Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "Remove Call to _ecore_evas_wayland_resize on a configure event."
On 08/20/13 17:03, Michael Blumenkrantz wrote: > On Tue, 20 Aug 2013 08:57:10 -0700 > Rafael Antognolli - Enlightenment Git wrote: > >> antognolli pushed a commit to branch master. >> >> commit ffa9d69180bd6db11aa3cdd06977f291d411734b >> Author: Rafael Antognolli >> Date: Wed Aug 21 12:55:14 2013 -0300 >> >> Revert "Remove Call to _ecore_evas_wayland_resize on a configure event." >> >> This reverts commit 5eeb820b0fd7fdaef0c29dc6a53870e5ee436fbf. >> --- >> src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git >> a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c >> b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c >> index a87bc85..1a94b83 100644 >> --- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c >> +++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c >> @@ -272,6 +272,8 @@ _ecore_evas_wl_common_cb_window_configure(void *data >> EINA_UNUSED, int type EINA_ >> >>win->server_allocation = win->allocation; >>ecore_wl_window_update_size(wdata->win, ev->w, ev->h); >> + >> + _ecore_evas_wayland_resize(ee, win->edges); >> } >> >> if (wdata->frame) >> > that's gonna be a problem. > Indeed. Will look into it in the morning...tho without this call, mouse resize was working fine /me ponders... dh -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "Remove Call to _ecore_evas_wayland_resize on a configure event."
I'm sorry, not sure how to fix it without this, but if we remove this line, the resize to left/top with + is broken. If you have any idea for a better solution, I'm all up for it, but so far if this is removed, we have broken behavior. I can take a look at it later (another day), but resize is a very complex code, whatever you change you also need to check lots of things. For instance, resize with middle click, dragging the edje of the window, both engines, check when the window is rotated, etc. On Tue, Aug 20, 2013 at 12:57 PM, Rafael Antognolli - Enlightenment Git wrote: > antognolli pushed a commit to branch master. > > commit ffa9d69180bd6db11aa3cdd06977f291d411734b > Author: Rafael Antognolli > Date: Wed Aug 21 12:55:14 2013 -0300 > > Revert "Remove Call to _ecore_evas_wayland_resize on a configure event." > > This reverts commit 5eeb820b0fd7fdaef0c29dc6a53870e5ee436fbf. > --- > src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > index a87bc85..1a94b83 100644 > --- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > +++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > @@ -272,6 +272,8 @@ _ecore_evas_wl_common_cb_window_configure(void *data > EINA_UNUSED, int type EINA_ > > win->server_allocation = win->allocation; > ecore_wl_window_update_size(wdata->win, ev->w, ev->h); > + > + _ecore_evas_wayland_resize(ee, win->edges); >} > > if (wdata->frame) > > -- > > -- > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk -- Rafael Antognolli -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "Remove Call to _ecore_evas_wayland_resize on a configure event."
On Tue, 20 Aug 2013 08:57:10 -0700 Rafael Antognolli - Enlightenment Git wrote: > antognolli pushed a commit to branch master. > > commit ffa9d69180bd6db11aa3cdd06977f291d411734b > Author: Rafael Antognolli > Date: Wed Aug 21 12:55:14 2013 -0300 > > Revert "Remove Call to _ecore_evas_wayland_resize on a configure event." > > This reverts commit 5eeb820b0fd7fdaef0c29dc6a53870e5ee436fbf. > --- > src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > index a87bc85..1a94b83 100644 > --- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > +++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c > @@ -272,6 +272,8 @@ _ecore_evas_wl_common_cb_window_configure(void *data > EINA_UNUSED, int type EINA_ > > win->server_allocation = win->allocation; > ecore_wl_window_update_size(wdata->win, ev->w, ev->h); > + > + _ecore_evas_wayland_resize(ee, win->edges); >} > > if (wdata->frame) > that's gonna be a problem. -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel