Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: add json file support feature

2020-03-08 Thread Hermet Park
Ok, It makes sense. we gonna rename it to lottie. Thanks.

On Thu, Feb 27, 2020 at 11:48 PM Stefan Schmidt 
wrote:

> Hello.
>
> I somehow missed this one.
>
> On 17.02.20 11:12, Carsten Haitzler (The Rasterman) wrote:
> > On Mon, 17 Feb 2020 02:02:51 -0800 YoungBok Shin 
> said:
> >
> > before we get too much further into this... just a naming and confusion
> thing.
> > shouldn't we refer to this as little support, not json? yes - the actual
> > encoding of data in lottie files is in json but it is not a generic
> thing. like
> > svg is not referred to as "xml support". :)
> >
> > shouldn't we adapt the name of our loaders, config options and all of
> the docs
> > and info to refer to this as lottie support as that's what it all really
> is?
>
> I agree here. While this loads a json file lotie format is what it
> really loads and assume here.
>
> YoungBok, Hermet could you have a look in renaming the flag and loader
> name to lottie?
>
> regards
> Stefan Schmidt
>
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>


-- 
Regards, Hermet

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: add json file support feature

2020-02-27 Thread Stefan Schmidt

Hello.

I somehow missed this one.

On 17.02.20 11:12, Carsten Haitzler (The Rasterman) wrote:

On Mon, 17 Feb 2020 02:02:51 -0800 YoungBok Shin  said:

before we get too much further into this... just a naming and confusion thing.
shouldn't we refer to this as little support, not json? yes - the actual
encoding of data in lottie files is in json but it is not a generic thing. like
svg is not referred to as "xml support". :)

shouldn't we adapt the name of our loaders, config options and all of the docs
and info to refer to this as lottie support as that's what it all really is?


I agree here. While this loads a json file lotie format is what it 
really loads and assume here.


YoungBok, Hermet could you have a look in renaming the flag and loader 
name to lottie?


regards
Stefan Schmidt


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: add json file support feature

2020-02-17 Thread The Rasterman
On Mon, 17 Feb 2020 02:02:51 -0800 YoungBok Shin  said:

before we get too much further into this... just a naming and confusion thing.
shouldn't we refer to this as little support, not json? yes - the actual
encoding of data in lottie files is in json but it is not a generic thing. like
svg is not referred to as "xml support". :)

shouldn't we adapt the name of our loaders, config options and all of the docs
and info to refer to this as lottie support as that's what it all really is?

:)

> hermet pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=2fe158ce652860b2aa5a2e883e6b2beb0ee1c670
> 
> commit 2fe158ce652860b2aa5a2e883e6b2beb0ee1c670
> Author: YoungBok Shin 
> Date:   Mon Feb 17 18:59:09 2020 +0900
> 
> edje: add json file support feature
> 
> Summary:
> It also starts to support following new edc properties.
> This is backported patch from Tizen 5.0
> 
> 1. frame
> desc { "default"
>vector {
>   frame: 0.5; // 0.0 ~ 1.0
>}
> }
> 
> 2. actions
> program { "vector_animation";
>// VG_ANIM_PLAY, VG_ANIM_PLAY_BACK, VG_ANIM_LOOP,
>// VG_ANIM_STOP, VG_ANIM_PAUSE, VG_ANIM_RESUME
>action: VG_ANIM_PLAY;
>target: "your_vector_part";
> }
> 
> @feature
> 
> Co-authored-by: Jaehyun Cho 
>   - Fix to remove Efl.Canvas.Animation_Player on edje
> 
> Test Plan:
> {F3840540}
> {F3840542}
> {F3840543}
> make and test attached file
> 
> edje_cc -beta -id ./ json_edc.edc json.edj
> gcc -o test test_edc.c -g `pkg-config --cflags --libs evas elementary
> rlottie` ./test
> 
> Reviewers: Hermet, Jaehyun_Cho, id213sin
> 
> Reviewed By: Hermet
> 
> Subscribers: segfaultxavi, raster, cedric, #reviewers, #committers
> 
> Tags: #efl
> 
> Differential Revision: https://phab.enlightenment.org/D11228
> ---
>  src/bin/edje/edje_cc_handlers.c |  56 +++
>  src/bin/edje/edje_cc_out.c  |  51 +++---
>  src/lib/edje/Edje_Common.h  |   8 ++-
>  src/lib/edje/edje_calc.c| 150 +
> +-- src/lib/edje/edje_data.c|   3 +
>  src/lib/edje/edje_load.c|  20 ++
>  src/lib/edje/edje_private.h |  32 -
>  src/lib/edje/edje_program.c |  72 +++
>  8 files changed, 371 insertions(+), 21 deletions(-)
> 
> diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c
> index 6b7ec172e7..59a0f377a8 100644
> --- a/src/bin/edje/edje_cc_handlers.c
> +++ b/src/bin/edje/edje_cc_handlers.c
> @@ -516,6 +516,9 @@ static void
> st_collections_group_parts_part_description_params_bool(void); static
> void   st_collections_group_parts_part_description_params_choice(void);
> static void
> st_collections_group_parts_part_description_params_smart(void); +/* vector
> part parameter */ +static void
> st_collections_group_parts_part_description_vector_frame(void); +
>  static void   ob_collections_group_programs_program(void);
>  static void   st_collections_group_programs_program_name(void);
>  static void   st_collections_group_programs_program_signal(void);
> @@ -1047,6 +1050,7 @@ New_Statement_Handler statement_handlers[] =
> {"collections.group.parts.part.description.params.bool",
> st_collections_group_parts_part_description_params_bool},
> {"collections.group.parts.part.description.params.choice",
> st_collections_group_parts_part_description_params_choice},
> {"collections.group.parts.part.description.params.*",
> st_collections_group_parts_part_description_params_smart},
> +   {"collections.group.parts.part.description.vector.frame",
> st_collections_group_parts_part_description_vector_frame},
> IMAGE_STATEMENTS("collections.group.parts.part.description.") {
>"collections.group.parts.part.description.font", st_fonts_font
> @@ -1590,6 +1594,7 @@ New_Object_Handler object_handlers[] =
> {"collections.group.parts.part.description.map.zoom", NULL},
> {"collections.group.parts.part.description.perspective", NULL},
> {"collections.group.parts.part.description.params", NULL},
> +   {"collections.group.parts.part.description.vector", NULL},
> {"collections.group.parts.part.description.color_classes", NULL},   /*
> dup */ {"collections.group.parts.part.description.color_classes.color_class",
> ob_color_class},   /* dup */
> {"collections.group.parts.part.description.text_classes", NULL},   /* dup */
> @@ -2545,6 +2550,7 @@ _handle_vector_image(void) {
>   ed->vg.set = EINA_TRUE;
>   ed->vg.id = edje_file->image_dir->vectors[i].id;
> + ed->vg.type = edje_file->image_dir->vectors[i].type;
>   break;
>}
>   }
> @@ -2587,6 +2593,7 @@ st_images_vector(void)
> Edje_Vector_Directory_Entry *vector;
> const char *tmp;
> unsigned int i;
> +   size_t entry_len;
>  
>