Re: [E-devel] [EGIT] [core/efl] master 04/06: ecore/wayland: Add and initialize subcompositor inside Ecore_Wayland.
Hello. On 10/10/2013 09:11 PM, Rafael Antognolli wrote: On Thu, Oct 10, 2013 at 3:32 PM, Rafael Antognolli rafael.antogno...@intel.com wrote: antognolli pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1cef77bfd784772539a39 5363b3aecbd3c2655d5 commit 1cef77bfd784772539a395363b3aecbd3c2655d5 Author: Rafael Antognolli rafael.antogno...@intel.com Date: Sat Aug 31 15:20:22 2013 -0300 ecore/wayland: Add and initialize subcompositor inside Ecore_Wayland. --- src/lib/ecore_wayland/Ecore_Wayland.h | 2 ++ src/lib/ecore_wayland/ecore_wl.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/src/lib/ecore_wayland/Ecore_Wayland.h b/src/lib/ecore_wayland/Ecore_Wayland.h index 05ceb00..c9b3e1f 100644 --- a/src/lib/ecore_wayland/Ecore_Wayland.h +++ b/src/lib/ecore_wayland/Ecore_Wayland.h @@ -12,6 +12,7 @@ # include wayland-client.h # include wayland-cursor.h # include xkbcommon/xkbcommon.h +# include subsurface-client-protocol.h OK, just noticed that this will probably break again, It does indeed. lib/ecore_wayland/ecore_wl.c: In function '_ecore_wl_cb_handle_global': lib/ecore_wayland/ecore_wl.c:524:44: error: 'wl_subcompositor_interface' undeclared (first use in this function) lib/ecore_wayland/ecore_wl.c:524:44: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [lib/ecore_wayland/lib_ecore_wayland_libecore_wayland_la-ecore_wl.lo] Error 1 since this header is not installed. Not sure why it didn't yet, when building Elementary. What is your setup that it does build for you? Last time you broke th build with this patchset you wrote it worked for you. I wonder how as it breaks every time for me. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 04/06: ecore/wayland: Add and initialize subcompositor inside Ecore_Wayland.
Hello. On 10/11/2013 07:28 AM, Stefan Schmidt wrote: Hello. On 10/10/2013 09:11 PM, Rafael Antognolli wrote: On Thu, Oct 10, 2013 at 3:32 PM, Rafael Antognolli rafael.antogno...@intel.com wrote: antognolli pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1cef77bfd784772539a39 5363b3aecbd3c2655d5 commit 1cef77bfd784772539a395363b3aecbd3c2655d5 Author: Rafael Antognolli rafael.antogno...@intel.com Date: Sat Aug 31 15:20:22 2013 -0300 ecore/wayland: Add and initialize subcompositor inside Ecore_Wayland. --- src/lib/ecore_wayland/Ecore_Wayland.h | 2 ++ src/lib/ecore_wayland/ecore_wl.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/src/lib/ecore_wayland/Ecore_Wayland.h b/src/lib/ecore_wayland/Ecore_Wayland.h index 05ceb00..c9b3e1f 100644 --- a/src/lib/ecore_wayland/Ecore_Wayland.h +++ b/src/lib/ecore_wayland/Ecore_Wayland.h @@ -12,6 +12,7 @@ # include wayland-client.h # include wayland-cursor.h # include xkbcommon/xkbcommon.h +# include subsurface-client-protocol.h OK, just noticed that this will probably break again, It does indeed. lib/ecore_wayland/ecore_wl.c: In function '_ecore_wl_cb_handle_global': lib/ecore_wayland/ecore_wl.c:524:44: error: 'wl_subcompositor_interface' undeclared (first use in this function) lib/ecore_wayland/ecore_wl.c:524:44: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [lib/ecore_wayland/lib_ecore_wayland_libecore_wayland_la-ecore_wl.lo] Error 1 My fault. See below. since this header is not installed. Not sure why it didn't yet, when building Elementary. What is your setup that it does build for you? Last time you broke th build with this patchset you wrote it worked for you. I wonder how as it breaks every time for me. Ignore me on this. Sorry for bothering you. It was a local problem. Did not have wayland-scanner in path thus an empty header was generated. I fixed the scanner problem but the header was already there and not overridden before I did a complete clean build. All this while battling with E crashes due to one of Cedrics changes. Excuses I know. :) regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 04/06: ecore/wayland: Add and initialize subcompositor inside Ecore_Wayland.
On Thu, Oct 10, 2013 at 3:32 PM, Rafael Antognolli
rafael.antogno...@intel.com wrote:
antognolli pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=1cef77bfd784772539a395363b3aecbd3c2655d5
commit 1cef77bfd784772539a395363b3aecbd3c2655d5
Author: Rafael Antognolli rafael.antogno...@intel.com
Date: Sat Aug 31 15:20:22 2013 -0300
ecore/wayland: Add and initialize subcompositor inside Ecore_Wayland.
---
src/lib/ecore_wayland/Ecore_Wayland.h | 2 ++
src/lib/ecore_wayland/ecore_wl.c | 7 +++
2 files changed, 9 insertions(+)
diff --git a/src/lib/ecore_wayland/Ecore_Wayland.h
b/src/lib/ecore_wayland/Ecore_Wayland.h
index 05ceb00..c9b3e1f 100644
--- a/src/lib/ecore_wayland/Ecore_Wayland.h
+++ b/src/lib/ecore_wayland/Ecore_Wayland.h
@@ -12,6 +12,7 @@
# include wayland-client.h
# include wayland-cursor.h
# include xkbcommon/xkbcommon.h
+# include subsurface-client-protocol.h
OK, just noticed that this will probably break again, since this
header is not installed. Not sure why it didn't yet, when building
Elementary.
So, Devilhorns, what about putting all these internal pointers and
structs hidden inside ecore_wl_private.h, or something like that? I
don't think they should be exposed at all...
# ifdef EAPI
# undef EAPI
@@ -101,6 +102,7 @@ struct _Ecore_Wl_Display
struct wl_display *display;
struct wl_registry *registry;
struct wl_compositor *compositor;
+struct wl_subcompositor *subcompositor;
struct wl_shell *shell;
struct wl_shell *desktop_shell;
struct wl_shm *shm;
diff --git a/src/lib/ecore_wayland/ecore_wl.c
b/src/lib/ecore_wayland/ecore_wl.c
index acce728..acc5988 100644
--- a/src/lib/ecore_wayland/ecore_wl.c
+++ b/src/lib/ecore_wayland/ecore_wl.c
@@ -397,6 +397,8 @@ _ecore_wl_shutdown(Eina_Bool close)
wl_data_device_manager_destroy(_ecore_wl_disp-wl.data_device_manager);
if (_ecore_wl_disp-wl.compositor)
wl_compositor_destroy(_ecore_wl_disp-wl.compositor);
+if (_ecore_wl_disp-wl.subcompositor)
+ wl_compositor_destroy(_ecore_wl_disp-wl.subcompositor);
if (_ecore_wl_disp-wl.display)
{
wl_registry_destroy(_ecore_wl_disp-wl.registry);
@@ -515,6 +517,11 @@ _ecore_wl_cb_handle_global(void *data, struct
wl_registry *registry, unsigned in
ewd-wl.compositor =
wl_registry_bind(registry, id, wl_compositor_interface, 3);
}
+ else if (!strcmp(interface, wl_subcompositor))
+ {
+ewd-wl.subcompositor =
+ wl_registry_bind(registry, id, wl_subcompositor_interface, 1);
+ }
else if (!strcmp(interface, wl_output))
_ecore_wl_output_add(ewd, id);
else if (!strcmp(interface, wl_seat))
--
--
Rafael Antognolli
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
