Re: [E-devel] [EGIT] [core/elementary] elementary-1.15 01/05: popup: make scroller optional in popup
Hi Davide,
This is what I have been doing for this specific purpose.
https://git.enlightenment.org/core/elementary.git/tree/data/themes/edc/elm/panes.edc#n1
data.item can be documented in the default theme.
Once we're ready, we should push this to the official widget
documentation or custom theme documentation.
Thanks,
Daniel (SeoZ)
On Wed, Aug 19, 2015 at 3:41 AM, Davide Andreoli d...@gurumeditation.it wrote:
2015-08-18 19:46 GMT+02:00 Amitesh Singh amitesh...@samsung.com:
ami pushed a commit to branch elementary-1.15.
http://git.enlightenment.org/core/elementary.git/commit/?id=c0bb755269da986df4255a6b8c8e7d99f10fb3a1
commit c0bb755269da986df4255a6b8c8e7d99f10fb3a1
Author: Amitesh Singh amitesh...@samsung.com
Date: Sat Aug 15 21:02:33 2015 +0530
popup: make scroller optional in popup
Summary:
@feature
Resolves: T2651
Test Plan:
1. elementary_test -to popup
2. Enable/disable checkbox named Enable popup scoller
Reviewers: raster, herb, herdsman, SanghyeonLee, tasn, simotek,
cedric, jeffhoogland
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2945
---
data/themes/edc/elm/popup.edc| 17 +++-
data/themes/edc/elm/scroller.edc | 3 +-
src/bin/test_popup.c | 43 +
src/lib/elc_popup.c | 182
++-
src/lib/elm_popup.eo | 21 +
src/lib/elm_widget_popup.h | 2 +
6 files changed, 225 insertions(+), 43 deletions(-)
diff --git a/data/themes/edc/elm/popup.edc b/data/themes/edc/elm/popup.edc
index 2ac2594..e49 100644
--- a/data/themes/edc/elm/popup.edc
+++ b/data/themes/edc/elm/popup.edc
@@ -367,11 +367,26 @@ group { name: elm/popup/base/default;
group { name: elm/popup/content/popup/default;
alias: elm/popup/content/popup/transparent;
alias: elm/popup/content/popup/subpopup;
+ data.item: scroller_enable on;
so, at the end you backported with the wrong name :(
the data item should have be done as:
data.item: scroller_available yes;
This kind of stuff are part of our api, they are also not documented,
how can we expect developers/theres will be able to understand
the meaning?
parts {
part { name:elm.swallow.content; type: SWALLOW;
description { state: default 0.0;
- min: 240 0;
}
+ description { state: scroll 0.0;
+min: 240 0;
+ }
+ }
+ }
+ programs {
+ program {
+ signal: elm,scroll,enable; source: elm;
+ action: STATE_SET scroll 0.0;
+ target: elm.swallow.content;
+ }
+ program {
+ signal: elm,scroll,disable; source: elm;
+ action: STATE_SET default 0.0;
+ target: elm.swallow.content;
}
}
}
diff --git a/data/themes/edc/elm/scroller.edc
b/data/themes/edc/elm/scroller.edc
index cf1cb99..2f3d699 100644
--- a/data/themes/edc/elm/scroller.edc
+++ b/data/themes/edc/elm/scroller.edc
@@ -1308,8 +1308,7 @@ group { name: elm/scroller/contents/default;
group { name: elm/scroller/base/popup/no_inset_shadow;
inherit: elm/scroller/base/default;
parts {
- part { name: elm.swallow.content;
- type: SWALLOW;
+ part { name: elm.swallow.content; type: SWALLOW;
description { state: default 0.0;
rel1.offset: 0 0;
rel2.offset: 0 0;
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index 32712ac..d7c9799 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -13,6 +13,7 @@ typedef struct
static Evas_Object *g_popup = NULL;
static int times = 0;
+static Eina_Bool is_popup_scroll;
static Evas_Rel_Coord_Point _popup_point[POPUP_POINT_MAX] =
{
{ 0.01, 0.01 },
@@ -122,6 +123,7 @@ _popup_center_text_cb(void *data, Evas_Object *obj
EINA_UNUSED,
Evas_Object *popup;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
elm_object_text_set(popup, This Popup has content area and
timeout value is 3 seconds);
elm_popup_timeout_set(popup, 3.0);
@@ -142,6 +144,7 @@ _popup_center_text_1button_cb(void *data, Evas_Object
*obj EINA_UNUSED,
Evas_Object *btn;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
elm_object_text_set(popup, This Popup has content area and
action area set, action area has one button
Close);
@@ -164,6 +167,7 @@ _popup_center_title_text_1button_cb(void *data,
Evas_Object *obj EINA_UNUSED,
Evas_Object *btn;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
// popup text
elm_object_text_set(popup, This Popup has title area, content area
and
@@ -190,6 +194,7 @@ _popup_center_title_text_block_clicked_event_cb(void
*data,
Evas_Object *popup;
popup = elm_popup_add(data);
+
Re: [E-devel] [EGIT] [core/elementary] elementary-1.15 01/05: popup: make scroller optional in popup
Hello.
On 18/08/15 20:41, Davide Andreoli wrote:
2015-08-18 19:46 GMT+02:00 Amitesh Singh amitesh...@samsung.com:
ami pushed a commit to branch elementary-1.15.
http://git.enlightenment.org/core/elementary.git/commit/?id=c0bb755269da986df4255a6b8c8e7d99f10fb3a1
commit c0bb755269da986df4255a6b8c8e7d99f10fb3a1
Author: Amitesh Singh amitesh...@samsung.com
Date: Sat Aug 15 21:02:33 2015 +0530
popup: make scroller optional in popup
Summary:
@feature
Resolves: T2651
Test Plan:
1. elementary_test -to popup
2. Enable/disable checkbox named Enable popup scoller
Reviewers: raster, herb, herdsman, SanghyeonLee, tasn, simotek,
cedric, jeffhoogland
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2945
---
data/themes/edc/elm/popup.edc| 17 +++-
data/themes/edc/elm/scroller.edc | 3 +-
src/bin/test_popup.c | 43 +
src/lib/elc_popup.c | 182
++-
src/lib/elm_popup.eo | 21 +
src/lib/elm_widget_popup.h | 2 +
6 files changed, 225 insertions(+), 43 deletions(-)
diff --git a/data/themes/edc/elm/popup.edc b/data/themes/edc/elm/popup.edc
index 2ac2594..e49 100644
--- a/data/themes/edc/elm/popup.edc
+++ b/data/themes/edc/elm/popup.edc
@@ -367,11 +367,26 @@ group { name: elm/popup/base/default;
group { name: elm/popup/content/popup/default;
alias: elm/popup/content/popup/transparent;
alias: elm/popup/content/popup/subpopup;
+ data.item: scroller_enable on;
so, at the end you backported with the wrong name :(
the data item should have be done as:
data.item: scroller_available yes;
This kind of stuff are part of our api, they are also not documented,
how can we expect developers/theres will be able to understand
the meaning?
Ami, are you going to change this?
regards
Stefan Schmidt
--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] elementary-1.15 01/05: popup: make scroller optional in popup
2015-08-18 19:46 GMT+02:00 Amitesh Singh amitesh...@samsung.com:
ami pushed a commit to branch elementary-1.15.
http://git.enlightenment.org/core/elementary.git/commit/?id=c0bb755269da986df4255a6b8c8e7d99f10fb3a1
commit c0bb755269da986df4255a6b8c8e7d99f10fb3a1
Author: Amitesh Singh amitesh...@samsung.com
Date: Sat Aug 15 21:02:33 2015 +0530
popup: make scroller optional in popup
Summary:
@feature
Resolves: T2651
Test Plan:
1. elementary_test -to popup
2. Enable/disable checkbox named Enable popup scoller
Reviewers: raster, herb, herdsman, SanghyeonLee, tasn, simotek,
cedric, jeffhoogland
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2945
---
data/themes/edc/elm/popup.edc| 17 +++-
data/themes/edc/elm/scroller.edc | 3 +-
src/bin/test_popup.c | 43 +
src/lib/elc_popup.c | 182
++-
src/lib/elm_popup.eo | 21 +
src/lib/elm_widget_popup.h | 2 +
6 files changed, 225 insertions(+), 43 deletions(-)
diff --git a/data/themes/edc/elm/popup.edc b/data/themes/edc/elm/popup.edc
index 2ac2594..e49 100644
--- a/data/themes/edc/elm/popup.edc
+++ b/data/themes/edc/elm/popup.edc
@@ -367,11 +367,26 @@ group { name: elm/popup/base/default;
group { name: elm/popup/content/popup/default;
alias: elm/popup/content/popup/transparent;
alias: elm/popup/content/popup/subpopup;
+ data.item: scroller_enable on;
so, at the end you backported with the wrong name :(
the data item should have be done as:
data.item: scroller_available yes;
This kind of stuff are part of our api, they are also not documented,
how can we expect developers/theres will be able to understand
the meaning?
parts {
part { name:elm.swallow.content; type: SWALLOW;
description { state: default 0.0;
- min: 240 0;
}
+ description { state: scroll 0.0;
+min: 240 0;
+ }
+ }
+ }
+ programs {
+ program {
+ signal: elm,scroll,enable; source: elm;
+ action: STATE_SET scroll 0.0;
+ target: elm.swallow.content;
+ }
+ program {
+ signal: elm,scroll,disable; source: elm;
+ action: STATE_SET default 0.0;
+ target: elm.swallow.content;
}
}
}
diff --git a/data/themes/edc/elm/scroller.edc
b/data/themes/edc/elm/scroller.edc
index cf1cb99..2f3d699 100644
--- a/data/themes/edc/elm/scroller.edc
+++ b/data/themes/edc/elm/scroller.edc
@@ -1308,8 +1308,7 @@ group { name: elm/scroller/contents/default;
group { name: elm/scroller/base/popup/no_inset_shadow;
inherit: elm/scroller/base/default;
parts {
- part { name: elm.swallow.content;
- type: SWALLOW;
+ part { name: elm.swallow.content; type: SWALLOW;
description { state: default 0.0;
rel1.offset: 0 0;
rel2.offset: 0 0;
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index 32712ac..d7c9799 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -13,6 +13,7 @@ typedef struct
static Evas_Object *g_popup = NULL;
static int times = 0;
+static Eina_Bool is_popup_scroll;
static Evas_Rel_Coord_Point _popup_point[POPUP_POINT_MAX] =
{
{ 0.01, 0.01 },
@@ -122,6 +123,7 @@ _popup_center_text_cb(void *data, Evas_Object *obj
EINA_UNUSED,
Evas_Object *popup;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
elm_object_text_set(popup, This Popup has content area and
timeout value is 3 seconds);
elm_popup_timeout_set(popup, 3.0);
@@ -142,6 +144,7 @@ _popup_center_text_1button_cb(void *data, Evas_Object
*obj EINA_UNUSED,
Evas_Object *btn;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
elm_object_text_set(popup, This Popup has content area and
action area set, action area has one button
Close);
@@ -164,6 +167,7 @@ _popup_center_title_text_1button_cb(void *data,
Evas_Object *obj EINA_UNUSED,
Evas_Object *btn;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
// popup text
elm_object_text_set(popup, This Popup has title area, content area
and
@@ -190,6 +194,7 @@ _popup_center_title_text_block_clicked_event_cb(void
*data,
Evas_Object *popup;
popup = elm_popup_add(data);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
evas_object_smart_callback_add(popup, block,clicked,
_block_clicked_cb,
NULL);
@@ -219,6 +224,7 @@
_popup_center_title_text_block_clicked_event_with_parent_cb(void *data,
evas_object_show(bg);
popup = elm_popup_add(bg);
+ elm_popup_scrollable_set(popup, is_popup_scroll);
evas_object_smart_callback_add(popup, block,clicked,
