Re: [E-devel] [PATCH] elm_entry: Add backward-compatible for elm_entry_magnifier_disabled_set
Carsten Haitzler's opinion is exactly right. This patch does not do anything useful and this is not even backwas-compatibility. I have to say sorry. Daniel Juyung Seo (SeoZ) On Mon, Sep 3, 2012 at 3:46 PM, Carsten Haitzler ras...@rasterman.com wrote: On Fri, 31 Aug 2012 10:37:40 +0800 Alex Wu zhiwen...@linux.intel.com said: Hi, Due to some legacy applications use elm_entry_magnifier_disabled_set(), add the fake function in order to be backward-compatible. ok. here comes the rub. elm never had such an api. this was a custom fork done without review from upstream (the open source side). from that point of view we can only reject such a patch. sorry. any app using such an api should be modified or the project (tizen in this case) needs to carry the patch forever. this is the price of making a fork then continuing that fork in private and making everything depend on it and never pushing your work back upstream. thought i'd like to be nice and say yes, this is a lesson that must be learned and thus this is a no. this is nothing new in the linux world. many a kernel, glibc, xorg, gtk, etc. patch has been rejected and needed re-doing and anything depending on that patch would have needed adjustment too. the solution is to push early, push often. :) let upstream know what you are doing AS you do it. until it's approved and in don't depend on it. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] elm_entry: Add backward-compatible for elm_entry_magnifier_disabled_set
On Fri, 31 Aug 2012 10:37:40 +0800 Alex Wu zhiwen...@linux.intel.com said: Hi, Due to some legacy applications use elm_entry_magnifier_disabled_set(), add the fake function in order to be backward-compatible. ok. here comes the rub. elm never had such an api. this was a custom fork done without review from upstream (the open source side). from that point of view we can only reject such a patch. sorry. any app using such an api should be modified or the project (tizen in this case) needs to carry the patch forever. this is the price of making a fork then continuing that fork in private and making everything depend on it and never pushing your work back upstream. thought i'd like to be nice and say yes, this is a lesson that must be learned and thus this is a no. this is nothing new in the linux world. many a kernel, glibc, xorg, gtk, etc. patch has been rejected and needed re-doing and anything depending on that patch would have needed adjustment too. the solution is to push early, push often. :) let upstream know what you are doing AS you do it. until it's approved and in don't depend on it. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] elm_entry: Add backward-compatible for elm_entry_magnifier_disabled_set
Hi,
Due to some legacy applications use elm_entry_magnifier_disabled_set(),
add the fake function in order to be backward-compatible.
From f7c29dccda83c64f76727f983d4c2a1138b71e8f Mon Sep 17 00:00:00 2001
From: Alex Wu zhiwen...@linux.intel.com
Date: Fri, 31 Aug 2012 10:28:48 +0800
Subject: [PATCH] elm_entry: Add backward-compatible for
elm_entry_magnifier_disabled_set
Due to some legacy applications use elm_entry_magnifier_disabled_set(),
add the fake function in order to be backward-compatible.
---
trunk/elementary/src/lib/elm_entry.c |5 +
trunk/elementary/src/lib/elm_entry.h |9 +
2 files changed, 14 insertions(+)
diff --git a/trunk/elementary/src/lib/elm_entry.c
b/trunk/elementary/src/lib/elm_entry.c
index a6d1fa9..c474b67 100644
--- a/trunk/elementary/src/lib/elm_entry.c
+++ b/trunk/elementary/src/lib/elm_entry.c
@@ -4001,6 +4001,11 @@ elm_entry_anchor_hover_end(Evas_Object *obj)
wd-anchor_hover.pop = NULL;
}
+EAPI void
+elm_entry_magnifier_disabled_set(Evas_Object *obj, Eina_Bool disabled)
+{
+ /* Do nothing, just for backward-compatible. */
+}
static void
_anchor_hover_clicked(void *data, Evas_Object *obj __UNUSED__, void
*event_info __UNUSED__)
diff --git a/trunk/elementary/src/lib/elm_entry.h
b/trunk/elementary/src/lib/elm_entry.h
index 4ace8a1..75f1be2 100644
--- a/trunk/elementary/src/lib/elm_entry.h
+++ b/trunk/elementary/src/lib/elm_entry.h
@@ -1773,5 +1773,14 @@ EAPI const char
*elm_entry_anchor_hover_style_get(const Evas_Obj
EAPI voidelm_entry_anchor_hover_end(Evas_Object *obj);
/**
+ * Do nothing, just for backward-compatible.
+ *
+ * @param obj The entry object
+ * @param disabled If true, the magnifier is not displayed
+ */
+
+EAPI voidelm_entry_magnifier_disabled_set(Evas_Object
*obj, Eina_Bool disabled);
+
+/**
* @}
*/
--
1.7.9.5
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
