Re: [E-devel] [Patch] small patch for elm_main.c
On Wed, 19 Jan 2011 18:31:42 +0900 WooHyun Jung wh0705.j...@samsung.com said: you're right! if you have no windows some caches won't be able to be flushed :) in svn! Hello ~ I made small patch for elm_main.c In elm_all_flush function, I was suspicious about, if _elm_win_list is NULL then following codes should not be called or not. ejde_file_cache_flush(); edje_collection_cache_flush(); eet_clearcache(); I thinks above functions should be called without any consideration about the state of _elm_win_list. Can anybody check about this ? Thanks. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] small patch for elm_main.c
Hello ~
I made small patch for elm_main.c
In elm_all_flush function, I was suspicious about,
if _elm_win_list is NULL then following codes should not be called or not.
ejde_file_cache_flush();
edje_collection_cache_flush();
eet_clearcache();
I thinks above functions should be called without any consideration about
the state of _elm_win_list.
Can anybody check about this ?
Thanks.
Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c (revision 56218)
+++ src/lib/elm_main.c (working copy)
@@ -1829,12 +1829,12 @@ elm_all_flush(void)
const Eina_List *l;
Evas_Object *obj;
+ edje_file_cache_flush();
+ edje_collection_cache_flush();
+ eet_clearcache();
EINA_LIST_FOREACH(_elm_win_list, l, obj)
{
Evas *e = evas_object_evas_get(obj);
-edje_file_cache_flush();
-edje_collection_cache_flush();
-eet_clearcache();
evas_image_cache_flush(e);
evas_font_cache_flush(e);
evas_render_dump(e);
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] small patch for elm_main.c
Hello ~
I made small patch for elm_main.c
In elm_all_flush function, I was suspicious about,
if _elm_win_list is NULL then following codes should not be called or not.
ejde_file_cache_flush();
edje_collection_cache_flush();
eet_clearcache();
I thinks above functions should be called without any consideration about
the state of _elm_win_list.
Can anybody check about this ?
Thanks.
Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c (revision 56218)
+++ src/lib/elm_main.c (working copy)
@@ -1829,12 +1829,12 @@ elm_all_flush(void)
const Eina_List *l;
Evas_Object *obj;
+ edje_file_cache_flush();
+ edje_collection_cache_flush();
+ eet_clearcache();
EINA_LIST_FOREACH(_elm_win_list, l, obj)
{
Evas *e = evas_object_evas_get(obj);
-edje_file_cache_flush();
-edje_collection_cache_flush();
-eet_clearcache();
evas_image_cache_flush(e);
evas_font_cache_flush(e);
evas_render_dump(e);
--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] small patch for elm_main.c
On 12/24/2010 12:17 AM, WooHyun Jung wrote: Hello ~ all. I found one small bug in elm_main.c exe is used just after free(exe). (in elm_quicklaunch_prepare() function) Can anybody check about this ? Thanks. In Svn. Thanks :) dh -- If C gives you enough rope to hang yourself, then C++ gives you enough rope to bind and gag your neighborhood, rig the sails on a small ship, and still have enough rope to hang yourself from the yardarm - Anonymous quote from the The UNIX-HATERS Handbook -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] small patch for elm_main.c
Hello ~ all.
I found one small bug in elm_main.c
exe is used just after free(exe). (in elm_quicklaunch_prepare()
function)
Can anybody check about this ?
Thanks.
Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c (revision 55742)
+++ src/lib/elm_main.c (working copy)
@@ -755,7 +755,6 @@ elm_quicklaunch_prepare(int argc __UNUSED__,
return EINA_FALSE;
}
INF(dlopen('%s') = %p, exe, qr_handle);
- free(exe);
qr_main = dlsym(qr_handle, elm_main);
INF(dlsym(%p, 'elm_main') = %p, qr_handle, qr_main);
if (!qr_main)
@@ -763,8 +762,10 @@ elm_quicklaunch_prepare(int argc __UNUSED__,
WRN(not quicklauncher capable: no elm_main in '%s', exe);
dlclose(qr_handle);
qr_handle = NULL;
+ free(exe);
return EINA_FALSE;
}
+ free(exe);
return EINA_TRUE;
#else
return EINA_FALSE;
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
