Re: [E-devel] E SVN: caro trunk/edje/src/lib
On Thu, Jan 14, 2010 at 4:47 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: use HUGE_VAL instead of a strange double/float numerical value do I have to add -lm to Libs in edje.pc ? Wouldn't that be to link to the library? Shouldn't be needed if you only use the header. Author: caro Date: 2010-01-14 11:47:08 -0800 (Thu, 14 Jan 2010) New Revision: 45119 Modified: trunk/edje/src/lib/Edje.h Modified: trunk/edje/src/lib/Edje.h === --- trunk/edje/src/lib/Edje.h 2010-01-14 18:52:55 UTC (rev 45118) +++ trunk/edje/src/lib/Edje.h 2010-01-14 19:47:08 UTC (rev 45119) @@ -261,7 +261,7 @@ typedef struct _Edje_External_Param Edje_External_Param; #define EDJE_EXTERNAL_INT_UNSET 0x -#define EDJE_EXTERNAL_DOUBLE_UNSET 0x1.0p255f +#define EDJE_EXTERNAL_DOUBLE_UNSET HUGE_VAL struct _Edje_External_Param_Info { -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
On Thu, 14 Jan 2010, Iván Briano (Sachiel) wrote: On Thu, Jan 14, 2010 at 4:47 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: use HUGE_VAL instead of a strange double/float numerical value do I have to add -lm to Libs in edje.pc ? Wouldn't that be to link to the library? Shouldn't be needed if you only use the header. when I looked at the header, i saw some references to __builtin_*** stuff Vincent-- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
On Thu, Jan 14, 2010 at 5:05 PM, Vincent Torri vto...@univ-evry.fr wrote: On Thu, 14 Jan 2010, Iván Briano (Sachiel) wrote: On Thu, Jan 14, 2010 at 4:47 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: use HUGE_VAL instead of a strange double/float numerical value do I have to add -lm to Libs in edje.pc ? Wouldn't that be to link to the library? Shouldn't be needed if you only use the header. when I looked at the header, i saw some references to __builtin_*** stuff http://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Other-Builtins.html#Other-Builtins No mention of -lm, but I'm just guessing that means it's not needed. We'll know for sure when someone complains. -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
2009/11/7 Peter Wehrfritz peter.wehrfr...@web.de Gustavo Sverzut Barbieri wrote: On Tue, Nov 3, 2009 at 7:26 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: * rename _edje_strbuf_append to _edje_strbuf_append1 and _edje_strbuf_append2 in edje_util.c and edje_textblock_styles.c respectiveley (for amalgamation. See next commit) well, I really think strbuf should be in eina, this would remove similar code from edje, evas and others... but since we don't have it, why not move it to a common edje_strbuf.x and include it in both, doing a single include in amalgamation? Rephorm added ecore_strbuf along time ago to ecore. I think his intention was to use it in efreet, but I don't think it is used anywhere. I tryed to use ecore_strbuf, some weeks ago, I then switched to another implementation because it was buggy... Some times the string loose the last char. Maybe we should remove the strbuf code from ecore. DaveMDS Peter -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
Gustavo Sverzut Barbieri wrote: On Tue, Nov 3, 2009 at 7:26 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: * rename _edje_strbuf_append to _edje_strbuf_append1 and _edje_strbuf_append2 in edje_util.c and edje_textblock_styles.c respectiveley (for amalgamation. See next commit) well, I really think strbuf should be in eina, this would remove similar code from edje, evas and others... but since we don't have it, why not move it to a common edje_strbuf.x and include it in both, doing a single include in amalgamation? Rephorm added ecore_strbuf along time ago to ecore. I think his intention was to use it in efreet, but I don't think it is used anywhere. Peter -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
On Tue, Nov 3, 2009 at 7:26 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: * rename _edje_strbuf_append to _edje_strbuf_append1 and _edje_strbuf_append2 in edje_util.c and edje_textblock_styles.c respectiveley (for amalgamation. See next commit) well, I really think strbuf should be in eina, this would remove similar code from edje, evas and others... but since we don't have it, why not move it to a common edje_strbuf.x and include it in both, doing a single include in amalgamation? -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
On Tue, 3 Nov 2009, Gustavo Sverzut Barbieri wrote: On Tue, Nov 3, 2009 at 7:26 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: * rename _edje_strbuf_append to _edje_strbuf_append1 and _edje_strbuf_append2 in edje_util.c and edje_textblock_styles.c respectiveley (for amalgamation. See next commit) well, I really think strbuf should be in eina, this would remove similar code from edje, evas and others... but since we don't have it, why not move it to a common edje_strbuf.x and include it in both, doing a single include in amalgamation? because i don't know edje code (well, just a bit). And iirc, we should clean up its code anyway, right ? Vincent-- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/edje/src/lib
Cedric told me that i can even removed, in edje_calc, the parameters that I have marked as unused. Is there an objection ? Vincent On Mon, 24 Aug 2009, Enlightenment SVN wrote: Log: * remove unused parameters (except in edje_lua.c, as i don't know the current status) * remove unused variables Author: caro Date: 2009-08-24 09:40:42 -0700 (Mon, 24 Aug 2009) New Revision: 41957 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_edit.c trunk/edje/src/lib/edje_entry.c trunk/edje/src/lib/edje_load.c trunk/edje/src/lib/edje_message_queue.c trunk/edje/src/lib/edje_script_only.c trunk/edje/src/lib/edje_textblock_styles.c trunk/edje/src/lib/edje_util.c trunk/edje/src/lib/edje_var.c Modified: trunk/edje/src/lib/edje_calc.c === --- trunk/edje/src/lib/edje_calc.c 2009-08-24 14:56:56 UTC (rev 41956) +++ trunk/edje/src/lib/edje_calc.c 2009-08-24 16:40:42 UTC (rev 41957) @@ -52,7 +52,7 @@ } Edje_Part_Description * -_edje_part_description_find(Edje *ed, Edje_Real_Part *rp, const char *name, +_edje_part_description_find(Edje *ed __UNUSED__, Edje_Real_Part *rp, const char *name, double val) { Edje_Part *ep = rp-part; @@ -293,7 +293,7 @@ static void _edje_part_recalc_single_rel(Edje *ed, -Edje_Real_Part *ep, +Edje_Real_Part *ep __UNUSED__, Edje_Part_Description *desc, Edje_Real_Part *rel1_to_x, Edje_Real_Part *rel1_to_y, @@ -1118,7 +1118,7 @@ Edje_Part_Description *desc, int *minw, int *minh, int *maxw, int *maxh, -int flags) +int flags __UNUSED__) { // if (flags FLAG_X) { @@ -1348,7 +1348,7 @@ } static void -_edje_gradient_recalc_apply(Edje *ed, Edje_Real_Part *ep, Edje_Calc_Params *p3, Edje_Part_Description *chosen_desc) +_edje_gradient_recalc_apply(Edje *ed, Edje_Real_Part *ep, Edje_Calc_Params *p3, Edje_Part_Description *chosen_desc __UNUSED__) { evas_object_gradient_fill_angle_set(ep-object, p3-type.common.fill.angle); evas_object_gradient_fill_spread_set(ep-object, p3-type.common.fill.spread); @@ -1383,7 +1383,7 @@ } static void -_edje_box_recalc_apply(Edje *ed, Edje_Real_Part *ep, Edje_Calc_Params *p3, Edje_Part_Description *chosen_desc) +_edje_box_recalc_apply(Edje *ed __UNUSED__, Edje_Real_Part *ep, Edje_Calc_Params *p3, Edje_Part_Description *chosen_desc) { Evas_Object_Box_Layout layout; void (*free_data)(void *data); @@ -1420,7 +1420,7 @@ } static void -_edje_table_recalc_apply(Edje *ed, Edje_Real_Part *ep, Edje_Calc_Params *p3, Edje_Part_Description *chosen_desc) +_edje_table_recalc_apply(Edje *ed __UNUSED__, Edje_Real_Part *ep, Edje_Calc_Params *p3 __UNUSED__, Edje_Part_Description *chosen_desc) { evas_object_table_homogeneous_set(ep-object, chosen_desc-table.homogeneous); evas_object_table_align_set(ep-object, chosen_desc-table.align.x, chosen_desc-table.align.y); Modified: trunk/edje/src/lib/edje_edit.c === --- trunk/edje/src/lib/edje_edit.c 2009-08-24 14:56:56 UTC (rev 41956) +++ trunk/edje/src/lib/edje_edit.c 2009-08-24 16:40:42 UTC (rev 41957) @@ -160,8 +160,6 @@ static void _edje_real_part_free(Edje_Real_Part *rp) { - Eina_List *l; - if (!rp) return; if (rp-object) @@ -1281,7 +1279,7 @@ edje_edit_style_tags_list_get(Evas_Object * obj, const char* style) { Eina_List *tags = NULL; - Eina_List *l, *ll; + Eina_List *l; Edje_Style *s; Edje_Style_Tag *t; @@ -1292,7 +1290,7 @@ s = _edje_edit_style_get(ed, style); printf(GET STYLE TAG LIST %d\n, eina_list_count(s-tags)); - EINA_LIST_FOREACH(s-tags, ll, t) + EINA_LIST_FOREACH(s-tags, l, t) tags = eina_list_append(tags, eina_stringshare_add(t-key)); return tags; @@ -3450,7 +3448,6 @@ Eina_List *l; Edje_Image_Directory_Entry *de; Edje_Image_Directory_Entry *i, *t; - int free_id = 0; GET_ED_OR_RETURN(0); Modified: trunk/edje/src/lib/edje_entry.c === --- trunk/edje/src/lib/edje_entry.c 2009-08-24 14:56:56 UTC (rev 41956) +++ trunk/edje/src/lib/edje_entry.c 2009-08-24 16:40:42 UTC (rev 41957) @@ -84,7 +84,7 @@ #ifdef HAVE_ECORE_IMF static void -_edje_entry_focus_in_cb(void *data, Evas_Object *o, const char *emission, const char *source) +_edje_entry_focus_in_cb(void *data, Evas_Object *o __UNUSED__, const char *emission __UNUSED__, const char *source __UNUSED__) { Edje_Real_Part *rp = data; if (!rp) return; @@ -104,7 +104,7 @@ } static void -_edje_entry_focus_out_cb(void *data, Evas_Object *o, const char *emission, const char *source) +_edje_entry_focus_out_cb(void
Re: [E-devel] E SVN: caro trunk/edje/src/lib
On Mon, Aug 24, 2009 at 2:22 PM, Vincent Torrivto...@univ-evry.fr wrote: Cedric told me that i can even removed, in edje_calc, the parameters that I have marked as unused. Is there an objection ? go for it! -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel