Hello Cedric,
On Tue, Sep 24, 2013 at 5:25 AM, Cedric BAIL cedric.b...@free.fr wrote:
Hello,
On Tue, Sep 24, 2013 at 8:28 AM, Jorge Luis Zapata Muga
jorgeluis.zap...@gmail.com wrote:
I applied the patches from the legacy tree
Hope this one is good enough
Yup, I just pushed them in with a few modification. We seems to be
putting _length and dup at the end of a function name, so renamed the
printf variant accordingly. In your eina rectangle change the variable
name remainder was already defined on my system, I did rename it to
leftover to have a still meaningful name and no clash.
Thanks for the changes
There seems to be two function eina_rectangle_max_x and
eina_rectangle_max_y that are not defined in eina_rectangle.h. Is it
voluntary ? Also, I am thinking we should maybe rename them and have
the _max as a suffix. Any opinion on that ?
Oh, I forgot about it. Btw, I was not sure about the name at the end we
usually put the subject before whatever verb/condition. It isnt better to
use
eina_rectangle_x_max and eina_rectangle_y_max?
Thanks for your submission, but you know that you still have a
developer access to efl git ! There is no problem if you push things
directly next time or create a branch directly on git.e.org.
Interesting, didnt know that my keys were ported to the phabricator system.
While i was looking at the eina code again, its been a while since i see
it, there seems to be several inconsistencies on how things are named and
some APIs that i dont think they should exist.
I don't remember all of them right now, but for example:
eina_rectangle_new()/eina_rectangle_free()? Looking at the code it looks
like it is a rectangle created with the rectangle pool, but why call it
without the pool prefix? as it should not be part of the rectangle API,
instead it should be part of the rectangle pool API, right? Also the code
seems to be better placed in eina_rectangle_pool.[ch], Don't know,
something is strange there :))
Also, the rectangle API had an inline function to set the coords in one
pass, eina_rectangle_coords_from, but then someone added EINA_RECTANGLE_SET
macro, is just a duplicate of the former ...
So, does it worth to put stuff on deprecated and add things the proper
way? Do you have already some *deprecation* process?
Cedric
The following changes since commit
4850c4660f226f1d58f3e877d0b8ddbd6a6c77d4:
Evas textblock: Fixed broken test. (2013-09-23 14:37:19 +0100)
are available in the git repository at:
https://github.com/turran/efl eina-extra
for you to fetch changes up to 67dc4a42d54e6533b6e72279ff54fd7a0f2091f7:
Add a substraction in rectangles and more helpers (2013-09-24 01:10:41
+0200)
Jorge Zapata (3):
Add double_from/to and helper defines in f16p16
Add functions to alloc strings from a printf fmt
Add a substraction in rectangles and more helpers
src/lib/eina/eina_fp.h |6 ++
src/lib/eina/eina_inline_fp.x| 17 +
src/lib/eina/eina_inline_rectangle.x | 138
++
src/lib/eina/eina_rectangle.h| 10 ++
src/lib/eina/eina_str.c | 41
+
src/lib/eina/eina_str.h | 33
+
6 files changed, 245 insertions(+)
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
from
the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Cedric BAIL
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
from
the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate
