Re: [E-devel] Elementary table regression
On Sat, Oct 10, 2009 at 9:56 AM, Atton Jonathan wrote: > The size of the clipper can't be set by dynamically ? yes, it is possible, just implement the Evas_Smart_Class->resize to resize it based on the current size... add some more room if you want to avoid clip at object boundaries (just use the other clip behavior, as coloring, smart object being clipped and easy hide/show. Although I changed a bit elm_table when I used it as base for evas_table and evas_box was written from scratch, they should not be slower, but faster as they will do heavy operations less time (just when changes, right before painting... not on every change). That said, it will check for more size_hints, so more function calls, but those shouldn't matter that much. It would be good to have those that complain to write a very simple test case and use oprofile or gprof to figure it out what's wrong. BR, > 2009/10/9 Iván Briano (Sachiel) > >> On Fri, Oct 9, 2009 at 4:02 PM, Nicolas Aguirre >> wrote: >> > 2009/10/9 Nicolas Aguirre : >> >> Hi guys, >> >> >> >> Since the switch to evas_table, I have issues with elm_table. >> >> The problem can be easily reproduced with elementary_test and the >> >> patch that you can find in attached file. >> >> >> >> In test_photo.c I just change the layout to have 3 rows and 200 columns. >> >> When I try elementary_test with a SVN < 42781 All images are shown on >> >> the screen when you scroll. But after this commit the end of the table >> >> is never shown. >> >> >> >> On the other side, table creation is faster with evas_table, in my >> >> test about 3 times faster. >> >> -- >> >> Nicolas Aguirre >> >> Mail: aguirre.nico...@gmail.com >> >> Web: http://www.digital-corner.org >> >> >> > >> > I have made more test and I have found a regression with elm_list. >> > Same than previously, when you add more than 150 items in a list, last >> > items are not shown. >> > the attached file is a patch to elm_list, and reproduce the problem >> > with actual SVN. >> > SVN < 42781 works great. >> > >> >> It's not a problem with table or list, but evas_box and evas_table inherit >> from evas_object_smart_clipped, which uses a smaller clipper than the >> smart objects in elm were. Increasing the size of the clipper "fixes" it, >> but you will run into the same problem if you keep growing the table. >> >> I just commited a bigger clipper, managed to get 1000 columns in the >> table just fine, albeit very slow to scroll, and that's already an insanely >> big number for elm_table. >> >> > regards, >> > >> > -- >> > Nicolas Aguirre >> > Mail: aguirre.nico...@gmail.com >> > Web: http://www.digital-corner.org >> > >> > >> -- >> > Come build with us! The BlackBerry(R) Developer Conference in SF, CA >> > is the only developer event you need to attend this year. Jumpstart your >> > developing skills, take BlackBerry mobile applications to market and stay >> > ahead of the curve. Join us from November 9 - 12, 2009. Register now! >> > http://p.sf.net/sfu/devconference >> > ___ >> > enlightenment-devel mailing list >> > enlightenment-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> > >> >> >> -- >> Come build with us! The BlackBerry(R) Developer Conference in SF, CA >> is the only developer event you need to attend this year. Jumpstart your >> developing skills, take BlackBerry mobile applications to market and stay >> ahead of the curve. Join us from November 9 - 12, 2009. Register now! >> http://p.sf.net/sfu/devconference >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > -- > Regards. > -- > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobi
Re: [E-devel] Elementary table regression
The size of the clipper can't be set by dynamically ? 2009/10/9 Iván Briano (Sachiel) > On Fri, Oct 9, 2009 at 4:02 PM, Nicolas Aguirre > wrote: > > 2009/10/9 Nicolas Aguirre : > >> Hi guys, > >> > >> Since the switch to evas_table, I have issues with elm_table. > >> The problem can be easily reproduced with elementary_test and the > >> patch that you can find in attached file. > >> > >> In test_photo.c I just change the layout to have 3 rows and 200 columns. > >> When I try elementary_test with a SVN < 42781 All images are shown on > >> the screen when you scroll. But after this commit the end of the table > >> is never shown. > >> > >> On the other side, table creation is faster with evas_table, in my > >> test about 3 times faster. > >> -- > >> Nicolas Aguirre > >> Mail: aguirre.nico...@gmail.com > >> Web: http://www.digital-corner.org > >> > > > > I have made more test and I have found a regression with elm_list. > > Same than previously, when you add more than 150 items in a list, last > > items are not shown. > > the attached file is a patch to elm_list, and reproduce the problem > > with actual SVN. > > SVN < 42781 works great. > > > > It's not a problem with table or list, but evas_box and evas_table inherit > from evas_object_smart_clipped, which uses a smaller clipper than the > smart objects in elm were. Increasing the size of the clipper "fixes" it, > but you will run into the same problem if you keep growing the table. > > I just commited a bigger clipper, managed to get 1000 columns in the > table just fine, albeit very slow to scroll, and that's already an insanely > big number for elm_table. > > > regards, > > > > -- > > Nicolas Aguirre > > Mail: aguirre.nico...@gmail.com > > Web: http://www.digital-corner.org > > > > > -- > > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > > is the only developer event you need to attend this year. Jumpstart your > > developing skills, take BlackBerry mobile applications to market and stay > > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > > http://p.sf.net/sfu/devconference > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > -- > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Regards. -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elementary table regression
On Fri, 9 Oct 2009 16:59:37 -0300 Iván Briano (Sachiel) said: > On Fri, Oct 9, 2009 at 4:46 PM, Nicolas Aguirre > wrote: > > 2009/10/9 Iván Briano (Sachiel) : > >> > >> It's not a problem with table or list, but evas_box and evas_table inherit > >> from evas_object_smart_clipped, which uses a smaller clipper than the > >> smart objects in elm were. Increasing the size of the clipper "fixes" it, > >> but you will run into the same problem if you keep growing the table. > >> > >> I just commited a bigger clipper, managed to get 1000 columns in the > >> table just fine, albeit very slow to scroll, and that's already an insanely > >> big number for elm_table. > >> > > > > It's usable with SVN < 42781, you can scroll 3x2000 items without lag > > in test_photo. but it's very very very slow with recent SVN. But as I > > said in my previous mail, table creation is much faster with > > evas_table. > > > > Test with 3x2000 items : > > SVN < 42781 : Table creation take 38.868 seconds, scroll is smotth. > > SVN r42984 : Table creation take 'only' 1.329 seconds. you can't > > scroll at least on my core2 duo. > > > > I can't test that now, but I *could* scroll the table with a huge ammount > of objects, it was just noticeably slower. > I'll look into this with more detail during the weekend. > > > I agree that it's not very smart to add so many items in a table and > > show all of them in the same time. But IIR you can't use elm_genlist > > in horizontal mode. And I use a lot of elm_box in enna. And with these > > last commits, it's very slow :/ > > But I find it unfortunate to have changed something that was really > > fast and reliable to evas_box that seems much slower, maybe we should > > try to fix evas_box before switching ? > > > > Both evas_box and evas_table were there for some time already and no one > touched them, it's much more likely that they'll get fixed now that elm moved > to them. actually the move to evas_box/table broke a slew of things. index, scrolling in photocam and scrolling in several other tests. one reason is that the smart table/box would calc their min size on every add - thus its alweasy available as "current". evas table/box are faster on inserts because they dont do this.. but thsi emans the min size is not known until some time later (or u explicitly call calc) i suspect this has triggered a small mountain of issues. i added something to foce a canvas-wide calc BEFORE any window show because one effect was windows coming up "1x1" pixel THEN resizing to be bigger as min size wasn't known until after first render. i added to edje the ability to listen to size hint changes and auto-adjust the swallowed element. this reduced some swallows in the code as its not needed anymore, but i suspect this has given rise to other problems. i suggest you try every test and look at them in detail. but something bad happened (tm). -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elementary table regression
On Fri, Oct 9, 2009 at 4:46 PM, Nicolas Aguirre wrote: > 2009/10/9 Iván Briano (Sachiel) : >> >> It's not a problem with table or list, but evas_box and evas_table inherit >> from evas_object_smart_clipped, which uses a smaller clipper than the >> smart objects in elm were. Increasing the size of the clipper "fixes" it, >> but you will run into the same problem if you keep growing the table. >> >> I just commited a bigger clipper, managed to get 1000 columns in the >> table just fine, albeit very slow to scroll, and that's already an insanely >> big number for elm_table. >> > > It's usable with SVN < 42781, you can scroll 3x2000 items without lag > in test_photo. but it's very very very slow with recent SVN. But as I > said in my previous mail, table creation is much faster with > evas_table. > > Test with 3x2000 items : > SVN < 42781 : Table creation take 38.868 seconds, scroll is smotth. > SVN r42984 : Table creation take 'only' 1.329 seconds. you can't > scroll at least on my core2 duo. > I can't test that now, but I *could* scroll the table with a huge ammount of objects, it was just noticeably slower. I'll look into this with more detail during the weekend. > I agree that it's not very smart to add so many items in a table and > show all of them in the same time. But IIR you can't use elm_genlist > in horizontal mode. And I use a lot of elm_box in enna. And with these > last commits, it's very slow :/ > But I find it unfortunate to have changed something that was really > fast and reliable to evas_box that seems much slower, maybe we should > try to fix evas_box before switching ? > Both evas_box and evas_table were there for some time already and no one touched them, it's much more likely that they'll get fixed now that elm moved to them. > > regards, > -- > Nicolas Aguirre > Mail: aguirre.nico...@gmail.com > Web: http://www.digital-corner.org > -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elementary table regression
2009/10/9 Iván Briano (Sachiel) : > > It's not a problem with table or list, but evas_box and evas_table inherit > from evas_object_smart_clipped, which uses a smaller clipper than the > smart objects in elm were. Increasing the size of the clipper "fixes" it, > but you will run into the same problem if you keep growing the table. > > I just commited a bigger clipper, managed to get 1000 columns in the > table just fine, albeit very slow to scroll, and that's already an insanely > big number for elm_table. > It's usable with SVN < 42781, you can scroll 3x2000 items without lag in test_photo. but it's very very very slow with recent SVN. But as I said in my previous mail, table creation is much faster with evas_table. Test with 3x2000 items : SVN < 42781 : Table creation take 38.868 seconds, scroll is smotth. SVN r42984 : Table creation take 'only' 1.329 seconds. you can't scroll at least on my core2 duo. I agree that it's not very smart to add so many items in a table and show all of them in the same time. But IIR you can't use elm_genlist in horizontal mode. And I use a lot of elm_box in enna. And with these last commits, it's very slow :/ But I find it unfortunate to have changed something that was really fast and reliable to evas_box that seems much slower, maybe we should try to fix evas_box before switching ? regards, -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://www.digital-corner.org -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elementary table regression
On Fri, Oct 9, 2009 at 4:02 PM, Nicolas Aguirre wrote: > 2009/10/9 Nicolas Aguirre : >> Hi guys, >> >> Since the switch to evas_table, I have issues with elm_table. >> The problem can be easily reproduced with elementary_test and the >> patch that you can find in attached file. >> >> In test_photo.c I just change the layout to have 3 rows and 200 columns. >> When I try elementary_test with a SVN < 42781 All images are shown on >> the screen when you scroll. But after this commit the end of the table >> is never shown. >> >> On the other side, table creation is faster with evas_table, in my >> test about 3 times faster. >> -- >> Nicolas Aguirre >> Mail: aguirre.nico...@gmail.com >> Web: http://www.digital-corner.org >> > > I have made more test and I have found a regression with elm_list. > Same than previously, when you add more than 150 items in a list, last > items are not shown. > the attached file is a patch to elm_list, and reproduce the problem > with actual SVN. > SVN < 42781 works great. > It's not a problem with table or list, but evas_box and evas_table inherit from evas_object_smart_clipped, which uses a smaller clipper than the smart objects in elm were. Increasing the size of the clipper "fixes" it, but you will run into the same problem if you keep growing the table. I just commited a bigger clipper, managed to get 1000 columns in the table just fine, albeit very slow to scroll, and that's already an insanely big number for elm_table. > regards, > > -- > Nicolas Aguirre > Mail: aguirre.nico...@gmail.com > Web: http://www.digital-corner.org > > -- > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elementary table regression
2009/10/9 Nicolas Aguirre :
> Hi guys,
>
> Since the switch to evas_table, I have issues with elm_table.
> The problem can be easily reproduced with elementary_test and the
> patch that you can find in attached file.
>
> In test_photo.c I just change the layout to have 3 rows and 200 columns.
> When I try elementary_test with a SVN < 42781 All images are shown on
> the screen when you scroll. But after this commit the end of the table
> is never shown.
>
> On the other side, table creation is faster with evas_table, in my
> test about 3 times faster.
> --
> Nicolas Aguirre
> Mail: aguirre.nico...@gmail.com
> Web: http://www.digital-corner.org
>
I have made more test and I have found a regression with elm_list.
Same than previously, when you add more than 150 items in a list, last
items are not shown.
the attached file is a patch to elm_list, and reproduce the problem
with actual SVN.
SVN < 42781 works great.
regards,
--
Nicolas Aguirre
Mail: aguirre.nico...@gmail.com
Web: http://www.digital-corner.org
Index: src/bin/test_photo.c
===
--- src/bin/test_photo.c (révision 42983)
+++ src/bin/test_photo.c (copie de travail)
@@ -30,11 +30,11 @@
tb = elm_table_add(win);
evas_object_size_hint_weight_set(tb, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
-
+ double t0 = ecore_time_get();
n = 0;
- for (j = 0; j < 12; j++)
+ for (j = 0; j < 3; j++)
{
-for (i = 0; i < 12; i++)
+for (i = 0; i < 200; i++)
{
ph = elm_photo_add(win);
snprintf(buf, sizeof(buf), "%s/images/%s",
@@ -51,7 +51,8 @@
evas_object_show(ph);
}
}
-
+ double t1 = ecore_time_get() - t0;
+ printf("Duration : %3.3f\n", t1);
sc = elm_scroller_add(win);
evas_object_size_hint_weight_set(sc, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_win_resize_object_add(win, sc);
--
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Elementary table regression
Hi guys,
Since the switch to evas_table, I have issues with elm_table.
The problem can be easily reproduced with elementary_test and the
patch that you can find in attached file.
In test_photo.c I just change the layout to have 3 rows and 200 columns.
When I try elementary_test with a SVN < 42781 All images are shown on
the screen when you scroll. But after this commit the end of the table
is never shown.
On the other side, table creation is faster with evas_table, in my
test about 3 times faster.
--
Nicolas Aguirre
Mail: aguirre.nico...@gmail.com
Web: http://www.digital-corner.org
Index: src/bin/test_photo.c
===
--- src/bin/test_photo.c (révision 42983)
+++ src/bin/test_photo.c (copie de travail)
@@ -30,11 +30,11 @@
tb = elm_table_add(win);
evas_object_size_hint_weight_set(tb, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
-
+ double t0 = ecore_time_get();
n = 0;
- for (j = 0; j < 12; j++)
+ for (j = 0; j < 3; j++)
{
-for (i = 0; i < 12; i++)
+for (i = 0; i < 200; i++)
{
ph = elm_photo_add(win);
snprintf(buf, sizeof(buf), "%s/images/%s",
@@ -51,7 +51,8 @@
evas_object_show(ph);
}
}
-
+ double t1 = ecore_time_get() - t0;
+ printf("Duration : %3.3f\n", t1);
sc = elm_scroller_add(win);
evas_object_size_hint_weight_set(sc, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_win_resize_object_add(win, sc);
--
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
