Re: [E-devel] Enlightenment CVS committal
I wrote: I think this is some subtle grad id problem, or some such, in the way edje grads are defined.. or some other part of the code that may deal with 'transitions'. and also, Since Brian is busy with things, it looks like I may have to see if I can sort this out. I ended up modifying all the edje grad stuff.. and adding bunch of new things.. and 'fixing' a couple of small things I saw.. and I still couldn't get rid of the weird transitions. In the end, I had to back up and re-examine evas itself, since I couldn't see how else this could be happening. And indeed I did find the source of the problem in evas grads, NOT edje. I'll send a patch for evas later (a couple of lines really), as I also saw that some changes that I thought I'd done for the xrender engine never made it to the diff I sent. Anyway, the 'edje-grad-transition-problem' is over. My sincere apologies to Brian for ever having doubted his edje-grads.. they work just fine :) jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
On Mon, 2 Oct 2006 08:59:22 -0500 Brian Mattern [EMAIL PROTECTED] babbled: On Mon, Oct 02, 2006 at 12:40:33PM +, [EMAIL PROTECTED] wrote: Ok, that will take care of your dialog previews and such... *BUT* for some reason, when you hit apply, it fails to do so. No idea why -- that's some obscure e17 thing I know nothing about. If you want I can send you the diffs to edje and e17, though I'm sure Brian intends to rewrite the edje grads a bit. But again, I have no idea why nothing gets 'applied' to the actual bg. I'll look at the bg dialog within the next couple of days (pretty busy with work atm. unfortunately). And I definitely plan on cleaning up the edje grads a bit. Just gotta find some time again. :) i fixed it already :) Brian - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
Brian writes: I'll look at the bg dialog within the next couple of days (pretty busy with work atm. unfortunately). And I definitely plan on cleaning up the edje grads a bit. Just gotta find some time again. :) Sounds good :) Edje grads should be easier and more flexibly dealt with now. And Carsten writes: i fixed it already :) All by yourself eh..? :) I haven't tried the latest in cvs, but the real problem I saw was the not-changing-correctly-to-the-desktop-bg issue. I looked at this a bit more carefully... It's not that it wasn't doing anything when 'apply' was pressed - it's doing some sort of transition between the current bg edje and the selected one.. But if either one is a grad edje, then you can see that around half way thru there's a bit of the grad edj showing (very transp), and then it goes white after that. If you actually logout with the grad edje set as bg and then log back in it'll then show up ok. But again if you try to change it to another grad bg.. we get the same weirdness. I've actually made edje to always set the grad-obj color to red say, and it doesn't seem to matter.. you get red-tinted grads lightly appearing ~half-way and then back to nothing... so the problem doesn't seem to be in edje color transitions... It may be somewhere else in edje's transitions code, or it may be in e17. Did this happen before the move to premul? I'll see if I can track this down a bit more.. My total ignorance of e17 doesn't help here - is there any way to make e not do the transition bit when switching bgs? It would actually be good if this were part of the bg dialog -- being able to set the trans type, speed, etc :) jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
On Tue, 3 Oct 2006 07:46:09 GMT [EMAIL PROTECTED] [EMAIL PROTECTED] babbled: Brian writes: I'll look at the bg dialog within the next couple of days (pretty busy with work atm. unfortunately). And I definitely plan on cleaning up the edje grads a bit. Just gotta find some time again. :) Sounds good :) Edje grads should be easier and more flexibly dealt with now. And Carsten writes: i fixed it already :) All by yourself eh..? :) nup - see commit log :) I haven't tried the latest in cvs, but the real problem I saw was the not-changing-correctly-to-the-desktop-bg issue. I looked at this a bit more carefully... It's not that it wasn't doing anything when 'apply' was pressed - it's doing some sort of transition between the current bg edje and the selected one.. But if either one is a grad edje, then you can see that around half way thru there's a bit of the grad edj showing (very transp), and then it goes white after that. If you actually logout with the grad edje set as bg and then log back in it'll then show up ok. But again if you try to change it to another grad bg.. we get the same weirdness. I've actually made edje to always set the grad-obj color to red say, and it doesn't seem to matter.. you get red-tinted grads lightly appearing ~half-way and then back to nothing... so the problem doesn't seem to be in edje color transitions... It may be somewhere else in edje's transitions code, or it may be in e17. edje does the transition :( Did this happen before the move to premul? no - i think it worked. I'll see if I can track this down a bit more.. My total ignorance of e17 doesn't help here - is there any way to make e not do the transition bit when switching bgs? It would actually be good if this were part of the bg dialog -- being able to set the trans type, speed, etc :) there is a transitiosn cfg dialog actually :) jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
I wrote: I think this is some subtle grad id problem, or some such, in the way edje grads are defined.. or some other part of the code that may deal with 'transitions'. Ummm I wonder if it may be that there's absolutely no support for edje grads in edje_embryo. There's no EDJE_SATE_PARAM_... related to grads.. and those for fill will only work with image types, there's none for fill-spread, or fill-angle (which, by the way, should be at least a float - ints are not enough to obtain smoothly varying angles), etc, etc.. Since Brian is busy with things, it looks like I may have to see if I can sort this out. jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
On Mon, 2 Oct 2006 05:47:01 GMT [EMAIL PROTECTED] [EMAIL PROTECTED] babbled: Author : raster Project : e17 Module : libs/evas Dir : e17/libs/evas/src/modules/loaders/eet Modified Files: evas_image_load_eet.c Log Message: fix eet load of premul images - need to check they are not bad :) Ummm... How about adding a 'premul' flag to eet images, which would be set/read accordingly... i could... but i would need to break eet api... and i'm just as happy to break format - premul encoding can be more efficient compression-wise by nulling out transparent pixels. :) jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
Ummm... How about adding a 'premul' flag to eet images, which would be set/read accordingly... i could... but i would need to break eet api... and i'm just as happy to break format - premul encoding can be more efficient compression-wise by nulling out transparent pixels. :) Yeah.. And it would be silly to load, premul, then unpremul to save-to-eet, and then load-from-eet and premul again! So you made the right decision there. PS. I looked into the grad problem you mention on irc... No problem with grads themselves, just a couple of changes that are needed now in edje and e17 due to the new evas changes. Two files you need to make changes to. In edje, in the file edje_calc.c, line 1303 should read: evas_object_gradient_fill_angle_set(ep-object, p3.fill.angle); also, line 1329 should now read: evas_object_gradient_color_stop_add(ep-object, sc-r, sc-g, sc-b, 255, sc-d); evas_object_gradient_alpha_stop_add(ep-object, sc-a, sc-d); Then in e17, in the file e_spectrum.c, line 304 should read: data[(i * sp-iw) + j] = (sp-cv-a 24) | (((r * sp-cv-a) / 255) 16) | (((g * sp-cv-a) / 255) 8) | ((b * sp-cv-a) / 255); Ok, that will take care of your dialog previews and such... *BUT* for some reason, when you hit apply, it fails to do so. No idea why -- that's some obscure e17 thing I know nothing about. If you want I can send you the diffs to edje and e17, though I'm sure Brian intends to rewrite the edje grads a bit. But again, I have no idea why nothing gets 'applied' to the actual bg. jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
On Mon, 2 Oct 2006 12:40:33 GMT [EMAIL PROTECTED] [EMAIL PROTECTED] babbled: Ummm... How about adding a 'premul' flag to eet images, which would be set/read accordingly... i could... but i would need to break eet api... and i'm just as happy to break format - premul encoding can be more efficient compression-wise by nulling out transparent pixels. :) Yeah.. And it would be silly to load, premul, then unpremul to save-to-eet, and then load-from-eet and premul again! So you made the right decision there. PS. I looked into the grad problem you mention on irc... No problem with grads themselves, just a couple of changes that are needed now in edje and e17 due to the new evas changes. Two files you need to make changes to. In edje, in the file edje_calc.c, line 1303 should read: evas_object_gradient_fill_angle_set(ep-object, p3.fill.angle); ok- fill angle it is! :) also, line 1329 should now read: evas_object_gradient_color_stop_add(ep-object, sc-r, sc-g, sc-b, 255, sc-d); evas_object_gradient_alpha_stop_add(ep-object, sc-a, sc-d); hmm - color stop can't add the alpha directly as-is? Then in e17, in the file e_spectrum.c, line 304 should read: data[(i * sp-iw) + j] = (sp-cv-a 24) | (((r * sp-cv-a) / 255) 16) | (((g * sp-cv-a) / 255) 8) | ((b * sp-cv-a) / 255); oh that was silly! of course! fixed. Ok, that will take care of your dialog previews and such... *BUT* for some reason, when you hit apply, it fails to do so. No idea why -- that's some obscure e17 thing I know nothing about. If you want I can send you the diffs to edje and e17, though I'm sure Brian intends to rewrite the edje grads a bit. But again, I have no idea why nothing gets 'applied' to the actual bg. jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
also, line 1329 should now read: evas_object_gradient_color_stop_add(ep-object, sc-r, sc-g, sc-b, 255, sc-d); evas_object_gradient_alpha_stop_add(ep-object, sc-a, sc-d); hmm - color stop can't add the alpha directly as-is? Yes, but only in this particular case because the alphas are then 255. But since edje assumes the inputs are non-premul, in general it would generate a premul spectrum with non-premul colors :( The evas_object_gradient_color_stop_add function expects premul colors and generates a premul spectrum. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
On Mon, Oct 02, 2006 at 12:40:33PM +, [EMAIL PROTECTED] wrote: Ok, that will take care of your dialog previews and such... *BUT* for some reason, when you hit apply, it fails to do so. No idea why -- that's some obscure e17 thing I know nothing about. If you want I can send you the diffs to edje and e17, though I'm sure Brian intends to rewrite the edje grads a bit. But again, I have no idea why nothing gets 'applied' to the actual bg. I'll look at the bg dialog within the next couple of days (pretty busy with work atm. unfortunately). And I definitely plan on cleaning up the edje grads a bit. Just gotta find some time again. :) Brian - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment CVS committal
Author : raster Project : e17 Module : libs/evas Dir : e17/libs/evas/src/modules/loaders/eet Modified Files: evas_image_load_eet.c Log Message: fix eet load of premul images - need to check they are not bad :) Ummm... How about adding a 'premul' flag to eet images, which would be set/read accordingly... jose. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
