Re: [E-devel] I found a bug in keybindings configuration

2006-02-25 Thread Aleksej Struk
Fixed. 

But in a little bit different way. Basically, the Key field is
disabled until you select an item from the list.

On Fri, Feb 24, 2006 at 07:29:03PM +0100, Alexander Griesser wrote:
// Hi all!
// 
// I'm just new to the list so at first I want to thank you all for
// giving us such a great window manager like E17 is!
// 
// Today I stumbled upon a bug in the freshest CVS release which is
// located in the keybindings configuration program, here's the info:
// 
// Symptoms:
// =
// When I start the keybindings configuration dialog and enter some text
// in the Key : edit control, enlightenment segfaults.
// 
// This is reproducible everytime I tried it.
// 
// The reason therefore seems to be, that when the window opens, no
// list item in the left is selected and therefore all future calls
// to cfdata-cur_eckb will result in segfaults as cur_eckb is NULL
// in this case.
// 
// The fix for this is simple, please apply:
// 
// --- e_int_config_keybindings.c/b2006-02-24 15:29:31.559179545 +0100ngs.c
// e_*.new
// +++ e_int_config_keybindings.c.new 2006-02-24 15:18:13.860107071 +0100
// @@ -1047,6 +1047,7 @@
// E_Config_Binding_Key *bk;
// 
// if (cfdata == NULL) return;
// + if (cfdata-cur_eckb == NULL) return;
// 
// wd_next = e_widget_data_get(cfdata-gui.btn_next_keybind);
// wd_prev = e_widget_data_get(cfdata-gui.btn_prev_keybind);
// 
// 
// ciao,
// -- 
// |   .-.  |Alexander Griesser -- [EMAIL PROTECTED] | .''`. |
// |   /v\   \  http://www.tuxx-home.at/ / : :' : |
// | /(   )\  |  GPG-KeyID: 0xA2949B5A  |  `. `'  |
// |  ^^ ^^   `-'`-   |
// 
// 
// 
// 
// ---
// This SF.Net email is sponsored by xPML, a groundbreaking scripting language
// that extends applications into web and mobile media. Attend the live webcast
// and join the prime developer group breaking into this new coding territory!
// http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642
// ___
// enlightenment-devel mailing list
// enlightenment-devel@lists.sourceforge.net
// https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

-- 

Aleksej Struk
Master Degree Student
Free University of Bozen-Bolzano
Faculty of Computer Science
phone: +39-0471-061749
cell phone: +39-3204627049 +370-61278908
[EMAIL PROTECTED] [EMAIL PROTECTED] - http://www.


---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] I found a bug in keybindings configuration

2006-02-25 Thread Alexander Griesser
Aleksej Struk wrote:
 Fixed. 
 
 But in a little bit different way. Basically, the Key field is
 disabled until you select an item from the list.

I wanted to fix it this way but wasn't able to because I just started
hacking E17 ;) It is the more beautiful way, thanks!

ciao,
Alex


---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] I found a bug in keybindings configuration

2006-02-24 Thread Alexander Griesser
Hi all!

I'm just new to the list so at first I want to thank you all for
giving us such a great window manager like E17 is!

Today I stumbled upon a bug in the freshest CVS release which is
located in the keybindings configuration program, here's the info:

Symptoms:
=
When I start the keybindings configuration dialog and enter some text
in the Key : edit control, enlightenment segfaults.

This is reproducible everytime I tried it.

The reason therefore seems to be, that when the window opens, no
list item in the left is selected and therefore all future calls
to cfdata-cur_eckb will result in segfaults as cur_eckb is NULL
in this case.

The fix for this is simple, please apply:

--- e_int_config_keybindings.c/b2006-02-24 15:29:31.559179545 +0100ngs.c
e_*.new
+++ e_int_config_keybindings.c.new 2006-02-24 15:18:13.860107071 +0100
@@ -1047,6 +1047,7 @@
E_Config_Binding_Key *bk;

if (cfdata == NULL) return;
+ if (cfdata-cur_eckb == NULL) return;

wd_next = e_widget_data_get(cfdata-gui.btn_next_keybind);
wd_prev = e_widget_data_get(cfdata-gui.btn_prev_keybind);


ciao,
-- 
|   .-.  |Alexander Griesser -- [EMAIL PROTECTED] | .''`. |
|   /v\   \  http://www.tuxx-home.at/ / : :' : |
| /(   )\  |  GPG-KeyID: 0xA2949B5A  |  `. `'  |
|  ^^ ^^   `-'`-   |




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel