Re: [E-devel] Ibox oddity when restarting E...

2007-03-18 Thread Christopher Michael
Ravenlock wrote:
> Hello,
> 
> Most will probably not be bothered by this behavior.  But for some 
> reason it drives me crazy.
> 
> It seems that when you restart E, you get all iconified applications 
> added to the iconbox present on the current desk regardless of the "Show 
> windows from active desktop" setting.
> 
> For example,  If I have 4 desks, each with 2 iconified apps on them. 
> Then I restart E...  I will end up with 8 iconified apps in the icon box 
> on the current desktop.  If you switch from the current desktop to any 
> other... things get straightened out.  But it still bothers me.
> 
> Attached is a patch to fix this behavior.
> 
> 
In cvs...Good catch :)

dh

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] Ibox oddity when restarting E...

2007-03-15 Thread Ravenlock

Hello,

Most will probably not be bothered by this behavior.  But for some 
reason it drives me crazy.


It seems that when you restart E, you get all iconified applications 
added to the iconbox present on the current desk regardless of the "Show 
windows from active desktop" setting.


For example,  If I have 4 desks, each with 2 iconified apps on them. 
Then I restart E...  I will end up with 8 iconified apps in the icon box 
on the current desktop.  If you switch from the current desktop to any 
other... things get straightened out.  But it still bothers me.


Attached is a patch to fix this behavior.

--
Regards,
Ravenlock
Index: e17/apps/e/src/modules/ibox/e_mod_main.c
===
RCS file: /var/cvs/e/e17/apps/e/src/modules/ibox/e_mod_main.c,v
retrieving revision 1.80
diff -u -r1.80 e_mod_main.c
--- e17/apps/e/src/modules/ibox/e_mod_main.c3 Jan 2007 06:14:03 -   
1.80
+++ e17/apps/e/src/modules/ibox/e_mod_main.c16 Mar 2007 06:15:48 -
@@ -1017,9 +1017,11 @@
E_Event_Border_Add *ev;
IBox *b;
IBox_Icon *ic;
+   E_Desk *desk;
 
ev = event;
/* add if iconic */
+   desk = e_desk_current_get(ev->border->zone);
if (ev->border->iconic)
  {
Evas_List *l, *ibox;
@@ -1028,6 +1030,7 @@
  {
 b = l->data;
 if (_ibox_icon_find(b, ev->border)) continue;
+if ((b->show_desk) && (ev->border->desk != desk)) continue;
 ic = _ibox_icon_new(b, ev->border);
 if (!ic) continue;
 b->icons = evas_list_append(b->icons, ic);
@@ -1078,15 +1081,18 @@
IBox *b;
IBox_Icon *ic;
Evas_List *l, *ibox;
+   E_Desk *desk;
 
ev = event;
/* add icon for ibox for right zone */
/* do some sort of anim when iconifying */
+   desk = e_desk_current_get(ev->border->zone);
ibox = _ibox_zone_find(ev->border->zone);
for (l = ibox; l; l = l->next)
  {
b = l->data;
if (_ibox_icon_find(b, ev->border)) continue;
+   if ((b->show_desk) && (ev->border->desk != desk)) continue;
ic = _ibox_icon_new(b, ev->border);
if (!ic) continue;
b->icons = evas_list_append(b->icons, ic);
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel