Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
On Mon, 29 Sep 2008 21:43:13 +0200 Hendrik Siedelmann [EMAIL PROTECTED] babbled: just fyi - it's slipped int svn in the meantime :) Did I post this in some wrong form? I can't believe there's no one interested in this. I thought this was asked for before, but it doesnt look like it. I'd be happy to get any feedback, even if only to know why my patch was completely ignored. I'm refering to my mail from 21 Sep 2008: Okay here it is, this patch adds the possibility to epsilon to create thumbnails in jpg format. The thumbnails are saved in FDO naming convention, just with ending .jpg. Would be glad if you could give me some feedback so this could eventually be included in svn. Patch works for me, but there are some things to mention: - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. - new function epsilon_format_set which allows to set format to jpeg. - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
2008/10/6 Gustavo Sverzut Barbieri [EMAIL PROTECTED]: On Sun, Sep 21, 2008 at 7:29 PM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: Okay here it is, this patch adds the possibility to epsilon to create thumbnails in jpg format. The thumbnails are saved in FDO naming convention, just with ending .jpg. Would be glad if you could give me some feedback so this could eventually be included in svn. Patch works for me, but there are some things to mention: Ok, better late than sorry, it's commited to SVN. As for your questions: Now that is great news, thanks. - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. EPEG was the old way to generate JPEGs in an efficient way. Then that code was integrated into Evas, then I deprecated EPEG (moved to OLD) when we changed to SVN. At the beginning, epsilon was not using Evas, but raster added that, but I never checked that it was not generating JPEGs, just PNGs because there was no option to select so. So is it save to assume epeg is never used and remove those parts? - new function epsilon_format_set which allows to set format to jpeg. It would be good to provide patch for BINDINGS/python-efl/python-epsilon. If you are able to provide so, mail it, otherwise I can do it for you. Sorry, never worked with python. - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. yes, raster already provided such feedback to fdo guys, but they blindly rejected so... damn it. Yeah would have been nice to have jpeg in the standard. But the way the jpegs are saved now makes it dead easy to implement for all programs that support the fdo spec. hendrik - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
On Mon, Oct 6, 2008 at 6:11 AM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: 2008/10/6 Gustavo Sverzut Barbieri [EMAIL PROTECTED]: On Sun, Sep 21, 2008 at 7:29 PM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. EPEG was the old way to generate JPEGs in an efficient way. Then that code was integrated into Evas, then I deprecated EPEG (moved to OLD) when we changed to SVN. At the beginning, epsilon was not using Evas, but raster added that, but I never checked that it was not generating JPEGs, just PNGs because there was no option to select so. So is it save to assume epeg is never used and remove those parts? those yes, now they can be handled with Evas. I'm not sure if you want to, but Epsilon requires some cleanup/refactory, making it evas only (and emotion for video). - new function epsilon_format_set which allows to set format to jpeg. It would be good to provide patch for BINDINGS/python-efl/python-epsilon. If you are able to provide so, mail it, otherwise I can do it for you. Sorry, never worked with python. ok, ok :-) - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. yes, raster already provided such feedback to fdo guys, but they blindly rejected so... damn it. Yeah would have been nice to have jpeg in the standard. But the way the jpegs are saved now makes it dead easy to implement for all programs that support the fdo spec. yeah -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: [EMAIL PROTECTED] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
On Sun, Sep 21, 2008 at 7:29 PM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: Okay here it is, this patch adds the possibility to epsilon to create thumbnails in jpg format. The thumbnails are saved in FDO naming convention, just with ending .jpg. Would be glad if you could give me some feedback so this could eventually be included in svn. Patch works for me, but there are some things to mention: Ok, better late than sorry, it's commited to SVN. As for your questions: - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. EPEG was the old way to generate JPEGs in an efficient way. Then that code was integrated into Evas, then I deprecated EPEG (moved to OLD) when we changed to SVN. At the beginning, epsilon was not using Evas, but raster added that, but I never checked that it was not generating JPEGs, just PNGs because there was no option to select so. - new function epsilon_format_set which allows to set format to jpeg. It would be good to provide patch for BINDINGS/python-efl/python-epsilon. If you are able to provide so, mail it, otherwise I can do it for you. - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. yes, raster already provided such feedback to fdo guys, but they blindly rejected so... damn it. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: [EMAIL PROTECTED] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
Did I post this in some wrong form? I can't believe there's no one interested in this. I thought this was asked for before, but it doesnt look like it. I'd be happy to get any feedback, even if only to know why my patch was completely ignored. I'm refering to my mail from 21 Sep 2008: Okay here it is, this patch adds the possibility to epsilon to create thumbnails in jpg format. The thumbnails are saved in FDO naming convention, just with ending .jpg. Would be glad if you could give me some feedback so this could eventually be included in svn. Patch works for me, but there are some things to mention: - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. - new function epsilon_format_set which allows to set format to jpeg. - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
2008/10/4 Gustavo Sverzut Barbieri [EMAIL PROTECTED]: On Mon, Sep 29, 2008 at 4:43 PM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: Did I post this in some wrong form? I can't believe there's no one interested in this. I thought this was asked for before, but it doesnt look like it. I'd be happy to get any feedback, even if only to know why my patch was completely ignored. I'm refering to my mail from 21 Sep 2008: Okay here it is, this patch adds the possibility to epsilon to create thumbnails in jpg format. The thumbnails are saved in FDO naming convention, just with ending .jpg. Would be glad if you could give me some feedback so this could eventually be included in svn. Patch works for me, but there are some things to mention: - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. - new function epsilon_format_set which allows to set format to jpeg. - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. Hey, calm down! We're all busy and I'm sure there is interest in it, I do, for example... as well as need to reply to Philip's thumbnail spec... just need time! :-) I'll try to go through it during this weekend. Sorry for the rush, I didn't want to sound rude. And thank you for looking at it. This little bit of feedback is all I wanted :). hendrik - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch: add jpeg thumbnail format to epsilon
On Sat, Oct 4, 2008 at 8:42 PM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: 2008/10/4 Gustavo Sverzut Barbieri [EMAIL PROTECTED]: On Mon, Sep 29, 2008 at 4:43 PM, Hendrik Siedelmann [EMAIL PROTECTED] wrote: Did I post this in some wrong form? I can't believe there's no one interested in this. I thought this was asked for before, but it doesnt look like it. I'd be happy to get any feedback, even if only to know why my patch was completely ignored. I'm refering to my mail from 21 Sep 2008: Okay here it is, this patch adds the possibility to epsilon to create thumbnails in jpg format. The thumbnails are saved in FDO naming convention, just with ending .jpg. Would be glad if you could give me some feedback so this could eventually be included in svn. Patch works for me, but there are some things to mention: - default behaviour is like before, BUT epsilon_exists will also find jpg thumbs, so epsilon_thumb_file_get will return the jpg and epsilon_info_get will return nothing as the jpg contains no exif infos. - I don't know what happens in those HAVE_EPEG_H parts, only tested without epeg. - new function epsilon_format_set which allows to set format to jpeg. - also changed epsilon_thumbd and added function epsilon_request_add_advanced which can also set format (and in the future hopefully custom sizes). - changed epsilon_thumb_test to accept the arguments -large and -jpg to request thumbnails with these options. From my test the jpg output is at least two times as fast on my laptop and at least five times on the the freerunner. Also the resulting files are 10-20% the size of png thumbnails. Hey, calm down! We're all busy and I'm sure there is interest in it, I do, for example... as well as need to reply to Philip's thumbnail spec... just need time! :-) I'll try to go through it during this weekend. Sorry for the rush, I didn't want to sound rude. And thank you for looking at it. This little bit of feedback is all I wanted :). you didn't sound rude, I was just doing a pong, we're here :-) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: [EMAIL PROTECTED] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Patch: add jpeg thumbnail format to epsilon
Okay here it is, this patch adds the possibility to epsilon to create
thumbnails in jpg format. The thumbnails are saved in FDO naming
convention, just with ending .jpg. Would be glad if you could give me
some feedback so this could eventually be included in svn. Patch works
for me, but there are some things to mention:
- default behaviour is like before, BUT epsilon_exists will also find
jpg thumbs, so epsilon_thumb_file_get will return the jpg and
epsilon_info_get will return nothing as the jpg contains no exif
infos.
- I don't know what happens in those HAVE_EPEG_H parts, only tested
without epeg.
- new function epsilon_format_set which allows to set format to jpeg.
- also changed epsilon_thumbd and added function
epsilon_request_add_advanced which can also set format (and in the
future hopefully custom sizes).
- changed epsilon_thumb_test to accept the arguments -large and -jpg
to request thumbnails with these options.
From my test the jpg output is at least two times as fast on my laptop
and at least five times on the the freerunner. Also the resulting
files are 10-20% the size of png thumbnails.
Index: src/include/Epsilon_Request.h
===
--- src/include/Epsilon_Request.h (Revision 35888)
+++ src/include/Epsilon_Request.h (Arbeitskopie)
@@ -18,6 +18,7 @@
{
unsigned int id; /** Identifier for this thumbnail */
unsigned int size; /** Thumbnail size to be generated */
+ unsigned int format; /** Thumbnail format to be generated */
unsigned int status; /** Status code of the thumbnail generation */
char *path; /** Path to file requiring thumbnail */
char *dest; /** Path to generated file, NULL on error */
@@ -30,6 +31,8 @@
EAPI int epsilon_request_init(void);
EAPI int epsilon_request_shutdown(void);
EAPI Epsilon_Request *epsilon_request_add(const char *path, Epsilon_Thumb_Size size, void *data);
+EAPI Epsilon_Request *epsilon_request_add_advanced(const char *path, Epsilon_Thumb_Size size,
+ Epsilon_Thumb_Format format, void *data);
EAPI void epsilon_request_del(Epsilon_Request *thumb);
#ifdef __cplusplus
Index: src/include/epsilon_private.h
===
--- src/include/epsilon_private.h (Revision 35888)
+++ src/include/epsilon_private.h (Arbeitskopie)
@@ -28,6 +28,7 @@
unsigned int status;
unsigned int thumbsize;
unsigned int bufsize;
+ unsigned int thumbformat;
};
typedef struct Epsilon_Ipc_End Epsilon_Ipc_End;
Index: src/lib/Epsilon.h
===
--- src/lib/Epsilon.h (Revision 35888)
+++ src/lib/Epsilon.h (Arbeitskopie)
@@ -43,6 +43,7 @@
int w, h;
int tw, th;
int tsize;
+ int format;
};
typedef struct _Epsilon Epsilon;
@@ -64,6 +65,14 @@
typedef enum _Epsilon_Thumb_Size Epsilon_Thumb_Size;
+enum _Epsilon_Thumb_Format
+{
+ EPSILON_THUMB_FDO,
+ EPSILON_THUMB_JPEG
+};
+
+typedef enum _Epsilon_Thumb_Format Epsilon_Thumb_Format;
+
EAPI int epsilon_init (void);
/* construct destruct */
@@ -74,6 +83,8 @@
EAPI void epsilon_key_set (Epsilon * e, const char *key);
/* Set the resolution*/
EAPI void epsilon_resolution_set (Epsilon * e, int w, int h);
+/* Set the thumbnail format */
+EAPI void epsilon_format_set (Epsilon * e, Epsilon_Thumb_Format f);
/*
* the source filename
Index: src/lib/epsilon_thumb.c
===
--- src/lib/epsilon_thumb.c (Revision 35888)
+++ src/lib/epsilon_thumb.c (Arbeitskopie)
@@ -306,12 +306,14 @@
/**
* @param path Path to the original image that will be thumbnailed.
* @param size Enum determining the scale of the thumbnail.
+ * @param size Enum determining the format of the thumbnail.
* @param data Data associated with this thumbnail for client use.
* @brief Request a thumbnail to be generated asynchronously for the specified
* @a path.
*/
Epsilon_Request *
-epsilon_request_add(const char *path, Epsilon_Thumb_Size size, void *data)
+epsilon_request_add_advanced(const char *path, Epsilon_Thumb_Size size,
+ Epsilon_Thumb_Format format, void *data)
{
Epsilon_Request *thumb;
@@ -333,6 +335,7 @@
}
thumb-size = size;
thumb-data = data;
+ thumb-format = format;
if (epsilon_request_resolve_thumb_file(thumb)) {
thumb-status = 1;
epsilon_event_inform_done(thumb);
@@ -342,6 +345,7 @@
msg = epsilon_message_new(epsilon_mid++, path, 0);
if (msg) {
msg-thumbsize = size;
+ msg-thumbformat = format;
if (debug) printf(!! requesting thumbnail for %s (request %d)!!, %d\n, path, msg-mid, sizeof(Epsilon_Message)+msg-bufsize);
if (ecore_ipc_server_send(epsilon_server, 1,1,1,1,1,msg,sizeof(Epsilon_Message)+msg-bufsize)) {
thumb-id = msg-mid;
@@ -358,6 +362,19 @@
}
/**
+ * @param path Path to the original image that will be thumbnailed.
+ * @param size Enum
