Re: [E-devel] Patch for evas (eina_log related)
On Thursday 22 October 2009 09:23:13 Mathieu Taillefumier wrote: It seems that my previous email did not pass through the mailing list. herewith a patch for evas that modify the previous patch I send weeks ago. The changes are listed below - Conversion of the remaining printf to eina_log in the lib and bin directories - Correction of the macros ERROR to ERR that caused trouble on windows platform. Now everything follow the short naming convention - Conversion of the printf in the graphical engines. The loaders are let as it is. the only thing that is problematic (maybe) is the initialization of the log domains for the engines. It is located in the module_open() (module_close() for destroying it) function. unfortunately, this looks like it broke directfb and qtopia. + _evas_engine_directfb_log_dom = eina_log_domain_register(EvasEngineDirectFB,EVAS_DEFAULT_COLOR); + _evas_engine_soft_qtopia_log_dom = eina_log_domain_register(EvasSoftQtopia,EVAS_DEFAULT_COLOR); ive fixed it now, but please try to test all your changes -mike signature.asc Description: This is a digitally signed message part. -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch for evas (eina_log related)
On Thu, Oct 22, 2009 at 3:23 PM, Mathieu Taillefumier mathieu.taillefum...@free.fr wrote: the only thing that is problematic (maybe) is the initialization of the log domains for the engines. It is located in the module_open() (module_close() for destroying it) function. Why do you make this statement ? It's sound good to me to register the domain on module open and unregister on module close. I am reviewing your patch, right now. I didn't have time previoulsy to do so. -- Cedric BAIL -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch for evas (eina_log related)
On Thu, Oct 22, 2009 at 4:04 PM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Oct 22, 2009 at 3:23 PM, Mathieu Taillefumier mathieu.taillefum...@free.fr wrote: the only thing that is problematic (maybe) is the initialization of the log domains for the engines. It is located in the module_open() (module_close() for destroying it) function. Why do you make this statement ? It's sound good to me to register the domain on module open and unregister on module close. I am reviewing your patch, right now. I didn't have time previoulsy to do so. I pushed it in svn. -- Cedric BAIL -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Patch for evas (eina_log related)
Hi, Why do you make this statement ? It's sound good to me to register the domain on module open and unregister on module close. Well, let us say that the eng_info function could have been a good place. I am reviewing your patch, right now. I didn't have time previoulsy to do so. I pushed it in svn. Cool, it is not much but it solves some of the problems on windows (and correct some of my previous mistakes). Sorry for reminding it :-). best regards Mathieu -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
