[E-devel] Re: E CVS: engage handyande
enlightenment-cvs@lists.sourceforge.net wrote: >Enlightenment CVS committal > >Author : handyande >Project : misc >Module : engage > >Dir : misc/engage/data/themes > > >Modified Files: > module.edc > > > Seems these not in the CVS yet? >+ image: "running_top.png" COMP; >+ image: "running_bottom.png" COMP; >+ image: "running_left.png" COMP; >+ image: "running_right.png" COMP; > Have fun, Dan --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Re: E CVS: engage handyande
Thanks, good point - fixed as for ignoring gkrellm - the idea is (check the FIXME) the list will be configurable, so the user can ignore anything they want... Sebastian Dransfeld wrote: > enlightenment-cvs@lists.sourceforge.net wrote: > >> Enlightenment CVS committal >> >> Author : handyande >> Project : misc >> Module : engage >> >> Dir : misc/engage/src/module >> >> >> Modified Files: >> e_mod_main.c >> >> Log Message: >> Module works with new ecore_x, no time to fix standalone right now >> === >> RCS file: /cvsroot/enlightenment/misc/engage/src/module/e_mod_main.c,v >> retrieving revision 1.48 >> retrieving revision 1.49 >> diff -u -3 -r1.48 -r1.49 >> --- e_mod_main.c9 Jun 2005 13:14:53 -1.48 >> +++ e_mod_main.c10 Jun 2005 09:24:36 -1.49 >> @@ -2293,10 +2293,13 @@ >> /* FIXME - this needs to be saved in config */ >> static char *ignores[] = { "Gkrellm2", "trayer", NULL}; >> char **cur; >> + Ecore_X_Window_State *state, *tmp; >> + unsigned int num; >> - if (ecore_x_window_prop_state_isset(bd->win, >> - ECORE_X_WINDOW_STATE_SKIP_TASKBAR)) >> - return 1; >> + ecore_x_netwm_window_state_get(bd->win, &state, &num); >> + for (tmp = state; tmp; tmp++) >> + if (tmp == ECORE_X_WINDOW_STATE_SKIP_TASKBAR) >> + return 1; >> for (cur = ignores; *cur; cur++) >> if (bd->client.icccm.class && strcmp(bd->client.icccm.class, >> *cur) == 0) > > > The state isn't nullterminated. So you should use the counter to loop > the state. And you don't have to ignore gkrellm, you can change gkrellms > behaviour to be netwm compliant. But maybe you don't want to tell users > that :) > > Sebastian > > > --- > This SF.Net email is sponsored by: NEC IT Guy Games. How far can you > shotput > a projector? How fast can you ride your desk chair down the office luge > track? > If you want to score the big prize, get to know the little guy. Play to > win an NEC 61" plasma display: http://www.necitguy.com/?r=20 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > --- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Re: E CVS: engage handyande
enlightenment-cvs@lists.sourceforge.net wrote: Enlightenment CVS committal Author : handyande Project : misc Module : engage Dir : misc/engage/src/module Modified Files: e_mod_main.c Log Message: Module works with new ecore_x, no time to fix standalone right now === RCS file: /cvsroot/enlightenment/misc/engage/src/module/e_mod_main.c,v retrieving revision 1.48 retrieving revision 1.49 diff -u -3 -r1.48 -r1.49 --- e_mod_main.c9 Jun 2005 13:14:53 - 1.48 +++ e_mod_main.c10 Jun 2005 09:24:36 - 1.49 @@ -2293,10 +2293,13 @@ /* FIXME - this needs to be saved in config */ static char *ignores[] = { "Gkrellm2", "trayer", NULL}; char **cur; + Ecore_X_Window_State *state, *tmp; + unsigned int num; - if (ecore_x_window_prop_state_isset(bd->win, - ECORE_X_WINDOW_STATE_SKIP_TASKBAR)) - return 1; + ecore_x_netwm_window_state_get(bd->win, &state, &num); + for (tmp = state; tmp; tmp++) + if (tmp == ECORE_X_WINDOW_STATE_SKIP_TASKBAR) + return 1; for (cur = ignores; *cur; cur++) if (bd->client.icccm.class && strcmp(bd->client.icccm.class, *cur) == 0) The state isn't nullterminated. So you should use the counter to loop the state. And you don't have to ignore gkrellm, you can change gkrellms behaviour to be netwm compliant. But maybe you don't want to tell users that :) Sebastian --- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Re: E CVS: engage handyande
On Wednesday, 08 June 2005, at 14:14:44 (+0100), Andrew Elcock wrote: > yes he will take time to realise, but no - it does not work, I > tested that before removing it to no avail. Here is the correct code, taken from one of almost any of the CVS modules: if test "x${bindir}" = 'x${exec_prefix}/bin'; then if test "x${exec_prefix}" = "xNONE"; then if test "x${prefix}" = "xNONE"; then bindir="${ac_default_prefix}/bin"; else bindir="${prefix}/bin"; fi else if test "x${prefix}" = "xNONE"; then bindir="${ac_default_prefix}/bin"; else bindir="${prefix}/bin"; fi fi fi if test "x${libdir}" = 'x${exec_prefix}/lib'; then if test "x${exec_prefix}" = "xNONE"; then if test "x${prefix}" = "xNONE"; then libdir="${ac_default_prefix}/lib"; else libdir="${prefix}/lib"; fi else if test "x${prefix}" = "xNONE"; then libdir="${ac_default_prefix}/lib"; else libdir="${prefix}/lib"; fi fi fi HTH, Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- "Sometimes it can last Forever, but it seldom ever lasts Forever. And we learn just how fast Forever goes." -- Howard Hewett --- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Re: E CVS: engage handyande
yes he will take time to realise, but no - it does not work, I tested that before removing it to no avail. :-p Michael Jennings wrote: > On Wednesday, 08 June 2005, at 04:00:44 (-0700), > E CVS List wrote: > > >>Log Message: >>This broke the PACKAGE_LIB_DIR, will the submitter of the patch please try >>again ;) >>=== >>RCS file: /cvsroot/enlightenment/misc/engage/configure.in,v >>retrieving revision 1.18 >>retrieving revision 1.19 >>diff -u -3 -r1.18 -r1.19 >>--- configure.in 6 Jun 2005 09:08:53 - 1.18 >>+++ configure.in 8 Jun 2005 11:00:44 - 1.19 >>@@ -39,7 +39,6 @@ >> fi >> fi >> >>-if test "x{libdir}" = "xNONE";then >> if test "x${exec_prefix}" = "xNONE"; then >> if test "x${prefix}" = "xNONE"; then >> libdir="${ac_default_prefix}/lib"; >>@@ -53,7 +52,6 @@ >> libdir="${prefix}/lib"; >> fi >> fi >>-fi > > > Will the Elcock please take about 2 seconds to realize that x{libdir} > is simply missing its $ and fix that rather than removing a very > important part of the patch? > > Michael > --- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Re: E CVS: engage handyande
On Wednesday, 08 June 2005, at 04:00:44 (-0700), E CVS List wrote: > Log Message: > This broke the PACKAGE_LIB_DIR, will the submitter of the patch please try > again ;) > === > RCS file: /cvsroot/enlightenment/misc/engage/configure.in,v > retrieving revision 1.18 > retrieving revision 1.19 > diff -u -3 -r1.18 -r1.19 > --- configure.in 6 Jun 2005 09:08:53 - 1.18 > +++ configure.in 8 Jun 2005 11:00:44 - 1.19 > @@ -39,7 +39,6 @@ >fi > fi > > -if test "x{libdir}" = "xNONE";then >if test "x${exec_prefix}" = "xNONE"; then > if test "x${prefix}" = "xNONE"; then >libdir="${ac_default_prefix}/lib"; > @@ -53,7 +52,6 @@ >libdir="${prefix}/lib"; > fi >fi > -fi Will the Elcock please take about 2 seconds to realize that x{libdir} is simply missing its $ and fix that rather than removing a very important part of the patch? Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- "You know, we're sitting on four million pounds of fuel, one nuclear weapon, and a thing that has 270 thousand moving parts built by the lowest bidder. Makes you feel good, doesn't it?" -- Steve Buscemi (Rockhound), "Armageddon" --- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel