Re: [E-devel] Small bug in evas_textblock.
On Tue, 22 Feb 2011 18:15:30 +0900 WooHyun Jung wh0705.j...@samsung.com said: tom - hmm somehow is this one related: http://trac.enlightenment.org/e/changeset/57229 suspiciously looks like its trying to fix the same bug. I've checked with ~ setting cursor to 0. And it worked fine :) I made a patch for it ~ -Original Message- From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] Sent: Tuesday, February 22, 2011 5:25 PM To: WooHyun Jung Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), though I think there's another issue hiding there, I'll take a look :) Will add the set to 0 soon. -- Tom. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: Oh. Right - return 0 is correct thing. But, why do you think - this solution will fix my issue ? I think - just returning 0 will be enough for this. From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen Sent: Tuesday, February 22, 2011 2:25 AM To: WooHyun Jung Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.com wrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- -- -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
It is the fix to that bug. I'm 99% sure I sent an email to WooHyun and list, but maybe I only sent it to WooHyun, but yeah, it's fixed. (Unless my memory is wrong). WooHyun: right? -- Tom. On Sun, 2011-02-27 at 10:59 +0100, Carsten Haitzler wrote: On Tue, 22 Feb 2011 18:15:30 +0900 WooHyun Jung wh0705.j...@samsung.com said: tom - hmm somehow is this one related: http://trac.enlightenment.org/e/changeset/57229 suspiciously looks like its trying to fix the same bug. I've checked with ~ setting cursor to 0. And it worked fine :) I made a patch for it ~ -Original Message- From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] Sent: Tuesday, February 22, 2011 5:25 PM To: WooHyun Jung Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), though I think there's another issue hiding there, I'll take a look :) Will add the set to 0 soon. -- Tom. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: Oh. Right - return 0 is correct thing. But, why do you think - this solution will fix my issue ? I think - just returning 0 will be enough for this. From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen Sent: Tuesday, February 22, 2011 2:25 AM To: WooHyun Jung Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.com wrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- -- -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
Right ~ It's fixed and working well now ^^ -Original Message- From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] Sent: Sunday, February 27, 2011 7:18 PM To: Carsten Haitzler Cc: WooHyun Jung; enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. It is the fix to that bug. I'm 99% sure I sent an email to WooHyun and list, but maybe I only sent it to WooHyun, but yeah, it's fixed. (Unless my memory is wrong). WooHyun: right? -- Tom. On Sun, 2011-02-27 at 10:59 +0100, Carsten Haitzler wrote: On Tue, 22 Feb 2011 18:15:30 +0900 WooHyun Jung wh0705.j...@samsung.com said: tom - hmm somehow is this one related: http://trac.enlightenment.org/e/changeset/57229 suspiciously looks like its trying to fix the same bug. I've checked with ~ setting cursor to 0. And it worked fine :) I made a patch for it ~ -Original Message- From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] Sent: Tuesday, February 22, 2011 5:25 PM To: WooHyun Jung Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), though I think there's another issue hiding there, I'll take a look :) Will add the set to 0 soon. -- Tom. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: Oh. Right - return 0 is correct thing. But, why do you think - this solution will fix my issue ? I think - just returning 0 will be enough for this. From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen Sent: Tuesday, February 22, 2011 2:25 AM To: WooHyun Jung Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.com wrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- -- -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), though I think there's another issue hiding there, I'll take a look :) Will add the set to 0 soon. -- Tom. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: Oh. Right - return 0 is correct thing. But, why do you think - this solution will fix my issue ? I think - just returning 0 will be enough for this. From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen Sent: Tuesday, February 22, 2011 2:25 AM To: WooHyun Jung Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.com wrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Index, Search Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
I've checked with ~ setting cursor to 0.
And it worked fine :)
I made a patch for it ~
-Original Message-
From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com]
Sent: Tuesday, February 22, 2011 5:25 PM
To: WooHyun Jung
Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] Small bug in evas_textblock.
Yeah, setting the cursor to 0 may actually fix your issue (did you try it?),
though I think there's another issue hiding there, I'll take a look :)
Will add the set to 0 soon.
--
Tom.
On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote:
Oh. Right - return 0 is correct thing.
But, why do you think - this solution will fix my issue ?
I think - just returning 0 will be enough for this.
From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom
Hacohen
Sent: Tuesday, February 22, 2011 2:25 AM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] Small bug in evas_textblock.
Dear WooHyun,
I can confirm the issue, but I don't think your solution is valid,
probably the more correct thing to do is set to 0 and return, but I
don't think this will fix your issue, but it's just a correct thing to
do :P
Anyhow, will take a look tomorrow, I'm too tired atm.
Thanks for the report,
Tom.
On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung
wh0705.j...@samsung.com
wrote:
Hello. All.
I found one small bug in evas_textblock.
For checking this bug ~ I recommend to do like following scenario.
In Entry 3 of Elementary_test,
1. Push Clr Button for the bottom entry.
2. Input 'a' and input Backspace in the bottom entry.
3. Click the top entry.
4. Click the bottom entry.
5. Input some characters.
6. Result : char is input before the last character.
So I made a patch and attached it.
Anybody can check about this ?
Thanks.
--
--
--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Index: src/lib/canvas/evas_object_textblock.c
===
--- src/lib/canvas/evas_object_textblock.c (revision 57228)
+++ src/lib/canvas/evas_object_textblock.c (working copy)
@@ -5465,7 +5465,11 @@ evas_textblock_cursor_line_char_last(Evas_Textbloc
_find_layout_item_match(cur, ln, it);
- if (!ln) return;
+ if (!ln)
+ {
+cur-pos = 0;
+return;
+ }
if (ln-items)
{
Evas_Object_Textblock_Item *i;
--
Index, Search Analyze Logs and other IT data in Real-Time with Splunk
Collect, index and harness all the fast moving IT data generated by your
applications, servers and devices whether physical, virtual or in the cloud.
Deliver compliance at lower cost and gain new business insights.
Free Software Download: http://p.sf.net/sfu/splunk-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
OK, I fixed it in somewhere else. As I suspected this was just a symptom, there was a problem with paragraph_char_last that with empty paragraphs would have set the cursor to a wrong value. Anyhow, fixed. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: Oh. Right - return 0 is correct thing. But, why do you think - this solution will fix my issue ? I think - just returning 0 will be enough for this. From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen Sent: Tuesday, February 22, 2011 2:25 AM To: WooHyun Jung Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.com wrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Index, Search Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Small bug in evas_textblock.
Hello. All.
I found one small bug in evas_textblock.
For checking this bug ~ I recommend to do like following scenario.
In Entry 3 of Elementary_test,
1. Push Clr Button for the bottom entry.
2. Input 'a' and input Backspace in the bottom entry.
3. Click the top entry.
4. Click the bottom entry.
5. Input some characters.
6. Result : char is input before the last character.
So I made a patch and attached it.
Anybody can check about this ?
Thanks.
Index: src/lib/canvas/evas_object_textblock.c
===
--- src/lib/canvas/evas_object_textblock.c (revision 57196)
+++ src/lib/canvas/evas_object_textblock.c (working copy)
@@ -5465,7 +5465,11 @@ evas_textblock_cursor_line_char_last(Evas_Textbloc
_find_layout_item_match(cur, ln, it);
- if (!ln) return;
+ if (!ln)
+ {
+cur-pos++;
+return;
+ }
if (ln-items)
{
Evas_Object_Textblock_Item *i;
--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.comwrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
Oh. Right - return 0 is correct thing. But, why do you think - this solution will fix my issue ? I think - just returning 0 will be enough for this. From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen Sent: Tuesday, February 22, 2011 2:25 AM To: WooHyun Jung Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Dear WooHyun, I can confirm the issue, but I don't think your solution is valid, probably the more correct thing to do is set to 0 and return, but I don't think this will fix your issue, but it's just a correct thing to do :P Anyhow, will take a look tomorrow, I'm too tired atm. Thanks for the report, Tom. On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung wh0705.j...@samsung.com wrote: Hello. All. I found one small bug in evas_textblock. For checking this bug ~ I recommend to do like following scenario. In Entry 3 of Elementary_test, 1. Push Clr Button for the bottom entry. 2. Input 'a' and input Backspace in the bottom entry. 3. Click the top entry. 4. Click the bottom entry. 5. Input some characters. 6. Result : char is input before the last character. So I made a patch and attached it. Anybody can check about this ? Thanks. -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Index, Search Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
