Re: [E-devel] eo_isa() buggy
looks like my bad, maybe I forgot to rebase on the branch... I've checked and it's fixed now! Thanks! On Thu, Dec 8, 2016 at 12:23 PM, Tom Hacohenwrote: > On 07/12/16 20:18, Gustavo Sverzut Barbieri wrote: >> On Wed, Dec 7, 2016 at 12:00 PM, Tom Hacohen wrote: >>> Hey, >>> >>> I just pushed 5424cdbd810042ba59e71bec6b8d91cb6a2c3e9c that I hope >>> should fix it. This commit fixes a bug I've known for a while and just >>> forgot to fix. From your description, I believe it is the same issue, >>> but please verify. >>> >>> Thanks for reporting. >> >> great fix, but didn't fix my issue yet. Try with the >> efl_net_dialer_simple_example using SSL: >> >> ./src/examples/ecore/efl_net_dialer_simple_example ssl localhost:1234 >> >> This uses: >> >> Efl.Net.Dialer.Ssl -> Efl.Net.Dialer, Efl.Net.Socket.Ssl >> >> Efl.Net.Dialer -> Efl.Net.Socket -> Efl.Io.Reader, Efl.Io.Writer >> >> Efl.Net.Socket.Ssl -> Efl.Loop_User, Efl.Net.Socket -> Efl.Io.Reader, >> Efl.Io.Writer >> >> what's funny is that it works for other complex hierarchies, such as: >> >> Efl.Net.Dialer.Tcp -> Efl.Net.Dialer, Efl.Net.Socket.Tcp >> >> Efl.Net.Socket.Tcp -> Efl.Net.Socket.Fd -> Efl.Loop_Fd. Efl.Net.Socket >> -> Efl.Io.Reader, Efl.Io.Writer >> >> as you can see, it's even more complex since uses Efl.Net.Socket.Fd! >> >> > > Are you sure you tested with my fix? I just ran the example and got: > > % ./efl_net_dialer_simple_example ssl localhost:1234 > INFO: sending 'Hello World!' > INFO: end of stream. > -- BEGIN RECEIVED DATA -- > -- END RECEIVED DATA-- > INFO: done receiving > ^C > INFO: main loop finished. > > Looks correct to me. > > -- > Tom > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today.http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] eo_isa() buggy
On 07/12/16 20:18, Gustavo Sverzut Barbieri wrote: > On Wed, Dec 7, 2016 at 12:00 PM, Tom Hacohenwrote: >> Hey, >> >> I just pushed 5424cdbd810042ba59e71bec6b8d91cb6a2c3e9c that I hope >> should fix it. This commit fixes a bug I've known for a while and just >> forgot to fix. From your description, I believe it is the same issue, >> but please verify. >> >> Thanks for reporting. > > great fix, but didn't fix my issue yet. Try with the > efl_net_dialer_simple_example using SSL: > > ./src/examples/ecore/efl_net_dialer_simple_example ssl localhost:1234 > > This uses: > > Efl.Net.Dialer.Ssl -> Efl.Net.Dialer, Efl.Net.Socket.Ssl > > Efl.Net.Dialer -> Efl.Net.Socket -> Efl.Io.Reader, Efl.Io.Writer > > Efl.Net.Socket.Ssl -> Efl.Loop_User, Efl.Net.Socket -> Efl.Io.Reader, > Efl.Io.Writer > > what's funny is that it works for other complex hierarchies, such as: > > Efl.Net.Dialer.Tcp -> Efl.Net.Dialer, Efl.Net.Socket.Tcp > > Efl.Net.Socket.Tcp -> Efl.Net.Socket.Fd -> Efl.Loop_Fd. Efl.Net.Socket > -> Efl.Io.Reader, Efl.Io.Writer > > as you can see, it's even more complex since uses Efl.Net.Socket.Fd! > > Are you sure you tested with my fix? I just ran the example and got: % ./efl_net_dialer_simple_example ssl localhost:1234 INFO: sending 'Hello World!' INFO: end of stream. -- BEGIN RECEIVED DATA -- -- END RECEIVED DATA-- INFO: done receiving ^C INFO: main loop finished. Looks correct to me. -- Tom -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] eo_isa() buggy
On Wed, Dec 7, 2016 at 12:00 PM, Tom Hacohenwrote: > Hey, > > I just pushed 5424cdbd810042ba59e71bec6b8d91cb6a2c3e9c that I hope > should fix it. This commit fixes a bug I've known for a while and just > forgot to fix. From your description, I believe it is the same issue, > but please verify. > > Thanks for reporting. great fix, but didn't fix my issue yet. Try with the efl_net_dialer_simple_example using SSL: ./src/examples/ecore/efl_net_dialer_simple_example ssl localhost:1234 This uses: Efl.Net.Dialer.Ssl -> Efl.Net.Dialer, Efl.Net.Socket.Ssl Efl.Net.Dialer -> Efl.Net.Socket -> Efl.Io.Reader, Efl.Io.Writer Efl.Net.Socket.Ssl -> Efl.Loop_User, Efl.Net.Socket -> Efl.Io.Reader, Efl.Io.Writer what's funny is that it works for other complex hierarchies, such as: Efl.Net.Dialer.Tcp -> Efl.Net.Dialer, Efl.Net.Socket.Tcp Efl.Net.Socket.Tcp -> Efl.Net.Socket.Fd -> Efl.Loop_Fd. Efl.Net.Socket -> Efl.Io.Reader, Efl.Io.Writer as you can see, it's even more complex since uses Efl.Net.Socket.Fd! -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] eo_isa() buggy
Hey, I just pushed 5424cdbd810042ba59e71bec6b8d91cb6a2c3e9c that I hope should fix it. This commit fixes a bug I've known for a while and just forgot to fix. From your description, I believe it is the same issue, but please verify. Thanks for reporting. -- Tom. On 07/12/16 02:14, Gustavo Sverzut Barbieri wrote: > eo_isa(o, iface) is buggy as shown with: > > EINA_LOG_LEVELS=eo:4 EFL_RUN_IN_TREE=1 libtool --mode=execute sh > ./src/scripts/eo/eo_debug > ./src/examples/ecore/efl_net_dialer_simple_example ssl localhost:1234 > > It will report Efl_Net_Dialer_Ssl fails efl_isa() with both > Efl_Io_Reader and Efl_Io_Writer, not in the message but also seems to > fail Efl_Io_Closer (not a critical error for that usage). > > These are declared as: > > class Efl.Net.Dialer.Ssl (Efl.Net.Socket.Ssl, Efl.Net.Dialer); > class Efl.Net.Socket.Ssl (Efl.Loop_User, Efl.Net.Socket); > interface Efl.Net.Dialer (Efl.Net.Socket); > interface Efl.Net.Socket (Efl.Io.Reader, Efl.Io.Writer, Efl.Io.Closer); > > then both Efl.Net.Socket.Ssl AND Efl.Net.Dialer would lead to these 3 > interfaces. > > Log (removed function names to be shorter) also says they are added to > the methods vtable: > > DBG<20851>:eo lib/eo/eo.c:1334 Started building extensions list for > class 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1366 Finished building extensions list for > class 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1371 Started building MRO list for class > 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1382 Finished building MRO list for class > 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1390 Started building Mixins list for class > 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1404 Finished building Mixins list for class > 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1444 Added 'Efl_Io_Writer' extension > DBG<20851>:eo lib/eo/eo.c:1444 Added 'Efl_Io_Closer' extension > DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Net_Socket' to MRO > DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Io_Closer' to MRO > DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Io_Reader' to MRO > DBG<20851>:eo lib/eo/eo.c:699 Set functions for class > 'Efl_Net_Socket':0x556186c12ff0 > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989c40->(nil) > 'efl_net_socket_address_local_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989e00->(nil) > 'efl_net_socket_address_local_set' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989fa0->(nil) > 'efl_net_socket_address_remote_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5398a160->(nil) > 'efl_net_socket_address_remote_set' > DBG<20851>:eo lib/eo/eo.c:699 Set functions for class > 'Efl_Net_Socket':0x556186c12ff0 > DBG<20851>:eo lib/eo/eo.c:1535 Finished building class 'Efl_Net_Socket' > DBG<20851>:eo lib/eo/eo.c:1334 Started building extensions list for > class 'Efl_Net_Socket_Ssl' > DBG<20851>:eo lib/eo/eo.c:1366 Finished building extensions list for > class 'Efl_Net_Socket_Ssl' > DBG<20851>:eo lib/eo/eo.c:1371 Started building MRO list for class > 'Efl_Net_Socket_Ssl' > DBG<20851>:eo lib/eo/eo.c:1382 Finished building MRO list for class > 'Efl_Net_Socket_Ssl' > DBG<20851>:eo lib/eo/eo.c:1390 Started building Mixins list for class > 'Efl_Net_Socket_Ssl' > DBG<20851>:eo lib/eo/eo.c:1404 Finished building Mixins list for class > 'Efl_Net_Socket_Ssl' > DBG<20851>:eo lib/eo/eo.c:1444 Added 'Efl_Net_Socket' extension > DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Net_Socket_Ssl' to MRO > DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Loop_User' to MRO > DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Object' to MRO > DBG<20851>:eo lib/eo/eo.c:699 Set functions for class > 'Efl_Net_Socket_Ssl':0x556186c134c0 > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53c0ed80->0x7fdc539b5220 'efl_constructor' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53c0ef40->0x7fdc539b5270 'efl_destructor' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53c0f0e0->0x7fdc539b53f0 'efl_finalize' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f7e0->0x7fdc539b5560 > 'efl_io_closer_close' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133edb0->0x7fdc539b5620 > 'efl_io_closer_closed_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f2d0->0x7fdc539b5670 > 'efl_io_closer_close_on_exec_set' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f120->0x7fdc539b56c0 > 'efl_io_closer_close_on_exec_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f640->0x7fdc539b5710 > 'efl_io_closer_close_on_destructor_set' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f490->0x7fdc539b5750 > 'efl_io_closer_close_on_destructor_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340aa0->0x7fdc539b57a0 > 'efl_io_reader_read' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc513405b0->0x7fdc539b5890 > 'efl_io_reader_can_read_set' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340400->0x7fdc539b5930 > 'efl_io_reader_can_read_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340900->0x7fdc539b5950 > 'efl_io_reader_eos_set' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340750->0x7fdc539b5a00 > 'efl_io_reader_eos_get' > DBG<20851>:eo lib/eo/eo.c:747 0x7fdc513419b0->0x7fdc539b5a20 > 'efl_io_writer_write' > DBG<20851>:eo lib/eo/eo.c:747
[E-devel] eo_isa() buggy
eo_isa(o, iface) is buggy as shown with: EINA_LOG_LEVELS=eo:4 EFL_RUN_IN_TREE=1 libtool --mode=execute sh ./src/scripts/eo/eo_debug ./src/examples/ecore/efl_net_dialer_simple_example ssl localhost:1234 It will report Efl_Net_Dialer_Ssl fails efl_isa() with both Efl_Io_Reader and Efl_Io_Writer, not in the message but also seems to fail Efl_Io_Closer (not a critical error for that usage). These are declared as: class Efl.Net.Dialer.Ssl (Efl.Net.Socket.Ssl, Efl.Net.Dialer); class Efl.Net.Socket.Ssl (Efl.Loop_User, Efl.Net.Socket); interface Efl.Net.Dialer (Efl.Net.Socket); interface Efl.Net.Socket (Efl.Io.Reader, Efl.Io.Writer, Efl.Io.Closer); then both Efl.Net.Socket.Ssl AND Efl.Net.Dialer would lead to these 3 interfaces. Log (removed function names to be shorter) also says they are added to the methods vtable: DBG<20851>:eo lib/eo/eo.c:1334 Started building extensions list for class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1366 Finished building extensions list for class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1371 Started building MRO list for class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1382 Finished building MRO list for class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1390 Started building Mixins list for class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1404 Finished building Mixins list for class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1444 Added 'Efl_Io_Writer' extension DBG<20851>:eo lib/eo/eo.c:1444 Added 'Efl_Io_Closer' extension DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Net_Socket' to MRO DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Io_Closer' to MRO DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Io_Reader' to MRO DBG<20851>:eo lib/eo/eo.c:699 Set functions for class 'Efl_Net_Socket':0x556186c12ff0 DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989c40->(nil) 'efl_net_socket_address_local_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989e00->(nil) 'efl_net_socket_address_local_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989fa0->(nil) 'efl_net_socket_address_remote_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5398a160->(nil) 'efl_net_socket_address_remote_set' DBG<20851>:eo lib/eo/eo.c:699 Set functions for class 'Efl_Net_Socket':0x556186c12ff0 DBG<20851>:eo lib/eo/eo.c:1535 Finished building class 'Efl_Net_Socket' DBG<20851>:eo lib/eo/eo.c:1334 Started building extensions list for class 'Efl_Net_Socket_Ssl' DBG<20851>:eo lib/eo/eo.c:1366 Finished building extensions list for class 'Efl_Net_Socket_Ssl' DBG<20851>:eo lib/eo/eo.c:1371 Started building MRO list for class 'Efl_Net_Socket_Ssl' DBG<20851>:eo lib/eo/eo.c:1382 Finished building MRO list for class 'Efl_Net_Socket_Ssl' DBG<20851>:eo lib/eo/eo.c:1390 Started building Mixins list for class 'Efl_Net_Socket_Ssl' DBG<20851>:eo lib/eo/eo.c:1404 Finished building Mixins list for class 'Efl_Net_Socket_Ssl' DBG<20851>:eo lib/eo/eo.c:1444 Added 'Efl_Net_Socket' extension DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Net_Socket_Ssl' to MRO DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Loop_User' to MRO DBG<20851>:eo lib/eo/eo.c:1457 Added 'Efl_Object' to MRO DBG<20851>:eo lib/eo/eo.c:699 Set functions for class 'Efl_Net_Socket_Ssl':0x556186c134c0 DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53c0ed80->0x7fdc539b5220 'efl_constructor' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53c0ef40->0x7fdc539b5270 'efl_destructor' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53c0f0e0->0x7fdc539b53f0 'efl_finalize' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f7e0->0x7fdc539b5560 'efl_io_closer_close' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133edb0->0x7fdc539b5620 'efl_io_closer_closed_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f2d0->0x7fdc539b5670 'efl_io_closer_close_on_exec_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f120->0x7fdc539b56c0 'efl_io_closer_close_on_exec_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f640->0x7fdc539b5710 'efl_io_closer_close_on_destructor_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc5133f490->0x7fdc539b5750 'efl_io_closer_close_on_destructor_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340aa0->0x7fdc539b57a0 'efl_io_reader_read' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc513405b0->0x7fdc539b5890 'efl_io_reader_can_read_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340400->0x7fdc539b5930 'efl_io_reader_can_read_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340900->0x7fdc539b5950 'efl_io_reader_eos_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51340750->0x7fdc539b5a00 'efl_io_reader_eos_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc513419b0->0x7fdc539b5a20 'efl_io_writer_write' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51341810->0x7fdc539b5b70 'efl_io_writer_can_write_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc51341660->0x7fdc539b5c10 'efl_io_writer_can_write_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989fa0->0x7fdc539b5c30 'efl_net_socket_address_remote_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc53989c40->0x7fdc539b5c80 'efl_net_socket_address_local_get' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc539b4410->0x7fdc539b5cd0 'efl_net_socket_ssl_verify_mode_set' DBG<20851>:eo lib/eo/eo.c:747 0x7fdc539b45b0->0x7fdc539b5d30