Re: [E-devel] [EGIT] [apps/terminology] master 01/01: themes - fix new error checks in edje_cc
On Fri, 18 Jan 2019 13:31:14 -0500 Mike Blumenkrantz
said:
i find a bug, i fix a bug. this is what i have done for decades since i started
this project. it took me maybe about 10 mins to do this fix. we're going to
waste far more than that just discussing this.
> Hi,
>
> While it has been made clear that you are going to continue to not use
> patch review for your own code, it would still be greatly appreciated if
> you could--at a minimum--check the pending patch queue in order to avoid
> wasting other peoples' time when they submit their work for review.
>
> In this specific case, I had posted patches (1) for resolving the same
> issues here and had also taken the time to notify Boris about the patches.
> I have seen other people raise this same complaint on more than one
> occasion, so this is clearly not an isolated case.
>
>
> Thanks,
> Mike
>
> 1.
> https://phab.enlightenment.org/D7689
> https://phab.enlightenment.org/D7690
>
> On Fri, Jan 18, 2019 at 1:13 PM Carsten Haitzler
> wrote:
>
> > raster pushed a commit to branch master.
> >
> >
> > http://git.enlightenment.org/apps/terminology.git/commit/?id=5abb8b0eb316b048c80fd7d292d1598b3392bd23
> >
> > commit 5abb8b0eb316b048c80fd7d292d1598b3392bd23
> > Author: Carsten Haitzler (Rasterman)
> > Date: Fri Jan 18 18:12:45 2019 +
> >
> > themes - fix new error checks in edje_cc
> >
> > where parts/states etc. dont exist.
> > ---
> > data/themes/mild.edc| 4
> > data/themes/nyanology/nyanology.edc | 31 +--
> > 2 files changed, 29 insertions(+), 6 deletions(-)
> >
> > diff --git a/data/themes/mild.edc b/data/themes/mild.edc
> > index 4a51c4b..a75cba0 100644
> > --- a/data/themes/mild.edc
> > +++ b/data/themes/mild.edc
> > @@ -1208,7 +1208,6 @@ collections {
> > target: "popmedia_clip";
> > target: "popmedia_dismiss";
> > target: "popmedia_shadow";
> > -target: "popmedia_fill";
> > target: "popmedia_overlay";
> > target: "popmedia_bevel";
> > target: "popmedia_glint";
> > @@ -1223,7 +1222,6 @@ collections {
> > target: "popmedia_clip";
> > target: "popmedia_dismiss";
> > target: "popmedia_shadow";
> > -target: "popmedia_fill";
> > target: "popmedia_overlay";
> > target: "popmedia_bevel";
> > target: "popmedia_glint";
> > @@ -1238,7 +1236,6 @@ collections {
> > target: "popmedia_clip";
> > target: "popmedia_dismiss";
> > target: "popmedia_shadow";
> > -target: "popmedia_fill";
> > target: "popmedia_overlay";
> > target: "popmedia_bevel";
> > target: "popmedia_glint";
> > @@ -1253,7 +1250,6 @@ collections {
> > target: "popmedia_clip";
> > target: "popmedia_dismiss";
> > target: "popmedia_shadow";
> > -target: "popmedia_fill";
> > target: "popmedia_overlay";
> > target: "popmedia_bevel";
> > target: "popmedia_glint";
> > diff --git a/data/themes/nyanology/nyanology.edc
> > b/data/themes/nyanology/nyanology.edc
> > index bc06124..5b07a77 100644
> > --- a/data/themes/nyanology/nyanology.edc
> > +++ b/data/themes/nyanology/nyanology.edc
> > @@ -95,6 +95,15 @@ collections {
> > description { state: "oneline" 0.0;
> > visible: 0;
> > }
> > +description { state: "disjoint" 0.0;
> > + inherit: "default" 0.0;
> > +}
> > +description { state: "topfull" 0.0;
> > + inherit: "default" 0.0;
> > +}
> > +description { state: "bottomfull" 0.0;
> > + inherit: "default" 0.0;
> > +}
> > }
> > part { name: "middle_clip"; type: RECT;
> > mouse_events: 0;
> > @@ -110,6 +119,15 @@ collections {
> > rel2.to: "terminology.bottom_right";
> > rel2.relative: 0.0 1.0;
> > }
> > +description { state: "disjoint" 0.0;
> > + inherit: "default" 0.0;
> > +}
> > +description { state: "topfull" 0.0;
> > + inherit: "default" 0.0;
> > +}
> > +description { state: "bottomfull" 0.0;
> > + inherit: "default" 0.0;
> > +}
> > }
> > part { name: "bottom_clip"; type: RECT;
> > mouse_events: 0;
> > @@ -118,10 +136,19 @@ collections {
> > rel1.relative: 0.0 0.0;
> > rel2.to_x: "terminology.bottom_right";
> > rel2.relative: 0.0 1.0;
> > -}
> > -description { state: "oneline" 0.0;
> > + }
> > + description { state: "oneline" 0.0;
> > visible: 0;
> > }
> > +description {
Re: [E-devel] [EGIT] [apps/terminology] master 01/01: themes - fix new error checks in edje_cc
Hi,
While it has been made clear that you are going to continue to not use
patch review for your own code, it would still be greatly appreciated if
you could--at a minimum--check the pending patch queue in order to avoid
wasting other peoples' time when they submit their work for review.
In this specific case, I had posted patches (1) for resolving the same
issues here and had also taken the time to notify Boris about the patches.
I have seen other people raise this same complaint on more than one
occasion, so this is clearly not an isolated case.
Thanks,
Mike
1.
https://phab.enlightenment.org/D7689
https://phab.enlightenment.org/D7690
On Fri, Jan 18, 2019 at 1:13 PM Carsten Haitzler
wrote:
> raster pushed a commit to branch master.
>
>
> http://git.enlightenment.org/apps/terminology.git/commit/?id=5abb8b0eb316b048c80fd7d292d1598b3392bd23
>
> commit 5abb8b0eb316b048c80fd7d292d1598b3392bd23
> Author: Carsten Haitzler (Rasterman)
> Date: Fri Jan 18 18:12:45 2019 +
>
> themes - fix new error checks in edje_cc
>
> where parts/states etc. dont exist.
> ---
> data/themes/mild.edc| 4
> data/themes/nyanology/nyanology.edc | 31 +--
> 2 files changed, 29 insertions(+), 6 deletions(-)
>
> diff --git a/data/themes/mild.edc b/data/themes/mild.edc
> index 4a51c4b..a75cba0 100644
> --- a/data/themes/mild.edc
> +++ b/data/themes/mild.edc
> @@ -1208,7 +1208,6 @@ collections {
> target: "popmedia_clip";
> target: "popmedia_dismiss";
> target: "popmedia_shadow";
> -target: "popmedia_fill";
> target: "popmedia_overlay";
> target: "popmedia_bevel";
> target: "popmedia_glint";
> @@ -1223,7 +1222,6 @@ collections {
> target: "popmedia_clip";
> target: "popmedia_dismiss";
> target: "popmedia_shadow";
> -target: "popmedia_fill";
> target: "popmedia_overlay";
> target: "popmedia_bevel";
> target: "popmedia_glint";
> @@ -1238,7 +1236,6 @@ collections {
> target: "popmedia_clip";
> target: "popmedia_dismiss";
> target: "popmedia_shadow";
> -target: "popmedia_fill";
> target: "popmedia_overlay";
> target: "popmedia_bevel";
> target: "popmedia_glint";
> @@ -1253,7 +1250,6 @@ collections {
> target: "popmedia_clip";
> target: "popmedia_dismiss";
> target: "popmedia_shadow";
> -target: "popmedia_fill";
> target: "popmedia_overlay";
> target: "popmedia_bevel";
> target: "popmedia_glint";
> diff --git a/data/themes/nyanology/nyanology.edc
> b/data/themes/nyanology/nyanology.edc
> index bc06124..5b07a77 100644
> --- a/data/themes/nyanology/nyanology.edc
> +++ b/data/themes/nyanology/nyanology.edc
> @@ -95,6 +95,15 @@ collections {
> description { state: "oneline" 0.0;
> visible: 0;
> }
> +description { state: "disjoint" 0.0;
> + inherit: "default" 0.0;
> +}
> +description { state: "topfull" 0.0;
> + inherit: "default" 0.0;
> +}
> +description { state: "bottomfull" 0.0;
> + inherit: "default" 0.0;
> +}
> }
> part { name: "middle_clip"; type: RECT;
> mouse_events: 0;
> @@ -110,6 +119,15 @@ collections {
> rel2.to: "terminology.bottom_right";
> rel2.relative: 0.0 1.0;
> }
> +description { state: "disjoint" 0.0;
> + inherit: "default" 0.0;
> +}
> +description { state: "topfull" 0.0;
> + inherit: "default" 0.0;
> +}
> +description { state: "bottomfull" 0.0;
> + inherit: "default" 0.0;
> +}
> }
> part { name: "bottom_clip"; type: RECT;
> mouse_events: 0;
> @@ -118,10 +136,19 @@ collections {
> rel1.relative: 0.0 0.0;
> rel2.to_x: "terminology.bottom_right";
> rel2.relative: 0.0 1.0;
> -}
> -description { state: "oneline" 0.0;
> + }
> + description { state: "oneline" 0.0;
> visible: 0;
> }
> +description { state: "disjoint" 0.0;
> + inherit: "default" 0.0;
> +}
> +description { state: "topfull" 0.0;
> + inherit: "default" 0.0;
> +}
> +description { state: "bottomfull" 0.0;
> + inherit: "default" 0.0;
> +}
> }
>
> // the outline around the selection...
>
> --
>
>
>
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
