Re: [E-devel] [PATCH] wallpaper2: implement close/apply buttons
In Svn now. Thanks :) Dh -Original Message- From: thomasg [mailto:tho...@gstaedtner.net] Sent: 01 August 2012 19:49 To: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [PATCH] wallpaper2: implement close/apply buttons On Wed, Aug 1, 2012 at 8:34 PM, thomasg tho...@gstaedtner.net wrote: On Wed, Aug 1, 2012 at 8:02 PM, Thomas Gstädtner tho...@gstaedtner.net wrote: This patch adds a close and a apply button the the conf_wallpaper2 module. It is implemented in an extremely simple way and does NOT have the advanced features brought by E_Dialog (like disabling after apply). This way the selector is much more usable without having to move to E_Dialog completely, and thus keeping its unique design which differs from typical dialogs. If the whole module should be ported to E_Dialog instead, please let me know. Signed-off-by: Thomas Gstädtner tho...@gstaedtner.net --- .../conf_wallpaper2/e_int_config_wallpaper.c | 30 ++- 1 files changed, 28 insertions(+), 2 deletions(-) Whoops, of course I sent the wrong patch with the buttons still disabled... Ignore the first one, here comes the correct one. Sorry for the inconvenience. ~thomasg Due to popular demand, clean up trailing whitespaces for conf_wallpaper2 :P Patch is based on the previous one. ~thomasg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] wallpaper2: implement close/apply buttons
On Wed, Aug 1, 2012 at 8:02 PM, Thomas Gstädtner tho...@gstaedtner.net wrote: This patch adds a close and a apply button the the conf_wallpaper2 module. It is implemented in an extremely simple way and does NOT have the advanced features brought by E_Dialog (like disabling after apply). This way the selector is much more usable without having to move to E_Dialog completely, and thus keeping its unique design which differs from typical dialogs. If the whole module should be ported to E_Dialog instead, please let me know. Signed-off-by: Thomas Gstädtner tho...@gstaedtner.net --- .../conf_wallpaper2/e_int_config_wallpaper.c | 30 ++- 1 files changed, 28 insertions(+), 2 deletions(-) Whoops, of course I sent the wrong patch with the buttons still disabled... Ignore the first one, here comes the correct one. Sorry for the inconvenience. ~thomasg 0001-wallpaper2-implement-close-apply-buttons.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] wallpaper2: implement close/apply buttons
On Wed, Aug 1, 2012 at 8:34 PM, thomasg tho...@gstaedtner.net wrote: On Wed, Aug 1, 2012 at 8:02 PM, Thomas Gstädtner tho...@gstaedtner.net wrote: This patch adds a close and a apply button the the conf_wallpaper2 module. It is implemented in an extremely simple way and does NOT have the advanced features brought by E_Dialog (like disabling after apply). This way the selector is much more usable without having to move to E_Dialog completely, and thus keeping its unique design which differs from typical dialogs. If the whole module should be ported to E_Dialog instead, please let me know. Signed-off-by: Thomas Gstädtner tho...@gstaedtner.net --- .../conf_wallpaper2/e_int_config_wallpaper.c | 30 ++- 1 files changed, 28 insertions(+), 2 deletions(-) Whoops, of course I sent the wrong patch with the buttons still disabled... Ignore the first one, here comes the correct one. Sorry for the inconvenience. ~thomasg Due to popular demand, clean up trailing whitespaces for conf_wallpaper2 :P Patch is based on the previous one. ~thomasg 0001-wallpaper2-remove-trailing-whitespaces.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] wallpaper2: implement close/apply buttons
On 01/08/12 19:34, thomasg wrote: On Wed, Aug 1, 2012 at 8:02 PM, Thomas Gstädtner tho...@gstaedtner.net wrote: This patch adds a close and a apply button the the conf_wallpaper2 module. It is implemented in an extremely simple way and does NOT have the advanced features brought by E_Dialog (like disabling after apply). This way the selector is much more usable without having to move to E_Dialog completely, and thus keeping its unique design which differs from typical dialogs. If the whole module should be ported to E_Dialog instead, please let me know. Signed-off-by: Thomas Gstädtner tho...@gstaedtner.net --- .../conf_wallpaper2/e_int_config_wallpaper.c | 30 ++- 1 files changed, 28 insertions(+), 2 deletions(-) Whoops, of course I sent the wrong patch with the buttons still disabled... Ignore the first one, here comes the correct one. Sorry for the inconvenience. ~thomasg Looks good. If nobody applies between now and tomorrow, I will do so when I get to work. Cheers, dh -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
