Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
Please review this patch. When inheriting group, program.after can be duplicated currently. But I think that duplicated program.after is not needed when inherting. If user want that after can be called twice, it's better to add one more after intentionally 2012/11/8 Bluezery ohpo...@gmail.com: Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- BRs, Kim. -- Keep yourself connected to Go Parallel: TUNE You got it built. Now make it sing. Tune shows you how. http://goparallel.sourceforge.net ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
2012/11/9 Daniel Juyung Seo seojuyu...@gmail.com: thanks for the quick fix. btw how can i reproduce/check the bug? I don't know this is a bug or intended. if duplicated after usage is wrong case, it's a bug. Daniel Juyung Seo (SeoZ) On Nov 8, 2012 6:37 PM, Bluezery ohpo...@gmail.com wrote: Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
thanks for the quick fix. btw how can i reproduce/check the bug? Daniel Juyung Seo (SeoZ) On Nov 8, 2012 6:37 PM, Bluezery ohpo...@gmail.com wrote: Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. edje_cc@fix_inherit_after.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
