Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2013-02-19 Thread Leif Middelschulte
Just as an explenation: I added timestamps, so one could add a browser for the 
remembered configurations and eventually remove any one won't use anymore. But 
since this configuration browser won't be added, I guess we could just as well 
remove this entry. 

-- 
Leif


Am Dienstag, 19. Februar 2013 um 11:54 schrieb Enlightenment SVN:

 Log:
 Remove timestamps from config (not needed).
 Add randr versions to header.
 
 Signed-off-by: Christopher Michael cp.mich...@samsung.com 
 (mailto:cp.mich...@samsung.com)
 
 Author: devilhorns
 Date: 2013-02-19 02:54:49 -0800 (Tue, 19 Feb 2013)
 New Revision: 84111
 Trac: http://trac.enlightenment.org/e/changeset/84111
 
 Modified:
 trunk/e/src/bin/e_randr.h 
 
 Modified: trunk/e/src/bin/e_randr.h
 ===
 --- trunk/e/src/bin/e_randr.h 2013-02-19 10:54:44 UTC (rev 84110)
 +++ trunk/e/src/bin/e_randr.h 2013-02-19 10:54:49 UTC (rev 84111)
 @@ -8,6 +8,11 @@
 # ifndef E_RANDR_H
 # define E_RANDR_H
 
 +#define E_RANDR_VERSION_1_1 ((1  16) | 1)
 +#define E_RANDR_VERSION_1_2 ((1  16) | 2)
 +#define E_RANDR_VERSION_1_3 ((1  16) | 3)
 +#define E_RANDR_VERSION_1_4 ((1  16) | 4)
 +
 #define E_RANDR_CONFIG_FILE_EPOCH 1
 #define E_RANDR_CONFIG_FILE_GENERATION 1
 #define E_RANDR_CONFIG_FILE_VERSION \
 @@ -21,7 +26,6 @@
 unsigned char primary; // flag to indicate if primary output
 unsigned long edid_count; // monitor's edid length
 unsigned char *edid; // monitor's edid
 - double timestamp; // config timestamp
 };
 
 struct _E_Randr_Crtc_Config
 @@ -31,35 +35,15 @@
 unsigned int orient; // value of the ecore_x_randr_orientation
 unsigned int mode; // ecore_x_randr mode id (xid)
 Eina_List *outputs; // list of outputs for this crtc
 - double timestamp; // config timestamp
 };
 
 struct _E_Randr_Config
 {
 - /* RANDR CONFIG
 - * 
 - * Screen:
 - * width, height (int);
 - * 
 - * list of crtcs
 - * each crtc having:
 - * unsigned int crtc_id (Ecore_X_ID);
 - * int x, y, w, h; (Eina_Rectangle);
 - * unsigned int orientation (Ecore_X_Randr_Orienation);
 - * unsigned int mode_id (Ecore_X_ID);
 - * list of outputs
 - * each output having:
 - * unsigned int output_id (Ecore_X_ID);
 - * unsigned int crtc_id (Ecore_X_ID);
 - * unsigned int output_policy;
 - */
 -
 int version; // INTERNAL CONFIG VERSION
 
 struct
 {
 int width, height; // geometry
 - double timestamp; // config timestamp
 } screen;
 
 Eina_List *crtcs;
 
 
 --
 Everyone hates slow websites. So do we.
 Make your web apps faster with AppDynamics
 Download AppDynamics Lite for free today:
 http://p.sf.net/sfu/appdyn_d2d_feb
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net 
 (mailto:enlightenment-...@lists.sourceforge.net)
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
 
 


--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-07-27 Thread Christopher Michael
Thanks Mike, owe you a cold one ;) Will test it out soon.

Cheers,
dh

On 07/26/11 22:36, Mike McCormack wrote:

 On 07/26/2011 11:23 PM, Christopher Michael wrote:
 Heh yea :( pretty odd, but I haven't stopped to look into why yet :) I
 just fixed it and moved on ;) Will look into 'why' later :)

 Hopefully SVN @61783 will fix it.

 thanks,

 Mike


--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-07-26 Thread Daniel Juyung Seo
need braces to compile this?
what's the difference?

Daniel Juyung Seo (SeoZ)
On Jul 26, 2011 11:04 PM, Enlightenment SVN no-re...@enlightenment.org
wrote:
 Log:
 E: Grrr, fix previous commit to actually compile.



 Author: devilhorns
 Date: 2011-07-26 07:04:14 -0700 (Tue, 26 Jul 2011)
 New Revision: 61762
 Trac: http://trac.enlightenment.org/e/changeset/61762

 Modified:
 trunk/e/src/bin/e_main.c

 Modified: trunk/e/src/bin/e_main.c
 ===
 --- trunk/e/src/bin/e_main.c 2011-07-26 14:00:54 UTC (rev 61761)
 +++ trunk/e/src/bin/e_main.c 2011-07-26 14:04:14 UTC (rev 61762)
 @@ -392,7 +392,9 @@

 TS(E_Randr Init);
 if (!e_randr_init())
 - e_error_message_show(_(Enlightenment cannot initialize E_Randr!\n));
 + {
 + e_error_message_show(_(Enlightenment cannot initialize E_Randr!\n));
 + }
 else
 _e_main_shutdown_push(e_randr_shutdown);
 TS(E_Randr Init Done);



--
 Magic Quadrant for Content-Aware Data Loss Prevention
 Research study explores the data loss prevention market. Includes in-depth
 analysis on the changes within the DLP market, and the criteria used to
 evaluate the strengths and weaknesses of these DLP solutions.
 http://www.accelacomm.com/jaw/sfnl/114/51385063/
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-07-26 Thread Christopher Michael
Heh yea :( pretty odd, but I haven't stopped to look into why yet :) I 
just fixed it and moved on ;) Will look into 'why' later :)

dh

On 07/26/11 10:13, Daniel Juyung Seo wrote:
 need braces to compile this?
 what's the difference?

 Daniel Juyung Seo (SeoZ)
 On Jul 26, 2011 11:04 PM, Enlightenment SVNno-re...@enlightenment.org
 wrote:
 Log:
 E: Grrr, fix previous commit to actually compile.



 Author: devilhorns
 Date: 2011-07-26 07:04:14 -0700 (Tue, 26 Jul 2011)
 New Revision: 61762
 Trac: http://trac.enlightenment.org/e/changeset/61762

 Modified:
 trunk/e/src/bin/e_main.c

 Modified: trunk/e/src/bin/e_main.c
 ===
 --- trunk/e/src/bin/e_main.c 2011-07-26 14:00:54 UTC (rev 61761)
 +++ trunk/e/src/bin/e_main.c 2011-07-26 14:04:14 UTC (rev 61762)
 @@ -392,7 +392,9 @@

 TS(E_Randr Init);
 if (!e_randr_init())
 - e_error_message_show(_(Enlightenment cannot initialize E_Randr!\n));
 + {
 + e_error_message_show(_(Enlightenment cannot initialize E_Randr!\n));
 + }
 else
 _e_main_shutdown_push(e_randr_shutdown);
 TS(E_Randr Init Done);






--
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-07-26 Thread Mike McCormack

On 07/26/2011 11:23 PM, Christopher Michael wrote:
 Heh yea :( pretty odd, but I haven't stopped to look into why yet :) I 
 just fixed it and moved on ;) Will look into 'why' later :)

Hopefully SVN @61783 will fix it.

thanks,

Mike

--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-05-11 Thread sd
 Log:
 E17: When searching for an icon in the fdo theme, if we do not find it
   in the current theme, check some fallback icon themes (so there is
   less chance of a menu item having no icon).

Oh! This is so wrong! You completely trash the efreet cache by doing this.
All themes inherit from hicolor anyway, and Human inherits from gnome. And
if I don't remember wrong, default isn't an icon theme.

S.




 Author:   devilhorns
 Date: 2011-05-10 22:06:08 -0700 (Tue, 10 May 2011)
 New Revision: 59314
 Trac: http://trac.enlightenment.org/e/changeset/59314

 Modified:
   trunk/e/src/bin/e_utils.c

 Modified: trunk/e/src/bin/e_utils.c
 ===
 --- trunk/e/src/bin/e_utils.c 2011-05-11 04:56:42 UTC (rev 59313)
 +++ trunk/e/src/bin/e_utils.c 2011-05-11 05:06:08 UTC (rev 59314)
 @@ -450,8 +450,25 @@
 size = e_icon_scale_size_get(obj);
 if (size  16) size = 16;
 size = e_util_icon_size_normalize(size * e_scale);
 +
 path = efreet_icon_path_find(e_config-icon_theme, icon, size);
 +   if (!path)
 + {
 +path = efreet_icon_path_find(default, icon, size);
 +if (!path)
 +  {
 + path = efreet_icon_path_find(hicolor, icon, size);
 + if (!path)
 +   {
 +  path = efreet_icon_path_find(gnome, icon, size);
 +  if (!path)
 +path = efreet_icon_path_find(Human, icon, size);
 +   }
 +  }
 + }
 +
 if (!path) return 0;
 +
 e_icon_file_set(obj, path);
 return 1;
  }


 --
 Achieve unprecedented app performance and reliability
 What every C/C++ and Fortran developer should know.
 Learn how Intel has extended the reach of its next-generation tools
 to help boost performance applications - inlcuding clusters.
 http://p.sf.net/sfu/intel-dev2devmay
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn




--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-05-11 Thread sd
It doesn't break it as will not work, but it wont work optimal. The
cache is designed for use with one theme. It should be the theme designers
responsibility to add theme inherits, and not e17 responsibility to show
random icons.

S.

 Log:
 E17: Revert fdo icon searching in different themes. Apparently it
   breaks efreet cache (tho I saw no side effects here).



 Author:   devilhorns
 Date: 2011-05-11 06:55:22 -0700 (Wed, 11 May 2011)
 New Revision: 59332
 Trac: http://trac.enlightenment.org/e/changeset/59332

 Modified:
   trunk/e/src/bin/e_utils.c

 Modified: trunk/e/src/bin/e_utils.c
 ===
 --- trunk/e/src/bin/e_utils.c 2011-05-11 12:24:13 UTC (rev 59331)
 +++ trunk/e/src/bin/e_utils.c 2011-05-11 13:55:22 UTC (rev 59332)
 @@ -452,21 +452,6 @@
 size = e_util_icon_size_normalize(size * e_scale);

 path = efreet_icon_path_find(e_config-icon_theme, icon, size);
 -   if (!path)
 - {
 -path = efreet_icon_path_find(default, icon, size);
 -if (!path)
 -  {
 - path = efreet_icon_path_find(hicolor, icon, size);
 - if (!path)
 -   {
 -  path = efreet_icon_path_find(gnome, icon, size);
 -  if (!path)
 -path = efreet_icon_path_find(Human, icon, size);
 -   }
 -  }
 - }
 -
 if (!path) return 0;

 e_icon_file_set(obj, path);


 --
 Achieve unprecedented app performance and reliability
 What every C/C++ and Fortran developer should know.
 Learn how Intel has extended the reach of its next-generation tools
 to help boost performance applications - inlcuding clusters.
 http://p.sf.net/sfu/intel-dev2devmay
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn




--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-05-11 Thread sd
 On 05/11/2011 02:39 AM, s...@tango.flipp.net wrote:
 Log:
 E17: When searching for an icon in the fdo theme, if we do not find it
in the current theme, check some fallback icon themes (so there is
less chance of a menu item having no icon).

 Oh! This is so wrong! You completely trash the efreet cache by doing
 this.
 All themes inherit from hicolor anyway, and Human inherits from gnome.
 And
 if I don't remember wrong, default isn't an icon theme.

 S.

 Hmm, then this needs to be fixed in elm also, because this is exactly
 how elm finds fdo icons also.

Sure? I did fix it there some time ago. Search for theme on initial icon
lookup, and then stick to this theme.

S.



--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2011-05-11 Thread Christopher Michael
On 05/11/2011 04:01 PM, s...@tango.flipp.net wrote:
 On 05/11/2011 02:39 AM, s...@tango.flipp.net wrote:
 Log:
 E17: When searching for an icon in the fdo theme, if we do not find it
 in the current theme, check some fallback icon themes (so there is
 less chance of a menu item having no icon).

 Oh! This is so wrong! You completely trash the efreet cache by doing
 this.
 All themes inherit from hicolor anyway, and Human inherits from gnome.
 And
 if I don't remember wrong, default isn't an icon theme.

 S.

 Hmm, then this needs to be fixed in elm also, because this is exactly
 how elm finds fdo icons also.

 Sure? I did fix it there some time ago. Search for theme on initial icon
 lookup, and then stick to this theme.

 S.

A so you did. May help if my elm svn was current huh ? ;)

Sorry for the noise.

dh





--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2010-12-02 Thread Mike Blumenkrantz
On Thu,  2 Dec 2010 00:05:54 -0800
Enlightenment SVN no-re...@enlightenment.org wrote:

 Log:
 Adjust min sizes of ilist and textblock so that Modules dialog fits
   nicely into 240x320 (without these changes, the toolbar is partially
   obscured by illume indicator).
   
   
 
 Author:   devilhorns
 Date: 2010-12-02 00:05:52 -0800 (Thu, 02 Dec 2010)
 New Revision: 55132
 Trac: http://trac.enlightenment.org/e/changeset/55132
 
 Modified:
   trunk/e/src/bin/e_int_config_modules.c 
 
 Modified: trunk/e/src/bin/e_int_config_modules.c
 ===
 --- trunk/e/src/bin/e_int_config_modules.c2010-12-02 08:01:19 UTC
 (rev 55131) +++ trunk/e/src/bin/e_int_config_modules.c2010-12-02
 08:05:52 UTC (rev 55132) @@ -167,7 +167,7 @@
 e_widget_ilist_go(cfdata-l_modules);
 e_widget_size_min_get(cfdata-l_modules, mw, mh);
 if (mw  (200 * e_scale)) mw = 200 * e_scale;
 -   if (mh  (120 * e_scale)) mh = 120 * e_scale;
 +   if (mh  (100 * e_scale)) mh = 100 * e_scale;
 e_widget_size_min_set(cfdata-l_modules, mw, mh);
 e_widget_on_change_hook_set(cfdata-l_modules, 
 _widget_list_selection_changed, cfdata);
 @@ -184,7 +184,7 @@
 e_widget_table_object_append(of, ol, 1, 2, 1, 1, 1, 1, 1, 0);
  
 ol = e_widget_textblock_add(evas);
 -   e_widget_size_min_set(ol, (200 * e_scale), 60 * e_scale);
 +   e_widget_size_min_set(ol, (200 * e_scale), 40 * e_scale);
 cfdata-o_desc = ol;
 e_widget_table_object_append(of, ol, 0, 3, 2, 1, 1, 0, 1, 0);
  
 
 
 --
 Increase Visibility of Your 3D Game App  Earn a Chance To Win $500!
 Tap into the largest installed PC base  get more eyes on your game by
 optimizing for Intel(R) Graphics Technology. Get started today with the
 Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
 http://p.sf.net/sfu/intelisp-dev2dev
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
Resizinghorns!

-- 
Mike Blumenkrantz
Zentific: Our boolean values are huge.

--
Increase Visibility of Your 3D Game App  Earn a Chance To Win $500!
Tap into the largest installed PC base  get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2010-04-02 Thread Cedric BAIL
On Thu, Apr 1, 2010 at 8:48 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
  Use item-label in places where we can. I don't know how this was
  overlooked all this time. This fixes a bug where getting item-label
  was always returning NULL.

  Can someone please check the eina_stringshare usage here ? Thanks :)

 @@ -571,7 +589,11 @@
    if (sd-multi_select) return NULL;
    if (sd-selected  0) return NULL;
    si = eina_list_nth(sd-items, sd-selected);
 -   if (si) return edje_object_part_text_get(si-o_base, e.text.label);
 +   if (si)
 +     {
 +        if (si-label) return si-label;
 +        return edje_object_part_text_get(si-o_base, e.text.label);
 +     }
    return NULL;
  }

Don't return edje_object_part_text_get as it is not a stringshare. If
si-label is not set, perhaps do an si-label =
eina_stringshare_add(edje_object_part_text_get(si-o_base,
e.text.label));. But I don't see why in your code, you will have
si-label == NULL and e.text.label != NULL. So perhaps just drop that
return at all.
-- 
Cedric BAIL

--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2010-04-02 Thread Christopher Michael
Fixed in svn now as per your suggestion. I kept the return of 
edje_object_part_text_get just in casebetter to be safe than sorry :)

Thanks :)

dh

On 04/02/2010 04:40 AM, Cedric BAIL wrote:
 On Thu, Apr 1, 2010 at 8:48 PM, Enlightenment SVN
 no-re...@enlightenment.org  wrote:
 Log:
   Use item-label in places where we can. I don't know how this was
   overlooked all this time. This fixes a bug where getting item-label
   was always returning NULL.

   Can someone please check the eina_stringshare usage here ? Thanks :)

 @@ -571,7 +589,11 @@
 if (sd-multi_select) return NULL;
 if (sd-selected  0) return NULL;
 si = eina_list_nth(sd-items, sd-selected);
 -   if (si) return edje_object_part_text_get(si-o_base, e.text.label);
 +   if (si)
 + {
 +if (si-label) return si-label;
 +return edje_object_part_text_get(si-o_base, e.text.label);
 + }
 return NULL;
   }

 Don't return edje_object_part_text_get as it is not a stringshare. If
 si-label is not set, perhaps do an si-label =
 eina_stringshare_add(edje_object_part_text_get(si-o_base,
 e.text.label));. But I don't see why in your code, you will have
 si-label == NULL and e.text.label != NULL. So perhaps just drop that
 return at all.


--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2010-04-01 Thread Gustavo Sverzut Barbieri
On Thu, Apr 1, 2010 at 10:48 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
  Use item-label in places where we can. I don't know how this was
  overlooked all this time. This fixes a bug where getting item-label
  was always returning NULL.

  Can someone please check the eina_stringshare usage here ? Thanks :)
 +   if (si)
 +     {
 +        if (si-label) eina_stringshare_del(si-label);
 +        si-label = eina_stringshare_add(label);
 +        edje_object_part_text_set(si-o_base, e.text.label, label);
 +     }

if (eina_stringshare_replace(si-label, label))
   edje_object_part_text_set(si-o_base, e.text.label, label);

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-12-29 Thread Sachiel
It compiles because for prototypes you only need the type,
not the variable name.

On Mon, Dec 28, 2009 at 3:01 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
  Fix function prototype...no idea how this even compiled all this time.


 Author:       devilhorns
 Date:         2009-12-28 10:01:39 -0800 (Mon, 28 Dec 2009)
 New Revision: 44749

 Modified:
  trunk/e/src/bin/e_container.h

 Modified: trunk/e/src/bin/e_container.h
 ===
 --- trunk/e/src/bin/e_container.h       2009-12-28 16:52:27 UTC (rev 44748)
 +++ trunk/e/src/bin/e_container.h       2009-12-28 18:01:39 UTC (rev 44749)
 @@ -129,8 +129,8 @@
  EAPI int                e_container_borders_count(E_Container *con);
  EAPI void               e_container_border_add(E_Border *bd);
  EAPI void               e_container_border_remove(E_Border *bd);
 -EAPI void               e_container_window_raise(E_Container *con, 
 Ecore_X_Window, int layer);
 -EAPI void               e_container_window_lower(E_Container *con, 
 Ecore_X_Window, int layer);
 +EAPI void               e_container_window_raise(E_Container *con, 
 Ecore_X_Window win, int layer);
 +EAPI void               e_container_window_lower(E_Container *con, 
 Ecore_X_Window win, int layer);
  EAPI E_Border          *e_container_border_raise(E_Border *bd);
  EAPI E_Border          *e_container_border_lower(E_Border *bd);
  EAPI void               e_container_border_stack_above(E_Border *bd, 
 E_Border *above);


 --
 This SF.Net email is sponsored by the Verizon Developer Community
 Take advantage of Verizon's best-in-class app development support
 A streamlined, 14 day to market process makes app distribution fast and easy
 Join now and get one step closer to millions of Verizon customers
 http://p.sf.net/sfu/verizon-dev2dev
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-27 Thread The Rasterman
On Sat, 22 Aug 2009 23:39:54 -0400 Christopher Michael cpmicha...@comcast.net
said:

 David Seikel wrote:
  On Sat, 22 Aug 2009 23:00:22 -0400 Christopher Michael
  cpmicha...@comcast.net wrote:
  
  Gustavo Sverzut Barbieri wrote:
  On Sat, Aug 22, 2009 at 11:27 PM, Christopher
  Michaelcpmicha...@comcast.net wrote:
  Gustavo Sverzut Barbieri wrote:
  On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
  SVNno-re...@enlightenment.org wrote:
  Log:
   Formatting.
   Whitespace Removal.
   Fetch the windows evas once instead of multiple calls to
  e_win_evas_get. Use E_FREE to free the config dialog structure.
   Make sure the window is centered when switching between Basic 
  Advanced.
  This last bit is up to discussion. I personally dislike it as all
  your reference is lost when you change the window.
  I'm lost a little here by this statement...I didn't change the
  window at all...just added one line to ensure that it's centered
  when changing modes (basic/advanced)
  exactly, window was at (x,y) + wxh. I prefer it to just change wxh
  and not the 4 values.
 
  Well, if it ends up bothering people too much, then we can just
  remove it. Seemed silly to me tho to not have the window centered
  when chaning modes (since it was centered at the start)...but maybe
  that's just me...
  
  And if the window had been moved to somewhere else by the user?  I say
  without looking at the code.  lol
  
 That's true...I hadn't considered that angle. I'll revert.

the destroy and re-create is just a bi-product of laziness by me. so normally
the behavior would be to expand  wxh only and not move. :)

-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-26 Thread Vincent Torri



On Tue, 25 Aug 2009, Enlightenment SVN wrote:


Log:
 Use simpler method for testing disabled state vs what we want it to be.


you should also look at and clean those kind of tests in ecore_x and 
ecore_evas. They are numerous :)


Vincent




Author:   devilhorns
Date: 2009-08-25 16:06:40 -0700 (Tue, 25 Aug 2009)
New Revision: 41996

Modified:
 trunk/e/src/bin/e_widget.c

Modified: trunk/e/src/bin/e_widget.c
===
--- trunk/e/src/bin/e_widget.c  2009-08-25 23:04:22 UTC (rev 41995)
+++ trunk/e/src/bin/e_widget.c  2009-08-25 23:06:40 UTC (rev 41996)
@@ -426,8 +426,7 @@
e_widget_disabled_set(Evas_Object *obj, int disabled)
{
   API_ENTRY return;
-   if (((sd-disabled)  (disabled)) ||
-   ((!sd-disabled)  (!disabled))) return;
+   if (sd-disabled == disabled) return;
   sd-disabled = disabled;
   if (sd-focused)
 {


--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Ce message a été vérifié par MailScanner
pour des virus ou des polluriels et rien de
suspect n'a été trouvé.
Message délivré par le serveur de messagerie de l'Université d'Evry.

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-26 Thread Christopher Michael
Vincent Torri wrote:
 
 
 On Tue, 25 Aug 2009, Enlightenment SVN wrote:
 
 Log:
  Use simpler method for testing disabled state vs what we want it to be.
 
 you should also look at and clean those kind of tests in ecore_x and 
 ecore_evas. They are numerous :)
 
 Vincent
 
Sounds like a good idea. I'll add that to me todo list. Hopefully I can 
get to it before I am 90 years old :)

dh


--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-22 Thread Gustavo Sverzut Barbieri
On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
SVNno-re...@enlightenment.org wrote:
 Log:
  Formatting.
  Whitespace Removal.
  Fetch the windows evas once instead of multiple calls to e_win_evas_get.
  Use E_FREE to free the config dialog structure.
  Make sure the window is centered when switching between Basic  Advanced.

This last bit is up to discussion. I personally dislike it as all your
reference is lost when you change the window. For example, the title
bar will change completely. Most people (at least languages supported
by E) read from top-left to bottom-right and loosing the reference
point is not good.

BUT I know the dialog can overflow visible area, even more if screen
is small (try at 640x480), so I'd say we should not center if we not
overflow, center or clamp otherwise.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-22 Thread Christopher Michael
Gustavo Sverzut Barbieri wrote:
 On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
 SVNno-re...@enlightenment.org wrote:
 Log:
  Formatting.
  Whitespace Removal.
  Fetch the windows evas once instead of multiple calls to e_win_evas_get.
  Use E_FREE to free the config dialog structure.
  Make sure the window is centered when switching between Basic  Advanced.
 
 This last bit is up to discussion. I personally dislike it as all your
 reference is lost when you change the window. 
I'm lost a little here by this statement...I didn't change the window at 
all...just added one line to ensure that it's centered when changing 
modes (basic/advanced)

For example, the title
 bar will change completely.
Just by centering a window ? I don't think so...

  Most people (at least languages supported
 by E) read from top-left to bottom-right and loosing the reference
 point is not good.
 
 BUT I know the dialog can overflow visible area, even more if screen
 is small (try at 640x480), so I'd say we should not center if we not
 overflow, center or clamp otherwise.
 

dh

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-22 Thread Gustavo Sverzut Barbieri
On Sat, Aug 22, 2009 at 11:27 PM, Christopher
Michaelcpmicha...@comcast.net wrote:
 Gustavo Sverzut Barbieri wrote:

 On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
 SVNno-re...@enlightenment.org wrote:

 Log:
  Formatting.
  Whitespace Removal.
  Fetch the windows evas once instead of multiple calls to e_win_evas_get.
  Use E_FREE to free the config dialog structure.
  Make sure the window is centered when switching between Basic 
 Advanced.

 This last bit is up to discussion. I personally dislike it as all your
 reference is lost when you change the window.

 I'm lost a little here by this statement...I didn't change the window at
 all...just added one line to ensure that it's centered when changing modes
 (basic/advanced)

exactly, window was at (x,y) + wxh. I prefer it to just change wxh and
not the 4 values.


 For example, the title

 bar will change completely.

 Just by centering a window ? I don't think so...

  Most people (at least languages supported

 by E) read from top-left to bottom-right and loosing the reference
 point is not good.

 BUT I know the dialog can overflow visible area, even more if screen
 is small (try at 640x480), so I'd say we should not center if we not
 overflow, center or clamp otherwise.


 dh




-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-22 Thread Christopher Michael
Gustavo Sverzut Barbieri wrote:
 On Sat, Aug 22, 2009 at 11:27 PM, Christopher
 Michaelcpmicha...@comcast.net wrote:
 Gustavo Sverzut Barbieri wrote:
 On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
 SVNno-re...@enlightenment.org wrote:
 Log:
  Formatting.
  Whitespace Removal.
  Fetch the windows evas once instead of multiple calls to e_win_evas_get.
  Use E_FREE to free the config dialog structure.
  Make sure the window is centered when switching between Basic 
 Advanced.
 This last bit is up to discussion. I personally dislike it as all your
 reference is lost when you change the window.
 I'm lost a little here by this statement...I didn't change the window at
 all...just added one line to ensure that it's centered when changing modes
 (basic/advanced)
 
 exactly, window was at (x,y) + wxh. I prefer it to just change wxh and
 not the 4 values.
 
Well, if it ends up bothering people too much, then we can just remove 
it. Seemed silly to me tho to not have the window centered when chaning 
modes (since it was centered at the start)...but maybe that's just me...

dh

 
 For example, the title
 bar will change completely.
 Just by centering a window ? I don't think so...

  Most people (at least languages supported
 by E) read from top-left to bottom-right and loosing the reference
 point is not good.

 BUT I know the dialog can overflow visible area, even more if screen
 is small (try at 640x480), so I'd say we should not center if we not
 overflow, center or clamp otherwise.

 dh

 
 
 


--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-22 Thread David Seikel
On Sat, 22 Aug 2009 23:00:22 -0400 Christopher Michael
cpmicha...@comcast.net wrote:

 Gustavo Sverzut Barbieri wrote:
  On Sat, Aug 22, 2009 at 11:27 PM, Christopher
  Michaelcpmicha...@comcast.net wrote:
  Gustavo Sverzut Barbieri wrote:
  On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
  SVNno-re...@enlightenment.org wrote:
  Log:
   Formatting.
   Whitespace Removal.
   Fetch the windows evas once instead of multiple calls to
  e_win_evas_get. Use E_FREE to free the config dialog structure.
   Make sure the window is centered when switching between Basic 
  Advanced.
  This last bit is up to discussion. I personally dislike it as all
  your reference is lost when you change the window.
  I'm lost a little here by this statement...I didn't change the
  window at all...just added one line to ensure that it's centered
  when changing modes (basic/advanced)
  
  exactly, window was at (x,y) + wxh. I prefer it to just change wxh
  and not the 4 values.
  
 Well, if it ends up bothering people too much, then we can just
 remove it. Seemed silly to me tho to not have the window centered
 when chaning modes (since it was centered at the start)...but maybe
 that's just me...

And if the window had been moved to somewhere else by the user?  I say
without looking at the code.  lol


signature.asc
Description: PGP signature
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-08-22 Thread Christopher Michael
David Seikel wrote:
 On Sat, 22 Aug 2009 23:00:22 -0400 Christopher Michael
 cpmicha...@comcast.net wrote:
 
 Gustavo Sverzut Barbieri wrote:
 On Sat, Aug 22, 2009 at 11:27 PM, Christopher
 Michaelcpmicha...@comcast.net wrote:
 Gustavo Sverzut Barbieri wrote:
 On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment
 SVNno-re...@enlightenment.org wrote:
 Log:
  Formatting.
  Whitespace Removal.
  Fetch the windows evas once instead of multiple calls to
 e_win_evas_get. Use E_FREE to free the config dialog structure.
  Make sure the window is centered when switching between Basic 
 Advanced.
 This last bit is up to discussion. I personally dislike it as all
 your reference is lost when you change the window.
 I'm lost a little here by this statement...I didn't change the
 window at all...just added one line to ensure that it's centered
 when changing modes (basic/advanced)
 exactly, window was at (x,y) + wxh. I prefer it to just change wxh
 and not the 4 values.

 Well, if it ends up bothering people too much, then we can just
 remove it. Seemed silly to me tho to not have the window centered
 when chaning modes (since it was centered at the start)...but maybe
 that's just me...
 
 And if the window had been moved to somewhere else by the user?  I say
 without looking at the code.  lol
 
That's true...I hadn't considered that angle. I'll revert.

dh

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-07-27 Thread Christopher Michael
After a quick read-through, the patches look good :) I won't have time 
to actually do a build test until later tonight tho (and if ok, then 
I'll commmit them). If someone else gets to these before me, great...if 
not I will attend to them later tonightbut for the most part, if you 
have more like this, feel free to send them in :) Much appreciated :)

Thanks,
devilhorns

Peter van de Werken wrote:
 On Sun, Jul 26, 2009 at 05:30:07PM -0700, Enlightenment SVN wrote:
 Log:
   Remove whitespace.
   Use E_FREE for things created with E_NEW.
   Add new function to clear the toolbar.
   Add new function to return the number of the selected item.
 
 got two patches:
 #1: hide eina_list internals by using the eina macros and methods instead
 #2: cleanup some duplicate code
 
 If appreciated I can provide more patches like #1 for the other parts
 of E.
 
 regards,
 Peter
 
 --
 With a rubber duck, one's never alone.
 -- The Hitchhiker's Guide to the Galaxy
 
 

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with Crystal 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-07-27 Thread Christopher Michael
Thanks, Committed :)

I slightly modified the patches a little to account for formatting  
whitespace. I also replaced a couple of missed while/for loops with 
eina_list macros.

Cheers,
devilhorns

Peter van de Werken wrote:
 On Sun, Jul 26, 2009 at 05:30:07PM -0700, Enlightenment SVN wrote:
 Log:
   Remove whitespace.
   Use E_FREE for things created with E_NEW.
   Add new function to clear the toolbar.
   Add new function to return the number of the selected item.
 
 got two patches:
 #1: hide eina_list internals by using the eina macros and methods instead
 #2: cleanup some duplicate code
 
 If appreciated I can provide more patches like #1 for the other parts
 of E.
 
 regards,
 Peter
 
 --
 With a rubber duck, one's never alone.
 -- The Hitchhiker's Guide to the Galaxy

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-07-20 Thread Gustavo Sverzut Barbieri
On Sun, Jul 19, 2009 at 11:53 PM, Christopher
Michaelcpmicha...@comcast.net wrote:
 Gustavo Sverzut Barbieri wrote:

 On Sun, Jul 19, 2009 at 5:08 PM, Enlightenment
 SVNno-re...@enlightenment.org wrote:

 Log:
  Cleanup compiler warning on e_signals.c:
         execinfo.h (which contains the backtrace* functions is only
 included
         if OBJECT_PARANOIA_CHECK is defined so add an #ifdef around those
 calls.

 no, this has nothing to do with object paranoia. These changes were
 meant to help us with user problems. Include execinfo.h always and
 remove the ifdefs.

 I understand the reason of helping with user problems, but according to the
 code, execinfo.h is only included if OBJECT_PARANOIA_CHECK is enabled:

 (e.h)
 #ifdef __GLIBC__
 #ifdef OBJECT_PARANOIA_CHECK
 #include execinfo.h
 #include setjmp.h
 #endif
 #endif

 so in a way it DOES have something to do with OBJECT_PARANOIA_CHECK in that
 the execinfo.h header was not added if paranoia_check was not
 defined...leading to the compiler complaining about missing functions...thus
 the reason why I added an #ifdef OBJECT_PARANOIA_CHECK around the backtrace
 code.

 NOW, having said that, if it is the general wish of the E 'Team' to always
 include the backtrace code (even for a 'release'), then by all means I will
 remove the #ifdef OBJECT_PARANOIA_CHECK around the backtrace calls (which I
 added to fix the compiler warning) and just include execinfo.h
 regardless...but IMO this may not be desirable in the long term because most
 'average users' would not know what to do with the backtrace anyway.

average users will never understand breakages. And asking them to do
more stuff (ie: recompile and try again) is bad. Just make it enabled
by default, if you want to avoid such things possibly make it an
optional disable (enabled by default), but I don't see a reason to not
have that, it should be always useful... no product is fail proof
these days.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-07-19 Thread Gustavo Sverzut Barbieri
On Sun, Jul 19, 2009 at 5:08 PM, Enlightenment
SVNno-re...@enlightenment.org wrote:
 Log:
  Cleanup compiler warning on e_signals.c:
          execinfo.h (which contains the backtrace* functions is only included
          if OBJECT_PARANOIA_CHECK is defined so add an #ifdef around those 
 calls.

no, this has nothing to do with object paranoia. These changes were
meant to help us with user problems. Include execinfo.h always and
remove the ifdefs.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-07-19 Thread Christopher Michael
Gustavo Sverzut Barbieri wrote:
 On Sun, Jul 19, 2009 at 5:08 PM, Enlightenment
 SVNno-re...@enlightenment.org wrote:
 Log:
  Cleanup compiler warning on e_signals.c:
  execinfo.h (which contains the backtrace* functions is only included
  if OBJECT_PARANOIA_CHECK is defined so add an #ifdef around those 
 calls.
 
 no, this has nothing to do with object paranoia. These changes were
 meant to help us with user problems. Include execinfo.h always and
 remove the ifdefs.
 
I understand the reason of helping with user problems, but according to 
the code, execinfo.h is only included if OBJECT_PARANOIA_CHECK is enabled:

(e.h)
#ifdef __GLIBC__
#ifdef OBJECT_PARANOIA_CHECK
#include execinfo.h
#include setjmp.h
#endif
#endif

so in a way it DOES have something to do with OBJECT_PARANOIA_CHECK in 
that the execinfo.h header was not added if paranoia_check was not 
defined...leading to the compiler complaining about missing 
functions...thus the reason why I added an #ifdef OBJECT_PARANOIA_CHECK 
around the backtrace code.

NOW, having said that, if it is the general wish of the E 'Team' to 
always include the backtrace code (even for a 'release'), then by all 
means I will remove the #ifdef OBJECT_PARANOIA_CHECK around the 
backtrace calls (which I added to fix the compiler warning) and just 
include execinfo.h regardless...but IMO this may not be desirable in 
the long term because most 'average users' would not know what to do 
with the backtrace anyway.

dh

--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-05-15 Thread Viktor Kojouharov
On Fri, 2009-05-15 at 11:11 -0700, Enlightenment SVN wrote:
 Log:
   use E_NEW  E_FREE macros
   
 Author:   devilhorns
 Date: 2009-05-15 11:11:41 -0700 (Fri, 15 May 2009)
 New Revision: 40680
 
 Modified:
   trunk/e/src/bin/e_pan.c 
 
 Modified: trunk/e/src/bin/e_pan.c
 ===
 --- trunk/e/src/bin/e_pan.c   2009-05-15 17:59:02 UTC (rev 40679)
 +++ trunk/e/src/bin/e_pan.c   2009-05-15 18:11:41 UTC (rev 40680)
 @@ -171,7 +171,7 @@
  {
 E_Smart_Data *sd;
  
 -   sd = calloc(1, sizeof(E_Smart_Data));
 +   sd = E_NEW(fSmart_Data, 1);
 if (!sd) return;
 sd-smart_obj = obj;
 sd-x = 0;
 @@ -186,7 +186,7 @@
  {
 INTERNAL_ENTRY;
 e_pan_child_set(obj, NULL);
 -   free(sd);
 +   E_FREE(sd);
  }
  
  static void
 
 

fSmart_Data, maybe that's a typo?
 --
 Crystal Reports - New Free Runtime and 30 Day Trial
 Check out the new simplified licensing option that enables 
 unlimited royalty-free distribution of the report engine 
 for externally facing server and web deployment. 
 http://p.sf.net/sfu/businessobjects
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


--
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: devilhorns trunk/e/src/bin

2009-05-15 Thread Christopher Michael
Fixed, Thanks Viktor :)

Damn fat-finger typing :)

dh

Viktor Kojouharov wrote:
 On Fri, 2009-05-15 at 11:11 -0700, Enlightenment SVN wrote:
 Log:
   use E_NEW  E_FREE macros
   
 Author:   devilhorns
 Date: 2009-05-15 11:11:41 -0700 (Fri, 15 May 2009)
 New Revision: 40680

 Modified:
   trunk/e/src/bin/e_pan.c 

 Modified: trunk/e/src/bin/e_pan.c
 ===
 --- trunk/e/src/bin/e_pan.c  2009-05-15 17:59:02 UTC (rev 40679)
 +++ trunk/e/src/bin/e_pan.c  2009-05-15 18:11:41 UTC (rev 40680)
 @@ -171,7 +171,7 @@
  {
 E_Smart_Data *sd;
  
 -   sd = calloc(1, sizeof(E_Smart_Data));
 +   sd = E_NEW(fSmart_Data, 1);
 if (!sd) return;
 sd-smart_obj = obj;
 sd-x = 0;
 @@ -186,7 +186,7 @@
  {
 INTERNAL_ENTRY;
 e_pan_child_set(obj, NULL);
 -   free(sd);
 +   E_FREE(sd);
  }
  
  static void


 
 fSmart_Data, maybe that's a typo?

--
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel