Re: [E-devel] EDC Reference
Hello everybody, The reason for my inactivity is a combination of moving to a new house and a broken monitor. I revised all the comments of the EDC Reference and added new ones. The EDC Reference are around 80% complete, I won't be able of completing them any time soon (moving yet again), I was wondering if someone could apply these patches in their current state. The patch with the necessary changes to acommodate the reference is: http://pastebin.com/m766b169b I only moved complete functions around in edje_cc_handlers.c, but due to the similarity of the functions moved diff makes it look as if I changed lines inside the functions, which I did not. And the actual EDC reference (applied after the other patch) is: http://pastebin.com/m607a4f38 This patch only contains the new comments. Bye dresb - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
Yea I moved some functions around, the reason is that the doxygen aliases I used to create the reference table assume the format: block1 properties of block1 block2 properties of block2 And the function definitions for color_class, color, color2 and color3, (description block) are located below the definition of the fill block. These would be the necessary changes to accomodate the reference, a few lines in Doxyfile, edje.css and the functions I moved around in edje_cc_handlers.c. http://pastebin.com/m1929ac03 The reference itself, I'm still working on :) El Tuesday 13 November 2007 03:38:58 Vincent Torri escribió: On Tue, 13 Nov 2007, dan sinclair wrote: Did you remove collections.group.parts.part.description.color_class, color, color2, color3 on purpose? If so, what's the reasoning behind this? (lines 139-142 and 1620 - 1694) If I'm not mistaken, they are moved (lines 128 and 1209) maybe the patch should be in 2 parts, code + doc. Vincent On 13-Nov-07, at 1:08 AM, Ben Rockwood wrote: Carsten Haitzler (The Rasterman) wrote: On Sun, 11 Nov 2007 16:32:35 -0300 andres [EMAIL PROTECTED] babbled: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. wow. thats a lot of patches/code/comments. thats a good idea. it means we can keep it consistent alongside the code. what do others think? Very nice... massive patch. Very nicely done. benr. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
Ah, ok. I didn't notice that they were moved in the original patch, hard to pick out with all the other changes in there. I don't see any reason why this can't get committed. dan andres wrote: Yea I moved some functions around, the reason is that the doxygen aliases I used to create the reference table assume the format: block1 properties of block1 block2 properties of block2 And the function definitions for color_class, color, color2 and color3, (description block) are located below the definition of the fill block. These would be the necessary changes to accomodate the reference, a few lines in Doxyfile, edje.css and the functions I moved around in edje_cc_handlers.c. http://pastebin.com/m1929ac03 The reference itself, I'm still working on :) El Tuesday 13 November 2007 03:38:58 Vincent Torri escribió: On Tue, 13 Nov 2007, dan sinclair wrote: Did you remove collections.group.parts.part.description.color_class, color, color2, color3 on purpose? If so, what's the reasoning behind this? (lines 139-142 and 1620 - 1694) If I'm not mistaken, they are moved (lines 128 and 1209) maybe the patch should be in 2 parts, code + doc. Vincent On 13-Nov-07, at 1:08 AM, Ben Rockwood wrote: Carsten Haitzler (The Rasterman) wrote: On Sun, 11 Nov 2007 16:32:35 -0300 andres [EMAIL PROTECTED] babbled: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. wow. thats a lot of patches/code/comments. thats a good idea. it means we can keep it consistent alongside the code. what do others think? Very nice... massive patch. Very nicely done. benr. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
On Sun, 11 Nov 2007 16:32:35 -0300 andres [EMAIL PROTECTED] babbled: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. wow. thats a lot of patches/code/comments. thats a good idea. it means we can keep it consistent alongside the code. what do others think? -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
Carsten Haitzler (The Rasterman) wrote: On Sun, 11 Nov 2007 16:32:35 -0300 andres [EMAIL PROTECTED] babbled: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. wow. thats a lot of patches/code/comments. thats a good idea. it means we can keep it consistent alongside the code. what do others think? Very nice... massive patch. Very nicely done. benr. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
Did you remove collections.group.parts.part.description.color_class, color, color2, color3 on purpose? If so, what's the reasoning behind this? (lines 139-142 and 1620 - 1694) dan On 13-Nov-07, at 1:08 AM, Ben Rockwood wrote: Carsten Haitzler (The Rasterman) wrote: On Sun, 11 Nov 2007 16:32:35 -0300 andres [EMAIL PROTECTED] babbled: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. wow. thats a lot of patches/code/comments. thats a good idea. it means we can keep it consistent alongside the code. what do others think? Very nice... massive patch. Very nicely done. benr. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
On Tue, 13 Nov 2007, dan sinclair wrote: Did you remove collections.group.parts.part.description.color_class, color, color2, color3 on purpose? If so, what's the reasoning behind this? (lines 139-142 and 1620 - 1694) If I'm not mistaken, they are moved (lines 128 and 1209) maybe the patch should be in 2 parts, code + doc. Vincent On 13-Nov-07, at 1:08 AM, Ben Rockwood wrote: Carsten Haitzler (The Rasterman) wrote: On Sun, 11 Nov 2007 16:32:35 -0300 andres [EMAIL PROTECTED] babbled: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. wow. thats a lot of patches/code/comments. thats a good idea. it means we can keep it consistent alongside the code. what do others think? Very nice... massive patch. Very nicely done. benr. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EDC Reference
On Nov 11, 2007 4:32 PM, andres [EMAIL PROTECTED] wrote: As some of you might know I'm writting a EDC reference as Doxygen formmated comments directly into edje_cc_handlers.c My theory is that having the reference flowing along the code will ease mantienance of the reference as the Edje specifications change. Here is the current state, http://pastebin.com/m49666ef9 It's mostly text I already wrote on the wiki but what I want to know is if the reference is going to be included before putting even more hours into it. Wow, that's really impressive! I'm all for including it, just one small comment: try to not modify the code with this patch, you do for some strange reason in lines 124-145 (in the patch) and some other paces that looks like whitespace cleanup. Please do them in separate patches. -- Gustavo Sverzut Barbieri -- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
