Re: [E-devel] [Patch] Edge and corner bindings
Hi Gustavo, The scanf issues actually come from the key/mouse binding dialos. I didn't change anything that was not related to edges when I copied the code over, since I wanted to quickly have a conf dialog for testing, and none of these dialogs segfault :) but yeah, all of these dialogs should be fixed for this at some point. I'll look into it once dell decides its time to give me my laptop back, or if someone else feels like it once Dave commits my patch. -Original Message- From: Gustavo Sverzut Barbieri Sent: 23 February 2009 02:50 To: Viktor Kojouharov Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [Patch] Edge and corner bindings On Sun, Feb 15, 2009 at 12:14 PM, Viktor Kojouharov wrote: > Hi guys, > > Since my computer burned to the ground, I will be out of one for at > least 2-3 weeks. But I have this nice looking patch, which adds edge and > corner binding possibilities to E. Since I won't be able to commit it if > raster approves it when he returns, I'd like to ask one of you to commit > it in my stead. > > Now for the patch itself. The edge.5.diff contains all the needed stuff > for this to work, besides the config dialog edj icon, which I hope toma > will create (I just copied the one from conf_keybindings and renamed it > so it would compile). > > It adds another dialog to the input section of the config panel. With > this dialog, one can bind actions to any edge or corner, and specify a > delay and modifiers for it. The default bindings (if you click restore > to default), is to make the desks flip in the direction of the > edge/corner with 0.3s delay. This is the same behaviour that was > previously set by default through the virtual desks config, and the > later was removed since it is not needed anymore. > > It also adds e_bindings_edge* set of functions to deal with the actual > bindings, the special flip_in_direction action, config bindings struct > and a major cleanup to the E_Zone struct and functions. A lot flags are > removed since they are not needed anymore, as well as some functions > that made use of these flags. The long-standing annoyance where dragging > something to a hidden shelf does not show it is also addressed. > > The second file is a patch for the configs that ship with E. It's a > separate file since I have NOT tested it (due to my laptop's unfortunate > meltdown). It should work though. Hi Viktor, I did review your patch and it looks good, I'd just say you should use EINA_LIST_FOREACH() whenever possible and that eina_stringshare is safe to operate with NULL, so no need to check for null before calling add or del. One issue is: +_modify_edge_binding_cb(void *data, void *data2) ... + int n; + + sscanf(cfdata->locals.cur, "e%d", &n); sscanf may fail, in this case it will return 0 and n will be undefined. Either init n=0 or check return and abort, that seems more reasonable. Also happens with _delete_edge_binding_cb and _update_action_list... search for sscanf() I have not studied the problem in depth, but I'd say that we should try to avoid lots of list lookups whenever possible. As I said, I don't really know if it is possible, but if we can add some extra points to avoid walking lists so many times, then let's do it. Patch is really big so maybe I missed something, if others could review it I'd appreciate. Regards, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E_Menu] recalculate the menu
The problem is when the menu exists and is display. When I add an item in the menu, the menu is not update/refresh. 2009/2/23 Gustavo Sverzut Barbieri > On Sun, Feb 22, 2009 at 6:22 PM, Atton Jonathan > wrote: > > hey, > > > > I have a probleme with the E_Menu > > I create one and add 1 item. > > > > A few time later I add a new item but it didn't appears in the menu, I > > suppose the menu is not recalculate or something like that. is there a > way > > to display the new items ? > > Hey, please give us more information, is this a new menu or existing? > If it is a new one, please provide a test case so we can debug it. > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > -- Regards. -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E_Menu] recalculate the menu
I need to know if: - currently can we update a menu while the menu is display ? I think we can't. - is there an easy way to add this possibility to the menu ? maybe a new method which force the update of the menu ? else I will continue to use an e_widget_ilist for the interfaces/networks list in exalt, but the size of the list doesn't depends of the contents. For example if you use a theme with a big font size, the size of the list will not be enough and you will have to use the horizontal scroll :/ 2009/2/23 Atton Jonathan > The problem is when the menu exists and is display. When I add an item in > the menu, the menu is not update/refresh. > > 2009/2/23 Gustavo Sverzut Barbieri > > On Sun, Feb 22, 2009 at 6:22 PM, Atton Jonathan >> wrote: >> > hey, >> > >> > I have a probleme with the E_Menu >> > I create one and add 1 item. >> > >> > A few time later I add a new item but it didn't appears in the menu, I >> > suppose the menu is not recalculate or something like that. is there a >> way >> > to display the new items ? >> >> Hey, please give us more information, is this a new menu or existing? >> If it is a new one, please provide a test case so we can debug it. >> >> -- >> Gustavo Sverzut Barbieri >> http://profusion.mobi embedded systems >> -- >> MSN: barbi...@gmail.com >> Skype: gsbarbieri >> Mobile: +55 (19) 9225-2202 >> > > > > -- > Regards. > -- Regards. -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E_Menu] recalculate the menu
On Mon, Feb 23, 2009 at 2:54 PM, Atton Jonathan wrote: > I need to know if: > - currently can we update a menu while the menu is display ? I think we > can't. > - is there an easy way to add this possibility to the menu ? maybe a new > method which force the update of the menu ? > > else I will continue to use an e_widget_ilist for the interfaces/networks > list in exalt, but the size of the list doesn't depends of the contents. For > example if you use a theme with a big font size, the size of the list will > not be enough and you will have to use the horizontal scroll :/ I think it should not be difficult to add such thing, but I never really looked much into e_menu, so you or me doing such will have the same "cost" :-) I'd say it is interesting to have it working, not just for exalt. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: aron IN trunk/E16: e/po e16menuedit/po
On Mon, 23 Feb 2009 09:35:05 +0100, Enlightenment SVN wrote: > Log: > Added Simplified Chinese translations > Author: aron > Date: 2009-02-23 00:35:05 -0800 (Mon, 23 Feb 2009) > New Revision: 39157 > > Added: > trunk/E16/e/po/zh_CN.po trunk/E16/e16menuedit/po/zh_CN.po > Modified: > trunk/E16/e/po/LINGUAS > > Modified: trunk/E16/e/po/LINGUAS > === > --- trunk/E16/e/po/LINGUAS2009-02-23 08:05:05 UTC (rev 39156) > +++ trunk/E16/e/po/LINGUAS2009-02-23 08:35:05 UTC (rev 39157) > @@ -1 +1 @@ > -bg bs da de en_US es fr hu ja ko nb nl pl pt pt_BR ru sv tr > +bg bs da de en_US es fr hu ja ko nb nl pl pt pt_BR ru sv tr zh_CN > > Added: trunk/E16/e/po/zh_CN.po > > Added: trunk/E16/e16menuedit/po/zh_CN.po > Aron, when you update po stuff, please run autogen.sh and make dist before committing. Currently make dist is broken. /Kim -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E_Menu] recalculate the menu
I ll look at it, currently I have a patch witch add the possibility to add an item in the front of the list and relative to an other item. I just need to update this *** menu :) 2009/2/23 Gustavo Sverzut Barbieri > On Mon, Feb 23, 2009 at 2:54 PM, Atton Jonathan > wrote: > > I need to know if: > > - currently can we update a menu while the menu is display ? I think we > > can't. > > - is there an easy way to add this possibility to the menu ? maybe a new > > method which force the update of the menu ? > > > > else I will continue to use an e_widget_ilist for the interfaces/networks > > list in exalt, but the size of the list doesn't depends of the contents. > For > > example if you use a theme with a big font size, the size of the list > will > > not be enough and you will have to use the horizontal scroll :/ > > I think it should not be difficult to add such thing, but I never > really looked much into e_menu, so you or me doing such will have the > same "cost" :-) I'd say it is interesting to have it working, not > just for exalt. > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > -- Regards. -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E_Menu] recalculate the menu
On Mon, 23 Feb 2009 21:17:21 +0100 Atton Jonathan said: > I ll look at it, currently I have a patch witch add the possibility to add > an item in the front of the list and relative to an other item. I just need > to update this *** menu :) as such i always destroy and re-create menus. i didnt make the code safe for modifying the menu in-place. :) > 2009/2/23 Gustavo Sverzut Barbieri > > > On Mon, Feb 23, 2009 at 2:54 PM, Atton Jonathan > > wrote: > > > I need to know if: > > > - currently can we update a menu while the menu is display ? I think we > > > can't. > > > - is there an easy way to add this possibility to the menu ? maybe a new > > > method which force the update of the menu ? > > > > > > else I will continue to use an e_widget_ilist for the interfaces/networks > > > list in exalt, but the size of the list doesn't depends of the contents. > > For > > > example if you use a theme with a big font size, the size of the list > > will > > > not be enough and you will have to use the horizontal scroll :/ > > > > I think it should not be difficult to add such thing, but I never > > really looked much into e_menu, so you or me doing such will have the > > same "cost" :-) I'd say it is interesting to have it working, not > > just for exalt. > > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -- > > MSN: barbi...@gmail.com > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > > > > -- > Regards. > -- > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
