Re: [E-devel] [Patch] Ecore exe - check kill() return value.
On Sun, 17 Apr 2011, Tom Hacohen wrote: If it's needed/important, we can possibly add "ecore_exe_pause_" or something like that :P or using eina_error ? Vincent -- Tom. On Fri, 2011-04-15 at 23:59 +0900, Carsten Haitzler wrote: On Fri, 15 Apr 2011 15:30:04 +0200 "Clément Battin" said: Hi. Here's a patch to check some missing return values in Ecore exe. we can't actually accept that patch. it breaks api. :( -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] genlist "mode" feature
Dear all, I introduce a new concept to genlist. I named it "genlist mode" after I discussed it with raster. Using this feature, one can activate/deactivate any mode(effect) to an item. The mode is defined in genlist item edc. You can watch a sample video on youtube. http://www.youtube.com/watch?v=ZPbwpzwwiS8 I created two sample mode: Slide and Rotate. [Feature Description] - One can activate a specific mode to an item. - One item is activated at one time while others are deactivated. - Genlist handles deactivating other items when one item is activated. - There are two different view: before activated, after activated. - Genlist creates the second view when the first view is activated. Usually the first view is animated. - Genlist destroys the second view when the item finishes deactivating. - Creating/Destroying the second view on the fly gives performance enhancement because there is no reason to hold all objects in two views all the time. - Mode is defined in genlist edc so one can easily add it more. - Mode edc style is separated from normal genlist styles. One can combine any genlist style with mode edc style. [API] - EAPI void elm_genlist_item_mode_set(Elm_Genlist_Item *it, const char *mode_type, Eina_Bool mode_set) EINA_ARG_NONNULL(1, 2); Activate/Deactivate a mode to an item. - EAPI const char *elm_genlist_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1); Get activated mode name. - EAPI const Elm_Genlist_Item *elm_genlist_mode_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1); Get activated item. [Structure] - Elm_Genlist_Item Added const char *mode_item_style; [Usage] - Set mode style name to genlist item class. itc.mode_item_style = "mode"; - Activated mode to an item whenever you want. elm_genlist_item_mode_set(it, "slide", EINA_TRUE); Please review this patch, if there is no issues I will commit this to upstream. Thanks. Daniel Juyung Seo (SeoZ) genlist_mode.diff Description: Binary data -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Ecore exe - check kill() return value.
On 04/17/2011 03:44 PM, Tom Hacohen wrote: > If it's needed/important, we can possibly add > "ecore_exe_pause_" or something like that :P That would be nicer than an "errno" style thing. Global error values have re-entrancy and thread-safety issues. In libc it's thread local. EFL returns void in way too many places for my liking. It would be a good thing to return an error codes in 2.0, or add extra calls in 1.0 as per Tom's suggestion. Last time this was brought up, Raster said that void is returned to simplify and avoid error handling code. Having the information available doesn't mean you have to write error handling code... it just means you can. thanks, Mike -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Ecore exe - check kill() return value.
On Mon, 18 Apr 2011, Mike McCormack wrote: > On 04/17/2011 03:44 PM, Tom Hacohen wrote: >> If it's needed/important, we can possibly add >> "ecore_exe_pause_" or something like that :P > > That would be nicer than an "errno" style thing. Global error values have > re-entrancy and thread-safety issues. In libc it's thread local. as the EFL are not thread safe, it's not a big issue Vincent > > EFL returns void in way too many places for my liking. It would be a good > thing > to return an error codes in 2.0, or add extra calls in 1.0 as per Tom's > suggestion. > > Last time this was brought up, Raster said that void is returned to simplify > and avoid error handling code. Having the information available doesn't > mean you have to write error handling code... it just means you can. > > thanks, > > Mike > > -- > Benefiting from Server Virtualization: Beyond Initial Workload > Consolidation -- Increasing the use of server virtualization is a top > priority.Virtualization can reduce costs, simplify management, and improve > application availability and disaster protection. Learn more about boosting > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] genlist "mode" feature
Any suggestion about API or anything? According to the youtube video, it looks like this feature is related to the effect. So I thought using elm_genlist_item_effect_mode_set() will be fine before. But it is not. Because the effect is described in edc. There is nothing to do with effect in genlist source code. So I will keep using elm_genlist_item_mode_set() if there is no comment. Thanks. Daniel Juyung Seo (SeoZ) On Mon, Apr 18, 2011 at 10:08 AM, Daniel Juyung Seo wrote: > Dear all, > I introduce a new concept to genlist. > I named it "genlist mode" after I discussed it with raster. > Using this feature, one can activate/deactivate any mode(effect) to an > item. > The mode is defined in genlist item edc. > > You can watch a sample video on youtube. > http://www.youtube.com/watch?v=ZPbwpzwwiS8 > I created two sample mode: Slide and Rotate. > > [Feature Description] > - One can activate a specific mode to an item. > - One item is activated at one time while others are deactivated. > - Genlist handles deactivating other items when one item is activated. > - There are two different view: before activated, after activated. > - Genlist creates the second view when the first view is activated. >Usually the first view is animated. > - Genlist destroys the second view when the item finishes deactivating. > - Creating/Destroying the second view on the fly gives performance > enhancement because there is no reason to hold all objects in two views all > the time. > - Mode is defined in genlist edc so one can easily add it more. > - Mode edc style is separated from normal genlist styles. One can combine > any genlist style with mode edc style. > > [API] > - EAPI void elm_genlist_item_mode_set(Elm_Genlist_Item *it, const char > *mode_type, Eina_Bool mode_set) EINA_ARG_NONNULL(1, 2); >Activate/Deactivate a mode to an item. > - EAPI const char *elm_genlist_mode_get(const Evas_Object *obj) > EINA_ARG_NONNULL(1); >Get activated mode name. > - EAPI const Elm_Genlist_Item *elm_genlist_mode_item_get(const Evas_Object > *obj) EINA_ARG_NONNULL(1); >Get activated item. > > [Structure] > - Elm_Genlist_Item >Added const char *mode_item_style; > > [Usage] > - Set mode style name to genlist item class. >itc.mode_item_style = "mode"; > - Activated mode to an item whenever you want. >elm_genlist_item_mode_set(it, "slide", EINA_TRUE); > > Please review this patch, if there is no issues I will commit this to > upstream. > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > -- > Benefiting from Server Virtualization: Beyond Initial Workload > Consolidation -- Increasing the use of server virtualization is a top > priority.Virtualization can reduce costs, simplify management, and improve > application availability and disaster protection. Learn more about boosting > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] elm_map name(address) feature
On Fri, 15 Apr 2011 17:57:52 +0900 sangho park said: sounds sensible. > that sounds good!! > I'll start to design the geographic solution... > First.. I'll make cool turn-by-turn navi using the solution. > > could you help me :D? > > On Fri, Apr 15, 2011 at 5:48 PM, Atton Jonathan > wrote: > > > hum. What do you think about adding a library in the EFL project to manage > > all geographic methods. (get map, get path, load GPX file ...) ? > > > > I think we can add a library or create a specific file/directory in > > elementary ? > > > > 2011/4/15 sangho park > > > >> okay, i fixed it and attach new patch. > >> > >> hmmm.. btw, would you please consider make me able to commit? > >> recently i made elm_map and ecore_file patches. my goal is .. > >> make the elm_map be better than google maps. > >> If i can join efl, i'll do my best for contribution. :) > >> > >> thanks. > >> > >> On Fri, Apr 15, 2011 at 4:36 PM, Carsten Haitzler >> >wrote: > >> > >> > On Thu, 14 Apr 2011 13:41:15 +0900 sangho park > >> said: > >> > > >> > that seems ok - but some things like: > >> > > >> > Route_Dump *dump = (Route_Dump*)data; > >> > > >> > aren't really needed - u assign from a void * which doesn't generate > >> > warnings as a void * is a "universal plug" (can plug any ptr into/out of > >> > it) or > >> > it should be. > >> > > >> > > I resend patch again with removing build warnings. > >> > > pls confirm this patch~ > >> > > > >> > > On Wed, Apr 13, 2011 at 10:23 AM, sangho park > >> > wrote: > >> > > > >> > > > Dear all, > >> > > > > >> > > > This is a patch for elm_map name(address) feature. > >> > > > I added some APIs for name to elm_map.c and added some test code to > >> > > > test_map.c > >> > > > > >> > > > I used nominatim OSM service. (http:// > >> > http://nominatim.openstreetmap.org/) > >> > > > as i felt, it's response time was very good to use. > >> > > > > >> > > > added APIs are: > >> > > >EAPI Elm_Map_Name *elm_map_utils_convert_coord_into_name(const > >> > > > Evas_Object *obj, double lon, double lat); > >> > > >EAPI Elm_Map_Name *elm_map_utils_convert_name_into_coord(const > >> > > > Evas_Object *obj, char *address); > >> > > > > >> > > >EAPI const char *elm_map_name_address_get(Elm_Map_Name *name); > >> > > >EAPI void elm_map_name_region_get(Elm_Map_Name *name, double > >> *lon, > >> > > > double *lat); > >> > > >EAPI void elm_map_name_remove(Elm_Map_Name *name); > >> > > > > >> > > > you can get the address from coordinate and also get coordinate from > >> > > > freeform address; > >> > > > > >> > > > please review this patch. > >> > > > > >> > > >> > > >> > -- > >> > - Codito, ergo sum - "I code, therefore I am" -- > >> > The Rasterman (Carsten Haitzler)ras...@rasterman.com > >> > > >> > > >> > >> > >> -- > >> Benefiting from Server Virtualization: Beyond Initial Workload > >> Consolidation -- Increasing the use of server virtualization is a top > >> priority.Virtualization can reduce costs, simplify management, and improve > >> application availability and disaster protection. Learn more about > >> boosting > >> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > >> ___ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > >> > > > > > > -- > > Regards. > > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Ecore exe - check kill() return value.
On 04/18/2011 03:14 PM, Vincent Torri wrote: > > > On Mon, 18 Apr 2011, Mike McCormack wrote: > >> On 04/17/2011 03:44 PM, Tom Hacohen wrote: >>> If it's needed/important, we can possibly add >>> "ecore_exe_pause_" or something like that :P >> >> That would be nicer than an "errno" style thing. Global error values have >> re-entrancy and thread-safety issues. In libc it's thread local. > > as the EFL are not thread safe, it's not a big issue There's a difference between not being thread-safe and designing an API that can never be thread safe. At least plan for the possible future. thanks, Mike -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Review] [Patch] Evas - OpenGL and Evas: eng_window_use (Bug Patch)
On Wed, 13 Apr 2011 12:23:22 +0900 "Sung W. Park" said: that patch seems wrong. if you are changing target window... and you have a previous window.. it flushes the gl render queue for the previous window target (or if the flush/use of the window) is flushed. you move the flush to AFTER setting the new context info (like new surfaces for read/write). that seems wrong. > Hi all, > > I've been toying around with creating a simple GLView smart object that > allows users do GL rendering simply. Eventually, I would like to see this > as an Elementary widget called GLView. The idea behind this is that > if evas_gl provides the low level stuff, GLView gives the simplified > user-version. > I'll start another email thread later on this topic. > > The reason why I'm mentioning the above is because while working on GLView, > I've noticed an interesting behavior. (You can see this by > compiling/running the > program that I'm attaching.) I'm drawing a simple blended Triangle in > the middle > of the GLView object and what i'm getting is a smaller inverted red triangle > on the top left corner of the GLView object. Obviously, something was messing > with the state of my GL code. > > I've tracked this issue down to eng_window_use() in evas_x_main.c under gl_x11 > module. In the code, > _ > void > eng_window_use(Evas_GL_X11_Window *gw) > { >if ((_evas_gl_x11_window != gw) || (force_use)) > { > if (_evas_gl_x11_window) > { > evas_gl_common_context_use(_evas_gl_x11_window->gl_context); > evas_gl_common_context_flush(_evas_gl_x11_window->gl_context); > } > _evas_gl_x11_window = gw; >if (gw) > { > >// Make Current Stuff.. > _ > > I've noticed that evas_gl_common_context_flush() gets called before it does > MakeCurrent(). When the evas_gl_common_context_flush() gets called, it resets > some shader stuff and does GL calls that tell the context to use the > particular shaders. This explains why my GLView was picking on what seemed > to be the MVP matrix states that Evas was using. > > Instead, what I think should happen is that the flush should be called after > MakeCurrent happens. Otherwise, you're not guaranteeing that your GL calls > are being applied to the proper context. I've tried that and it seems to > address the > problem. > > You can try running the glview program that I'm attaching before you apply > the patch and also try running it after you apply the patch. > > Let me know if this seems reasonable or I'm missing something somewhere. > > Thanks! > > cheers, > Sung -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel