Re: [E-devel] E SVN: devilhorns trunk/evas/src/modules/engines/gl_x11

2011-12-15 Thread Christopher Michael
Right...thanks what I asked. Rather than bitch, it's easier to fix :P

dh :P :P :P


On 12/14/11 17:45, Vincent Torri wrote:
> On Wed, Dec 14, 2011 at 11:40 PM,  wrote:
>> Ahh, then I need (or someone can) to fix the doxy on the 2 new Evas 
>> functions I added for setting/getting framepsace. They are doxy'd @ 1.1.0 
>> (my bad, I don't follow rev versions much ;) )
>
> @since 1.2 actually, if the function does not exist in 1.1
>
> Vincent
>
>>
>> dh
>>
>> - Original Message -
>> From: "michael bouchaud"
>> To: "Enlightenment developer list"
>> Sent: Wednesday, December 14, 2011 4:28:56 PM
>> Subject: Re: [E-devel] E SVN: devilhorns 
>> trunk/evas/src/modules/engines/gl_x11
>>
>> no no no, They don't need to be backported it's since evas 1.2
>>
>> 2011/12/14 Christopher Michael
>>
>>> On 12/14/11 13:59, Vincent Torri wrote:
 On Wed, Dec 14, 2011 at 7:58 PM, Christopher Michael
   wrote:
> On 12/14/11 13:55, Vincent Torri wrote:
>>
>> this one and the previous one should be backported
>>
>> Vincent
>>
>
> Not sure how to go about that :/ Never did any backporting.

 just check out the branches, modify them and commit. they are in
 e/branches/, not in e/trunk/

 Vincent

>>> Ok, I checked both evas 1.0 and 1.1, but this function does not exist in
>>> either so there is no 'changes' to backport.
>>>
>>> dh
>>>
>
> dh
>
>> On Wed, Dec 14, 2011 at 7:52 PM, Enlightenment SVN
>>   wrote:
>>>
>>> Log:
>>> Evas: Gl_X11: Fix typo? for __UNUSED__ param.
>>>
>>>
>>>
>>> Author: devilhorns
>>> Date: 2011-12-14 10:52:42 -0800 (Wed, 14 Dec 2011)
>>> New Revision: 66224
>>> Trac: http://trac.enlightenment.org/e/changeset/66224
>>>
>>> Modified:
>>> trunk/evas/src/modules/engines/gl_x11/evas_engine.c
>>>
>>> Modified: trunk/evas/src/modules/engines/gl_x11/evas_engine.c
>>> ===
>>> --- trunk/evas/src/modules/engines/gl_x11/evas_engine.c 2011-12-14
>>> 18:44:20 UTC (rev 66223)
>>> +++ trunk/evas/src/modules/engines/gl_x11/evas_engine.c 2011-12-14
>>> 18:52:42 UTC (rev 66224)
>>> @@ -3703,7 +3703,7 @@
>>> }
>>>
>>> static Eina_Bool
>>> -eng_image_can_region_get(void *data__UNUSED__, void *image)
>>> +eng_image_can_region_get(void *data __UNUSED__, void *image)
>>> {
>>> Evas_GL_Image *gim = image;
>>> Image_Entry *im;
>>>
>>>
>
>

>>>
>>>
>>>
>>> --
>>> Cloud Computing - Latest Buzzword or a Glimpse of the Future?
>>> This paper surveys cloud computing today: What are the benefits?
>>> Why are businesses embracing it? What are its payoffs and pitfalls?
>>> http://www.accelacomm.com/jaw/sdnl/114/51425149/
>>> ___
>>> enlightenment-devel mailing list
>>> enlightenment-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>>
>>
>>
>>
>> --
>> Michaël Bouchaud
>> --
>> Cloud Computing - Latest Buzzword or a Glimpse of the Future?
>> This paper surveys cloud computing today: What are the benefits?
>> Why are businesses embracing it? What are its payoffs and pitfalls?
>> http://www.accelacomm.com/jaw/sdnl/114/51425149/
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> --
>> Cloud Computing - Latest Buzzword or a Glimpse of the Future?
>> This paper surveys cloud computing today: What are the benefits?
>> Why are businesses embracing it? What are its payoffs and pitfalls?
>> http://www.accelacomm.com/jaw/sdnl/114/51425149/
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> --
> Cloud Computing - Latest Buzzword or a Glimpse of the Future?
> This paper surveys cloud computing today: What are the benefits?
> Why are businesses embracing it? What are its payoffs and pitfalls?
> http://www.accelacomm.com/jaw/sdnl/114/51425149/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>


--
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.  
But none more important than the need to reduce IT complexity 
while impr

Re: [E-devel] E SVN: cedric trunk/eio

2011-12-15 Thread Sebastian Dransfeld
On 12/15/2011 10:53 AM, Enlightenment SVN wrote:
> Log:
> eio: fix licensing to properly refer to the authors.
>
>
> Author:   cedric
> Date: 2011-12-15 01:53:09 -0800 (Thu, 15 Dec 2011)
> New Revision: 66247
> Trac: http://trac.enlightenment.org/e/changeset/66247
>
> Modified:
>trunk/eio/COPYING
>
> Modified: trunk/eio/COPYING
> ===
> --- trunk/eio/COPYING 2011-12-15 09:40:07 UTC (rev 66246)
> +++ trunk/eio/COPYING 2011-12-15 09:53:09 UTC (rev 66247)
> @@ -1,3 +1,21 @@
> +Copyright notice for Elementary:

Should be eio.

S.

--
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.  
But none more important than the need to reduce IT complexity 
while improving strategic productivity.  Learn More! 
http://www.accelacomm.com/jaw/sdnl/114/51507609/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Bluezery
2011/12/15 Tom Hacohen :
> On 15/12/11 08:11, Daniel Juyung Seo wrote:
>> Overall idea looks good.
>>
>> 1) wrap 80 chars
>>> evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, 
>>> _rect_resize_cb, obj);
>>
>> This is too long. EFL sources are written based on 80 chars per line policy.
>> Please wrap them correctly.
>>
>> 2) remove unrelated changes
>> Check config/profile.src, src/bin/test_map.c
>>
>> 3) setter/getter apis
>> We should also set the configuration by apis.
>> ex) elm_password_show_last_get/set
>> It looks like glayer has no configurable apis. I need Tom's comment for this.

I reflected Daniel's comments.  I added setter/getter APIs for all
gesture configuration. :D
Please review again.

>
> I wanted to comment, but Daniel already said it all :P
>
> With the same line of thinking, what about rotation with fingers? lines
> with fingers? what should be done in those cases?

Configuration may be added later for rotation with finger and lines
with fingers, etc.
There exist a lot of damn patents :(

>
> Does Apple really have patents for pinch to zoom? ffs with those damn
> idiotic patents.

Apple actually doesn't have a patent on "pinch-to-zoom but have limited. :p
Please refers: 
http://www.engadget.com/2010/10/13/apple-awarded-limited-patent-on-pinch-to-zoom/
Anyway, we should be able to configure gestures with fingers because
we cannot recognize overall patents.

>
> Anyhow, please follow Daniel's suggestions, and then I'll review it again.
>
> --
> Tom.
>
> --
> 10 Tips for Better Server Consolidation
> Server virtualization is being driven by many needs.
> But none more important than the need to reduce IT complexity
> while improving strategic productivity.  Learn More!
> http://www.accelacomm.com/jaw/sdnl/114/51507609/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



-- 
BRs,
Kim.
Index: src/lib/elm_config.c
===
--- src/lib/elm_config.c	(리비전 66231)
+++ src/lib/elm_config.c	(작업 사본)
@@ -318,6 +318,7 @@ _desc_init(void)
ELM_CONFIG_VAL(D, T, desktop_entry, T_UCHAR);
ELM_CONFIG_VAL(D, T, password_show_last, T_UCHAR);
ELM_CONFIG_VAL(D, T, password_show_last_timeout, T_DOUBLE);
+   ELM_CONFIG_VAL(D, T, glayer_zoom_finger_enable, T_UCHAR);
ELM_CONFIG_VAL(D, T, glayer_zoom_finger_factor, T_DOUBLE);
ELM_CONFIG_VAL(D, T, glayer_zoom_wheel_factor, T_DOUBLE);
ELM_CONFIG_VAL(D, T, glayer_zoom_distance_tolerance, T_DOUBLE);
@@ -887,6 +888,7 @@ _config_load(void)
_elm_config->is_mirrored = EINA_FALSE; /* Read sys value in env_get() */
_elm_config->password_show_last = EINA_FALSE;
_elm_config->password_show_last_timeout = 2.0;
+   _elm_config->glayer_zoom_finger_enable = EINA_FALSE;
_elm_config->glayer_zoom_finger_factor = 1.0;
_elm_config->glayer_zoom_wheel_factor = 0.05;
_elm_config->glayer_zoom_distance_tolerance = 1.0; /* 1 times elm_finger_size_get() */
Index: src/lib/elm_map.c
===
--- src/lib/elm_map.c	(리비전 66231)
+++ src/lib/elm_map.c	(작업 사본)
@@ -3223,12 +3223,15 @@ elm_map_add(Evas_Object *parent)
   _mouse_move, obj);
evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_UP,
   _mouse_up, obj);
-   evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_DOWN,
-  _mouse_multi_down, obj);
-   evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_MOVE,
-  _mouse_multi_move, obj);
-   evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_UP,
-  _mouse_multi_up, obj);
+   if (_elm_config->glayer_zoom_finger_enable)
+ {
+evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_DOWN,
+   _mouse_multi_down, obj);
+evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_MOVE,
+   _mouse_multi_move, obj);
+evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_UP,
+   _mouse_multi_up, obj);
+ }
evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_WHEEL,
   _mouse_wheel_cb, obj);
 
Index: src/lib/elm_gesture_layer.c
===
--- src/lib/elm_gesture_layer.c	(리비전 66231)
+++ src/lib/elm_gesture_layer.c	(작업 사본)
@@ -237,6 +237,7 @@ struct _Widget_Data
Evas_Coord zoom_distance_tolerance;
Evas_Coord line_distance_tolerance;
double line_angular_tolerance;
+   Eina_Bool zoom_finger_enable : 1; /* finger (pinch) zoom enable */
double zoom_wheel_factor; /*

Re: [E-devel] ecore_main_loop_glib_integrate (leak)

2011-12-15 Thread Guilherme Silveira
I'm trying to help Benatto, and I found some strange things...

When you call ecore_main_loop_glib_integrate(), it change main loop
function to _ecore_glib_select (ecore_glib.c) instead of select (default
one). I made some experiments and I saw when comment second line of
function:
GMutex *mutex = g_static_mutex_get_mutex(&lock);
the leak stop...
But We use glib a long time in blackfin, and I ran the follow test:

#include 
#include 

int
main(void)
{
for (;;) {
GStaticMutex lock = G_STATIC_MUTEX_INIT;
GMutex *mutex = g_static_mutex_get_mutex(&lock);
}

return 0;
}

Any leak occurs, I hope this experiments help someone to help us..

Regards,

2011/12/14 Paulo Benatto 

> Hi all,
>
> I have a doubt about ecore_main_loop_glib_integrate() with
> ecore_timer_add(). I did the example below, I compiled it to blackfin and
> x86. My problem is, when I run in blackfin occurs a memory leak, in x86 is
> ok (without leak). Is something wrong with my code? Any tips? I'm going to
> study ecore code. Thanks.
>
> #include 
> #include 
>
> static Ecore_Timer *update_datetime_timer = NULL;
>
> static Eina_Bool
> _update_datetime_cb(void *data)
> {
>return EINA_TRUE;
> }
>
> EAPI int
> elm_main(int argc, char **argv)
> {
>(void)argc;
>(void)argv;
>
>g_type_init();
>ecore_main_loop_glib_integrate();
>ecore_event_init();
>
>update_datetime_timer = ecore_timer_add(0.01, _update_datetime_cb,
> NULL);
>
>elm_run();
>
>elm_shutdown();
>
>return 0;
> }
> ELM_MAIN()
>
> Regards,
>
> --
> Paulo Leonardo Benatto, patito
> "the fear of being free, makes you proud of being a slave"
>
> --
> Cloud Computing - Latest Buzzword or a Glimpse of the Future?
> This paper surveys cloud computing today: What are the benefits?
> Why are businesses embracing it? What are its payoffs and pitfalls?
> http://www.accelacomm.com/jaw/sdnl/114/51425149/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Eng. Guilherme Silveira
E-mail: xgu...@gmail.com
Nextel: (48) 7811-8418 / ID: 85*227765
--
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.  
But none more important than the need to reduce IT complexity 
while improving strategic productivity.  Learn More! 
http://www.accelacomm.com/jaw/sdnl/114/51507609/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Tom Hacohen
On 15/12/11 16:34, Bluezery wrote:
> I reflected Daniel's comments.  I added setter/getter APIs for all
> gesture configuration. :D
> Please review again.

I have a couple of more suggestions:
1. I'm very very sorry, I just saw something I missed in Daniel's 
comment, get/set APIs is actually not needed, sorry. :((( please remove.
The reason for that is that those are configurations you set on the 
environment and should be of no concern to the programmer. I'm very 
sorry, but these should be removed. You can leave them there if you 
want, and I will gladly remove the to pay for my mistake.
2. No need for wd->zoom_finger_enable, just use the elm config values, 
the only reasons the other values are there is that we thought people 
may want to change them manually (but as said in #1, we don't want that 
atm). This is a patent issue, it should not be manually overridden per 
object, really no use for that.
3. There are still unrelated format changes (for example in 
Elementary.h.in).
4. The error message should explain more about why it's disabled and 
what to do to enable it (config).

Again, I'm very sorry. :(
>
> Configuration may be added later for rotation with finger and lines
> with fingers, etc.
> There exist a lot of damn patents :(

Yeah. :(

> Apple actually doesn't have a patent on "pinch-to-zoom but have limited. :p
> Please refers: 
> http://www.engadget.com/2010/10/13/apple-awarded-limited-patent-on-pinch-to-zoom/
> Anyway, we should be able to configure gestures with fingers because
> we cannot recognize overall patents.

I actually remember this link, read it before, but I will read it again, 
thanks.

--
Tom.

--
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.  
But none more important than the need to reduce IT complexity 
while improving strategic productivity.  Learn More! 
http://www.accelacomm.com/jaw/sdnl/114/51507609/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Tom Hacohen
On 15/12/11 16:34, Bluezery wrote:
> Apple actually doesn't have a patent on "pinch-to-zoom but have limited. :p
> Please refers: 
> http://www.engadget.com/2010/10/13/apple-awarded-limited-patent-on-pinch-to-zoom/
> Anyway, we should be able to configure gestures with fingers because
> we cannot recognize overall patents.

In my point of view, it sounds unrelated to what gesture layer does in 
my pov, but I only read the engadget summary, and not the whole 
document. And even if I have read the whole thing, I'm not sure I have 
the legal qualifications to determine anything. :)

--
Tom.

--
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.  
But none more important than the need to reduce IT complexity 
while improving strategic productivity.  Learn More! 
http://www.accelacomm.com/jaw/sdnl/114/51507609/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: jaehwan trunk/edje/src/bin

2011-12-15 Thread Gustavo Chaves
On Thu, Dec 15, 2011 at 7:15 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> Bug fix - about type change in group inherit.
>  Lately, raster removed the code about the prohibition of type-change in
>  group inherit.
>  But about the "part" of different type, the data structure of the their
>  "description" is different.
>  So if the type is changed, it have to be reallocated. Current, it is not.
>
>  At first, we have to remove the lookups. If we don't, when lookup module
>  executes, the memory
>  may be broken. So I removed all lookups for reallocated description before
>  it is reallocated.
>  And I changed all description of the "part" is reallocated when the type
> is
>  changed.
>  The attribute of the "part" is remained. Just it reallocated the part of
>  **_Spec_**.
>
>
Short on time to send an edc test now, but you just broke group
inheritance. Just
try to refer to an inherited part (say, with rel1.to) and edje_cc will
bitch about not finding it.

-- 
Gustavo Lima Chaves
Senior Developer

ProFUSION embedded systems

http://profusion.mobi
--
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.  
But none more important than the need to reduce IT complexity 
while improving strategic productivity.  Learn More! 
http://www.accelacomm.com/jaw/sdnl/114/51507609/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: jaehwan trunk/edje/src/bin

2011-12-15 Thread The Rasterman
On Thu, 15 Dec 2011 01:15:12 -0800 "Enlightenment SVN"
 said:

i've backed this out as this makes things worse... like stopping compiling from
being possible. see my commit log.

> Log:
> Bug fix - about type change in group inherit.
>   Lately, raster removed the code about the prohibition of type-change in
>   group inherit.
>   But about the "part" of different type, the data structure of the their
>   "description" is different.
>   So if the type is changed, it have to be reallocated. Current, it is not.
>   
>   At first, we have to remove the lookups. If we don't, when lookup module
>   executes, the memory
>   may be broken. So I removed all lookups for reallocated description before
>   it is reallocated.
>   And I changed all description of the "part" is reallocated when the type is
>   changed.
>   The attribute of the "part" is remained. Just it reallocated the part of
>   **_Spec_**.
>   
> 
> Author:   jaehwan
> Date: 2011-12-15 01:15:11 -0800 (Thu, 15 Dec 2011)
> New Revision: 66242
> Trac: http://trac.enlightenment.org/e/changeset/66242
> 
> Modified:
>   trunk/edje/src/bin/edje_cc_handlers.c trunk/edje/src/bin/edje_cc_mem.c
> trunk/edje/src/bin/edje_cc_out.c 
> 
> Modified: trunk/edje/src/bin/edje_cc_handlers.c
> ===
> --- trunk/edje/src/bin/edje_cc_handlers.c 2011-12-15 09:12:14 UTC (rev
> 66241) +++ trunk/edje/src/bin/edje_cc_handlers.c  2011-12-15 09:15:11
> UTC (rev 66242) @@ -831,7 +831,7 @@
>  }
>  
>  static Edje_Part_Description_Common *
> -_edje_part_description_alloc(unsigned char type, const char *collection,
> const char *part) +_edje_part_description_alloc(Edje_Part_Description_Common
> *ced, unsigned char type, const char *collection, const char *part) {
> Edje_Part_Description_Common *result = NULL;
>  
> @@ -840,14 +840,15 @@
>case EDJE_PART_TYPE_RECTANGLE:
>case EDJE_PART_TYPE_SWALLOW:
>case EDJE_PART_TYPE_GROUP:
> -  result = mem_alloc(SZ(Edje_Part_Description_Common));
> +  result = mem_realloc(ced, SZ(Edje_Part_Description_Common));
>break;
>case EDJE_PART_TYPE_TEXT:
>case EDJE_PART_TYPE_TEXTBLOCK:
>   {
>  Edje_Part_Description_Text *ed;
>  
> -ed = mem_alloc(SZ(Edje_Part_Description_Text));
> +   ed = mem_realloc(ced, SZ(Edje_Part_Description_Text));
> +   memset(&(ed->text), 0, SZ(Edje_Part_Description_Spec_Text));
>  
>  ed->text.color3.r = 0;
>  ed->text.color3.g = 0;
> @@ -865,7 +866,8 @@
>   {
>  Edje_Part_Description_Image *ed;
>  
> -ed = mem_alloc(SZ(Edje_Part_Description_Image));
> +   ed = mem_realloc(ced, SZ(Edje_Part_Description_Image));
> +   memset(&(ed->image), 0, SZ(Edje_Part_Description_Spec_Image));
>  
>  ed->image.id = -1;
>  
> @@ -878,7 +880,8 @@
>  {
> Edje_Part_Description_Proxy *ed;
>  
> -   ed = mem_alloc(SZ(Edje_Part_Description_Proxy));
> +   ed = mem_realloc(ced, SZ(Edje_Part_Description_Proxy));
> +   memset(&(ed->proxy), 0, SZ(Edje_Part_Description_Spec_Proxy));
>  
> ed->proxy.id = -1;
>  
> @@ -891,7 +894,8 @@
>   {
>  Edje_Part_Description_Box *ed;
>  
> -ed = mem_alloc(SZ(Edje_Part_Description_Box));
> +   ed = mem_realloc(ced, SZ(Edje_Part_Description_Box));
> +   memset(&(ed->box), 0, SZ(Edje_Part_Description_Spec_Box));
>  
>  ed->box.layout = NULL;
>  ed->box.alt_layout = NULL;
> @@ -907,7 +911,8 @@
>   {
>  Edje_Part_Description_Table *ed;
>  
> -ed = mem_alloc(SZ(Edje_Part_Description_Table));
> +   ed = mem_realloc(ced, SZ(Edje_Part_Description_Table));
> +   memset(&(ed->table), 0, SZ(Edje_Part_Description_Spec_Table));
>  
>  ed->table.homogeneous = EDJE_OBJECT_TABLE_HOMOGENEOUS_NONE;
>  ed->table.align.x = FROM_DOUBLE(0.5);
> @@ -922,7 +927,8 @@
>   {
>  Edje_Part_Description_External *ed;
>  
> -ed = mem_alloc(SZ(Edje_Part_Description_External));
> +   ed = mem_realloc(ced, SZ(Edje_Part_Description_External));
> +   ed->external_params = NULL;
>  
>  ed->external_params = NULL;
>  
> @@ -941,6 +947,53 @@
>  }
>  
>  static void
> +_edje_part_description_lookup_del(Edje_Part_Collection *pc,
> Edje_Part_Description_Common *ced, unsigned char type) +{
> +   switch (type)
> + {
> +  case EDJE_PART_TYPE_RECTANGLE:
> +  case EDJE_PART_TYPE_SWALLOW:
> +  case EDJE_PART_TYPE_GROUP:
> + break;
> +  case EDJE_PART_TYPE_TEXT:
> +  case EDJE_PART_TYPE_TEXTBLOCK:
> +{
> +   Edje_Part_Description_Text *ed = (Edje_Part_Description_Text*)ced;
> +
> +   data_queue_part_lookup(pc, NULL, &(ed->text.id_source));
> +   data_queue_part_lookup(pc, NULL, &(ed->text.id_text_source));
> +   break;
> +}
> +  case EDJE_PART

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Bluezery
2011/12/15 Tom Hacohen :
> I have a couple of more suggestions:
> 1. I'm very very sorry, I just saw something I missed in Daniel's comment,
> get/set APIs is actually not needed, sorry. :((( please remove.
> The reason for that is that those are configurations you set on the
> environment and should be of no concern to the programmer. I'm very sorry,
> but these should be removed. You can leave them there if you want, and I
> will gladly remove the to pay for my mistake.
> 2. No need for wd->zoom_finger_enable, just use the elm config values, the
> only reasons the other values are there is that we thought people may want
> to change them manually (but as said in #1, we don't want that atm). This is
> a patent issue, it should not be manually overridden per object, really no
> use for that.
> 3. There are still unrelated format changes (for example in
> Elementary.h.in).
> 4. The error message should explain more about why it's disabled and what to
> do to enable it (config).
>
> Again, I'm very sorry. :(

No problem!! I have learned a lot. :D
I removed whole gesture layer's get/set APIs.


2011/12/16 Tom Hacohen :
> In my point of view, it sounds unrelated to what gesture layer does in my
> pov, but I only read the engadget summary, and not the whole document. And
> even if I have read the whole thing, I'm not sure I have the legal
> qualifications to determine anything. :)

Yeah, Apple does not have complete pinch to zoom patent.
But, I don't know who have this or It may be patent pending  :-( ...

--
BRs,
Kim.
Index: src/lib/elm_config.c
===
--- src/lib/elm_config.c	(리비전 66265)
+++ src/lib/elm_config.c	(작업 사본)
@@ -318,6 +318,7 @@ _desc_init(void)
ELM_CONFIG_VAL(D, T, desktop_entry, T_UCHAR);
ELM_CONFIG_VAL(D, T, password_show_last, T_UCHAR);
ELM_CONFIG_VAL(D, T, password_show_last_timeout, T_DOUBLE);
+   ELM_CONFIG_VAL(D, T, glayer_zoom_finger_enable, T_UCHAR);
ELM_CONFIG_VAL(D, T, glayer_zoom_finger_factor, T_DOUBLE);
ELM_CONFIG_VAL(D, T, glayer_zoom_wheel_factor, T_DOUBLE);
ELM_CONFIG_VAL(D, T, glayer_zoom_distance_tolerance, T_DOUBLE);
@@ -887,6 +888,7 @@ _config_load(void)
_elm_config->is_mirrored = EINA_FALSE; /* Read sys value in env_get() */
_elm_config->password_show_last = EINA_FALSE;
_elm_config->password_show_last_timeout = 2.0;
+   _elm_config->glayer_zoom_finger_enable = EINA_FALSE;
_elm_config->glayer_zoom_finger_factor = 1.0;
_elm_config->glayer_zoom_wheel_factor = 0.05;
_elm_config->glayer_zoom_distance_tolerance = 1.0; /* 1 times elm_finger_size_get() */
Index: src/lib/elm_map.c
===
--- src/lib/elm_map.c	(리비전 66265)
+++ src/lib/elm_map.c	(작업 사본)
@@ -3223,12 +3223,15 @@ elm_map_add(Evas_Object *parent)
   _mouse_move, obj);
evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_UP,
   _mouse_up, obj);
-   evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_DOWN,
-  _mouse_multi_down, obj);
-   evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_MOVE,
-  _mouse_multi_move, obj);
-   evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_UP,
-  _mouse_multi_up, obj);
+   if (_elm_config->glayer_zoom_finger_enable)
+ {
+evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_DOWN,
+   _mouse_multi_down, obj);
+evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_MOVE,
+   _mouse_multi_move, obj);
+evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MULTI_UP,
+   _mouse_multi_up, obj);
+ }
evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_WHEEL,
   _mouse_wheel_cb, obj);
 
Index: src/lib/elm_gesture_layer.c
===
--- src/lib/elm_gesture_layer.c	(리비전 66265)
+++ src/lib/elm_gesture_layer.c	(작업 사본)
@@ -3327,6 +3327,12 @@ elm_gesture_layer_cb_set(Evas_Object *ob
Gesture_Info *p;
if (!wd) return;
 
+   if (!_elm_config->glayer_zoom_finger_enable && idx == ELM_GESTURE_ZOOM)
+ {
+ERR("Finger(pinch) zoom is disabled for some reasons such as patent issues. if you want enable it, you should change glayer_zoom_finger_enable value in elementary configuration");
+return;
+ }
+
if (!wd->gesture[idx])
  wd->gesture[idx] = calloc(1, sizeof(Gesture_Info));
if (!wd->gesture[idx]) return;
Index: src/lib/elm_priv.h
===
--- src/lib/elm_priv.h	(리비전 66265)
+++ src/lib/elm_priv.h	(작업 사본)
@@ -149,6 +149,7 @@ struct _Elm_Config

Re: [E-devel] E SVN: raster trunk/edje/src/bin

2011-12-15 Thread Jaehwan Kim
Dear raster

Thank you for getting back out and sorry for an inconvenience.
I should have be more careful.
But It's necessary code for type change.
After I check the issue, I will fix the seg fault.

Thanks
--
Jaehwan Kim


2011년 12월 16일 금요일에 Enlightenment SVN님이 작성:

> Log:
> back out:
>  r66257 <- another small fix on the real problem
>  r66250 <- a small fix on the real problem
>  r66242 <- the real problem
>
>  jaewhan - your commit yesterday (r66242) has made edje_cc very
>  unstable and it will randomly segv (sometimes yes, sometimes no). as
>  such it's at the point i can't even compile e and elm without it
>  segving somewhere during build, so this gets backed out. review your
>  change carefully and look for issues.
>
>
>
> Author:   raster
> Date: 2011-12-15 16:29:05 -0800 (Thu, 15 Dec 2011)
> New Revision: 66265
> Trac: http://trac.enlightenment.org/e/changeset/66265
>
> Modified:
>  trunk/edje/src/bin/edje_cc_handlers.c trunk/edje/src/bin/edje_cc_mem.c
> trunk/edje/src/bin/edje_cc_out.c
>
> Modified: trunk/edje/src/bin/edje_cc_handlers.c
> ===
> --- trunk/edje/src/bin/edje_cc_handlers.c   2011-12-15 22:27:59 UTC
> (rev 66264)
> +++ trunk/edje/src/bin/edje_cc_handlers.c   2011-12-16 00:29:05 UTC
> (rev 66265)
> @@ -832,7 +832,7 @@
>  }
>
>  static Edje_Part_Description_Common *
> -_edje_part_description_alloc(Edje_Part_Description_Common *ced, unsigned
> char type, const char *collection, const char *part)
> +_edje_part_description_alloc(unsigned char type, const char *collection,
> const char *part)
>  {
>Edje_Part_Description_Common *result = NULL;
>
> @@ -841,15 +841,14 @@
>   case EDJE_PART_TYPE_RECTANGLE:
>   case EDJE_PART_TYPE_SWALLOW:
>   case EDJE_PART_TYPE_GROUP:
> -result = mem_realloc(ced, SZ(Edje_Part_Description_Common));
> +result = mem_alloc(SZ(Edje_Part_Description_Common));
> break;
>   case EDJE_PART_TYPE_TEXT:
>   case EDJE_PART_TYPE_TEXTBLOCK:
>{
>   Edje_Part_Description_Text *ed;
>
> -   ed = mem_realloc(ced, SZ(Edje_Part_Description_Text));
> -   memset(&(ed->text), 0, SZ(Edje_Part_Description_Spec_Text));
> +  ed = mem_alloc(SZ(Edje_Part_Description_Text));
>
>   ed->text.color3.r = 0;
>   ed->text.color3.g = 0;
> @@ -867,8 +866,7 @@
>{
>   Edje_Part_Description_Image *ed;
>
> -   ed = mem_realloc(ced, SZ(Edje_Part_Description_Image));
> -   memset(&(ed->image), 0, SZ(Edje_Part_Description_Spec_Image));
> +  ed = mem_alloc(SZ(Edje_Part_Description_Image));
>
>   ed->image.id = -1;
>
> @@ -881,8 +879,7 @@
> {
>Edje_Part_Description_Proxy *ed;
>
> -   ed = mem_realloc(ced, SZ(Edje_Part_Description_Proxy));
> -   memset(&(ed->proxy), 0, SZ(Edje_Part_Description_Spec_Proxy));
> +   ed = mem_alloc(SZ(Edje_Part_Description_Proxy));
>
>ed->proxy.id = -1;
>
> @@ -895,8 +892,7 @@
>{
>   Edje_Part_Description_Box *ed;
>
> -   ed = mem_realloc(ced, SZ(Edje_Part_Description_Box));
> -   memset(&(ed->box), 0, SZ(Edje_Part_Description_Spec_Box));
> +  ed = mem_alloc(SZ(Edje_Part_Description_Box));
>
>   ed->box.layout = NULL;
>   ed->box.alt_layout = NULL;
> @@ -912,8 +908,7 @@
>{
>   Edje_Part_Description_Table *ed;
>
> -   ed = mem_realloc(ced, SZ(Edje_Part_Description_Table));
> -   memset(&(ed->table), 0, SZ(Edje_Part_Description_Spec_Table));
> +  ed = mem_alloc(SZ(Edje_Part_Description_Table));
>
>   ed->table.homogeneous = EDJE_OBJECT_TABLE_HOMOGENEOUS_NONE;
>   ed->table.align.x = FROM_DOUBLE(0.5);
> @@ -928,8 +923,7 @@
>{
>   Edje_Part_Description_External *ed;
>
> -   ed = mem_realloc(ced, SZ(Edje_Part_Description_External));
> -   ed->external_params = NULL;
> +  ed = mem_alloc(SZ(Edje_Part_Description_External));
>
>   ed->external_params = NULL;
>
> @@ -948,53 +942,6 @@
>  }
>
>  static void
> -_edje_part_description_lookup_del(Edje_Part_Collection *pc,
> Edje_Part_Description_Common *ced, unsigned char type)
> -{
> -   switch (type)
> - {
> -  case EDJE_PART_TYPE_RECTANGLE:
> -  case EDJE_PART_TYPE_SWALLOW:
> -  case EDJE_PART_TYPE_GROUP:
> - break;
> -  case EDJE_PART_TYPE_TEXT:
> -  case EDJE_PART_TYPE_TEXTBLOCK:
> -{
> -   Edje_Part_Description_Text *ed =
> (Edje_Part_Description_Text*)ced;
> -
> -   data_queue_part_lookup(pc, NULL, &(ed->text.id_source));
> -   data_queue_part_lookup(pc, NULL, &(ed->text.id_text_source));
> -   break;
> -}
> -  case EDJE_PART_TYPE_IMAGE:
> -{
> -   int i;
> -   Edje_Part_Description_Image *ed =
> (Edje_Part_Description_Image*)ced;
> -   Edje_Part_Image_Id *iid;
> -
> - 

Re: [E-devel] [Patch] elc_ctxpopup: using calculated value, getting size from the style also.

2011-12-15 Thread ChunEon Park
in. thanks.
rev 66267

-Regards, Hermet-
 
-Original Message-
From: "Kim Shinwoo" 
To: "Enlightenment developer 
list"
Cc: 
Sent: 11-12-13(화) 15:31:35
Subject: Re: [E-devel] [Patch] elc_ctxpopup: using calculated value, getting 
size from the style also.
Sure, I have separated the path.
The attached patch is for the using previous result which is calculated by
the _calc_base_geometry();
Thanks always.. Please review this patch first. I will send second one
based on the attached.
Sincerely,
Shinwoo Kim.
2011년 12월 13일 오후 1:21, ChunEon Park 님의 말:
> Reverted.
> Unfortunately, this patch should not be applied.
> The reason is I replied already.
> 
> -Regards, Hermet-
>
> -Original Message-
> From: "Carsten Haitzler"
> To: "Enlightenment developer list"&
> lt;enlightenment-devel@lists.sourceforge.net>
> Cc: "cnook"
> Sent: 11-12-13(화) 12:37:51
> Subject: Re: [E-devel] [Patch] elc_ctxpopup: using calculated value,
> getting size from the style also.
> On Mon, 5 Dec 2011 15:20:36 +0900 cnook  said:
> looked at it - nothing obviously wrong in the reading of it. formatting all
> looks fine to me. in svn it goes. thanks!
> > Dear All, Hello!
> >
> > As the title, attached patch has followings.
> >
> > 1) Using Calculated Value: The _update_arrow(); had used
> > evas_object_geometry_get(); internally for getting its base size.
> > But the _calc_base_geometry(); already got the base size which
> > is more accurate.
> >
> > 2) Getting Size From The Style Also: If the ctxpopup has content
> > which is composed using the style (means, the size of
> > content can get from *.edc file only), then ctxpopup does not
> > come properly. So resolving this, the patch is using a box,
> > and add a RESIZE callback to the box. When the box is resized,
> > the callback calls elm_box_recalculate();
> >
> > Then, please review this patch and give any feedbacks. Thanks a lot.
> >
> > Sincerely,
> > Shinwoo Kim.
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler) ras...@rasterman.com
>
> --
> Systems Optimization Self Assessment
> Improve efficiency and utilization of IT resources. Drive out cost and
> improve service delivery. Take 5 minutes to use this Systems Optimization
> Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> --
> Systems Optimization Self Assessment
> Improve efficiency and utilization of IT resources. Drive out cost and
> improve service delivery. Take 5 minutes to use this Systems Optimization
> Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. 
http://www.accelacomm.com/jaw/sdnl/114/51450054/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elc_ctxpopup: using calculated value, getting size from the style also.

2011-12-15 Thread ChunEon Park
in. thank you.
rev 66268

-Regards, Hermet-
 
-Original Message-
From: "Kim Shinwoo" 
To: "Enlightenment developer 
list"
Cc: 
Sent: 11-12-13(화) 20:35:16
Subject: Re: [E-devel] [Patch] elc_ctxpopup: using calculated value, getting 
size from the style also.
The patch had been kidnapped. -,.-;;
2011년 12월 13일 오후 8:32, Kim Shinwoo 님의 말:
> Hey dear, here is the second patch using the box for the ctxpopup's
> content.
> The wd->content is content which is set by
> elm_object_content_set(ctxpopup, content) not the box.
> Please check this and give any feedbacks, Thanks. :-)
>
>
> 2011년 12월 13일 오후 3:31, Kim Shinwoo 님의 말:
>
> Sure, I have separated the path.
>> The attached patch is for the using previous result which is calculated
>> by the _calc_base_geometry();
>> Thanks always.. Please review this patch first. I will send second one
>> based on the attached.
>>
>> Sincerely,
>> Shinwoo Kim.
>>
>> 2011년 12월 13일 오후 1:21, ChunEon Park 님의 말:
>>
>> Reverted.
>>> Unfortunately, this patch should not be applied.
>>> The reason is I replied already.
>>> 
>>> -Regards, Hermet-
>>>
>>> -Original Message-
>>> From: "Carsten Haitzler"
>>> To: "Enlightenment developer list"&
>>> lt;enlightenment-devel@lists.sourceforge.net>
>>> Cc: "cnook"
>>> Sent: 11-12-13(화) 12:37:51
>>> Subject: Re: [E-devel] [Patch] elc_ctxpopup: using calculated value,
>>> getting size from the style also.
>>> On Mon, 5 Dec 2011 15:20:36 +0900 cnook  said:
>>> looked at it - nothing obviously wrong in the reading of it. formatting
>>> all
>>> looks fine to me. in svn it goes. thanks!
>>> > Dear All, Hello!
>>> >
>>> > As the title, attached patch has followings.
>>> >
>>> > 1) Using Calculated Value: The _update_arrow(); had used
>>> > evas_object_geometry_get(); internally for getting its base size.
>>> > But the _calc_base_geometry(); already got the base size which
>>> > is more accurate.
>>> >
>>> > 2) Getting Size From The Style Also: If the ctxpopup has content
>>> > which is composed using the style (means, the size of
>>> > content can get from *.edc file only), then ctxpopup does not
>>> > come properly. So resolving this, the patch is using a box,
>>> > and add a RESIZE callback to the box. When the box is resized,
>>> > the callback calls elm_box_recalculate();
>>> >
>>> > Then, please review this patch and give any feedbacks. Thanks a lot.
>>> >
>>> > Sincerely,
>>> > Shinwoo Kim.
>>> --
>>> - Codito, ergo sum - "I code, therefore I am" --
>>> The Rasterman (Carsten Haitzler) ras...@rasterman.com
>>>
>>> --
>>> Systems Optimization Self Assessment
>>> Improve efficiency and utilization of IT resources. Drive out cost and
>>> improve service delivery. Take 5 minutes to use this Systems Optimization
>>> Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
>>> ___
>>> enlightenment-devel mailing list
>>> enlightenment-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>>
>>> --
>>> Systems Optimization Self Assessment
>>> Improve efficiency and utilization of IT resources. Drive out cost and
>>> improve service delivery. Take 5 minutes to use this Systems Optimization
>>> Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
>>> ___
>>> enlightenment-devel mailing list
>>> enlightenment-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>>
>>
>>
>
--
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. 
http://www.accelacomm.com/jaw/sdnl/114/51450054/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourcefo