Re: [E-devel] [patch] elm_genlist - rename and fix typo error in internal variables (2/2)
In SVN. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Apr 5, 2012 at 3:13 PM, Hyoyoung Chang wrote: > Dear all, > > It simple renaming patch for elm_genlist. > I rename two variables. > > deco_all_obj -> deco_all_view > deco_all_textss -> deco_all_texts > > Thanks > > -- > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] elm_genlist - add functionality to elm_genlist_fields_update (1/2)
In SVN. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Apr 5, 2012 at 3:12 PM, Hyoyoung Chang wrote: > Dear all, > > I made a patch for elm_genlist_fields_update to selective content update. > a genlist item can update any content regardless of its mode. > > Thanks. > > PS: It assumed my previous patch is applied ([patch] elm_genlist - > split flip content from item's content) > > -- > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elementary] elc_popup, focus next hook implementation
in svn 69947 But I changed here also. please refer. 64 static Eina_Bool 65 -_focus_next_hook(const Evas_Object *obj __UNUSED__, 66 - Elm_Focus_Direction dir __UNUSED__, 67 - Evas_Object **next __UNUSED__) 68 +_focus_next_hook(const Evas_Object *obj, 69 + Elm_Focus_Direction dir, 70 + Evas_Object **next) Thank you very much -Regards, Hermet- -Original Message- From: "Kim Shinwoo"To: "Enlightenment developer list" ; Cc: Sent: 2012-04-06 (금) 00:20:34 Subject: [E-devel] [Patch][elementary] elc_popup, focus next hook implementation Current Issue: Focus does not go to Popup content and action area. Reason: focus_next hook is returning EINA_FALSE in focus_next_hook. Change Description: 1. Routed the focus_next call to the internal notify object. 2. Set the visibility of action area layout in edc to True as the visibility of the action area layout returns zero even if due to state change it is set to visible state in edje. 3. Deleted the show event callback "_popup_show" in del_pre_ hook. Signed-Off-By: RAJEEV RANJAN @samsumg.com> -- Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Eobj - Request for review/comments
Yeah, we got it. You say it so muxh that it's all I think about nowadays. I can't commit without having flashbacks of you saying it... On Apr 6, 2012 11:06 AM, "Vincent Torri" wrote: > On Fri, Apr 6, 2012 at 9:58 AM, Tom Hacohen wrote: > > Yeah, no need to worry. As I said, it'll use whatever we use. > > yep. And i'll leave if cmake is used, as i've said before. > > Vincent > -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: seoz trunk/elementary/src/lib
On Fri, Apr 6, 2012 at 4:10 PM, Enlightenment SVN wrote: > Log: > elm genlist: Get the stringlist only when it does not exist. Free the > stringlist when we change the item class. > > Author: seoz > Date: 2012-04-06 00:10:29 -0700 (Fri, 06 Apr 2012) > New Revision: 69946 > Trac: http://trac.enlightenment.org/e/changeset/69946 > > Modified: > trunk/elementary/src/lib/elm_genlist.c > > Modified: trunk/elementary/src/lib/elm_genlist.c > === > --- trunk/elementary/src/lib/elm_genlist.c 2012-04-06 07:10:26 UTC (rev > 69945) > +++ trunk/elementary/src/lib/elm_genlist.c 2012-04-06 07:10:29 UTC (rev > 69946) > @@ -1904,7 +1904,8 @@ > const Eina_List *l; > const char *key; > > - *source = elm_widget_stringlist_get(edje_object_data_get(target, > "texts")); > + if (!(*source)) > + *source = elm_widget_stringlist_get(edje_object_data_get(target, > "texts")); > EINA_LIST_FOREACH(*source, l, key) > { > if (parts && fnmatch(parts, key, FNM_PERIOD)) > @@ -2010,7 +2011,8 @@ > const char *key; > char buf[4096]; > > - *source = elm_widget_stringlist_get(edje_object_data_get(target, > "states")); > + if (!(*source)) > + *source = elm_widget_stringlist_get(edje_object_data_get(target, > "states")); > EINA_LIST_FOREACH(*source, l, key) > { > if (parts && fnmatch(parts, key, FNM_PERIOD)) > @@ -2171,8 +2173,9 @@ > if (it->flipped) > { > edje_object_signal_emit(VIEW(it), "elm,state,flip,enabled", > "elm"); > - it->item->flip_contents = > - elm_widget_stringlist_get(edje_object_data_get(VIEW(it), > "flips")); > + if (!(it->item->flip_contents)) > + it->item->flip_contents = > + elm_widget_stringlist_get(edje_object_data_get(VIEW(it), > "flips")); > it->item->flip_content_objs = > _item_mode_content_realize(it, VIEW(it), > &it->item->flip_contents, NULL, > @@ -3271,8 +3274,9 @@ > assert(eina_list_count(it->item->deco_it_content_objs) == 0); > > _item_text_realize(it, it->item->deco_it_view, &it->item->deco_it_texts, > NULL); > - it->item->deco_it_contents = > - elm_widget_stringlist_get(edje_object_data_get(it->item->deco_it_view, > "contents")); > + if (!it->item->deco_it_contents) > + it->item->deco_it_contents = > + > elm_widget_stringlist_get(edje_object_data_get(it->item->deco_it_view, > "contents")); > it->item->deco_it_content_objs = > _item_mode_content_realize(it, it->item->deco_it_view, > &it->item->deco_it_contents, NULL, > @@ -3425,8 +3429,9 @@ > > _item_text_realize(it, it->deco_all_view, &it->item->deco_all_texts, NULL); > if (it->flipped) edje_object_signal_emit(it->deco_all_view, > "elm,state,flip,enabled", "elm"); > - it->item->deco_all_contents = > - elm_widget_stringlist_get(edje_object_data_get(it->deco_all_view, > "contents")); > + if (!it->item->deco_all_contents) > + it->item->deco_all_contents = > + elm_widget_stringlist_get(edje_object_data_get(it->deco_all_view, > "contents")); > it->item->deco_all_content_objs = > _item_mode_content_realize(it, it->deco_all_view, > &it->item->deco_all_contents, NULL, > @@ -5100,6 +5105,34 @@ > if (_it->generation < _it->wd->generation) return; > _it->itc = itc; > _it->item->nocache_once = EINA_TRUE; > + > + elm_widget_stringlist_free(_it->texts); > + _it->texts = NULL; > + elm_widget_stringlist_free(_it->contents); > + _it->contents = NULL; > + elm_widget_stringlist_free(_it->states); > + _it->states = NULL; > + > + if (_it->flipped) > + { > + elm_widget_stringlist_free(_it->item->flip_contents); > + _it->item->flip_contents = NULL; > + } > + if (_it->item->deco_it_view) > + { > + elm_widget_stringlist_free(_it->item->deco_it_texts); > + _it->item->deco_it_texts = NULL; > + elm_widget_stringlist_free(_it->item->deco_it_contents); > + _it->item->deco_it_contents = NULL; > + } > + if (_it->wd->decorate_all_mode) > + { > + elm_widget_stringlist_free(_it->item->deco_all_texts); > + _it->item->deco_all_texts = NULL; > + elm_widget_stringlist_free(_it->item->deco_all_contents); > + _it->item->deco_all_contents = NULL; > + } > + > elm_genlist_item_update(it); > } elm_genlist_item_item_class_update() calls _update_job() _update_job() calls item unrealizing. how about to move freeing widget string routine to item_unrealize? > > > > -- > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor
Re: [E-devel] E SVN: seoz trunk/elementary/src/lib
No, it doesn't need to be freed at every unrealize. stringlist will stay same until item style changes so realize/unrealize do not change the string list. So this is more optimized way of doing it. Daniel Juyung Seo (SeoZ) On Fri, Apr 6, 2012 at 9:21 PM, Hyoyoung Chang wrote: > On Fri, Apr 6, 2012 at 4:10 PM, Enlightenment SVN > wrote: >> Log: >> elm genlist: Get the stringlist only when it does not exist. Free the >> stringlist when we change the item class. >> >> Author: seoz >> Date: 2012-04-06 00:10:29 -0700 (Fri, 06 Apr 2012) >> New Revision: 69946 >> Trac: http://trac.enlightenment.org/e/changeset/69946 >> >> Modified: >> trunk/elementary/src/lib/elm_genlist.c >> >> Modified: trunk/elementary/src/lib/elm_genlist.c >> === >> --- trunk/elementary/src/lib/elm_genlist.c 2012-04-06 07:10:26 UTC (rev >> 69945) >> +++ trunk/elementary/src/lib/elm_genlist.c 2012-04-06 07:10:29 UTC (rev >> 69946) >> @@ -1904,7 +1904,8 @@ >> const Eina_List *l; >> const char *key; >> >> - *source = elm_widget_stringlist_get(edje_object_data_get(target, >> "texts")); >> + if (!(*source)) >> + *source = elm_widget_stringlist_get(edje_object_data_get(target, >> "texts")); >> EINA_LIST_FOREACH(*source, l, key) >> { >> if (parts && fnmatch(parts, key, FNM_PERIOD)) >> @@ -2010,7 +2011,8 @@ >> const char *key; >> char buf[4096]; >> >> - *source = elm_widget_stringlist_get(edje_object_data_get(target, >> "states")); >> + if (!(*source)) >> + *source = elm_widget_stringlist_get(edje_object_data_get(target, >> "states")); >> EINA_LIST_FOREACH(*source, l, key) >> { >> if (parts && fnmatch(parts, key, FNM_PERIOD)) >> @@ -2171,8 +2173,9 @@ >> if (it->flipped) >> { >> edje_object_signal_emit(VIEW(it), "elm,state,flip,enabled", >> "elm"); >> - it->item->flip_contents = >> - elm_widget_stringlist_get(edje_object_data_get(VIEW(it), >> "flips")); >> + if (!(it->item->flip_contents)) >> + it->item->flip_contents = >> + elm_widget_stringlist_get(edje_object_data_get(VIEW(it), >> "flips")); >> it->item->flip_content_objs = >> _item_mode_content_realize(it, VIEW(it), >> &it->item->flip_contents, NULL, >> @@ -3271,8 +3274,9 @@ >> assert(eina_list_count(it->item->deco_it_content_objs) == 0); >> >> _item_text_realize(it, it->item->deco_it_view, &it->item->deco_it_texts, >> NULL); >> - it->item->deco_it_contents = >> - elm_widget_stringlist_get(edje_object_data_get(it->item->deco_it_view, >> "contents")); >> + if (!it->item->deco_it_contents) >> + it->item->deco_it_contents = >> + >> elm_widget_stringlist_get(edje_object_data_get(it->item->deco_it_view, >> "contents")); >> it->item->deco_it_content_objs = >> _item_mode_content_realize(it, it->item->deco_it_view, >> &it->item->deco_it_contents, NULL, >> @@ -3425,8 +3429,9 @@ >> >> _item_text_realize(it, it->deco_all_view, &it->item->deco_all_texts, >> NULL); >> if (it->flipped) edje_object_signal_emit(it->deco_all_view, >> "elm,state,flip,enabled", "elm"); >> - it->item->deco_all_contents = >> - elm_widget_stringlist_get(edje_object_data_get(it->deco_all_view, >> "contents")); >> + if (!it->item->deco_all_contents) >> + it->item->deco_all_contents = >> + elm_widget_stringlist_get(edje_object_data_get(it->deco_all_view, >> "contents")); >> it->item->deco_all_content_objs = >> _item_mode_content_realize(it, it->deco_all_view, >> &it->item->deco_all_contents, NULL, >> @@ -5100,6 +5105,34 @@ >> if (_it->generation < _it->wd->generation) return; >> _it->itc = itc; >> _it->item->nocache_once = EINA_TRUE; >> + >> + elm_widget_stringlist_free(_it->texts); >> + _it->texts = NULL; >> + elm_widget_stringlist_free(_it->contents); >> + _it->contents = NULL; >> + elm_widget_stringlist_free(_it->states); >> + _it->states = NULL; >> + >> + if (_it->flipped) >> + { >> + elm_widget_stringlist_free(_it->item->flip_contents); >> + _it->item->flip_contents = NULL; >> + } >> + if (_it->item->deco_it_view) >> + { >> + elm_widget_stringlist_free(_it->item->deco_it_texts); >> + _it->item->deco_it_texts = NULL; >> + elm_widget_stringlist_free(_it->item->deco_it_contents); >> + _it->item->deco_it_contents = NULL; >> + } >> + if (_it->wd->decorate_all_mode) >> + { >> + elm_widget_stringlist_free(_it->item->deco_all_texts); >> + _it->item->deco_all_texts = NULL; >> + elm_widget_stringlist_free(_it->item->deco_all_contents); >> + _it->item->deco_all_contents = NULL; >>
Re: [E-devel] virtualbox GL blacklist
Maybe blacklist for that version "only" ? I think that is related in the way of how it works this GL, i think that is something like a fake layer underlying to the real graphic card, this could explain why do strange things like "ghosted windows of GL when switching e17 desktops" 2012/4/4 Vincent Torri > On Wed, Apr 4, 2012 at 11:13 AM, Thanatermesis > wrote: > > E17 segfaults in the first run on virtualbox, when is running the wizard > > module checking for GL capabilities. > > > > The GL of virtualbox seems at this state a bit buggy, it seems to be a > kind > > of overlay to the real graphic card, it does some buggy things on the > > interfaces, I think that the best could be to blacklist it (to fallback > to > > software x11 mode). > > > > There's a traceback and a glxinfo: > > > > http://pastebin.com/YpTTLm3d > > > > http://pastebin.com/rqH2azgK > > i'm wondering if the fact that glx version is < 1.4 is the problem or not > > Vincent > > > -- > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch] evas doxygen warnings
Hi, Attached patch fixes a bunch of warnings in evas doc: - Make remaining EINA_{TRUE,FALSE} @c, removing some undef link in same time - Make remaining NULL @c - Fix the color space list - small random fix Build log diff: -/tmp/evas/src/lib/Evas.h:3741: warning: explicit link request to 'Evas_Canvas_Events' could not be resolved -/tmp/evas/src/lib/Evas.h:6424: warning: End of list marker found has invalid indent level -/tmp/evas/src/lib/Evas.h:6443: warning: End of list marker found has invalid indent level -/tmp/evas/src/lib/Evas.h:6469: warning: End of list marker found has invalid indent level -/tmp/evas/src/lib/Evas.h:6473: warning: End of list marker found has invalid indent level -/tmp/evas/src/lib/Evas.h:6500: warning: End of list marker found has invalid indent level -/tmp/evas/src/lib/Evas.h:9106: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:9106: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:9064: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:9064: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8749: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8749: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8757: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8757: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:9092: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:9092: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8914: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8914: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8718: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8718: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8725: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8725: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8733: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8733: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8741: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8741: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8832: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8832: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8613: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8613: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8621: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8621: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8774: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8774: warning: explicit link request to 'EINA_FALSE' could not be resolved -/tmp/evas/src/lib/Evas.h:8765: warning: explicit link request to 'EINA_TRUE' could not be resolved -/tmp/evas/src/lib/Evas.h:8765: warning: explicit link request to 'EINA_FALSE' could not be resolved -- Jérôme Pinot http://ngc891.blogdns.net/ Index: evas/src/lib/Evas.h === --- evas/src/lib/Evas.h (revision 69955) +++ evas/src/lib/Evas.h (working copy) @@ -1305,8 +1305,7 @@ * @attention it is recommended that one calls evas_init() before * creating new canvas. * - * @return A new uninitialised Evas canvas on success. Otherwise, @c - * NULL. + * @return A new uninitialised Evas canvas on success. Otherwise, @c NULL. * @ingroup Evas_Canvas */ EAPI Evas *evas_new (void) EINA_WARN_UNUSED_RESULT EINA_MALLOC; @@ -1677,7 +1676,7 @@ * available. The strings should never be modified, neither should the * list be modified. This list should be cleaned up as soon as the * program no longer needs it using evas_render_method_list_free(). If - * no engines are available from Evas, NULL will be returned. + * no engines are available from Evas, @c NULL will be returned. * * Example: * @code @@ -1788,7 +1787,7 @@ * * @param eThe pointer to the Evas Canvas * @param info The pointer to the Engine Info to use -