Re: [E-devel] Enlightenment Wayland bugs

2016-12-11 Thread Vasiliy Tolstov
Also in terminology windows and other e windows (settinal and other) i
have very big mouse pointer =(

2016-12-11 6:19 GMT+03:00 Vasiliy Tolstov :
> Hi, I'm use latest released e and efl and try Wayland. Some issues blocks me
> from using Wayland
> * keyboard switching via menu key not works (menu key handled via e and
> opens menu)
> * sometimes windows can't be closed
> * sometimes window duplicates and I have 3 identical windows but only one
> can be used and react to key input.



-- 
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [core/efl] master 01/01: elementary: naviframe uses widget item for atspi

2016-12-11 Thread Shinwoo Kim
kimcinoo pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ba03d68117198762198a04f82c0730bcce5eac85

commit ba03d68117198762198a04f82c0730bcce5eac85
Author: Shinwoo Kim 
Date:   Sun Dec 11 19:38:00 2016 +0900

elementary: naviframe uses widget item for atspi

Application developer could rewrite accessible information of naviframe 
item.
But view object - VIEW(item) - is not accessible from application side.
So the accessible information should be set to widget item.
---
 src/lib/elementary/elc_naviframe.c   | 17 +
 src/lib/elementary/elm_naviframe_item.eo |  1 +
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/lib/elementary/elc_naviframe.c 
b/src/lib/elementary/elc_naviframe.c
index 57e1b03..81d20fb 100644
--- a/src/lib/elementary/elc_naviframe.c
+++ b/src/lib/elementary/elc_naviframe.c
@@ -460,7 +460,7 @@ _access_obj_process(Elm_Naviframe_Item_Data *it, Eina_Bool 
is_access)
 }
 
 EOLIAN static void
-_elm_naviframe_item_elm_widget_item_part_text_set(Eo *eo_it EINA_UNUSED,
+_elm_naviframe_item_elm_widget_item_part_text_set(Eo *eo_it,
   Elm_Naviframe_Item_Data *it,
   const char *part,
   const char *label)
@@ -526,7 +526,7 @@ _elm_naviframe_item_elm_widget_item_part_text_set(Eo *eo_it 
EINA_UNUSED,
 if (nit->title_label) strncat(buf, " ", 1);
 strncat(buf, nit->subtitle_label, sizeof(buf) - strlen(buf) - 2);
  }
-   elm_interface_atspi_accessible_name_set(VIEW(it), buf);
+   elm_interface_atspi_accessible_name_set(eo_it, buf);
 
elm_layout_sizing_eval(WIDGET(nit));
 }
@@ -1224,6 +1224,8 @@ _item_new(Evas_Object *obj,
ELM_NAVIFRAME_DATA_GET(obj, sd);
 
eo_item = efl_add(ELM_NAVIFRAME_ITEM_CLASS, obj);
+   elm_interface_atspi_accessible_role_set(eo_item, ELM_ATSPI_ROLE_PAGE_TAB);
+   elm_interface_atspi_accessible_name_set(eo_item, (char*)title_label);
 
if (!eo_item)
  {
@@ -1235,8 +1237,6 @@ _item_new(Evas_Object *obj,
 
//item base layout
VIEW(it) = elm_layout_add(obj);
-   elm_interface_atspi_accessible_role_set(VIEW(it), ELM_ATSPI_ROLE_PAGE_TAB);
-   elm_interface_atspi_accessible_name_set(VIEW(it), (char*)title_label);
evas_object_smart_member_add(VIEW(it), obj);
 
if (!elm_widget_sub_object_add(obj, VIEW(it)))
@@ -1986,6 +1986,15 @@ _elm_naviframe_item_pop_cb_set(Eo *eo_item EINA_UNUSED,
nit->pop_data = data;
 }
 
+EOLIAN static Eina_List*
+_elm_naviframe_item_elm_interface_atspi_accessible_children_get(Eo *eo_item 
EINA_UNUSED, Elm_Naviframe_Item_Data *nit)
+{
+   Eina_List *ret = NULL;
+
+   ret = eina_list_append(ret, VIEW(nit));
+   return ret;
+}
+
 EOLIAN static void
 _elm_naviframe_prev_btn_auto_pushed_set(Eo *obj EINA_UNUSED, 
Elm_Naviframe_Data *sd, Eina_Bool auto_pushed)
 {
diff --git a/src/lib/elementary/elm_naviframe_item.eo 
b/src/lib/elementary/elm_naviframe_item.eo
index 2545e29..4f3ae44 100644
--- a/src/lib/elementary/elm_naviframe_item.eo
+++ b/src/lib/elementary/elm_naviframe_item.eo
@@ -84,5 +84,6 @@ class Elm.Naviframe.Item(Elm.Widget.Item)
 Elm.Widget.Item.part_content.get;
 Elm.Widget.Item.part_content.set;
 Elm.Widget.Item.part_content_unset;
+Elm.Interface.Atspi_Accessible.children.get;
}
 }

-- 




[EGIT] [core/enlightenment] master 01/01: xkbswitch: rewrite the config panel to improve the gui design

2016-12-11 Thread yoz
yoz pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=15c0d460504abdbb25d4dcba9cdb3bde3c7a2b54

commit 15c0d460504abdbb25d4dcba9cdb3bde3c7a2b54
Author: Michaƫl Bouchaud (yoz) 
Date:   Mon Oct 31 11:35:24 2016 +0100

xkbswitch: rewrite the config panel to improve the gui design
---
 src/modules/xkbswitch/e_mod_config.c | 1388 ++
 src/modules/xkbswitch/e_mod_main.c   |   15 -
 src/modules/xkbswitch/e_mod_parse.c  |  148 ++--
 src/modules/xkbswitch/e_mod_parse.h  |   27 +-
 4 files changed, 1182 insertions(+), 396 deletions(-)

diff --git a/src/modules/xkbswitch/e_mod_config.c 
b/src/modules/xkbswitch/e_mod_config.c
index d615aad..e7fa898 100644
--- a/src/modules/xkbswitch/e_mod_config.c
+++ b/src/modules/xkbswitch/e_mod_config.c
@@ -10,9 +10,51 @@ struct _E_Config_Dialog_Data
Evas_Object *btn_add, *btn_del, *btn_up, *btn_down;
Ecore_Timer *fill_delay;
Ecore_Timer *dlg_fill_delay;
+   Evas_Object *popup;
+
+   Evas_Object *btn_layout;
+   Evas_Object *led_list;
+   Evas_Object *switch_list;
+   Evas_Object *ctrl_list;
+   Evas_Object *lv3_list;
+   Evas_Object *keypad_list;
+   Evas_Object *delkeypad_list;
+   Evas_Object *capslock_list;
+   Evas_Object *altwin_list;
+   Evas_Object *compose_list;
+   Evas_Object *currency_list;
+   Evas_Object *lv5_list;
+   Evas_Object *spacebar_list;
+   Evas_Object *japan_list;
+   Evas_Object *korean_list;
+   Evas_Object *esperanto_list;
+   Evas_Object *solaris_list;
+   Evas_Object *terminate_list;
+   Evas_Object *misc_list;
+
+   Evas_Object *chk_label;
 
Eina_List   *cfg_layouts;
-   Eina_List   *cfg_options;
+
+   Eina_List   *cfg_led_options;
+   Eina_List   *cfg_switch_options;
+   Eina_List   *cfg_lv3_options;
+   Eina_List   *cfg_ctrl_options;
+   Eina_List   *cfg_keypad_options;
+   Eina_List   *cfg_delkeypad_options;
+   Eina_List   *cfg_capslock_options;
+   Eina_List   *cfg_altwin_options;
+   Eina_List   *cfg_compose_options;
+   Eina_List   *cfg_currency_options;
+   Eina_List   *cfg_lv5_options;
+   Eina_List   *cfg_spacebar_options;
+   Eina_List   *cfg_japan_options;
+   Eina_List   *cfg_korean_options;
+   Eina_List   *cfg_esperanto_options;
+   Eina_List   *cfg_solaris_options;
+   Eina_List   *cfg_terminate_options;
+   Eina_List   *cfg_misc_options;
+
const char  *default_model;
 
int  only_label;
@@ -22,25 +64,46 @@ struct _E_Config_Dialog_Data
E_Config_Dialog *cfd;
 };
 
-typedef struct _E_XKB_Dialog_Option
-{
-   int enabled;
-   const char *name;
-} E_XKB_Dialog_Option;
-
 /* Local prototypes */
 
 static void*_create_data(E_Config_Dialog *cfd);
 static void _free_data(E_Config_Dialog *cfd, E_Config_Dialog_Data 
*cfdata);
 static Evas_Object *_basic_create(E_Config_Dialog *cfd, Evas *evas, 
E_Config_Dialog_Data *cfdata);
+static Evas_Object *_advanced_create(E_Config_Dialog *cfd, Evas *evas, 
E_Config_Dialog_Data *cfdata);
 static int  _basic_apply(E_Config_Dialog *cfd, E_Config_Dialog_Data 
*cfdata);
-static int  _basic_check_changed(E_Config_Dialog *cfd, 
E_Config_Dialog_Data *cfdata);
-
-static void _cb_add(void *data, void *data2 EINA_UNUSED);
-static void _cb_del(void *data, void *data2 EINA_UNUSED);
-
-static void _cb_up(void *data, void *data2 EINA_UNUSED);
-static void _cb_dn(void *data, void *data2 EINA_UNUSED);
+static int  _check_changed(E_Config_Dialog_Data *cfdata);
+
+
+static void _dont_touch_my_damn_keyboard_changed(void *data, 
Evas_Object *obj, void *event);
+static void _only_label_changed(void *data, Evas_Object *obj, void 
*event);
+
+static void _layout_clicked(void *data, Evas_Object *obj, void *event);
+static void _cb_add(void *data, Evas_Object *obj, void *event);
+static void _cb_del(void *data, Evas_Object *obj, void *event);
+
+static void _cb_up(void *data, Evas_Object *obj, void *event);
+static void _cb_dn(void *data, Evas_Object *obj, void *event);
+
+static void _cb_led_up(void *data, Evas_Object *obj, void *event);
+static void _cb_ctrl_up(void *data, Evas_Object *obj, void *event);
+static void _cb_compose_up(void *data, Evas_Object *obj, void *event);
+static void _cb_lv3_up(void *data, Evas_Object *obj, void *event);
+static void _cb_switch_up(void *data, Evas_Object *obj, void *event);
+static void _cb_keypad_up(void *data, Evas_Object *obj, void *event);
+static void _cb_delkeypad_up(void *data, Evas_Object *obj, void 
*event);
+static void _cb_capslock_up(void *data, Evas_Object *obj, void *event);
+static void _cb_altwin_up(void *data, Evas_Object *obj, void *event);
+static void _cb_currency_up(void *data, Evas_Object *obj, void *event);
+static void _cb_lv5_up(void *data, Evas_Object *obj, void *event);
+static void _cb_spacebar_up(void *data, Evas_Object

[EGIT] [core/enlightenment] v0.21.5 02/02: 21.5 NEWS Updates

2016-12-11 Thread Simon Lees
simotek pushed a commit to annotated tag v0.21.5.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=bad861979889d5ffa63747e787ba329758f754b0

commit bad861979889d5ffa63747e787ba329758f754b0
Author: Simon Lees 
Date:   Thu Dec 8 11:33:33 2016 +1030

21.5 NEWS Updates
---
 NEWS | 27 +++
 1 file changed, 27 insertions(+)

diff --git a/NEWS b/NEWS
index 9145f6b..0aed663 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,30 @@
+Release 0.21.5:
+-
+Carsten Haitzler (1):
+  e_util_defer_object_del - ensure order of deferred deletions are right
+
+Christopher Michael (1):
+  remove unused variables in e_comp_wl
+
+Derek Foreman (5):
+  Fix keyboard tracking when leaving an xdg shell window
+  Fix crash when exiting an xdg shell application
+  More aggressively prune keyboard focus list
+  Stop sending key up/down events on focus change under wayland
+  test dmabuf pixmaps properly
+
+Mike Blumenkrantz (10):
+  handle xdg-shell maximize/unmaximize calls correctly
+  stack subsurfaces above their parents upon creation
+  use more accurate determination for applying xdg-shell (un)maximize 
operations
+  do not pop pointer types on client hide events if the client is 
pass_events
+  set wl pointer surfaces to E_LAYER_CLIENT_PRIO during setup
+  attempt to re-set wl surface pointer when popping back to "default" 
pointer type
+  fix internal wl windows to exit when border X is clicked
+  use better check for getting wl surface alpha from cursor pixmaps
+  revert all sizing commits to ibar/ibox for the past year
+  maintain "empty" object's size hints when ibar/ibox resizes
+
 Release 0.21.4:
 -
 Al Poole (1):

-- 




[EGIT] [core/enlightenment] v0.21.5 01/02: 21.5 Release

2016-12-11 Thread Simon Lees
simotek pushed a commit to annotated tag v0.21.5.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=06d7531019ddf8378a886b74f41f832c496e399a

commit 06d7531019ddf8378a886b74f41f832c496e399a
Author: Simon Lees 
Date:   Thu Dec 8 11:22:18 2016 +1030

21.5 Release
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index a3a2ec6..2e9588d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,11 +2,11 @@
 ##--##--##--##--##--##--##--##--##--##--##--##--##--##--##--##--##
 m4_define([v_maj], [0])
 m4_define([v_min], [21])
-m4_define([v_mic], [4])
+m4_define([v_mic], [5])
 m4_define([v_rev], m4_esyscmd([(git rev-list --count HEAD 2>/dev/null || echo 
0) | tr -d '\n']))dnl
 ##--   When released, remove the dnl on the below line
 m4_undefine([v_rev])
-m4_define([relname], [0.21.4])
+m4_define([relname], [0.21.5])
 ##--   When doing snapshots - change soname. remove dnl on below line
 m4_define([relname], [ver-0.21])
 dnl m4_define([v_rel], [-release relname])

-- 




[EGIT] [core/enlightenment] annotated tag v0.21.5 created (now c84bdd9)

2016-12-11 Thread Enlightenment Git
This is an automated email from the git hooks/post-receive script.

simotek pushed a change to annotated tag v0.21.5
in repository core/enlightenment.

at  c84bdd9   (tag)
   tagging  bad861979889d5ffa63747e787ba329758f754b0 (commit)
  replaces  v0.21.4
 tagged by  Simon Lees
on  Fri Dec 9 11:59:31 2016 +1030

- Log -
0.21.5 Release

Carsten Haitzler (1):
  e_util_defer_object_del - ensure order of deferred deletions are right

Christopher Michael (1):
  remove unused variables in e_comp_wl

Derek Foreman (5):
  Fix keyboard tracking when leaving an xdg shell window
  Fix crash when exiting an xdg shell application
  More aggressively prune keyboard focus list
  Stop sending key up/down events on focus change under wayland
  test dmabuf pixmaps properly

Mike Blumenkrantz (10):
  handle xdg-shell maximize/unmaximize calls correctly
  stack subsurfaces above their parents upon creation
  use more accurate determination for applying xdg-shell (un)maximize 
operations
  do not pop pointer types on client hide events if the client is 
pass_events
  set wl pointer surfaces to E_LAYER_CLIENT_PRIO during setup
  attempt to re-set wl surface pointer when popping back to "default" 
pointer type
  fix internal wl windows to exit when border X is clicked
  use better check for getting wl surface alpha from cursor pixmaps
  revert all sizing commits to ibar/ibox for the past year
  maintain "empty" object's size hints when ibar/ibox resizes

Simon Lees (2):
  21.5 Release
  21.5 NEWS Updates

---

This annotated tag includes the following new commits:

   new  06d7531   21.5 Release
   new  bad8619   21.5 NEWS Updates

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 




[EGIT] [core/enlightenment] enlightenment-0.21 01/01: Merge branch 'enlightenment-0.21' of git+ssh://git.enlightenment.org/core/enlightenment into enlightenment-0.21

2016-12-11 Thread Simon Lees
simotek pushed a commit to branch enlightenment-0.21.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=caade0432ad7fab45466025435bb81ea933491bb

commit caade0432ad7fab45466025435bb81ea933491bb
Merge: bad8619 f6292eb
Author: Simon Lees 
Date:   Mon Dec 12 08:00:11 2016 +1030

Merge branch 'enlightenment-0.21' of 
git+ssh://git.enlightenment.org/core/enlightenment into enlightenment-0.21

 src/bin/efx/efx_fade.c   | 1 +
 src/bin/efx/efx_move.c   | 1 +
 src/bin/efx/efx_resize.c | 1 +
 3 files changed, 3 insertions(+)

-- 




[EGIT] [tools/edi] master 01/02: autocomplete: Add code autocomplete using clang

2016-12-11 Thread YeongJong Lee
ajwillia-ms pushed a commit to branch master.

http://git.enlightenment.org/tools/edi.git/commit/?id=ebc07e85e064027b50efa61c8469d518fc40ec00

commit ebc07e85e064027b50efa61c8469d518fc40ec00
Author: YeongJong Lee 
Date:   Mon Dec 12 00:23:22 2016 +

autocomplete: Add code autocomplete using clang

Summary:
Pressing shortcut( + ) while editing the code show
the list of suggestions.

This support variable, function, struct member.. etc.
It is simple version, so it show just function name without parameter, 
return type.

Test Plan:
1. Run edi.
2. Open project.
3. Press shortcut( + ) while editing the code.
4. Check that the list of suggestions are correct.

Reviewers: ajwillia.ms

Reviewed By: ajwillia.ms

Subscribers: bu5hm4n

Differential Revision: https://phab.enlightenment.org/D4476
---
 src/bin/editor/edi_editor.c | 259 +++-
 1 file changed, 257 insertions(+), 2 deletions(-)

diff --git a/src/bin/editor/edi_editor.c b/src/bin/editor/edi_editor.c
index 317c01d..365eb7e 100644
--- a/src/bin/editor/edi_editor.c
+++ b/src/bin/editor/edi_editor.c
@@ -26,6 +26,8 @@ typedef struct
Edi_Location end;
 } Edi_Range;
 
+static Evas_Object *_clang_autocomplete_popup_bg;
+
 void
 edi_editor_save(Edi_Editor *editor)
 {
@@ -51,8 +53,6 @@ _edi_editor_autosave_cb(void *data)
return ECORE_CALLBACK_CANCEL;
 }
 
-
-
 static void
 _changed_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info 
EINA_UNUSED)
 {
@@ -66,6 +66,252 @@ _changed_cb(void *data, Evas_Object *obj EINA_UNUSED, void 
*event_info EINA_UNUS
  editor->save_timer = ecore_timer_add(EDI_CONTENT_SAVE_TIMEOUT, 
_edi_editor_autosave_cb, editor);
 }
 
+#if HAVE_LIBCLANG
+static char*
+_edi_editor_currnet_word_get(Edi_Editor *editor)
+{
+   Elm_Code *code;
+   Elm_Code_Line *line;
+   char *ptr, *curword, *curtext;
+   unsigned int curlen, col, row, wordlen;
+
+   elm_obj_code_widget_cursor_position_get(editor->entry, &col, &row);
+
+   code = elm_code_widget_code_get(editor->entry);
+   line = elm_code_file_line_get(code->file, row);
+
+   curtext = (char *)elm_code_line_text_get(line, &curlen);
+   ptr = curtext + col - 1;
+
+   while (ptr != curtext &&
+ ((*(ptr - 1) >= 'a' && *(ptr - 1) <= 'z') ||
+  (*(ptr - 1) >= 'A' && *(ptr - 1) <= 'Z') ||
+  (*(ptr - 1) >= '0' && *(ptr - 1) <= '9') ||
+  *(ptr - 1) == '_'))
+ ptr--;
+
+   wordlen = col - (ptr - curtext) - 1;
+   curword = malloc(sizeof(char) * (wordlen + 1));
+   strncpy(curword, ptr, wordlen);
+   curword[wordlen] = '\0';
+
+   return curword;
+}
+
+static void
+_autocomplete_list_cb_key_down(void *data EINA_UNUSED, Evas *e EINA_UNUSED,
+   Evas_Object *obj, void *event_info)
+{
+   Edi_Mainview_Item *item;
+   Edi_Editor *editor;
+   Elm_Code *code;
+   Elm_Code_Line *line;
+   Evas_Event_Key_Down *ev = event_info;
+   char *word;
+   const char *list_word;
+   unsigned int wordlen, col, row;
+
+   item = edi_mainview_item_current_get();
+
+   if (!item)
+ return;
+
+   editor = (Edi_Editor *)evas_object_data_get(item->view, "editor");
+
+   elm_code_widget_cursor_position_get(editor->entry, &col, &row);
+
+   code = elm_code_widget_code_get(editor->entry);
+   line = elm_code_file_line_get(code->file, row);
+
+   if (!strcmp(ev->key, "Down") || !strcmp(ev->key, "Up"))
+ return;
+   else if (!strcmp(ev->key, "Return"))
+ {
+Elm_Object_Item *it;
+
+word = _edi_editor_currnet_word_get(editor);
+wordlen = strlen(word);
+free(word);
+
+elm_code_line_text_remove(line, col - wordlen - 1, wordlen);
+it = elm_genlist_selected_item_get(obj);
+list_word = elm_object_item_data_get(it);
+
+elm_code_line_text_insert(line, col - wordlen - 1,
+  list_word, strlen(list_word));
+elm_code_widget_cursor_position_set(editor->entry,
+  col - wordlen + strlen(list_word), row);
+ }
+
+   evas_object_del(_clang_autocomplete_popup_bg);
+}
+
+static void
+_autocomplete_list_cb_focus(void *data EINA_UNUSED,
+Evas_Object *obj EINA_UNUSED, void *event_info)
+{
+   Elm_Object_Item *it = event_info;
+   elm_genlist_item_selected_set(it, EINA_TRUE);
+}
+
+static Evas_Object *
+_autocomplete_list_content_get(void *data, Evas_Object *obj, const char *part)
+{
+   Edi_Editor *editor;
+   Edi_Mainview_Item *item;
+   Evas_Object *label;
+   char *format, *display, *auto_str = data;
+   const char *font;
+   int font_size, displen;
+
+   if (strcmp(part, "elm.swallow.content"))
+ return NULL;
+
+   item = edi_mainview_item_current_get();
+
+   if (!item)
+ return NULL;
+
+   editor = (Edi_Editor *)evas_object_data_get(item->view, "editor");
+   elm_code_widget_font_get(editor->entry, &font, &font_size);
+
+   format = " 
%s";
+   displen = strl

[EGIT] [tools/edi] master 02/02: fix typo in patch

2016-12-11 Thread Andy Williams
ajwillia-ms pushed a commit to branch master.

http://git.enlightenment.org/tools/edi.git/commit/?id=efd56cf9189b7934a4b70897a063da9e3cebe4ce

commit efd56cf9189b7934a4b70897a063da9e3cebe4ce
Author: Andy Williams 
Date:   Mon Dec 12 00:24:51 2016 +

fix typo in patch
---
 src/bin/editor/edi_editor.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/bin/editor/edi_editor.c b/src/bin/editor/edi_editor.c
index 365eb7e..aaf6b52 100644
--- a/src/bin/editor/edi_editor.c
+++ b/src/bin/editor/edi_editor.c
@@ -68,7 +68,7 @@ _changed_cb(void *data, Evas_Object *obj EINA_UNUSED, void 
*event_info EINA_UNUS
 
 #if HAVE_LIBCLANG
 static char*
-_edi_editor_currnet_word_get(Edi_Editor *editor)
+_edi_editor_current_word_get(Edi_Editor *editor)
 {
Elm_Code *code;
Elm_Code_Line *line;
@@ -129,7 +129,7 @@ _autocomplete_list_cb_key_down(void *data EINA_UNUSED, Evas 
*e EINA_UNUSED,
  {
 Elm_Object_Item *it;
 
-word = _edi_editor_currnet_word_get(editor);
+word = _edi_editor_current_word_get(editor);
 wordlen = strlen(word);
 free(word);
 
@@ -214,7 +214,7 @@ _autocomplete_list_update(Evas_Object *genlist, Edi_Editor 
*editor)
code = elm_code_widget_code_get(editor->entry);
path = elm_code_file_path_get(code->file);
 
-   curword = _edi_editor_currnet_word_get(editor);
+   curword = _edi_editor_current_word_get(editor);
 
//Genlist Item Class
Elm_Genlist_Item_Class *ic = elm_genlist_item_class_new();

-- 




Re: [E-devel] [EGIT] [core/enlightenment] enlightenment-0.21 01/01: Merge branch 'enlightenment-0.21' of git+ssh://git.enlightenment.org/core/enlightenment into enlightenment-0.21

2016-12-11 Thread Simon Lees
Sorry all, I stuffed up and forgot to push after the 0.21.5 release,

On 12/12/2016 08:01 AM, Simon Lees wrote:
> simotek pushed a commit to branch enlightenment-0.21.
> 
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=caade0432ad7fab45466025435bb81ea933491bb
> 
> commit caade0432ad7fab45466025435bb81ea933491bb
> Merge: bad8619 f6292eb
> Author: Simon Lees 
> Date:   Mon Dec 12 08:00:11 2016 +1030
> 
> Merge branch 'enlightenment-0.21' of 
> git+ssh://git.enlightenment.org/core/enlightenment into enlightenment-0.21
> 
>  src/bin/efx/efx_fade.c   | 1 +
>  src/bin/efx/efx_move.c   | 1 +
>  src/bin/efx/efx_resize.c | 1 +
>  3 files changed, 3 insertions(+)
> 

-- 

Simon Lees (Simotek)http://simotek.net

Emergency Update Team   keybase.io/simotek
SUSE LinuxAdeliade Australia, UTC+9:30
GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B



signature.asc
Description: OpenPGP digital signature
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Enlightenment Wayland bugs

2016-12-11 Thread The Rasterman
On Sun, 11 Dec 2016 12:27:10 +0300 Vasiliy Tolstov  said:

> Also in terminology windows and other e windows (settinal and other) i
> have very big mouse pointer =(

you really have to follow efl and e git for wayland.. and even then it changes
on a daily or weekly basis. wayland support is still not "prime time ready to
go" yet. it's being worked on.

> 2016-12-11 6:19 GMT+03:00 Vasiliy Tolstov :
> > Hi, I'm use latest released e and efl and try Wayland. Some issues blocks me
> > from using Wayland
> > * keyboard switching via menu key not works (menu key handled via e and
> > opens menu)
> > * sometimes windows can't be closed
> > * sometimes window duplicates and I have 3 identical windows but only one
> > can be used and react to key input.
> 
> 
> 
> -- 
> Vasiliy Tolstov,
> e-mail: v.tols...@selfip.ru
> 
> --
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/xeonphi
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Please test: devs/barbieri/ecore_con-efl_net

2016-12-11 Thread The Rasterman
On Fri, 9 Dec 2016 14:23:19 -0200 Gustavo Sverzut Barbieri 
said:

> Hi all,
> 
> I'll replace ecore_con core with efl_net, then we'll have a single
> code path, just a shim layer to keep old API compatibility.
> 
> While the new API is in GIT for a while, with gradual updates so
> ecore_ipc is already doing efl_net, as well as ecore_con_url, now is
> the time for the last bit that is Ecore_Con_Server.
> 
> While tests pass, I'd like to give you a heads up to test my branch:
> 
> https://git.enlightenment.org/core/efl.git/log/?h=devs/barbieri/ecore_con-efl_net
> 
> I'll keep rebasing it on master during today, my plan is to commit
> later tonight or early tomorrow. Let me know if breaks for you so I
> can avoid a major br0karge on master :-D

you didn't give us much notice... specially sending it on a saturday (or friday
afternoon for you) :)

i didnt have much time this weekend... :)

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [core/efl] master 01/01: efl_canvas_proxy: fix the parameter of EINA_COW_WRITE

2016-12-11 Thread Hosang Kim
jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=12c50e55229de4c086067b0564aa14e649f3b415

commit 12c50e55229de4c086067b0564aa14e649f3b415
Author: Hosang Kim 
Date:   Mon Dec 12 11:42:01 2016 +0900

efl_canvas_proxy: fix the parameter of EINA_COW_WRITE

Summary:
EINA_COW_WRITE_BEGIN and EINA_COW_WRITE_END's parameters must be same.
But 'Read' paramter is different. So wrong variable's value is changed.
@fix

Reviewers: woohyun, Hermet, cedric, raster, jpeg

Reviewed By: jpeg

Differential Revision: https://phab.enlightenment.org/D4472
---
 src/lib/evas/canvas/efl_canvas_proxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/efl_canvas_proxy.c 
b/src/lib/evas/canvas/efl_canvas_proxy.c
index aa5cfe5..2e5af8d 100644
--- a/src/lib/evas/canvas/efl_canvas_proxy.c
+++ b/src/lib/evas/canvas/efl_canvas_proxy.c
@@ -207,7 +207,7 @@ _evas_image_proxy_unset(Evas_Object *proxy, 
Evas_Object_Protected_Data *cur_prox
 EINA_COW_IMAGE_STATE_WRITE_END(o, state_write);
  }
 
-   EINA_COW_WRITE_BEGIN(evas_object_proxy_cow, cur_source->proxy, 
Evas_Object_Proxy_Data, proxy_write)
+   EINA_COW_WRITE_BEGIN(evas_object_proxy_cow, cur_proxy->proxy, 
Evas_Object_Proxy_Data, proxy_write)
  proxy_write->is_proxy = EINA_FALSE;
EINA_COW_WRITE_END(evas_object_proxy_cow, cur_proxy->proxy, proxy_write);
 }

-- 




Re: [E-devel] Enlightenment Wayland bugs

2016-12-11 Thread Simon Lees


On 12/12/2016 01:45 PM, Carsten Haitzler (The Rasterman) wrote:
> On Sun, 11 Dec 2016 12:27:10 +0300 Vasiliy Tolstov  said:
> 
>> Also in terminology windows and other e windows (settinal and other) i
>> have very big mouse pointer =(
> 
> you really have to follow efl and e git for wayland.. and even then it changes
> on a daily or weekly basis. wayland support is still not "prime time ready to
> go" yet. it's being worked on.
> 

Having said that by far the biggest percentage of bug fixes going into
stable enlightenment releases are wayland related so stuff thats found
and reported may well get fixed unless it also requires efl changes
which seem to be going through less often.

>> 2016-12-11 6:19 GMT+03:00 Vasiliy Tolstov :
>>> Hi, I'm use latest released e and efl and try Wayland. Some issues blocks me
>>> from using Wayland
>>> * keyboard switching via menu key not works (menu key handled via e and
>>> opens menu)
>>> * sometimes windows can't be closed
>>> * sometimes window duplicates and I have 3 identical windows but only one
>>> can be used and react to key input.
>>
>>
>>
>> -- 
>> Vasiliy Tolstov,
>> e-mail: v.tols...@selfip.ru


-- 

Simon Lees (Simotek)http://simotek.net

Emergency Update Team   keybase.io/simotek
SUSE LinuxAdeliade Australia, UTC+9:30
GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B



signature.asc
Description: OpenPGP digital signature
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Please test: devs/barbieri/ecore_con-efl_net

2016-12-11 Thread Gustavo Sverzut Barbieri
On Mon, Dec 12, 2016 at 1:16 AM, Carsten Haitzler  wrote:
> On Fri, 9 Dec 2016 14:23:19 -0200 Gustavo Sverzut Barbieri 
> 
> said:
>
>> Hi all,
>>
>> I'll replace ecore_con core with efl_net, then we'll have a single
>> code path, just a shim layer to keep old API compatibility.
>>
>> While the new API is in GIT for a while, with gradual updates so
>> ecore_ipc is already doing efl_net, as well as ecore_con_url, now is
>> the time for the last bit that is Ecore_Con_Server.
>>
>> While tests pass, I'd like to give you a heads up to test my branch:
>>
>> https://git.enlightenment.org/core/efl.git/log/?h=devs/barbieri/ecore_con-efl_net
>>
>> I'll keep rebasing it on master during today, my plan is to commit
>> later tonight or early tomorrow. Let me know if breaks for you so I
>> can avoid a major br0karge on master :-D
>
> you didn't give us much notice... specially sending it on a saturday (or 
> friday
> afternoon for you) :)
>
> i didnt have much time this weekend... :)

well, it landed and I'll be around to fix issues that show. The notice
was useful to get a build break on non-linux, by netstar.


-- 
Gustavo Sverzut Barbieri
--
Mobile: +55 (16) 99354-9890

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [core/efl] master 03/05: Efl_Future: class name (string) using "." for namespace.

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=47ddca0f42f1e0a9f956cc3243e89f0e43ccde5a

commit 47ddca0f42f1e0a9f956cc3243e89f0e43ccde5a
Author: Gustavo Sverzut Barbieri 
Date:   Sun Dec 11 21:28:45 2016 -0200

Efl_Future: class name (string) using "." for namespace.

Following recent eolian change, the string must have "." to split
namespace, not "_".
---
 src/lib/ecore/efl_promise.c | 2 +-
 src/lib/eo/efl_future.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/ecore/efl_promise.c b/src/lib/ecore/efl_promise.c
index 18f18da..52d2819 100644
--- a/src/lib/ecore/efl_promise.c
+++ b/src/lib/ecore/efl_promise.c
@@ -500,7 +500,7 @@ _efl_loop_future_class_initializer(Efl_Class *klass)
 
 static const Efl_Class_Description _efl_loop_future_class_desc = {
   EO_VERSION,
-  "Efl_Future",
+  "Efl.Future",
   EFL_CLASS_TYPE_REGULAR,
   sizeof (Efl_Loop_Future_Data),
   _efl_loop_future_class_initializer,
diff --git a/src/lib/eo/efl_future.c b/src/lib/eo/efl_future.c
index 3414332..aaa1d88 100644
--- a/src/lib/eo/efl_future.c
+++ b/src/lib/eo/efl_future.c
@@ -28,7 +28,7 @@ _efl_future_class_initializer(Efl_Class *klass)
 
 static const Efl_Class_Description _efl_future_class_desc = {
   EO_VERSION,
-  "Efl_Future",
+  "Efl.Future",
   EFL_CLASS_TYPE_REGULAR_NO_INSTANT,
   0,
   _efl_future_class_initializer,

-- 




[EGIT] [core/efl] master 04/05: efl_net: move error COULDNT_RESOLVE_HOST to broader scope.

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=96eccc27535e2d2a0de3dae46dbdedb5450e1174

commit 96eccc27535e2d2a0de3dae46dbdedb5450e1174
Author: Gustavo Sverzut Barbieri 
Date:   Sun Dec 11 22:17:15 2016 -0200

efl_net: move error COULDNT_RESOLVE_HOST to broader scope.

This error is shared by Dialer and Server, will also be used by IP
resolution.
---
 src/Makefile_Ecore_Con.am   |  1 +
 src/lib/ecore_con/Ecore_Con_Eo.h|  2 ++
 src/lib/ecore_con/ecore_con.c   | 20 +---
 src/lib/ecore_con/ecore_con_url_curl.c  |  2 +-
 src/lib/ecore_con/efl_net_dialer.eo |  1 -
 src/lib/ecore_con/efl_net_dialer_udp.c  |  2 +-
 src/lib/ecore_con/efl_net_dialer_unix.c |  4 ++--
 src/lib/ecore_con/efl_net_server.eo |  2 --
 src/lib/ecore_con/efl_net_server_tcp.c  |  2 +-
 src/lib/ecore_con/efl_net_server_udp.c  |  2 +-
 src/lib/ecore_con/efl_net_server_unix.c |  4 ++--
 src/lib/ecore_con/efl_net_types.eot |  3 +++
 12 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/src/Makefile_Ecore_Con.am b/src/Makefile_Ecore_Con.am
index 1fc3ea5..10285c6 100644
--- a/src/Makefile_Ecore_Con.am
+++ b/src/Makefile_Ecore_Con.am
@@ -40,6 +40,7 @@ ecore_con_eolian_files += \
 endif
 
 ecore_con_eolian_type_files = \
+   lib/ecore_con/efl_net_types.eot \
 lib/ecore_con/efl_net_http_types.eot \
lib/ecore_con/efl_net_ssl_types.eot
 
diff --git a/src/lib/ecore_con/Ecore_Con_Eo.h b/src/lib/ecore_con/Ecore_Con_Eo.h
index 76c6d30..089c88c 100644
--- a/src/lib/ecore_con/Ecore_Con_Eo.h
+++ b/src/lib/ecore_con/Ecore_Con_Eo.h
@@ -1,3 +1,5 @@
+#include "efl_net_types.eot.h"
+
 #include "efl_net_socket.eo.h"
 #include "efl_net_dialer.eo.h"
 #include "efl_net_server.eo.h"
diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c
index d603eae..7aaeb35 100644
--- a/src/lib/ecore_con/ecore_con.c
+++ b/src/lib/ecore_con/ecore_con.c
@@ -56,13 +56,12 @@ int sd_fd_index = 0;
 int sd_fd_max = 0;
 #endif
 
+EWAPI Eina_Error EFL_NET_ERROR_COULDNT_RESOLVE_HOST = 0;
+
 EWAPI Eina_Error EFL_NET_DIALER_ERROR_COULDNT_CONNECT = 0;
 EWAPI Eina_Error EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_PROXY = 0;
-EWAPI Eina_Error EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_HOST = 0;
 EWAPI Eina_Error EFL_NET_DIALER_ERROR_PROXY_AUTHENTICATION_FAILED = 0;
 
-EWAPI Eina_Error EFL_NET_SERVER_ERROR_COULDNT_RESOLVE_HOST = 0;
-
 EWAPI Eina_Error EFL_NET_SOCKET_SSL_ERROR_HANDSHAKE = 0;
 EWAPI Eina_Error EFL_NET_SOCKET_SSL_ERROR_CERTIFICATE_VERIFY_FAILED = 0;
 
@@ -101,13 +100,12 @@ ecore_con_init(void)
ecore_con_mempool_init();
ecore_con_legacy_init();
 
+   EFL_NET_ERROR_COULDNT_RESOLVE_HOST = 
eina_error_msg_static_register("Couldn't resolve host name");
+
EFL_NET_DIALER_ERROR_COULDNT_CONNECT = 
eina_error_msg_static_register("Couldn't connect to server");
EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_PROXY = 
eina_error_msg_static_register("Couldn't resolve proxy name");
-   EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_HOST = 
eina_error_msg_static_register("Couldn't resolve host name");
EFL_NET_DIALER_ERROR_PROXY_AUTHENTICATION_FAILED = 
eina_error_msg_static_register("Proxy authentication failed");
 
-   EFL_NET_SERVER_ERROR_COULDNT_RESOLVE_HOST = 
eina_error_msg_static_register("Couldn't resolve host name");
-
EFL_NET_SOCKET_SSL_ERROR_HANDSHAKE = eina_error_msg_static_register("Failed 
SSL handshake");
EFL_NET_SOCKET_SSL_ERROR_CERTIFICATE_VERIFY_FAILED = 
eina_error_msg_static_register("Failed to verify peer's certificate");
 
@@ -1000,7 +998,7 @@ _efl_net_ip_resolve_and_connect(const char *host, const 
char *port, int type, in
  {
 DBG("couldn't resolve host='%s', port='%s': %s",
 host, port, gai_strerror(r));
-ret = EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_HOST;
+ret = EFL_NET_ERROR_COULDNT_RESOLVE_HOST;
 *sockfd = INVALID_SOCKET;
  }
else
@@ -1218,7 +1216,7 @@ 
_efl_net_ip_connect_async_run_socks4(Efl_Net_Ip_Connect_Async_Data *d, const cha
  {
 DBG("couldn't resolve host='%s', port='%s': %s",
 host, port, gai_strerror(r));
-d->error = EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_HOST;
+d->error = EFL_NET_ERROR_COULDNT_RESOLVE_HOST;
  }
else
  {
@@ -1317,7 +1315,7 @@ 
_efl_net_ip_connect_async_run_socks4a(Efl_Net_Ip_Connect_Async_Data *d, const ch
if (r != 0)
  {
 DBG("couldn't resolve port='%s': %s", port, gai_strerror(r));
-d->error = EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_HOST;
+d->error = EFL_NET_ERROR_COULDNT_RESOLVE_HOST;
  }
else
  {
@@ -1806,7 +1804,7 @@ 
_efl_net_ip_connect_async_run_socks5(Efl_Net_Ip_Connect_Async_Data *d, const cha
  {
 DBG("couldn't resolve host='%s', port='%s': %s",
 host, port, gai_strerror(r));
-d->error = EFL_NET_DIALER_ERROR_COULDNT_RESOLVE_HOST;
+d->error = EFL_NET_ERROR_COULDNT_RESOLVE_HOST;
  }
el

[EGIT] [core/efl] master 05/05: efl_net: add Efl.Net.Ip_Address

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=633ec445b8f167339fa451350319f47a4b01900b

commit 633ec445b8f167339fa451350319f47a4b01900b
Author: Gustavo Sverzut Barbieri 
Date:   Mon Dec 12 02:23:29 2016 -0200

efl_net: add Efl.Net.Ip_Address

This is a string parser, serializer and asynchronous resolver.

It's purpose is to convert to and from the strings we use in our
dialers and servers, such as "127.0.0.1:1234" or "[::1]:1234",
properties allow to check the family, port, address bytes (slice) and
even get a struct sockaddr pointer to use with bind()/connect() in
outside code.

It will also offer some utilities present in netinet/in.h in an easy
to use way, after all IN6_IS_ADDR_LOOPBACK() works one way, while
there is no IN_LOOPBACK and comparing with INADDR_LOOPBACK will lead
to errors since it's in network order.

Last but not least, it will do asynchronous resolve of host and port
names using an internal thread and getaddrinfo(). The results are
delivered using a Future with an array of objects.
---
 src/Makefile_Ecore_Con.am  |5 +-
 src/examples/ecore/.gitignore  |1 +
 src/examples/ecore/Makefile.am |4 +
 src/examples/ecore/efl_net_ip_address_example.c|  137 +++
 src/lib/ecore_con/Ecore_Con_Eo.h   |2 +
 src/lib/ecore_con/efl_net_ip_address.c |  569 ++
 src/lib/ecore_con/efl_net_ip_address.eo|  246 +
 src/tests/ecore_con/ecore_con_suite.c  |1 +
 src/tests/ecore_con/ecore_con_suite.h  |1 +
 .../ecore_con/ecore_con_test_efl_net_ip_address.c  | 1154 
 10 files changed, 2119 insertions(+), 1 deletion(-)

diff --git a/src/Makefile_Ecore_Con.am b/src/Makefile_Ecore_Con.am
index 10285c6..3c62337 100644
--- a/src/Makefile_Ecore_Con.am
+++ b/src/Makefile_Ecore_Con.am
@@ -27,6 +27,7 @@ ecore_con_eolian_files = \
 lib/ecore_con/efl_net_control_technology.eo \
 lib/ecore_con/efl_net_control.eo \
 lib/ecore_con/efl_net_session.eo \
+lib/ecore_con/efl_net_ip_address.eo \
lib/ecore_con/ecore_con_eet_base.eo \
lib/ecore_con/ecore_con_eet_server_obj.eo \
lib/ecore_con/ecore_con_eet_client_obj.eo
@@ -109,7 +110,8 @@ lib/ecore_con/efl_net_socket_ssl.c \
 lib/ecore_con/efl_net_ssl_context.c \
 lib/ecore_con/efl_net_dialer_ssl.c \
 lib/ecore_con/efl_net_server_ssl.c \
-lib/ecore_con/ecore_con_local.c
+lib/ecore_con/ecore_con_local.c \
+lib/ecore_con/efl_net_ip_address.c
 
 if EFL_NET_CONTROL_BACKEND_CONNMAN
 lib_ecore_con_libecore_con_la_SOURCES += \
@@ -179,6 +181,7 @@ tests/ecore_con/ecore_con_suite.c \
 tests/ecore_con/ecore_con_test_ecore_con.c \
 tests/ecore_con/ecore_con_test_ecore_con_url.c \
 tests/ecore_con/ecore_con_test_ecore_con_eet.c \
+tests/ecore_con/ecore_con_test_efl_net_ip_address.c \
 tests/ecore_con/ecore_con_suite.h
 
 tests_ecore_con_ecore_con_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \
diff --git a/src/examples/ecore/.gitignore b/src/examples/ecore/.gitignore
index 88fc2bd..eeaf839 100644
--- a/src/examples/ecore/.gitignore
+++ b/src/examples/ecore/.gitignore
@@ -66,5 +66,6 @@
 /*.pem
 /efl_net_session_example
 /efl_net_control_example
+/efl_net_ip_address_example
 /ecore_ipc_server_example
 /ecore_ipc_client_example
diff --git a/src/examples/ecore/Makefile.am b/src/examples/ecore/Makefile.am
index 5ac7a1d..f0f4557 100644
--- a/src/examples/ecore/Makefile.am
+++ b/src/examples/ecore/Makefile.am
@@ -97,6 +97,7 @@ efl_net_socket_ssl_dialer_example \
 efl_net_socket_ssl_server_example \
 efl_net_session_example \
 efl_net_control_example \
+efl_net_ip_address_example \
 ecore_ipc_server_example \
 ecore_ipc_client_example
 
@@ -366,6 +367,9 @@ efl_net_session_example_LDADD = $(ECORE_CON_COMMON_LDADD)
 efl_net_control_example_SOURCES = efl_net_control_example.c
 efl_net_control_example_LDADD = $(ECORE_CON_COMMON_LDADD)
 
+efl_net_ip_address_example_SOURCES = efl_net_ip_address_example.c
+efl_net_ip_address_example_LDADD = $(ECORE_CON_COMMON_LDADD)
+
 ecore_ipc_server_example_SOURCES = ecore_ipc_server_example.c
 ecore_ipc_server_example_LDADD = $(ECORE_IPC_COMMON_LDADD)
 
diff --git a/src/examples/ecore/efl_net_ip_address_example.c 
b/src/examples/ecore/efl_net_ip_address_example.c
new file mode 100644
index 000..8c817c4
--- /dev/null
+++ b/src/examples/ecore/efl_net_ip_address_example.c
@@ -0,0 +1,137 @@
+#define EFL_BETA_API_SUPPORT 1
+#define EFL_EO_API_SUPPORT 1
+#include 
+#include 
+#include 
+#include 
+#include 
+
+static int retval = EXIT_SUCCESS;
+static Eina_List *resolving = NULL;
+
+static void
+_print_ip_addr_info(const Eo *o)
+{
+   const Eina_Slice *addr;
+   const struct sockaddr *sa;
+   char buf[INET6_ADDRSTRLEN] = "?";
+   uint16_t port;
+   size_t i;
+
+   printf("INFO: %p = %s\n", o, efl_net_ip_address_string_ge

[EGIT] [core/efl] master 01/05: efl_net: spell check s/revogation/revocation/g

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e9a72ea8f4b803f4b5accee6f487652de675174e

commit e9a72ea8f4b803f4b5accee6f487652de675174e
Author: Gustavo Sverzut Barbieri 
Date:   Sat Dec 10 10:21:56 2016 -0200

efl_net: spell check s/revogation/revocation/g

Sorry, in pt_BR it's revoGar... so I did misspell :-)
---
 src/examples/ecore/efl_net_server_example.c|  4 ++--
 src/examples/ecore/efl_net_server_simple_example.c |  4 ++--
 src/examples/ecore/efl_net_socket_ssl_dialer_example.c |  8 
 src/examples/ecore/efl_net_socket_ssl_server_example.c |  8 
 src/lib/ecore_con/ecore_con_legacy.c   |  6 +++---
 src/lib/ecore_con/efl_net_dialer_http.c|  4 ++--
 src/lib/ecore_con/efl_net_dialer_http.eo   |  4 ++--
 src/lib/ecore_con/efl_net_ssl_context.c| 18 +-
 src/lib/ecore_con/efl_net_ssl_context.eo   |  6 +++---
 src/lib/ecore_con/efl_net_ssl_ctx-gnutls.c | 14 +++---
 src/lib/ecore_con/efl_net_ssl_ctx-openssl.c| 14 +++---
 11 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/src/examples/ecore/efl_net_server_example.c 
b/src/examples/ecore/efl_net_server_example.c
index c8fc088..32e7f83 100644
--- a/src/examples/ecore/efl_net_server_example.c
+++ b/src/examples/ecore/efl_net_server_example.c
@@ -533,7 +533,7 @@ static const Ecore_Getopt options = {
 ECORE_GETOPT_CHOICE('c', "ssl-cipher", "Cipher to use, defaults to 
'auto'", ciphers_strs),
 ECORE_GETOPT_APPEND(0, "ssl-certificate", "certificate path to use.", 
ECORE_GETOPT_TYPE_STR),
 ECORE_GETOPT_APPEND(0, "ssl-private-key", "private key path to use.", 
ECORE_GETOPT_TYPE_STR),
-ECORE_GETOPT_APPEND(0, "ssl-crl", "certificate revogation list to use.", 
ECORE_GETOPT_TYPE_STR),
+ECORE_GETOPT_APPEND(0, "ssl-crl", "certificate revocation list to use.", 
ECORE_GETOPT_TYPE_STR),
 ECORE_GETOPT_APPEND(0, "ssl-ca", "certificate authorities path to use.", 
ECORE_GETOPT_TYPE_STR),
 
 ECORE_GETOPT_CHOICE_METAVAR(0, NULL, "The server protocol.", "protocol",
@@ -706,7 +706,7 @@ main(int argc, char **argv)
 ssl_ctx = efl_add(EFL_NET_SSL_CONTEXT_CLASS, NULL,
   efl_net_ssl_context_certificates_set(efl_added, 
eina_list_iterator_new(certificates)),
   efl_net_ssl_context_private_keys_set(efl_added, 
eina_list_iterator_new(private_keys)),
-  
efl_net_ssl_context_certificate_revogation_lists_set(efl_added, 
eina_list_iterator_new(crls)),
+  
efl_net_ssl_context_certificate_revocation_lists_set(efl_added, 
eina_list_iterator_new(crls)),
   
efl_net_ssl_context_certificate_authorities_set(efl_added, 
eina_list_iterator_new(cas)),
   efl_net_ssl_context_setup(efl_added, cipher, 
EINA_FALSE /* a server! */));
 
diff --git a/src/examples/ecore/efl_net_server_simple_example.c 
b/src/examples/ecore/efl_net_server_simple_example.c
index a7dc2b7..d8580bf 100644
--- a/src/examples/ecore/efl_net_server_simple_example.c
+++ b/src/examples/ecore/efl_net_server_simple_example.c
@@ -328,7 +328,7 @@ static const Ecore_Getopt options = {
 ECORE_GETOPT_CHOICE('c', "ssl-cipher", "Cipher to use, defaults to 
'auto'", ciphers_strs),
 ECORE_GETOPT_APPEND(0, "ssl-certificate", "certificate path to use.", 
ECORE_GETOPT_TYPE_STR),
 ECORE_GETOPT_APPEND(0, "ssl-private-key", "private key path to use.", 
ECORE_GETOPT_TYPE_STR),
-ECORE_GETOPT_APPEND(0, "ssl-crl", "certificate revogation list to use.", 
ECORE_GETOPT_TYPE_STR),
+ECORE_GETOPT_APPEND(0, "ssl-crl", "certificate revocation list to use.", 
ECORE_GETOPT_TYPE_STR),
 ECORE_GETOPT_APPEND(0, "ssl-ca", "certificate authorities path to use.", 
ECORE_GETOPT_TYPE_STR),
 
 ECORE_GETOPT_CHOICE_METAVAR(0, NULL, "The server protocol.", "protocol",
@@ -505,7 +505,7 @@ main(int argc, char **argv)
 ssl_ctx = efl_add(EFL_NET_SSL_CONTEXT_CLASS, NULL,
   efl_net_ssl_context_certificates_set(efl_added, 
eina_list_iterator_new(certificates)),
   efl_net_ssl_context_private_keys_set(efl_added, 
eina_list_iterator_new(private_keys)),
-  
efl_net_ssl_context_certificate_revogation_lists_set(efl_added, 
eina_list_iterator_new(crls)),
+  
efl_net_ssl_context_certificate_revocation_lists_set(efl_added, 
eina_list_iterator_new(crls)),
   
efl_net_ssl_context_certificate_authorities_set(efl_added, 
eina_list_iterator_new(cas)),
   efl_net_ssl_context_setup(efl_added, cipher, 
EINA_FALSE /* a server! */));
 
diff --git a/src/examples/ecore/efl_net_socket_ssl_dialer_example.c 
b/src/examples/ecore/efl_net_socket_ssl_dialer_example.c
index 34abd16..7a06379 100644
--- a/src/examples/ecore/efl_net_soc

[EGIT] [core/efl] master 02/05: yoda-style inactivity timeout.

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=21759f713af37263e340f7c61e867d639b2b1488

commit 21759f713af37263e340f7c61e867d639b2b1488
Author: Gustavo Sverzut Barbieri 
Date:   Sun Dec 11 13:19:46 2016 -0200

yoda-style inactivity timeout.

s/inactivity_timeout/timeout_inactivity/g so it matches the EFL names
with scope first, like timeout_connect, etc.
---
 src/examples/ecore/efl_io_copier_example.c |  2 +-
 src/examples/ecore/efl_net_dialer_simple_example.c |  6 ++---
 src/examples/ecore/efl_net_server_example.c|  8 +++
 src/examples/ecore/efl_net_server_simple_example.c |  2 +-
 .../ecore/efl_net_socket_ssl_server_example.c  |  2 +-
 src/lib/ecore/efl_io_buffered_stream.c | 12 +-
 src/lib/ecore/efl_io_buffered_stream.eo|  2 +-
 src/lib/ecore/efl_io_copier.c  | 28 +++---
 src/lib/ecore/efl_io_copier.eo |  4 ++--
 src/lib/ecore_con/ecore_con_legacy.c   |  8 +++
 src/lib/ecore_con/efl_net_dialer_simple.c  | 24 +--
 src/lib/ecore_con/efl_net_dialer_simple.eo |  2 +-
 12 files changed, 50 insertions(+), 50 deletions(-)

diff --git a/src/examples/ecore/efl_io_copier_example.c 
b/src/examples/ecore/efl_io_copier_example.c
index 96457d4..4bde9a5 100644
--- a/src/examples/ecore/efl_io_copier_example.c
+++ b/src/examples/ecore/efl_io_copier_example.c
@@ -893,7 +893,7 @@ main(int argc, char **argv)
 efl_io_copier_line_delimiter_set(efl_added, 
&line_delm_slice), /* optional */
 efl_io_copier_buffer_limit_set(efl_added, buffer_limit), 
/* optional, defaults to unlimited */
 efl_io_copier_read_chunk_size_set(efl_added, 
read_chunk_size), /* optional, defaults to 4096 */
-efl_io_copier_inactivity_timeout_set(efl_added, timeout), 
/* optional, defaults to 0.0 (disabled) */
+efl_io_copier_timeout_inactivity_set(efl_added, timeout), 
/* optional, defaults to 0.0 (disabled) */
 efl_event_callback_array_add(efl_added, copier_cbs(), 
NULL) /* recommended, at least EFL_IO_COPIER_EVENT_DONE. */
 );
if (!copier)
diff --git a/src/examples/ecore/efl_net_dialer_simple_example.c 
b/src/examples/ecore/efl_net_dialer_simple_example.c
index d748e2f..9b790c8 100644
--- a/src/examples/ecore/efl_net_dialer_simple_example.c
+++ b/src/examples/ecore/efl_net_dialer_simple_example.c
@@ -288,7 +288,7 @@ main(int argc, char **argv)
char *protocol = NULL;
unsigned long buffer_limit = 0;
unsigned long read_chunk_size = 0;
-   double inactivity_timeout = 0.0;
+   double timeout_inactivity = 0.0;
double connect_timeout = 0.0;
Eina_Bool quit_option = EINA_FALSE;
Ecore_Getopt_Value values[] = {
@@ -299,7 +299,7 @@ main(int argc, char **argv)
  ECORE_GETOPT_VALUE_STR(line_delimiter_str),
  ECORE_GETOPT_VALUE_ULONG(buffer_limit),
  ECORE_GETOPT_VALUE_ULONG(read_chunk_size),
- ECORE_GETOPT_VALUE_DOUBLE(inactivity_timeout),
+ ECORE_GETOPT_VALUE_DOUBLE(timeout_inactivity),
  ECORE_GETOPT_VALUE_DOUBLE(connect_timeout),
 
  /* standard block to provide version, copyright, license and help */
@@ -379,7 +379,7 @@ main(int argc, char **argv)
 efl_io_buffered_stream_max_queue_size_input_set(efl_added, 
buffer_limit), /* optional, defaults to unlimited */
 
efl_io_buffered_stream_max_queue_size_output_set(efl_added, buffer_limit), /* 
optional, defaults to unlimited */
 efl_io_buffered_stream_read_chunk_size_set(efl_added, 
read_chunk_size), /* optional, defaults to 4096 */
-efl_io_buffered_stream_inactivity_timeout_set(efl_added, 
inactivity_timeout), /* optional, defaults to 0.0 (disabled) */
+efl_io_buffered_stream_timeout_inactivity_set(efl_added, 
timeout_inactivity), /* optional, defaults to 0.0 (disabled) */
 efl_net_dialer_timeout_dial_set(efl_added, 
connect_timeout), /* optional, defaults to 0.0 (disabled) */
 efl_event_callback_array_add(efl_added, dialer_cbs(), 
NULL));
 
diff --git a/src/examples/ecore/efl_net_server_example.c 
b/src/examples/ecore/efl_net_server_example.c
index 32e7f83..edd5408 100644
--- a/src/examples/ecore/efl_net_server_example.c
+++ b/src/examples/ecore/efl_net_server_example.c
@@ -159,7 +159,7 @@ _send_copier_done(void *data, const Efl_Event *event)
if (d->recv_copier)
  {
 /* only start the reader inactivity timeout once the sender is done */
-efl_io_copier_inactivity_timeout_set(d->recv_copier, 
efl_io_copier_inactivity_timeout_get(copier));
+efl_io_copier_timeout_inactivity_set(d->recv_copier, 
efl_io_copier_timeout_inactivity_get(copier));
  }
 
fprintf(stderr, "INFO: send copier done, check if should close %p\n", 
copier);
@@

[EGIT] [core/efl] master 02/02: efl_net_dialer_http: fix HEAD requests.

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=0073e877618f709f65ff4454c905424bce0483bc

commit 0073e877618f709f65ff4454c905424bce0483bc
Author: Gustavo Sverzut Barbieri 
Date:   Mon Dec 12 03:17:35 2016 -0200

efl_net_dialer_http: fix HEAD requests.

We do not need to keep a "only_head" flag, but we must set
CURLOPT_NOBODY instead of going the "CUSTOMREQUEST" route, otherwise
curl won't follow redirects, etc.
---
 src/lib/ecore_con/ecore_con_url.c   | 6 --
 src/lib/ecore_con/efl_net_dialer_http.c | 2 ++
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/lib/ecore_con/ecore_con_url.c 
b/src/lib/ecore_con/ecore_con_url.c
index 0792857..489f187 100644
--- a/src/lib/ecore_con/ecore_con_url.c
+++ b/src/lib/ecore_con/ecore_con_url.c
@@ -143,7 +143,6 @@ struct _Ecore_Con_Url
int status;
int write_fd;
Efl_Net_Http_Version http_version;
-   Eina_Bool only_head;
Eina_Bool ssl_verify_peer;
Eina_Bool verbose;
Eina_Bool ftp_use_epsv;
@@ -497,9 +496,6 @@ _ecore_con_url_dialer_headers_done(void *data, const 
Efl_Event *event EINA_UNUSE
 
  end:
eina_iterator_free(it);
-
-   if (url_con->only_head && ((status >= 200) && (status < 300)))
- _ecore_con_url_dialer_close(url_con);
 }
 
 EFL_CALLBACKS_ARRAY_DEFINE(ecore_con_url_dialer_cbs,
@@ -726,8 +722,6 @@ _ecore_con_url_request_prepare(Ecore_Con_Url *url_con, 
const char *method)
 
_c->curl_easy_setopt(curl_easy, CURLOPT_FTP_USE_EPSV, 
(long)url_con->ftp_use_epsv);
 
-   url_con->only_head = strcmp(method, "HEAD") == 0;
-
/* previously always set encoding to gzip,deflate */
efl_net_dialer_http_request_header_add(url_con->dialer, "Accept-Encoding", 
"gzip,deflate");
 
diff --git a/src/lib/ecore_con/efl_net_dialer_http.c 
b/src/lib/ecore_con/efl_net_dialer_http.c
index eccfdee..135051d 100644
--- a/src/lib/ecore_con/efl_net_dialer_http.c
+++ b/src/lib/ecore_con/efl_net_dialer_http.c
@@ -1879,6 +1879,8 @@ _efl_net_dialer_http_request_apply(Eo *o, 
Efl_Net_Dialer_Http_Data *pd, const ch
   r = curl_easy_setopt(pd->easy, CURLOPT_HTTPGET, 1L);
 else if (strcasecmp(method, "POST") == 0)
   r = curl_easy_setopt(pd->easy, CURLOPT_POST, 1L);
+else if (strcasecmp(method, "HEAD") == 0)
+  r = curl_easy_setopt(pd->easy, CURLOPT_NOBODY, 1L);
 else if (strcasecmp(method, "PUT") == 0)
   {
  if (primary_mode == EFL_NET_DIALER_HTTP_PRIMARY_MODE_AUTO)

-- 




[EGIT] [core/efl] master 01/02: efl_net_dialer_http: fix reference check.

2016-12-11 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=d52daf8dd7a09077409f71635bdebc803e627505

commit d52daf8dd7a09077409f71635bdebc803e627505
Author: Gustavo Sverzut Barbieri 
Date:   Mon Dec 12 03:16:07 2016 -0200

efl_net_dialer_http: fix reference check.

With the last patch to fix delete-from-curl callback it went too much,
considering it was always dead (in the test scenario it was, so it was
"right"), but broke normal cases.
---
 src/lib/ecore_con/efl_net_dialer_http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/ecore_con/efl_net_dialer_http.c 
b/src/lib/ecore_con/efl_net_dialer_http.c
index c44d629..eccfdee 100644
--- a/src/lib/ecore_con/efl_net_dialer_http.c
+++ b/src/lib/ecore_con/efl_net_dialer_http.c
@@ -818,7 +818,7 @@ _efl_net_dialer_http_curl_safe_end(Eo *o, 
Efl_Net_Dialer_Http_Data *pd, CURL *ea
int refs;
 
refs = efl_ref_get(o);
-   if (refs > 2)
+   if (refs >= 2)
  {
 pd->in_curl_callback--;
 efl_unref(o);

-- 




[EGIT] [core/efl] master 01/01: elm_spinner: Spinner internal focus logic fixed to following new focused UI concept.

2016-12-11 Thread Woochan Lee
jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1e4c44f0257a371acd1083cf750c04f7a13c8847

commit 1e4c44f0257a371acd1083cf750c04f7a13c8847
Author: Woochan Lee 
Date:   Mon Dec 12 16:46:27 2016 +0900

elm_spinner: Spinner internal focus logic fixed to following new focused UI 
concept.

Summary:
The spinner entry will be activated when user gives a focus to text button 
in new focused ui concept.

To support this, we have to change internal logic about change text button 
to entry, entry to text button.

@fix

Test Plan:
elementary_test
spinner sample.

Reviewers: woohyun, Hermet

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4475
---
 src/lib/elementary/elm_spinner.c | 59 
 1 file changed, 18 insertions(+), 41 deletions(-)

diff --git a/src/lib/elementary/elm_spinner.c b/src/lib/elementary/elm_spinner.c
index ddea278..9d3acd9 100644
--- a/src/lib/elementary/elm_spinner.c
+++ b/src/lib/elementary/elm_spinner.c
@@ -51,9 +51,9 @@ _inc_dec_button_mouse_move_cb(void *data, const Efl_Event 
*event);
 static void
 _text_button_focused_cb(void *data, const Efl_Event *event);
 static void
-_button_focused_cb(void *data, const Efl_Event *event);
-static void
 _entry_unfocused_cb(void *data, const Efl_Event *event);
+static void
+_entry_activated_cb(void *data, const Efl_Event *event);
 
 EFL_CALLBACKS_ARRAY_DEFINE(_inc_dec_button_cb,
{ EFL_UI_EVENT_CLICKED, _inc_dec_button_clicked_cb},
@@ -377,14 +377,17 @@ _entry_hide(Evas_Object *obj)
 
if (sd->button_layout)
  {
-elm_layout_signal_emit(obj, "elm,state,entry,inactive", "elm");
-evas_object_hide(sd->ent);
 elm_layout_signal_emit(obj, "elm,state,button,active", "elm");
 evas_object_show(sd->text_button);
+elm_layout_signal_emit(obj, "elm,state,entry,inactive", "elm");
+evas_object_hide(sd->ent);
  }
else
  elm_layout_signal_emit(obj, "elm,state,inactive", "elm");
 
+   if (sd->entry_visible && !evas_focus_state_get(evas_object_evas_get(obj)))
+ sd->entry_reactivate = EINA_TRUE;
+
sd->entry_visible = EINA_FALSE;
 }
 
@@ -399,6 +402,8 @@ _entry_value_apply(Evas_Object *obj)
 
if (!sd->entry_visible) return;
 
+   efl_event_callback_del
+(sd->ent, ELM_WIDGET_EVENT_UNFOCUSED, _entry_unfocused_cb, obj);
_entry_hide(obj);
str = elm_object_text_get(sd->ent);
if (!str) return;
@@ -608,14 +613,8 @@ _toggle_entry(Evas_Object *obj)
  elm_entry_markup_filter_append(sd->ent, 
_invalid_input_validity_filter, NULL);
  if (_elm_config->spinner_min_max_filter_enable)
elm_entry_markup_filter_append(sd->ent, 
_min_max_validity_filter, obj);
- if (sd->inc_button)
-   efl_event_callback_add
-  (sd->inc_button, ELM_WIDGET_EVENT_FOCUSED, 
_button_focused_cb, obj);
- if (sd->dec_button)
-   efl_event_callback_add
-  (sd->dec_button, ELM_WIDGET_EVENT_FOCUSED, 
_button_focused_cb, obj);
  efl_event_callback_add
-(sd->ent, ELM_ENTRY_EVENT_ACTIVATED, _entry_unfocused_cb, obj);
+(sd->ent, ELM_ENTRY_EVENT_ACTIVATED, _entry_activated_cb, obj);
   }
 if (!sd->button_layout)
   {
@@ -625,6 +624,10 @@ _toggle_entry(Evas_Object *obj)
  elm_widget_focus_set(sd->ent, EINA_TRUE);
  sd->entry_visible = EINA_TRUE;
   }
+
+efl_event_callback_add
+   (sd->ent, ELM_WIDGET_EVENT_UNFOCUSED, _entry_unfocused_cb, obj);
+sd->entry_visible = EINA_TRUE;
 elm_layout_signal_emit(obj, "elm,state,entry,active", "elm");
 evas_object_show(sd->ent);
  }
@@ -811,7 +814,6 @@ _inc_dec_button_clicked_cb(void *data, const Efl_Event 
*event)
sd->spin_speed = sd->inc_btn_activated ? sd->step : -sd->step;
_spin_value(data);
 
-   if (sd->entry_visible) _entry_value_apply(data);
if (_elm_config->access_mode)
  _access_increment_decrement_info_say(data, EINA_TRUE);
 }
@@ -828,9 +830,6 @@ _inc_dec_button_pressed_cb(void *data, const Efl_Event 
*event)
sd->longpress_timer = ecore_timer_add
(_elm_config->longpress_timeout,
 _val_inc_dec_start, data);
-
-   if (sd->entry_visible) _entry_value_apply(data);
-   if (sd->entry_reactivate) sd->entry_reactivate = EINA_FALSE;
 }
 
 static void
@@ -850,27 +849,19 @@ _inc_dec_button_unpressed_cb(void *data, const Efl_Event 
*event EINA_UNUSED)
 static void
 _text_button_focused_cb(void *data, const Efl_Event *event EINA_UNUSED)
 {
-   ELM_SPINNER_DATA_GET(data, sd);
-
-   sd->entry_visible = EINA_FALSE;
_toggle_entry(data);
 }
 
 static void
-_button_focused_cb(void *data, const Efl_Event *event EINA_UNUSED)
+_entry_activated_cb(void *data, const Efl_Event *event EINA_UN