[EGIT] [core/efl] master 01/01: evas: proceed glyph iterator to handle next index properly
herdsman pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=bf1c0e2657259ab6d6c7ac44408bc46429c9d1c9 commit bf1c0e2657259ab6d6c7ac44408bc46429c9d1c9 Author: Youngbok Shin Date: Mon Sep 4 10:18:05 2017 +0300 evas: proceed glyph iterator to handle next index properly Summary: When harfbuzz is enabled, _content_create_ot() function will be used for shaping. If evas_common_font_int_cache_glyph_get() failed in some reason, it never proceed gl_itr until the end. It can cause weird rendering result. Because, all of gl_itr after the failure can't have proper x_bear, y_bear and width. @fix Test Plan: N/A Reviewers: raster, cedric, herdsman, jpeg Differential Revision: https://phab.enlightenment.org/D5154 --- src/lib/evas/common/evas_text_utils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/evas/common/evas_text_utils.c b/src/lib/evas/common/evas_text_utils.c index 9223c6e50b..5c00c7fb54 100644 --- a/src/lib/evas/common/evas_text_utils.c +++ b/src/lib/evas/common/evas_text_utils.c @@ -352,7 +352,7 @@ _content_create_ot(RGBA_Font_Int *fi, const Eina_Unicode *text, evas_common_font_ot_populate_text_props(text, text_props, len, mode, lang); gl_itr = text_props->info->glyph; - for (char_index = 0 ; char_index < text_props->len ; char_index++) + for (char_index = 0 ; char_index < text_props->len ; char_index++, gl_itr++) { FT_UInt idx; RGBA_Font_Glyph *fg; @@ -406,7 +406,6 @@ _content_create_ot(RGBA_Font_Int *fi, const Eina_Unicode *text, gl_itr->pen_after += adjust_x; fi = text_props->font_instance; -gl_itr++; } } #else --
[EGIT] [core/efl] efl-1.20 01/01: evas: proceed glyph iterator to handle next index properly
herdsman pushed a commit to branch efl-1.20. http://git.enlightenment.org/core/efl.git/commit/?id=d24c0431dd474bdcfc46502f35c6c895b7fc855b commit d24c0431dd474bdcfc46502f35c6c895b7fc855b Author: Youngbok Shin Date: Mon Sep 4 10:18:05 2017 +0300 evas: proceed glyph iterator to handle next index properly Summary: When harfbuzz is enabled, _content_create_ot() function will be used for shaping. If evas_common_font_int_cache_glyph_get() failed in some reason, it never proceed gl_itr until the end. It can cause weird rendering result. Because, all of gl_itr after the failure can't have proper x_bear, y_bear and width. @fix Test Plan: N/A Reviewers: raster, cedric, herdsman, jpeg Differential Revision: https://phab.enlightenment.org/D5154 --- src/lib/evas/common/evas_text_utils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/evas/common/evas_text_utils.c b/src/lib/evas/common/evas_text_utils.c index 9223c6e50b..5c00c7fb54 100644 --- a/src/lib/evas/common/evas_text_utils.c +++ b/src/lib/evas/common/evas_text_utils.c @@ -352,7 +352,7 @@ _content_create_ot(RGBA_Font_Int *fi, const Eina_Unicode *text, evas_common_font_ot_populate_text_props(text, text_props, len, mode, lang); gl_itr = text_props->info->glyph; - for (char_index = 0 ; char_index < text_props->len ; char_index++) + for (char_index = 0 ; char_index < text_props->len ; char_index++, gl_itr++) { FT_UInt idx; RGBA_Font_Glyph *fg; @@ -406,7 +406,6 @@ _content_create_ot(RGBA_Font_Int *fi, const Eina_Unicode *text, gl_itr->pen_after += adjust_x; fi = text_props->font_instance; -gl_itr++; } } #else --
[EGIT] [core/efl] master 01/01: eina: properly track valgrind use of the mempool.
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=c9a0237770a7fb0f1d94c9f99b7cab68399a922f commit c9a0237770a7fb0f1d94c9f99b7cab68399a922f Author: Cedric Bail Date: Mon Sep 4 03:08:33 2017 -0700 eina: properly track valgrind use of the mempool. T5966 --- .../eina/mp/chained_pool/eina_chained_mempool.c| 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/modules/eina/mp/chained_pool/eina_chained_mempool.c b/src/modules/eina/mp/chained_pool/eina_chained_mempool.c index ec24b3a69f..5913f87d76 100644 --- a/src/modules/eina/mp/chained_pool/eina_chained_mempool.c +++ b/src/modules/eina/mp/chained_pool/eina_chained_mempool.c @@ -378,6 +378,9 @@ eina_chained_mempool_from(void *data, void *ptr) Eina_Rbtree *r; Chained_Pool *p; Eina_Trash *t; +#ifndef NVALGRIND + Eina_Trash *last; +#endif void *pmem; Eina_Bool ret = EINA_FALSE; @@ -420,8 +423,19 @@ eina_chained_mempool_from(void *data, void *ptr) } // Check if the pointer was freed - for (t = p->base; t != NULL; t = t->next) - if (t == ptr) goto end; + for (t = p->base, last = NULL; t != NULL; t = t->next) + { +#ifndef NVALGRIND +VALGRIND_MAKE_MEM_DEFINED(t, pool->item_alloc); +if (last) VALGRIND_MAKE_MEM_NOACCESS(last, pool->item_alloc); +last = t; +#endif + +if (t == ptr) goto end; + } +#ifndef NVALGRIND + if (last) VALGRIND_MAKE_MEM_NOACCESS(last, pool->item_alloc); +#endif // Seems like we have a valid pointer actually ret = EINA_TRUE; --
Re: [E-devel] ANN: new Future/Promise implementation (in Eina)
Hi all, This was merged in GIT master with Efl.Io and Efl.Net converted to use it. If you were using the old Efl_Future, please convert to Eina_Future as that one will be removed soon. On Fri, Aug 25, 2017 at 11:09 PM, Gustavo Sverzut Barbieri wrote: > Hi all, > > As some may have followed at IRC, ProFUSION embedded systems dedicate > some effort to make a new, simpler, leaner and easier Future and > Promise implementation. > > If you're new to Promise and Future, want to know what problems it > solve and how our design looks, please read > https://phab.enlightenment.org/w/future_promise/ (which I just > updated, then if you read it before, do it again). > > Our engineer, Guilherme Iscaro, worked for weeks and more than 10 > interactions to deliver the code at > https://phab.enlightenment.org/D5131, which I kindly ask for you to > review and test. I plan to merge this on Monday night if nothing big > shows. > > What makes us happy is that the core is very lean on memory and > simple. So easy that it could be moved to Eina, solving the old > implementation issue where promise was implemented in one library > while Future was in another -- They also involved Eo, which is way > heavier than our new implementation which is only 16 bytes per Promise > and 28 bytes per Future (32bits). > > With some macros with could deliver some syntax sugar to eliminate > functions with half dozen "NULL" pointers. Even better one can also > provide "named" parameters using the structure members. > > Previously ignored and now handled is the type of the result. Before > the function would get a pointer to the value and would need to know > how to interpret it, trusting it's the expected type and how to > release the memory was mostly undefined, particularly with chaining > and conversion. > > Eina_Value is used to carry type information with the actual value, > providing many benefits: > - runtime type checking > - provides information how to release memory (eina_value_flush) > - provides information how to copy memory (eina_value_copy) > - provides conversion to other types, like to string (eina_value_to_string) > - extensible, one can provide new Eina_Value_Type in their own code/library > - can be passed on the stack and returned as value, avoid memory > allocations and programming errors. > > There is a drawback: it's recommended to always check value.type prior > to use eina_value_get(), some utilities are provided to help with > basic types. C++ should provide some templates to help with such > mundane tasks. In C11 we could use _Generic() to provide something > similar. > > This email is already long enough, please check the Wiki for > motivation, details and examples. > https://phab.enlightenment.org/w/future_promise/ > > Please review the code before Monday night, when I plan to merge this. > https://phab.enlightenment.org/D5131 > > Cheers, > > -- > Gustavo Sverzut Barbieri > -- > Mobile: +55 (16) 99354-9890 -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: ecore: fix return value
jayji pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=660e76a562257fa953ce537444fac704b44f8577 commit 660e76a562257fa953ce537444fac704b44f8577 Author: Jean Guyomarc'h Date: Mon Sep 4 19:59:20 2017 +0200 ecore: fix return value --- src/lib/ecore/ecore_poller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore/ecore_poller.c b/src/lib/ecore/ecore_poller.c index b46f0dfcaf..2b6344e9a1 100644 --- a/src/lib/ecore/ecore_poller.c +++ b/src/lib/ecore/ecore_poller.c @@ -248,7 +248,7 @@ ecore_poller_add(Ecore_Poller_Type type EINA_UNUSED, if (EINA_UNLIKELY(!eina_main_loop_is())) { -EINA_MAIN_LOOP_CHECK_RETURN; +EINA_MAIN_LOOP_CHECK_RETURN_VAL(NULL); } if (!func) --
Re: [E-devel] meson vs autotools in enlightenment
On Sun, 3 Sep 2017 18:03:41 +0900 Carsten Haitzler (The Rasterman) wrote: > you always have to first configure the project with meson for this to work. > i.e. > > meson . build On a fresh checkout of enlightenment i got a : Meson encountered an error in file meson.build, line 211, column 4: Native dependency 'systemd' not found I do not have systemd on my box. Commenting it out in the meson.build file is not an option to me. regards palla -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Can't ssh to download.e.org
On 17-09-03 17:14, Jonathan Aquilina wrote: > Will have to defer this to Stefan or raster as I am not sure about release > procedures > > Sent from my iPhone > > > On 03 Sep 2017, at 15:55, Boris Faure wrote: > > > >> On 17-09-02 18:11, Jonathan Aquilina wrote: > >> Hi Boris, > >> > >> We have moved the vm's to a different server. I am not sure the URL of > >> the server though. > > > > Is there something you can do or should I use my own server for that > > release? > > -- > > Boris Faure > > Pointer Arithmetician > I can ssh to download.enlightenment.org from the outside but not from the inside. It's not where https://download.enlightenment.org/ is hosted :( -- Boris Faure Pointer Arithmetician signature.asc Description: Digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [tools/edi] master 01/01: build: Add support for tracking build process exit code and add notification.
netstar pushed a commit to branch master. http://git.enlightenment.org/tools/edi.git/commit/?id=5aba714f90e29e2a2702836fd49c2b04f2d4fea0 commit 5aba714f90e29e2a2702836fd49c2b04f2d4fea0 Author: Al Poole Date: Mon Sep 4 20:52:34 2017 +0100 build: Add support for tracking build process exit code and add notification. This patch adds tracking of the build process's status code. This allows us to respond to the build process within the program much easier. Also added a simple API for desktop notification of the build process and its exit code which is useful and pretty. --- src/bin/edi_build_main.c| 2 +- src/bin/edi_main.c | 23 +-- src/bin/screens/edi_screens.c | 16 src/bin/screens/edi_screens.h | 10 ++ src/lib/edi_build_provider.h| 2 +- src/lib/edi_build_provider_cargo.c | 6 -- src/lib/edi_build_provider_cmake.c | 8 +++- src/lib/edi_build_provider_make.c | 31 +++ src/lib/edi_build_provider_meson.c | 14 ++ src/lib/edi_build_provider_python.c | 6 -- src/lib/edi_builder.c | 6 +++--- src/lib/edi_builder.h | 4 +++- 12 files changed, 87 insertions(+), 41 deletions(-) diff --git a/src/bin/edi_build_main.c b/src/bin/edi_build_main.c index 6ca1a35..0eca57e 100644 --- a/src/bin/edi_build_main.c +++ b/src/bin/edi_build_main.c @@ -196,7 +196,7 @@ main(int argc, char **argv) if ( ((ret = _edi_build_action_try(provider, provider->clean, "clean", build_type)) == EXIT_NOACTION) && ((ret = _edi_build_action_try(provider, provider->test, "test", build_type)) == EXIT_NOACTION) && - ((ret = _edi_build_action_try(provider, provider->build, "build", build_type)) == EXIT_NOACTION)) + ((ret = _edi_build_action_try(provider, (void *)provider->build, "build", build_type)) == EXIT_NOACTION)) { fprintf(stderr, "Unrecognized build type - try build, clean, create or test.\n"); goto end; diff --git a/src/bin/edi_main.c b/src/bin/edi_main.c index 2acfa65..c5b0d8b 100644 --- a/src/bin/edi_main.c +++ b/src/bin/edi_main.c @@ -701,10 +701,29 @@ _edi_launcher_run(Edi_Project_Config_Launch *launch) } static void +_edi_build_project(void) +{ + Eina_Strbuf *message; + int status; + + message = eina_strbuf_new(); + + status = edi_builder_build(); + if (status != 0) + eina_strbuf_append_printf(message, "Build of project %s in %s failed with status code %d.", edi_project_name_get(), edi_project_get(), status); + else + eina_strbuf_append_printf(message, "Build of project %s in %s was successful.", edi_project_name_get(), edi_project_get()); + + edi_screens_desktop_notify("EDI Project Build Status", eina_strbuf_string_get(message)); + + eina_strbuf_free(message); +} + +static void _tb_build_cb(void *data EINA_UNUSED, Evas_Object *obj, void *event_info EINA_UNUSED) { if (_edi_build_prep(obj)) - edi_builder_build(); + _edi_build_project(); } static void @@ -903,7 +922,7 @@ static void _edi_menu_build_cb(void *data EINA_UNUSED, Evas_Object *obj EINA_UNUSED, void *event_info EINA_UNUSED) { - edi_builder_build(); + _edi_build_project(); } static void diff --git a/src/bin/screens/edi_screens.c b/src/bin/screens/edi_screens.c index f0b9da0..7e625f4 100644 --- a/src/bin/screens/edi_screens.c +++ b/src/bin/screens/edi_screens.c @@ -119,3 +119,19 @@ void edi_screens_message(Evas_Object *parent, const char *title, const char *mes evas_object_show(popup); } + +void edi_screens_desktop_notify(const char *title, const char *message) +{ + Eina_Strbuf *command; + + if (!ecore_file_app_installed("notify-send")) + return; + + command = eina_strbuf_new(); + + eina_strbuf_append_printf(command, "notify-send -t 1 -i edi '%s' '%s'", title, message); + + ecore_exe_run(eina_strbuf_string_get(command), NULL); + + eina_strbuf_free(command); +} diff --git a/src/bin/screens/edi_screens.h b/src/bin/screens/edi_screens.h index bc22923..fb4906e 100644 --- a/src/bin/screens/edi_screens.h +++ b/src/bin/screens/edi_screens.h @@ -84,6 +84,16 @@ void edi_screens_message_confirm(Evas_Object *parent, const char *message, void void edi_screens_message(Evas_Object *parent, const char *title, const char *message); /** + * Send a desktop notification message to the window manager. + * + * @param title The title for the notification. + * @param message The text to be displayed in the desktop notification. + * + * @ingroup UI + */ +void edi_screens_desktop_notify(const char *title, const char *message); + +/** * @} */ diff --git a/src/lib/edi_build_provider.h b/src/lib/edi_build_provider.h index 6e68869..4fb19eb 100644 --- a/src/lib/edi_build_provider.h +++ b/src/lib/edi_build_provider.h @@ -18,7 +18,7 @@ typedef struct _Edi_Build_Provider Eina_Bool (*file_hidden_is)(const char *path);
Re: [E-devel] meson vs autotools in enlightenment
hi, i think you can do: meson -Dsystemd=false On Mon, Sep 4, 2017 at 7:39 PM, Antonio Palladini wrote: > On Sun, 3 Sep 2017 18:03:41 +0900 Carsten Haitzler (The Rasterman) > wrote: > > > you always have to first configure the project with meson for this to > work. i.e. > > > > meson . build > > On a fresh checkout of enlightenment i got a : > > > Meson encountered an error in file meson.build, line 211, column 4: > Native dependency 'systemd' not found > > I do not have systemd on my box. > Commenting it out in the meson.build file is not an option to me. > > > regards > > palla > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: eina: fix destruction of the osx semaphores
jayji pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b5e7a00681a5a86d2f31c2d1bb2b1697247d20b5 commit b5e7a00681a5a86d2f31c2d1bb2b1697247d20b5 Author: Jean Guyomarc'h Date: Tue Sep 5 00:09:57 2017 +0200 eina: fix destruction of the osx semaphores Well... that's just embarassing... semaphore_destroy() actually takes the mach task as its first parameter, not the second. This core amazingly worked very fine on macOS earlier than Sierra. Fixes T5245 --- src/lib/eina/eina_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eina/eina_lock.c b/src/lib/eina/eina_lock.c index 3423852a8d..76819367b4 100644 --- a/src/lib/eina/eina_lock.c +++ b/src/lib/eina/eina_lock.c @@ -303,7 +303,7 @@ _eina_semaphore_free(Eina_Semaphore *sem) if (sem) { #if defined(EINA_HAVE_OSX_SEMAPHORE) -return (semaphore_destroy(*sem, mach_task_self()) == KERN_SUCCESS) +return (semaphore_destroy(mach_task_self(), *sem) == KERN_SUCCESS) ? EINA_TRUE : EINA_FALSE; #else return (sem_destroy(sem) == 0) ? EINA_TRUE : EINA_FALSE; --
[EGIT] [core/efl] efl-1.20 01/02: Revert "efl: terrible kludge so avoid termination crash on osx"
jayji pushed a commit to branch efl-1.20. http://git.enlightenment.org/core/efl.git/commit/?id=04643036176b79cb58fbec4d1b44e90215c033d9 commit 04643036176b79cb58fbec4d1b44e90215c033d9 Author: Jean Guyomarc'h Date: Tue Sep 5 00:49:50 2017 +0200 Revert "efl: terrible kludge so avoid termination crash on osx" This reverts commit 9368eedd353a88dd31ba50c71433f81a2978adb5. A proper fix has been found! --- src/lib/elementary/elm_module.c | 14 -- src/lib/evas/common/evas_thread_render.c | 14 -- 2 files changed, 28 deletions(-) diff --git a/src/lib/elementary/elm_module.c b/src/lib/elementary/elm_module.c index a987c9e23c..03f70dc032 100644 --- a/src/lib/elementary/elm_module.c +++ b/src/lib/elementary/elm_module.c @@ -190,22 +190,8 @@ _elm_module_unload(Elm_Module *m) if (m->module) { if (m->shutdown_func) m->shutdown_func(m); -#if defined(__APPLE__) && defined(__MACH__) - /* -* FIXME -* -* MacOS currently undergo a fatal issue on shutdown: dlsym() -* crashes. I still have no clue why... Sue to the imminent release, -* let's NOT shutdown the module. Do nothing... -* -* THIS IS A TERRIBLE KLUDGE. IT MUST NOT STAY AFTER THE RELEASE OCCURS! -* -* FIXME -*/ -#else eina_module_unload(m->module); eina_module_free(m->module); -#endif m->module = NULL; } m->shutdown_func = NULL; diff --git a/src/lib/evas/common/evas_thread_render.c b/src/lib/evas/common/evas_thread_render.c index 2f3b291927..bbde81a657 100644 --- a/src/lib/evas/common/evas_thread_render.c +++ b/src/lib/evas/common/evas_thread_render.c @@ -261,21 +261,7 @@ evas_thread_shutdown(void) } } -#if defined(__APPLE__) && defined(__MACH__) - /* -* FIXME -* -* MacOS currently undergo a fatal issue on shutdown: pthread_join() -* crashes. I still have no clue why... Sue to the imminent release, -* let's NOT join this thread: do nothing at all! -* -* THIS IS A TERRIBLE KLUDGE. IT MUST NOT STAY AFTER THE RELEASE OCCURS! -* -* FIXME -*/ -#else eina_thread_join(evas_thread_worker); -#endif timeout_shutdown: eina_lock_free(&evas_thread_queue_lock); eina_condition_free(&evas_thread_queue_condition); --
[EGIT] [core/efl] efl-1.20 02/02: eina: fix destruction of the osx semaphores
jayji pushed a commit to branch efl-1.20. http://git.enlightenment.org/core/efl.git/commit/?id=06d752b6327132ea54762cc3e676dbb0749b43c0 commit 06d752b6327132ea54762cc3e676dbb0749b43c0 Author: Jean Guyomarc'h Date: Tue Sep 5 00:09:57 2017 +0200 eina: fix destruction of the osx semaphores Well... that's just embarassing... semaphore_destroy() actually takes the mach task as its first parameter, not the second. This core amazingly worked very fine on macOS earlier than Sierra. Fixes T5245 --- src/lib/eina/eina_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eina/eina_lock.c b/src/lib/eina/eina_lock.c index 3423852a8d..76819367b4 100644 --- a/src/lib/eina/eina_lock.c +++ b/src/lib/eina/eina_lock.c @@ -303,7 +303,7 @@ _eina_semaphore_free(Eina_Semaphore *sem) if (sem) { #if defined(EINA_HAVE_OSX_SEMAPHORE) -return (semaphore_destroy(*sem, mach_task_self()) == KERN_SUCCESS) +return (semaphore_destroy(mach_task_self(), *sem) == KERN_SUCCESS) ? EINA_TRUE : EINA_FALSE; #else return (sem_destroy(sem) == 0) ? EINA_TRUE : EINA_FALSE; --
Re: [E-devel] Can't ssh to download.e.org
Can anyone else shed light on this please Sent from my iPhone > On 04 Sep 2017, at 21:43, Boris Faure wrote: > >> On 17-09-03 17:14, Jonathan Aquilina wrote: >> Will have to defer this to Stefan or raster as I am not sure about release >> procedures >> >> Sent from my iPhone >> On 03 Sep 2017, at 15:55, Boris Faure wrote: On 17-09-02 18:11, Jonathan Aquilina wrote: Hi Boris, We have moved the vm's to a different server. I am not sure the URL of the server though. >>> >>> Is there something you can do or should I use my own server for that >>> release? >>> -- >>> Boris Faure >>> Pointer Arithmetician >> > > I can ssh to download.enlightenment.org from the outside but not from > the inside. It's not where https://download.enlightenment.org/ is > hosted :( > -- > Boris Faure > Pointer Arithmetician -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Can't ssh to download.e.org
On 05/09/17 10:47, Jonathan Aquilina wrote: > Can anyone else shed light on this please > I can't but i'm planning to do a minor release of e once its fixed. > Sent from my iPhone > >> On 04 Sep 2017, at 21:43, Boris Faure wrote: >> >>> On 17-09-03 17:14, Jonathan Aquilina wrote: >>> Will have to defer this to Stefan or raster as I am not sure about release >>> procedures >>> >>> Sent from my iPhone >>> > On 03 Sep 2017, at 15:55, Boris Faure wrote: > > On 17-09-02 18:11, Jonathan Aquilina wrote: > Hi Boris, > > We have moved the vm's to a different server. I am not sure the URL of > the server though. Is there something you can do or should I use my own server for that release? -- Boris Faure Pointer Arithmetician >>> >> >> I can ssh to download.enlightenment.org from the outside but not from >> the inside. It's not where https://download.enlightenment.org/ is >> hosted :( >> -- >> Boris Faure >> Pointer Arithmetician > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Simon Lees (Simotek)http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] meson vs autotools in enlightenment
On Mon, 4 Sep 2017 21:05:24 +0100 Al Poole wrote: > >hi, i think you can do: > > meson -Dsystemd=false > Yes, this works :) Thanks a lot. regards palla -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 03/05: textpath: remove legacy api support
thiep pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=54d1cc38a125e786311d103babd6dd366eea5656 commit 54d1cc38a125e786311d103babd6dd366eea5656 Author: Thiep Ha Date: Tue Sep 5 12:07:38 2017 +0900 textpath: remove legacy api support --- src/lib/elementary/efl_ui_textpath.c | 8 src/lib/elementary/efl_ui_textpath.eo | 2 -- 2 files changed, 10 deletions(-) diff --git a/src/lib/elementary/efl_ui_textpath.c b/src/lib/elementary/efl_ui_textpath.c index 2931995336..0ed45e8500 100644 --- a/src/lib/elementary/efl_ui_textpath.c +++ b/src/lib/elementary/efl_ui_textpath.c @@ -13,9 +13,7 @@ #define MY_CLASS EFL_UI_TEXTPATH_CLASS - #define MY_CLASS_NAME "Efl.Ui.Textpath" -#define MY_CLASS_NAME_LEGACY "elm_textpath" #define SLICE_DEFAULT_NO 99 @@ -500,12 +498,6 @@ _efl_ui_textpath_efl_canvas_group_group_add(Eo *obj, Efl_Ui_Textpath_Data *priv) efl_event_callback_add(obj, EFL_GFX_PATH_EVENT_CHANGED, _path_changed_cb, obj); } -EOLIAN static void -_efl_ui_textpath_class_constructor(Efl_Class *klass) -{ - evas_smart_legacy_type_register(MY_CLASS_NAME_LEGACY, klass); -} - EOLIAN static Efl_Object * _efl_ui_textpath_efl_object_constructor(Eo *obj, Efl_Ui_Textpath_Data *pd) { diff --git a/src/lib/elementary/efl_ui_textpath.eo b/src/lib/elementary/efl_ui_textpath.eo index a48a4bce1c..9c8faf9344 100644 --- a/src/lib/elementary/efl_ui_textpath.eo +++ b/src/lib/elementary/efl_ui_textpath.eo @@ -7,7 +7,6 @@ enum Efl.Ui.Textpath.Direction { class Efl.Ui.Textpath (Efl.Ui.Layout, Efl.Object, Efl.Text, Efl.Gfx.Path) { [[Efl Ui Textpath class]] - legacy_prefix: elm_textpath; methods { circle_set { [[Set a circle with given center, radius, and start angle.]] @@ -47,7 +46,6 @@ class Efl.Ui.Textpath (Efl.Ui.Layout, Efl.Object, Efl.Text, Efl.Gfx.Path) } } implements { - class.constructor; Efl.Object.constructor; Efl.Object.destructor; Efl.Canvas.Group.group_calculate; --
[EGIT] [core/efl] master 05/05: focus_manager: remove unused parameter warning
thiep pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=60aa0f2389019cd9f25952325c89e22ea3d8c63f commit 60aa0f2389019cd9f25952325c89e22ea3d8c63f Author: Thiep Ha Date: Tue Sep 5 14:44:21 2017 +0900 focus_manager: remove unused parameter warning --- src/lib/elementary/efl_ui_focus_manager_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/efl_ui_focus_manager_sub.c b/src/lib/elementary/efl_ui_focus_manager_sub.c index eb197bad2f..86fdcea6b2 100644 --- a/src/lib/elementary/efl_ui_focus_manager_sub.c +++ b/src/lib/elementary/efl_ui_focus_manager_sub.c @@ -36,7 +36,7 @@ _register(Efl_Ui_Focus_Manager *obj, Efl_Ui_Focus_Manager *par_m, Efl_Ui_Focus_O } static void -_unregister(Efl_Ui_Focus_Manager *obj, Efl_Ui_Focus_Manager *par_m, Efl_Ui_Focus_Object *node) +_unregister(Efl_Ui_Focus_Manager *obj EINA_UNUSED, Efl_Ui_Focus_Manager *par_m, Efl_Ui_Focus_Object *node) { efl_ui_focus_manager_calc_unregister(par_m, node); } --
[EGIT] [core/efl] master 01/05: textpath: correct data gets from path
thiep pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b55cb4feb1c35a0a6b31ac1ccbadc76432f581bc commit b55cb4feb1c35a0a6b31ac1ccbadc76432f581bc Author: Thiep Ha Date: Tue Sep 5 11:55:07 2017 +0900 textpath: correct data gets from path values of px0, py0 should be stored from previous command. --- src/lib/elementary/efl_ui_textpath.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/lib/elementary/efl_ui_textpath.c b/src/lib/elementary/efl_ui_textpath.c index eb82a45435..ec0a6a56c7 100644 --- a/src/lib/elementary/efl_ui_textpath.c +++ b/src/lib/elementary/efl_ui_textpath.c @@ -311,11 +311,10 @@ _path_data_get(Eo *obj, Efl_Ui_Textpath_Data *pd, Eina_Bool set_min) { int pos = -1; Eina_Rectangle *rect = eina_rectangle_new(0, 0, 0, 0); +double px0 = 0.0, py0 = 0.0, ctrl_x0, ctrl_y0, ctrl_x1, ctrl_y1, px1, py1; while (*cmd != EFL_GFX_PATH_COMMAND_TYPE_END) { - double px0 = 0.0, py0 = 0.0, ctrl_x0, ctrl_y0, ctrl_x1, ctrl_y1, px1, py1; - if (*cmd == EFL_GFX_PATH_COMMAND_TYPE_MOVE_TO) { pos++; @@ -327,6 +326,7 @@ _path_data_get(Eo *obj, Efl_Ui_Textpath_Data *pd, Eina_Bool set_min) { Eina_Bezier bz; double bx, by, bw, bh; + Eina_Rectangle *brect; pos++; ctrl_x0 = points[pos] + x; @@ -361,12 +361,14 @@ _path_data_get(Eo *obj, Efl_Ui_Textpath_Data *pd, Eina_Bool set_min) py0 = py1; eina_bezier_bounds_get(&bz, &bx, &by, &bw, &bh); - Eina_Rectangle *brect = eina_rectangle_new(bx, by, bw, bh); + brect = eina_rectangle_new(bx, by, bw, bh); eina_rectangle_union(rect, brect); eina_rectangle_free(brect); } else if (*cmd == EFL_GFX_PATH_COMMAND_TYPE_LINE_TO) { + Eina_Rectangle *lrect; + pos++; px1 = points[pos] + x; pos++; @@ -388,7 +390,7 @@ _path_data_get(Eo *obj, Efl_Ui_Textpath_Data *pd, Eina_Bool set_min) pd->segments = eina_inlist_append(pd->segments, EINA_INLIST_GET(seg)); pd->total_length += seg->length; - Eina_Rectangle *lrect = eina_rectangle_new(px0, py0, px1 - px0, py1 - py0); + lrect = eina_rectangle_new(px0, py0, px1 - px0, py1 - py0); eina_rectangle_union(rect, lrect); eina_rectangle_free(lrect); } --
[EGIT] [core/efl] master 04/05: textpath: correct map point number
thiep pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6a8cf155a30426f140ee4a4988828a7fbf29e69f commit 6a8cf155a30426f140ee4a4988828a7fbf29e69f Author: Thiep Ha Date: Tue Sep 5 14:19:59 2017 +0900 textpath: correct map point number The last map point is not counted if seg is too small. Test: change start angle to 3, the last segment is missed. --- src/bin/elementary/test_ui_textpath.c | 2 +- src/lib/elementary/efl_ui_textpath.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/elementary/test_ui_textpath.c b/src/bin/elementary/test_ui_textpath.c index 5860ff5a5c..88e8de4ee7 100644 --- a/src/bin/elementary/test_ui_textpath.c +++ b/src/bin/elementary/test_ui_textpath.c @@ -102,7 +102,7 @@ test_ui_textpath(void *data EINA_UNUSED, Evas_Object *obj EINA_UNUSED, void *eve efl_text_set(txtpath, "This text follows the path which you defined. This is atext designed to make it ellipsis."); efl_ui_textpath_circle_set(txtpath, CX, CY, CR, 0, EFL_UI_TEXTPATH_DIRECTION_CCW); - efl_gfx_visible_set(txtpath, EINA_TRUE); + efl_gfx_visible_set(txtpath, EINA_TRUE); path_type = 0; hbox = elm_box_add(win); diff --git a/src/lib/elementary/efl_ui_textpath.c b/src/lib/elementary/efl_ui_textpath.c index 0ed45e8500..c5ff22a5e0 100644 --- a/src/lib/elementary/efl_ui_textpath.c +++ b/src/lib/elementary/efl_ui_textpath.c @@ -213,6 +213,7 @@ _map_point_calc(Efl_Ui_Textpath_Data *pd) else if (seg->type == EFL_GFX_PATH_COMMAND_TYPE_CUBIC_TO) { int no = pd->slice_no * seg->length / (double)pd->total_length; + if (no == 0) no = 1; map_no += no; } } --
[EGIT] [core/efl] master 02/05: textpath: do not process line if failed to allocate segment
thiep pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=967e94dc6b76eac5002e662042760a0d6f76f8ef commit 967e94dc6b76eac5002e662042760a0d6f76f8ef Author: Thiep Ha Date: Tue Sep 5 12:02:01 2017 +0900 textpath: do not process line if failed to allocate segment --- src/lib/elementary/efl_ui_textpath.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elementary/efl_ui_textpath.c b/src/lib/elementary/efl_ui_textpath.c index ec0a6a56c7..2931995336 100644 --- a/src/lib/elementary/efl_ui_textpath.c +++ b/src/lib/elementary/efl_ui_textpath.c @@ -380,6 +380,7 @@ _path_data_get(Eo *obj, Efl_Ui_Textpath_Data *pd, Eina_Bool set_min) ERR("Failed to allocate segment"); px0 = px1; py0 = py1; + continue; } seg->type = EFL_GFX_PATH_COMMAND_TYPE_LINE_TO; seg->line.start.x = px0; --