Re: Proposal: Expose offsets for capturing groups in regular expression matches

2017-03-30 Thread Sebastian Zartner 
I've filed issue
https://github.com/tc39/proposal-regexp-named-groups/issues/21 to start the
discussion there.

Sebastian

On 30 March 2017 at 12:25, Daniel Ehrenberg  wrote:

> I've been trying to organize feedback to the named captures proposal in
> bugs on the repository in GitHub at https://github.com/tc39/
> proposal-regexp-named-groups/issues . I'd be happy to have your input.
> This proposal's implementation is in progress in V8.
>
> Dan
>
> On Mar 30, 2017 10:29 AM, "Sebastian Zartner" 
> wrote:
>
>> Hi, and sorry for the response delay!
>>
>> On 24 March 2017 at 01:47, Jordan Harband  wrote:
>>
>>> Adding a property to the match result is indeed tricky.
>>>
>>
>> Why? The match result already has the properties index and input
>> .
>>
>>
>>> Not sure if you're already aware that named capture groups are stage 3:
>>> https://github.com/tc39/proposal-regexp-named-groups
>>>
>>
>> Thank you for the reference! At the time I wrote my proposal (which was
>> the last time I looked), named captured groups were at stage 0. I read
>> about that proposal back then, though it doesn't allow to get the related
>> offsets, either.
>> My proposal may be changed to work together with named captured groups
>> (i.e. by adding the offsets to the groups property), though the offsets
>> should also be available when the captured groups are not named.
>>
>> On Thu, Mar 23, 2017 at 8:08 AM, T.J. Crowder <
>>> tj.crow...@farsightsoftware.com> wrote:
>>>
 Excellent idea, and nice and simple as well. I wouldn't think adding a
 property to the match result would rattle cages, it'll be interesting to
 find out.

 @eric - I prefer the proposal's approach to offsets. If you need to
 know where the end is, you can always add the length of the captured text,
 so the information is already there.

 -- T.J. Crowder

 On Thu, Mar 23, 2017 at 3:00 PM, Erik Corry 
 wrote:

> This would be great.  Can I suggest that both the start and end of
> each match should be there.  So instead of offsets you would have "starts"
> and "ends".  Alternatively, offsets should be twice as long with start-end
> pairs in it.
>

>> Initially I had an advanced approach to this
>> 
>> similar to the named captured groups proposal including start and end
>> properties for each group. Though after a discussion related to
>> String.prototype.matchAll()
>>  due to the
>> fact that the end offset can easily be calculated by the start offset and
>> the length of the captured group, I thought a simpler approach would easier
>> get traction. Also, this approach is conformant to how other languages like
>> ColdFusion solve this.
>> Having said that, I am happy to discuss different approaches to this.
>>
>> Sebastian
>>
>>
>>> On Mon, Oct 31, 2016 at 9:53 AM, Sebastian Zartner <
> sebastianzart...@gmail.com> wrote:
>
>> Hello together,
>>
>> for advanced processing of capturing groups in regular expression,
>> I'd like to propose to expose their offsets within the results of 
>> executing
>> an expression on a string.
>>
>> The complete proposal can be found at https://github.com/SebastianZ/
>> es-proposal-regexp-capturing-group-offsets.
>>
>> I'd like it to be added to the Stage 0 proposals
>> 
>> and I'm asking for feedback and a champion to help me bring it into shape
>> and get it into the standard.
>>
>> Thank you in advance,
>>
>> Sebastian
>>
>> ___
>> es-discuss mailing list
>> es-discuss@mozilla.org
>> https://mail.mozilla.org/listinfo/es-discuss
>>
>>
>
> ___
> es-discuss mailing list
> es-discuss@mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss
>
>

 ___
 es-discuss mailing list
 es-discuss@mozilla.org
 https://mail.mozilla.org/listinfo/es-discuss


>>>
>>> ___
>>> es-discuss mailing list
>>> es-discuss@mozilla.org
>>> https://mail.mozilla.org/listinfo/es-discuss
>>>
>>>
>>
___
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss

Re: Proposal: Expose offsets for capturing groups in regular expression matches

2017-03-30 Thread Sebastian Zartner 
Hi, and sorry for the response delay!

On 24 March 2017 at 01:47, Jordan Harband  wrote:

> Adding a property to the match result is indeed tricky.
>

Why? The match result already has the properties index and input
.


> Not sure if you're already aware that named capture groups are stage 3:
> https://github.com/tc39/proposal-regexp-named-groups
>

Thank you for the reference! At the time I wrote my proposal (which was the
last time I looked), named captured groups were at stage 0. I read about
that proposal back then, though it doesn't allow to get the related
offsets, either.
My proposal may be changed to work together with named captured groups
(i.e. by adding the offsets to the groups property), though the offsets
should also be available when the captured groups are not named.

On Thu, Mar 23, 2017 at 8:08 AM, T.J. Crowder  om> wrote:
>
>> Excellent idea, and nice and simple as well. I wouldn't think adding a
>> property to the match result would rattle cages, it'll be interesting to
>> find out.
>>
>> @eric - I prefer the proposal's approach to offsets. If you need to know
>> where the end is, you can always add the length of the captured text, so
>> the information is already there.
>>
>> -- T.J. Crowder
>>
>> On Thu, Mar 23, 2017 at 3:00 PM, Erik Corry  wrote:
>>
>>> This would be great.  Can I suggest that both the start and end of each
>>> match should be there.  So instead of offsets you would have "starts" and
>>> "ends".  Alternatively, offsets should be twice as long with start-end
>>> pairs in it.
>>>
>>
Initially I had an advanced approach to this

similar to the named captured groups proposal including start and end
properties for each group. Though after a discussion related to
String.prototype.matchAll()
 due to the
fact that the end offset can easily be calculated by the start offset and
the length of the captured group, I thought a simpler approach would easier
get traction. Also, this approach is conformant to how other languages like
ColdFusion solve this.
Having said that, I am happy to discuss different approaches to this.

Sebastian


> On Mon, Oct 31, 2016 at 9:53 AM, Sebastian Zartner <
>>> sebastianzart...@gmail.com> wrote:
>>>
 Hello together,

 for advanced processing of capturing groups in regular expression, I'd
 like to propose to expose their offsets within the results of executing an
 expression on a string.

 The complete proposal can be found at https://github.com/SebastianZ/
 es-proposal-regexp-capturing-group-offsets.

 I'd like it to be added to the Stage 0 proposals
 
 and I'm asking for feedback and a champion to help me bring it into shape
 and get it into the standard.

 Thank you in advance,

 Sebastian

 ___
 es-discuss mailing list
 es-discuss@mozilla.org
 https://mail.mozilla.org/listinfo/es-discuss


>>>
>>> ___
>>> es-discuss mailing list
>>> es-discuss@mozilla.org
>>> https://mail.mozilla.org/listinfo/es-discuss
>>>
>>>
>>
>> ___
>> es-discuss mailing list
>> es-discuss@mozilla.org
>> https://mail.mozilla.org/listinfo/es-discuss
>>
>>
>
> ___
> es-discuss mailing list
> es-discuss@mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss
>
>
___
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss

Re: Proposal: Expose offsets for capturing groups in regular expression matches

2017-03-23 Thread Jordan Harband 
Adding a property to the match result is indeed tricky.


Not sure if you're already aware that named capture groups are stage 3:
https://github.com/tc39/proposal-regexp-named-groups

On Thu, Mar 23, 2017 at 8:08 AM, T.J. Crowder <
tj.crow...@farsightsoftware.com> wrote:

> Excellent idea, and nice and simple as well. I wouldn't think adding a
> property to the match result would rattle cages, it'll be interesting to
> find out.
>
> @eric - I prefer the proposal's approach to offsets. If you need to know
> where the end is, you can always add the length of the captured text, so
> the information is already there.
>
> -- T.J. Crowder
>
> On Thu, Mar 23, 2017 at 3:00 PM, Erik Corry  wrote:
>
>> This would be great.  Can I suggest that both the start and end of each
>> match should be there.  So instead of offsets you would have "starts" and
>> "ends".  Alternatively, offsets should be twice as long with start-end
>> pairs in it.
>>
>> On Mon, Oct 31, 2016 at 9:53 AM, Sebastian Zartner <
>> sebastianzart...@gmail.com> wrote:
>>
>>> Hello together,
>>>
>>> for advanced processing of capturing groups in regular expression, I'd
>>> like to propose to expose their offsets within the results of executing an
>>> expression on a string.
>>>
>>> The complete proposal can be found at https://github.com/SebastianZ/
>>> es-proposal-regexp-capturing-group-offsets.
>>>
>>> I'd like it to be added to the Stage 0 proposals
>>> 
>>> and I'm asking for feedback and a champion to help me bring it into shape
>>> and get it into the standard.
>>>
>>> Thank you in advance,
>>>
>>> Sebastian
>>>
>>> ___
>>> es-discuss mailing list
>>> es-discuss@mozilla.org
>>> https://mail.mozilla.org/listinfo/es-discuss
>>>
>>>
>>
>> ___
>> es-discuss mailing list
>> es-discuss@mozilla.org
>> https://mail.mozilla.org/listinfo/es-discuss
>>
>>
>
> ___
> es-discuss mailing list
> es-discuss@mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss
>
>
___
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss

Re: Proposal: Expose offsets for capturing groups in regular expression matches

2017-03-23 Thread T.J. Crowder 
Excellent idea, and nice and simple as well. I wouldn't think adding a
property to the match result would rattle cages, it'll be interesting to
find out.

@eric - I prefer the proposal's approach to offsets. If you need to know
where the end is, you can always add the length of the captured text, so
the information is already there.

-- T.J. Crowder

On Thu, Mar 23, 2017 at 3:00 PM, Erik Corry  wrote:

> This would be great.  Can I suggest that both the start and end of each
> match should be there.  So instead of offsets you would have "starts" and
> "ends".  Alternatively, offsets should be twice as long with start-end
> pairs in it.
>
> On Mon, Oct 31, 2016 at 9:53 AM, Sebastian Zartner <
> sebastianzart...@gmail.com> wrote:
>
>> Hello together,
>>
>> for advanced processing of capturing groups in regular expression, I'd
>> like to propose to expose their offsets within the results of executing an
>> expression on a string.
>>
>> The complete proposal can be found at https://github.com/SebastianZ/
>> es-proposal-regexp-capturing-group-offsets.
>>
>> I'd like it to be added to the Stage 0 proposals
>>  and
>> I'm asking for feedback and a champion to help me bring it into shape and
>> get it into the standard.
>>
>> Thank you in advance,
>>
>> Sebastian
>>
>> ___
>> es-discuss mailing list
>> es-discuss@mozilla.org
>> https://mail.mozilla.org/listinfo/es-discuss
>>
>>
>
> ___
> es-discuss mailing list
> es-discuss@mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss
>
>
___
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss

Re: Proposal: Expose offsets for capturing groups in regular expression matches

2017-03-23 Thread Erik Corry 
This would be great.  Can I suggest that both the start and end of each
match should be there.  So instead of offsets you would have "starts" and
"ends".  Alternatively, offsets should be twice as long with start-end
pairs in it.

On Mon, Oct 31, 2016 at 9:53 AM, Sebastian Zartner <
sebastianzart...@gmail.com> wrote:

> Hello together,
>
> for advanced processing of capturing groups in regular expression, I'd
> like to propose to expose their offsets within the results of executing an
> expression on a string.
>
> The complete proposal can be found at https://github.com/SebastianZ/
> es-proposal-regexp-capturing-group-offsets.
>
> I'd like it to be added to the Stage 0 proposals
>  and
> I'm asking for feedback and a champion to help me bring it into shape and
> get it into the standard.
>
> Thank you in advance,
>
> Sebastian
>
> ___
> es-discuss mailing list
> es-discuss@mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss
>
>
___
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss