[Evolution-hackers] Re: [Apologies] Can camel-mime-utils.[ch] be made public please?
On Mon, 2005-11-28 at 13:59 +0100, Jules Colding wrote: Hi, camel-mime-utils.[ch] contains a *lot* of extremely useful utility functions for Camel providers but those functions are inaccessible for provider backends being developed outside the main tree. Other utility functions, such as those in camel-file-utils.h, are already installed so why not camel-mime-utils? Please consider making these functions public. Please accept my apologies. camel-mime-utils is already public and I have no idea why I couldn't find the file in the include install directory. Again, I am sincerely sorry for the noise :-( jules ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] camel_header_unfold()
On Mon, 2005-11-28 at 15:10 +0100, Jules Colding wrote:
*dst = *rfc822_header;
if (!dst)
break;
That should be:
*dst = *rfc822_header;
if ('\0' == *dst)
break;
--
jules
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] What do I do about missing data in the message summary?
actually, that's not true. date_sent is gotten from the MIME message headers (Date: header, fwiw). Jeff On Tue, 2005-11-22 at 14:56 +0100, Jules Colding wrote: On Tue, 2005-11-22 at 18:44 +0530, Parthasarathi Susarla wrote: On Tue, 2005-11-22 at 13:55 +0100, Jules Colding wrote: Hi, I am currently retrieving data from a MAPI object and most data is easily mapped from MAPI into corresponding Camel data types. One is missing though - the CamelMessageInfoBase.date_sent type doesn't seem to exist within the range of MAPI properties available on the object. Does the sent time exist in the message header? Do I just set the date_sent property to NULL if not?? date_sent is typically for the items in the Sent folder. Yeah you can set it to 0. OK - thanks, jules ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] About evolution-data-server/libedataser and evolution/e-utils
On Mon, 2005-11-28 at 11:23 -0500, Jeffrey Stedfast wrote: EAccount and EAccountList are private to Evolution app and should not be used inside e-d-s Would it be best to rename the e-account and e-account-list files/functions in e-d-s then, as they are used and there is obviously potential for incorrect symbol resolution? Ross -- Ross Burton mail: [EMAIL PROTECTED] jabber: [EMAIL PROTECTED] www: http://www.burtonini.com./ PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] I am confused about CamelMessageInfoBase.message_id
I believe it's the first 8 bytes of a 16-byte MD5 hash of the Message-Id (or it might be the second 8 bytes) You can check the code in camel-folder-summary.c to find out how to calculate it. Jeff On Fri, 2005-11-25 at 13:38 +0100, Jules Colding wrote: Hi, How do I populate this field? I can see in camel-nntp-utils.c:l196 that it is a strdup() of the Message-ID message header filed, but CamelSummaryMessageID is only 8 bytes big, so how can it fit in there? This can't be right, so I am certain that I am missing something in a really stupid and embarrassing way :-( Could someone please lift the clouds from my eyes? Thanks, jules ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. [EMAIL PROTECTED] - www.novell.com ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] Status of bug #255303 (was bug #55303)
This bug is really driving me nuts: http://bugzilla.gnome.org/show_bug.cgi?id=255303 The Changelog (grep for bug 55303 not 255303) implies that it's fixed or at least worked around. But I can definitely confirm that it's not - switching folders always causes the scroll position to be reset to the top of the folder. Any updates on this problem? What is the exact nature of the etable bug that Evolution claims to be working around? Lee ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] camel_header_unfold()
On Mon, 2005-11-28 at 15:10 +0100, Jules Colding wrote:
Hi,
Consider the camel_header_unfold() function:
char *
camel_header_unfold(const char *in)
{
char *out = g_malloc(strlen(in)+1);
const char *inptr = in;
char c, *o = out;
o = out;
while ((c = *inptr++)) {
if (c == '\n') {
if (camel_mime_is_lwsp(*inptr)) {
do {
inptr++;
} while (camel_mime_is_lwsp(*inptr));
*o++ = ' ';
} else {
*o++ = c;
}
} else {
*o++ = c;
}
}
*o = 0;
return out;
}
This function will skip any sequence of space (' '), tabs ('\t') and
newlines ('\n') as long as it starts with '\n'. How can that be right?
RFC 822, and RFC 2822 in particular, explicitly states that unfolding is
done by removing any CRLF ('\r' followed by '\n') that is immediately
followed by ' ' or '\t'.
I really can't see how camel_header_unfold() can unfold a message header
correctly.
I see what you are thinking, but by the time this code is run on any
input, the \r has already been stripped and you cannot, by definition,
have \n\n in a header (it terminates the header block so we don't have
to worry about that).
I suppose the following modification could be made to be more clear:
char *
camel_header_unfold(const char *in)
{
char *out = g_malloc(strlen(in)+1);
const char *inptr = in;
char c, *o = out;
o = out;
while ((c = *inptr++)) {
if (c == '\n') {
if (*inptr == ' ' || *inptr == '\t') {
do {
inptr++;
} while (*inptr == ' ' || *inptr == '\t');
*o++ = ' ';
} else {
*o++ = c;
}
} else {
*o++ = c;
}
}
*o = 0;
return out;
}
--
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
[EMAIL PROTECTED] - www.novell.com
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] About evolution-data-server/libedataser and evolution/e-utils
what uses them? On Mon, 2005-11-28 at 16:30 +, Ross Burton wrote: On Mon, 2005-11-28 at 11:23 -0500, Jeffrey Stedfast wrote: EAccount and EAccountList are private to Evolution app and should not be used inside e-d-s Would it be best to rename the e-account and e-account-list files/functions in e-d-s then, as they are used and there is obviously potential for incorrect symbol resolution? Ross -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. [EMAIL PROTECTED] - www.novell.com ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] About evolution-data-server/libedataser and evolution/e-utils
On Mon, 2005-11-28 at 12:23 -0500, Jeffrey Stedfast wrote: what uses them? From a very rough grep: ./calendar/libedata-cal/e-cal-backend-util.c ./servers/exchange/storage/exchange-account.c Ross -- Ross Burton mail: [EMAIL PROTECTED] jabber: [EMAIL PROTECTED] www: http://www.burtonini.com./ PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
