Re: [Evolution-hackers] Bug in main_system_beep?
On Fri, 2007-03-30 at 07:48 +0100, Karl Relton wrote:
Srini
Welcome to your new role.
Thanks you.
I posted this on evolution-patches a couple of
weeks back, but don't think anyone has got round to it yet ...
Whilst looking at the code for other things, I think I have spotted a
bug in main_system_beep() in mail-session.c.
You are absolutely right. It is a bug and the patch fixes it right. Just
for tracking, file a bug and attach the patch to bugzilla (Pass us the
bug id). It has to go for STABLE and trunk branches.
-Srini.
Comparing the beep function with play_sound function:
session_play_sound() and main_play_sound() do a
camel_object_ref(session) and a camel_object_unref(session) between
them.
However, session_system_beep() and main_system_beep() does the
camel_object_ref(session) but without the corresponding unref.
I assume thats wrong - the patch below fixes that by putting in the
unref.
Karl
--- mail-session.c.old 2007-03-02 11:31:23.0 +
+++ mail-session.c 2007-03-02 11:29:42.0 +
@@ -441,6 +441,7 @@ static void
main_system_beep (CamelFilterDriver *driver, gpointer user_data)
{
gdk_beep ();
+ camel_object_unref (session);
}
static void
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Proposed fix for bug 311512
On Fri, 2007-03-30 at 07:51 +0100, Karl Relton wrote:
Srini
Welcome to your new role (again!).
Last week I posted two patches (one for eds, one for evo) on evo bugzill
that I believe fix bug 311512.
--- camel-folder.h.1102007-03-20 16:57:40.0 +
+++ camel-folder.h2007-03-20 16:50:34.0 +
@@ -195,6 +195,7 @@ typedef struct {
void (*freeze)(CamelFolder *folder);
void (*thaw) (CamelFolder *folder);
gboolean (*is_frozen) (CamelFolder *folder);
+ int (*get_filter_thread) (CamelFolder *folder);
} CamelFolderClass;
On first look, I noticed that your patch has introduced an ABI break in
CamelFolderClass.
I'm sure that the mailer hackers would have a more closer look at it.
Thanks for your friendly poke :-)
-Srini.
f
Could you take a look - any comments are welcome!
Regards
Karl
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Evolution Maintainership
On Thu, 2007-03-29 at 15:15 +0530, Harish Krishnaswamy wrote: Hi friends, This mail is to announce that Srinivasa Ragavan (srag) is joining me to assume the responsibilites as maintainer of the Evolution project. Most of you already know Srini (as he is fondly referred to by the Evo folks) - having interacted with him on IRC, mail or in person during GUADEC 2006. He is one of our best and most energetic hackers. A few of his notable contributions include the Evolution Attachment Bar, the Vertical View for mails, integrating Evolution with the GNOME keyring and the GNOME VFS backend etc. He has also been prolific in building the student community in India as part of the Novell Open Source Internship Program and has mentored students on the Global search, Cairo integration, migration to gtk-print etc. He is also looking after the addressbook module in Evolution and GtkHTML and has been handling the release management partly during the last development series. Thanks Harish for this opportunity. I will do my very best to make Evolution a better enterprise quality groupware client. Srini is already busy seeding the Planning page for Evolution Two Twelve. Please join the discussions at http://www.go-evolution.org/Evo2.12. I welcome your suggestions. Please feel free to add your thoughts to the page. Cheers, Srini. ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
