Re: [ofa-general] Re: [ewg] New features for OFED 1.4

[Johann George]

Tziporet, 

> So we should assess how close we are to that goal and how we can put
> OFED out of business.

Could you cover this topic during your session on "OFED 1.3: Procedure
and Review"?  It seems that this would be the right place to bring it
up and we can attempt to extend your session to allow for it.

Johann

On Tue, Nov 06, 2007 at 01:36:08PM -0800, Roland Dreier wrote:
> I would suggest trying to figure out how to make OFED 1.4 the last
> OFED release.  OFED was originally supposed to be a short-term
> distribution until mainstream Linux distributions caught up and were
> able to distribute IB/iWARP support.  So we should assess how close we
> are to that goal and how we can put OFED out of business.
> 
>  - R.
> ___
> general mailing list
> [EMAIL PROTECTED]
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Johann George]

> I think Roland will not be on the 2nd day (Friday)
> Maybe we need to switch this session to Thursday - Johann is this possible?

Are you referring to the IPoIB Stateless Offloads session?  Yes.  I
can move that to Thursday.

Johann
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ofa-general] Re: [ewg] New features for OFED 1.4

[Or Gerlitz]

Roland Dreier wrote:

I would suggest trying to figure out how to make OFED 1.4 the last
OFED release.  OFED was originally supposed to be a short-term
distribution until mainstream Linux distributions caught up and were
able to distribute IB/iWARP support.  So we should assess how close we
are to that goal and how we can put OFED out of business.


I suggest putting this in a separate agenda item to be discussed in the 
first day (eg following the distribution people feedback and OFED 1.3 
update by Tziporet).


Johann - this can't be put aside under the excuse of no time. If needed, 
I suggest to carve 5 minutes from each session, etc.


Or.



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] RE: dmesg spammed by a print from the XRC patches

[Jack Morgenstein]

Was fixed on Oct 31. 

> -Original Message-
> From: Or Gerlitz [mailto:[EMAIL PROTECTED] 
> Sent: Thursday, November 01, 2007 9:28 AM
> To: Jack Morgenstein
> Cc: ewg@lists.openfabrics.org
> Subject: dmesg spammed by a print from the XRC patches
> 
> Hi Jack,
> 
> With OFED 1.3, the printk below in core/verbs.c is present in
> my dmesg each time a qp is destroyed, can you please remove it?
> 
> Or.
> 
>   if (qp_type == IB_QPT_XRC)
>   atomic_dec(&xrcd->usecnt);
>   else
>   printk("ib_destroy_qp: type = %d, xrcd = %p\n", 
> qp_type, xrcd);
> 
> 
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] printk in ofed-1.3 ib_destroy_qp()

[Jack Morgenstein]

On Tuesday 06 November 2007 22:02, Tziporet Koren wrote:
> Steve Wise wrote:
> > Should this printk be here?
> >
> >>
> >> else
> >> printk("ib_destroy_qp: type = %d, xrcd = 
> >> %p\n", qp_type, xrcd);
> >> }
> >>
> >> return ret;
> >> }
> I think Jack already fixed this (there was also a bug about it)
> 
> Jack?
> 
> Tziporet
> 

Fixed on Oct 31.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [GIT PULL] ofed-1.3/2.6.24 - cxgb backports

[Steve Wise]

Vlad,

Please pull from:

git://git.openfabrics.org/~swise/ofed-1.3 stevo

I've added cxgb3/iw_cxgb3 backports for:

- 2.6.12-2.6.23 kernel.org kernels
- rhel4u4
- rhel5/FC6
- sles10

I'll have more to come but this is all I could get done for today's cutoff.

If possible, I'd like a few more days to finish all the backports and do 
some more testing.



Thanks,

Steve.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

RE: [ofa-general] Re: [ewg] New features for OFED 1.4

[Kanevsky, Arkady]

sound like a topic for planery time at dev conference.

Arkady Kanevsky   email: [EMAIL PROTECTED]
Network Appliance Inc.   phone: 781-768-5395
1601 Trapelo Rd. - Suite 16.Fax: 781-895-1195
Waltham, MA 02451   central phone: 781-768-5300
 

> -Original Message-
> From: Roland Dreier [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, November 06, 2007 4:36 PM
> To: Tziporet Koren
> Cc: EWG; OpenFabrics General
> Subject: [ofa-general] Re: [ewg] New features for OFED 1.4
> 
> I would suggest trying to figure out how to make OFED 1.4 the 
> last OFED release.  OFED was originally supposed to be a 
> short-term distribution until mainstream Linux distributions 
> caught up and were able to distribute IB/iWARP support.  So 
> we should assess how close we are to that goal and how we can 
> put OFED out of business.
> 
>  - R.
> ___
> general mailing list
> [EMAIL PROTECTED]
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit 
> http://openib.org/mailman/listinfo/openib-general
> 
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] New features for OFED 1.4

[Roland Dreier]

I would suggest trying to figure out how to make OFED 1.4 the last
OFED release.  OFED was originally supposed to be a short-term
distribution until mainstream Linux distributions caught up and were
able to distribute IB/iWARP support.  So we should assess how close we
are to that goal and how we can put OFED out of business.

 - R.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Johann George]

> > I should be able to make this, but as soon as you start pushing sessions
> > before noon, time should probably be made for lunch.

Perhaps we can include a working lunch for the developers who want to
and are able to meet earlier and discuss these issues?

Johann
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] New features for OFED 1.4

[Hal Rosenstock]

On Tue, 2007-11-06 at 17:53 +0200, Tziporet Koren wrote:
> I wish to collect requirements for new features for OFED 1.4
> Please reply with any request you have (features of existing modules, 
> new modules etc.)

Xsigo will be contributing its virtual NIC and HBA host drivers for OFED
1.4.

-- Hal

> Thanks,
> Tziporet
> ___
> ewg mailing list
> ewg@lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Or Gerlitz]

On 11/6/07, Sean Hefty <[EMAIL PROTECTED]> wrote:
>
> > 11-12: SA cache session
> > 12-1: IPoIB stateless offload issues
> >
> > Sean, Roland, Dror - can you make it?
>
> I should be able to make this, but as soon as you start pushing sessions
> before noon, time should probably be made for lunch.


So what is your suggestion? with all the pushes I have tries, Johann refuses
to allocate more then 20m to the two years SA cache old open issue in the IB
stack, and said that only if we want to meet before 1PM, he might get us the
room.  So we would hear about windowz, about iwarp, about the logo program,
about dapl, about this or that protocol update etc etc and not disucss our
open issues?

Or.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] RE: [ofa-general] New features for OFED 1.4

[Sufficool, Stanley]

Integrating the SRP Target code into the stable or testing branch for
nightly testing with newer kernels & OFED releases would be a plus IMHO.

-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Tziporet
Koren
Sent: Tuesday, November 06, 2007 7:53 AM
To: EWG; OpenFabrics General
Subject: [ofa-general] New features for OFED 1.4


I wish to collect requirements for new features for OFED 1.4 Please
reply with any request you have (features of existing modules, 
new modules etc.)

Thanks,
Tziporet
___
general mailing list
[EMAIL PROTECTED]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit
http://openib.org/mailman/listinfo/openib-general
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] printk in ofed-1.3 ib_destroy_qp()

[Tziporet Koren]

Steve Wise wrote:

Should this printk be here?



else
printk("ib_destroy_qp: type = %d, xrcd = 
%p\n", qp_type, xrcd);

}

return ret;
}

I think Jack already fixed this (there was also a bug about it)

Jack?

Tziporet
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] New features for OFED 1.4

[Tziporet Koren]

Kanevsky, Arkady wrote:

Tziporet,
which Linux version is it going to be based on? 2.6.25? 26?
  

I guess 2.6.26

Tziporet
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: Toward OFED-1.3-beta release - prepare ofed_1_3 branch for every package

[Sasha Khapyorsky]

Hi Vlad,

On 03:27 Sun 28 Oct , Sasha Khapyorsky wrote:
> On 11:25 Thu 25 Oct , Vladimir Sokolovsky wrote:
> >  All maintainers of the user space package please create ofed_1_3 branch in 
> >  your git trees if this is not done yet on the OpenFabrics server.
> 
> I would prefer to keep master branch as source for OFED-1.3 for few more
> days if it is acceptable. In this period I'm not planning to put there
> things which are not desired for OFED, so this will just prevents some
> patch duplication works for me. Please let me know if it breaks your
> plans or makes it harder to maintain OFED builds.

I created ofed_1_3 branch. It is up to date now, please pull...

Sasha
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [ANNOUNCE] management tarballs release

[Sasha Khapyorsky]

Hi,

There is a new release of the management (OpenSM and infiniband
diagnostics) tarballs available in:

http://www.openfabrics.org/downloads/management/

md5sum:

e270309f2fb0f948b098f63cb1f13bfb  infiniband-diags-1.3.3.tar.gz
25b9491f90c7e851f5bafd556bcac5f6  libibcommon-1.0.6.tar.gz
0fa433e69cb04559efbc76a7157cc700  libibmad-1.1.3.tar.gz
b4297b00f3999c951f8b98df6f5e6b19  libibumad-1.1.4.tar.gz
979b05d0534b1ee5f4a2eb12576a76e7  opensm-3.1.6.tar.gz

Sasha
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] printk in ofed-1.3 ib_destroy_qp()

[Steve Wise]

Should this printk be here?


int ib_destroy_qp(struct ib_qp *qp)
{
struct ib_pd *pd;
struct ib_cq *scq, *rcq;
struct ib_srq *srq;
struct ib_xrcd *xrcd;
enum ib_qp_type qp_type = qp->qp_type;
int ret;

pd  = qp->pd;
scq = qp->send_cq;
rcq = qp->recv_cq;
srq = qp->srq;
xrcd = qp->xrcd;

ret = qp->device->destroy_qp(qp);
if (!ret) {
atomic_dec(&pd->usecnt);
atomic_dec(&scq->usecnt);
atomic_dec(&rcq->usecnt);
if (srq)
atomic_dec(&srq->usecnt);
if (qp_type == IB_QPT_XRC)
atomic_dec(&xrcd->usecnt);
else
printk("ib_destroy_qp: type = %d, xrcd = %p\n", 
qp_type, xrcd);
}

return ret;
}

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Tziporet Koren wrote:

> Erez Zilber wrote:
> >
> >
> > I wasn't able to test open-iscsi over iSER for the following distros
> > (because other patches fail):
> >
> >* RHAS4 up3 - could not apply 2.6.9_U3/core_4807_to_2_6_9.patch
> >* SLES 9 sp3 - could not apply
> > 2.6.5_sles9_sp3/core_4807_to_2_6_9.patch
> >* RHAS4 up2 - could not apply 2.6.9_U2/core_4807_to_2_6_9.patch
> >
> We do not support these OSes in OFED 1.3
>

If they are not supported, the ofed_makedist script should skip them.
Currently, it stops whenever a backport fails. It doesn't proceed beyond
SLES 9 sp3. Vlad - what do you think?

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] RE: [ofa-general] New features for OFED 1.4

[Kanevsky, Arkady]

Tziporet,
which Linux version is it going to be based on? 2.6.25? 26?

Arkady Kanevsky   email: [EMAIL PROTECTED]
Network Appliance Inc.   phone: 781-768-5395
1601 Trapelo Rd. - Suite 16.Fax: 781-895-1195
Waltham, MA 02451   central phone: 781-768-5300
 

> -Original Message-
> From: Tziporet Koren [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, November 06, 2007 10:53 AM
> To: EWG; OpenFabrics General
> Subject: [ofa-general] New features for OFED 1.4
> 
> I wish to collect requirements for new features for OFED 1.4 
> Please reply with any request you have (features of existing 
> modules, new modules etc.)
> 
> Thanks,
> Tziporet
> ___
> general mailing list
> [EMAIL PROTECTED]
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit 
> http://openib.org/mailman/listinfo/openib-general
> 
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] Feedback on Developer's Summit

[Sean Hefty]

11-12: SA cache session
12-1: IPoIB stateless offload issues

Sean, Roland, Dror - can you make it?


I should be able to make this, but as soon as you start pushing sessions 
before noon, time should probably be made for lunch.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] New features for OFED 1.4

[Tziporet Koren]

I wish to collect requirements for new features for OFED 1.4
Please reply with any request you have (features of existing modules, 
new modules etc.)


Thanks,
Tziporet
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Tziporet Koren]

Erez Zilber wrote:



I wasn't able to test open-iscsi over iSER for the following distros 
(because other patches fail):


   * RHAS4 up3 - could not apply 2.6.9_U3/core_4807_to_2_6_9.patch
   * SLES 9 sp3 - could not apply 
2.6.5_sles9_sp3/core_4807_to_2_6_9.patch

   * RHAS4 up2 - could not apply 2.6.9_U2/core_4807_to_2_6_9.patch


We do not support these OSes in OFED 1.3

Tziporet
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] OFED Nov 05 meeting summary on OFED 1.3 beta readiness

[Tziporet Koren]

Note: there will be no meeting next week - CU all in SC07
Tziporet


OFED Nov 05 meeting summary on OFED 1.3 beta readiness

1. Rebase for kernel 2.6.24-rc1:
   The backport was more complicated (mainly in IPoIB). 
   The following kernel modules have now backports to all kernels:
   mthca, mlx4, ehca, ipath, core, IPoIB, RDS

   Kernel modules that need update: Chelsio driver (cxgb3), iSER, SDP,
SRP, VNIC

   Note: Please work on this git branch:
   git://git.openfabrics.org/ofed_1_3/linux-2.6.git
ofed_kernel_2_6_24_rc1

   Schedule: 
   All new backport patches should be send to Vlad by Tuesday Nov 6. 
   On Wed (Nov 7) we will start to publish the new package based on
   kernel 2.6.24. 
   Kernel modules that will not pass compilation will be disabled  

2. Other Beta tasks status:
   1. Fix compilation problems on PPC SLES10 with 32 bits - Vlad
(Mellanox) - on work
   2. SPEC files should be part of each user space package - each owner
should take the spec file
   3. Fix all compilation and install issues - All
   4. management readiness and open a branch for 1.3 - Sasha

3. Beta schedule:
   Target: do the beta release by the end of this week 
   (Note: Since in Israel we are not working on Friday it will be done
either on Thursday or Sunday)

4. GA schedule:
   Tziporet to publish the GA schedule - after the beta release will be
done
   The schedule we had is published on the Wiki at 
 
https://wiki.openfabrics.org/tiki-index.php?page=OFED+1.3+release+plan+a
nd+features

5. Integration of OFED 1.3 with Redhat:
   Tziporet to talk to Doug in SC07


Done tasks for the beta:
   o Multiple uDAPL libs (1.0 & 2.0) - Vlad and Arlin (Intel)
   o ibutils on SLES10 PPC64 (64 bits) - Vlad
   o Add qperf test from Qlogic - Johann (Qlogic)
   o Support RHEL 5 up1 - Woody & Vlad
   o Apply patches that fix warning of backport patches - Vlad
   o New MVAPICH package - Pasha & DK (OSU)
   o Complete RDS work - Vlad (Mellanox)
   o Integrate all SDP features - Jim (Mellanox)
   o nes - updated backport patches - Glenn (NetEffect)



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

open-iscsi & iSER backport patches work ok for the following distros:

   * SLES 10
   * SLES 10 sp1
   * RHEL 5
   * RHEL 5 up1
   * RHAS4 up4
   * RHAS4 up5

I wasn't able to test open-iscsi over iSER for the following distros 
(because other patches fail):


   * RHAS4 up3 - could not apply 2.6.9_U3/core_4807_to_2_6_9.patch


FYI - Some other distros (that open-iscsi over iSER is not supported on) 
fail:


   * SLES 9 sp3 - could not apply 2.6.5_sles9_sp3/core_4807_to_2_6_9.patch
   * RHAS4 up2 - could not apply 2.6.9_U2/core_4807_to_2_6_9.patch

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Or Gerlitz]

Dror Goldenberg wrote:
a) it's an option that is turned off by default and people that are 
willing to take the risk can turn it on and get better performance
b) indeed we will need to make it work with the kernel lso, no need to 
have something specific for ipoib


Anyway, I am planning to present those things during the IPoIB SO talk. 
Wouldn't this be good enough ?


Dror,

I have missed this post of yours, sorry for asking again if you can 
explain the approach. With what you say here, it seems that discussion 
on the LRO and non-complaint-checksum-offload patches can continue over 
 the list once they are submitted to review for the upstream kernel.


If possible, I'd like to hear more details on what does the HW actually 
knows to do (eg checksum and LSO offloads - for what IB transports, UDP 
or TCP, IPv6 or IPv4 only where the IP version matters), the slides in 
Sonoma were --very-- short to describe this and reviewing the patches 
without having the complete picture is tough.


Can you shed more light (Roland, indeed its more education then debate 
on open issues) on what you called in the Sonoma slides RCA (Receive 
Core Affinity), I understand this is actually multiple EQs? I'd be happy 
to learn on the motivation and suggested SW usage.


Dror/Roland - how about a 30m session between 11:30-12 (before the SA 
cache)?


Or.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Tziporet Koren]

Dror Goldenberg wrote:

Or Gerlitz wrote:
On 11/5/07, *Roland Dreier* <[EMAIL PROTECTED] 
> wrote:


> 12-1: IPoIB stateless offload issues
 


a) it's an option that is turned off by default and people that are 
willing to take the risk can turn it on and get better performance
b) indeed we will need to make it work with the kernel lso, no need to 
have something specific for ipoib



Anyway, I am planning to present those things during the IPoIB SO 
talk. Wouldn't this be good enough ?



I think Roland will not be on the 2nd day (Friday)
Maybe we need to switch this session to Thursday - Johann is this possible?

Thanks,
Tziporet




___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Vladimir Sokolovsky]

Erez Zilber wrote:
OK. Let me know when you apply it and I will try to rerun 
ofed_makedist.sh. Just to make sure that I understand - does this fix 
allow the script to run without having quilt installed?


Erez



Done (ofed_kernel_2_6_24_rc1 branch),
Yes, you can run it without "quilt".

Regards,
Vladimir


Vladimir Sokolovsky wrote:

No, only for ofed_makedist.sh.
Ralph Campbell already sent me the patch that fix this issue. I will
apply it shortly.


Regards,
Vladimir


 

-Original Message-
From: Erez Zilber [mailto:[EMAIL PROTECTED]
Sent: Tuesday, November 06, 2007 10:21 AM
To: Vladimir Sokolovsky
Cc: OpenFabricsEWG
Subject: Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches
update required

Vladimir Sokolovsky wrote:
   

Erez,
Do you have "quilt" installed?


Regards,
Vladimir


  

No. Do I need quilt in order to build/test OFED?

Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Or Gerlitz]

Roland Dreier wrote:

As I said earlier on this thread,  the open issues I see with the stateless
offload series are (A) the non interoperable checksum offload patch based on
the IB ICRC sent by Michael (and if it is inter-operable, I'd like to be
educated how) 



For (A): as far as I'm concerned, turning off TCP/IP checksums is not
something we want to do in IPoIB.  Is there anyone arguing in favor of
it at this point?


Not that someone argues, but they just went and put the below patch in 
OFED 1.3 skipping the review process and maintainer acceptance.  So if 
Dror does not want to stand and refine the approach, eg as Jason 
suggested, maybe we can avoid discussing it at this point - Dror?


Or.



Add module option hw_csum: when set, IPoIB will report HW CSUM
and S/G support, and rely on hardware end-to-end transport
checksum (ICRC) instead of software-level protocol checksums.

Forwarding such packets outside the IB subnet would increase
the risk of data corruption, so it is safest not to set
hw_csum flag on gateways. To reduce the chance of
this routing triggering data corruption by mistake, on RX
we set skb checksum field to CHECKSUM_UNNECESSARY - this way
if such a packet ends up outside the IB network,
it is detected as malformed and dropped.

To enable interoperability with IEEE IPoIB, checksum
for outgoing packets is calculated in software
unless the remote advertises hw_csum capability
by setting a bit in hardware address flag.

Signed-off-by: Michael S. Tsirkin <[EMAIL PROTECTED]>

---

This patch has to be applied on top of
[PATCH 2/11] IB/ipoib: support for sending gather skbs.

Updates since v2: 


Enable interoperability with IEEE IPoIB.
Split out S/G support to a separate patch.

Updates since v1: fixed thinko in setting header flags.

When applied on top of previously posted mlx4 patches,
and with hw_csum enabled on both ends, this patch speeds up
single-stream netperf bandwidth on connectx DDR from 1000
to 1250 MBytes/sec.

Index: ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib.h
===
--- ofa_1_3_dev_kernel.orig/drivers/infiniband/ulp/ipoib/ipoib.h
2007-09-24 16:21:10.0 +0200
+++ ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib.h 2007-09-24 
16:21:29.0 +0200
@@ -86,6 +86,7 @@ enum {
IPOIB_MCAST_STARTED   = 8,
IPOIB_FLAG_NETIF_STOPPED  = 9,
IPOIB_FLAG_ADMIN_CM   = 10,
+   IPOIB_FLAG_HW_CSUM= 11,
 
 	IPOIB_MAX_BACKOFF_SECONDS = 16,
 
@@ -104,9 +105,11 @@ enum {
 
 /* structs */
 
+#define IPOIB_HEADER_F_HWCSUM 0x1

+
 struct ipoib_header {
__be16  proto;
-   u16 reserved;
+   __be16  flags;
 };
 
 struct ipoib_pseudoheader {
@@ -484,6 +487,8 @@ void ipoib_pkey_poll(struct work_struct 
 int ipoib_pkey_dev_delay_open(struct net_device *dev);

 void ipoib_drain_cq(struct net_device *dev);
 
+#define IPOIB_FLAGS_HWCSUM  0x01

+
 #ifdef CONFIG_INFINIBAND_IPOIB_CM
 
 #define IPOIB_FLAGS_RC  0x80

Index: ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib_cm.c
===
--- ofa_1_3_dev_kernel.orig/drivers/infiniband/ulp/ipoib/ipoib_cm.c 
2007-09-24 16:21:10.0 +0200
+++ ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib_cm.c  2007-09-24 
16:21:29.0 +0200
@@ -407,6 +407,7 @@ void ipoib_cm_handle_rx_wc(struct net_de
unsigned long flags;
u64 mapping[IPOIB_CM_RX_SG];
int frags;
+   struct ipoib_header *header;
 
 	ipoib_dbg_data(priv, "cm recv completion: id %d, status: %d\n",

   wr_id, wc->status);
@@ -469,7 +470,10 @@ void ipoib_cm_handle_rx_wc(struct net_de
 
 	skb_put_frags(skb, IPOIB_CM_HEAD_SIZE, wc->byte_len, newskb);
 
-	skb->protocol = ((struct ipoib_header *) skb->data)->proto;

+   header = (struct ipoib_header *)skb->data;
+   skb->protocol = header->proto;
+   if (header->flags & cpu_to_be16(IPOIB_HEADER_F_HWCSUM))
+   skb->ip_summed = CHECKSUM_UNNECESSARY;
skb_reset_mac_header(skb);
skb_pull(skb, IPOIB_ENCAP_LEN);
 
Index: ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib_ib.c

===
--- ofa_1_3_dev_kernel.orig/drivers/infiniband/ulp/ipoib/ipoib_ib.c 
2007-09-24 16:21:10.0 +0200
+++ ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib_ib.c  2007-09-24 
16:21:29.0 +0200
@@ -170,6 +170,7 @@ static void ipoib_ib_handle_rx_wc(struct
struct ipoib_dev_priv *priv = netdev_priv(dev);
unsigned int wr_id = wc->wr_id & ~IPOIB_OP_RECV;
struct sk_buff *skb;
+   struct ipoib_header *header;
u64 addr;
 
 	ipoib_dbg_data(priv, "recv completion: id %d, status: %d\n",

@@ -220,7 +221,10 @@ static void ipoib_ib_handle_rx_wc(struct
skb_put(skb, wc->byte_len);
skb_pull(skb, IB_GRH_BYTES);
 
-	skb->protocol = ((struct ipoib_he

[ewg] Re: resend two patches

[Vladimir Sokolovsky]

Ralph Campbell wrote:

I sent these to the EWG list but didn't see a response.
Betsy suggested I send them to you directly.




Subject:
[PATCH] OFED/scripts - Not all systems create a ".pc" file



[PATCH] OFED/kernel_addons - add for_each_sg() macro


Applied,

Ralph, please CC me on the emails with patches that you send to EWG list and 
intended for OFED.
Thanks,

Regards,
Vladimir
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] Feedback on Developer's Summit

[Or Gerlitz]

Roland Dreier wrote:

 > For (B): the LRO implementation posted is exactly using the generic
 > network stack software LRO helpers!

Sorry, I take that back.  I just checked again, and the patch that was
posted just used the same function names as the upstream LRO generic
helpers, which is what confused me when I skimmed it.

Yes, clearly we want to use the inet_lro stuff; I don't think there's
anything to discuss about that.


OK, fine.

So the way this patch is present in OFED 1.3 is only temporal where the 
upstream code would be done differently, let it be.


Or.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

OK. Let me know when you apply it and I will try to rerun 
ofed_makedist.sh. Just to make sure that I understand - does this fix 
allow the script to run without having quilt installed?


Erez

Vladimir Sokolovsky wrote:

No, only for ofed_makedist.sh.
Ralph Campbell already sent me the patch that fix this issue. I will
apply it shortly.


Regards,
Vladimir


  

-Original Message-
From: Erez Zilber [mailto:[EMAIL PROTECTED]
Sent: Tuesday, November 06, 2007 10:21 AM
To: Vladimir Sokolovsky
Cc: OpenFabricsEWG
Subject: Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches
update required

Vladimir Sokolovsky wrote:


Erez,
Do you have "quilt" installed?


Regards,
Vladimir


  

No. Do I need quilt in order to build/test OFED?

Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

RE: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Vladimir Sokolovsky]

No, only for ofed_makedist.sh.
Ralph Campbell already sent me the patch that fix this issue. I will
apply it shortly.


Regards,
Vladimir


> -Original Message-
> From: Erez Zilber [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, November 06, 2007 10:21 AM
> To: Vladimir Sokolovsky
> Cc: OpenFabricsEWG
> Subject: Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches
> update required
> 
> Vladimir Sokolovsky wrote:
> > Erez,
> > Do you have "quilt" installed?
> >
> >
> > Regards,
> > Vladimir
> >
> >
> 
> No. Do I need quilt in order to build/test OFED?
> 
> Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Vladimir Sokolovsky wrote:

Erez,
Do you have "quilt" installed?


Regards,
Vladimir
  



No. Do I need quilt in order to build/test OFED?

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

RE: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Vladimir Sokolovsky]

Erez,
Do you have "quilt" installed?


Regards,
Vladimir


> -Original Message-
> From: Erez Zilber [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, November 06, 2007 10:12 AM
> To: Vladimir Sokolovsky
> Cc: [EMAIL PROTECTED]; Eli Cohen; OpenFabricsEWG
> Subject: Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches
> update required
> 
> Tziporet Koren wrote:
> > Erez Zilber wrote:
> >>
> >> Vlad,
> >>
> >> I'm trying to run ofed_makedist.sh according to the instructions
> from
> >> https://wiki.openfabrics.org/tiki-
> index.php?page=HOWTO+Build+OFA+kernel+package:
> >>
> >>
> >> [EMAIL PROTECTED] linux-2.6]# ./ofed_scripts/ofed_makedist.sh
> >> git clone -q -s -n /home/erezz/work/ofed/linux-2.6
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11
> >> pushd /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11
> >> /home/erezz/work/ofed/linux-2.6
> >> /home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh
> >> e9f4951c8b3e2e784860545edf93b83189e34ce6
> >> 379afb8172cceb63872bd1ce8d1b318abf18bcf9 >>
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
> >> /home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh
> >> --with-backport=2.6.11 >>
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
> >> Failed executing
> >> /home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh
> >> --with-backport=2.6.11 >>
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
> >>
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-
> 2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch
> >>
> >> patching file drivers/infiniband/ulp/ipoib/ipoib.h
> >> Hunk #1 succeeded at 350 (offset 20 lines).
> >> patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
> >> Hunk #2 FAILED at 856.
> >> Hunk #3 succeeded at 897 (offset -8 lines).
> >> Hunk #4 succeeded at 916 with fuzz 2 (offset -1 lines).
> >> Hunk #5 succeeded at 932 (offset -8 lines).
> >> 1 out of 5 hunks FAILED -- saving rejects to file
> >> drivers/infiniband/ulp/ipoib/ipoib_main.c.rej
> >> Failed to apply patch:
> >> /tmp/build-ofed_kernel-nm2119/ofed_kernel-
> 2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch
> >>
> >> Build failed in /tmp/build-ofed_kernel-nm2119
> >> See log file /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
> >>
> > We are aware of this
> > Eli will work to fix these
> 
> Different problems now:
> 
> thyme:/home/erezz/work/ofed/linux-2.6 #
./ofed_scripts/ofed_makedist.sh
> git clone -q -s -n /home/erezz/work/ofed/linux-2.6
> /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
> Initialized empty Git repository in
> /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11/.git/
> pushd /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
> /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
> /home/erezz/work/ofed/linux-2.6
> /home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh
> b2d3675c40b61182b184ddf476d3c733ede164fd
> b0138854a4fe4de7c65a78876cf15cb186e66c21 >>
> /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11.log
> /home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh
> --with-backport=2.6.11 >>
> /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11.log
> chmod -R u+rw .pc
> chmod: cannot access `.pc': No such file or directory
> Failed executing chmod -R u+rw .pc
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Tziporet Koren wrote:

Erez Zilber wrote:


Vlad,

I'm trying to run ofed_makedist.sh according to the instructions from 
https://wiki.openfabrics.org/tiki-index.php?page=HOWTO+Build+OFA+kernel+package: 



[EMAIL PROTECTED] linux-2.6]# ./ofed_scripts/ofed_makedist.sh
git clone -q -s -n /home/erezz/work/ofed/linux-2.6 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11

pushd /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11 
/home/erezz/work/ofed/linux-2.6
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh 
e9f4951c8b3e2e784860545edf93b83189e34ce6 
379afb8172cceb63872bd1ce8d1b318abf18bcf9 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
Failed executing 
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
   
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch 


patching file drivers/infiniband/ulp/ipoib/ipoib.h
Hunk #1 succeeded at 350 (offset 20 lines).
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #2 FAILED at 856.
Hunk #3 succeeded at 897 (offset -8 lines).
Hunk #4 succeeded at 916 with fuzz 2 (offset -1 lines).
Hunk #5 succeeded at 932 (offset -8 lines).
1 out of 5 hunks FAILED -- saving rejects to file 
drivers/infiniband/ulp/ipoib/ipoib_main.c.rej
Failed to apply patch: 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch 


Build failed in /tmp/build-ofed_kernel-nm2119
See log file /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log


We are aware of this
Eli will work to fix these


Different problems now:

thyme:/home/erezz/work/ofed/linux-2.6 # ./ofed_scripts/ofed_makedist.sh
git clone -q -s -n /home/erezz/work/ofed/linux-2.6 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
Initialized empty Git repository in 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11/.git/

pushd /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11 
/home/erezz/work/ofed/linux-2.6
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh 
b2d3675c40b61182b184ddf476d3c733ede164fd 
b0138854a4fe4de7c65a78876cf15cb186e66c21 >> 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11.log
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11.log

chmod -R u+rw .pc
chmod: cannot access `.pc': No such file or directory
Failed executing chmod -R u+rw .pc
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg