Re: [ewg] Re: Merging ofed_kernel with 2.6.24-rc5
Erez Zilber wrote: Sorry, I meant ~vlad/ofed_kernel_test.git ofed_kernel branch. ./ofed_scripts/ofed_makedist.sh - applies patches from kernel_patches/fixes first and then patches from kernel_patches/backports following kernel version. Your patch is under kernel_patches/fixes and it fails on any kernel. - Vladimir I see that the script fails on something with IPoIB: patching file drivers/infiniband/ulp/ipoib/ipoib_main.c Hunk #2 succeeded at 783 (offset 3 lines). Hunk #3 succeeded at 918 (offset 3 lines). Hunk #4 succeeded at 987 (offset 3 lines). /tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0040_checksum-offload.patch patching file drivers/infiniband/ulp/ipoib/ipoib.h patching file drivers/infiniband/ulp/ipoib/ipoib_cm.c patching file drivers/infiniband/ulp/ipoib/ipoib_ib.c patching file drivers/infiniband/ulp/ipoib/ipoib_main.c Hunk #1 succeeded at 1123 (offset 3 lines). Hunk #2 succeeded at 1184 (offset 3 lines). /tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0050_Add-LSO-support.patch patching file drivers/infiniband/ulp/ipoib/ipoib.h patching file drivers/infiniband/ulp/ipoib/ipoib_cm.c patching file drivers/infiniband/ulp/ipoib/ipoib_ib.c patching file drivers/infiniband/ulp/ipoib/ipoib_main.c Hunk #1 succeeded at 716 (offset 3 lines). Hunk #2 succeeded at 1206 (offset 3 lines). /tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0060_ethtool-support.patch patching file drivers/infiniband/ulp/ipoib/Makefile patching file drivers/infiniband/ulp/ipoib/ipoib.h patching file drivers/infiniband/ulp/ipoib/ipoib_etool.c patching file drivers/infiniband/ulp/ipoib/ipoib_main.c Hunk #1 succeeded at 974 (offset 3 lines). /tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0070_modiy_cq_params.patch patching file drivers/infiniband/ulp/ipoib/ipoib.h patching file drivers/infiniband/ulp/ipoib/ipoib_etool.c /tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0080_broadcast_null.patch patching file drivers/infiniband/ulp/ipoib/ipoib_main.c Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file drivers/infiniband/ulp/ipoib/ipoib_main.c.rej Failed to apply patch: /tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0080_broadcast_null.patch Somehow the order of applied patches is different for me. I removed 'kernel_patches/fixes/ipoib_0080_broadcast_null.patch' patch. Please update your tree and rerun ofed_makedist.sh. Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] ewg please check
* Belgische Regierungskrise: Gefangen im politischen Nirgendwo* Zwiebelfischbl?ttern* Guter Geruchssinn: Elefanten erschn?ffeln, wo sich die Familie aufh?lt* Familiendramen: Acht tote Kinder entdeckt - M?tter unter Tatverdacht* Digitale Wasserzeichen: Nielsen will Web- Fernsehnutzern ?ber die Schulter schauenbl?ttern Save up to 90% on your m* RoutenplanerWissenschafts-Posse: Ahnungslose Chemiker entdecken Verbindung zum zweiten Mal* ?bersicht* Leute* Gammelfleisch- Verdacht: Superm?rkte verbannen Gefl?gel aus den Regalen* Techeds. Special Internet prices. Follow this linkNasa verschiebt Atlantis- Start* Doping- Sperre: Radprofi Winokurow bei Olympia wieder startberechtigtNETZWELT* Kinderstatistik: ?lterer Vater und j?ngere Mutter sind am erfolgreichsten* Fahrkultur* Fu?ball___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] RE: [ofa-general] ofed-1.2.5 - RH 4 U 6 bacport files
Al I did is coping the 2.6.9_U5 directory to 2.6.9_U6 and changing ofed_scripts/ofed_patch.sh . Typo . . I change the configure file and not ofed_scripts/ofed_patch.sh Moshe Moshe Katzir | +972-9971-8639 (o) | +972-52-860-6042 (m) Voltaire - The Grid Backbone www.voltaire.com -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Moshe Kazir Sent: Monday, December 17, 2007 11:11 AM To: Vladimir Sokolovsky; Yiftah Shahar Cc: EWG; OpenFabrics General Subject: [ofa-general] ofed-1.2.5 - RH 4 U 6 bacport files Back porting is very simple. Al I did is coping the 2.6.9_U5 directory to 2.6.9_U6 and changing ofed_scripts/ofed_patch.sh . I choose to copy the kernel_addons and kernel_patches directories to enable fixes in the future, If we find that U6 need something more. The attached files do the work. Moshe Moshe Katzir | +972-9971-8639 (o) | +972-52-860-6042 (m) Voltaire - The Grid Backbone www.voltaire.com ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Re: Merging ofed_kernel with 2.6.24-rc5
Erez Zilber wrote: Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git ofed_kernel It still fails (but not in open-iscsi/iSER patches): /tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch patching file drivers/net/mlx4/qp.c Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file drivers/net/mlx4/qp.c.rej Failed to apply patch: /tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch Thanks, Now iscsi backport patch for 2.6.18 fails: Applying patch open-iscsi-tx-hash-fixes.patch patching file drivers/scsi/iscsi_tcp.c Hunk #1 succeeded at 109 (offset 3 lines). Hunk #2 succeeded at 469 (offset 3 lines). Hunk #3 succeeded at 649 (offset 3 lines). Hunk #4 succeeded at 677 (offset 3 lines). Hunk #5 succeeded at 694 (offset 4 lines). Hunk #6 succeeded at 748 (offset 4 lines). Hunk #7 succeeded at 767 (offset 4 lines). Hunk #8 succeeded at 813 (offset 4 lines). Hunk #9 succeeded at 887 (offset 4 lines). Hunk #10 succeeded at 908 (offset 4 lines). Hunk #11 succeeded at 1211 (offset 4 lines). Hunk #12 FAILED at 1469. Hunk #13 FAILED at 1502. Hunk #14 succeeded at 1536 (offset 4 lines). Hunk #15 succeeded at 1824 (offset 3 lines). Hunk #16 succeeded at 1873 (offset 3 lines). Hunk #17 succeeded at 1884 (offset 3 lines). 2 out of 17 hunks FAILED -- rejects in file drivers/scsi/iscsi_tcp.c patching file drivers/scsi/iscsi_tcp.h Patch open-iscsi-tx-hash-fixes.patch does not apply (enforce with -f) ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Re: Merging ofed_kernel with 2.6.24-rc5
Vladimir Sokolovsky wrote: Erez Zilber wrote: Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git ofed_kernel It still fails (but not in open-iscsi/iSER patches): /tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch patching file drivers/net/mlx4/qp.c Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file drivers/net/mlx4/qp.c.rej Failed to apply patch: /tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch Thanks, Now iscsi backport patch for 2.6.18 fails: Applying patch open-iscsi-tx-hash-fixes.patch patching file drivers/scsi/iscsi_tcp.c Hunk #1 succeeded at 109 (offset 3 lines). Hunk #2 succeeded at 469 (offset 3 lines). Hunk #3 succeeded at 649 (offset 3 lines). Hunk #4 succeeded at 677 (offset 3 lines). Hunk #5 succeeded at 694 (offset 4 lines). Hunk #6 succeeded at 748 (offset 4 lines). Hunk #7 succeeded at 767 (offset 4 lines). Hunk #8 succeeded at 813 (offset 4 lines). Hunk #9 succeeded at 887 (offset 4 lines). Hunk #10 succeeded at 908 (offset 4 lines). Hunk #11 succeeded at 1211 (offset 4 lines). Hunk #12 FAILED at 1469. Hunk #13 FAILED at 1502. Hunk #14 succeeded at 1536 (offset 4 lines). Hunk #15 succeeded at 1824 (offset 3 lines). Hunk #16 succeeded at 1873 (offset 3 lines). Hunk #17 succeeded at 1884 (offset 3 lines). 2 out of 17 hunks FAILED -- rejects in file drivers/scsi/iscsi_tcp.c patching file drivers/scsi/iscsi_tcp.h Patch open-iscsi-tx-hash-fixes.patch does not apply (enforce with -f) Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git ofed_kernel For some reason, there were backport patches for 2.6.18 2.6.18_suse10_2. Erez ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Re: Merging ofed_kernel with 2.6.24-rc5
Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git ofed_kernel For some reason, there were backport patches for 2.6.18 2.6.18_suse10_2. Erez ofed_makedist.sh passed successfully. Now there are compilation issues on RHEL5.0 RHEL4U4, RHEL4U5, SLES10, SLES10SP1: gcc -Wp,-MD,/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/.iscsi_tcp.o.d -nostdinc -iwithprefix include -D__KERNEL__ -include include/linux/autoconf.h -include /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/include/linux/autoconf.h -I/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/kernel_addons/backport/2.6.9_U4/include/ -include /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/infiniband/debug/mtrack.h -Werror-implicit-function-declaration -I/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/include -I/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/infiniband/debug -I/usr/local/include/scst -I/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/infiniband/ulp/srpt -I/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/net/cxgb3 -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Os -fomit-frame-pointer -g -Wdeclaration-after-statement -mno-red-zone -mcmodel=kernel -pipe -fno-reorder-blocks -Wno-sign-compare -funit-at-a-time -DMODULE -DKBUILD_BASENAME=iscsi_tcp -DKBUILD_MODNAME=iscsi_tcp -c -o /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/.tmp_iscsi_tcp.o /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c from /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:39: include/linux/skbuff.h: In function 'skb_add_data': include/linux/skbuff.h:1013: warning: pointer targets in passing argument 2 of 'csum_partial_copy_from_user' differ in signedness /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: In function 'iscsi_r2t_rsp': /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:425: error: implicit declaration of function 'iscsi_requeue_ctask' /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: In function 'iscsi_recv_digest_update': /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:697: warning: pointer targets in passing argument 2 of 'sg_init_one' differ in signedness /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: In function 'iscsi_tcp_data_recv': /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:912: warning: pointer targets in passing argument 2 of 'sg_init_one' differ in signedness /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: In function 'iscsi_tcp_mtask_xmit': /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:1375: warning: pointer targets in passing argument 3 of 'iscsi_sendpage' differ in signedness /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: In function 'iscsi_send_unsol_pdu': /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:1626: warning: pointer targets in passing argument 5 of 'iscsi_send_data' differ in signedness /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: In function 'iscsi_tcp_ctask_xmit': /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:1791: warning: pointer targets in passing argument 5 of 'iscsi_send_data' differ in signedness /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c: At top level: /tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.c:2272: error: 'iscsi_eh_device_reset' undeclared here (not in a function) make[3]: *** [/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi/iscsi_tcp.o] Error 1 make[3]: Target `__build' not remade because of errors. make[2]: *** [/tmp/ofa_1_3_dev_kernel-20071217-1452_linux-2.6.9-42.ELsmp_check/drivers/scsi] Error 2 ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] OFED teleconference today
Friendly reminder: the OFED teleconference is today (Monday, 17 December, 2007). Next few teleconferences: - All are at noon US eastern / 9am US Pacific / 7pm Israel 1. Monday, Dec 17, code 210020028 (***TODAY***) === Break for holidays === 2. Monday, Jan 7, code 210020028 3. Monday, Jan 14, code 210020028 Dial-in information: US/Canada: +1.866.432.9903 India: +91.80.4103.3979 Israel: +972.9.892.7026 Others: http://cisco.com/en/US/about/doing_business/conferencing/ -- Jeff Squyres Cisco Systems ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] ofed-1.3-rc1 problem
Vladimir Sokolovsky wrote: On Sunday 16 December 2007 18:11:07 Steve Wise wrote: You're right! It is not installed, but it was built by install.pl. However I didn't explicitly request to build/install ibumad. Its a prerequisite of mvapich2, which I did ask to have built/installed. So I think install.pl needs to be fixed to prereq this maybe? install.pl set requirements for OFED packages selected to be installed. As I understand, correct me if I am wrong, the installation passed successfully, so , there is no issues in the install. If you want to compile your application (not from OFED) over libibumad, then you have to select libibumad-devel to be installed during OFED installation. I'm not sure where the fix needs to go, but if I install mvapich2-1.0.0 via install.pl, it should also build/install libibumad-devel. Otherwise, mpi programs cannot link correctly. I don't know if this dependency should be defined in the mvapich2 srpm somehow or the ofed tools. But in install.pl I see this: 'mvapich2_gcc' = { name = mvapich2_gcc, parent = mvapich2, selected = 0, installed = 0, rpm_exist = 0, rpm_exist32 = 0, available = 0, mode = user, dist_req_build = [], dist_req_inst = [], ofa_req_build = [libibumad-devel, libibverbs-devel, librdmacm-devel], ofa_req_inst = [mpi-selector, librdmacm, libibumad], install32 = 0, exception = 0 }, And see that libibumad-devel is a build requirement. I claim it is also an install requirement. This all worked on 1.2.5 by the way... Steve. Regards, Vladimir Vladimir Sokolovsky wrote: Steve Wise wrote: linking with libibumad fails on ofed-1.3-rc1. I get a 'cannot find -libumad' from ld. I looked in /usr/lib64 and there wasn't a link from libibumad.so to libibumad.so.1.0.2. I added the link and the ld works now. This was on PPC64. I think this is some install problem with libibumad. Steve. Hi Steve, Check that libibumad-devel is installed. Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] RE: [ofa-general] OFED 1.3 Beta release is available
I remembered someone else suggested to use: struct ibv_context { struct ibv_device *device; struct ibv_context_ops ops; int cmd_fd; int async_fd; int num_comp_vectors; pthread_mutex_t mutex; void *abi_compat; struct ibv_context_extra_ops extra_ops; }; Here we don't use pointer for extra_ops, and any future changes are added into 'extra_ops', So why not this way ? Thanks. --CQ -Original Message- From: Jack Morgenstein [mailto:[EMAIL PROTECTED] Sent: Sunday, December 16, 2007 11:01 AM To: [EMAIL PROTECTED] Cc: Tang, Changqing; Roland Dreier; ewg@lists.openfabrics.org; [EMAIL PROTECTED] Subject: Re: [ofa-general] OFED 1.3 Beta release is available On Wednesday 05 December 2007 17:45, Tang, Changqing wrote: I think the only alternative we have to preserve backwards compatibility is to leave struct ibv_context_ops alone and change the structure to: struct ibv_context { struct ibv_device *device; struct ibv_context_ops ops; int cmd_fd; int async_fd; int num_comp_vectors; pthread_mutex_t mutex; void *abi_compat; struct ibv_xrc_op *xrc_ops; }; with xrc_ops added at the end. It's my fault for not making the ops member a pointer I guess. Tziporet/Jack/whoever -- please fix up the libibverbs you ship for OFED 1.3 to resolve this. We can clean this up for libibverbs 1.2 when the ABI can change, if/when we have something worth breaking the ABI for. We need to have all userspace libraries set their private context object to 0 at allocation time (the private context object includes the ibv_context structure, which must now be NULL-ed out). The other userspace driver libraries (e.g., libmthca) do not zero-out their internal userspace context structures (e.g., mthca_context) which include the ibv_context structure as the first element. Up to now, we depended on the ibv_context assign to set unavailable verb implementations to NULL. (and every userspace driver assigned the ops structure, with unimplemented operations set to NULL by the compiler). This is no longer true. Thus, anyone installing OFED will have a compatible set of userspace drivers for XRC applications (drivers which do not implement XRC will return errors for XRC-verbs). Applications which were compiled with previous libraries will still work (since they do not use XRC). - Jack ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] OFED 1.3 Beta release is available
On Monday 17 December 2007 17:35, Tang, Changqing wrote: I remembered someone else suggested to use: struct ibv_context { struct ibv_device *device; struct ibv_context_ops ops; int cmd_fd; int async_fd; int num_comp_vectors; pthread_mutex_t mutex; void *abi_compat; struct ibv_context_extra_ops extra_ops; }; Here we don't use pointer for extra_ops, and any future changes are added into 'extra_ops', So why not this way ? That someone was me. However, I think Roland's idea is better: Roland wrote: Actually I'd prefer to add xrc_ops and then if we need to extend further with more new ops, add another structure after it. That way we avoid having to put any define in libibverbs to tell drivers like libmlx4 that xrc support is present; libmlx4 et al can just use AC_CHECK_MEMBER(struct ibv_context.xrc_ops) to test with autoconf. That is what I implemented. - Jack ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] ofed-1.3-rc1 problem
I'm not sure where the fix needs to go, but if I install mvapich2-1.0.0 via install.pl, it should also build/install libibumad-devel. Otherwise, mpi programs cannot link correctly. I don't know if this dependency should be defined in the mvapich2 srpm somehow or the ofed tools. But in install.pl I see this: 'mvapich2_gcc' = { name = mvapich2_gcc, parent = mvapich2, selected = 0, installed = 0, rpm_exist = 0, rpm_exist32 = 0, available = 0, mode = user, dist_req_build = [], dist_req_inst = [], ofa_req_build = [libibumad-devel, libibverbs-devel, librdmacm-devel], ofa_req_inst = [mpi-selector, librdmacm, libibumad], install32 = 0, exception = 0 }, And see that libibumad-devel is a build requirement. I claim it is also an install requirement. This all worked on 1.2.5 by the way... Steve. I added libibumad-devel to mvapich2 install requirements in the install.pl. This change will be available in the tomorrow's OFED-1.3 daily build. Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [PATCH 3 of 5] libcxgb3: zero context struct at allocation time (prep for additional context ops)
Applied. Thanks. I've released version 1.1.1 of the library, and updated the ofed_1_3 branch. Vlad, can you pull version 1.1.1 for ofed-1.3? git://git.openfabrics.org/~swise/libcxgb3.git ofed_1_3 Thanks, Steve. Jack Morgenstein wrote: The ibv_context structure will be getting additional ops, to be added at the end of the structure (and not as part of the existing ibv_context_ops structure). Reason: ibv_context_ops is declared directly as a member of ibv_context, and not as a pointer. Binaries compiled with previous libibverbs versions will not be backwards compatible if we add new operations to ibv_context_ops, since fields following the ops structure will move. To enable adding new operations at the end of the existing ibv_context struct, all driver libraries MUST zero their context structure at allocation time, so that new ops will be NULL by default. Signed-off-by: Jack Morgenstein [EMAIL PROTECTED] diff --git a/src/iwch.c b/src/iwch.c index 2747518..517ff00 100644 --- a/src/iwch.c +++ b/src/iwch.c @@ -114,6 +114,7 @@ static struct ibv_context *iwch_alloc_context(struct ibv_device *ibdev, if (!context) return NULL; + memset(context, 0, sizeof *context); context-ibv_ctx.cmd_fd = cmd_fd; if (ibv_cmd_get_context(context-ibv_ctx, cmd, sizeof cmd, ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Become a true s'e_xual giant in a coming new year!
of the financial markets, dominated high finance. They hadThe year 1992 had been a bright one for Soros. Not only had he a dazzling Are you out of luck? Only real men deserve success in this world! Grow to be a fortunate guy with a massive stick in year 2008! Obtain your dose of MegaDik today for the lowest price ever! http://sonblack.com/ interest rate trends by betting correctly on how certain currenciesleverage and have more than 100 percent invested.of the financial markets, dominated high finance. They hadnotice that each time they sell a stock for someone, the stock does not For all their risk, hedge funds offer a number of allurements. One,But none of the traders has sources within the Soros organization, athedge-fund managers, who requested anonymity, described the___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [GIT PULL ofed-1.2.5 and ofed-1.3] cxgb3 fixes
Vlad, Please pull 3 new cxgb3 driver fixes + backport support for ofed-1.2.5 and ofed-1.3. The 3 patches have been submitted and merged upstream. First two patches are submitted here: http://www.spinics.net/lists/kernel/msg659899.html And the third here: http://www.spinics.net/lists/kernel/msg660541.html For ofed-1.2.5, please pull from: git://git.openfabrics.org/~swise/ofed-1.2.5.git ofed_1_2_c For ofed-1.3, please pull from: git://git.openfabrics.org/~swise/ofed-1.3.git ofed_kernel Thanks, Steve. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg