Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Vladimir Sokolovsky]

SRP is included already in OFED-4.8 as a part of linux-4.8 kernel and I 
don't see any reason to include SRP code twice.
If some bug fixes have to be added there then there is a specific place 
in compat-rdma git tree for the relevant patches.
If somebody is interested to add an additional SRP standalone package 
then please send me the relevant patches for compat-rdma/ofed_scripts 
and build git trees.


Regards,
Vladimir


On 06/20/2017 09:01 PM, Davis, Arlin R wrote:

Ok. Vlad, what would it take to get this backported version of SRP into OFED 
4.8?


-Original Message-
From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
Sent: Tuesday, June 20, 2017 10:49 AM
To: v...@dev.mellanox.co.il; rsda...@soft-forge.com; Davis, Arlin R
; Hanania, Amir ;
Woodruff, Robert J ; mschlin...@ddn.com
Cc: ewg@lists.openfabrics.org; cfernan...@ddn.com; mda...@ddn.com
Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Hello Arlin,

Adding a URL to the OFED README is not the same as including a version of
the ib_srp-backport driver in OFED. How can OFED users know what version
of the ib_srp-backport driver has been tested in combination with which OFED
version?

Thanks,

Bart.

On Tue, 2017-06-20 at 17:18 +, Davis, Arlin R wrote:

Marty,

Would this work for DDN? We could add the URL and the SRP backport
readme to the OFED release notes. I believe you had an issue when
applying the backport to SL 7.2 and OFED 4.8 RC4 but I think Bart fixed that

already.

Thanks, Arlin


Hello Arlin and Robert,

A backported version of the 4.11 ib_srp driver that already has been
tested is available at https://github.com/bvanassche/ib_srp-backport.
That driver builds fine against kernel.org kernels, RHEL/CentOS
kernels, openSuSE and SLES kernels and also against MOFED and OFED.
Has it already been considered to use that code base instead of
duplicating the backporting effort of the ib_srp driver?

Thanks,

Bart.


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/mailman/listinfo/ewg

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Davis, Arlin R]

Ok. Vlad, what would it take to get this backported version of SRP into OFED 
4.8? 

> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Tuesday, June 20, 2017 10:49 AM
> To: v...@dev.mellanox.co.il; rsda...@soft-forge.com; Davis, Arlin R
> ; Hanania, Amir ;
> Woodruff, Robert J ; mschlin...@ddn.com
> Cc: ewg@lists.openfabrics.org; cfernan...@ddn.com; mda...@ddn.com
> Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> 
> Hello Arlin,
> 
> Adding a URL to the OFED README is not the same as including a version of
> the ib_srp-backport driver in OFED. How can OFED users know what version
> of the ib_srp-backport driver has been tested in combination with which OFED
> version?
> 
> Thanks,
> 
> Bart.
> 
> On Tue, 2017-06-20 at 17:18 +, Davis, Arlin R wrote:
> > Marty,
> >
> > Would this work for DDN? We could add the URL and the SRP backport
> > readme to the OFED release notes. I believe you had an issue when
> > applying the backport to SL 7.2 and OFED 4.8 RC4 but I think Bart fixed that
> already.
> >
> > Thanks, Arlin
> >
> > > Hello Arlin and Robert,
> > >
> > > A backported version of the 4.11 ib_srp driver that already has been
> > > tested is available at https://github.com/bvanassche/ib_srp-backport.
> > > That driver builds fine against kernel.org kernels, RHEL/CentOS
> > > kernels, openSuSE and SLES kernels and also against MOFED and OFED.
> > > Has it already been considered to use that code base instead of
> > > duplicating the backporting effort of the ib_srp driver?
> > >
> > > Thanks,
> > >
> > > Bart.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/mailman/listinfo/ewg

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Bart Van Assche]

Hello Arlin,

Adding a URL to the OFED README is not the same as including a version of the
ib_srp-backport driver in OFED. How can OFED users know what version of the
ib_srp-backport driver has been tested in combination with which OFED version?

Thanks,

Bart.

On Tue, 2017-06-20 at 17:18 +, Davis, Arlin R wrote:
> Marty,
> 
> Would this work for DDN? We could add the URL and the SRP backport readme to
> the OFED release notes. I believe you had an issue when applying the backport
> to SL 7.2 and OFED 4.8 RC4 but I think Bart fixed that already.
> 
> Thanks, Arlin
>  
> > Hello Arlin and Robert,
> > 
> > A backported version of the 4.11 ib_srp driver that already has been tested 
> > is
> > available at https://github.com/bvanassche/ib_srp-backport.
> > That driver builds fine against kernel.org kernels, RHEL/CentOS kernels,
> > openSuSE and SLES kernels and also against MOFED and OFED. Has it already
> > been considered to use that code base instead of duplicating the backporting
> > effort of the ib_srp driver?
> > 
> > Thanks,
> > 
> > Bart.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/mailman/listinfo/ewg

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Davis, Arlin R]

Marty,

Would this work for DDN? We could add the URL and the SRP backport readme to 
the OFED release notes. I believe you had an issue when applying the backport 
to SL 7.2 and OFED 4.8 RC4 but I think Bart fixed that already.

Thanks, Arlin
 
> Hello Arlin and Robert,
> 
> A backported version of the 4.11 ib_srp driver that already has been tested is
> available at https://github.com/bvanassche/ib_srp-backport.
> That driver builds fine against kernel.org kernels, RHEL/CentOS kernels,
> openSuSE and SLES kernels and also against MOFED and OFED. Has it already
> been considered to use that code base instead of duplicating the backporting
> effort of the ib_srp driver?
> 
> Thanks,
> 
> Bart.
> 
> On 06/20/17 09:32, Woodruff, Robert J wrote:
> > The question is, do we need everything that is in 4.11 or is there
> > just one or two fixes in 4.11 that would fix this specific issue
> > rather than trying to backport the entire 4.11 srp driver ?
> >
> >
> >
> > *From:*Davis, Arlin R
> > *Sent:* Tuesday, June 20, 2017 9:21 AM
> > *To:* Hanania, Amir ; Marty Schlining
> > ; Woodruff, Robert J
> > ; RSD@SFI ;
> 'Vladimir Sokolovsky'
> > 
> > *Cc:* bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric
> > Fernandes ; Mike Davis 
> > *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> >
> >
> >
> > Bart and Vlad,
> >
> >
> >
> > What is the best way to pull in 4.11 fixes into OFED 4.8?
> >
> > Looks like a lot of changes between 4.8 and 4.11.
> >
> >
> >
> > -arlin
> >
> >
> >
> >
> >
> > *From:*Hanania, Amir
> > *Sent:* Monday, June 19, 2017 4:26 PM
> > *To:* Davis, Arlin R  > >; Marty Schlining  > >; Woodruff, Robert J
> > >;
> > RSD@SFI >;
> > 'Vladimir Sokolovsky'  > >
> > *Cc:* bart.vanass...@gmail.com ;
> > ewg@lists.openfabrics.org ; Cedric
> > Fernandes >; Mike
> Davis
> > >
> > *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> >
> >
> >
> > I updated the bug with the below comment:
> >
> >
> >
> > I'm not sure if this ib_srp-backport patch is related, but it worth to
> > take a look.
> >
> >
> >
> > IB/srp: Improve an error path
> >
> > Avoid that the following message is printed if login fails: scsi host0:
> > ib_srp: Sending CM DREQ failed
> >
> >
> >
> >
> >
> >
> >
> > https://github.com/bvanassche/ib_srp-
> backport/commit/75c59cb20e6b7d209
> > 48f5a7b5e4fd92bd7436a60
> >
> >
> >
> >
> >
> > *From:*Davis, Arlin R
> > *Sent:* Monday, June 19, 2017 2:21 PM
> > *To:* Marty Schlining  > >; Woodruff, Robert J
> > >;
> > RSD@SFI >;
> 'Vladimir Sokolovsky'
> > >
> > *Cc:* bart.vanass...@gmail.com ;
> > ewg@lists.openfabrics.org ; Cedric
> > Fernandes >; Mike
> Davis
> > >; Hanania, Amir
> > >
> > *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> >
> >
> >
> > Ok, so it’s safe to say we are missing some bug fixes after kernel.org 4.8.
> >
> >
> >
> > +Amir, to help isolate and validate.
> >
> >
> >
> >
> >
> > *From:*Marty Schlining [mailto:mschlin...@ddn.com]
> > *Sent:* Monday, June 19, 2017 1:40 PM
> > *To:* Davis, Arlin R  > >; Woodruff, Robert J
> > >;
> > RSD@SFI >;
> > 'Vladimir Sokolovsky'  > >
> > *Cc:* bart.vanass...@gmail.com ;
> > ewg@lists.openfabrics.org ; Cedric
> > Fernandes >; Mike
> Davis
> > >
> > *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> >
> >
> >
> > The upstream test was for Bug 2631, SRP Reject Issue. The Base OS was
> > SL
> > 7.3 (not SL 7.2) w/ OFED 4.8-rc4 and the ib_srp_backport_4_11. That
> > combination worked properly.
> >
> >
> >
> > *From:*Davis, Arlin R [mailto:arlin.r.da...@intel.com]
> > *Sent:* Monday, June 19, 2017 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Bart Van Assche]

Hello Arlin and Robert,

A backported version of the 4.11 ib_srp driver that already has been
tested is available at https://github.com/bvanassche/ib_srp-backport.
That driver builds fine against kernel.org kernels, RHEL/CentOS kernels,
openSuSE and SLES kernels and also against MOFED and OFED. Has it
already been considered to use that code base instead of duplicating the
backporting effort of the ib_srp driver?

Thanks,

Bart.

On 06/20/17 09:32, Woodruff, Robert J wrote:
> The question is, do we need everything that is in 4.11 or is there just
> one or two fixes in 4.11 that would fix this specific issue rather than
> trying to backport the entire 4.11 srp driver ?
> 
>  
> 
> *From:*Davis, Arlin R
> *Sent:* Tuesday, June 20, 2017 9:21 AM
> *To:* Hanania, Amir ; Marty Schlining
> ; Woodruff, Robert J ;
> RSD@SFI ; 'Vladimir Sokolovsky'
> 
> *Cc:* bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric
> Fernandes ; Mike Davis 
> *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> 
>  
> 
> Bart and Vlad,
> 
>  
> 
> What is the best way to pull in 4.11 fixes into OFED 4.8?
> 
> Looks like a lot of changes between 4.8 and 4.11.
> 
>  
> 
> -arlin
> 
>  
> 
>  
> 
> *From:*Hanania, Amir
> *Sent:* Monday, June 19, 2017 4:26 PM
> *To:* Davis, Arlin R  >; Marty Schlining  >; Woodruff, Robert J
> >;
> RSD@SFI >;
> 'Vladimir Sokolovsky'  >
> *Cc:* bart.vanass...@gmail.com ;
> ewg@lists.openfabrics.org ; Cedric
> Fernandes >; Mike Davis
> >
> *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> 
>  
> 
> I updated the bug with the below comment:
> 
>  
> 
> I'm not sure if this ib_srp-backport patch is related, but it worth to
> take a look.
> 
>  
> 
> IB/srp: Improve an error path
> 
> Avoid that the following message is printed if login fails: scsi host0:
> ib_srp: Sending CM DREQ failed
> 
>  
> 
>  
> 
>  
> 
> https://github.com/bvanassche/ib_srp-backport/commit/75c59cb20e6b7d20948f5a7b5e4fd92bd7436a60
> 
>  
> 
>  
> 
> *From:*Davis, Arlin R
> *Sent:* Monday, June 19, 2017 2:21 PM
> *To:* Marty Schlining >;
> Woodruff, Robert J  >; RSD@SFI  >; 'Vladimir Sokolovsky'
> >
> *Cc:* bart.vanass...@gmail.com ;
> ewg@lists.openfabrics.org ; Cedric
> Fernandes >; Mike Davis
> >; Hanania, Amir
> >
> *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> 
>  
> 
> Ok, so it’s safe to say we are missing some bug fixes after kernel.org 4.8.
> 
>  
> 
> +Amir, to help isolate and validate.
> 
>  
> 
>  
> 
> *From:*Marty Schlining [mailto:mschlin...@ddn.com]
> *Sent:* Monday, June 19, 2017 1:40 PM
> *To:* Davis, Arlin R  >; Woodruff, Robert J
> >;
> RSD@SFI >;
> 'Vladimir Sokolovsky'  >
> *Cc:* bart.vanass...@gmail.com ;
> ewg@lists.openfabrics.org ; Cedric
> Fernandes >; Mike Davis
> >
> *Subject:* RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> 
>  
> 
> The upstream test was for Bug 2631, SRP Reject Issue. The Base OS was SL
> 7.3 (not SL 7.2) w/ OFED 4.8-rc4 and the ib_srp_backport_4_11. That
> combination worked properly.
> 
>  
> 
> *From:*Davis, Arlin R [mailto:arlin.r.da...@intel.com]
> *Sent:* Monday, June 19, 2017 4:35 PM
> *To:* Marty Schlining >;
> Woodruff, Robert J  >; RSD@SFI  >; 'Vladimir Sokolovsky'
> >
> *Cc:* bart.vanass...@gmail.com ;
> ewg@lists.openfabrics.org ; Cedric
> Fernandes 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Marty Schlining]

The upstream test was for Bug 2631, SRP Reject Issue. The Base OS was SL 7.3 
(not SL 7.2) w/ OFED 4.8-rc4 and the ib_srp_backport_4_11. That combination 
worked properly.

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 4:35 PM
To: Marty Schlining ; Woodruff, Robert J 
; RSD@SFI ; 'Vladimir 
Sokolovsky' 
Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric Fernandes 
; Mike Davis 
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I tested SL 7.2 with OFED 4.8-rc4. Scanning SRP targets yielded the following 
response:

Ok, so this is a kernel.org 4.8 base SRP driver backported to 3.10.
Can someone tell me if the same problem exists with upstream SRP driver in 
kernel 4.8?
This will tell me if it is an OFED 4.8 backport issue or if it is a kernel 
4.8 SRP driver issue.

ib_srp: Sending CM DREQ failed and the SRP targets were never scanned. (See Bug 
2632. http://bugs.openfabrics.org/show_bug.cgi?id=2632)

I attempted to use Bart Van Assche’s ib_srp_backport driver on top of SL 7.2 
and OFED 4.8-rc4 according to his instructions. The ib_srp_backport driver 
failed to compile (see attached text file). The ib_srp_backport driver will not 
compile with OFED 4.8-rc4 installed. I was able to uninstall OFED 4.8-rc4, then 
compile the driver. However, when OFED 4.8-rc4 was reinstalled, the 
ib_srp_backport driver was not compatible.

Ok, I think I understand.
This is the upstream test that you said passed? A SL 
7.2+infiniband+ib_srp_backport_from_4.11?
Correct?

   -arlin

That’s all of the testing , so far.

-Marty

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 4:02 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Sorry, I am still trying to understand what is working and what is needed to 
fix this for OFED 4.8.

When you said you tested the upstream kernel, was it SL 7.2 kernel plus the 
backports from Bart’s 4.11 drop? Do you need the 4.11 kernel base driver set 
for SRP to work properly?

-arlin

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Monday, June 19, 2017 9:42 AM
To: Davis, Arlin R >; 
Woodruff, Robert J 
>; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

No upstream kernel. SL 7.2 (3.10.0-327.el7.x86_64), OFED-4.8-rc4. Was unable to 
build the backport ib_srp backport driver on this platform with OFED 4.8-rc4 
installed. Multiple build errors. However, if I uninstall OFED-4.8-rc4, I am 
able to build the upstream ib_srp RPMs on SL 7.2

Backport ib_srp driver obtained by the following mechanism:

git clone https://github.com/bvanassche/ib_srp-backport.git

-Marty


From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 12:36 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Marty,

What upstream kernel did you use to verify SRP? Was it on a 4.8 base or 
something newer? If newer, maybe we are missing some key SRP fixes in our OFED 
4.8 kernel base.

Thanks, Arlin

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Friday, June 16, 2017 1:00 PM
To: Davis, Arlin R >; 
Woodruff, Robert J 

[ewg] [GIT PULL compat-rdma] Fix rstream timeouts on 4k_lat test

[Czeszun, Tomasz]

Hi Vlad,

Please pull from git://flatbed.openfabrics.org/~tomaszc/compat-rdma:for_vlad
commit d295ff654f1116249d901fc838a0df0feec7aca8  -  Fix rstream timeouts on 
4k_lat test

Thanks,
Tomasz


Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial 
Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | 
Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i 
moze zawierac informacje poufne. W razie przypadkowego otrzymania tej 
wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; 
jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole 
use of the intended recipient(s). If you are not the intended recipient, please 
contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/mailman/listinfo/ewg

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Marty Schlining]

No upstream kernel. SL 7.2 (3.10.0-327.el7.x86_64), OFED-4.8-rc4. Was unable to 
build the backport ib_srp backport driver on this platform with OFED 4.8-rc4 
installed. Multiple build errors. However, if I uninstall OFED-4.8-rc4, I am 
able to build the upstream ib_srp RPMs on SL 7.2

Backport ib_srp driver obtained by the following mechanism:

git clone https://github.com/bvanassche/ib_srp-backport.git

-Marty


From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 12:36 PM
To: Marty Schlining ; Woodruff, Robert J 
; RSD@SFI ; 'Vladimir 
Sokolovsky' 
Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric Fernandes 
; Mike Davis 
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Marty,

What upstream kernel did you use to verify SRP? Was it on a 4.8 base or 
something newer? If newer, maybe we are missing some key SRP fixes in our OFED 
4.8 kernel base.

Thanks, Arlin

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Friday, June 16, 2017 1:00 PM
To: Davis, Arlin R >; 
Woodruff, Robert J 
>; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I can’t say for sure. I am attempting to build the upstream ib_srp driver for 
this platform, but I am running into build issues. Bart, I will send you a 
separate email on that subject.

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Friday, June 16, 2017 3:58 PM
To: Woodruff, Robert J 
>; Marty 
Schlining >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Another SRP critical issue just opened. Is this also a backport issue?

Bug 2632 - SRP Login failure 
for SL 7.2 and OFED 4.8-rc4 (ib_srp: Sending CM DREQ failed)


From: Woodruff, Robert J
Sent: Friday, June 16, 2017 10:24 AM
To: Marty Schlining >; Davis, 
Arlin R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Ok, then it sound like it is important enough to hold the release until we have 
a fix. I assume this is something that you can look at Vlad ?

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Friday, June 16, 2017 10:17 AM
To: Woodruff, Robert J 
>; Davis, Arlin 
R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I tested the upstream driver from Bart VanAssche and it does not have the same 
issue as the OFED-4.8-rc4 ib_srp driver. The upstream driver handles the 
SRP_Reject as expected without crashing the SL 7.3 kernel. That is also 
detailed in the defect.

From: Woodruff, Robert J [mailto:robert.j.woodr...@intel.com]
Sent: Friday, June 16, 2017 1:14 PM
To: Marty Schlining >; Davis, 
Arlin R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Marty Schlining]

I can’t say for sure. I am attempting to build the upstream ib_srp driver for 
this platform, but I am running into build issues. Bart, I will send you a 
separate email on that subject.

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Friday, June 16, 2017 3:58 PM
To: Woodruff, Robert J ; Marty Schlining 
; RSD@SFI ; 'Vladimir Sokolovsky' 

Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric Fernandes 
; Mike Davis 
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Another SRP critical issue just opened. Is this also a backport issue?

Bug 2632 - SRP Login failure 
for SL 7.2 and OFED 4.8-rc4 (ib_srp: Sending CM DREQ failed)


From: Woodruff, Robert J
Sent: Friday, June 16, 2017 10:24 AM
To: Marty Schlining >; Davis, 
Arlin R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Ok, then it sound like it is important enough to hold the release until we have 
a fix. I assume this is something that you can look at Vlad ?

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Friday, June 16, 2017 10:17 AM
To: Woodruff, Robert J 
>; Davis, Arlin 
R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I tested the upstream driver from Bart VanAssche and it does not have the same 
issue as the OFED-4.8-rc4 ib_srp driver. The upstream driver handles the 
SRP_Reject as expected without crashing the SL 7.3 kernel. That is also 
detailed in the defect.

From: Woodruff, Robert J [mailto:robert.j.woodr...@intel.com]
Sent: Friday, June 16, 2017 1:14 PM
To: Marty Schlining >; Davis, 
Arlin R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

So I guess the next question is, does anyone have a fix that can be included ? 
Also, do you know if this is a problem with the backport or is it also broken 
in the upstream kernel ?

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Friday, June 16, 2017 10:03 AM
To: Woodruff, Robert J 
>; Davis, Arlin 
R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I do not think this is an acceptable workaround. An SRP target could have many 
hosts connected (IO nodes), not just the one that may have been abruptly 
rebooted (due to a power failure or pulled power cord). Are you suggesting that 
customers must reboot all of the IO nodes in their cluster attached to the SRP 
target and the SRP target as a workaround thereby taking the entire file system 
offline?

The backported ib_srp driver has a defect where it is not handling an 
SRP_Reject properly leaving a null pointer for the blk_mq driver. Normally, 
this would just be a note in the log and the srp_daemon could be setup to 
attempt a reconnect after 30 seconds. But, that is no longer possible with the 
current defect. The host would crash and reboot every time a connection is 
attempted.

-Marty 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Marty Schlining]

I tested the upstream driver from Bart VanAssche and it does not have the same 
issue as the OFED-4.8-rc4 ib_srp driver. The upstream driver handles the 
SRP_Reject as expected without crashing the SL 7.3 kernel. That is also 
detailed in the defect.

From: Woodruff, Robert J [mailto:robert.j.woodr...@intel.com]
Sent: Friday, June 16, 2017 1:14 PM
To: Marty Schlining ; Davis, Arlin R 
; RSD@SFI ; 'Vladimir 
Sokolovsky' 
Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric Fernandes 
; Mike Davis 
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

So I guess the next question is, does anyone have a fix that can be included ? 
Also, do you know if this is a problem with the backport or is it also broken 
in the upstream kernel ?

From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Friday, June 16, 2017 10:03 AM
To: Woodruff, Robert J 
>; Davis, Arlin 
R >; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I do not think this is an acceptable workaround. An SRP target could have many 
hosts connected (IO nodes), not just the one that may have been abruptly 
rebooted (due to a power failure or pulled power cord). Are you suggesting that 
customers must reboot all of the IO nodes in their cluster attached to the SRP 
target and the SRP target as a workaround thereby taking the entire file system 
offline?

The backported ib_srp driver has a defect where it is not handling an 
SRP_Reject properly leaving a null pointer for the blk_mq driver. Normally, 
this would just be a note in the log and the srp_daemon could be setup to 
attempt a reconnect after 30 seconds. But, that is no longer possible with the 
current defect. The host would crash and reboot every time a connection is 
attempted.

-Marty Schlining

From: Woodruff, Robert J [mailto:robert.j.woodr...@intel.com]
Sent: Friday, June 16, 2017 12:18 PM
To: Davis, Arlin R >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Marty Schlining 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

When I read the bug, it looks like the work around is to also reboot the target 
whenever the host is rebooted. Is this work around acceptable for the short 
term, and then fix the
issue in OFED-4.8-1, which will be a quick turnaround release since the new 
functionality being added to OFED-4.8-1 is limited.  If people are OK with 
that, I would recommend moving
to GA for OFED-4.8 and then start work on OFED-4.8-1 right away. OFED-4.8 has 
been dragging on forever and there are people that will want to start using it.

From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Davis, Arlin R
Sent: Friday, June 16, 2017 9:13 AM
To: RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; 
mschlin...@ddn.com
Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

What is the visibility and impact of the bug? Is this something that would be 
seen in normal use cases?
Is this actively being worked? What is the ETA for a fix?

From: RSD@SFI [mailto:rsda...@soft-forge.com]
Sent: Thursday, June 15, 2017 8:02 PM
To: Davis, Arlin R >; 
'Vladimir Sokolovsky' >
Cc: ewg@lists.openfabrics.org
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

SRP is very important to DDN and they have been a major supporter of IB and the 
OFA for a long time. Marty always attends the OFA Interop events and has been a 
big supporter of the OFA Logo program. Therefore I vote that we wait and find a 
fix.

From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Davis, Arlin R
Sent: Thursday, June 15, 2017 4:20 PM
To: Vladimir Sokolovsky 
>
Cc: 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Marty Schlining]

I do not think this is an acceptable workaround. An SRP target could have many 
hosts connected (IO nodes), not just the one that may have been abruptly 
rebooted (due to a power failure or pulled power cord). Are you suggesting that 
customers must reboot all of the IO nodes in their cluster attached to the SRP 
target and the SRP target as a workaround thereby taking the entire file system 
offline?

The backported ib_srp driver has a defect where it is not handling an 
SRP_Reject properly leaving a null pointer for the blk_mq driver. Normally, 
this would just be a note in the log and the srp_daemon could be setup to 
attempt a reconnect after 30 seconds. But, that is no longer possible with the 
current defect. The host would crash and reboot every time a connection is 
attempted.

-Marty Schlining

From: Woodruff, Robert J [mailto:robert.j.woodr...@intel.com]
Sent: Friday, June 16, 2017 12:18 PM
To: Davis, Arlin R ; RSD@SFI ; 
'Vladimir Sokolovsky' 
Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Marty Schlining 

Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

When I read the bug, it looks like the work around is to also reboot the target 
whenever the host is rebooted. Is this work around acceptable for the short 
term, and then fix the
issue in OFED-4.8-1, which will be a quick turnaround release since the new 
functionality being added to OFED-4.8-1 is limited.  If people are OK with 
that, I would recommend moving
to GA for OFED-4.8 and then start work on OFED-4.8-1 right away. OFED-4.8 has 
been dragging on forever and there are people that will want to start using it.

From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Davis, Arlin R
Sent: Friday, June 16, 2017 9:13 AM
To: RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; 
mschlin...@ddn.com
Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

What is the visibility and impact of the bug? Is this something that would be 
seen in normal use cases?
Is this actively being worked? What is the ETA for a fix?

From: RSD@SFI [mailto:rsda...@soft-forge.com]
Sent: Thursday, June 15, 2017 8:02 PM
To: Davis, Arlin R >; 
'Vladimir Sokolovsky' >
Cc: ewg@lists.openfabrics.org
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

SRP is very important to DDN and they have been a major supporter of IB and the 
OFA for a long time. Marty always attends the OFA Interop events and has been a 
big supporter of the OFA Logo program. Therefore I vote that we wait and find a 
fix.

From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Davis, Arlin R
Sent: Thursday, June 15, 2017 4:20 PM
To: Vladimir Sokolovsky 
>
Cc: ewg@lists.openfabrics.org
Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I just noticed a new critical SRP bug with RC4. Do we document as “known 
issues” or hold off on GA for a fix?

http://bugs.openfabrics.org/bugzilla/show_bug.cgi?id=2631


From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Davis, Arlin R
Sent: Thursday, June 15, 2017 10:57 AM
To: Vladimir Sokolovsky 
>; Schmidt, William R 
>; Schulfer, 
Pawel >
Cc: ewg@lists.openfabrics.org
Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8


Last call for release note changes. Please get them to Vlad by end of the day 
today so we can wrap this up.



Vlad, please roll GA tomorrow with all updated release notes.



Thanks everyone!


From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Vladimir 
Sokolovsky
Sent: Thursday, June 15, 2017 8:58 AM
To: Schmidt, William R 
>; Schulfer, 
Pawel >
Cc: ewg@lists.openfabrics.org
Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

This fix will get to GA as it was already applied as I mentioned before and the 
GA was not built yet.

Regards,
Vladimir
On 06/15/2017 12:51 AM, Schmidt, William R wrote:
Vlad,

Did this fix get into the GA version of OFED 4.8?

From: ewg [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Vladimir 
Sokolovsky
Sent: Thursday, June 8, 2017 12:17 PM
To: Schulfer, Pawel 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Woodruff, Robert J]

The question is, do we need everything that is in 4.11 or is there just one or 
two fixes in 4.11 that would fix this specific issue rather than trying to 
backport the entire 4.11 srp driver ?

From: Davis, Arlin R
Sent: Tuesday, June 20, 2017 9:21 AM
To: Hanania, Amir ; Marty Schlining 
; Woodruff, Robert J ; RSD@SFI 
; 'Vladimir Sokolovsky' 
Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric Fernandes 
; Mike Davis 
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Bart and Vlad,

What is the best way to pull in 4.11 fixes into OFED 4.8?
Looks like a lot of changes between 4.8 and 4.11.

-arlin


From: Hanania, Amir
Sent: Monday, June 19, 2017 4:26 PM
To: Davis, Arlin R >; 
Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I updated the bug with the below comment:

I'm not sure if this ib_srp-backport patch is related, but it worth to take a 
look.

IB/srp: Improve an error path
Avoid that the following message is printed if login fails: scsi host0: ib_srp: 
Sending CM DREQ failed



https://github.com/bvanassche/ib_srp-backport/commit/75c59cb20e6b7d20948f5a7b5e4fd92bd7436a60


From: Davis, Arlin R
Sent: Monday, June 19, 2017 2:21 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>; Hanania, Amir 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Ok, so it’s safe to say we are missing some bug fixes after kernel.org 4.8.

+Amir, to help isolate and validate.


From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Monday, June 19, 2017 1:40 PM
To: Davis, Arlin R >; 
Woodruff, Robert J 
>; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

The upstream test was for Bug 2631, SRP Reject Issue. The Base OS was SL 7.3 
(not SL 7.2) w/ OFED 4.8-rc4 and the ib_srp_backport_4_11. That combination 
worked properly.

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 4:35 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I tested SL 7.2 with OFED 4.8-rc4. Scanning SRP targets yielded the following 
response:

Ok, so this is a kernel.org 4.8 base SRP driver backported to 3.10.
Can someone tell me if the same problem exists with upstream SRP driver in 
kernel 4.8?
This will tell me if it is an OFED 4.8 backport issue or if it is a kernel 
4.8 SRP driver issue.

ib_srp: Sending CM DREQ failed and the SRP targets were never scanned. (See Bug 
2632. http://bugs.openfabrics.org/show_bug.cgi?id=2632)

I attempted to use Bart Van Assche’s ib_srp_backport driver on top of SL 7.2 
and OFED 4.8-rc4 according to his instructions. The ib_srp_backport driver 
failed to compile (see attached text 

Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Davis, Arlin R]

Bart and Vlad,

What is the best way to pull in 4.11 fixes into OFED 4.8?
Looks like a lot of changes between 4.8 and 4.11.

-arlin


From: Hanania, Amir
Sent: Monday, June 19, 2017 4:26 PM
To: Davis, Arlin R ; Marty Schlining 
; Woodruff, Robert J ; RSD@SFI 
; 'Vladimir Sokolovsky' 
Cc: bart.vanass...@gmail.com; ewg@lists.openfabrics.org; Cedric Fernandes 
; Mike Davis 
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I updated the bug with the below comment:

I'm not sure if this ib_srp-backport patch is related, but it worth to take a 
look.

IB/srp: Improve an error path
Avoid that the following message is printed if login fails: scsi host0: ib_srp: 
Sending CM DREQ failed



https://github.com/bvanassche/ib_srp-backport/commit/75c59cb20e6b7d20948f5a7b5e4fd92bd7436a60


From: Davis, Arlin R
Sent: Monday, June 19, 2017 2:21 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>; Hanania, Amir 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

Ok, so it’s safe to say we are missing some bug fixes after kernel.org 4.8.

+Amir, to help isolate and validate.


From: Marty Schlining [mailto:mschlin...@ddn.com]
Sent: Monday, June 19, 2017 1:40 PM
To: Davis, Arlin R >; 
Woodruff, Robert J 
>; RSD@SFI 
>; 'Vladimir Sokolovsky' 
>
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

The upstream test was for Bug 2631, SRP Reject Issue. The Base OS was SL 7.3 
(not SL 7.2) w/ OFED 4.8-rc4 and the ib_srp_backport_4_11. That combination 
worked properly.

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 4:35 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com; 
ewg@lists.openfabrics.org; Cedric Fernandes 
>; Mike Davis 
>
Subject: RE: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8

I tested SL 7.2 with OFED 4.8-rc4. Scanning SRP targets yielded the following 
response:

Ok, so this is a kernel.org 4.8 base SRP driver backported to 3.10.
Can someone tell me if the same problem exists with upstream SRP driver in 
kernel 4.8?
This will tell me if it is an OFED 4.8 backport issue or if it is a kernel 
4.8 SRP driver issue.

ib_srp: Sending CM DREQ failed and the SRP targets were never scanned. (See Bug 
2632. http://bugs.openfabrics.org/show_bug.cgi?id=2632)

I attempted to use Bart Van Assche’s ib_srp_backport driver on top of SL 7.2 
and OFED 4.8-rc4 according to his instructions. The ib_srp_backport driver 
failed to compile (see attached text file). The ib_srp_backport driver will not 
compile with OFED 4.8-rc4 installed. I was able to uninstall OFED 4.8-rc4, then 
compile the driver. However, when OFED 4.8-rc4 was reinstalled, the 
ib_srp_backport driver was not compatible.

Ok, I think I understand.
This is the upstream test that you said passed? A SL 
7.2+infiniband+ib_srp_backport_from_4.11?
Correct?

   -arlin

That’s all of the testing , so far.

-Marty

From: Davis, Arlin R [mailto:arlin.r.da...@intel.com]
Sent: Monday, June 19, 2017 4:02 PM
To: Marty Schlining >; Woodruff, 
Robert J >; 
RSD@SFI >; 'Vladimir 
Sokolovsky' >
Cc: bart.vanass...@gmail.com;