[exim-dev] [Bug 400] Patch for readsocket to shut down sending side of socket

[admin]

https://bugs.exim.org/show_bug.cgi?id=400

Git Commit  changed:

   What|Removed |Added

 CC||g...@exim.org

--- Comment #11 from Git Commit  ---
Git commit:
https://git.exim.org/exim.git/commitdiff/8de9db65575ccd8013753bb3d23426f0da2a669a

commit 8de9db65575ccd8013753bb3d23426f0da2a669a
Author: Jeremy Harris 
AuthorDate: Sun Feb 26 18:53:06 2017 +
Commit: Jeremy Harris 
CommitDate: Sun Feb 26 19:01:07 2017 +

add option to control use of shutdown by ${readsocket }.  bug 400

 doc/doc-docbook/spec.xfpt| 13 -
 doc/doc-txt/NewStuff |  3 +++
 src/src/expand.c | 37 -
 test/scripts/-Basic/0373 |  5 -
 test/stdout/0373 |  6 ++
 5 files changed, 49 insertions(+), 15 deletions(-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 1837] small subgroup attack

[admin]

https://bugs.exim.org/show_bug.cgi?id=1837

--- Comment #11 from Phil Pennock  ---
Exim 4.89 is still in-practice-compatible with OpenSSL 1.0.1 and earlier, even
though we're not officially supporting them.

After 4.89, the gloves come off and we can deal with this issue properly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 1895] Default groups for DH possibly backdoored

[admin]

https://bugs.exim.org/show_bug.cgi?id=1895

--- Comment #7 from Phil Pennock  ---
Current status: Exim 4.89 will "not support prior to 1.0.2" but in _practice_
we're keeping the codebase using old APIs for one final release, to give people
a little breathing room and an upgrade checkpoint.

After 4.89, we can start switching support to rely upon 1.0.2+ APIs, which gets
us the ability to load the q from DH and be in a slightly stronger
cryptographic position.

We're doing a bunch of stuff around re-using connections and TLS moving
forward, so rather than leave this as a timebomb just because it doesn't affect
us _now_, we should fix it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 400] Patch for readsocket to shut down sending side of socket

[admin]

https://bugs.exim.org/show_bug.cgi?id=400

Jeremy Harris  changed:

   What|Removed |Added

   Target Milestone|Exim 4.77   |Exim_4.90+

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 400] Patch for readsocket to shut down sending side of socket

[admin]

https://bugs.exim.org/show_bug.cgi?id=400

--- Comment #10 from Jeremy Harris  ---
Going for an explicit option, extending the timeout arg to take a list.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 400] Patch for readsocket to shut down sending side of socket

[admin]

https://bugs.exim.org/show_bug.cgi?id=400

Jeremy Harris  changed:

   What|Removed |Added

   Assignee|p...@hermes.cam.ac.uk   |jgh146...@wizmail.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 2061] Initial $value in reduce being erased

[admin]

https://bugs.exim.org/show_bug.cgi?id=2061

Jeremy Harris  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 2061] Initial $value in reduce being erased

[admin]

https://bugs.exim.org/show_bug.cgi?id=2061

--- Comment #3 from Git Commit  ---
Git commit:
https://git.exim.org/exim.git/commitdiff/1e0a93cf90adf08507195e7af3b689e3f42b7910

commit 1e0a93cf90adf08507195e7af3b689e3f42b7910
Author: Jeremy Harris 
AuthorDate: Sun Feb 26 13:34:10 2017 +
Commit: Jeremy Harris 
CommitDate: Sun Feb 26 13:34:10 2017 +

Testsuite: regression test for Bug 2061
---
 test/scripts/-Basic/0002 | 2 ++
 test/stdout/0002 | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/test/scripts/-Basic/0002 b/test/scripts/-Basic/0002
index c2dcc40..cf8dc36 100644
--- a/test/scripts/-Basic/0002
+++ b/test/scripts/-Basic/0002
@@ -63,6 +63,8 @@ reduce: "${reduce{}{+}{$value$item}}"
 reduce: ${reduce{a:b:c}{+}{$value$item}}
 reduce: ${reduce {<, 1,2,3}{0}{${eval:$value+$item}}}
 reduce: ${reduce {3:0:9:4:6}{0}{${if >{$item}{$value}{$item}{$value
+# Check for extract corrupting reduce's $value
+reduce: ${reduce {b}{a aaa}{${extract{1}{ }{$value}} , $item}}

 listnamed: ${listnamed:dlist}
 listnamed: ${listnamed:+dlist}
diff --git a/test/stdout/0002 b/test/stdout/0002
index b6ca54d..fa445b0 100644
--- a/test/stdout/0002
+++ b/test/stdout/0002
@@ -52,6 +52,8 @@
 > reduce: +abc
 > reduce: 6
 > reduce: 9
+> # Check for extract corrupting reduce's 
+> reduce: a , b
 > 
 > listnamed: *.aa.bb : ^\Nxxx(.*)
 > listnamed: *.aa.bb : ^\Nxxx(.*)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 966] DKIM resource-limit logging could be more specific

[admin]

https://bugs.exim.org/show_bug.cgi?id=966

--- Comment #3 from Git Commit  ---
Git commit:
https://git.exim.org/exim.git/commitdiff/c0ad8edfe5615780184f88bfc8fa306b76db6bbc

commit c0ad8edfe5615780184f88bfc8fa306b76db6bbc
Author: Jeremy Harris 
AuthorDate: Sun Feb 26 14:58:54 2017 +
Commit: Jeremy Harris 
CommitDate: Sun Feb 26 15:03:15 2017 +

DKIM: rework error logging - compiler quietening.  Bug 966
---
 src/src/transports/smtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/src/transports/smtp.c b/src/src/transports/smtp.c
index 90ec87b..c590864 100644
--- a/src/src/transports/smtp.c
+++ b/src/src/transports/smtp.c
@@ -3030,7 +3030,7 @@ if (!sx.ok)
 save_errno = errno;
 code = '4';
 message = string_sprintf("send() to %s [%s] failed: %s",
-  host->name, host->address, message ? message : strerror(save_errno));
+  host->name, host->address, message ? message : US strerror(save_errno));
 sx.send_quit = FALSE;
 goto FAILED;
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 1870] Use of ${run} in router conditions causes intermittent crash

[admin]

https://bugs.exim.org/show_bug.cgi?id=1870

--- Comment #8 from Git Commit  ---
Git commit:
https://git.exim.org/exim.git/commitdiff/9e09521e621d852ac4828f1865b4ccb01568d9ee

commit 9e09521e621d852ac4828f1865b4ccb01568d9ee
Author: Jeremy Harris 
AuthorDate: Sun Feb 26 01:07:47 2017 +
Commit: Jeremy Harris 
CommitDate: Sun Feb 26 13:22:31 2017 +

Fix ${extract } corrupting an enclosing ${reduce }  $value.  Bug 2061

Broken-by: 20fcb1e7be45   - Bug 1870
---
 src/src/expand.c | 27 ++-
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/src/expand.c b/src/src/expand.c
index 6257c28..f85ee49 100644
--- a/src/src/expand.c
+++ b/src/src/expand.c
@@ -3194,17 +3194,17 @@ items. */
 while (isspace(*s)) s++;
 if (*s == '}')
   {
-  if (!skipping)
-if (type[0] == 'i')
-  {
-  if (yes) *yieldptr = string_catn(*yieldptr, sizeptr, ptrptr, US"true",
4);
-  }
-else
-  {
-  if (yes && lookup_value)
-*yieldptr = string_cat(*yieldptr, sizeptr, ptrptr, lookup_value);
-  lookup_value = save_lookup;
-  }
+  if (type[0] == 'i')
+{
+if (yes && !skipping)
+  *yieldptr = string_catn(*yieldptr, sizeptr, ptrptr, US"true", 4);
+}
+  else
+{
+if (yes && lookup_value && !skipping)
+  *yieldptr = string_cat(*yieldptr, sizeptr, ptrptr, lookup_value);
+lookup_value = save_lookup;
+}
   s++;
   goto RETURN;
   }
@@ -5801,11 +5801,12 @@ while (*s != 0)
   processing for real, we perform the iteration. */

   if (skipping) continue;
-  while ((iterate_item = string_nextinlist(, , NULL, 0)) != NULL)
+  while ((iterate_item = string_nextinlist(, , NULL, 0)))
 {
 *outsep = (uschar)sep;  /* Separator as a string */

-DEBUG(D_expand) debug_printf_indent("%s: $item = \"%s\"\n", name,
iterate_item);
+DEBUG(D_expand) debug_printf_indent("%s: $item = '%s'  $value = '%s'\n",
+  name, iterate_item, lookup_value);

 if (item_type == EITEM_FILTER)
   {

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] [Bug 2061] Initial $value in reduce being erased

[admin]

https://bugs.exim.org/show_bug.cgi?id=2061

Git Commit  changed:

   What|Removed |Added

 CC||g...@exim.org

--- Comment #2 from Git Commit  ---
Git commit:
https://git.exim.org/exim.git/commitdiff/9e09521e621d852ac4828f1865b4ccb01568d9ee

commit 9e09521e621d852ac4828f1865b4ccb01568d9ee
Author: Jeremy Harris 
AuthorDate: Sun Feb 26 01:07:47 2017 +
Commit: Jeremy Harris 
CommitDate: Sun Feb 26 13:22:31 2017 +

Fix ${extract } corrupting an enclosing ${reduce }  $value.  Bug 2061

Broken-by: 20fcb1e7be45   - Bug 1870
---
 src/src/expand.c | 27 ++-
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/src/expand.c b/src/src/expand.c
index 6257c28..f85ee49 100644
--- a/src/src/expand.c
+++ b/src/src/expand.c
@@ -3194,17 +3194,17 @@ items. */
 while (isspace(*s)) s++;
 if (*s == '}')
   {
-  if (!skipping)
-if (type[0] == 'i')
-  {
-  if (yes) *yieldptr = string_catn(*yieldptr, sizeptr, ptrptr, US"true",
4);
-  }
-else
-  {
-  if (yes && lookup_value)
-*yieldptr = string_cat(*yieldptr, sizeptr, ptrptr, lookup_value);
-  lookup_value = save_lookup;
-  }
+  if (type[0] == 'i')
+{
+if (yes && !skipping)
+  *yieldptr = string_catn(*yieldptr, sizeptr, ptrptr, US"true", 4);
+}
+  else
+{
+if (yes && lookup_value && !skipping)
+  *yieldptr = string_cat(*yieldptr, sizeptr, ptrptr, lookup_value);
+lookup_value = save_lookup;
+}
   s++;
   goto RETURN;
   }
@@ -5801,11 +5801,12 @@ while (*s != 0)
   processing for real, we perform the iteration. */

   if (skipping) continue;
-  while ((iterate_item = string_nextinlist(, , NULL, 0)) != NULL)
+  while ((iterate_item = string_nextinlist(, , NULL, 0)))
 {
 *outsep = (uschar)sep;  /* Separator as a string */

-DEBUG(D_expand) debug_printf_indent("%s: $item = \"%s\"\n", name,
iterate_item);
+DEBUG(D_expand) debug_printf_indent("%s: $item = '%s'  $value = '%s'\n",
+  name, iterate_item, lookup_value);

 if (item_type == EITEM_FILTER)
   {

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##