[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #10 from Matthias Kurz --- Jeremy, this should be done now. Patch 2+3 just move the event logger ACL in a separate file so we can easily re-use it for other tests. There are test cases for ALL the cases where prop.ignore_error get set to true (Some get tested already, so I didn't had to add tests, e.g. rf_get_errors_address.c also sets it but that was covered in the existing tests already). Also see the comments at the attachments I uploaded. Let me know if that is OK for you. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #8 from Matthias Kurz --- Created attachment 1132 --> https://bugs.exim.org/attachment.cgi?id=1132&action=edit Raise event for syntactically invalid generated recipient in autoreply transport even when error is ignored Test when prop.ignore_error gets set in deliver.c in line 6364: https://git.exim.org/exim.git/blob/7ea1237c783e380d7bdb86c90b13d8203c7ecf26:/src/src/deliver.c#l6364 -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #9 from Matthias Kurz --- Created attachment 1133 --> https://bugs.exim.org/attachment.cgi?id=1133&action=edit Changelog -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #7 from Matthias Kurz --- Created attachment 1131 --> https://bugs.exim.org/attachment.cgi?id=1131&action=edit Raise msg:fail:delivery when an error of a failed bounce gets ignored Test when prop.ignore_error gets set in deliver.c in line 7436 https://git.exim.org/exim.git/blob/7ea1237c783e380d7bdb86c90b13d8203c7ecf26:/src/src/deliver.c#l7436 -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #6 from Matthias Kurz --- Created attachment 1130 --> https://bugs.exim.org/attachment.cgi?id=1130&action=edit msg:fail:delivery if ignore_error was set from within a filter This patch handles ALL the cases where prop.ignore_error gets set within filter.c and/or sieve.c even though it's only a test just for the deliver command. That's because there is just a single point in rda.c where filter_interpret and sieve_interpret get called and return a value: Line 398: https://git.exim.org/exim.git/blob/25beaee4c28ed29a37078e6c68fa3d18ced6ec8c:/src/src/rda.c#l398 Line 407: https://git.exim.org/exim.git/blob/25beaee4c28ed29a37078e6c68fa3d18ced6ec8c:/src/src/rda.c#l407 Therefore I think just one test for all filter scenarios should be enough since the logic in rda.c is the same for all of them. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2311] DANE verify fails with a TA-mode TLSA and a selfsigned server cert
https://bugs.exim.org/show_bug.cgi?id=2311 Git Commit changed: What|Removed |Added CC||g...@exim.org --- Comment #5 from Git Commit --- Git commit: https://git.exim.org/exim.git/commitdiff/570cb1bdbc6ea378b2dcaf6ebabb45a5610ed1ef commit 570cb1bdbc6ea378b2dcaf6ebabb45a5610ed1ef Author: Jeremy Harris AuthorDate: Mon Sep 17 16:28:58 2018 +0100 Commit: Jeremy Harris CommitDate: Mon Sep 17 16:28:58 2018 +0100 dane: fix ta-mode verify under gnutls. bug 2311 doc/doc-txt/ChangeLog | 7 +++- src/src/tls-gnu.c | 22 test/confs/5820 | 2 +- test/confs/5822 | 67 - test/confs/5840 | 2 +- test/confs/5842 | 64 --- test/log/5820 | 4 +-- test/log/5822 | 20 --- test/log/5840 | 7 ++-- test/log/5842 | 24 - test/scripts/5820-DANE-GnuTLS/5820 | 8 ++--- test/scripts/5820-DANE-GnuTLS/5822 | 19 --- test/scripts/5840-DANE-OpenSSL/5840 | 2 +- test/scripts/5840-DANE-OpenSSL/5842 | 19 --- test/stderr/5820| 12 +++ test/stderr/5842| 8 - test/stdout/5820| 12 +++ test/stdout/5822| 8 - test/stdout/5842| 8 - 19 files changed, 45 insertions(+), 270 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 Matthias Kurz changed: What|Removed |Added Attachment #1105|0 |1 is obsolete|| --- Comment #3 from Matthias Kurz --- Created attachment 1127 --> https://bugs.exim.org/attachment.cgi?id=1127&action=edit Raise event when ignore_error is true -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #4 from Matthias Kurz --- Created attachment 1128 --> https://bugs.exim.org/attachment.cgi?id=1128&action=edit Move acl that logs events into own file -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2314] Raise event (also) when ignore_error is true
https://bugs.exim.org/show_bug.cgi?id=2314 --- Comment #5 from Matthias Kurz --- Created attachment 1129 --> https://bugs.exim.org/attachment.cgi?id=1129&action=edit Allow other domains than domain1 in event logger acl -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2311] DANE verify fails with a TA-mode TLSA and a selfsigned server cert
https://bugs.exim.org/show_bug.cgi?id=2311 Jeremy Harris changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|ni...@exim.org |jgh146...@wizmail.org -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #19 from Jeremy Harris --- Just not needed. We could create another value if we really cared, but unless we need different processing anywhere in the ACL handling, or that value gets exposed as a variable... we don't. Thank for spotting the typo; I'll tweak that next time I'm in there. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
Re: [exim-dev] buildfarm client proposal: tests configure support
Phil Pennock via Exim-dev (Sa 15 Sep 2018 03:34:35 CEST):
> I've made the buildfarm repos visible† on git.exim.org since there's
> nothing secret in them and we point folks to them on public wiki pages,
> and all the repos can be cloned without authentication.
>
> I've pushed to buildfarm-client.git a new branch `test_configure_tuning`
> with one additional commit:
>
> https://git.exim.org/buildfarm-client.git/shortlog/refs/heads/test_configure_tuning
> https://git.exim.org/buildfarm-client.git/commitdiff/0ce98df83e53cc21a25d98f95e431803a398742c
(1)
Instead of
my %saved_env = %ENV;
…
%ENV = %saved_env;
I'd do:
{ local %ENV = %ENV;
…
}
This should have the same result, but is more reliable in restoring the
old %ENV when leaving the scope.
(2)
And instead of adding the keys/values to the %ENV one by one, I'd
probably do
%ENV = (%ENV, %{$EximBuild::conf{test_configure_env}});
But that's matter of taste.
(3)
And instead of the attempt to get the quoting right, I'd try
do do it in pure Perl
I'd replace
my $conf_args = '';
foreach (@{$EximBuild::conf{test_configure_args}}) {
s/'/'"'"'/g;
$conf_args .= " '${_}'";
}
@makeout =`(cd $exim/test && ./configure $conf_args && $make )2>&1 `;
with (untested) block like this (no shell involved anymore):
open(my $make, '-|') or do {
open(STDERR, '>&STDOUT');
chdir "$exim/test" or die;
system("./configure", @{$EximBuild::conf{test_configure_args}) == 0 or
die;
system("make") == 0 or die;
exit 0;
};
@makeout = <$make>;
close($make) or die;
Maybe I missed the point, but If you'd like, I can try implementing the above
changes.
Best regards from Dresden/Germany
Viele Grüße aus Dresden
Heiko Schlittermann
--
SCHLITTERMANN.de internet & unix support -
Heiko Schlittermann, Dipl.-Ing. (TU) - {fon,fax}: +49.351.802998{1,3} -
gnupg encrypted messages are welcome --- key ID: F69376CE -
! key id 7CBF764A and 972EAC9F are revoked since 2015-01 -
signature.asc
Description: PGP signature
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim
details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #18 from Matthias Kurz --- Thanks Jeremy! I saw you didn't set acl_where? Was that intentional? Or just not needed? Also there is a typo in the changelog: > ...message is manually reoved... Should probably be "...removed...". -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
