Re: [exim-dev] ulong in exim_monitor/em_menu.c

[Jeremy Harris via Exim-dev]

On 12/09/2020 19:47, Richard Clayton via Exim-dev wrote:
> in exim_monitor/em_menu.c
> 
>  635   text_showf(text, "Format error in spool file %s: size=%lu\n", 
> buffer,
>  636 (ulong)statbuf.st_size);
> 
> sadly, when I compile with clang on FreeBSD "ulong" does not exist

Thanks for finding this.  I obviously need to add eximon to the
FreeBSD buildfarm animal I have.  I foresee a world of library pain...

Unless you fancy setting one up, so that the specific configuration
you are interested in is certain to get regression tests?
-- 
Cheers,
  Jeremy

-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##

[exim-dev] ulong in exim_monitor/em_menu.c

[Richard Clayton via Exim-dev]

in exim_monitor/em_menu.c

 635   text_showf(text, "Format error in spool file %s: size=%lu\n", buffer,
 636 (ulong)statbuf.st_size);

sadly, when I compile with clang on FreeBSD "ulong" does not exist

changing ulong to unsigned long makes my compiler happy, I cannot
speak for others...

this is the only use of ulong in the Exim source, and appears to have
been introduced 2019-09-29 "tidying" ... and was not removed (when
perhaps it might have been) by 2020-06-27 "Remove attempts to quieten
compiler static-checking"

the FreeBSD package fixed it by patch r526980 (see comment #8)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242518

but since I compile from source that's little consolation

-- 
richard   Richard Clayton

Those who would give up essential Liberty, to purchase a little temporary 
Safety, deserve neither Liberty nor Safety. Benjamin Franklin 11 Nov 1755


signature.asc
Description: PGP signature
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim 
details at http://www.exim.org/ ##