[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Jeremy Harris changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #20 from Jeremy Harris --- No further comments seen -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #19 from Jeremy Harris --- Just not needed. We could create another value if we really cared, but unless we need different processing anywhere in the ACL handling, or that value gets exposed as a variable... we don't. Thank for spotting the typo; I'll tweak that next time I'm in there. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #18 from Matthias Kurz --- Thanks Jeremy! I saw you didn't set acl_where? Was that intentional? Or just not needed? Also there is a typo in the changelog: > ...message is manually reoved... Should probably be "...removed...". -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Git Commit changed: What|Removed |Added CC||g...@exim.org --- Comment #17 from Git Commit --- Git commit: https://git.exim.org/exim.git/commitdiff/7ea1237c783e380d7bdb86c90b13d8203c7ecf26 commit 7ea1237c783e380d7bdb86c90b13d8203c7ecf26 Author: Matthias Kurz AuthorDate: Mon Sep 17 00:20:24 2018 +0100 Commit: Jeremy Harris CommitDate: Mon Sep 17 00:21:30 2018 +0100 events: raise msg:fail:internal & msg:complete for -mrm. bug 2310 doc/doc-txt/ChangeLog | 4 src/src/deliver.c | 24 +++- src/src/exim.c| 6 ++ src/src/queue.c | 35 +-- test/log/5700 | 17 + test/scripts/5700-events/5700 | 20 test/stdout/5700 | 3 +++ 7 files changed, 98 insertions(+), 11 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Jeremy Harris changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|ni...@exim.org |jgh146...@wizmail.org --- Comment #16 from Jeremy Harris --- Seems reasonable. I shuffled the ordering, and used an internal parse function rather than the string-expansion hack (also in the place I wrote that hack originally). -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Matthias Kurz changed: What|Removed |Added Attachment #1109|0 |1 is obsolete|| --- Comment #13 from Matthias Kurz --- Created attachment 1118 --> https://bugs.exim.org/attachment.cgi?id=1118=edit Set acl_where -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #15 from Matthias Kurz --- NOW it's really done ;) The last patch file I added now also fires "msg:fail:internal" for non-delivered recipients when removing a message via -Mrm. Comment 9 still applies. Let me know what you think, I am eager to get this in. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #14 from Matthias Kurz --- Created attachment 1119 --> https://bugs.exim.org/attachment.cgi?id=1119=edit Fire msg:fail:internal for each recipient for -Mrm -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Matthias Kurz changed: What|Removed |Added Attachment #1108|0 |1 is obsolete|| --- Comment #12 from Matthias Kurz --- Created attachment 1117 --> https://bugs.exim.org/attachment.cgi?id=1117=edit Test: Fire event(s) when removing message from queue -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Matthias Kurz changed: What|Removed |Added Attachment #1106|0 |1 is obsolete|| --- Comment #10 from Matthias Kurz --- Created attachment 1115 --> https://bugs.exim.org/attachment.cgi?id=1115=edit event_raise(...) can be used outside of transport -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Matthias Kurz changed: What|Removed |Added Attachment #1107|0 |1 is obsolete|| --- Comment #11 from Matthias Kurz --- Created attachment 1116 --> https://bugs.exim.org/attachment.cgi?id=1116=edit Call event_raise when removing message from queue (-Mrm) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #9 from Matthias Kurz --- Alright, it's done - here is a working version that fires "msg:complete" when a message gets removed via "-Mrm". The problem I was facing a couple of days ago was that the ACL definitions were not available in queue_action(...) because the were not loaded yet by readconf_rest(...). So what I did is load them but only for the MSG_REMOVE action. (I understand that readconf_rest(...) wasn't loaded yet but for that specific queue-action it is needed now) The only thing I am unsure right now is what acl_where should be set to. Right now I made it ACL_WHERE_DELIVERY but maybe someone knows a better value? Or should we just keep/set it to ACL_WHERE_UNKNOWN? Or add a new value for it? In a future change we probably also want to call "msg:fail:internal" for all recipients, however I will do that later in another patch. Let's finish that one for now. (Also I added 4 patch files which are all needed, I hope that's OK. If wished I can just add one single patch.) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #7 from Matthias Kurz --- Created attachment 1108 --> https://bugs.exim.org/attachment.cgi?id=1108=edit Test: Fire event(s) when removing message from queue -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #6 from Matthias Kurz --- Created attachment 1107 --> https://bugs.exim.org/attachment.cgi?id=1107=edit Call event_raise when removing message from queue (-Mrm) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #8 from Matthias Kurz --- Created attachment 1109 --> https://bugs.exim.org/attachment.cgi?id=1109=edit Set acl_where -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #5 from Matthias Kurz --- Created attachment 1106 --> https://bugs.exim.org/attachment.cgi?id=1106=edit event_raise(...) can be used outside of transport -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 Matthias Kurz changed: What|Removed |Added Attachment #1102|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #4 from Matthias Kurz --- Created attachment 1102 --> https://bugs.exim.org/attachment.cgi?id=1102=edit Unfinished patch with idea how to fix Bug 2310 Again, this is just an idea how to fix this - which should give an experienced exim dev a kickstart. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #3 from Jeremy Harris --- We don't do github PRs as a matter of course; please attach your patch to this bug. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #2 from Matthias Kurz --- One last comment to my GitHub pull request/patch: I am not entirely sure, but I think in `queue.c` something like --- extern int acl_where; --- with a value defined in macros.h needs to be set: https://github.com/Exim/exim/blob/07738d610fd70638835db7b12cf158e71a7346e3/src/src/macros.h#L934-L959 (That is how it is done in deliver.c) But again, I am not sure. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 2310] event_action fires/expands with -Mg flag, but not with -Mrm
https://bugs.exim.org/show_bug.cgi?id=2310 --- Comment #1 from Matthias Kurz --- Here is what I came up with to fix that bug: https://github.com/Exim/exim/pull/65 It's not finished (of course) - however I think what I added in queue.c is a good starting point for the work that needs to be done to fix that bug. I think you get the idea. For an experience exim dev it shouldn't take too long to come up with a working patch (hopefully ;) (?) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
