Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
Hi,
On Tue, Oct 13, 2009 at 9:26 PM, Adam Jackson a...@fedoraproject.org wrote:
Author: ajax
Update of /cvs/pkgs/rpms/libXres/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv12383
Modified Files:
.cvsignore libXres.spec sources
Log Message:
* Tue Oct 13 2009 Adam Jackson a...@redhat.com 1.0.4-1
- libXres 1.0.4
Index: .cvsignore
===
RCS file: /cvs/pkgs/rpms/libXres/devel/.cvsignore,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -p -r1.9 -r1.10
--- .cvsignore 6 Jan 2007 00:12:42 - 1.9
+++ .cvsignore 13 Oct 2009 15:56:03 - 1.10
@@ -1 +1 @@
-libXres-1.0.3.tar.bz2
+libXres-1.0.4.tar.bz2
Index: libXres.spec
===
RCS file: /cvs/pkgs/rpms/libXres/devel/libXres.spec,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -p -r1.26 -r1.27
--- libXres.spec 14 Aug 2009 11:13:43 - 1.26
+++ libXres.spec 13 Oct 2009 15:56:03 - 1.27
@@ -1,7 +1,7 @@
Summary: X-Resource extension client library
Name: libXres
-Version: 1.0.3
-Release: 9%{?dist}
+Version: 1.0.4
+Release: 1%{?dist}
License: MIT
Group: System Environment/Libraries
URL: http://www.x.org
@@ -9,9 +9,7 @@ BuildRoot: %{_tmppath}/%{name}-%{version
Source0: ftp://ftp.x.org/pub/individual/lib/%{name}-%{version}.tar.bz2
-BuildRequires: pkgconfig
-BuildRequires: libX11-devel
-BuildRequires: libXext-devel
+BuildRequires: pkgconfig(xext)
%description
X-Resource is an extension that allows a client to query
@@ -21,7 +19,6 @@ the X server about its usage of various
Summary: Development files for %{name}
Group: Development/Libraries
Requires: %{name} = %{version}-%{release}
-Requires: pkgconfig
According to Review Guidelines MUST: Packages containing
pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory
ownership and usability), this should not be removed.
%description devel
X.Org X11 libXres development package
@@ -29,20 +26,14 @@ X.Org X11 libXres development package
%prep
%setup -q
-# Disable static library creation by default.
-%define with_static 0
-
%build
-%configure \
-%if ! %{with_static}
- --disable-static
-%endif
+%configure --disable-static
make %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
-make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
+make install DESTDIR=$RPM_BUILD_ROOT
I think its good to keep timestamps.
# We intentionally don't ship *.la files
rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
@@ -62,15 +53,15 @@ rm -rf $RPM_BUILD_ROOT
%files devel
%defattr(-,root,root,-)
%{_includedir}/X11/extensions/XRes.h
-%if %{with_static}
-%{_libdir}/libXRes.a
-%endif
%{_libdir}/libXRes.so
%{_libdir}/pkgconfig/xres.pc
#%dir %{_mandir}/man3x
%{_mandir}/man3/*.3*
%changelog
+* Tue Oct 13 2009 Adam Jackson a...@redhat.com 1.0.4-1
+- libXres 1.0.4
+
* Thu Aug 13 2009 Parag par...@fedoraproject.org 1.0.3-9
- Merge-review cleanups #226086
Index: sources
===
RCS file: /cvs/pkgs/rpms/libXres/devel/sources,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -p -r1.10 -r1.11
--- sources 6 Jan 2007 00:12:42 - 1.10
+++ sources 13 Oct 2009 15:56:03 - 1.11
@@ -1 +1 @@
-de66ffb657aba64c9d6dbdeabb757f3e libXres-1.0.3.tar.bz2
+4daf91f93d924e693f6f6ed276791be2 libXres-1.0.4.tar.bz2
--
fedora-extras-commits mailing list
fedora-extras-comm...@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-extras-commits
- Parag.
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
On Tue, 2009-10-13 at 22:04 +0530, Parag N(पराग़) wrote:
-BuildRequires: pkgconfig
-BuildRequires: libX11-devel
-BuildRequires: libXext-devel
+BuildRequires: pkgconfig(xext)
%description
X-Resource is an extension that allows a client to query
@@ -21,7 +19,6 @@ the X server about its usage of various
Summary: Development files for %{name}
Group: Development/Libraries
Requires: %{name} = %{version}-%{release}
-Requires: pkgconfig
According to Review Guidelines MUST: Packages containing
pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory
ownership and usability), this should not be removed.
atropine:~% repoquery --whatprovides 'pkgconfig(xext)'
libXext-devel-0:1.0.99.4-3.fc12.i686
atropine:~% repoquery --requires libXext-devel | grep pkg
pkgconfig
pkgconfig(x11)
pkgconfig(xextproto)
So, whatever. Clearly the pkgconfig autorequires are doing the right
thing: -devel packages that provide a .pc file pick up a Requires:
pkgconfig. The guidelines should be fixed.
- ajax
signature.asc
Description: This is a digitally signed message part
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
On Tue, Oct 13, 2009 at 01:21:38PM -0400, Adam Jackson wrote: atropine:~% repoquery --whatprovides 'pkgconfig(xext)' libXext-devel-0:1.0.99.4-3.fc12.i686 atropine:~% repoquery --requires libXext-devel | grep pkg pkgconfig pkgconfig(x11) pkgconfig(xextproto) So, whatever. Clearly the pkgconfig autorequires are doing the right thing: -devel packages that provide a .pc file pick up a Requires: pkgconfig. The guidelines should be fixed. Agreed - do you have time to find out when the pkgconfig autoprovides went into effect and put up a draft on the wiki? Link it to: https://fedoraproject.org/wiki/PackagingDrafts If all Fedora releases have the autoprovides but EL-5 is still affected, the draft can be as simple as: rpm detects pkgconfig dependencies in all Fedora releases, please move the pkgconfig requires from [LINK] to the EPEL specific guidelines. Thanks, -Tosiho pgpzeXxVKdhBH.pgp Description: PGP signature -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
On Tue, 2009-10-13 at 10:32 -0700, Toshio Kuratomi wrote: If all Fedora releases have the autoprovides but EL-5 is still affected, the draft can be as simple as: rpm detects pkgconfig dependencies in all Fedora releases, please move the pkgconfig requires from [LINK] to the EPEL specific guidelines. Done: https://fedoraproject.org/wiki/PackagingDrafts/PkgconfigAutoRequires AFAICT this became automagic in F-10, but I can't find any overt history of that in redhat-rpm-macros. - ajax signature.asc Description: This is a digitally signed message part -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
Adam Jackson wrote, at 10/14/2009 03:20 AM +9:00: On Tue, 2009-10-13 at 10:32 -0700, Toshio Kuratomi wrote: If all Fedora releases have the autoprovides but EL-5 is still affected, the draft can be as simple as: rpm detects pkgconfig dependencies in all Fedora releases, please move the pkgconfig requires from [LINK] to the EPEL specific guidelines. Done: https://fedoraproject.org/wiki/PackagingDrafts/PkgconfigAutoRequires AFAICT this became automagic in F-10, but I can't find any overt history of that in redhat-rpm-macros. - ajax Actually in the change of rpm (not redhat-rpm-config) and from F-11. Note that F-10 rpm also generated pkgconfig related Provides lists, but not Requires list (i.e. adding Requires: pkgconfig and some pkgconfig related Requires list is still needed for F-10 packages, although F-10 is going to be EOL). The example is the following packages. F-11: http://koji.fedoraproject.org/koji/rpminfo?rpmID=1592955 F-10: http://koji.fedoraproject.org/koji/rpminfo?rpmID=1592985 The explanation is: https://www.redhat.com/archives/fedora-devel-list/2008-November/msg02173.html Regards, Mamoru -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
On Tue, 13 Oct 2009 14:20:52 -0400, Adam wrote: On Tue, 2009-10-13 at 10:32 -0700, Toshio Kuratomi wrote: If all Fedora releases have the autoprovides but EL-5 is still affected, the draft can be as simple as: rpm detects pkgconfig dependencies in all Fedora releases, please move the pkgconfig requires from [LINK] to the EPEL specific guidelines. Done: https://fedoraproject.org/wiki/PackagingDrafts/PkgconfigAutoRequires AFAICT this became automagic in F-10, but I can't find any overt history of that in redhat-rpm-macros. If memory serves correctly, the roll-out took place in two steps: 1) Enabling automatic pkgconfig Provides. 2) Enabling automatic pkgconfig Requires. F-10 initially started with only 1 and a later RPM update added 2, but F-11 started with both. -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: rpms/libXres/devel .cvsignore, 1.9, 1.10 libXres.spec, 1.26, 1.27 sources, 1.10, 1.11
Hi, On Tue, Oct 13, 2009 at 11:50 PM, Adam Jackson a...@redhat.com wrote: On Tue, 2009-10-13 at 10:32 -0700, Toshio Kuratomi wrote: If all Fedora releases have the autoprovides but EL-5 is still affected, the draft can be as simple as: rpm detects pkgconfig dependencies in all Fedora releases, please move the pkgconfig requires from [LINK] to the EPEL specific guidelines. Done: https://fedoraproject.org/wiki/PackagingDrafts/PkgconfigAutoRequires AFAICT this became automagic in F-10, but I can't find any overt history of that in redhat-rpm-macros. Thanks all. - Parag. -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
