Re: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit)
Oliver Falk wrote: Hi! Changed the subject, as happens that I oversee the mails :-( And this subject is more descriptive, isn't it? Kyle McMartin wrote: [ ... ] This all looks fine to me. May I interpret this as a *GO*? :-) Sorry to have been so blunt, but I'm fairly new to Fedora, so I didn't know you were actually working on stuff, and not just someone asking for random commit access. Don't worry. I didn't get this wrong. I can understand you where worrying. If I'd be in your position, I would react differently. I wouldn't worry too much about the linux-2.6- namespace for patches, I'd prefer if they were just alpha-$patch.patch. davej, thoughts? Whatever you prefer. Let me know, so I start working on this today... Did I miss the answer to my mail!? -of ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit)
On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote: Oliver Falk wrote: Hi! Changed the subject, as happens that I oversee the mails :-( And this subject is more descriptive, isn't it? Kyle McMartin wrote: [ ... ] This all looks fine to me. May I interpret this as a *GO*? :-) Sorry to have been so blunt, but I'm fairly new to Fedora, so I didn't know you were actually working on stuff, and not just someone asking for random commit access. Don't worry. I didn't get this wrong. I can understand you where worrying. If I'd be in your position, I would react differently. I wouldn't worry too much about the linux-2.6- namespace for patches, I'd prefer if they were just alpha-$patch.patch. davej, thoughts? Whatever you prefer. Let me know, so I start working on this today... Did I miss the answer to my mail!? Sorry, I was on vacation, and it fell off my radar when I got back. Looked ok to commit to me though iirc. I've no really preference on patch naming. If you want to do alpha-*, go ahead. but don't feel that you have to. Dave -- http://www.codemonkey.org.uk ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
[PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*)
The radeon_buffer.c addition that gets pulled into the DRM driver as
part of Kernel Mode Setting (even if you disable KMS for the Radeon
driver) was assuming that it was safe to use symbols from the AGP code,
but that isn't safe on platforms where __OS_HAS_AGP is 0. Such as
sparc64. :)
This patch gets the code building again. It probably should go into the
actual kms patch, but if you would prefer this go as a separate patch, I
can apply it. With this, we can get rawhide building for sparc64, so I'm
eager to see it applied in one way or another.
Signed-off-by: Tom spot Callaway tcall...@redhat.com
diff -up linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c.BAD
linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c
--- linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c.BAD
2009-03-11 09:11:01.0 -0500
+++ linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c 2009-03-11
09:11:27.0 -0500
@@ -37,9 +37,11 @@ struct drm_ttm_backend *radeon_create_tt
{
drm_radeon_private_t *dev_priv = dev-dev_private;
+#if __OS_HAS_AGP
if (dev_priv-flags RADEON_IS_AGP)
return drm_agp_init_ttm(dev);
else
+#endif
return ati_pcigart_init_ttm(dev, dev_priv-gart_info,
radeon_gart_flush);
}
___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*)
On Wed, Mar 11, 2009 at 10:27:51AM -0400, Tom spot Callaway wrote:
The radeon_buffer.c addition that gets pulled into the DRM driver as
part of Kernel Mode Setting (even if you disable KMS for the Radeon
driver) was assuming that it was safe to use symbols from the AGP code,
but that isn't safe on platforms where __OS_HAS_AGP is 0. Such as
sparc64. :)
This patch gets the code building again. It probably should go into the
actual kms patch, but if you would prefer this go as a separate patch, I
can apply it. With this, we can get rawhide building for sparc64, so I'm
eager to see it applied in one way or another.
Signed-off-by: Tom spot Callaway tcall...@redhat.com
diff -up linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c.BAD
linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c
--- linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c.BAD
2009-03-11 09:11:01.0 -0500
+++ linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c
2009-03-11 09:11:27.0 -0500
@@ -37,9 +37,11 @@ struct drm_ttm_backend *radeon_create_tt
{
drm_radeon_private_t *dev_priv = dev-dev_private;
+#if __OS_HAS_AGP
Not that this is your fault, but shouldn't this be something
like __ARCH_HAS_AGP?
josh
___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*)
On 03/11/2009 11:33 AM, Josh Boyer wrote: +#if __OS_HAS_AGP Not that this is your fault, but shouldn't this be something like __ARCH_HAS_AGP? Maybe, but I'm not about to redefine existing kernel defines for the purposes of logic. ;) ~spot ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*)
On Wed, Mar 11, 2009 at 11:55:53AM -0400, Kyle McMartin wrote: On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote: +#if __OS_HAS_AGP Not that this is your fault, but shouldn't this be something like __ARCH_HAS_AGP? Keep in mind the DRM for better or for worse supposedly supports more OSes than just Linux. I had blissfully forgotten that. I suspect the 'ideal' fix for upstream is to stub out drm_agp_init_ttm on !CONFIG_AGP arches. Yeah, something like that. josh ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*)
On Wed, 2009-03-11 at 11:55 -0400, Kyle McMartin wrote: On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote: +#if __OS_HAS_AGP Not that this is your fault, but shouldn't this be something like __ARCH_HAS_AGP? Keep in mind the DRM for better or for worse supposedly supports more OSes than just Linux. I suspect the 'ideal' fix for upstream is to stub out drm_agp_init_ttm on !CONFIG_AGP arches. OS_HAS_AGP is just a wrapper around convoluted CONFIG_AGP, CONFIG_AGP_MODULE. Its perfectly acceptable to build a kernel with no AGP and DRM enabled on x86. Dave. regards, Kyle ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
