[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 02:17 EST --- Well, http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/xtide.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/xtide-2.9-0.10.dev20061015.src.rpm should fix all the issues that needs fixing. Please check. (In reply to comment #47) Others are ignorable W: xtide strange-permission tideEditor-wrapper.sh 0755 W: xtide dangling-relative-symlink /usr/share/icons/hicolor/48x48/apps/xtide.png ../../../../xtide/icon_48x48_orig.png W: xtide dangling-relative-symlink /usr/share/icons/hicolor/16x16/apps/xtide.png ../../../../xtide/icon_16x16_orig.png W: tcd-utils dangling-relative-symlink /usr/share/icons/hicolor/16x16/apps/tideEditor.png ../../../../xtide/icon_16x16_orig.png W: tcd-utils dangling-relative-symlink /usr/share/icons/hicolor/48x48/apps/tideEditor.png ../../../../xtide/icon_48x48_orig.png By the way, these warning are avoided once we install this and execute rpmlint for *INSTALLED* rpm, for example, rpmlint xtide. * spec is not very legible, with tons of macros and building of 3-4 different programs with different build systems. Well, I leave it for now though this is a bit complicated... the guidelines break with desktop-file-utils-0.11-1.fc7. Maybe desktop-file-utils will change. - the package which install in hicolor could depend on hicolor-icon-theme for directory ownership, but this is not very clear to whether this is really right since it adds an otherwise unneeded dependency to a lot of packages. Well, there is a agreement that hicolor-icon-theme can be treated as something like filesystem rpm. Actually trying to remove hicolor-icon-theme (by yum) also tries to remove lots of packages (even gtk2). (In reply to comment #48) xttpd: * initscript should return 2 as Usage error return code. Well, I checked some init scripts in /etc/rc.d/init.d and usually they return the value 1 so I use 1. * With default install, it is very quiet: . I hope the updated init script (and wrapper shell script) should fix this problem. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211711] Review Request: ren - tool to rename many files at once according to search and replacement patterns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ren - tool to rename many files at once according to search and replacement patterns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211711 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 04:16 EST --- Built for devel, FC-[56]. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196591] Review Request: bitlbee
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bitlbee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196591 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 04:21 EST --- 20335 (bitlbee): Build on target fedora-development-extras succeeded. 20336 (bitlbee): Build on target fedora-6-extras succeeded. 20337 (bitlbee): Build on target fedora-5-extras succeeded. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 04:29 EST --- Please respect http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 06:02 EST --- The xttpd start script don't do what I would have expected. Indeed when PORT is not set I don't get any error message, only a failed error (ÉCHOUÉ means FAILED): # /etc/init.d/xttpd start Starting xttpd:[ÉCHOUÉ] Nothing appears in logs (a grep PORT in /var/log/* /var/log/*/* don't return anything). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 06:31 EST --- Created an attachment (id=139451) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=139451action=view) alternative xttpd to write It seems that initlog is commented out so nothing is written in any logs. The attached xttpd writes the error message to stderr. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201418] Review Request: widelands - GPL Settlers II clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: widelands - GPL Settlers II clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201418 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 09:22 EST --- Okay, no problem and good to hear from you. Next time please keep in touch, even it is just to say that you currently cannot work on a package for whatever reasons. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 09:25 EST --- Well, please check the attachment in my comment #51 ? If it is okay, I will replace xttpd.init with the attachment. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xtide - Calculate tide all over the world
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626
--- Additional Comments From [EMAIL PROTECTED] 2006-10-26 09:32 EST ---
It works better now, but I am not convinced that it is
the proper fix. I don't see why you need to send the
echo output on STDERR? It works the same without redirection?
Anyway redirection to log should be done explicitely. So
if you want errors to be logged, I guess you should call
logger yourself.
And also it seems that failure should be used instead of echo_failure
since it does something when with rhgb (show details).
Moreover I think the [ FAILED ] should appear before the explanation.
It leads to the following code:
if test -z $PORT ; then
failure
echo
echo $PORT environment is not set.
RETVAL=1
return $RETVAL
Another remark is that I think having HOME defaulting to /root is wrong,
it should be set to a directory below sysconfig, for example
%{_sysconfig}/xtide. And I am not completly convinced that using
nobody as a user is the right thing to do, maybe a specific user
would be better.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 09:37 EST --- (In reply to comment #49) Maybe desktop-file-utils will change. Indeed this is rawhide breakage. Either the guidelines or desktop-file-utils should be updated. Well, there is a agreement that hicolor-icon-theme can be treated as something like filesystem rpm. Actually trying to remove hicolor-icon-theme (by yum) also tries to remove lots of packages (even gtk2). I am not sure that there is such agreement. But as I said it is acceptable, since it is not clear what is the right way to do. As a side note, gtk2 isn't a package that is always installed (on a server, if using fluxbox, or using X apps only through ssh). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212045] Review Request: eclipse-emf - Eclipse Modeling Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-emf - Eclipse Modeling Framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212045 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 10:02 EST --- I'm seeing this error: + aot-compile-rpm --exclude '/usr/share/eclipse/plugins/org.eclipse.emf.doc_*/doc.zip' aot-compile-rpm: error: /var/tmp/eclipse-emf-2.2.1-1-root-fitzsim/usr/share/eclipse/plugins/org.eclipse.emf.doc_*/doc.zip: path does not exist or is not a job error: Bad exit status from /var/tmp/rpm-tmp.11823 (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.11823 (%install) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xtide - Calculate tide all over the world
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626
--- Additional Comments From [EMAIL PROTECTED] 2006-10-26 10:09 EST ---
(In reply to comment #53)
Indeed this is rawhide breakage. Either the guidelines or
desktop-file-utils should be updated.
Jesse Keating commented on fedora-extras-list.
https://www.redhat.com/archives/fedora-extras-list/2006-October/msg00722.html
It works better now, but I am not convinced that it is
the proper fix. I don't see why you need to send the
echo output on STDERR?
Simply because I wanted to send to stderr because it is a error.
Removing.
And also it seems that failure should be used instead of echo_failure
since it does something when with rhgb (show details).
Okay.
Moreover I think the [ FAILED ] should appear before the explanation.
It leads to the following code:
if test -z $PORT ; then
failure
echo
echo $PORT environment is not set.
RETVAL=1
return $RETVAL
My recognition is that usually OK of FAILED appears at the last
and the location of failure should be under the explanation.
Another remark is that I think having HOME defaulting to /root is wrong,
it should be set to a directory below sysconfig, for example
%{_sysconfig}/xtide.
Okay.
And I am not completly convinced that using
nobody as a user is the right thing to do, maybe a specific user
would be better.
Well, for this I will reply later.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 10:15 EST --- Also you want to have Requires: redhat-artwork as Echo (currently) falls back to Bluecurve. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212045] Review Request: eclipse-emf - Eclipse Modeling Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-emf - Eclipse Modeling Framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212045 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 10:54 EST --- (In reply to comment #4) I'm seeing this error: + aot-compile-rpm --exclude '/usr/share/eclipse/plugins/org.eclipse.emf.doc_*/doc.zip' aot-compile-rpm: error: /var/tmp/eclipse-emf-2.2.1-1-root-fitzsim/usr/share/eclipse/plugins/org.eclipse.emf.doc_*/doc.zip: path does not exist or is not a job Yeah, I fixed that and I *finally* got my mock setup working again (down mirrors). I've got a build going now that I think fixes that and one other error. I'll re-post when it finishes in mock. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:08 EST --- Well, I leave failure function below echo $PORT environment is not set. I tried to change nobody to xttpd. Check: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/xtide.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/xtide-2.9-0.11.dev20061015.src.rpm (In reply to comment #54) Maybe desktop-file-utils will change. Indeed this is rawhide breakage. Either the guidelines or desktop-file-utils should be updated. Well, discussion seems to be proceeding to the direction that X-Fedora should be removed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211629] Review Request: hatari - An Atari ST emulator suitable for playing games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hatari - An Atari ST emulator suitable for playing games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211629 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:11 EST --- Hi, I see you've imported this, but haven't requested a build yet, may I ask why? With FE things are not like Dribble where Ian does all the building, with FE we've got an automated buildsys, but you must instruct it to build, see: http://fedoraproject.org/wiki/Extras/Contributors#head-0956b12959af46cfe0aa12d09ed15e573bfd9ef4 and: http://fedoraproject.org/wiki/Extras/Contributors#head-e2f7f3048aae892d69bba2b1d1563aed5c63a1ff -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192434] Review Request: compiz-quinn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compiz-quinn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192434 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:29 EST --- I've pushed 0.1.1 updates for all previously built beryl components (and will work on a beryl-dbus package when I get the chance). Also, I'm closing this bug as a dupe of the beryl-core one, please use that bug or the respective beryl sub-package bugs for any further discussion on beryl. *** This bug has been marked as a duplicate of 209259 *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 209259] Review Request: beryl-core - Beryl OpenGL window and compositing manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beryl-core - Beryl OpenGL window and compositing manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209259 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:29 EST --- *** Bug 192434 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 209263] Review Request: emerald - Themeable window decorator and compositing manager for Beryl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emerald - Themeable window decorator and compositing manager for Beryl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209263 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:39 EST --- Just pushed out a 0.1.1-1 build. http://wilsonet.com/packages/beryl/emerald-0.1.1-1.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 209262] Review Request: beryl-plugins - Beryl OpenGL window and compositing manager plug-ins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beryl-plugins - Beryl OpenGL window and compositing manager plug-ins https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209262 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:40 EST --- Just pushed out a 0.1.1-1 build. http://wilsonet.com/packages/beryl/beryl-plugins-0.1.1-1.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 209261] Review Request: beryl-settings - Beryl OpenGL window and compositing manager GUI config utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beryl-settings - Beryl OpenGL window and compositing manager GUI config utility https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209261 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:40 EST --- Just pushed out a 0.1.1-1 build: http://wilsonet.com/packages/beryl/beryl-settings-0.1.1-1.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 209260] Review Request: beryl-manager - Beryl window decorator and theme management utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beryl-manager - Beryl window decorator and theme management utility https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209260 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:44 EST --- Aurelien, can you double-check if that patch is still required for beryl-manager 0.1.1? I've just pushed out a 0.1.1 build, but don't have an FC5 machine handy at the moment, nor the time to get one mocked up. :) http://wilsonet.com/packages/beryl/beryl-manager-0.1.1-1.fc6.src.rpm As for the compiz integration (comment #2), I believe we should have inherited that same support by moving to 0.1.1 (will double-check when I have a chance). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 209264] Review Request: emerald-themes - Themes for Emerald, the window decorator for Beryl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emerald-themes - Themes for Emerald, the window decorator for Beryl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209264 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:45 EST --- Just pushed a 0.1.1 build out: http://wilsonet.com/packages/beryl/emerald-themes-0.1.1-1.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211711] Review Request: ren - tool to rename many files at once according to search and replacement patterns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ren - tool to rename many files at once according to search and replacement patterns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211711 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:56 EST --- You're welcomed... You should close the bug with resolution NEXTRELEASE, now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 210823] Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: wxsvg - wxSVG is C++ library to create, manipulate and
render SVG files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210823
--- Additional Comments From [EMAIL PROTECTED] 2006-10-26 11:57 EST ---
$ rpmlint wxsvg-1.0b7-1.src.rpm
W: wxsvg summary-not-capitalized wxSVG is C++ library to create,
manipulate and render SVG files.
W: wxsvg summary-ended-with-dot wxSVG is C++ library to create,
manipulate and render SVG files.
Better:
Summary: C++ library to create, manipulate and render SVG files
Repeating the package name in the summary is often considered bad
style, because it either leads to poor summaries or raises questions
not answered in the summary. For a more detailed description, there
is the package %description field, where you can explain acronyms and
other things, too.
E: wxsvg no-description-tag
It must not be empty.
W: wxsvg invalid-license wxWindows Library Licence, Version 3
This needs a second look, since the project is named wxWidgets for
a long time.
Now a brief look at the spec file:
Version:1.0b7
Release:1%{?dist}
You should take a look at the pre-release versioning scheme, which
makes it possible that you can go from 1.0b7 to 1.0:
Version:1.0
Release:0.1.b7%{?dist}
Requires: wxGTK
Not needed and ought to be deleted. Rely on rpmbuild's automatic
dependencies on the library SONAMEs your built files are linked
against.
%package devel
Missing Requires: wxGTK-devel since the wxSVG headers include
wxGTK headers.
Requires: %{name} = %{version}
Ought to be
Release: %{name} = %{version}-%{release}
so your package-set is always in sync (even if in many cases,
%{version} may be sufficient actually). This strict requirement is
particularly useful when patches are applied. Assume what happens
when the main package is permitted to be older than the -devel package.
The -devel package mentions fixes in its %changelog, but the main
package is not up-to-date and suffers from problems at build-time
or run-time. Or vice versa.
%build
./autogen.sh
Try to get the upstream developers to pregenerate these files, which
is what they ought to do for every release, regardless of whether it's
beta or not. Then you would not be missing automake and friends, which
might be wrong versions.
%files
%defattr(-,root,root,-)
%doc
No %doc files? At least the license file ought to be included.
Possibly also a few of the available text files.
%files devel
[...]
%{_includedir}/wxSVG/*.h
%{_includedir}/wxXML/*.h
The directories are not included. Use either:
%{_includedir}/wxSVG/
%{_includedir}/wxXML/
Or:
%dir %{_includedir}/wxSVG/
%{_includedir}/wxSVG/*.h
%dir %{_includedir}/wxXML/
%{_includedir}/wxXML/*.h
%{_libdir}/libwxsvg.a
%{_libdir}/libwxsvg.la
If these cannot be disabled, delete them in %install.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211629] Review Request: hatari - An Atari ST emulator suitable for playing games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hatari - An Atari ST emulator suitable for playing games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211629 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 12:02 EST --- I know. I was studing the Extras/Contributors doc very carefully. I haven't done it yet because I requested branches for FC5 and FC6 and not only devel. I had to wait for this. I just sow that my request has been completed. I think I'll be able to request a build soon. I'm really busy right now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora Core Status|NEW |ASSIGNED Component|Package Review |Package Review AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 13:08 EST --- Actually we want Echo to be the default in Rawhide which right now means it needs to go into Core. So I'm changing product to Core and claiming ownership of this bug. Hope to have it in Rawhide soon! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202528] Review Request: rt2x00-kmod
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rt2x00-kmod https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202528 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 13:59 EST --- Where are you pulling the stack from? Is it straight from wireless-dev? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202528] Review Request: rt2x00-kmod
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rt2x00-kmod https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202528 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 14:02 EST --- You d80211 packages seem to come straight from the rt2x00 project. I think you should have a clean extract of the code from wireless-dev if you are doing to create a d80211 package. A d80211 package ought to be driver-agnostic, not tied to the rt2x00 driver. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212045] Review Request: eclipse-emf - Eclipse Modeling Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-emf - Eclipse Modeling Framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212045 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 14:12 EST --- (In reply to comment #5) Yeah, I fixed that and I *finally* got my mock setup working again (down mirrors). I've got a build going now that I think fixes that and one other error. I'll re-post when it finishes in mock. Okay, I think this one will work: Spec URL: http://overholt.ca/eclipse/eclipse-emf.spec SRPM URL: http://overholt.ca/eclipse/eclipse-emf-2.2.1-1.src.rpm It built in mock with --no-clean (I didn't want to wait for an entire run) and the regular run is going now. I anticipate no problems with that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 208898] Review Request: bluez-gnome -- Bluetooth pairing and control applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bluez-gnome -- Bluetooth pairing and control applet https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208898 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 14:33 EST --- than, do you know what the status of autostart compliance is in kde right now? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211711] Review Request: ren - tool to rename many files at once according to search and replacement patterns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ren - tool to rename many files at once according to search and replacement patterns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211711 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 14:39 EST --- Great thanks, David. Following the comments, I have renamed the spec file and cleaned up to follow Packaging Guidelime. SPEC: http://www.thefinalzone.com/RPMS/echo-icon-theme.spec SRPM: http://www.thefinalzone.com/RPMS/echo-icon-theme-0.1-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211629] Review Request: hatari - An Atari ST emulator suitable for playing games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hatari - An Atari ST emulator suitable for playing games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211629 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 14:58 EST --- Build succeded on FC5 and FC6. It failed on devel because of bug #212350. When it will be corrected, I'll request a new build for devel. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212045] Review Request: eclipse-emf - Eclipse Modeling Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-emf - Eclipse Modeling Framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212045 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 15:04 EST --- (In reply to comment #6) It built in mock with --no-clean (I didn't want to wait for an entire run) and the regular run is going now. I anticipate no problems with that. It completed without problems in a regular mock run. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 15:29 EST --- We have generally not added a gtk2 dependency for running gtk-update-icon-cache in other packages, and the packaging guidelines also discourage it. The description should be one or more complete sentences. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 15:32 EST --- Also, it should not be too hard to find a safe %defattr mask -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 15:34 EST --- and own the root dir (%dir) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 15:51 EST --- (In reply to comment #9) We have generally not added a gtk2 dependency for running gtk-update-icon-cache in other packages, and the packaging guidelines also discourage it. Should I add coreutils Requires(post) and Requires(postun)? I looked to the link posted on comment #5 and noticed coreutils is omitted. The description should be one or more complete sentences. Fixed (In reply to comment #10) Also, it should not be too hard to find a safe %defattr mask Not sure how to proceed as I haven't touched that line for awhile. Could you give an example? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 16:13 EST --- I'm not a sponsor, so I can't do an official review, but a couple things jump out at me: 1. find-external-requires is a script Does that mean it needs to be transported in the SRPM +x'd? Can't it be set 644 and chmod'd +x in the conditional that points __find_requires at it? (I suspect yes.) There's (rarely? never?) a reason to have a file +x in the SRPM, they can usually be corrected during the prep/build/install process. 3. Macro in changelog is an entry from 2003 relating to a valid change. I don't feel comfortable changing it without clarification Neither would I. However, escaping it as %%attr both preserves the history (shows up as %attr in --changelog) and shuts rpmlint up about it. ;-) Minor tweaks, I wouldn't bother respinning unless you have more important fixes to add. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |188267 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 16:59 EST --- It looks pretty good to me. There isn't much point in including the %build section since it's empty, though, is there? In core packages we don't normally add the Requires(pre) and Requires(post) for gtk2. instead we only run it gtk-update-icon-cache if it's available. On the other hand, since you Require redhat-artwork and it requires gtk2, then I think the pre and post are right, because you're going to end up with gtk2 installed anyway, and if that's the case then you want to make sure it gets installed early enough in the transaction. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|188267 |188268 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 17:15 EST --- I wouldn't leave the comment in there about coreutils. coreutils is just expected to be available. Anyway, it looks pretty good. David, feel free to build it and close the bug report. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: echo-icon-thme - Echo icon theme
Alias: echo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256
--- Additional Comments From [EMAIL PROTECTED] 2006-10-26 17:42 EST ---
1. still missing the root dir ownership, will leave dangling dirs when removed.
Please add %dir %{_datadir}/icons/Echo (not too fond of using caps in names BTW)
2. a lot of people like to keep %build, if only to document it was intentionaly
left empty (also I think in some cases pulling it triggers rpm bugs)
3. explicitly copying LICENSE is not necessary, %doc does it for you
4. I would recommend keeping any gtk2 dep out - much better to have a clean spec
people can safely copy. Evetyone will forget why Echo was special soonish
(please add a comment before the redhat-artwork dep)
5. when copying static data it's usually better to preserve original timestamps
[shameless style preference plug, feel free to ignore)
6. you should know it's possible to replace $RPM_BUILD_ROOT with a leaner
%{buildroot}
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 210787] Review Request: php-pear-XML-Serializer - Swiss-army knife for reading and writing XML files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-XML-Serializer - Swiss-army knife for reading and writing XML files Alias: pear-XML-Serializer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210787 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 17:57 EST --- No problem, thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 210788] Review Request: php-pear-Date-Holidays - Driver based class to calculate holidays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Date-Holidays - Driver based class to calculate holidays Alias: pear-Date-Holidays https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210788 Bug 210788 depends on bug 210787, which changed state. Bug 210787 Summary: Review Request: php-pear-XML-Serializer - Swiss-army knife for reading and writing XML files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210787 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 18:47 EST --- OK, I'm going to import this http://people.redhat.com/davidz/echo-icon-theme.spec http://people.redhat.com/davidz/echo-icon-theme-0.1-6.srpm which takes the advice from comment 17 into advice (except for the gtk2 dep). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 18:48 EST --- OK, I'm going to import this http://people.redhat.com/davidz/echo-icon-theme.spec http://people.redhat.com/davidz/echo-icon-theme-0.1-6.src.rpm which takes the advice from comment 17 into advice (except for the gtk2 dep). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211626] Review Request: xtide - Calculate tide all over the world
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 19:01 EST --- * Regarding the user, I'd prefer a patch such that it doesn't silently fail if the user name change or something along (at least in the code, in the documentation, I don't care). * Requires(pre): /sbin/nologin isn't needed, useradd don't fail even if the shell don't exist and it is in util-linux. useradd I don't know. Maybe it is needed for proper ordering, but it is not obvious since rpm depends on it. * xttpd user may be deleted at the uninstall since he shouldn't own any directory (nor any file). * Regarding the init file, if you want to have the message on the same line that the 'starting message', no problem but currently there is an additional end of line, so it isn't clear what failed. In my opinion, the code should be (added -n for the first echo) echo -n $PORT environment is not set. failure echo RETVAL=1 return $RETVAL * from a look at the code it seems that the group isn't changed, it should be. And also if setuid fails, there is only a log, the program should exit. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 19:39 EST --- It's now in Core dist CVS and will appear in Rawhide when it's added to dist-fc7. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198836] Review Request: freetype1 compatibility FreeType 1.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freetype1 compatibility FreeType 1.x https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 20:18 EST --- *** Bug 212488 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 20:27 EST --- Hey Nick, a package doesn't have to use %dir to take ownership of a directory. If the directory is listed in the file list (without any globs after it) then it implies %dir (and also implies adding a /* glob) I agree with everything else you said, I think, except for 6 because both methods are equivalent and most core packages use the $RPM_BUILD_ROOT syntax. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212502] New: Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212502 Summary: Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/Chatbot-Eliza/ OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com SRPM URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza-1.04-1.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza.spec Description: This module implements the classic Eliza algorithm. The original Eliza program was written by Joseph Weizenbaum and described in the Communications of the ACM in 1966. Eliza is a mock Rogerian psychotherapist. It prompts for user input, and uses a simple transformation algorithm to change user input into a follow-up question. The program is designed to give the appearance of understanding. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212502] Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212502 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||163776 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212503] New: Review Request: perl-WWW-Babelfish - Perl extension for translation via Babelfish or Google
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212503 Summary: Review Request: perl-WWW-Babelfish - Perl extension for translation via Babelfish or Google Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/WWW-Babelfish/ OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com SRPM URL: http://home.comcast.net/~ckweyl/perl-WWW-Babelfish-0.15-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-WWW-Babelfish.spec Description: Perl interface to the WWW babelfish translation server. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212503] Review Request: perl-WWW-Babelfish - Perl extension for translation via Babelfish or Google
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-WWW-Babelfish - Perl extension for translation via Babelfish or Google https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212503 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||163776 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 22:22 EST --- package added to collection with davidz as the owner. Usually the bug stays open until the package has actually been built into a collection. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 22:33 EST --- Thanks. I've just built the package into dist-fc7 so it should appear in Rawhide tomorrow. Sorry about closing the bug early. For the Cc's that have been tracking this bug: I'll do the libgnome changes tomorrow as to switch Rawhide over to using Echo by default. Yay! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212256] Review Request: echo-icon-thme - Echo icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: echo-icon-thme - Echo icon theme Alias: echo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256 --- Additional Comments From [EMAIL PROTECTED] 2006-10-26 23:36 EST --- (In reply to comment #15) There isn't much point in including the %build section since it's empty, though, is there? Theoretically no. Practically yes, %build is a must even if it's empty, to work-around bugs in redhat-rpm-config and rpm. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212513] New: Review Request: sparse - source code semantec parser used by the Linux kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212513 Summary: Review Request: sparse - source code semantec parser used by the Linux kernel Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://domsch.com/linux/fedora/extras/sparse/sparse.spec SRPM URL: http://domsch.com/linux/fedora/extras/sparse/sparse-0-0.1.20061026git.src.rpm Description: Sparse is a semantic parser of source files: it's neither a compiler (although it could be used as a front-end for one) nor is it a preprocessor (although it contains as a part of it a preprocessing phase). It is meant to be a small - and simple - library. Scanty and meager, and partly because of that easy to use. It has one mission in life: create a semantic parse tree for some arbitrary user for further analysis. It's not a tokenizer, nor is it some generic context-free parser. In fact, context (semantics) is what it's all about - figuring out not just what the grouping of tokens are, but what the _types_ are that the grouping implies. Sparse is primarily used in the development and debugging of the Linux kernel. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185325] Review Request: sparse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sparse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185325 [EMAIL PROTECTED] changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2006-10-27 01:09 EST --- *** This bug has been marked as a duplicate of 212513 *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 212513] Review Request: sparse - source code semantec parser used by the Linux kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sparse - source code semantec parser used by the Linux kernel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212513 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||t --- Additional Comments From [EMAIL PROTECTED] 2006-10-27 01:09 EST --- *** Bug 185325 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
