[Bug 214087] Review Request: libextractor -- Simple library for keyword extraction

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libextractor -- Simple library for keyword extraction


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214087





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 03:21 EST ---
Well, 

(In reply to comment #8)
  * For main package:
  --
  Requires:   plugin(%name)
  --
What I meant was main package (libextract) should require at least
base plugin package (libextract-plugins-base).  

 I do not think so:
 
 1. libextract works without plugins too. But because output is very
limited in this case, you can say that plugins are highly recommended
(*not* required)
 
 2. libextract does not require the -plugins-base plugins but works
e.g. with the thumbnail plugin when e.g. a collection of images
shall be indexed
 
 Therefore, I use
 Requires: plugin(%name)
 
 which satisfies 1. and allows users to install only the really needed
 plugins (2.).

My biggest worry is that when libextractor requires
plugin(libextractor), I cannot tell in advance which package this
Requires actually pulls to satisfy this dependency
because plugin(libextractor) is provided more than one package.

... For me, this always pulls a same package:
-
[EMAIL PROTECTED] i386]# yum --disablerepo=\*debug\* --disablerepo=\*dries\*
--disablerepo=\*freshrpms\* install libextractor
Loading installonlyn plugin
Setting up Install Process
Setting up repositories
Reading repository metadata in from local files
Parsing package install arguments
Resolving Dependencies
-- Populating transaction set with selected packages. Please wait.
--- Package libextractor.i386 0:0.5.16-2.fc7 set to be updated
-- Running transaction check
-- Processing Dependency: plugin(libextractor) for package: libextractor
-- Restarting Dependency Resolution with new changes.
-- Populating transaction set with selected packages. Please wait.
--- Package libextractor-plugins-pdf.i386 0:0.5.16-2.fc7 set to be updated
-- Running transaction check

Dependencies Resolved

=
 Package Arch   Version  RepositorySize 
=
Installing:
 libextractori386   0.5.16-2.fc7 LOCAL  70 k
Installing for dependencies:
 libextractor-plugins-pdf  i386   0.5.16-2.fc7 LOCAL 131 k

Transaction Summary
=
Install  2 Package(s) 
Update   0 Package(s) 
Remove   0 Package(s) 

Total download size: 201 k
Is this ok [y/N]: N
Exiting on user Command
Complete!
-

however, 
* I am not sure if yum always pulls -pdf package for everyone
* and I am not sure if pulling -pdf package is what you expect
  if yum always pulls -pdf package.

If there is no best idea as of what plugins main package should
require for a minimal usage, you may want to remove plugin requirement
as before. My idea is requiring -plugins-base package is 
convenient for libextractor users. How do you think?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219962] Review Request: crystal-clear - Crystal Clear KDE Icon set

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crystal-clear - Crystal Clear KDE Icon set


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219962





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 03:30 EST ---
(In reply to comment #7)
 Quick update
 Included tarball and upstream tarball md5sum matches 
 adb7962b585c8ad12adc3b82246edb35  CrystalClear.tar.gz
 
 According to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=389499, you also
 need to replace firefox.png icon or remove it while installing.
 Thanks for giving this link Chitlesh.

I've asked in the FE mailing list to see what they think of it, since I've once
read that its only trademarks by the authors, however this is an icon set. The
situation might be different.

 I have one question, how to check that a given individual icon is LGPL/GPL or
 non-LPGL. Do you know about this? 
 Also where is LGPL written? I mean no license text is added in RPM


see the commented link below the url:
http://www.kde-look.org/content/show.php?content=25668
 
 Also,
 URL: http://linuxcult.com/node/10 is not working.
 

Ok, I'll use http://www.everaldo.com/crystal.html as URL


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218176] Review Request: gchempaint - A 2D chemical formulae drawing tool

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gchempaint - A 2D chemical formulae drawing tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218176


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209214] Review Request: libprelude - Prelude library collection

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libprelude - Prelude library collection


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209214





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 05:47 EST ---
ok, here we go:

* config is _now_ in /etc/prelude
* perl-modules are now in vendor_perl instead of site_perl
* unnecessary files were deleted 
* package does not own /usr/share/aclocal anymore
* automake is a new Requirement for libprelude-devel
* language bindings are in separated packages now

sponsors?

new package is here:
http://people.redhat.com/tscherf/fedora-extra/libprelude-0.9.12-2.src.rpm
http://people.redhat.com/tscherf/fedora-extra/libprelude.spec


   

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203864] Review Request: tripwire - IDS

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 06:07 EST ---
Thank you, too. Good work. Remember to close this as RESOLVED NEXTRELEASE when
it builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 214087] Review Request: libextractor -- Simple library for keyword extraction

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libextractor -- Simple library for keyword extraction


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214087





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 07:04 EST ---
* I think, it is a bug in yum. It should fail on such ambiguities instead of
  using the short-name-wins method

* I see the following two solutions:

  1. abuse yum's (mis)behavior and add a

 | Provides: plugin(%name)

 to 'libextractor-plugins' package. This will pull in all available
 plugins (because 'libextractor-plugins' is the shortest package name and
 wins therefore).

 This will not address problems with smart or apt.

  2. remove the 'Requires: plugin(%name)' accordingly your suggestion and add a 
 README.fedora which explains that user has to install additional plugin
 packages

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220217] Review Request: perl-Test-Spelling - Check for spelling errors in POD files

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Spelling - Check for spelling errors in POD 
files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 07:12 EST ---
Thanks for the review.

Package imported and built for FC-5, FC-6, and devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220218] Review Request: perl-Module-Find - Find and use installed modules in a (sub)category

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-Find - Find and use installed modules in a 
(sub)category


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220218


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 07:12 EST ---
Thanks for the review.

Package imported and built for FC-5, FC-6, and devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219931] Review Request: perl-Net-GPSD - Provides an object client interface to the gpsd server daemon

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-GPSD - Provides an object client interface to 
the gpsd server daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219931


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 07:15 EST ---
Thanks for the review.

Package imported and built for FC-5, FC-6, and devel (with the typo corrected).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 08:14 EST ---
(In reply to comment #2)
 Issues:
 
 1. Whats with the commented line in the files section?
 #%{_libexecdir}/xfce4/panel-plugins/%{name}

This is the new location of xfce4-panel plugins. Hopefully with the next version
 libsmarbookmark.so will be moved from %{_libdir}/xfce4/panel-plugins to
%{_libexecdir}/xfce4/panel-plugins. When all panel plugins are _fully_ ported to
the new panel plugin API you can drop %{_libdir}/xfce4/panel-plugins from you
xfce4-panel package.

 2. Your desktop file needs desktop-file-install:

Really? I always thought this was only for applications that show up in the main
menu. This desktop file only appears in the Add Items to the Panel dialog. I
think in this case there's not need to install the file with
desktop-file-install, because we don't need to modify it (--add-category,
--vendor etc.).

Think of your xfce-utils package, which installs xfce4.desktop in
/usr/share/xsessions or of all the files installed under /etc/xdg/autostart by
xfce4-session and others. None of these packages uses desktop-file-install.

 3. This package provides:
 libsmartbookmark.so
 Is that correct? Or should that be filtered?

IMO it is correct, but useless.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 214087] Review Request: libextractor -- Simple library for keyword extraction

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libextractor -- Simple library for keyword extraction


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214087





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 08:16 EST ---
I think the latter (No.2) of your suggestion is better
if you feel no reluctance to write README.fedora .

Pulling all plugins is not preferable if this package can
be used without plugins IMO.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel 
based applets inside the Xfce4 one


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 08:24 EST ---
(In reply to comment #2)
 Issues:
 
 1. The summary seems a bit odd to me:
 A plugin to use gnome-panel based applets inside the Xfce4 one
 How about:
 A plugin to use gnome-panel based applets inside the Xfce4 panel

Thanks, will change that. As I'm not a native english speaker, I wouldn't have
recognized this.

 2. Your desktop file needs desktop-file-install:

As I said in Bug #219986 Comment #3 I don't think so. Quoting from the 
guidelines:
This is mostly for the sake of menu-editing (which bases off of .desktop
file/path names).
... but nothing in the Add Items to the Panel dialog can be edited.

BTW: Is the above sentence from the guidelines correct? bases OFF OF .desktop
file sounds strange to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 09:40 EST ---
(In reply to comment #3)

  3. This package provides:
  libsmartbookmark.so
  Is that correct? Or should that be filtered?
 
 IMO it is correct, but useless.

I think that it is incorrect, but harmless. And not worth taking care
of it manually in fedora, it should be handled
* upstream, by not providing the useless soname (which certainly means
  changing libtool)
* at the rpm level, by automatically adding sonames only for sonames
  in %_libdir and directories searched for by ldd

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 09:59 EST ---
(In reply to comment #4)

 I think that it is incorrect, but harmless. And not worth taking care
 of it manually in fedora, it should be handled
 * upstream, by not providing the useless soname (which certainly means
   changing libtool)
 * at the rpm level, by automatically adding sonames only for sonames
   in %_libdir and directories searched for by ldd

I can certainly talk to upstream about the first, but the second needs to be
fixed in rpm. As we all know rpm is about to change a lot in the near future, so
I don't think that this will be fixed soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203864] Review Request: tripwire - IDS

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 10:19 EST ---
Build successfully in devel and FC6 branch requested

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218020] Review Request: postgrey - Postfix Greylisting Policy Server

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgrey - Postfix Greylisting Policy Server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218020


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 11:16 EST ---
I'll review this Matthias.  (Fair warning: it's my first review, so if anyone
else wants to jump in and make sure it's done right, it will be welcome.)


* rpmlint runs without errors on the srpm (just a few warnings)

  $ rpmlint postgrey-1.27-3.src.rpm 
  W: postgrey strange-permission postgrey.init 0755
  W: postgrey setup-not-quiet

These warnings are minor and easily silenced with the addition of -q to %setup
and chmod'ing postgrey.init.  Neither of them are blockers as far as I know. 
Anyone know differently?

* Adheres to naming guidelines
* Specfile name matches package name
* Meets the packaging guidelines

The perl(IO::Multiplex) Requires seems unneeded.  RPM automatically picks up
perl(Net::Server::Multiplex) which is provided by the perl-Net-Server package
and perl-Net-Server requires perl-IO-Multiplex.

* License meets open-source requirements
* License included in %doc
* License field matches the upstream license
* Specfile is in American English
* Specfile is legible
* Source matches upstream (md5sum: df3a8b4a0c6ab7e8e5bb5be0de096c47)
* Builds, installs, and works on FC6, i386
* Owns directories that it creates
* Does not own files or dirs of other packages
* File list has no duplicates
* File perms are generally sane

Why is /var/spool/postfix/postgrey 0751?  I don't see anything in the postgrey
docs about the need to have such tight permissions on the dbdir.  Can you
enlighten me?

* Specfile includes %clean section
* Macros used consistently
* Package contains code or permissable content
* Builds in mock against fedora-{5,6,development}-i386-core targets
* Scriplets are sane
* Package functions correctly (tested on FC6)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 11:51 EST ---
ok, on item 1, perhaps a comment above that line explaining that the plugin will
move there someday?

on item 2, sorry about that. I saw .desktop and didn't look as closely as I
should have. I agree that desktop-file-install is unneeded. 

on item 3, yeah, mentioning it to upstream would probibly be a good idea. 
I wonder if the new rpm.org has a 'wishlist' page we could add that idea to?

I don't see any further issues... so this package is APPROVED. 

Don't forget to close this NEXTRELEASE once it's been imported and built. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel 
based applets inside the Xfce4 one


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 11:54 EST ---
Yeah, desktop-file-install isn't needed here. Sorry about that. 

Oddly, that sentence is ok. English is a weird language. ;) 

I don't see any further blockers here, so this package is APPPROVED. 
You can fix the summary on import. 

Don't forget to close this NEXTRELEASE once it's been imported and built. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192313] Review Request: koan

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: koan


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192313


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192313] Review Request: koan

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: koan


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192313





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 11:57 EST ---
Oops .. sorry; totally slipped through teh cracks. I did ACCEPT the package;
changed blocker to FE-ACCEPT now

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220630] New: Review Request: qpidc - C++ implementation of AMQP messaging spec from Apache Qpid. Upstream for Red Hat Messaging.

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220630

   Summary: Review Request: qpidc - C++ implementation of AMQP
messaging spec from Apache Qpid. Upstream for Red Hat
Messaging.
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: 
http://people.apache.org/dist/incubator/qpid/M1-incubating/cpp/qpidc.spec
SRPM URL: 
http://people.apache.org/dist/incubator/qpid/M1-incubating/cpp/qpidc-0.1-1.src.rpm
Description: First time submitter, need a sponsor.

Background: C++ implementation of the AMQP messaging specification 
(http://amqp.org/) from Apache Qpid project (http://incubator.apache.org/qpid). 
This is the upstream for the Red Hat Messaging project hosted at 
https://etp.108.redhat.com. I will submit an RPM for 108 stuff shortly.

%description 
Run-time libraries for AMQP client applications developed using Qpid
C++. Clients exchange messages with an AMQP message broker using
the AMQP protocol.

%description devel
Libraries, header files and documentation for developing AMQP clients
in C++ using Qpid.  Qpid implements the AMQP messaging specification.

%description -n qpidd
A message broker daemon that receives stores and routes messages using
the open AMQP messaging protocol.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 12:21 EST ---
(In reply to comment #6)
 ok, on item 1, perhaps a comment above that line explaining that the plugin 
 will
 move there someday?

Ok, will do after import.

 I wonder if the new rpm.org has a 'wishlist' page we could add that idea to?

rpm.org is under construction ATM, they don't have a whishlist nor bugzilla.
On http://wiki.rpm.org/ReportingBugs Jesse suggests to file bugs in Fedora's
bugzilla for now.

Thanks for the review, Kevin!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 12:29 EST ---
(In reply to comment #5)

 I can certainly talk to upstream about the first,

I don't think it is worth it, since it is libtool which drives
the link, and (to my knowledge) there is no way to prevent libtool
to add a soname. It is also possible that I am wrong and that a 
soname is needed even if it has no practical use.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220630] Review Request: qpidc - C++ implementation of AMQP messaging spec from Apache Qpid. Upstream for Red Hat Messaging.

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qpidc - C++ implementation of AMQP messaging spec from 
Apache Qpid. Upstream for Red Hat Messaging.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220630


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 207846] Review Request: perl-Finance-YahooQuote - Perl interface to get stock quotes from Yahoo! Finance

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Finance-YahooQuote - Perl interface to get stock 
quotes from Yahoo! Finance
Alias: finance-YahooQuote

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207846


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 12:36 EST ---
This package is currently approved for FC7+ only.

mod_perl-2.0.3-3 must be built for FC6/FC5 before branching to those releases.

See bug #197841 for more information.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220635] New: Review Request: livecd-tools - Tools for creating Live CD's

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220635

   Summary: Review Request: livecd-tools - Tools for creating Live
CD's
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/davidz/livecd/spec/livecd-tools.spec
SRPM URL: http://people.redhat.com/davidz/livecd/src/livecd-tools-001-1.src.rpm 
Description: Tools for generating live CD's on Fedora based systems including
derived distributions such as RHEL, CentOS and others. See
http://fedoraproject.org/wiki/FedoraLiveCD for more details.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220637] New: Review Request: fedora-livecd - This package defines the contents of Fedora live CD's

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220637

   Summary: Review Request: fedora-livecd - This package defines the
contents of Fedora live CD's
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/davidz/livecd/spec/fedora-livecd.spec
SRPM URL: http://people.redhat.com/davidz/livecd/src/fedora-livecd-6-1.src.rpm 
Description: This package defines the contents of Fedora live CD's.

The three RPM's from this SRPM is used by the livecd-tools package to create 
Fedora specific live CD's. See bug 220635 for livecd-tools review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198836] Review Request: freetype1 compatibility FreeType 1.x

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freetype1 compatibility FreeType 1.x


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||163779




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 15:53 EST ---
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189195] Review Request: horde - php application framework

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: horde - php application framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 16:03 EST ---
I urge caution in trying to add symbols that might satisfy whatever CentOS is
doing; this package won't cleanly replace that one since it puts the config
files under /usr/share/horde.

We're very nearly done here; I just need to run through my checklist and
double-check everything.  Unfortunately holiday issues keep intruding; I really
hope to have it done today.

Regarding how the various consumers of the Horde infrastructure store their
files, I think it's rather expected that, say, IMP files show up under the Horde
directory and changing that would break various user expectations.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220577] Review Request: imp - webmail

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: imp - webmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220577


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189195] Review Request: horde - php application framework

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: horde - php application framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 16:48 EST ---
Don't push yourself; it's Christmas!  I'll be in and out until Tuesday anyway,
so no need to rush.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218600] Review Request: resapplet - Resolution Switching Applet

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: resapplet - Resolution Switching Applet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218600


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220637] Review Request: fedora-livecd - This package defines the contents of Fedora live CD's

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fedora-livecd - This package defines the contents of 
Fedora live CD's


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220637





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 17:57 EST ---
I note that all three packages generated from this spec own /etc/livecd, and
ownership of a single directory by multiple packages is generally something to
be avoided.  Since there's a clear dependency chain (fedora-livecd is required
by the two subpackages), the base package should probably own it and the others
shouldn't.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the 
Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 17:57 EST ---
Build on target fedora-development-extras succeeded.
 Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-development-extras/24429-xfce4-smartbookmark-plugin-0.4.2-1.fc7/

Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel 
based applets inside the Xfce4 one


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 18:09 EST ---
(In reply to comment #4)
 Oddly, that sentence is ok. English is a weird language. ;) 

No, it's not _that_ weird, German is even worse for non native speakers I 
think. :)

Glad to have English spell-checking in Firefox 2.0 now.

 You can fix the summary on import. 

Done.

 Don't forget to close this NEXTRELEASE once it's been imported and built. 

Done. Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220635] Review Request: livecd-tools - Tools for creating Live CD's

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: livecd-tools - Tools for creating Live CD's


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220635


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 18:23 EST ---
#1: Rpmlint's output isn't clean

chitlesh(SPECS)[0]$rpmlint
/home/chitlesh/rpmbuild/RPMS/i386/livecd-tools-001-1.i386.rpm
E: livecd-tools statically-linked-binary /usr/lib/livecd-creator/run-init
chitlesh(SPECS)[0]$rpmlint
/home/chitlesh/rpmbuild/RPMS/i386/livecd-tools-debuginfo-001-1.i386.rpm
E: livecd-tools-debuginfo empty-debuginfo-package

#2: Parallel build is missing

#3: BuildRoot tag should be fixed according to FE guidelines


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for 
the Audacious media player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: audacious- |Review Request: audacious-
   |itouch - iTouch keyboard  |itouch - iTouch keyboard
   |control plugin for the  |control plugin for the
   |Audacious media player |Audacious media player
  BugsThisDependsOn||163776




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for 
the Audacious media player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|163776  |
OtherBugsDependingO||163776
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 19:45 EST ---
yes it looks like the piedmont.homelinux.org server is down again.

Brian email me the spec and src.rpm and I can host them for you.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189188] Review Request: sqlgrey - postfix grey-listing policy service

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sqlgrey - postfix grey-listing policy service


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189188


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 19:54 EST ---
Imported, branches (finally) created, and builds requested.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 20:28 EST ---
Here you go, these urls are live.

http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine-0.3.16-1.src.rpm
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220683] New: Review Request: rubygems - the Ruby standard for packaging ruby libraries

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220683

   Summary: Review Request: rubygems - the Ruby standard for
packaging ruby libraries
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygems.spec
SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygems-0.9.0-1.src.rpm
Description: RubyGems is the Ruby standard for publishing and managing third 
party 
libraries.

NOTE: While the guidelines currently don't allow packaging of ruby gems, this 
package is *not* a gem, it contains the libraries/utilities needed to deal with 
gems, and is packaged like any other ruby package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 207685] Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for farsight protocol

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for 
farsight protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207685


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |63778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220185] Review Request: kvm - Kernel Based Virtual Machine

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kvm - Kernel Based Virtual Machine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220185


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 207685] Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for farsight protocol

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for 
farsight protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207685


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|63778   |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 21:19 EST ---

GOOD:
*Built in mock on i386 against fedora-development
*rpmlint runs cleanly against it
*follows naming guidelines for addon packages
*licnese is GPL and spec tag matches
*COPYING file in %doc
*spec in US/english and legible
*Include source matches upstream md5sum
77c92554c2bd57ad1b426e5ba50eb9a8  gst-plugins-farsight-0.10.2.tar.gz
*buildrequires look good
*no locales to worry about
*only gstreamer plugin so's no shared libs in default linker path
*not relocatable
*does not create any unowned directories. Package requires   
  gstreamer-plugins-base which in turns requires gstreamer which owns 
  /usr/lib/gstreamer-0.10
*no duplicates in %files
*file permissions seem fine
*install and clean sections look good
*macro use is consistent
*docs is good
*no -devel subpackage
*la files removed in install section
*not a gui, no desktop file needed
*appears to meet all packaging guidelines


One small thing I'd like to see changed. Can you rename the macro at from
majorminor to gst_majorminor?  I was slightly confused initially because its the
same numerical value as the package version majorminor. Its clear now its a
macro to define the gstreamer majorminor, but it would be helpful for clarity to
change the name to gst_majorminor.  This is not a blocker however, but it may
help save a little time if someone has to pick this package up from you later.

This package is APPROVED for entry into the development tree.


I haven't tested this yet, I'm be building stream-engine next so I can test 
this. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 21:27 EST ---
Uhm looks like they bumped up to 0.3.18 in the meantime.

Would you like me to spin up an updated srpm and spec for 0.3.18 and place them
on the website for you?

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 22:41 EST ---
thanks to python 2.5 now in the development tree you'll need a new 
Buildrequires: python-devel

You'll find the updated srpm and spec  which builds against current
fedora-development here:

http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-twisted-web/python-twisted-web-0.6.0-4.src.rpm
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-twisted-web/python-twisted-web.spec

I've also included the LICENSE and NEWS fileas as %doc and updated the URL tag
as suggested in the review comment



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 22:50 EST ---
URL updated
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine-0.3.18-1.src.rpm

I will be starting the formal review of 0.3.18 srpm tonite as time allows.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 23:32 EST ---
It looks good. Here is the formal review.
I'm going to start a clock on this, and if noone brings up any blockers I'll
approve tomorrow evening.

-jef

GOOD:
*Built in mock on i386 against fedora-development
*rpmlint runs cleanly against it
*follows naming guidelines
*licnese is LGPL and spec tag matches
*COPYING file in %doc
*spec in US/english and legible
*Include source matches upstream md5sum
52c0b48905f11cac71df1f8560c8f4d7  telepathy-stream-engine-0.3.18.tar.gz

*buildrequires look good
*no locales to worry about
*no shared libraries
*not relocatable
*does not create any unowned directories. Package requires   
  libdbus-1.so.3 which is provided by dbus which owns 
  %{_datadir}/dbus-1/services/
*no duplicates in %files
*file permissions seem fine
*install and clean sections look good
*macro use is consistent
*docs is good
*no -devel subpackage
*no la files
*not a gui, no desktop file needed
*appears to meet all packaging guidelines



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 00:27 EST ---
Well, 
* please check if the following is what you expect.
---
checking for pic2plot... no
checking for gs... no
checking for convert... no
configure: WARNING: Imagemagick not found, drawing sequence diagrams will be
disabled.
configure: WARNING: Ghostscript not found, drawing sequence diagrams will be
disabled.
configure: WARNING: GNU plotutils not found, drawing sequence diagrams will be
disabled.

Note: all of them are available in Fedora Core/Extras and
a people who has already installed them beforehand may create
different binary rpm of telepathy-stream-engine.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 01:16 EST ---
Yes, this was on purpose since the sequence diagrams generation support isn't
complete yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 02:29 EST ---
Okay, then this package can be approved IMO.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review