[Bug 209222] Review Request: prelude-lml - Prelude log analyzer

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prelude-lml - Prelude log analyzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209222





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 03:27 EST ---
Well, for prelude-lml:

* -devel package issues
  - First of all, is this package of any sense?
I don't know how only installing one header file without
providing any .so symlink libraries can be used for any
other applications.

For example, /usr/include/prelude-lml/prelude-lml.h contains

const char *lml_log_entry_get_message(const lml_log_entry_t *log_entry);

However, to what library should I actually link to use
this function *lml_log_entry_get_message ?


  The other things are:
- prelude-lml.h includes:
-
#include libprelude/prelude.h
#include libprelude/prelude-log.h
-
This means that -devel package should need
Requires: libprelude-devel

- The description of Requires is wrong.

* BuildRequires:
--
BuildRequires:  libprelude, libprelude-devel, pcre-devel  
--
  - libprelude is not necessary
  - mockbuild log says:
--
snip
checking for pcre-config... /usr/bin/pcre-config
checking for pcre_get_named_substring in -lpcre... yes
checking fam.h usability... no
checking fam.h presence... no
checking for fam.h... no
checking for FAMOpen in -lfam... no
checking whether FILENAME_MAX is declared... yes
checking for an ANSI C-conforming const... yes
snip
*** Dumping configuration ***
- Enable FAM support: no
- Enable unsupported rulesets:  : yes
+ make
snip
--
Why is FAM support disabled? NOTE: fam.h is included in
gamin-devel.

* For debuginfo issue:
  - Mockbuild log says:
---
+ rm -f
/var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild//usr/lib/prelude-lml/debug.la
+ rm -f
/var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild//usr/lib/prelude-lml/pcre.la
+ /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/prelude-lml-0.9.8.1
extracting debug info from
/var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild/usr/bin/prelude-lml
extracting debug info from
/var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild/usr/lib/prelude-lml/pcre.so
extracting debug info from
/var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild/usr/lib/prelude-lml/debug.so
cpio: prelude-lml-0.9.8.1/src/.libs/prelude-lmlS.c: No such file or directory -
THIS LINE
377 blocks
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-compress
+ /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
---
The description of THIS LINE means that a needed file for debugging
this package is missing and this should be fixed.

Again mockbuild log says
---
creating .libs/prelude-lmlS.c
(cd .libs  gcc  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -c -fno-builtin prelude-lmlS.c)
rm -f .libs/prelude-lmlS.c .libs/prelude-lml.nm .libs/prelude-lml.nmS
.libs/prelude-lml.nmT
---
rm -f .libs/prelude-lmlS.c is wrong and this should not be done.

* Documentation
  - Some %doc files are encoded with non-UTF-8 encodings. Please
change to UTF-8.
---
/usr/share/doc/prelude-lml-0.9.8.1/ChangeLog:  ISO-8859 English text
/usr/share/doc/prelude-lml-0.9.8.1/NEWS:   ISO-8859 English text
---

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209215] Review Request: libpreludedb - Provides an abstraction layer for the libprelude

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libpreludedb - Provides an abstraction layer for the 
libprelude


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209215


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 08:12 EST ---
Gawain, so what do we do make sure firefox15 profile is not modified? firefox2
IMHO must be completely parallel-installable (e.g. separate home-dirs for both
firefox15 and firefox2) IMHO, otherwise it's unsuitable for Extras

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220968] Review Request: scigraphica - Scientific application for data analysis and technical graphics

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scigraphica - Scientific application for data analysis 
and technical graphics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 08:17 EST ---
NO.

scigraphica should own the libdir and libscigraphica should add to it - NOT the
other way around!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 08:43 EST ---
FYI firefox2-2.0.0.1-2.1.fc6.src.rpm builds just fine on FC6/x86_64.

Thanks.
-  Gilboa

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 09:08 EST ---
(In reply to comment #26)
 Gawain, so what do we do make sure firefox15 profile is not modified? firefox2
 IMHO must be completely parallel-installable (e.g. separate home-dirs for both
 firefox15 and firefox2) IMHO, otherwise it's unsuitable for Extras

IT is not an elegant solution, but the .desktop file uses the -ProfileManager
switch.

I'm not sure that we can automatically create another profile and copy
everything over.  If some one else has some pointers on if/how this can be done,
I would love to hear about it.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221084] New: Review Request: dkms - Dynamic Kernel Module Support

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221084

   Summary: Review Request: dkms - Dynamic Kernel Module Support
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://domsch.com/linux/fedora/extras/dkms/dkms.spec
SRPM URL: 
http://download.fedora.redhat.com/pub/fedora/linux/extras/development/SRPMS/dkms-2.0.13-1.fc6.src.rpm
Description: 
This package contains the framework for the Dynamic
Kernel Module Support (DKMS) method for installing
kernel module RPMS.


DKMS has been included in Fedora Extras since March 15, 2005, though we 
couldn't find a formal review ticket for it.  Gary Lerhaupt, Matt Domsch, and 
Tom Callaway all reviewed the spec at that time prior to its importation.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220888] Review Request: fakeroot - Gives a fake root environment

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fakeroot - Gives a fake root environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220888





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 09:30 EST ---
Spec URL: http://dl.atrpms.net/all/fakeroot.spec
SRPM URL: http://dl.atrpms.net/all/fakeroot-1.5.10-12.at.src.rpm

* Sun Dec 31 2006 Axel Thimm [EMAIL PROTECTED] - 1.5.10-12
- Add %%{_libdir}/libfakeroot to %%files.
- Add %%check.

* Fri Dec 29 2006 Axel Thimm [EMAIL PROTECTED] - 1.5.10-11
- Extend the %%description a bit.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 09:31 EST ---
(In reply to comment #28)
 IT is not an elegant solution, but the .desktop file uses the -ProfileManager
 switch.

heh, that's why I missed it -- I started firefox2 from the command line :-(

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220890] Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcdaudio - Control operation of a CD-ROM when 
playing audio CDs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220890





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 09:33 EST ---
Spec URL: http://dl.atrpms.net/all/libcdaudio.spec
SRPM URL: http://dl.atrpms.net/all/libcdaudio-0.99.12p2-8.at.src.rpm

* Fri Dec 29 2006 Axel Thimm [EMAIL PROTECTED] - 0.99.12p2-8
- Change Group tag.
- Fix libcdaudio-config for libdir != %%{_prefix}/lib.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220945] Review Request: perl-Text-CharWidth - Get number of occupied columns of a string on terminal

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-CharWidth - Get number of occupied columns 
of a string on terminal


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220945





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 09:42 EST ---
Too bad, that would had been a nice addition to rpmlint. Anyway even more thanks
for spotting this with eyeballs. :)

Spec URL: http://dl.atrpms.net/all/perl-Text-CharWidth.spec
SRPM URL: http://dl.atrpms.net/all/perl-Text-CharWidth-0.04-2.at.src.rpm

* Sat Dec 30 2006 Axel Thimm [EMAIL PROTECTED] - 0.04-2
- Add ownership of some perl folders.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 09:50 EST ---
Please consider also upgrade paths to F?7, a firefox2 user in FC6 would be
rather annoyed finding his half year old profile imported over instead of what
this package would maintain. And this kind of upgrade path would only be
possible from the main ff package.

E.g. in any case Chris cooperation is a must for this package
(Obsoleting/Providing this package and catering for collecting user data) and if
he gets that much involved, then perhaps it would be more worth to him to issue
an ff2 update for FC6?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220967] Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libscigraphica - A library of gtk+ widgets for 
SciGraphica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 10:08 EST ---
Well,

(In reply to comment #7)
 (In reply to comment #6)
  Unsure:
  Does the -devel need ldconfig to be run?
 I believe the package guildline says it has to be done 
 for the package and its
 subpackage that contains a *.so.
It is not necessary. As when you try ldconfig -v and it returns like:
-
libGL.so.1 - libGL.so.1.2
-
ldconfig checks libraries with somajor if the library has 
somajor/sominor. and .so files are not (necessary to be) checked.

(In reply to comment #8)
 The scigraphica directory must belong to the 
 application and not the library.
Umm.. Ownership distribution between libraries - applications is
of second importance or less.

First of all, all directories created during installation must
belong to some package. You can install libscigraphica without
any applications which may use this library. %{_libdir}/scigraphica/
_must_ be owned by this package.

There are other issues.
--
/usr/share/aclocal/libscigraphica-2.0.m4
--
This should be in -devel package and owning aclocal m4 files means
-devel package should need Requires: automake

libscigraphica-2.0.pc says:
---
Requires: glib-2.0 gtk+-2.0 gtkextra-2.0
---
This means that -devel package should require -devel 
as well as pkgconfig (Please check Requires section of
http://fedoraproject.org/wiki/Packaging/Guidelines)

And.. this package contains many documentations (xml/header files,
etc) and image files and keeping timestamps on these files 
are strongly recommended. Please keep timestamps on these files.
(I have not tried, however for many cases
-
make DESTDIR=%{buildroot} INSTALL=%{__install} -c -p install
--
works.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220968] Review Request: scigraphica - Scientific application for data analysis and technical graphics

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scigraphica - Scientific application for data analysis 
and technical graphics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 10:25 EST ---
Please correct libscigraphica first.

Apparently
---
BuildRequires:  gtk2-devel gtk+extra-devel
BuildRequires:  pkgconfig
---
This should be required by libscigraphica-devel, not by
BuildRequires of this package.


%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

This is not necessary because no libraries installed
by this package are installed under default path on which
ldconfig tries to search.

(In reply to comment #5)
 NO.
 scigraphica should own the libdir and libscigraphica 
 should add to it - NOT the
 other way around!
See my comments on bug 220967.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 215241] Review Request: thunar-archive-plugin - Archive plugin for the Thunar file manager

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thunar-archive-plugin - Archive plugin for the Thunar 
file manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215241





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 11:05 EST ---
Yes, I'll do the formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221027] Review Request: LabPlot - Data Analysis and Visualization

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LabPlot - Data Analysis and Visualization


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 11:14 EST ---
Updated
Spec URL: http://tux.u-strasbg.fr/~chit/LabPlot/LabPlot.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/LabPlot/LabPlot-1.5.1.5-1.src.rpm

changelog
- New stable release 1.5.1.5
- Fixed symlink-should-be-relative rpmlint issues
- Removed numerous entries on kmenu
- Added examples in a new -doc package
- Building pdf handbook for different languages
- Breaking down -doc package for different languages

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220889] Review Request: fakechroot - Gives a fake chroot environment

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fakechroot - Gives a fake chroot environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220889


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209217] Review Request: libpreludedb-mysql - mysql plugin for libpreludedb

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  libpreludedb-mysql - mysql plugin for libpreludedb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE
 CC||[EMAIL PROTECTED]
OtherBugsDependingO|163776  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 12:00 EST ---
This package is now a subpackage of libpreludedb.

*** This bug has been marked as a duplicate of 209215 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209215] Review Request: libpreludedb - Provides an abstraction layer for the libprelude

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libpreludedb - Provides an abstraction layer for the 
libprelude


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209215





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 12:00 EST ---
*** Bug 209217 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209224] Review Request: prelude-manager - Prelude Management server

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prelude-manager - Prelude Management server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209224


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219915] Review Request: kio_resources - Kio_resources provides the resources protocol for KDE

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kio_resources - Kio_resources provides the resources 
protocol for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219915


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 12:07 EST ---
I'll review this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219915] Review Request: kio_resources - Kio_resources provides the resources protocol for KDE

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kio_resources - Kio_resources provides the resources 
protocol for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219915


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 12:24 EST ---
Pretty simple and straight-forward.
* builds in mock environment.
* MUST: SOURCE matches upstream

APPROVED.

I'll leave these up to you to consider:
* SHOULD: Summary shouldn't include pkg name (ie, don't include Kio_resources)
* SHOULD: Description is too long, imo.  Could probably omit 2nd paragraph.

 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219915] Review Request: kio_resources - Kio_resources provides the resources protocol for KDE

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kio_resources - Kio_resources provides the resources 
protocol for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219915





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 12:39 EST ---
Thanks Rex :)

* Mon Jan 01 2007 Chitlesh Goorah chitlesh [AT] fedoraproject DOT org - 0.2-2
- Removed package name from summary
- Fixed description, since it was too long

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220889] Review Request: fakechroot - Gives a fake chroot environment

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fakechroot - Gives a fake chroot environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220889


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 12:56 EST ---
Well,

A. From http://fedoraproject.org/wiki/Packaging/Guidelines
=  Licensing -- is not LGPL and this is correct

* Use rpmlint
-
W: fakechroot doc-file-dependency /usr/share/doc/fakechroot-2.5/ldd.fake
/usr/bin/perl

-
   Well.. I understood first when I read the following.
-
doc-file-dependency :
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.
-

   For this package, 
-
[EMAIL PROTECTED] ~]$ rpm -q --requires fakechroot
/bin/sh  
/usr/bin/perl  - THIS
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.1.1)  
libc.so.6(GLIBC_2.1.3)  
libc.so.6(GLIBC_2.3.4)  
libc.so.6(GLIBC_2.4)  
libdl.so.2  
libdl.so.2(GLIBC_2.0)  
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rtld(GNU_HASH)  
--
and /usr/bin/perl is actually not necessary.
When I all changed the permission of %doc files
to 0644,
--
[EMAIL PROTECTED] i386]$ rpm -qp --requires fakechroot-2.5-11.1.i386.rpm 
/bin/sh  
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.1.1)  
libc.so.6(GLIBC_2.1.3)  
libc.so.6(GLIBC_2.3.4)  
libc.so.6(GLIBC_2.4)  
libdl.so.2  
libdl.so.2(GLIBC_2.0)  
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rtld(GNU_HASH)  

and the dependency for /usr/bin/perl disappears.

Change the permission of %doc files to 0644.
(However, I think this is somewhat bug of rpmbuild?)

B. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
   = This is okay, except for written in A.

Please fix the issues in A. Other things are okay.

   This package (fakechroot) is APPROVED by me.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220889] Review Request: fakechroot - Gives a fake chroot environment

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fakechroot - Gives a fake chroot environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220889





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 13:01 EST ---
(In reply to comment #6)
 A. From http://fedoraproject.org/wiki/Packaging/Guidelines
 =  Licensing -- is not LGPL and this is correct

I meant Licensing -- is now LGPL and this is correct

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220967] Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libscigraphica - A library of gtk+ widgets for 
SciGraphica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 13:18 EST ---
Another issue.
--
+ make
make  all-recursive
make[1]: Entering directory `/builddir/build/BUILD/libscigraphica-2.1.1'
Making all in pixmaps
make[2]: Entering directory `/builddir/build/BUILD/libscigraphica-2.1.1/pixmaps'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/builddir/build/BUILD/libscigraphica-2.1.1/pixmaps'
Making all in scigraphica
make[2]: Entering directory 
`/builddir/build/BUILD/libscigraphica-2.1.1/scigraphica'
Making all in widgets
make[3]: Entering directory
`/builddir/build/BUILD/libscigraphica-2.1.1/scigraphica/widgets'
if /bin/sh ../../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I.
-I../../pixmaps -I../../scigraphica -I../../scigraphica/dialogs
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12  
-I/usr/include/gtkextra-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2
-I/usr/include/libpng12-I/usr/include/python2.5 -I/usr/include/python2.
5/Numeric/ -DWITH_NUMERIC_PYTHON-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
-mtune=generic -fasynchronous-unwind-tables -g -O -W -Wall -DWITH_WARNINGS -MT
gtkplotart.lo -MD -MP -MF .deps/gtkplotart.Tpo \
.

This means that gcc optimizes this code finally by -O, not
-O2? If so, this should be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220967] Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libscigraphica - A library of gtk+ widgets for 
SciGraphica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 13:21 EST ---
(In reply to comment #9)

 
 (In reply to comment #8)
  The scigraphica directory must belong to the 
  application and not the library.
 Umm.. Ownership distribution between libraries - applications is
 of second importance or less.
 
 First of all, all directories created during installation must
 belong to some package. You can install libscigraphica without
 any applications which may use this library. %{_libdir}/scigraphica/
 _must_ be owned by this package.

So Paul what do think about this? I actually know people that use libscigraphica
without needing scigraphica.
 
 There are other issues.
 --
All fixed.
Happy new year to one and all.

Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/libscigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/libscigraphica-2.1.1-4.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220968] Review Request: scigraphica - Scientific application for data analysis and technical graphics

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scigraphica - Scientific application for data analysis 
and technical graphics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 13:22 EST ---

With fixes,
Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-3.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 212974] Review Request: aspell-ar - Word list/dictionaries for Arabic

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aspell-ar - Word list/dictionaries for Arabic


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212974





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 15:00 EST ---
Any news with this package?

I've already seen it in Debian. I'll be happy to see it in Fedora as well.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 212974] Review Request: aspell-ar - Word list/dictionaries for Arabic

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aspell-ar - Word list/dictionaries for Arabic


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212974





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 15:47 EST ---
I'm pasting a part of a private mail between me and Dan, at his request. 

On Mon, Jan 01, 2007 at 09:53:49PM +0200, Lior Kaplan wrote:
  
  About the spec file - why do you manually edit the Makefile instead of
  running ./configure during %build ?
  
  and in %install
  $(MAKE) DESTDIR=$(DEB_DESTDIR) install
  
  $(DEB_DESTDIR) has the path for the debian package build root.
  
  I think it will look much more cleaner with these changes.

Suggestions are based on aspell-ar package from Debian (which I maintain with
others).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 211763] Review Request: jikes - Java source to bytecode compiler

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jikes - Java source to bytecode compiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211763


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||149781




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220889] Review Request: fakechroot - Gives a fake chroot environment

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fakechroot - Gives a fake chroot environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220889


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
  Component|915resolution   |Package Review




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 16:12 EST ---
Thanks for the review! Final changelog entry:

* Mon Jan  1 2007 Axel Thimm [EMAIL PROTECTED] - 2.5-12
- Remove executable bits from scripts in documentation.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221045] Review Request: gtk-rezlooks-engine - Rezlooks GTK2 engine

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-rezlooks-engine - Rezlooks GTK2 engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221045





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 16:52 EST ---
Removed the Rezlooks-Aerials theme since it required an extra metacity theme and
icon theme.

New spec url is the same as the old one.
New SRPM url: http://www.krakoa.dk/fedora/gtk-rezlooks-engine-0.6-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220766] Review Request: ScientificPython - a collection of Python modules that are useful for scientific computing

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ScientificPython -  a collection of Python modules 
that are useful for scientific computing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220766


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 17:02 EST ---
(In reply to comment #15)
 fixed and built in the development tree, awaiting signing.

Thanks for the great work Jef, would you push this package for FC6 too?






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220766] Review Request: ScientificPython - a collection of Python modules that are useful for scientific computing

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ScientificPython -  a collection of Python modules 
that are useful for scientific computing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220766





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 17:05 EST ---
Soon it will be, Terje :)
http://fedoraproject.org/wiki/Extras/CVSSyncNeeded

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189830] Review Request: xmms-scrobbler - Audioscrobbler plugin for XMMS

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmms-scrobbler - Audioscrobbler plugin for XMMS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189830


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: xmms-   |Review Request: xmms-
   |scrobber - Audioscrobbler   |scrobbler - Audioscrobbler
   |plugin for XMMS |plugin for XMMS




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 17:38 EST ---
Fix typo.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221108] New: Review Request: openarena - first person shooter

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221108

   Summary: Review Request: openarena - first person shooter
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://ecik.nonlogic.org/openarena/openarena.spec
SRPM URL: http://ecik.nonlogic.org/openarena/openarena-0.6.0-1.src.rpm
Description:
OpenArena is an open-source content package for Quake III Arena licensed under
the GPL, effectively creating a free stand-alone game.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209222] Review Request: prelude-lml - Prelude log analyzer

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prelude-lml - Prelude log analyzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209222





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 17:49 EST ---
concerning the debuging thing I got the following information from upstream:

This is the way automake+libtool handle building the program. More
specifically, this is related to the handling of pre-opened modules.
You will notice similar behavior with prelude-manager, but this is all
generated libtool code.

because of the missing .so symlink libraries in the -devel I got this:

The prelude-lml.h header provide the necessary API for contributor to
write LML plugins. The function (*lml_log_entry_get_message, used in your
example) is a public function available from the LML core. Plugin loaded by
LML have access to LML public symbols. 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178922] Review Request: asterisk - The Open Source PBX

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asterisk - The Open Source PBX


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178922





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 21:26 EST ---
1.4 final shouldn't be that different from the last beta.  Hopefully I'll have
new SRPMS up in a day or so.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220967] Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libscigraphica - A library of gtk+ widgets for 
SciGraphica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 21:39 EST ---
(In reply to comment #10)
 Another issue.

 5/Numeric/ -DWITH_NUMERIC_PYTHON-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
 -mtune=generic -fasynchronous-unwind-tables -g -O -W -Wall -DWITH_WARNINGS -MT
 gtkplotart.lo -MD -MP -MF .deps/gtkplotart.Tpo \
 .
 
 This means that gcc optimizes this code finally by -O, not
 -O2? If so, this should be fixed.
This is caused by the configure scripts assuming it building a CVS checkout (the
developers have enabled some extra debugging options for CVS builds, and
mistakingly shipped a configure script generated in a CVS checkout).
Regenerating the configure script should have worked, but it failed because some
expected file are not shipped in the released package.
I've fixed it and some other issues I noticed while looking at this.

Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/libscigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/libscigraphica-2.1.1-5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220968] Review Request: scigraphica - Scientific application for data analysis and technical graphics

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scigraphica - Scientific application for data analysis 
and technical graphics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 21:44 EST ---
I discovered building this package (as is in last spec) fails when
python-numarry is installed. This is because the configure script is kinda
confused by python-numarry and python-numeric both providing 'arrayobject.h'.
This is resolved in this build.

Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-4.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209222] Review Request: prelude-lml - Prelude log analyzer

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prelude-lml - Prelude log analyzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209222





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 22:07 EST ---
(In reply to comment #7)
 concerning the debuging thing I got the following information from upstream:
 
 This is the way automake+libtool handle building the program. More
 specifically, this is related to the handling of pre-opened modules. You
will notice similar behavior with prelude-manager, but this is all
 generated libtool code.

Then? actually .libs/prelude-lmlS.o is used in prelude-lml as
--
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=g
eneric -fasynchronous-unwind-tables -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-declarations -Wbad-function-cast -Wcast-qual -Wcast-align
-Wnested-externs -Wunused -o prelude-lml -pthread .libs/prelude-lmlS.o
prelude-lml.o udp-server.o regex.o log-entry.o log-source.o log-plugins.o
lml-options.o file-server.o lml-alert.o -Wl,--export-dynamic  -L/usr/lib
-lprelude -lgnutls -lgcrypt -lgpg-error -lrt -ldl -lpcre
../libmissing/.libs/libmissing.a
--
and debugging prelude-lml actually needs prelude-lmlS.c, so
prelude-lmlS.c should not be removed.

 because of the missing .so symlink libraries in the -devel I got this:
 
 The prelude-lml.h header provide the necessary API for contributor to
 write LML plugins. The function (*lml_log_entry_get_message, used in your
 example) is a public function available from the LML core. Plugin loaded by
 LML have access to LML public symbols. 

Well, then what library actually provides *lml_log_entry_get_message?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220967] Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libscigraphica - A library of gtk+ widgets for 
SciGraphica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 22:41 EST ---
Well, some minor things and issues.

Minor:
* BuildRequies
  pkgconfig, gtk2-devel is not necessary. These are (finally) required
  by gtk+extra-devel

? Group: Development/Libraries (main)
  Usually Development is used for -devel package and the
  group of this type is System Environment/Libraries.

Should be fixed:
* %{_datadir}/pixmaps/%{name}/
  is not owned by any package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221059] Review Request: cowsay - configurable speaking/thinking cow

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cowsay - configurable speaking/thinking cow


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 22:58 EST ---
Actually I know this application because I use this
for cowsaver, one of hacks which can be used for xscreensaver.

I will review this.

* Use cp -p to keep timestamps (Timestamps in
  http://fedoraproject.org/wiki/Packaging/Guidelines )

* Please fix the description of man package according to
  installed paths.

* How about randomize a cow which is choosen?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221059] Review Request: cowsay - configurable speaking/thinking cow

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cowsay - configurable speaking/thinking cow


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 23:05 EST ---
Created an attachment (id=144618)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=144618action=view)
wrapper script I use to randomize cowsay

c.f.

animalsay, which I use for cowsaver to randomize
animal used by cowsay.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219972] Review Request: poker-network - A poker server, client and abstract user interface library

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: poker-network - A poker server, client and abstract 
user interface library
Alias: poker-network

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219972


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|171543, 219954  |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219972] Review Request: poker-network - A poker server, client and abstract user interface library

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: poker-network - A poker server, client and abstract 
user interface library
Alias: poker-network

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219972





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 23:28 EST ---
pec URL: http://tkmame.retrogames.com/fedora-extras/poker-network.spec
SRPM URL: 
http://tkmame.retrogames.com/fedora-extras/poker-network-1.0.32-3.src.rpm

%changelog
* Sun Dec 31 2006 Christopher Stone [EMAIL PROTECTED] 1.0.32-4
- Add full path to exec in desktop file
- Add pkgconfig to devel subpackage
- Convert icons to png format and store in icons directory
- Update TODO

Jef: Can you test the icons out on this release? Thx

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220945] Review Request: perl-Text-CharWidth - Get number of occupied columns of a string on terminal

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-CharWidth - Get number of occupied columns 
of a string on terminal


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220945





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 23:31 EST ---
I am unable to download above links.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220944] Review Request: perl-Text-WrapI18N - Line wrapping with support for several locale setups

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-WrapI18N - Line wrapping with support for 
several locale setups


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220944





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 23:31 EST ---
I am unable to download SPEC and SRPMS files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219972] Review Request: poker-network - A poker server, client and abstract user interface library

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: poker-network - A poker server, client and abstract 
user interface library
Alias: poker-network

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219972





--- Additional Comments From [EMAIL PROTECTED]  2007-01-01 23:49 EST ---
(In reply to comment #18)
 pec URL: http://tkmame.retrogames.com/fedora-extras/poker-network.spec
 SRPM URL:
http://tkmame.retrogames.com/fedora-extras/poker-network-1.0.32-3.src.rpm

Ack, this is supposed to be:
http://tkmame.retrogames.com/fedora-extras/poker-network-1.0.32-4.src.rpm

I apologize, I am notoriously bad for copypasting without updating.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219972] Review Request: poker-network - A poker server, client and abstract user interface library

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: poker-network - A poker server, client and abstract 
user interface library
Alias: poker-network

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219972





--- Additional Comments From [EMAIL PROTECTED]  2007-01-02 01:13 EST ---
Menu entry and menu icons appear to be working in this release.

I think the only important thing left is the issue of whether
/usr/lib/poker-network/poker-interface  should be moved to
/usr/lib/python2.4/site-packages/pokerclient2d and if it should be renamed to
poker-interface.so for clarity.

the python add-on package naming issue is less clear since there are already
poker-whatever packages in the tree which you'd have to also rename to meet the
python-whatever guidance. I'm not going to block on that since these poker-*
packages make a consistent naming group.  If someone else has a problem with it,
you'll have to go into the tree later and rename and do some virtual providing.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218839] Review Request: pyflakes - A Lint-like tool for Python

2007-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyflakes - A Lint-like tool for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218839





--- Additional Comments From [EMAIL PROTECTED]  2007-01-02 01:15 EST ---
Ville

I don't have a Fedora account since I haven't been sponsored yet.  I forgot to
state that this was an unofficial review, but Jeffrey knew that because I was
providing several unofficial reviews for his packages.

Sorry for the confusion.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review