[Bug 234711] Review Request: desktop-drapes - A wallpaper manager application for the GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-drapes - A wallpaper manager application for the GNOME desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234711 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 03:38 EST --- Here are the list of blocker review issues as I see it. I have provided an updated specfile as an attachment to this report which I believe address each of the issues below. If you have an issue with any of the suggested changes, please let me know. Review items that need to be addressed: - Change the name to drapes to match upstream tarball and packaging ... Fixed in updated spec - Need BuildRequires: perl-XML-Parser to build under mock against development tree ... Fixed in updated spec - Directory ownership issues: Package should require hicolor-icon-theme for /usr/share/icons/hicolor/*/apps/ ownership Package should require yelp for /usr/share/gnome/help/ ownership Package should require libbonobo for /usr/lib/bonobo/servers/ ownership Package should own /usr/share/omf/drapes/ and /usr/share/gnome/help/drapes/ and /usr/lib/drapes/ ... Fixed in updated spec - Minor Scriptlet changes to bring the package inline with http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ... Fixed in updated spec Details concerning scriptlets: + GConf scriptlets and requires look good according to ScriptletSnippets - scrollkeeper scriptlet updated for to best practises from ScriptletSnippets ... updated spec file contains suggested changes. - update-desktop-database scriptlets technically not needed, since desktop file does not reference a MimeType. ... removed in the updates specfile. Non-blocker item: - Close button on the About dialog doesn't work. ... This is not a blocker, but should be filed with upstream developer. Items which pass review: + rpmlint not clean, but messages appear to be bogus pmlint messages from binary with comments inline: E: desktop-drapes no-binary I'm not sure what this means. This looks bogus to me. The /usr/bin/drapes file is a bash script which shells out to mono. I don't see a problem here. E: desktop-drapes only-non-binary-in-usr-lib I think this is also bogus, the file location /usr/lib/drapes/drapes.exe appears to be consistent with other mono application packaging such as tomboy. W: desktop-drapes non-conffile-in-etc /etc/gconf/schemas/drapes.schemas clearly a bogus warning + Specfile name matches name field. Note that both should probably change to just 'drapes' + URL and SOURCE0 tags look good + md5sum of included source matches with upstream source 3ae3b1489f33a3e3b6ccaa3dd8782622 drapes-0.5.1.tar.gz + GPL License tag matches actual license as listed in source COPYING file. COPYING file is included in docs section appropriately + specfile is in legible english-ese + no need for ldconfig no shared libraries + locales seem to be handled correctly + files section looks good ( after correction for directory ownership ) + permissions look good + clean section looks good + install section looks good + no need for doc subpackage + no need for devel subpackage + docs section does not include runtime necessary files + desktop file is included and appears to be installed correctly (Suggestion, add fedora as vendor-id.. this is included in updated spec) + build process appears to be using the rpm build environment compiler options correctly. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234711] Review Request: desktop-drapes - A wallpaper manager application for the GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-drapes - A wallpaper manager application for the GNOME desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234711 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 03:40 EST --- Created an attachment (id=152519) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=152519action=view) Updated drapes specfile which includes all suggested fixes for review This specfile includes all suggested review blocker fixes. Most importantly this includes a name change from desktop-drapes to drapes to bring it inline with upstream packaging. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233597] Review Request: pigment - Media Center Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pigment - Media Center Toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233597 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 05:18 EST --- Status is not ASSIGNED yet, so I guess you could review :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222964] Review Request: dayplanner - A simple time management program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dayplanner - A simple time management program. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222964 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776, 177841 |201449 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 05:59 EST --- Closing for now. If you want to try this software, feel free to reopen this bug. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222964] Review Request: dayplanner - A simple time management program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dayplanner - A simple time management program. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222964 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution||WONTFIX Flag|needinfo?([EMAIL PROTECTED]| |ch) | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 210823] Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210823 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 06:05 EST --- What is the status of this bug? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235588] Review Request: escape - an extensible puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: escape - an extensible puzzle game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235588 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 06:06 EST --- You should also add hicolor-icon-theme to Requires. This is an empty package owning the /usr/share/icons/hicolor dir hierarchy, sortoff like the filesystem package but then for icons. Note that all packages which have an icon should Require this to ensure proper icon dir ownership. Version is wrong. Please read: http://fedoraproject.org/wiki/Packaging/NamingGuidelines?action=show#head-cfd71146dbb6f00cec9fe3623ea619f843394837 BTW, why do you use a snapshot version (CVS checkout) instead of a stable release? There may be good reasons, but I'd like to know :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235588] Review Request: escape - an extensible puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: escape - an extensible puzzle game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235588 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 07:23 EST --- (In reply to comment #3) BTW, why do you use a snapshot version (CVS checkout) instead of a stable release? There may be good reasons, but I'd like to know :) +1. Would probably also make the URL issue go away more easily. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221027] Review Request: LabPlot - Data Analysis and Visualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: LabPlot - Data Analysis and Visualization https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 07:50 EST --- (In reply to comment #30) (In reply to comment #29) [EMAIL PROTECTED] i386]$ rpmlint LabPlot W: LabPlot incoherent-version-in-changelog 1.5.1.5-4 1.5.1.5-4.2.fc7 W: LabPlot unused-direct-shlib-dependency /usr/lib/libLabPlot.so.1.5.1 /usr/lib/libgslcblas.so.0 W: LabPlot unused-direct-shlib-dependency /usr/lib/libLabPlot.so.1.5.1 /usr/lib/liblcms.so.1 W: LabPlot unused-direct-shlib-dependency /usr/lib/libLabPlot.so.1.5.1 /usr/lib/libfreetype.so.6 W: LabPlot unused-direct-shlib-dependency /usr/lib/libLabPlot.so.1.5.1 /usr/lib/libjpeg.so.62 W: LabPlot unused-direct-shlib-dependency /usr/lib/libLabPlot.so.1.5.1 /usr/lib/libfontconfig.so.1 It can be ignored. Yes. Anyway, please check my spec file and fix it. Especially, * it seems for me that -devel package is not useful because -devel package does not contain any header files * I don't understand why you don't split -fr documents -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221027] Review Request: LabPlot - Data Analysis and Visualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: LabPlot - Data Analysis and Visualization https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 07:58 EST --- Updated Spec URL: http://tux.u-strasbg.fr/~chit/LabPlot/LabPlot.spec SRPM URL: http://tux.u-strasbg.fr/~chit/LabPlot/LabPlot-1.5.1.5-5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221027] Review Request: LabPlot - Data Analysis and Visualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: LabPlot - Data Analysis and Visualization https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 08:00 EST --- (In reply to comment #31) * I don't understand why you don't split -fr documents I've done it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231911] Review Request: jomolhari-fonts - Jomolhari a Bhutanese style font for Tibetan and Dzongkha
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jomolhari-fonts - Jomolhari a Bhutanese style font for Tibetan and Dzongkha https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231911 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 08:20 EST --- Imported and builded. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233802] Review Request: python-xlib - Fully functional X client library for Python programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-xlib - Fully functional X client library for Python programs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233802 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 223592] Review Request: wuja - Gnome desktop applet for integration with Google calendar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wuja - Gnome desktop applet for integration with Google calendar https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223592 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 09:20 EST --- http://dangerouslyinc.com/files/wuja/wuja.spec http://dangerouslyinc.com/files/wuja/wuja-0.0.6-3.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225253] Merge Review: apr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: apr https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225253 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 09:48 EST --- Re: comment #11 Regardless, if you want to keep static libs/.la files, they should to be in *-static pkgs: http://fedoraproject.org/wiki/Packaging/Guidelines#head-82d97fc4a3421310f4e2971180e4165965b65662 http://fedoraproject.org/wiki/PackagingDrafts/StaticLinkage -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226189] Merge Review: neon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: neon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226189 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |ASSIGNED Keywords||Reopened Resolution|RAWHIDE | Flag|fedora-review+ |fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 10:00 EST --- Here's a few more items that should be addressed in merge review: 1. neon's static libs (and .la's) file should be packaged separately: into a -static or -devel-static package: http://fedoraproject.org/wiki/Packaging/Guidelines#head-82d97fc4a3421310f4e2971180e4165965b65662 http://fedoraproject.org/wiki/PackagingDrafts/StaticLinkage This will be mildly painful, but to do this right, we'll have to sort through the whole stack of dependent libs/packages and do those too. 2. libneon.la (currently in neon-devel) contains references to -lgssapi_krb5 -lkrb5 but it doesn't include: the (sub) package owning libneon.la MUST include: Requires: krb5-devel Eventually, when/if krb5-static exists, neon-static needs Requires: krb5-static -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 236366] New: Review Request: clutter-gtk - basic GTK clutter widget
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236366 Summary: Review Request: clutter-gtk - basic GTK clutter widget Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] Spec URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk.spec SRPM URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk-0.1.0-1.src.rpm Description: This allows clutter to be embedded in GTK applications. We hope with further work in the future clutter-gtk will also allow the reverse, namely embedding GTK in Clutter -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226189] Merge Review: neon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: neon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226189 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 11:21 EST --- Just a note that the static library guideline wasn't there when I originally reviewed this package, so this bit about splitting them (and the .la file) out from the main package is new. Still, I'm not sure what the value of putting the .la file in a separate package is if the main package will just require it in order for neon-config --la-file to be meaningful. Unless, of course, it's OK for neon-config output to point to a nonexistant file in the case that the -static package is not installed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 223592] Review Request: wuja - Gnome desktop applet for integration with Google calendar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wuja - Gnome desktop applet for integration with Google calendar https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223592 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 11:22 EST --- Created an attachment (id=152547) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=152547action=view) mock build log of wuja-0.0.6-3 on FC-devel i386 wuja-0.0.6-3 won't be rebuilt on FC-devel i386. Please check BuildRequires (at least python-devel seems required as BR) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226189] Merge Review: neon
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: neon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226189
--- Additional Comments From [EMAIL PROTECTED] 2007-04-13 11:29 EST ---
Re: neon-config --la-file
Prolly patch
--- neon-config.static 2006-07-12 12:13:28.0 -0500
+++ neon-config 2007-04-13 10:27:56.0 -0500
@@ -82,7 +82,9 @@
;;
--la-file)
+ if test -f ${libdir}/libneon.la ; then
echo ${libdir}/libneon.la
+ fi
;;
--support)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
[EMAIL PROTECTED]
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226189] Merge Review: neon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: neon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226189 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 11:49 EST --- Rex: thanks for the .pc patch, looks great (neon 0.26.x does similar already). But breaking the --la-file output is simply not acceptable. I'm not sure it is worth the hassle of going through creating all those -static packages. We could just drop the libneon.a, strip the dep_libs line from the .la file to prevent deps leaks, break the upstream RPM build, and be done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226189] Merge Review: neon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: neon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226189 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 12:31 EST --- break the upstream RPM build, and be done. you sure? Having the ability to have a static rpm seems desirable (but you're right, the extra effort may not be worth the pain). breaking the --la-file output is simply not acceptable. why? really, who uses it? what depends on it? couldn't/shouldn't those be fixed? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226407] Merge Review: sendmail
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: sendmail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226407
--- Additional Comments From [EMAIL PROTECTED] 2007-04-13 13:11 EST ---
rpmlint output, ignoring things explained away in Comment #2.
W: sendmail unversioned-explicit-provides MTA
= I'm not convinced about the merits of Provides: MTA vs. Provides:
smtpdaemon, and the discussion on fedora-devel-list didn't seem to lead to any
particular conclusion. It's harmless enough though so I'm not going to quibble
about it.
E: sendmail hardcoded-library-path in /usr/lib/sendmail
= This comes from Provides: /usr/lib/sendmail, is intentional and required
for backwards compatibility (OK).
W: sendmail unversioned-explicit-provides %{_sysconfdir}/pam.d/smtp
W: sendmail unversioned-explicit-provides %{_mandir}/man8/sendmail.8.gz
== Provides for alternatives-based files (OK).
W: sendmail mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 232)
= Should use either spaces or tabs consistently, not a mixture of the two.
E: sendmail non-standard-executable-perm /usr/sbin/makemap 0555
= Permission should be 0755 to enable debuginfo extraction.
E: sendmail non-readable /etc/aliases.db 0640
= This has appeared because the original package explicitly used %attr(0644...
for this file. Harmless because (a) the file is %ghosted and (b) the permissions
will be 0640 on the installed system anyway if the file is created properly.
E: sendmail executable-marked-as-config-file /etc/rc.d/init.d/sendmail
= Marking initscripts as %config is a contentious subject. I'm against it on
the basis that configurability should be encapsulated in /etc/sysconfig/sendmail
etc. but I can see the merits of the argument the other way too. Do you have a
strong opinion on this or is this just an inheritance from older packaging?
E: sendmail non-standard-executable-perm /usr/sbin/smrsh 0555
= Permission should be 0755 to enable debuginfo extraction.
E: sendmail postin-without-chkconfig /etc/rc.d/init.d/sendmail
= /sbin/chkconfig --add sendmail was removed from %post along with the stuff
for upgrading from old versions, needs to be reinstated.
Other comments:
FFR_UNSAFE_SASL still present in sasl2 config - why?
Why is the not-included mysql support stuff still in the spec?
Any thoughts on my suggestion for the %post script near the end of Comment #9?
Finally, the line containing MSPQOWN=${nameuser} in the spec has a trailing
space on it. Please remove it, it's been annoying me for ages ;-)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
[EMAIL PROTECTED]
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225792] Merge Review: gfs2-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gfs2-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225792 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222372] Review Request: tilda - a quake like drop down terminal for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tilda - a quake like drop down terminal for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222372 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 14:19 EST --- Hmm I never closed this. Its been committed to CVS and released. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234860] Review Request: perl-Mail-IMAPClient - An IMAP Client API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Mail-IMAPClient - An IMAP Client API Alias: perl-Mail-IMAPClient https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234860 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 15:48 EST --- Built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234862] Review Request: perl-Mail-Box - Manage a mailbox, a folder with messages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Mail-Box - Manage a mailbox, a folder with messages Alias: perl-Mail-Box https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234862 Bug 234862 depends on bug 234860, which changed state. Bug 234860 Summary: Review Request: perl-Mail-IMAPClient - An IMAP Client API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234860 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 236422] New: Review Request: clutter-gst - ClutterMedia interface to GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236422 Summary: Review Request: clutter-gst - ClutterMedia interface to GStreamer Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] Spec URL: http://fedora.allisson.eti.br/clutter-gst/clutter-gst.spec SRPM URL: http://fedora.allisson.eti.br/clutter-gst/clutter-gst-0.1.1-1.src.rpm Description: This package contains a video texture actor and an audio player object for use with clutter -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234862] Review Request: perl-Mail-Box - Manage a mailbox, a folder with messages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Mail-Box - Manage a mailbox, a folder with messages Alias: perl-Mail-Box https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234862 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 15:57 EST --- Built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234863] Review Request: perl-Mail-Box-Parser-C - Parsing folders for MailBox with C routines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Mail-Box-Parser-C - Parsing folders for MailBox with C routines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234863 Bug 234863 depends on bug 234862, which changed state. Bug 234862 Summary: Review Request: perl-Mail-Box - Manage a mailbox, a folder with messages https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234862 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234790] Review Request: perl-Email-Abstract - Unified interface to mail representations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Abstract - Unified interface to mail representations Alias: perl-Email-Abstract https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234790 Bug 234790 depends on bug 234862, which changed state. Bug 234862 Summary: Review Request: perl-Mail-Box - Manage a mailbox, a folder with messages https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234862 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225610] Merge Review: bcel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: bcel
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225610
--- Additional Comments From [EMAIL PROTECTED] 2007-04-13 16:50 EST ---
(In reply to comment #6)
* The examples/Mini README probably shouldn't be marked as a %doc as it makes
more sense to just leave it in the Mini directory.
Done
* The demo package probably shouldn't install things to
%{_datadir}/%{name}-%{version} but to %{_datadir}/%{name}-%{version}/demo
Fixed
* It seems strange that the demo package doesn't have any documentation
describing what the classes do and how to build them. But I guess the sources
don't have this information either
Yeah, the upstream sources don't have any documentation either.
* The build file for the demo package is the build.xml for the whole project.
Perhaps this should be included in the demo package (or maybe a subset that
would only build the demos?)
I've made the main package a Requires: for the demo package
* The manual subpackage just has the license file in there, there should be
more
to the manual than this. maybe the manual only gets built if using maven?
The docs/* stuff are built but doesn't get included in the package, I copied the
LICENCE.txt to %{_docdir}/%{name}-%{version}, so that the docs/* stays in the
package.
New spec file and srpm at the same location.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
[EMAIL PROTECTED]
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225607] Merge Review: axis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: axis https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225607 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 18:04 EST --- (In reply to comment #4) - if upstream doesn't release source drops, put *clear* instructions on how to generate the the source drop; ie. # svn export blah/tag blah # tar cjf blah-version-src.tar.bz2 blah X md5sums do not match Fixed rpmlint axis-javadoc-1.2.1-2jpp.7.fc7.x86_64.rpm W: axis-javadoc non-standard-group Development/Libraries/Java W: axis-javadoc symlink-should-be-relative /usr/share/javadoc/axis /usr/share/javadoc/axis-1.2.1 X please fix the symlink issue I don't think the symlink can be made relative since there is macro in there. rpmlint axis-manual-1.2.1-2jpp.7.fc7.x86_64.rpm W: axis-manual non-standard-group Development/Libraries/Java W: axis-manual dangling-symlink /usr/share/doc/axis-manual-1.2.1/apiDocs /usr/share/javadoc/axis W: axis-manual symlink-should-be-relative /usr/share/doc/axis-manual-1.2.1/apiDocs /usr/share/javadoc/axis X please fix the symlink issues The symlink is needed to avoid duplicate files. This symlink also includes a macro. Updated spec file and srpm at the same location. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235589] Review Request: escape-data - data for the escape package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: escape-data - data for the escape package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235589 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 18:06 EST --- Yeah, I'll kill this bug and just have the one package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 223486] Review Request: happy - Haskell parser generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: happy - Haskell parser generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223486 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 18:17 EST --- New Package CVS Request === Package Name: happy Short Description: Haskell parser generator Owners: [EMAIL PROTECTED] Branches: FC-6 InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235802] Review Request: remind - Sophisticated calendar and alarm program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: remind - Sophisticated calendar and alarm program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235802 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 18:52 EST --- Created an attachment (id=152596) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=152596action=view) Patch to not strip binaries I'm seeking a sponsor also, so consider this just pre-review comments. The binaries are being stripped, leaving an empty debuginfo package. See http://fedoraproject.org/wiki/Packaging/Debuginfo for details. My patch to src/Makefile.in is attached. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 230806] Review Request: tasks - To-do list
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tasks - To-do list https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230806 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 18:56 EST --- Pre-review notes on remind: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235802 Proposed patch to stop stripping binaries, generate non-empty debuginfo. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235588] Review Request: escape - an extensible puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: escape - an extensible puzzle game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235588 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 19:23 EST --- New release: http://www.spicenitz.org/fedora/escape-200704130-1.fc7.src.rpm http://www.spicenitz.org/fedora/escape.spec - Merge -data package into this - Install icon into correct place and update the icon cache - Use upstream tarball, created by upstream at my request - Remove X-Fedora category -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226048] Merge Review: libtheora
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libtheora https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226048 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 19:31 EST --- I guess we'll have to wait until a stable version is out (hopefully it won't be called 1.0). Closing this bug, since in this case it's a review of an existing package and there's no owner set -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 230806] Review Request: tasks - To-do list
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tasks - To-do list https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230806 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 19:49 EST --- Well, * tasks-0.4-3 is okay * I have not checked remind (bug 235802) in detail, however your patch is actually needed. - This package (tasks) is APPROVED by me. - I will sponsor you. Please follow according to http://fedoraproject.org/wiki/PackageMaintainers/Join -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226230] Merge Review: parted
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: parted https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226230 --- Additional Comments From [EMAIL PROTECTED] 2007-04-13 21:00 EST --- Sorry, should have been [x] Package does not own files or directories owned by other packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 230806] Review Request: tasks - To-do list
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tasks - To-do list https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230806 --- Additional Comments From [EMAIL PROTECTED] 2007-04-14 00:43 EST --- Thank you for the review and sponsorship. I've applied for my account and will notify you when I'm in the cvsextras and fedorabugs groups. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235588] Review Request: escape - an extensible puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: escape - an extensible puzzle game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235588 --- Additional Comments From [EMAIL PROTECTED] 2007-04-14 00:51 EST --- Backup location if spicenitz.org is down: http://www.andrew.cmu.edu/user/agoode/fedora/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
