[Bug 230802] Review Request: perl-Callback - Object interface for function callbacks

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Callback - Object interface for function callbacks
Alias: perl-Callback

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230802





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 02:14 EST ---

I followed the procedure at
http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess
and successfully imported for the devel branch.

If I am required to do something else for FC-6 and F-7, please tell me what it
is. I will update the wiki accordingly.

Thanks,
-- Pai

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Extra m17n-lib datafiles for input and output

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Extra m17n-lib datafiles for input and 
output


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 02:44 EST ---
Created an attachment (id=159763)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159763action=view)
m17n-contrib.spec-macro.patch

Ok here is a patch with a macro to define the subpackages
and other improvements.  You need to download the missing script
from cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Extra m17n-lib datafiles for input and output

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Extra m17n-lib datafiles for input and 
output


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 03:08 EST ---
Thanks for your inputs.
here is updated package links
Spec URL: http://people.redhat.com/pnemade/m17n/m17n-contrib.spec
SRPM URL: 
http://people.redhat.com/pnemade/m17n/m17n-contrib-1.1.2-1.1.fc8.src.rpm

Also, updated m17n-db package is available at 
http://people.redhat.com/pnemade/m17n

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249214] Review Request: alienblaster - Action-loaded 2D arcade shooter game

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alienblaster - Action-loaded 2D arcade shooter game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249214





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 03:15 EST ---
(In reply to comment #2)
 One minor note:
 
 The .sh script you're using to launch the alienblaster.bin has a minor bug
 (preventing the game from launching).
 
 Your script make a symlink to sounds instead of the correct sound.
 

Oopsee, good catch. I noticed this myself too, fixed the symlink in my ~
manually, play tested and then forgot all about it :)

And many thanks for the review!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249214] Review Request: alienblaster - Action-loaded 2D arcade shooter game

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alienblaster - Action-loaded 2D arcade shooter game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249214


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 03:47 EST ---
New Package CVS Request
===
Package Name:  alienblaster
Short Description: Action-loaded 2D arcade shooter game
Owners:[EMAIL PROTECTED]
Branches:  FC-6 F-7 devel
InitialCC: empty




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Extra m17n-lib datafiles for input and output

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Extra m17n-lib datafiles for input and 
output


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 03:57 EST ---
Created an attachment (id=159767)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159767action=view)
m17n-contrib.spec-1.1.patch

missing script should be installed 755 - my bad.

Few other bits of cleanup and description improvements.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision 
floating-point computations


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 04:37 EST ---
Hello,
I'm gmp maintainer too so I'd like to update gmp in devel branch too, but I
don't want to remove mpfr files from gmp for long time without existence of the
separate mpfr package. So I plan to do both these changes (update gmp and remove
mpfr files from gmp and add mpfr package) when this review will be approved. 
I will update the conflict flag when I will build the new gmp version. 
Thanks for your comments.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Extra m17n-lib datafiles for input and output

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Extra m17n-lib datafiles for input and 
output


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 04:44 EST ---
Ok done with changes, but I kept same release number. So new links are
Spec URL: http://people.redhat.com/pnemade/m17n/m17n-contrib.spec
SRPM URL: 
http://people.redhat.com/pnemade/m17n/m17n-contrib-1.1.2-1.1.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision 
floating-point computations


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 04:51 EST ---
Nice to hear that, Ivana. Do you have a gmp package updated, so that we can 
test it with the mpfr RPM of this bug?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 236521] Review Request: nspluginwrapper - A compatibility layer for Mozilla/Firefox plugins

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nspluginwrapper - A compatibility layer for 
Mozilla/Firefox plugins
Alias: nspluginwrapper

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236521





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 05:00 EST ---
you have to build and install the 32-bit version, too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249235] Review Request: pidgin-knotify - KNotify plugin for Pidgin

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-knotify - KNotify plugin for Pidgin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249235





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 05:05 EST ---
snip from a mock build:

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.40708
+ umask 022
+ cd /builddir/build/BUILD
+ cd pidgin-knotify-0.1
+ LANG=C
+ export LANG
+ unset DISPLAY
+ make
gcc -o knotify-plugin.so -shared knotify-plugin.c `pkg-config pidgin --cflags
--libs` -g -Wall
/bin/sh: pkg-config: command not found
knotify-plugin.c:16:18: error: glib.h: No such file or directory
knotify-plugin.c:17:26: error: glib/gprintf.h: No such file or directory
knotify-plugin.c:21:24: error: connection.h: No such file or directory
knotify-plugin.c:22:26: error: conversation.h: No such file or directory
knotify-plugin.c:23:18: error: core.h: No such file or directory
knotify-plugin.c:24:21: error: signals.h: No such file or directory
knotify-plugin.c:25:21: error: version.h: No such file or directory
knotify-plugin.c:26:20: error: status.h: No such file or directory
knotify-plugin.c:31: error: expected '=', ',', ';', 'asm' or '__attribute__'
before 'dcopmessage'
knotify-plugin.c:34: error: expected ')' before '*' token
knotify-plugin.c:49: error: expected ')' before '*' token
knotify-plugin.c:64: error: expected ')' before '*' token
knotify-plugin.c:71: error: expected '=', ',', ';', 'asm' or '__attribute__'
before 'plugin_load'
knotify-plugin.c:84: error: expected '=', ',', ';', 'asm' or '__attribute__'
before 'info'
knotify-plugin.c:115: error: expected ')' before '*' token
knotify-plugin.c:118: warning: data definition has no type or storage class
knotify-plugin.c:118: warning: type defaults to 'int' in declaration of
'PURPLE_INIT_PLUGIN'
knotify-plugin.c:118: warning: parameter names (without types) in function
declaration
make: *** [knotify-plugin.so] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.40708 (%build)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249251] New: Review Request: hardinfo - System Profiler and Benchmark

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249251

   Summary: Review Request: hardinfo - System Profiler and Benchmark
   Product: Fedora
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://tgmweb.at/gadllah/hardinfo.spec
SRPM URL: http://tgmweb.at/gadllah/hardinfo-0.4.2.2-1.fc7.src.rpm
Description: 
HardInfo can gather information about a system's hardware and operating system,
perform benchmarks, and generate printable reports either in HTML or in plain 
text formats.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249251] Review Request: hardinfo - System Profiler and Benchmark

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hardinfo - System Profiler and Benchmark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249251


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249251] Review Request: hardinfo - System Profiler and Benchmark

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hardinfo - System Profiler and Benchmark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249251





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:17 EST ---
Fixed a bug in the package (detection of human users):
New URLs:
http://tgmweb.at/gadllah/hardinfo.spec
http://tgmweb.at/gadllah/hardinfo-0.4.2.2-2.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 246312] Review Request: Pygments - A syntax highlighting engine written in Python

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Pygments - A syntax highlighting engine written in 
Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246312





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:20 EST ---
I'm getting a dist-fc7-updates-candidate error in F-7 (and a similar one in
devel)  not sure if I missing something or if I don't have the build ability
yet ...

[EMAIL PROTECTED] F-7]$ make build
Created task: 73459
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=3D73459
Watching tasks (this may be safely interrupted)...
73459 build (dist-fc7-updates-candidate, F-7:python-pygments-0_8_1-1_fc7):
free
73459 build (dist-fc7-updates-candidate, F-7:python-pygments-0_8_1-1_fc7):
free - open (xenbuilder4.fedora.phx.redhat.com)
  73460 buildSRPMFromCVS (F-7:python-pygments-0_8_1-1_fc7): open
(ppc1.fedora.redhat.com)
  73460 buildSRPMFromCVS (F-7:python-pygments-0_8_1-1_fc7): open
(ppc1.fedora.redhat.com) - closed
  0 free  1 open  1 done  0 failed
73459 build (dist-fc7-updates-candidate, F-7:python-pygments-0_8_1-1_fc7):
open (xenbuilder4.fedora.phx.redhat.com) - FAILED: BuildError: package
python-pygments not in list for tag dist-fc7-updates-candidate
  0 free  0 open  1 done  1 failed

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Contributed m17n input maps

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Contributed m17n input maps


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: m17n-contrib|Review Request: m17n-contrib
   |- Extra m17n-lib datafiles  |- Contributed m17n input
   |for input and output|maps




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:23 EST ---
In the future please always bump the release that makes the reviewers job 
easier.

I suggest making the tbl2mim.swk script executable in the srpm.

For me the above links are still pointing to the old version of the package
(ie same as comment 3).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision 
floating-point computations


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:28 EST ---
Created an attachment (id=159779)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159779action=view)
proposed version of gmp package

Oops good idea - so this is the proposed version of gmp package. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249251] Review Request: hardinfo - System Profiler and Benchmark

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hardinfo - System Profiler and Benchmark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249251


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:36 EST ---
ackage Review
==

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format 
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: x86_64
 [x] Rpmlint output:none
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type:GPL
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
 SHA1SUM of package: e3ec42cdb5ee03b002aa071d418f951579998408 
/home/wolfy/hardinfo-0.4.2.2.tar.bz2
 [x] Package is not known to require ExcludeArch, OR:
 Arches excluded:
 Why:
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: F7/x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on:F7/x86_64, devel/x86_64
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.

NOTES
I would have used a simple sed over the source file (rather than a full blown
patch) to fix the start UID of the normal users, but your approach is perfectly
fine.



*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data 
analysis application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:43 EST ---
Well, it seems that all files are installed under site_lib,
not site_arch. While this should be for arch-independent files
(.py{,c,o}), arch-dependent files (.so, for example) must be
installed under site_arch directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Contributed m17n input maps

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Contributed m17n input maps


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:47 EST ---
(In reply to comment #6)
 In the future please always bump the release that makes the reviewers job 
 easier.
 
 I suggest making the tbl2mim.swk script executable in the srpm.
 
 For me the above links are still pointing to the old version of the package
 (ie same as comment 3).

I rechecked again and new links already have updated SPEC.
Ok now I bump release. So new links are
Spec URL: http://people.redhat.com/pnemade/m17n/m17n-contrib.spec
SRPM URL: 
http://people.redhat.com/pnemade/m17n/m17n-contrib-1.1.2-1.2.fc8.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 247227] Review Request: nabi - hangul and hanja X input method

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nabi - hangul and hanja X input method
Alias: nabi

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 08:52 EST ---
By the way are there any information when upstream will
release new version?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249251] Review Request: hardinfo - System Profiler and Benchmark

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hardinfo - System Profiler and Benchmark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249251





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 09:03 EST ---
thx for the review.
NOTES
I would have used a simple sed over the source file (rather than a full blown
patch) to fix the start UID of the normal users, but your approach is perfectly
fine.

I somehow prefer patches don't ask me why ;)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249006] Review Request: m17n-contrib - Contributed m17n input maps

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: m17n-contrib - Contributed m17n input maps


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249006





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 09:20 EST ---
Some notes:

* Please try to keep timestamps as much as possible.
  For recent Makefile, the following method usually works.
---
make install DESTDIR=foo INSTALL=%{__install} -c -p
---

* Check the directory ownership
---
[EMAIL PROTECTED] mock]# LANG=C rpm -ivh m17n-contrib-1.1.2-1.2.fc8.noarch.rpm
m17n-contrib-marathi-1.1.2-1.2.fc8.noarch.rpm 
Preparing...### [100%]
   1:m17n-contrib   ### [ 50%]
   2:m17n-contrib-marathi   ### [100%]
[EMAIL PROTECTED] mock]# LANG=C rpm -qf /usr/share/m17n/icons/mr-inscript.png 
m17n-contrib-marathi-1.1.2-1.2.fc8
[EMAIL PROTECTED] mock]# LANG=C rpm -qf /usr/share/m17n/icons/
file /usr/share/m17n/icons is not owned by any package
---

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 09:22 EST ---
build fails here:
make[2]: Leaving directory `/home/linux/rpmbuild/BUILD/qfaxreader-0.3.1/pix'
Making all in src
make[2]: Entering directory `/home/linux/rpmbuild/BUILD/qfaxreader-0.3.1/src'
/usr/lib64/qt-3.3/bin/uic alias.ui -o alias.h
make[2]: *** No rule to make target `alias.h', needed by `all'.  Stop.
make[2]: *** Waiting for unfinished jobs
/usr/lib64/qt-3.3/bin/uic -impl alias.h alias.ui -o alias.cpp
Conflict in /usr/lib/kde3/plugins/designer/kdewidgets.so:
  Plugin uses incompatible Qt library!
  expected build key x86_64 Linux g++-4.* full-config, got i686 Linux g++-4.*
full-config.
/usr/lib64/qt-3.3/bin/moc alias.h  alias.cpp
make[2]: Leaving directory `/home/linux/rpmbuild/BUILD/qfaxreader-0.3.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/linux/rpmbuild/BUILD/qfaxreader-0.3.1'
make: *** [all] Error 2
Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.55914 (%build)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248291] Review Request: libXNVCtrl - Library that provides the NV-CONTROL API

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libXNVCtrl -  Library that provides the NV-CONTROL API


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248291





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 09:24 EST ---
(In reply to comment #2)
 Ok so few comments to start:
 
 1/ You must use $RPM_OPT_FLAGS
 This will allow to have some debuginfo... (cf 0 blocks )
 
 2/ About: # ... but apps expect them under NVCtrl:
   Ok but can you preserve timestamp? ( maybe some install -pm 0644 would be
 better...)
 

New version with these both fixed here:
Spec URL: http://people.atrpms.net/~hdegoede/libXNVCtrl.spec
SRPM URL: http://people.atrpms.net/~hdegoede/libXNVCtrl-1.0-2.fc8.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 09:29 EST ---
some NOTES:
%configure line to long split it please.
use %{_bindir} not /usr/bin
%description seems long too. is it necessary to list all features here?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 247930] Review Request: linkchecker - checks HTML documents for broken links

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linkchecker - checks HTML documents for broken links


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247930





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 09:49 EST ---
This time:

* linkchecker won't work:
-
[EMAIL PROTECTED] mock]# linkchecker http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/
Traceback (most recent call last):
  File /usr//bin/linkchecker, line 527, in module
config.init_logging(debug=options.debug)
  File /usr/lib/python2.5/site-packages/linkcheck/configuration/__init__.py,
line 161, in init_logging
logging.config.fileConfig(filename)
  File /usr/lib/python2.5/logging/config.py, line 76, in fileConfig
formatters = _create_formatters(cp)
  File /usr/lib/python2.5/logging/config.py, line 107, in _create_formatters
flist = cp.get(formatters, keys)
  File /usr/lib/python2.5/ConfigParser.py, line 511, in get
raise NoSectionError(section)
ConfigParser.NoSectionError: No section: 'formatters'
---
  - linkcheck/configuration/__init__.py really uses logging.conf
  - The configutaion directory path is set in _linkchecker_configdata.py

* gettext .mo files
  - File entries of gettext .mo files should be marked by using
%find_lang.

* rpmlint
  - rpmlint complains:

E: linkchecker non-executable-script /usr/share/linkchecker/examples/lc.cgi 0644
E: linkchecker non-executable-script
/usr/share/linkchecker/examples/check_blacklist.sh 0644
E: linkchecker non-executable-script /usr/share/linkchecker/examples/lc.fcgi 
0644
E: linkchecker non-executable-script
/usr/share/linkchecker/examples/check_for_x_errors.sh 0644
E: linkchecker non-executable-script
/usr/share/linkchecker/examples/check_urls.sh 0644
-

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:04 EST ---
Thanks for the review, Adel.

If I interpret correctly your log, you did not use mock. Could you please try a
mock build? As you can see in my buildlogs for devel/x86_64 (which are available
at http://wolfy.fedorapeople.org/buildlogs/devel) on my test machine, under
mock, everything seems OK so I would be grateful if you can provide more input
on the situation when it does not build

I have split the %configure line, I will upload the new spec once more
modifications are to be included. As of the description, that's how the author
describes it and I would like to leave it as it is.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:16 EST ---
(In reply to comment #8)
 Thanks for the review, Adel.
 
 If I interpret correctly your log, you did not use mock. Could you please try 
 a
 mock build? As you can see in my buildlogs for devel/x86_64 (which are 
 available
 at http://wolfy.fedorapeople.org/buildlogs/devel) on my test machine, under
 mock, everything seems OK so I would be grateful if you can provide more input
 on the situation when it does not build
 

ok I am building it in mock now.

 I have split the %configure line, I will upload the new spec once more
 modifications are to be included. As of the description, that's how the author
 describes it and I would like to leave it as it is.
ok,
this comment seems unneeded: #the category Application is not valid

when you upload the new spec and the build work I will do a formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:27 EST ---
you also don't need the / when you use the macros:

ex:

/%{_datadir}/man/man1/*
-
%{_datadir}/man/man1/*

and so on.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:33 EST ---
Created an attachment (id=159787)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159787action=view)
mock build log

the build failed in mock too (F7 x86_64)
log is attached.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220706] Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, 
man page


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220706





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:48 EST ---
I have updated the spec file.

http://snecker.fedorapeople.org/linuxwacom.spec

Mainly rpmlint cleanups but some errors which would have been blockers for
approval. Unfortunately wacomcpl does *not* work for me - I'm currently
investigating.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:52 EST ---
ok it seems not to be smp build safe remove the smp_flags from make.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:57 EST ---
For 0.1.0-1:

* License
  - While COPYING says this is licensed under LGPL (and you
tagged this rpm as such, although COPYING is missing on
%doc entry), common.c, instrum.c, etc... are licensed 
under _GPL_ .

? Dependency
  - Would you explain why main package should explicitly have
Requires: timidity++?

? binary executable files
  - Are test/.libs/{playmidi,midi2raw} of no use?
(playmidi seems to be created only with have libao-devel
 installed).

* libtimidity.pc
  - Why does this need -lm on Libs? Linkage against libm.so
is already done on libtimidity.so and extra linkage like
this must be removed unless header files installed require
it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 10:59 EST ---
It seems that parallel build is not always functional. I've informed upstream
who will look into it.

New spec + src.rpm are available at
http://wolfy.fedorapeople.org/qfaxreader.spec
http://wolfy.fedorapeople.org/qfaxreader-0.3.1-4.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226427] Merge Review: specspo

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: specspo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226427


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:04 EST ---
Package Change Request
==
Package Name: specspo
Updated Fedora Owners: [EMAIL PROTECTED]

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 244623] Review Request: OggConvert - OggConvert is a small GNOME utility that uses GStreamer to convert media files to the licence-free Theora and Vorbis formats.

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OggConvert - OggConvert is a small GNOME utility that 
uses GStreamer to convert media files to the licence-free Theora and Vorbis 
formats.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244623





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:05 EST ---
Description is fixed, however upstream package for OggConvert 0.2.1.1 has issues
during build that affected upstream, so I notified upstream so that he will fix
it. I do not think it would be worth rebuilding because apparently there were
files missing in 0.2.1, so I am waiting for 0.2.1.1 to be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:10 EST ---
you still have /usr/bin in %files please use %{_bindir}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:18 EST ---
(In reply to comment #1)
 For 0.1.0-1:
 
 * License
   - While COPYING says this is licensed under LGPL (and you
 tagged this rpm as such, although COPYING is missing on
 %doc entry), common.c, instrum.c, etc... are licensed 
 under _GPL_ .
 

These files come from timidity (through SDL_mixer, which also is LGPL), when
timidity was discontinued it was set free under a choice if GPL / LGPL /
artistic, see:
http://web.archive.org/web/20010106150700/http://www.cgs.fi/~tt/discontinued.html

Also see the first paragraph of the included COPYING which says:

Please note that the included source from TiMidity, is also licensed
 under the following terms (GNU LGPL), but can also be used separately
 under the GNU GPL, or the Perl Artistic License. Those licensing
 terms are not reprinted here, but can be found on the web easily.

I will include the missing COPYING file, good catch.

 ? Dependency
   - Would you explain why main package should explicitly have
 Requires: timidity++?
 

Because timidity++ provides the necessary patch files containing the wavetable
instruments, this is why for example SDL_mixer and allegro also require 
timidity++.

 ? binary executable files
   - Are test/.libs/{playmidi,midi2raw} of no use?
 (playmidi seems to be created only with have libao-devel
  installed).
 

There already is a cmdline utility called playmidi (or atleast was), also we
already have playmus from SDL_mixer and timidity itself through timidity++,
notice that the standalone version of timidity is of much better quality (and
much more cpu intensive). So I see little use in these test apps, if people want
to play or convert midi using timidity they should be using the standalone 
version.


 * libtimidity.pc
   - Why does this need -lm on Libs? Linkage against libm.so
 is already done on libtimidity.so and extra linkage like
 this must be removed unless header files installed require
 it.

Many package config files contain libs in the LDFLAGS against which the lib
itself is already linked, this is normal behaviour as not all Unix OS's support
.so files having deps, so sometimes the app itself must be linked against the
deps, so that the symbols will be there for the lib.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 246312] Review Request: Pygments - A syntax highlighting engine written in Python

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Pygments - A syntax highlighting engine written in 
Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246312





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:25 EST ---
Sorry about that. My fault. 
Can you try it now? It should work...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] New: Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296

   Summary: Review Request: libgeotiff - GeoTIFF format handler
library
   Product: Fedora
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://openrisc.rdsor.ro/libgeotiff.spec
SRPM URL: http://openrisc.rdsor.ro/libgeotiff-1.2.4rc1.fc8.src.rpm
Description: Libgeotiff is a public domain library normally hosted on top of 
libtiff for reading, and writing GeoTIFF information tags.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178162] Review Request: libgeotiff

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178162


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:36 EST ---


*** This bug has been marked as a duplicate of 249296 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:36 EST ---
*** Bug 178162 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:41 EST ---
Package Review:
==
--
MUST: rpmlint must be run on every package.
--
OK, no output.
--
MUST: The package must be named according to the Package Naming Guidelines.
--
OK
--
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec 
--
OK
--
MUST: The package must meet the  Packaging Guidelines.
--
NOT OK!
Please replace /usr/bin in %files with %{_bindir}
--
MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements.
--
OK
--
MUST: The License field in the package spec file must match the actual license.
--
OK (GPL)
--
MUST: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, 
containing the text of the license(s) for the package must be included in %doc.
--
OK
--
MUST: The spec file must be written in American English.
--
OK
--
MUST: The spec file for the package MUST be legible.
--
OK
--
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
--
OK (mdsum = 165774433c44f721e82552c866e7be87)
--
MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
--
OK (Tested on F7 x86_64)
--
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in 
ExcludeArch.
--
N/A
--
MUST: All build dependencies must be listed in BuildRequires.
--
OK
--
MUST: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation of
that specific package.
--
OK (not relocateable)
--
MUST: A package must own all directories that it creates.
--
OK
--
MUST: A package must not contain any duplicate files in the %files listing.
--
OK
--
MUST: Permissions on files must be set properly.
--
OK
--
MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
--
OK
--
MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines. 
--
NOT OK!
Please replace /usr/bin in %files with %{_bindir}
--
MUST: The package must contain code, or permissable content. 
--
OK
--
MUST: If a package includes something as %doc, it must not affect the runtime of
the application.
--
OK
--
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
--
OK
--
MUST: Packages must not own files or directories already owned by other 
packages. 
--
OK
--
MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
--
OK
--
MUST: All filenames in rpm packages must be valid UTF-8.
--
SHOULD: The reviewer should test that the package builds in mock.
--
OK (builds fine on F7 x86_64)
--

[Bug 245045] Review Request: re2c - Tool for generating C-based recognizers from regular expressions

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: re2c -  Tool for generating C-based recognizers from 
regular expressions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245045





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:50 EST ---
re2c-0.12.1-2.fc7 has been pushed to the Fedora 7 stable repository.  If 
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249214] Review Request: alienblaster - Action-loaded 2D arcade shooter game

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alienblaster - Action-loaded 2D arcade shooter game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249214


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 245045] Review Request: re2c - Tool for generating C-based recognizers from regular expressions

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: re2c -  Tool for generating C-based recognizers from 
regular expressions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245045


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||ERRATA
   Fixed In Version||0.12.1-2.fc7




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 243631] Review Request: msmtp - an SMTP client

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: msmtp - an SMTP client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243631





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:50 EST ---
msmtp-1.4.12-7.fc7 has been pushed to the Fedora 7 stable repository.  If 
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 243631] Review Request: msmtp - an SMTP client

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: msmtp - an SMTP client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243631


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|CLOSED  |CLOSED
 Resolution|NEXTRELEASE |ERRATA
   Fixed In Version||1.4.12-7.fc7




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 11:55 EST ---
New version uploaded. Changes:
- fixes the missing macro usage
- re-enables parallel build.

Please let me know if these build on your system:
 http://wolfy.fedorapeople.org/qfaxreader.spec
 http://wolfy.fedorapeople.org/qfaxreader-0.3.1-5.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:18 EST ---
build fails in the same way.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 230802] Review Request: perl-Callback - Object interface for function callbacks

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Callback - Object interface for function callbacks
Alias: perl-Callback

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230802





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:22 EST ---
Well, all you're required to do for the release branches is described in step 11
of that document; I see nothing incorrect there that would need to be updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178162] Review Request: libgeotiff

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178162


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |201449
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation 
utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:26 EST ---
tryed in mock here is the output:

make[2]: Leaving directory `/builddir/build/BUILD/qfaxreader-0.3.1/pix'
Making all in src
make[2]: Entering directory `/builddir/build/BUILD/qfaxreader-0.3.1/src'
 cd ..  /bin/sh /builddir/build/BUILD/qfaxreader-0.3.1/missing --run
automake-1.9 --gnu  src/Makefile
/builddir/build/BUILD/qfaxreader-0.3.1/missing: line 52: automake-1.9: command
not found
WARNING: `automake-1.9' is missing on your system.  You should only need it if
 you modified `Makefile.am', `acinclude.m4' or `configure.in'.
 You might want to install the `Automake' and `Perl' packages.
 Grab them from any GNU archive site.
/usr/lib64/qt-3.3/bin/uic alias.ui -o alias.h
make[2]: *** No rule to make target `alias.h', needed by `all'.  Stop.
make[2]: *** Waiting for unfinished jobs
/usr/lib64/qt-3.3/bin/uic -impl alias.h alias.ui -o alias.cpp
/usr/lib64/qt-3.3/bin/moc alias.h  alias.cpp
make[2]: Leaving directory `/builddir/build/BUILD/qfaxreader-0.3.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/qfaxreader-0.3.1'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.64731 (%build)


RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.64731 (%build)
-

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:26 EST ---
(In reply to comment #0)
 Spec URL: http://openrisc.rdsor.ro/libgeotiff.spec
 SRPM URL: http://openrisc.rdsor.ro/libgeotiff-1.2.4rc1.fc8.src.rpm

Both seems 404?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:35 EST ---
(A note:
 For pre-versions like rc, the EVR of rpm must be like:
 1.2.4-0.X.rcY to avoid broken EVR path.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:36 EST ---
All right.
Please add COPYING on CVS.

---
  This package (libtimidity) is APPROVED by me
---

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:51 EST ---
Thanks for the review!

New Package CVS Request
===
Package Name:  libtimidity
Short Description: MIDI to WAVE converter library
Owners:[EMAIL PROTECTED]
Branches:  FC-6 F-7 devel
InitialCC: empty



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:51 EST ---
I am sorry.

re-uploaded.

Spec URL: http://openrisc.rdsor.ro/libgeotiff.spec
SRPM URL: http://openrisc.rdsor.ro/libgeotiff-1.2.4-0.1.rc1.fc8.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 12:56 EST ---
EPSG dataset license is OK now.

Confirmed by Thomas Callaway [EMAIL PROTECTED], olso FSF.

   Minor thing is that EPSG dataset is splitted in csv files, see
ChangeLog but without alter the data essence itself, just 
reorganise original EPSG wich comes as SQl dumps or MS Access 
files.
   EPSG hates alter of dataset so I must be carefull looking at that.

At a point my plan is to split separate epsg-data.noarch one and re-base
gdal and geotiff over it. Thats should be clearest way include EPSG 
dataset, and trace down how csv files are generated.

~cristian


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 244623] Review Request: OggConvert - OggConvert is a small GNOME utility that uses GStreamer to convert media files to the licence-free Theora and Vorbis formats.

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OggConvert - OggConvert is a small GNOME utility that 
uses GStreamer to convert media files to the licence-free Theora and Vorbis 
formats.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244623





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:30 EST ---
updated to 0.2.1.1, which according to the upstream, will address issues
regarding the building of the application without missing files...

Spec URL: http://rpm.rgw-net.com/SPECS/oggconvert.spec

RPM URL: 
http://rpm.rgw-net.com/RPMS/fc7/noarch/oggconvert-0.2.1.1-8.fc7.noarch.rpm
md5sum: d675b34744eb39768c86c46ce55a4964
sha1sum: 7e627bb1aa0f1cac9ac4263b4bb164aa8457916c

SRPM URL: http://rpm.rgw-net.com/RPMS/fc7/SRPMS/oggconvert-0.2.1.1-8.fc7.src.rpm
md5sum: ee64a2cb4455a23fd16d819b6dca4815
sha1sum: 2ccec0f23dc34739518602d70db40ad01d980a71

This rpm are digitally signed and the GPG key is available, the instructions
for my GPG key are at rpm.rgw-net.com (my first name is Neal)

Hopefully, mock will build fine with this... aside from my GPG key if it isnt
imported... Also, the description issues were fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 240807] Review Request: asl - Macro Assembler AS

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asl - Macro Assembler AS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240807


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|CLOSED
 Resolution||NOTABUG
   Flag|fedora-review?, |fedora-review-
   |needinfo?([EMAIL PROTECTED])|




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:30 EST ---
CLOSING.

If someone want to maintain this package, please sumbit a new
review request, Thanks.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 229098] Review Request: openjpeg - JPEG 2000 codec library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library
Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:31 EST ---
Last ping !

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241475] Review Request: ocaml-ulex - OCaml lexer generator for Unicode

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-ulex - OCaml lexer generator for Unicode


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241475





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:33 EST ---
ping ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 241473] Review Request: ocaml-ssl - SSL bindings for OCaml

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-ssl - SSL bindings for OCaml


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241473





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:33 EST ---
ping ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 247402] Review Request: GspiceUI - A GUI to freely available Spice Electronic circuit similators

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GspiceUI - A GUI to freely available Spice Electronic 
circuit similators


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247402


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED])




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:37 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249251] Review Request: hardinfo - System Profiler and Benchmark

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hardinfo - System Profiler and Benchmark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249251


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248996] Review Request: libopensync-plugin-synce - Synce plugin for libopensync

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopensync-plugin-synce - Synce plugin for libopensync


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248996


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248899] Review Request: kdelibs3 - K Desktop Environment 3 - Libraries

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdelibs3 - K Desktop Environment 3 - Libraries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248899


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248857] Review Request: schedtool - A tool to query or alter process scheduling policy

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schedtool - A tool to query or alter process 
scheduling policy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248857


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248730] Review Request: nss_compat_ossl - OpenSSL to NSS porting library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nss_compat_ossl - OpenSSL to NSS porting library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248730


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248457] Review Request: perl-Devel-Profiler - Perl profiler compatible with dprofpp

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Devel-Profiler - Perl profiler compatible with 
dprofpp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248457


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 247402] Review Request: GspiceUI - A GUI to freely available Spice Electronic circuit similators

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GspiceUI - A GUI to freely available Spice Electronic 
circuit similators


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247402





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 13:55 EST ---
Actually, Xavier and I are working on packaging the _latest_ gwave .
(gwave2-20070514) I repeat _latest_.

We are having difficulties and still struggling in rpmbuiling that latest 
release since it requires many dependencies.
V buildrequires W
W buildrequires X
X buildrequires Y
Y buildrequires Z

We were able to build the previous release of gwave-20060606 which required 
only guile-gtk and compat-guile-16.
http://chitlesh.fedorapeople.org/RPMS/gwave/gwave.png
But, that gwave-20060606 can't be built on the latest guile-gtk-2. So we opted 
for now, the 1.2 version of guile-gtk which is only available on the debian 
repository.

We are now working to meet the dependencies of the latest gwave.
But I'm not in favour of doing so, since 2 or 3 dependencies are either keep 
on changing names or being split.

In accordance to 2 fedora-geda users (to whom I talked), they would be happy 
to have at least gwave-20060606 for their simulations.

Our work can be found here:
* http://laxathom.fedorapeople.org/RPMS/
* http://chitlesh.fedorapeople.org/RPMS/gwave/ (my specs needs to be polished 
and are met for testing functional use only)

So now, the question is:
are we willing to ship 
 *the latest gwave and at the same time shipping lots of old dependencies ?
or
 *the gwave-2006006 and one dependency ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248427] Review Request: perl-Authen-PAM - Authen::PAM Perl module

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Authen-PAM - Authen::PAM Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248427


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 247402] Review Request: GspiceUI - A GUI to freely available Spice Electronic circuit similators

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GspiceUI - A GUI to freely available Spice Electronic 
circuit similators


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247402





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 14:36 EST ---
Well, I don't know well about gwave, however is gwave really
not bypassed to proceed the review of this package?
Current gspiceui does not require gwave, so you can just ignore
gwave for now?

For gwave:
(In reply to comment #16)
 So now, the question is:
 are we willing to ship 
  *the latest gwave and at the same time shipping lots of old dependencies ?
Absolutely, unless the newest gwave has regression issue problems,
for example.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] New: Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325

   Summary: Review Request: yum-updatesd - Update notification
daemon
   Product: Fedora
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://katzj.fedorapeople.org/yum-updatesd.spec
SRPM URL: 
http://katzj.fedorapeople.org/repos/yum-updatesd/yum-updatesd-0.3-1.fc8.noarch.rpm
Description: 
yum-updatesd provides a daemon which checks for available updates and
can notify you when they are available via email, syslog or dbus.

Note: this is the new and split out yum-updatesd.  It has an epoch of 1 so that 
it will update the standalone version from the yum package (which will be gone 
as of yum 3.2.3, and will be removed from rawhide when we push this package 
into the repo).

[EMAIL PROTECTED] repo]$ rpmlint yum-updatesd-0.3-1.fc8.src.rpm  
yum-updatesd-0.3-1.fc8.noarch.rpm
W: yum-updatesd invalid-license GPLv2
W: yum-updatesd invalid-license GPLv2

This is pedantically correct.

W: yum-updatesd conffile-without-noreplace-flag 
/etc/dbus-1/system.d/yum-updatesd.conf

dbus configs aren't intended to be human editable

W: yum-updatesd service-default-enabled /etc/rc.d/init.d/yum-updatesd

We intentionally have the service enabled by default so that users can take 
advantage of it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 14:53 EST ---
You meant:
http://katzj.fedorapeople.org/repos/yum-updatesd/yum-updatesd-0.3-1.fc8.src.rpm
for the source rpm, right?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 15:06 EST ---
Created an attachment (id=159804)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159804action=view)
mock build log of libgeotiff 1.2.4-0.1.rc1 on rawhide i386

Very rapid comment because I want to go to bed..

* debuginfo rpm is of no use. It seems that -g option is
  removed.
* I suggest to move the header files to the subdirectory of /usr/include
  and hide them from /usr/include (as you wrote on .pc file)
* Specify the full URL of the source.
* I may be wrong, however (for example)
  /usr/include/geonames.h contains

47  static KeyInfo _keyInfo[] =  {
48  #   include geokeys.inc   /* geokey database */
49  END_LIST

  but geokeys.inc is missing?
* /usr/include/xtiffio.h contains

10  #include tiffio.h

  And it seems that tiffio.h is included in libtiff-devel.
  So libgeotiff-devel should require libtiff-devel.
* Check if

make install DESTDIR=foo INSTALL=%{__install} -p

  works to keep timestamps on the header files installed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 15:09 EST ---
Yes.  One of these days I'll learn to type what I mean :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 15:25 EST ---
I have 4 minor nits:
* use BuildArch instead of BuildArchitectures
* use the 4 argument form of defattr
* include a full url for source0 (when such a thing exists)
* use sh rather than bash for the init script (if possible)

These are just my preferences, however.

Review:
* source files match upstream:
   Jeremy is the upstream, so this is ok.   
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (F7, i686).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   config(yum-updatesd) = 1:0.3-1.fc7
   yum-updatesd = 1:0.3-1.fc7
  =
   /bin/bash  
   /bin/sh  
   /sbin/chkconfig  
   /sbin/service  
   /usr/bin/python  
   config(yum-updatesd) = 1:0.3-1.fc7
   dbus-python  
   gamin-python  
   pygobject2  
   python = 2.4
   yum = 3.2.0
* %check is not present (no test suite upstream)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriplets are sane.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 15:30 EST ---
(In reply to comment #3)
 I have 4 minor nits:
 * use BuildArch instead of BuildArchitectures
 * use the 4 argument form of defattr

Fixed both of these in git for the next version

 * include a full url for source0 (when such a thing exists)

This is in progress and I'll get it added in the next couple of days

 * use sh rather than bash for the init script (if possible)

This will break the initscript translation stuff as it's bash-specific how that
works

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 15:31 EST ---
New Package CVS Request
===
Package Name:  yum-updatesd
Short Description: Update notification daemon
Owners: [EMAIL PROTECTED]
Branches: devel

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 238994] Review Request: memcached - High Performance, Distributed Memory Object Cache

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: memcached - High Performance, Distributed Memory 
Object Cache


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238994





--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 15:36 EST ---
Could you please build EPEL branches as well?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248457] Review Request: perl-Devel-Profiler - Perl profiler compatible with dprofpp

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Devel-Profiler - Perl profiler compatible with 
dprofpp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248457


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248434] Review Request: perl-HTTP-DAV - WebDAV client library for Perl5

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTTP-DAV - WebDAV client library for Perl5


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248434


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248427] Review Request: perl-Authen-PAM - Authen::PAM Perl module

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Authen-PAM - Authen::PAM Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248427


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248431] Review Request: perl-Net-FTPServer - Secure, extensible and configurable Perl FTP server

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-FTPServer - Secure, extensible and 
configurable Perl FTP server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248431


Bug 248431 depends on bug 248427, which changed state.

Bug 248427 Summary: Review Request: perl-Authen-PAM - Authen::PAM Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248427

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249059] Review Request: wdaemon - hotplug helper for wacom x.org driver

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wdaemon - hotplug helper for wacom x.org driver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249059


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 16:44 EST ---
First pass through the spec...

1) Why the use of ExclusiveArch, then list just about all possible arches? I
think an ExcludeArch for the arch or arches it doesn't build on might be better.
So far as I can see, that list is really just s390/s390x, no?

2) %makeinstall is a big no-no :)
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002

3) the CFLAGS aren't being honored.

I've actually got a patch in hand that'll make 'make install
DESTDIR=$RPM_BUILD_ROOT' work, as well as the CFLAGS honored:

8
--- wdaemon-0.10/Makefile   2007-07-20 12:07:44.0 -0400
+++ wdaemon-0.10.updated/Makefile   2007-07-23 16:30:06.0 -0400
@@ -1,4 +1,4 @@
-CFLAGS = -O0 -g -Wall
+CFLAGS ?= -O0 -g -Wall
 OBJS = hotplug.o \
input.o \
monitored.o \
@@ -24,10 +24,10 @@ wdaemon: $(OBJS)
gcc $(CFLAGS) -c -o $@ $
 
 install:
-   mkdir -p $(bindir)
-   cp wdaemon $(bindir)/
-   mkdir -p $(sysconfdir)/rc.d/init.d/
-   cp wdaemon.initrd $(sysconfdir)/rc.d/init.d/wdaemon
+   mkdir -p $(DESTDIR)$(bindir)
+   cp wdaemon $(DESTDIR)$(bindir)/
+   mkdir -p $(DESTDIR)$(sysconfdir)/rc.d/init.d/
+   cp wdaemon.initrd $(DESTDIR)$(sysconfdir)/rc.d/init.d/wdaemon
 
 clean:
rm -f *.o wdaemon core
8

4) I'd install is_uinput.sh mode 755 instead of 644, which also eliminates the
need for the %attr stuff on that file in %files.

That's all I've got so far... rpmlint output is fairly clean, just two warnings
about the udev rules files not being marked as config files. Not sure yet if
they should be, or if we just ignore those.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249059] Review Request: wdaemon - hotplug helper for wacom x.org driver

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wdaemon - hotplug helper for wacom x.org driver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249059


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249214] Review Request: alienblaster - Action-loaded 2D arcade shooter game

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alienblaster - Action-loaded 2D arcade shooter game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249214


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2007-07-23 17:01 EST ---
imported, build and submitted as F-7 update, closing.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249325] Review Request: yum-updatesd - Update notification daemon

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248425] Review Request: perl-File-Sync - Perl access to fsync() and sync() function calls

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-File-Sync - Perl access to fsync() and sync() 
function calls


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248425


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248403] Review Request: perl-Test-Class - Easily create test classes in an xUnit/JUnit style

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Class - Easily create test classes in an 
xUnit/JUnit style


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248403


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249352] New: Review Request: popt - C library for parsing command line parameters

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249352

   Summary: Review Request: popt - C library for parsing command
line parameters
   Product: Fedora
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://labs.linuxnetz.de/bugzilla/popt.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/popt-1.12-1.src.rpm
Description: Popt is a C library for parsing command line parameters. Popt
was heavily influenced by the getopt() and getopt_long() functions, but it
improves on them by allowing more powerful argument expansion. Popt can parse
arbitrary argv[] style arrays and automatically set variables based on command
line arguments. Popt allows command line arguments to be aliased via
configuration files and includes utility functions for parsing arbitrary
strings into argv[] arrays using shell-like rules.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248400] Review Request: perl-Test-File-Contents - Test routines for examining the contents of files

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-File-Contents - Test routines for examining 
the contents of files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248400


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248396] Review Request: perl-Text-Diff-HTML - XHTML format for Text::Diff::Unified

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-Diff-HTML - XHTML format for 
Text::Diff::Unified


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248396


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 248394] Review Request: perl-Text-LevenshteinXS - XS implementation of the Levenshtein edit distance

2007-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-LevenshteinXS - XS implementation of the 
Levenshtein edit distance


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248394


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >