[Bug 443871] Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN
Alias: perl-CPAN-Mini

https://bugzilla.redhat.com/show_bug.cgi?id=443871





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 02:00 EST ---
Updated per comment #4:

SRPM URL:
http://fedora.biggerontheinside.net/review/perl-CPAN-Mini-0.571-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 02:04 EST ---
(In reply to comment #31)
 This time your srpm does not build.
 http://koji.fedoraproject.org/koji/taskinfo?taskID=635125

Sorry I built this not for the target olpc-3 but for the target
dist-f10. Actually on i386 (i.e. on olpc-3) build succeeds.
Will check later. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 02:44 EST ---
Okay, good

--
This package (olpcsound) is APPROVED by me
--

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from Get a Fedora Account.
At a point a mail should be sent to sponsor members which notifies
that you need a sponsor. At the stage, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 03:07 EST ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=635914

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] New: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=449067

   Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst
generic session plugin
   Product: Fedora
   Version: rawhide
  Platform: All
   URL: http://search.cpan.org/dist/Catalyst-Plugin-Session/
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


SRPM URL: 
http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session-0.19-1.fc8.src.rpm
SPEC URL: 
http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session.spec

Description:
This plugin is the base of two related parts of functionality
required for session management in web applications.

The first part, the State, is getting the browser to repeat back a
session key, so that the web application can identify the client and
logically string several requests together into a session.

The second part, the Store, deals with the actual storage of information
about the client. This data is stored so that the it may be revived for
every request made by the same client.

This plugin links the two pieces together.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443871] Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN
Alias: perl-CPAN-Mini

https://bugzilla.redhat.com/show_bug.cgi?id=443871


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 03:30 EST ---
new source md5sum (matches upstream) : 0fcaa2f7ee4872c51ae62620ec04f221

Still requires perl = 0:5.006
sed -i -e '/use 5.006;/d' Makefile.PL fixes it, but this is harmless.

Looks good, APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437285] Review Request: libgphoto2 - Library for accessing digital cameras

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgphoto2 - Library for accessing digital cameras


https://bugzilla.redhat.com/show_bug.cgi?id=437285


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 03:46 EST ---
Review:
+ package builds in mock.
Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=635914
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
eb7e9679234cd4f4269b5b1869141082  Catalyst-Plugin-Session-0.19.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
All tests successful, 3 tests skipped.
Files=8, Tests=33,  1 wallclock secs ( 1.01 cusr +  0.07 csys =  1.08 CPU)
+ package perl-Catalyst-Plugin-Session-0.19-1.fc9 =
  Provides: perl(Catalyst::Plugin::Session) = 0.19
perl(Catalyst::Plugin::Session::State) perl(Catalyst::Plugin::Session::Store)
perl(Catalyst::Plugin::Session::Store::Dummy)
perl(Catalyst::Plugin::Session::Test::Store)
perl(Catalyst::Plugin::SessionStateTest)
  Requires: perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Catalyst)
perl(Catalyst::Exception) perl(Catalyst::Test) perl(Digest) perl(File::Spec)
perl(File::Temp) perl(NEXT) perl(Object::Signature) perl(Test::More) perl(base)
perl(overload) perl(strict) perl(utf8) perl(warnings)

I don't know why some tests got skipped 
all skipped: Catalyst::Plugin::Session::State::Cookie version 0.03 or
higher is required for this test
 See build.log



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442507] Review Request: libspe2 - SPE Runtime Management Library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libspe2 - SPE Runtime Management Library


https://bugzilla.redhat.com/show_bug.cgi?id=442507





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 04:00 EST ---
Sorry for the confusion. 
I'm at the LinuxTag and I have only limited access to the internet. I'll upload
the files to the link mentioned in comment #1 as soon as possible. Some of the
point mentioned by Robert are already addressed. I just had a talk with Robert. 

Thanks for your interest.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188542] Review Request: hylafax

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 04:13 EST ---
You want proof? No problem. ;) The spec file contains 

  %{_libdir}/*

which also includes /usr/lib/debug recursively.
Instead, you want the more explicit

  %{_libdir}/libfax*

or

  %{_libdir}/*.so.*

That your own build does not include debuginfo files means that
you don't have the redhat-rpm-config installed. Packagers should
yum install rpmdevtools.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188542] Review Request: hylafax

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 04:16 EST ---
 ghostscript-fonts

$ rpm -q ghostscript-fonts hylafax
ghostscript-fonts-5.50-18.fc8
hylafax-5.2.5-1.fc8

It was installed already. It doesn't add /usr/share/ghostscript/fonts 
but /usr/share/fonts/default/ghostscript:

$ rpmls ghostscript-fonts|grep ^d
drwxr-xr-x  /etc/X11/fontpath.d
drwxr-xr-x  /usr/share/fonts/default
drwxr-xr-x  /usr/share/fonts/default/ghostscript


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448582] Review Request: automoc - KDE4 Automoc

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: automoc - KDE4 Automoc


https://bugzilla.redhat.com/show_bug.cgi?id=448582


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 05:08 EST ---
New Package CVS Request
===
Package Name: automoc
Short Description: KDE4 Automoc
Owners: arbiter,rdieter,kkofler,tuxbrewr
Branches: F-8 F-9
InitialCC:
Cvsextras Commits:


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435016] Review Request: mmdb - MMDB coordinate library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mmdb - MMDB coordinate library


https://bugzilla.redhat.com/show_bug.cgi?id=435016





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 05:34 EST ---
(In reply to comment #8)
 One final, last minute issue:
 
 Where is the upstream of this package?
 
 AFAIU, the original tarballs are those in
 http://www.ebi.ac.uk/~keb/cldoc/downloads/
 while
 ftp://ftp.bioxray.au.dk/pub/mok/src/ 
 hosts repackaged tarballs w/ autotool-support having been added. 
 
 This wouldn't be much of a problem, if the original upstream was dead, but it
 apparently isn't. It released an update a couple of days ago.
 

See:

http://www.bioxray.dk/~mok/mmdb.php

quote:
This distribution is based on the last free version of mmdb, namely 1.09.
Eugene's latest version of mmdb (1.10) is licensed under the non-free CCP4 
license.

The licensing, however, seems to have switched back to the LGPL:

http://www.ccp4.ac.uk/ccp4license.php

I can bring this issue up with those involved and see what the current status
is.  My hope is that the current fork will only be temporary.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448582] Review Request: automoc - KDE4 Automoc

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: automoc - KDE4 Automoc


https://bugzilla.redhat.com/show_bug.cgi?id=448582





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 05:19 EST ---
New Package CVS Request
===
Package Name: automoc
Short Description: KDE4 Automoc
Owners: arbiter,rdieter,kkofler,tuxbrewr
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442507] Review Request: libspe2 - SPE Runtime Management Library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libspe2 - SPE Runtime Management Library


https://bugzilla.redhat.com/show_bug.cgi?id=442507





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 05:19 EST ---
The spec file and the src.rpm are available again on: 

Spec URL: ftp://testcase.software.ibm.com/fromibm/linux/libspe2.spec
SRPM URL: 
ftp://testcase.software.ibm.com/fromibm/linux/libspe2-2.2.80-95.src.rpm

I'll reply to your comments as soon as possible. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 439337] Review Request: python-sphinx - Python documentation generator

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-sphinx - Python documentation generator


https://bugzilla.redhat.com/show_bug.cgi?id=439337


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 06:04 EST ---
Two brief notes:

1) You define %pyver but you never use it.
2) The srpm spec file still has the exclusion part while the spec you present in
the entry above  does not have it. Of course the spec without the exclusion is
the right one.

These points are minor and can be fixed later when importing.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 07:07 EST ---
Thanks! 
My FAS name is veplaini



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448702] Review Request: SndObj - The Sound Object Library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SndObj - The Sound Object Library


https://bugzilla.redhat.com/show_bug.cgi?id=448702


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 07:17 EST ---
Removing NEEDSPONSOR, I am sponsoring

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 07:17 EST ---
Now I should be sponsoring you. Please follow Join wiki
again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 07:46 EST ---
New Package CVS Request
===
Package Name: olpcsound
Short Description: olpc subset of csound 5
Owners: veplaini
Branches: olpc-3
InitialCC: veplaini
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445105] Review Request: milkytracker - SDL clone of the Fasttracker II module tracker

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: milkytracker - SDL clone of the Fasttracker II module 
tracker


https://bugzilla.redhat.com/show_bug.cgi?id=445105





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 07:48 EST ---
Sorry for delay...

(In reply to comment #5)
 * Mon May 26 2008 Joonas Sarajärvi [EMAIL PROTECTED] - 0.90.80-2
 - Modified a Makefile.am to not compile the included static zlib library.
 The included Zlib isn't compiled in this release, 

Well, I reviewed your patch, however in fact 
patching against Makefile.am does not do anything, because
configure created Makefile from Makefile.in, not from Makefile.am
and Makefile.in is not automatically regenerated from Makefile.am.

 but the
 zziplib library in Milkytracker seems quite modified to me, 
 and I haven't got MT
 to build with Fedora-provided zziplib.

Would you check the following?
http://koji.fedoraproject.org/koji/taskinfo?taskID=636231
http://koji.fedoraproject.org/scratch/mtasaka/task_636231/

I applied a patch to use system-wide zziplib. milkytracter does not use zlib
directly.


Now I will wait for your another review request submit or pre-review
of other person's review request.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448531] Review Request: pyrenamer - A mass file renamer written in PyGTK

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyrenamer - A mass file renamer written in PyGTK


https://bugzilla.redhat.com/show_bug.cgi?id=448531





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 08:09 EST ---
Spec URL: http://lokthare.fedorapeople.org/temp/pyrenamer.spec
SRPM URL: http://lokthare.fedorapeople.org/temp/pyrenamer-0.5.0-4.fc9.src.rpm
- Fix Requires : Add gnome-python2-gconf and pygtk2-libglade

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428410] Review Request: LADR - Library for Automated Deduction Research

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LADR - Library for Automated Deduction Research


https://bugzilla.redhat.com/show_bug.cgi?id=428410





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 08:14 EST ---
Good plan. I am going to resubmit this next week as prover9 to FC9 with a
local patch (as far as I know the upstream developer has not produced a new
release including this patch), hopefully then someone will sponsor it going into
the Extras repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
   Fixed In Version||libxml2-2.6.32-3.fc10
 Resolution||CURRENTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 08:35 EST ---
I think I have done most of this. The most annoying point is the static
lib because I know some people use that to shave 2% of extra performance
on parsing speed. But by separating as a -static package that's reasonable.
For the file-not-utf8, sorry can't fix here, report upstream if you believe
it's worth it.
Ah the patch is not dependent on the version of the libxml2 package but on
multiarch crazyness, so just renamed libxml2-multilib.patch

Considered done from my POV,

Daniel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448531] Review Request: pyrenamer - A mass file renamer written in PyGTK

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyrenamer - A mass file renamer written in PyGTK


https://bugzilla.redhat.com/show_bug.cgi?id=448531


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 09:21 EST ---
Okay.


   This package (pyrenamer) is APPROVED by me


Please follow
http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess
from step 7.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 09:28 EST ---
(In reply to comment #2)
[...]
 For the file-not-utf8, sorry can't fix here,

Sure you can. What's stopping you?

 report upstream if you believe it's worth it.

I believe it's the maintainer's job to do that. Upstream might not want to
convert to UTF-8, but it is a Fedora requirement for all text documents in a
package to be encoded in UTF-8, so it is your responsibility.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436677] Review Request: xxdiff

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xxdiff


https://bugzilla.redhat.com/show_bug.cgi?id=436677


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||182235
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436677] Review Request: xxdiff

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xxdiff


https://bugzilla.redhat.com/show_bug.cgi?id=436677





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 09:52 EST ---
(In reply to comment #23)
 Finally, can someone please comment on the copyright notice at the bottom of 
 /usr/share/doc/xxdiff-3.2/doc/screenshots/allindex.html (and other files in 
 that
 directory). It says:
 
 All images and material are Copyright © 2001 Martin Blais, Montreal, Canada.
 All Rights Reserved. Images may not be used without written permission.
 If you would like to license or use an image, please contact [EMAIL 
 PROTECTED] 
 
 Does that cause any problems for us?

Yes. Either get written permission to freely redistribute and modify or pull out
these docs/images.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435016] Review Request: mmdb - MMDB coordinate library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mmdb - MMDB coordinate library


https://bugzilla.redhat.com/show_bug.cgi?id=435016


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 10:07 EST ---
Technically, you can consider this package approved, however ... this package
needs a legal review - Spot this pumpkin is yours.

In my understanding, this package, using the tarball Tim is using (an apparent
fork from it's original upstream), is licenced under a LGPLv2+ with 
exceptions.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 10:36 EST ---
What's stopping me ? ... maybe realizing this exercise is just about
dogmatic rules, and as you proved, I should rather spend 30 mn of my time
as the libxml2/libxslt upstream maintainer on patch review than just
getting annoyed by people who insist on changing package content at the
distro level. I was about to conver libsxlt along those lines, but right
I'm better off checking the patches from Huawei on the xml list.

Daniel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448531] Review Request: pyrenamer - A mass file renamer written in PyGTK

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyrenamer - A mass file renamer written in PyGTK


https://bugzilla.redhat.com/show_bug.cgi?id=448531


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 10:39 EST ---
New Package CVS Request
===
Package Name: pyrenamer
Short Description: A mass file renamer written in PyGTK
Owners: lokthare
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438433] Review Request: python-toscawidgets - Web widget toolkit

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-toscawidgets - Web widget toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=438433


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 10:49 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
   Keywords||Reopened
 Resolution|CURRENTRELEASE  |




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 11:14 EST ---
Can you please take care on all points mentioned in the review before closing 
this bug report? And please don't close this bug report until you got an 
approval
for your package - thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 429486] Review Request: screenlets - A widget system for Compiz-fusion and Beryl

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: screenlets - A widget system for Compiz-fusion and 
Beryl


https://bugzilla.redhat.com/show_bug.cgi?id=429486





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 11:31 EST ---
I do it tonight, sorry for being late... lot of works lasts weeks.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 11:34 EST ---
Including ::Cookie as a BR would create a circular buildloop, as ::Cookie has
::Session as a mandatory BR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443871] Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN
Alias: perl-CPAN-Mini

https://bugzilla.redhat.com/show_bug.cgi?id=443871


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443871] Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN
Alias: perl-CPAN-Mini

https://bugzilla.redhat.com/show_bug.cgi?id=443871





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 11:36 EST ---
New Package CVS Request
===
Package Name: perl-CPAN-Mini
Short Description: Create a minimal mirror of CPAN
Owners: cweyl
Branches: F-7, F-8, F-9, devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 411551] Review Request: perl-DBIx-Class - Extensible and flexible object - relational mapper

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DBIx-Class - Extensible and flexible object - 
relational mapper
Alias: perl-DBIx-Class

https://bugzilla.redhat.com/show_bug.cgi?id=411551





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 11:47 EST ---
ping?  Is there anything you see needing to be updated to move this review
forward? :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435016] Review Request: mmdb - MMDB coordinate library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mmdb - MMDB coordinate library


https://bugzilla.redhat.com/show_bug.cgi?id=435016


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||182235
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 11:51 EST ---
Blocking FE-Legal until I get a chance to do a proper review of this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 12:01 EST ---
(In reply to comment #3)
 Including ::Cookie as a BR would create a circular buildloop, as ::Cookie has
 ::Session as a mandatory BR.

OK. APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 12:10 EST ---
New Package CVS Request
===
Package Name: perl-Catalyst-Plugin-Session
Short Description: Catalyst generic session plugin
Owners: cweyl
Branches: F-7, F-8, F-9, devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 12:25 EST ---
I did take care/checked everything and, NO I won't change files coming from
upstream unless i have a clear valid and checked with upstream reason for 
doing so.

Daniel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448491] Review Request: cgroup-lib - A collection of tools and libraries to control and monitor control groups the associated controllers

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cgroup-lib -  A collection of tools and libraries to 
control and monitor control groups the associated controllers


https://bugzilla.redhat.com/show_bug.cgi?id=448491





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 12:33 EST ---
Scratch build passed:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=636762

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448491] Review Request: cgroup-lib - A collection of tools and libraries to control and monitor control groups the associated controllers

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cgroup-lib -  A collection of tools and libraries to 
control and monitor control groups the associated controllers


https://bugzilla.redhat.com/show_bug.cgi?id=448491





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 12:45 EST ---
One minor issue:

Please don't use %makeinstall, use make DESTDIR=$RPM_BUILD_ROOT install

See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:01 EST ---
Maybe you want to focus on upstream work, in that case you could consider
having somebody else follow the dogmatic rules. Those dogmatic
rules are not only dogmatic, for instance the NEWS file has strange 
characters when seen in less. 

(I would personally prefer that writer.xml is not changed since it has 
the encoding specified in the file).

Maybe you could search for a co-maintainer, I think that it is better
in most cases to separate upstream from the primary maintainer (though 
upstream as co-maintainer is very nice) such that when there is conflict
between the packaging rules and what upstream want, the maintainer can
decide what is best (which could be what upstream want, but not 
necessarily).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226079] Merge Review: libxml2

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libxml2


https://bugzilla.redhat.com/show_bug.cgi?id=226079





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:08 EST ---
Daniel, all packages in Fedora have to follow the MUSTS of the Fedora Packaging
Rules and Guidelines, libxml2 is there no exception. As you're upstream and also
downstream you can change it where you want; at least it has to be solved in the
end. Why do I have to explain a Red Hat guy how the Fedora Packaging works? ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444574] Review Request: pidgin-lastfm - Display informaiton form Last.fm profile in Pidgin status message

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-lastfm - Display informaiton form Last.fm 
profile in Pidgin status message


https://bugzilla.redhat.com/show_bug.cgi?id=444574





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:06 EST ---
Created an attachment (id=307216)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=307216action=view)
spec patch


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428798] Review Request: OmegaT - Computer Aid Translation tool

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OmegaT - Computer Aid Translation tool


https://bugzilla.redhat.com/show_bug.cgi?id=428798


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED])  |




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:18 EST ---
Not for the next weeks, sorry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442507] Review Request: libspe2 - SPE Runtime Management Library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libspe2 - SPE Runtime Management Library


https://bugzilla.redhat.com/show_bug.cgi?id=442507





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:28 EST ---
/opt/cell/bin/ppu-gcc -O2 -Wall -I. -fPIC -I./include -fexceptions -std=gnu99
-Wformat -Wdisabled-optimization -Wundef -Wshadow -Wcast-align -Wwrite-strings
-Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wredundant-decls
-Wnested-externs -Winline -Wformat -m32  -mabi=altivec   -I./spebase
-I./speevent   -c -o libspe2.o libspe2.c
make: /opt/cell/bin/ppu-gcc: Command not found

Well, /opt/cell/bin/ppu-gcc doesn't seem to be part of Fedora/RHEL at all. Can't
we use the regular gcc delivered with Fedora for that? If we need a special gcc,
we have to get this one into Fedora first. Comments?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 250804] Review Request: perl-Encode-Detect - Detects the encoding of data

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Encode-Detect - Detects the encoding of data
Alias: perl-Encode-Detect

https://bugzilla.redhat.com/show_bug.cgi?id=250804





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:37 EST ---
I tagged and built the devel branch yesterday, but I haven't seen the packages
show up in Rawhide yet.  I know that for I need to submit the FC-? branches via
Bodhi, but is there anything special I need to do to submit to devel?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 250804] Review Request: perl-Encode-Detect - Detects the encoding of data

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Encode-Detect - Detects the encoding of data
Alias: perl-Encode-Detect

https://bugzilla.redhat.com/show_bug.cgi?id=250804





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 13:52 EST ---
All you need to do is build for rawhide and it will show up in the next push,
but it's possible that you just missed the cutoff.  It takes several hours to
compose the rawhide tree.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449135] New: Review Request: gforge - GForge Collaborative Development Environment

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=449135

   Summary: Review Request: gforge - GForge Collaborative
Development Environment
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://www.freewebs.com/javiplx/Fedora/gforge.spec
SRPM URL: http://www.freewebs.com/javiplx/Fedora/gforge-4.5-4.fc9.src.rpm
Description:
GForge is a web-based Collaborative Development Environment offering
easy access to CVS, mailing lists, bug tracking, message
boards/forums, task management, permanent file archival, and total
web-based administration.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449135] Review Request: gforge - GForge Collaborative Development Environment

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gforge - GForge Collaborative Development Environment


https://bugzilla.redhat.com/show_bug.cgi?id=449135


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448491] Review Request: cgroup-lib - A collection of tools and libraries to control and monitor control groups the associated controllers

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cgroup-lib -  A collection of tools and libraries to 
control and monitor control groups the associated controllers


https://bugzilla.redhat.com/show_bug.cgi?id=448491





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 14:51 EST ---
Dan, thanks for the build results

Tom, I've updated the spec file at the same location as mentioned earlier. In
case you see an older version of the spec file (still), sf.net does not update
all its mirrors immediately and hence the older file might still be around as
stale data.

I've replace %makeinstall with make DESTDIR=$RPM_BUILD_ROOT install as 
suggested.

The file sizes are
-rw-r--r-- 1 balbir balbir 1638 2008-05-30 23:29 libcgroup.spec
-rw-r--r-- 1 balbir balbir 64201 2008-05-30 23:30 libcgroup-0.1b-1.fc9.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] New: Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=449149

   Summary: Review Request: Plymouth - Graphical Boot Animation and
Logger
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-
[EMAIL PROTECTED],[EMAIL PROTECTED],[EMAIL PROTECTED],pjon
[EMAIL PROTECTED]


Spec URL: http://rstrode.fedorapeople.org/plymouth/plymouth.spec
SRPM URL: http://rstrode.fedorapeople.org/plymouth/plymouth-0.1.0-1.fc10.src.rpm

Description:
Plymouth provides an attractive graphical boot animation in
place of the text messages that normally get shown.  Text
messages are instead redirected to a log file for viewing
after boot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:14 EST ---
So I'd like to get this in rawhide soon rather than later.  We shouldn't turn it
on by default until it's actually ready though.

Note, these packages won't do anything until we make the necessary mkinitrd 
changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:19 EST ---
Random note: generic-logos doesn't have the logo mentioned here ATM. Any
size/colormap/format considerations?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=435572


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:24 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:22 EST ---
Picking up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 313271] Review Request: perl-Net-IRC - Perl interface to the Internet Relay Chat protocol

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-IRC - Perl interface to the Internet Relay 
Chat protocol
Alias: perl-Net-IRC

https://bugzilla.redhat.com/show_bug.cgi?id=313271


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:22 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] New: Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=449151

   Summary: Review Request: pyodbc - Python DB API 2.0 Module for
ODBC
   Product: Fedora
   Version: 9
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: low
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc.spec
SRPM URL: http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc-2.0.58-1.src.rpm

Description:
A Python DB API 2 module for ODBC. This project provides an up-to-date, 
convenient interface to ODBC using native data types like datetime and 
decimal.

Questions:
- Should I included text of the MIT license even though source package doesn't
include it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:27 EST ---
no, not really.  It should be white or light colored and a png file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:26 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441098] Review Request: python-dictclient - Python client for DICT protocol

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-dictclient - Python client for DICT protocol


https://bugzilla.redhat.com/show_bug.cgi?id=441098


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:28 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443871] Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN
Alias: perl-CPAN-Mini

https://bugzilla.redhat.com/show_bug.cgi?id=443871


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:30 EST ---
cvs done, except for F-7 branch (We are no longer doing F-7 branches) do you
really need one?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444426] Review Request: gabedit - GUI for computational chemistry

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gabedit - GUI for computational chemistry


https://bugzilla.redhat.com/show_bug.cgi?id=26


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:33 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444511] Review Request: emma - Java code coverage tool

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emma - Java code coverage tool


https://bugzilla.redhat.com/show_bug.cgi?id=444511


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:35 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444755] Review Request: perl-Lingua-EN-Numbers-Ordinate - Perl functions for giving the ordinal form of a number given its cardinal value

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Lingua-EN-Numbers-Ordinate - Perl functions for 
giving the ordinal form of a number given its cardinal value


https://bugzilla.redhat.com/show_bug.cgi?id=444755


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:38 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:36 EST ---
MUST items:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - GPLv2+
- License field in spec matches - *** 

Spec says GPLv2. Code says GPLv2+.

- License file included in package  - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum: - ***

Can't find an upstream tarball. Also, URL tag redirects to nowhere.

- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is relocatable and has a reason to be. - N/A
- Package has %defattr and permissions on files is good. - OK
- Package has a correct %clean section. - OK
- Package has correct buildroot - OK
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK

- Spec has needed ldconfig in post and postun - ***

It installs shared libraries but doesn't call ldconfig.

- .so files in -devel subpackage. - ***

Ships %{_libdir}/libply.so - probably should be removed

- .la files are removed. - OK

- Package compiles and builds on at least one arch. - OK (tested x86_64)
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - ***

plymouth-plugin-fade-in.x86_64: W: no-documentation
plymouth-plugin-spinfinity.x86_64: W: no-documentation

Ignorable.

plymouth.x86_64: E: library-without-ldconfig-postin /usr/lib64/libply.so.1.0.0
plymouth.x86_64: E: library-without-ldconfig-postun /usr/lib64/libply.so.1.0.0
plymouth.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libply.so

See above notes.

- final provides and requires are sane: - ***

What's the Requires: on mkinitrd for? (I understand logically that it's for use
in the initrd, but I don't see that it calls anything from it, for example.)

SHOULD Items:

- Should build in mock. - OK (tested x86_64)
- Should build on all supported archs - don't see why it wouldn't
- Should function as described. - Not tested
- Should have sane scriptlets. - ***

See above re: ldconfig

- Should have subpackages require base package with fully versioned depend. - OK
- Should have dist tag - OK

Assorted Other Issues:

- Conflicts: rhgb should possibly also have Obsoletes and Provides associated
with it
- You don't ship a development package. If you expect other packages to build
their own plugins, you may want to
- What happens if you have plymouth but no plugins installed and try to use it?
Should it require a plugin?
- --with-background-color=hex is ugly. Can't that be specified in the plugin
package as part of the theming?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445020] Review Request: python-mako - The Mako template system

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-mako - The Mako template system


https://bugzilla.redhat.com/show_bug.cgi?id=445020


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:41 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445021] Review Request: python-routes - A RoR-like routes library for python

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-routes - A RoR-like routes library for python


https://bugzilla.redhat.com/show_bug.cgi?id=445021


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:42 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445024] Review Request: python-webhelpers - Helper routines for writing web applications

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-webhelpers - Helper routines for writing web 
applications


https://bugzilla.redhat.com/show_bug.cgi?id=445024


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:45 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445347] Review Request: python-shout - python binding for libshout

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-shout - python binding for libshout


https://bugzilla.redhat.com/show_bug.cgi?id=445347


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:49 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445142] Review Request: libcapseo - Realtime encoding/decoding library

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcapseo - Realtime encoding/decoding library


https://bugzilla.redhat.com/show_bug.cgi?id=445142


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:47 EST ---
Ideally, we will get pkgdb to just have a form/web ui for requesting things... 

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448901] Review Request: nled - Simple curses-based text editor

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nled - Simple curses-based text editor


https://bugzilla.redhat.com/show_bug.cgi?id=448901


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:49 EST ---
Hi Chris,

Just a few items to clean up:

- md5sums don't match:
  b3257a99cb113d57eb621a3144d9dfe9
http://cdot.senecac.on.ca/software/nled/nled_2_52_src.tgz
  8862849778bc3fd8c71bbf550e9f9aaf rpmbuild/SOURCES/nled_2_52_src.tgz
- consider using install -p to preserve timestamps
- should we add %{?_smp_mflags} to the make line to do parallel builds?  it
worked for me

Thanks to Deepak Bhole for helping me review this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445454] Review Request: python-virtkey - Python extension for emulating keypresses and getting current keyboard layout

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-virtkey - Python extension for emulating 
keypresses and getting current keyboard layout


https://bugzilla.redhat.com/show_bug.cgi?id=445454


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:50 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445455] Review Request: xdotool - Fake keyboard/mouse input

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdotool - Fake keyboard/mouse input


https://bugzilla.redhat.com/show_bug.cgi?id=445455


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:53 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 446410] Review Request: perl-BDB - Asynchronous Berkeley DB access

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-BDB - Asynchronous Berkeley DB access


https://bugzilla.redhat.com/show_bug.cgi?id=446410


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 15:58 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 446412] Review Request: perl-Event-RPC - Event based transparent Client/Server RPC framework

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Event-RPC - Event based transparent Client/Server 
RPC framework


https://bugzilla.redhat.com/show_bug.cgi?id=446412


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:00 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl 
applications


https://bugzilla.redhat.com/show_bug.cgi?id=446414


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:04 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448497] Review Request: ca-certificates - Mozilla CA root bundle package

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ca-certificates - Mozilla CA root bundle package


https://bugzilla.redhat.com/show_bug.cgi?id=448497


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:08 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448531] Review Request: pyrenamer - A mass file renamer written in PyGTK

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyrenamer - A mass file renamer written in PyGTK


https://bugzilla.redhat.com/show_bug.cgi?id=448531


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:13 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:13 EST ---
Fixed license.

added upstream url.

remove libply.so

add ldconfig

mkinitrd was for grubby used by the sample script. the script really shouldn't
be used though, so i dropped the requires.

add obsoletes and provides

i haven't sorted out the plugin situation yet.  right now the plugins require
intree files to build, and there's no way to switch which one gets used by the
daemon. it's something i'm going to fix soon.

the base package ships two plugins.  One of them, text will run if there
aren't any other plugins installed (or if they fail to work).

--with-background-color is a hint to the plugins which color to use to fit in
with the configured logo.  plugins are free to ignore it and do their own thing
just like they're free to ignore the configured logo.

 





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448582] Review Request: automoc - KDE4 Automoc

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: automoc - KDE4 Automoc


https://bugzilla.redhat.com/show_bug.cgi?id=448582


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:16 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448606] Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: subtitleeditor - GTK+2 tool to edit subtitles for 
GNU/Linux/*BSD


https://bugzilla.redhat.com/show_bug.cgi?id=448606


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:21 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448901] Review Request: nled - Simple curses-based text editor

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nled - Simple curses-based text editor


https://bugzilla.redhat.com/show_bug.cgi?id=448901





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:21 EST ---
Thanks Andrew, fixed all (not sure what happened with the md5sums!)--

Spec URL: http://chris.tylers.info/rpm/nled.spec
SRPM URL: http://chris.tylers.info/rpm/nled-2.52-3.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448650] Review Request: gmm - C++ library for sparse, dense and skyline matrices

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gmm - C++ library for sparse, dense and skyline 
matrices


https://bugzilla.redhat.com/show_bug.cgi?id=448650


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:23 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems


https://bugzilla.redhat.com/show_bug.cgi?id=448745


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:24 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448901] Review Request: nled - Simple curses-based text editor

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nled - Simple curses-based text editor


https://bugzilla.redhat.com/show_bug.cgi?id=448901


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:27 EST ---
Awesome, thanks, Chris.  APPROVED.  Don't forget to do the CVS Admin procedure 
now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448871] Review Request: perl-Template-Provider-Encoding - Explicitly declare encodings of your templates

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Template-Provider-Encoding - Explicitly declare 
encodings of your templates


https://bugzilla.redhat.com/show_bug.cgi?id=448871


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:27 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448491] Review Request: cgroup-lib - A collection of tools and libraries to control and monitor control groups the associated controllers

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cgroup-lib -  A collection of tools and libraries to 
control and monitor control groups the associated controllers


https://bugzilla.redhat.com/show_bug.cgi?id=448491





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:28 EST ---
In general, any time you make a change to the spec file, you need to increment
the release, and add a new entry to the %changelog section. I'll ignore that for
now, but please be sure to do it in the future.

In the spec, you've got:

URL: http://downloads.sourceforge.net/libcg/%{name}-%{version}.tar.bz2
Source0: libcgroup-0.1b.tar.bz2

URL is intended to point to the libcgroup website.
Source0 should be the URL path to download the tarball.

So, you need to change it to:

URL: http://libcg.sourceforge.net/
Source0: http://downloads.sourceforge.net/libcg/%{name}-%{version}.tar.bz2

Please make a new SRPM, and I'll finish this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449067] Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic 
session plugin


https://bugzilla.redhat.com/show_bug.cgi?id=449067


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:29 EST ---
cvs done (except for F-7, as we are no longer doing F-7 branches). 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:41 EST ---
If you're both obsoleting and providing rhgb, you need to version the obsoletes
so it doesn't obsolete itself.

New URL still gets a 404. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149





--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:54 EST ---
okay should be good to go now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:54 EST ---
Looks good. Might want to add the url to the source download, but that's just a
style thing.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443871] Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN
Alias: perl-CPAN-Mini

https://bugzilla.redhat.com/show_bug.cgi?id=443871


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 16:56 EST ---
(In reply to comment #8)
 cvs done, except for F-7 branch (We are no longer doing F-7 branches) do you
 really need one?

Not really -- just part of my request branch script.  I wasn't aware we'd
stopped doing F-7 branches; I'll drop that from the script...


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444426] Review Request: gabedit - GUI for computational chemistry

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gabedit - GUI for computational chemistry


https://bugzilla.redhat.com/show_bug.cgi?id=26


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 17:09 EST ---
Imported and built for devel and F-9, others will follow. Thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449149] Review Request: Plymouth - Graphical Boot Animation and Logger

2008-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Plymouth - Graphical Boot Animation and Logger


https://bugzilla.redhat.com/show_bug.cgi?id=449149


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-05-30 17:09 EST ---
New Package CVS Request
===
Package Name: plymouth
Short Description: Plymouth Graphical Boot Animation and Logger
Owners: rstrode,krh 
InitialCC:
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >