[Bug 447599] Review Request: immix - image mixer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 02:44 EST ---
typo : license field is correct -- OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 447599] Review Request: immix - image mixer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|fedora-review?, |fedora-review+
   |needinfo?([EMAIL PROTECTED]) |




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 02:44 EST ---

OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
BAD license field matches the actual license.
OK  license is open source-compatible (LGPLv3+). License text included in 
package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
N/A compiler flags are appropriate.
OK  %clean is present.
OK  package builds in koji (Rawhide/x86_64).
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires look sane.
OK   Binaries are proper
N/A %check is present and all tests pass.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  correct scriptlets present.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no libtool archives droppings.
OK  GUI app == Desktop file is present and correct.


This package is APPROVED



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 421241] Review Request: php-ZendFramework - Leading open-source PHP framework

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-ZendFramework - Leading open-source PHP framework


https://bugzilla.redhat.com/show_bug.cgi?id=421241





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 02:53 EST ---
OT: too bad http://www.zendframework.com/issues/browse/ZF-2624 is still open ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454921] Review Request: python-dotconf - Parser for dot.conf file

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-dotconf - Parser for dot.conf file


https://bugzilla.redhat.com/show_bug.cgi?id=454921


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 03:04 EST ---
Thanks Mamoru :)

New Package CVS Request
===
Package Name: python-dotconf
Short Description: python parser for dot.conf file
Owners: hemantg
Branches: OLPC-2 OLPC-3 F-8 F-9
InitialCC:
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452523] Review Request: perl-Event-ExecFlow - High level API for event-based execution flow control

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Event-ExecFlow - High level API for event-based 
execution flow control


https://bugzilla.redhat.com/show_bug.cgi?id=452523


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452523] Review Request: perl-Event-ExecFlow - High level API for event-based execution flow control

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Event-ExecFlow - High level API for event-based 
execution flow control


https://bugzilla.redhat.com/show_bug.cgi?id=452523





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 03:09 EST ---
New Package CVS Request
===
Package Name: perl-Event-ExecFlow
Short Description: High level API for event-based execution flow control
Owners: kwizart
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksplice - Patching a Linux kernel without reboot


https://bugzilla.redhat.com/show_bug.cgi?id=454462





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 03:16 EST ---
(In reply to comment #4)
 For Topic #3 of comment #2 I want to aks, how I can do it?

See http://fedoraproject.org/wiki/Packaging/Perl#In_.25prep_.28preferred.29 :

cat  \EOF  %{name}-prov
#!/bin/sh
%{__perl_provides} $* |\
sed -e '/perl(ksplice)/d'
EOF

%define __perl_provides %{_builddir}/%{name}-%{version}/%{name}-prov
chmod +x %{__perl_provides}

cat  \EOF  %{name}-req
#!/bin/sh
%{__perl_requires} $* |\
sed -e '/perl(ksplice)/d'
EOF

%define __perl_requires %{_builddir}/%{name}-%{version}/%{name}-req
chmod +x %{__perl_requires}

 For the last point of comment #2 if have decided to make no changes.

Ok. Other packages seem to have sourcefiles in %_datadir as well.

 ExclusiveArch:%{x86} x86_64

Typo: should be %{ix86}. However, I was told on #fedora-devel that in such
cases, when it isn't unlikely at all that the package will be ported to other
architectures, we should use excludearch instead. Only packages that will
*never* be built on anything else should use exclusivearch. So, please use
ExcludeArch: ppc ppc64.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456009] Review Request: python-jinja2 - General purpose template engine

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-jinja2 - General purpose template engine


https://bugzilla.redhat.com/show_bug.cgi?id=456009





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 04:24 EST ---
python-jinja2-2.0-2.fc9 has been submitted as an update for Fedora 9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456009] Review Request: python-jinja2 - General purpose template engine

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-jinja2 - General purpose template engine


https://bugzilla.redhat.com/show_bug.cgi?id=456009





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 04:26 EST ---
python-jinja2-2.0-2.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 447599] Review Request: immix - image mixer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 04:27 EST ---
New Package CVS Request
===
Package Name: immix
Short Description: An image mixer
Owners: eponyme
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456042] Review Request: python-mwlib - MediaWiki conversion library for Python

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-mwlib - MediaWiki conversion library for Python


https://bugzilla.redhat.com/show_bug.cgi?id=456042


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 04:28 EST ---
Build cleanly in mock.

* rpmlint clean
* package meets naming guidelines
* uses macros consistently
* build root is ok
X license isn't completely correct, mwlib/cdb.py was taken from the spambayes
project, and should be under the Python license (include both in the license tag
and add a comment explaining it)
* Requires/BuildRequires are OK
X The %check section currently doesn't run the tests.  I don't see any docs on
how to run them (and there's a chance that it might require py.test, which isn't
in Fedora), so it might be best to kill the section entirely.
* Installs/uninstalls fine
* Permissions are fine

APPROVED (just fix the above issues)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456331] Review Request: pdfmerge - Command line utility program for merging PDF files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfmerge - Command line utility program for merging 
PDF files


https://bugzilla.redhat.com/show_bug.cgi?id=456331





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 06:03 EST ---
That internally converts from PDF to PS and back and loses quality. A real PDF 
merging tool can do it without quality loss.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456514] New: Package review: geeqie

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456514

   Summary: Package review: geeqie
   Product: Fedora
   Version: rawhide
  Platform: All
   URL: http://http://mmaslano.fedorapeople.org/geeqie/geeqie-
1.0-0.1.a.fc9.src.rpm
OS/Version: Linux
Status: NEW
  Severity: low
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


http://mmaslano.fedorapeople.org/geeqie/geeqie-1.0-0.1.a.fc9.src.rpm
http://mmaslano.fedorapeople.org/geeqie/geeqie.spec

Geeqie is a lightweight image viewer. It was forked from GQview.
The development is focused on features for photo collection
maintenance: raw format, Exif/IPTC/XMP metadata and integration
with programs like UFraw, ImageMagick, Gimp, gPhoto or ExifTool.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456514] Package review: geeqie

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: geeqie


https://bugzilla.redhat.com/show_bug.cgi?id=456514


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 06:37 EST ---


*** This bug has been marked as a duplicate of 445594 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445594] Review Request: geeqie - Image browser and viewer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geeqie - Image browser and viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445594


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 06:37 EST ---
*** Bug 456514 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454125] Review Request: gtest - Google C++ testing framework

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtest - Google C++ testing framework


https://bugzilla.redhat.com/show_bug.cgi?id=454125


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 06:44 EST ---
New Package CVS Request
===
Package Name: gtest
Short Description: Google C++ testing framework
Owners: rishi
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] New: Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456517

   Summary: Review Request: fotoxx - Photo editor
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://nicoleau.fabien.free.fr/rpms/SPECS/fotoxx.spec
SRPM URL: http://nicoleau.fabien.free.fr/rpms/srpms.fc9/fotoxx-4.9-1.fc9.src.rpm
Description:
Fotoxx is a free open source Linux program for editing image files
from a digital camera. The goal of fotoxx is to meet most image editing
needs while remaining easy to use.

rpmlint output : 
[EMAIL PROTECTED] tmp]$ rpmlint fotoxx-4.9-1.fc9.i386.rpm 
fotoxx-debuginfo-4.9-1.fc9.i386.rpm fotoxx-4.9-1.fc9.src.rpm 
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
[EMAIL PROTECTED] tmp]$ 

package builds on koji :
http://koji.fedoraproject.org/koji/taskinfo?taskID=735847

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk 
space information


https://bugzilla.redhat.com/show_bug.cgi?id=455443





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 07:49 EST ---
 I really like to see people commenting updated (SPEC and SRPM)path by
increasing release tag and adding changelog in SPEC each time they rebuild SRPM.

I assume that updated SRPM is 
http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df-0.92-1.fc9.src.rpm

Your package is not building still and failed with build.log
http://koji.fedoraproject.org/koji/getfile?taskID=735939name=build.log

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455788] Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-DBI - Find a parser class for a 
database connection


https://bugzilla.redhat.com/show_bug.cgi?id=455788


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 07:46 EST ---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=735907
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
97efe8dfe3a6e68cfb9489c451cd16dd  DateTime-Format-DBI-0.031.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.00 usr  0.00 sys +  0.04 cusr  0.00 csys
=  0.04 CPU)
+ Package perl-DateTime-Format-DBI-0.031-2.fc10 =
 Provides: perl(DateTime::Format::DBI) = 0.031
  Requires: perl(Carp) perl(DBI) = 1.21  perl(strict) perl(vars)

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotoxx - Photo editor


https://bugzilla.redhat.com/show_bug.cgi?id=456517


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 07:49 EST ---
*** Bug 442244 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442244] Review Request: fotox - Program for improving image files made with a digital camera

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotox -  Program for improving image files made with a 
digital camera


https://bugzilla.redhat.com/show_bug.cgi?id=442244


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 07:49 EST ---
fotoxx the successor of fotox is under review now, so I will close this one..

*** This bug has been marked as a duplicate of 456517 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotoxx - Photo editor


https://bugzilla.redhat.com/show_bug.cgi?id=456517


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 07:58 EST ---
Review:
+ package builds in mock (rawhide i386).
koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=735923
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bbc9b2522331960f1bf5cab9b7b09ca0  fotoxx-4.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed correctly.

* Remove unnecessary BR:pkgconfig

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455700] Review Request: kpackagekit - KDE packagekit interface

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpackagekit - KDE packagekit interface


https://bugzilla.redhat.com/show_bug.cgi?id=455700





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 08:06 EST ---
New SPEC and SRPM uploaded to http://tuxbrewr.fedorapeople.org/kpackagekit/

Build logs here: http://koji.fedoraproject.org/koji/taskinfo?taskID=735971

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455700] Review Request: kpackagekit - KDE packagekit interface

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpackagekit - KDE packagekit interface


https://bugzilla.redhat.com/show_bug.cgi?id=455700


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455700] Review Request: kpackagekit - KDE packagekit interface

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpackagekit - KDE packagekit interface


https://bugzilla.redhat.com/show_bug.cgi?id=455700


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 08:16 EST ---
close enough.  the remaining items are cosmetic and can be dealt with post
review.  :)  (don't build anything until we have a chance to go over that 
together)

upstream sources verified:
5dd2cffe88091c495f93ffd256faa68e  84745-kpackagekit-0.1-b3.tar.bz2

license: ok

APPROVED.





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455700] Review Request: kpackagekit - KDE packagekit interface

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpackagekit - KDE packagekit interface


https://bugzilla.redhat.com/show_bug.cgi?id=455700


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 08:21 EST ---
New Package CVS Request
===
Package Name: kpackagekit
Short Description: KDE packagekit interface
Owners: tuxbrewr
Branches: F9
InitialCC: rdieter, kkofler
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotoxx - Photo editor


https://bugzilla.redhat.com/show_bug.cgi?id=456517


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 08:45 EST ---
New Package CVS Request
===
Package Name: fotoxx
Short Description: Photo editor
Owners: eponyme
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 447104] Review Request: qdevelop - development environment for QT4

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qdevelop - development environment for QT4


https://bugzilla.redhat.com/show_bug.cgi?id=447104


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|9   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456150] Review Request: slapi-nis - NIS Server and Schema Compatibility plugins for Fedora DS

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: slapi-nis - NIS Server and Schema Compatibility 
plugins for Fedora DS


https://bugzilla.redhat.com/show_bug.cgi?id=456150


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 09:57 EST ---
+ rpmlint is silent

I also setup a FDS instance, configured and loaded the plugin, added a user in
the right mapping and NIS:

# ypcat -k -d example.com -h localhost passwd
tuser tuser:*:1160:500:Test User:/home/tuser:/bin/sh

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456331] Review Request: pdfmerge - Command line utility program for merging PDF files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfmerge - Command line utility program for merging 
PDF files


https://bugzilla.redhat.com/show_bug.cgi?id=456331





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 09:15 EST ---
This package also uses ps2pdfwr, that invokes gs with the following parameters:

exec $GS_EXECUTABLE $OPTIONS -q -dNOPAUSE -dBATCH -sDEVICE=pdfwrite
-sOutputFile=$outfile $OPTIONS -c .setpdfwrite -f $infile



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456542] New: Review Request: hotssh - An interface to Secure Shell, for GNOME and OpenSSH

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456542

   Summary: Review Request: hotssh - An interface to Secure Shell,
for GNOME and OpenSSH
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://cdn.verbum.org/hotssh.spec
SRPM URL: http://cdn.verbum.org/hotssh-0.2-1.fc9.src.rpm
Description: HotSSH is an interface to Secure Shell, for GNOME and OpenSSH. It 
intends to be a better experience than simply invoking ssh from an existing 
terminal window.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455788] Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-DBI - Find a parser class for a 
database connection


https://bugzilla.redhat.com/show_bug.cgi?id=455788





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 10:39 EST ---
New Package CVS Request
===
Package Name: perl-DateTime-Format-DBI
Short Description: Find a parser class for a database connection
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455788] Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-DBI - Find a parser class for a 
database connection


https://bugzilla.redhat.com/show_bug.cgi?id=455788


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456527] New: Review Request: gentium-basic-fonts - Gentium Basic Font Family

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456527

   Summary: Review Request: gentium-basic-fonts -  Gentium Basic
Font Family
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: 
http://rbhalera.fedorapeople.org/gentium-basic-fonts/gentium-basic-fonts.spec
SRPM URL: 
http://rbhalera.fedorapeople.org/gentium-basic-fonts/gentium-basic-fonts-1.1-1.fc10.src.rpm
Description:  Gentium Basic is a font family based on the original Gentium 
design.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iw - A nl80211 based wireless configuration tool


https://bugzilla.redhat.com/show_bug.cgi?id=453870


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456331] Review Request: pdfmerge - Command line utility program for merging PDF files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfmerge - Command line utility program for merging 
PDF files


https://bugzilla.redhat.com/show_bug.cgi?id=456331





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 09:54 EST ---
Peter,
I really don't know how to react such problems. you are not the first asking why
alternative package when simple thing or some other package already exists in
Fedora repository.
I have seen already similar cases by peoples asking such questions why this
package when other alternative is available?

I will leave decision to Rahul whether to continue adding this package in Fedora
or not?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456331] Review Request: pdfmerge - Command line utility program for merging PDF files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfmerge - Command line utility program for merging 
PDF files


https://bugzilla.redhat.com/show_bug.cgi?id=456331





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 11:31 EST ---
Actually, I looked at it and it's just a simple Perl script which invokes 
GhostScript. Which means that 1. the package is missing dependencies (you need 
Requires tags for the tools invoked - Rahul, please fix the specfile before 
building!) and 2. it is a bad PDF merge tool, because PDF merging can and 
should be done directly on the PDF, not on PostScript files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk 
space information


https://bugzilla.redhat.com/show_bug.cgi?id=455443





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 11:32 EST ---
SRCRPM:
http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df-0.92-2.fc9.src.rpm
SPEC: http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df.spec
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=736579
$ rpmlint /home/msuchy/rpmbuild/SRPMS/perl-Filesys-Df-0.92-2.fc9.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452395] Review Request: lxlauncher - Open source replacement for Asus Launcher of the EeePC

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lxlauncher - Open source replacement for Asus Launcher 
of the EeePC


https://bugzilla.redhat.com/show_bug.cgi?id=452395





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 11:34 EST ---
So do you still think it needs a launcher? IMO a launcher in the menu is
nonsens, nobody will launch a lauchner from the menu just to launch another app.

The only thing that makes sense to me is /etc/xdg/autostart, but I'm not sure
how to handle that for all desktops/window managers, because some do support
/etc/xdg/autostart but do not implement Hidden=true.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436704] Review Request: mapnik - a Free toolkit for developing mapping applications

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mapnik - a Free toolkit for developing mapping 
applications


https://bugzilla.redhat.com/show_bug.cgi?id=436704


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||182235
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 11:36 EST ---
Once sendint to spot.
Spot, would you verify the following?

http://geogratis.cgdi.gc.ca/geogratis/en/licence.jsp

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188542] Review Request: hylafax

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 11:39 EST ---
On the FHS matter...

It would be infinitely easier to move all of /var/spool/hylafax into
/var/hylafax instead of trying to move subdirectories bin, etc, config
into other places.

Does this make a resolution any easier?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456549] New: Review Request: pmpu - GUI for distributed VCS's

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456549

   Summary: Review Request: pmpu - GUI for distributed VCS's
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://rezza.hofyland.cz/fedora/packages/pmpu/pmpu.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/pmpu/pmpu-0.2-1.fc9.src.rpm
Description: Push Me Pull You is a graphical interface for a distributed 
version control system. Currently it contains proof-of-concept support the hg 
(including basic support for the forest and Mq extensions), git (including 
basic support for submodules / superprojects), bzr and darcs systems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksplice - Patching a Linux kernel without reboot


https://bugzilla.redhat.com/show_bug.cgi?id=454462





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 11:58 EST ---
Thank you for your hints. I have modified the package as suggested.

The uploaded stuff may be find at:

Spec URL: http://www.herr-schmitt.de/pub/ksplice/ksplice.spec
SRPM URL: http://www.herr-schmitt.de/pub/ksplice/ksplice-0.8.7-5.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436704] Review Request: mapnik - a Free toolkit for developing mapping applications

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mapnik - a Free toolkit for developing mapping 
applications


https://bugzilla.redhat.com/show_bug.cgi?id=436704





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 12:52 EST ---
For 0.5.1-2:

* General rpmlint check
-
mapnik.src:217: E: files-attr-not-set
mapnik.src:218: E: files-attr-not-set
mapnik.src:219: E: files-attr-not-set
mapnik.src:220: E: files-attr-not-set
mapnik-demo.i386: E: devel-dependency mapnik-devel
-
  + I guess the last one (i.e. mapnik-demo depends on mapnik-devel)
is intentional

  - On the other hand, the first rpmlint (i.e. %files demo entry
does not have %defattr(-,root,root,-) ) must be fixed.

* Directory ownership issue
  - %{_libdir}/mapnik is not owned by any packages.

Please fix above. Once spot approves data license, I can say go for
this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on 
OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:02 EST ---
Please retry. Perhaps it is okay now. Again closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438750] Review Request: qtoctave - fronted for octave written using qt4 widgets

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qtoctave - fronted for octave written using qt4 widgets


https://bugzilla.redhat.com/show_bug.cgi?id=438750





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:06 EST ---
ping again?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:06 EST ---
Again ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 450243] Review Request: google-gadgets - Google Gadgets for Linux

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: google-gadgets - Google Gadgets for Linux


https://bugzilla.redhat.com/show_bug.cgi?id=450243


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||l.com)




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:10 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443238] Review Request: cave9 - 3d clone of SFCave.

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cave9 - 3d clone of SFCave.


https://bugzilla.redhat.com/show_bug.cgi?id=443238


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:16 EST ---
Victor, are you still interested in this package? If so I will try
to review this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445604] Review Request: Tennix! - A funny 2D tennis game

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Tennix! - A funny 2D tennis game


https://bugzilla.redhat.com/show_bug.cgi?id=445604


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Status|NEW |NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||asoni.it)




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:17 EST ---
What is the status of this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448702] Review Request: SndObj - The Sound Object Library

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SndObj - The Sound Object Library


https://bugzilla.redhat.com/show_bug.cgi?id=448702


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||uim.ie)




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:18 EST ---
What is the status of this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443238] Review Request: cave9 - 3d clone of SFCave.

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cave9 - 3d clone of SFCave.


https://bugzilla.redhat.com/show_bug.cgi?id=443238





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:31 EST ---
Yes! :-) 

But let me do a clean-up first, I think the upstream have a data package that
fits better on free distribution. The font on this package is not free, and even
though I have removed it from the rpm file, the source package still has it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451189] Review Request: rancid - Really Awesome New Cisco confIg Differ

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rancid - Really Awesome New Cisco confIg Differ


https://bugzilla.redhat.com/show_bug.cgi?id=451189


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||rg)




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:38 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448874] Review Request: pyroom - PyRoom is a full screen text editor and a clone of Writeroom

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyroom - PyRoom is a full screen text editor and a 
clone of Writeroom


https://bugzilla.redhat.com/show_bug.cgi?id=448874


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:49 EST ---

Package is APPROVED

Required:
[x] rpmlint output - clean
[x] package name  spec name -- correct. pyroom is acceptable as upstream py
[x] packaging guideline
[x] fedora approved license
[x] license field in spec - correct
[x] LICENSE included in %{doc}
[x] spec file -- AMERICAN english
[x] spec file - legible
[x] md5sum
  Upstream: c8d9ff35153554f5388a4f24a0ed0dad
  Source: c8d9ff35153554f5388a4f24a0ed0dad
[x] package successfully compiles and builds (build on koji)
[x] BuildRequires -- correct
[x] Requires -- correct
[x] locales -- handled
[NA] shared libraries, header files and static libraries
[x] owns all directories it creates
[x] file permissions correct
[x] no duplicates in %files section
[x] %install and %clean section have rm -rf $RPM_BUILD
[x] nothing in %doc effects application
[x] GUI -- %{name}.desktop included
[x] all files have valid encoding -- utf8
[x] py files are byte compiled. Included in %files -- so package removal does 
not left behind files
[NA] unnecessary byte compilation -- no py files in bin instead a script used. 

Optional:
[NA] No need to upstream for LICENSE
[?] you may like to check whether description and summary sections are 
available in other
 languages. -- (very much optional)
[x]  builds on koji
[x] script add is sane
[x] no dependencies paths outside FHS guidelines 

Optional Suggestions(you may not consider using them):
1. Use either $RPM_BUILD_ROOT or %{buildroot} consistently
2. you can use '--vendor fedora'
3. There are some extra lines in spec -- you may consider using
 uniform layout
4. %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX) is preferred 
BuildRoot tag

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453395] Review Request: libmapi - OpenChange: Microsoft Exchange access with native protocols

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmapi - OpenChange: Microsoft Exchange access with 
native protocols


https://bugzilla.redhat.com/show_bug.cgi?id=453395


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:51 EST ---
I can review this (and help with samba4 more later, that one's going to take
more time).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448702] Review Request: SndObj - The Sound Object Library

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SndObj - The Sound Object Library


https://bugzilla.redhat.com/show_bug.cgi?id=448702


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
   Flag|needinfo?([EMAIL PROTECTED]|
   |uim.ie) |




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:50 EST ---
Not ready for re-review yet. I have to fix some of the scons build issues
before I set it for approval. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for 
Mozilla programs


https://bugzilla.redhat.com/show_bug.cgi?id=448215


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:52 EST ---
I suppose not, just would be good to do moving forward... 

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453395] Review Request: libmapi - OpenChange: Microsoft Exchange access with native protocols

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmapi - OpenChange: Microsoft Exchange access with 
native protocols


https://bugzilla.redhat.com/show_bug.cgi?id=453395


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 13:58 EST ---
1.  SHOULD drop Epoch

2.  drop extraneous:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

3.  SHOULD drop extraneous
Requires: libtalloc = 0:%{talloc_version}
which is already satisfied by fedora's default repos (F9+ anyway)

Can't confirm buildability atm, lacking samba4 builds here.  I think we can
trust you an that. :)

This one is pretty small/simple and the only items I found were mostly cosmetic,
so I'll also trust you to address them before performing any builds.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Samba4 - Samba4 CIFS and AD server and client


https://bugzilla.redhat.com/show_bug.cgi?id=453083


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:00 EST ---
Well, I'll chip away at this (any external review help welcome).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455174] Review Request: perl-Mon - Mon Perl module

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Mon - Mon Perl module
Alias: perl-Mon-review

https://bugzilla.redhat.com/show_bug.cgi?id=455174


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:08 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452523] Review Request: perl-Event-ExecFlow - High level API for event-based execution flow control

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Event-ExecFlow - High level API for event-based 
execution flow control


https://bugzilla.redhat.com/show_bug.cgi?id=452523


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:14 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454921] Review Request: python-dotconf - Parser for dot.conf file

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-dotconf - Parser for dot.conf file


https://bugzilla.redhat.com/show_bug.cgi?id=454921


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:12 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Samba4 - Samba4 CIFS and AD server and client


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:17 EST ---
1.  Should drop Epoch: 0

2.  drop
BR: ldconfig

3.  drop extraneous, hard-coded library deps
Requires: libtdb = 0:%{tdb_version}
Requires: libtalloc = 0:%{talloc_version}
should already be satisified by fedora's default versions (verified F9+)

4.  the -common deps
Requires(post): /sbin/chkconfig, /sbin/service, coreutils
Requires(preun): /sbin/chkconfig, /sbin/service
are misplaced.  these need to be in main pkg.  (and what's coreutils used for?)

5.  SHOULD use a recommended buildroot (cosmetic only).

Going to try some builds...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 447599] Review Request: immix - image mixer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:23 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454125] Review Request: gtest - Google C++ testing framework

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtest - Google C++ testing framework


https://bugzilla.redhat.com/show_bug.cgi?id=454125


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:25 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotoxx - Photo editor


https://bugzilla.redhat.com/show_bug.cgi?id=456517


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:28 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455700] Review Request: kpackagekit - KDE packagekit interface

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpackagekit - KDE packagekit interface


https://bugzilla.redhat.com/show_bug.cgi?id=455700


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:26 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455788] Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-DBI - Find a parser class for a 
database connection


https://bugzilla.redhat.com/show_bug.cgi?id=455788


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 14:30 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456581] New: Review Request: main package name here - short summary here

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456581

   Summary: Review Request: main package name here - short
summary here
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://www.cs.umd.edu/~gaburici/tex-fontools.spec
SRPM URL: http://www.cs.umd.edu/~gaburici/tex-fontools-20070807-1.fc9.src.rpm
Description: Tools for handling fonts with LaTeX and fontinst

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotoxx - Photo editor


https://bugzilla.redhat.com/show_bug.cgi?id=456517





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:36 EST ---
fotoxx-4.9-1.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456517] Review Request: fotoxx - Photo editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotoxx - Photo editor


https://bugzilla.redhat.com/show_bug.cgi?id=456517





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:38 EST ---
fotoxx-4.9-1.fc9 has been submitted as an update for Fedora 9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456582] New: Review Request: tex-fontools - Tools for handling fonts with LaTeX and fontinst

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456582

   Summary: Review Request: tex-fontools - Tools for handling fonts
with LaTeX and fontinst
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://www.cs.umd.edu/~gaburici/tex-fontools.spec
SRPM URL: http://www.cs.umd.edu/~gaburici/tex-fontools-20070807-1.fc9.src.rpm
Description:
This package provides a few tools to ease using fonts (especially
TrueType/OpenType ones) with LaTeX and fontinst. The main tool is
autoinst. It simplifies the use of the LCDF TypeTools by creating
a command file for otftotfm, plus it generates .fd and .sty files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456582] Review Request: tex-fontools - Tools for handling fonts with LaTeX and fontinst

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tex-fontools - Tools for handling fonts with LaTeX and 
fontinst


https://bugzilla.redhat.com/show_bug.cgi?id=456582


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:43 EST ---
Btw, this is my first package and I'm seeking a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456583] New: Review Request: calamaris - Squid native log format (NLF) analyzer and report generator

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456583

   Summary: Review Request: calamaris - Squid native log format
(NLF) analyzer and report generator
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://labs.linuxnetz.de/bugzilla/calamaris.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/calamaris-2.59-1.src.rpm
Calamaris parses the Squid Native Log and genereates reports about Peak-usage, 
Request-Methods, Status-reports of incoming and outgoing requests, second and 
Top-level destinations, content-types and performance.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455111] Review Request: python-webob - WSGI request and response object

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-webob - WSGI request and response object


https://bugzilla.redhat.com/show_bug.cgi?id=455111


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:42 EST ---
* rpmlint: No output, great
* Follows naming guidelines
* MIT license is OSS
* License is included in docs
* spec file is clearly readable
* Tarball matches upstream
* Builds on i386
* No translations at the moment
* Not a C library
* Not relocatable
* Package owns all directories it creates
* No duplicate files
* Does not own files owned by another package
* Permissions set properly
* Proper %clean section
* Macros used consistently
* Code, not content
* %doc does not affect the Provides or Requires
* Not a GUI
* Buildroot cleaned at beginning of %install
* All filenames are valid UTF-8
* No file dependencies
* No scriptlets
* Builds in mock

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 447599] Review Request: immix - image mixer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:46 EST ---
immix-1.3.2-3.fc9 has been submitted as an update for Fedora 9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 447599] Review Request: immix - image mixer

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:45 EST ---
immix-1.3.2-3.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456582] Review Request: tex-fontools - Tools for handling fonts with LaTeX and fontinst

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tex-fontools - Tools for handling fonts with LaTeX and 
fontinst


https://bugzilla.redhat.com/show_bug.cgi?id=456582





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:54 EST ---
*** Bug 456581 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456581] Review Request: main package name here - short summary here

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: main package name here - short summary here


https://bugzilla.redhat.com/show_bug.cgi?id=456581


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE
Summary|Review Request: main   |Review Request: main
   |package name here - short |package name here - short
   |summary here   |summary here




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:54 EST ---


*** This bug has been marked as a duplicate of 456582 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445010] Review Request: xvarstar - an astronomical program used for searching GCVS

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xvarstar - an astronomical program used for searching 
GCVS


https://bugzilla.redhat.com/show_bug.cgi?id=445010





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 15:59 EST ---
Michael: ok, sounds fine to me... please when you have some more packages ready
feel free to email me or add my name to CC on the review bug(s). 

Marek: Do you want to look at spinning up a new package with the new license, or
see why it's not the case? 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 16:09 EST ---
I'll do a formal review and I can sponsor you.  You'll need to create an account
in the Fedora Account System, sign the CLA, etc, and then request membership in
the cvsextras group.  I'll send you invites for these.  Review to follow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456398] Review Request: why - Why software verification platform

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: why - Why software verification platform


https://bugzilla.redhat.com/show_bug.cgi?id=456398





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 16:11 EST ---
(In reply to comment #2)

I'm addressing these as I write, but I thought it'd be good to comment on how 
they're going/what I think about them.

 Must-do's:
 * You renamed cpulimit to why-cpulimit, which is sensible enough, but at
 least gwhy (and maybe others) still call cpulimit, so the whole thing 
fails. 
 Quick test:
  sudo yum install -y zenon
  rpmbuild -ba ~/rpmbuild/SPECS/why.spec
  sudo rpm -ivh ~/rpmbuild/RPMS/*/why*.rpm
  cd ~/rpmbuild/BUILD/why-2.13/examples-c/tutorial
  gwhy binary_search.c
  # then click on the Zenon column.  Nothing works. Doing:
  strace -f -e trace=process gwhy binary_search.c
  # Note that that it's trying to run cpulimit instead. Ooops.
  # After fixing that, re-test.

Whoops, that's definitely my fault. Fixed in the next version (another patch).

 * Something else is wrong with the installation; even trivial tests of
   caduceus fail.  After building, doing:
   cd ~/rpmbuild/BUILD/why-2.13/examples-c/tutorial
   caduceus max.c
   make -f max.makefile zenon
  Ends in failure. Running:
 strace -v -f -e trace=process make -f max.makefile zenon
  shows that the makefile invokes dp, which in turn tries to call zenon.
  But trying to invoke zenon on the generated file:
zenon zenon/max_why.znn
  fails with a syntax error.  (I guess it's possible it has a bad bug
  in Zenon.)

I figured out that Why's Zenon output is wrong (it changed
between Zenon versions and remained undetected due to the
complete lack of Zenon documentation). I contacted upstream, and
they wrote a patch for me this morning. The change will be added
to the next version of Why.

 * I believe you're missing some Requires:.  I could yum erase tcl tk,
   and still install ALL the programs (including gwhy).  rpm can 
automatically
   deduce a lot of dependencies from library information, but it will miss
   stuff (e.g., stuff invoked via shell/command line).  I was expecting
   gwhy, at least, to have more dependencies.  I think that's a blocker.

I'll look at this.

 * Shouldn't the why-summer-school.tar.gz line include the URL?

No, because I created that file (a few PDFs packaged up).

 * Can you confirm that Fedora has the legal right to redistribute the 
included
 documents?  Fedora doesn't require the right to modify them (though that'd 
be
 nice), but we need to make sure that it's legal to redistributed them.  (Of
 course, if we could redistribute the .tex source files, that'd be even 
better.)

I'll ask upstream.

 Here are a few suggestions:
 * No %check section.   You ought to have SOME test in there, at least as a
 'smoke test' to make sure everything can run with a trivial input.  The 
build's
 bench subdirectory has useful tests (though you can't run ./bench 
directly -
 looks like they've changed --type-only and didn't fix the tests).

Right, I originally wanted to run their tests, but they didn't
work. I did make my own (exceptionally brief) test, but I haven't
included it yet - I will.

 * You ought to install the examples that come with the distribution, those 
in
 the build directory's examples/ and examples-c.  I suggest copying them 
to
 be placed somewhere under /usr/share/doc//examples. (you probably want 
it
 further organized than that). The Caduceus web page 
(http://caduceus.lri.fr/)
 points some out.  For the trick to doing this, see:
 http://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Examples

The example Makefiles are odd: the library files need to have
already been installed in the right places before the examples
can be compiled. Thus I can't put both in the build section, and
it doesn't seem right to put this in the install section...

 * /usr/bin/dp is an absurdly short name for /usr/bin, and almost certain to
 conflict with SOMETHING.  You might consider renaming that, too.

Changing dp's name would require patches for the following files:

Makefile.in
examples/Makefile.common
bench/java/bench

but I believe that's it (however, I could be introducing errors
here... again, maybe I'll suggest this change to upstream instead
who would better know how to fix it)

 * I'm slightly surprised that Caduceus, Krakatoa, and Jessie aren't split 
into
 separate packages.  Did you consider splitting them up?  Debian seems to 
have
 done the same thing, so I won't make that a blocker.

I wasn't quite sure, and Debian didn't, so I didn't.

 * Is there other documentation you can include, e.g., specifically for 
Caduceus,
 Krakatoa, and Jessie?  I see that the makefile can generate the documents, 
but
 that the release doesn't include the source .tex files.

I'll check on that.

 * The description isn't very clear for the unwashed masses, and 

[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 16:17 EST ---
- MUST: rpmlint must be run on every package. The output should be posted in the
review.

Multiple errors like the following:
merkaartor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/merkaartor/Interaction/CreateAreaInteraction.cpp
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

Check the permissions on the source code in the tarball.  If they're executable,
correct this in the spec to silence this warning.

- MUST: The package must be named according to the  Package Naming Guidelines .
Good.

- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on  Package Naming Guidelines 
.
Good.

- MUST: The package must meet the Packaging Guidelines .
Good.

- MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
Good.

- MUST: The License field in the package spec file must match the actual 
license.
Change license tag to GPLv2+

- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
Good.

- MUST: The spec file must be written in American English.
Good.

- MUST: The spec file for the package MUST be legible. If the reviewer is unable
to read the spec file, it will be impossible to perform a review. Fedora is not
the place for entries into the Obfuscated Code Contest (http://www.ioccc.org/).
Good.

- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this.
md5 matches.

- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
Builds great here.

- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed
in bugzilla, describing the reason that the package does not compile/build/work
on that architecture. The bug number should then be placed in a comment, next to
the corresponding ExcludeArch line. New packages will not have bugzilla entries
during the review process, so they should put this description in the comment
until the package is approved, then file the bugzilla entry, and replace the
long explanation with the bug number. The bug should be marked as blocking one
(or more) of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86 , FE-ExcludeArch-x64 , FE-ExcludeArch-ppc , 
FE-ExcludeArch-ppc64 
N/A

More to come. . .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 16:30 EST ---
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the [wiki:Self:Packaging/Guidelines#Exceptions exceptions
section of Packaging Guidelines] ; inclusion of those as BuildRequires is
optional. Apply common sense.
Mock build pending.

- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
Good.

- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. If the package has multiple subpackages with libraries, each
subpackage should also have a %post/%postun section that calls /sbin/ldconfig.
An example of the correct syntax for this is:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

N/A

- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.

N/A

- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. Refer to the Guidelines for examples.

Good.

- MUST: A package must not contain any duplicate files in the %files listing.

Good.

- MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.

See rpmlint output above.

- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} ([wiki:Self:Packaging/Guidelines#UsingBuildRootOptFlags or
$RPM_BUILD_ROOT] ).

Good.

- MUST: Each package must consistently use macros, as described in the
[wiki:Self:Packaging/Guidelines#macros macros section of Packaging Guidelines] .

Good.

- MUST: The package must contain code, or permissable content. This is described
in detail in the [wiki:Self:Packaging/Guidelines#CodeVsContent code vs. content
section of Packaging Guidelines] .

Good.

- MUST: Large documentation files should go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity)
- MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
- MUST: Header files must be in a -devel package.
- MUST: Static libraries must be in a -static package.

N/A.

- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
- MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
- MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.

N/A.

- MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. This is described in detail in the
[wiki:Self:Packaging/Guidelines#desktop desktop files section of Packaging
Guidelines] . If you feel that your packaged GUI application does not need a
.desktop file, you must put a comment in the spec file with your explanation.

Good.

- MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another package
owns, then please present that at package review time.

Good.

- MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
([wiki:Self:Packaging/Guidelines#UsingBuildRootOptFlags or $RPM_BUILD_ROOT] ).
See [wiki:Self:Packaging/Guidelines#PreppingBuildRootForInstall Prepping
BuildRoot For %install] for details.

Good.

- MUST: All filenames in rpm packages must be valid UTF-8.

Good.

Most of the SHOULDs are OK or NA.  Once I finish my mock build I'll have an idea
of any BuildRequires problems. So far the only MUSTFIXs are the license tag 

[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 16:54 EST ---
 - MUST: The License field in the package spec file must match the 
 actual license. Change license tag to GPLv2+

I don't think GPLv2+ is correct. The licensing information in the tarball does
need to be improved and I'll try to get that process started. There are two
places where GPLv2 is  mentioned - the webpage
(http://www.irule.be/bvh/c++/merkaartor/ - not relevant for the package) and the
About-Dialog: This program is licensed under the GNU Public License v2


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 16:57 EST ---
The comments in parts of the source, it says v2 or any later version.  If they
intend GPLv2 only, they need to say that.  Until they do, it needs to be GPLv2+,
or at least: License: GPLv2 and GPLv2+.


Mock build is OK, so the BuildRequires are good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436704] Review Request: mapnik - a Free toolkit for developing mapping applications

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mapnik - a Free toolkit for developing mapping 
applications


https://bugzilla.redhat.com/show_bug.cgi?id=436704





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:00 EST ---
Thank you Tasaka for the patience !
I'll fix #23 comments ASAP on my side.

Spot, I don't insist with the license:
http://geogratis.cgdi.gc.ca/geogratis/en/licence.jsp

Would be fine w/o, at last this particular package 
can live fine without those vector datasets
even forever, if they are declined I'll repack a -fedora 
tarball with README.fedora placeholder where I will
mention the explicit removal out from original tarball.


 I am bit dissapointed  with functional misbehavior of some 
plugins/parts, invested some time to fix it, functionality 
is pretty worse on linux, upstream politics is wierd too,
next release will e.g depend on significantly totaly other 
libs, cmake seems to be dropped in SVN, but package still provide
something unique in opensource land, e.g openstreetmap.org
render their maps with mapnik, apperantly google maps too, 
and there is no other replacement tool to do this fine render 
job in GIS world for free yet.
  I wanted a SVN one pack but its impossible to compile/fix,
due to total different lib requirements which even dont exist
(i wasnt able to locate where such external functions lives
at all).



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:14 EST ---
You're right wrt. the mentioning of GPLv2+ - but according to 

http://fedoraproject.org/wiki/Licensing/FAQ

GPLv2 ist still correct for the package:

 The source code contains some .c files which are GPLv2 and some other .c 
 files which are GPLv2+. They're compiled together to form an executable. In 
 this case, the stricter license wins, so the resulting executable is GPLv2. 
 The License tag should read: License: GPLv2 Note that you do NOT need to list 
 GPLv2 and GPLv2+ in the License tag. 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456345] Review Request: sportrop-fonts - A multiline decorative font

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sportrop-fonts - A multiline decorative font


https://bugzilla.redhat.com/show_bug.cgi?id=456345





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:18 EST ---
Hi Jon,

After discussing it on various forums the consensus seems to be that only the
OTF (OpenType CFF) version should be packaged. So you can simplify the whole
thing considerably.

I apologize for waiting so long to get this part clarified

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456398] Review Request: why - Why software verification platform

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: why - Why software verification platform


https://bugzilla.redhat.com/show_bug.cgi?id=456398





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:18 EST ---
 * I believe you're missing some Requires:.  I could yum erase tcl tk,
   and still install ALL the programs (including gwhy).  rpm can 
automatically
   deduce a lot of dependencies from library information, but it will miss
   stuff (e.g., stuff invoked via shell/command line).  I was expecting
   gwhy, at least, to have more dependencies.  I think that's a blocker.

gwhy has a lot of requires (as automatically determined by the RPM build 
system):

/bin/sh
libatk-1.0.so.0
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.2)
libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4)
libcairo.so.2
libdl.so.2
libdl.so.2(GLIBC_2.0)
libdl.so.2(GLIBC_2.1)
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libglib-2.0.so.0
libgmodule-2.0.so.0
libgobject-2.0.so.0
libgtk-x11-2.0.so.0
libm.so.6
libm.so.6(GLIBC_2.0)
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpthread.so.0
libpthread.so.0(GLIBC_2.0)
libpthread.so.0(GLIBC_2.1)
libpthread.so.0(GLIBC_2.2)
libpthread.so.0(GLIBC_2.3.2)
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rtld(GNU_HASH)
why
zenity

What other ones would it have? There are no packages tcl or tk... it 
certainly doesn't require tcllib and tklib. Furthermore, gwhy really 
depends on gtk, not tk (which it does indeed appropriately require as above). 
I'm pretty sure rpmbuild indeed saw that gwhy was just a shell script that 
calls gwhy-bin (since running find-requires on just gwhy produces /bin/sh). 
Was there something else you had in mind?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:22 EST ---
I sit corrected.  Should be just the perms issue then (saw your email).  I
suspect a %{__chmod} 644 *.h and .cpp or somesuch, prior to the build, would be 
ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456603] New: Review Request: oggvideotools - Toolbox for manipulating Ogg video files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=456603

   Summary: Review Request: oggvideotools - Toolbox for manipulating
Ogg video files
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://domsch.com/linux/fedora/oggvideotools.spec
SRPM URL: http://domsch.com/linux/fedora/oggvideotools-0.4-1.fc9.src.rpm
Description: 
A toolbox for manipulating Ogg video files, which usually consist of a
video stream (Theora) and an audio stream (Vorbis). It includes a
number of handy command line tools for manipulating these video files,
such as for splitting the different streams.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454208] Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: florence -  Florence is an extensible scalable 
on-screen virtual keyboard for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=454208





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:31 EST ---
okay, i hope i got the trick.

Spec URL:
http://packages.cassmodiah.de/fedora/florence/bug-454208/florence-0.2.2-3/florence.spec
SRPM URL:
http://packages.cassmodiah.de/fedora/florence/bug-454208/florence-0.2.2-3/florence-0.2.2-3.fc9.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452395] Review Request: lxlauncher - Open source replacement for Asus Launcher of the EeePC

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lxlauncher - Open source replacement for Asus Launcher 
of the EeePC


https://bugzilla.redhat.com/show_bug.cgi?id=452395


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:43 EST ---
Okay, let's do the official review: I checked all my points which are mostly 
equivalent to that ones already mentioned, so I'll not re-post my list. From 
my side I've no complaints at all.

 NOK | MUST: Packages containing GUI applications must include…

I agree with the requestor that no *.desktop is required, doesn't make sense
here. Maybe the hint for the autostart can be put into a README-FEDORA or a 
similar file, but per default enabled when maybe some/not all desktops/window 
managers are supporting it, is not ideal.

 NOK  | MUST: Packages must not own files or directories already

I can't see any issue here, the result in the built RPM package looks fine.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445151] Review Request: merkaartor - openstreetmap editor

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: merkaartor - openstreetmap editor


https://bugzilla.redhat.com/show_bug.cgi?id=445151





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 17:47 EST ---
rpmlint is happy now - updated files:

Spec URL: http://sven.lank.es/Fedora/SPECS/merkaartor.spec
SRPM URL: http://sven.lank.es/Fedora/SRPM/merkaartor-0.0.10-7.fc10.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456429] Review Request: chm2pdf - A tool to convert CHM files to PDF files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: chm2pdf - A tool to convert CHM files to PDF files


https://bugzilla.redhat.com/show_bug.cgi?id=456429


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 18:03 EST ---
Package has a small license field issue. Rest package is okay.

Required:
[x] rpmlint output: clean
[x] package and spec naming
[x] packaging guideline
[x] license file included
[!] license field should be GPLv2+
[x] spec file -- is legible and written in American English
[x] md5sum
 Upstream: 2d5518e3284cca496270566c2554b713
 Package Source: 2d5518e3284cca496270566c2554b713
[x] package builds on koji
[x] package working on i686 
[x] BuildRequires tag
[NA] locales
[NA] static libraries, shared libraries, header files
[x] owns directory it creates
[x] no duplicates files  
[x] file permissions
[x] %clean and %install section have rm -rf $RPM_BUILD_ROOT
[x] macros used consistently
[x] package has permissible content
[x] program runs independent of files in %doc
[NA] GUI
[x] All file encoding is utf-8
[x] no unnecessary bite compilation
[x] egg-info file included
[x] 

Optional:
[x] LICENSE file included
[x] description and summary not available in other languages
[x] package builds in koji
[x] package works as expected
[NA] no sciriptlets
[NA] no subpackages  
[x] no dependencies outside paths in FH Guidelines

Optional Suggestions(you may consider not using them):
a. you can remove python_sitearch definition as it is not being used

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452523] Review Request: perl-Event-ExecFlow - High level API for event-based execution flow control

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Event-ExecFlow - High level API for event-based 
execution flow control


https://bugzilla.redhat.com/show_bug.cgi?id=452523


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video 
files


https://bugzilla.redhat.com/show_bug.cgi?id=456603





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 18:22 EST ---
yes, I know it doesn't build in mock; I need to figure out how to get autoconf
to run, as the one patch necessarily changes configure.ac.  right now autoconf
and autoreconf both fail.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436704] Review Request: mapnik - a Free toolkit for developing mapping applications

2008-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mapnik - a Free toolkit for developing mapping 
applications


https://bugzilla.redhat.com/show_bug.cgi?id=436704





--- Additional Comments From [EMAIL PROTECTED]  2008-07-24 19:00 EST ---
new packs:
http://openrisc.rdsor.ro/mapnik.spec
http://openrisc.rdsor.ro/mapnik-0.5.1-3.fc9.src.rpm

---
This is intentionate:
mapnik-demo.x86_64: E: devel-dependency mapnik-devel

Plugins are clean:
ldd -r /usr/lib64/mapnik/input/* /dev/null

Dir ownership fixed:
# rpm -qf /usr/lib64/mapnik
mapnik-0.5.1-3.fc9.x86_64

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >