[Bug 466648] Review Request: dnstracer - Trace a DNS record to its start of authority
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466648 --- Comment #4 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 02:01:02 EDT --- dnstracer-1.9-1.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/dnstracer-1.9-1.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466648] Review Request: dnstracer - Trace a DNS record to its start of authority
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466648 --- Comment #5 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 02:01:10 EDT --- dnstracer-1.9-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/dnstracer-1.9-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446800] Review Request: ebnetd - EBNET protocol server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=446800
--- Comment #11 from Akira TAGOH [EMAIL PROTECTED] 2008-10-15 02:07:26 EDT
---
unable to build the package due to FAILED: BuildError: package ebnetd not in
list for tag dist-{f10,{f9,f8}-updates-candidate}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464441] Review Request: HamFax - An application for sending and receiving facsimiles in amateur radio.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464441 --- Comment #8 from Randall Berry [EMAIL PROTECTED] 2008-10-15 02:30:31 EDT --- Yet another practice review. Bug URL: https://bugzilla.redhat.com/show_bug.cgi?id=458402 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458402] Review Request: griffith - Media collection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=458402
Randall Berry [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Randall Berry [EMAIL PROTECTED] 2008-10-15 02:18:59 EDT
---
Practice Review:
[*] OK
[x] Fail (see comment)
[o] Not Applicable
[?] Questions
[*] MUST: rpmlint must be run on every package. The output should be posted in
the review.
Comment: 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[*] MUST: The package must be named according to the Package Naming Guidelines.
[*] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming
Guidelines.
[*] MUST: The package must meet the Packaging Guidelines.
[*] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[*] MUST: The License field in the package spec file must match the actual
license.
[*] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[*] MUST: The spec file must be written in American English.
[*] MUST: The spec file for the package MUST be legible. If the reviewer is
unable to read the spec file, it will be impossible to perform a review.
Fedora is not the place for entries into the Obfuscated Code Contest
(http://www.ioccc.org/).
[*] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If
no upstream URL can be specified for this package, please see the Source
URL
Guidelines for how to deal with this.
Comment: Upstream URL works, but no md5sum available
[*] MUST: The package must successfully compile and build into binary rpms on
at
least one supported architecture.
Comment: Successful mock build on F9 i386, Rawhide 1386 run tested on F9
i386
[*] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug
filed in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number should then be
placed in a comment, next to the corresponding ExcludeArch line. New
packages will not have bugzilla entries during the review process,
so they should put this description in the comment until the package is
approved, then file the bugzilla entry, and replace the long explanation
with the bug number. The bug should be marked as blocking one (or more) of
the following bugs to simplify tracking such issues: FE-ExcludeArch-x86 ,
FE-ExcludeArch-x64 , FE-ExcludeArch-ppc , FE-ExcludeArch-ppc64
[*] MUST: All build dependencies must be listed in BuildRequires, except for
any
that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional. Apply common sense.
[*] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[o] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig
in %post and %postun. If the package has multiple subpackages with
libraries, each subpackage should also have a %post/%postun section that
calls /sbin/ldconfig.An example of the correct syntax for this is:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[o] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[*] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does
create that directory. Refer to the Guidelines for examples.
[*] MUST: A package must not contain any duplicate files in the %files listing.
[*] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[*] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} ( or $RPM_BUILD_ROOT ).
[x] MUST: Each package must consistently use macros, as described in the macros
[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457517 --- Comment #13 from Marcela Maslanova [EMAIL PROTECTED] 2008-10-15 02:38:01 EDT --- http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462818] Review Request: perl-Net-SMTP-SSL - SSL support for Net::SMTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462818 --- Comment #12 from Paul Howarth [EMAIL PROTECTED] 2008-10-15 02:39:31 EDT --- You don't actually need to request an F-10 branch here; if you omit it you'll still get the devel branch for Rawhide that will eventually become F-10. There will be a mass branching of all packages shortly before F-10 goes gold to create an F-10 branch from what's currently in devel. The availability of early F-10 branching (which is what you've requested here) is targeted at packages for which major changes will be happening in the F-11 development period, so that those changes can get underway now in CVS without affecting what will be going into F-10. Having said that, it's not going to do any harm to have the F-10 branch earlier, and this package is unlikely to change before the mass branching happens. Just so you know... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457517 Dan Horák [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #14 from Dan Horák [EMAIL PROTECTED] 2008-10-15 02:46:04 EDT --- All issues fixed, package is APPROVED. But remove the --add-category parameter when calling desktop-file-install (category is already set in the dekstop file itself) before import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466762] Review Request: ipmitool - Utility for IPMI control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466762 --- Comment #9 from Jan Safranek [EMAIL PROTECTED] 2008-10-15 03:09:14 EDT --- oops, I don't know what went wrong, but the srpm has old (=wrong) .spec file. I uploaded new .srpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458402] Review Request: griffith - Media collection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458402 --- Comment #2 from Randall Berry [EMAIL PROTECTED] 2008-10-15 02:44:16 EDT --- One comment I forgot to mention. The Website URL appears to be a domain parker with pop-ups included. Is this correct or is this a temporary place holder for the website listed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457517 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Marcela Maslanova [EMAIL PROTECTED] 2008-10-15 02:54:06 EDT --- New Package CVS Request === Package Name: perl-Padre Short Description: text editor aimed to be an IDE for Perl Owners: mmaslano Branches: F-10 rawhide InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446800] Review Request: ebnetd - EBNET protocol server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=446800 Akira TAGOH [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Akira TAGOH [EMAIL PROTECTED] 2008-10-15 03:34:22 EDT --- there seems to be a delay. it's ok now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458402] Review Request: griffith - Media collection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458402 --- Comment #3 from Randall Berry [EMAIL PROTECTED] 2008-10-15 03:41:33 EDT --- My Bad.. I forgot to check all packages and not just src.rpm. [x] MUST: rpmlint must be run on every package. The output should be posted in the review. griffith.i386: W: symlink-should-be-relative /usr/bin/griffith /usr/share/griffith/lib/griffith griffith.i386: W: file-not-utf8 /usr/share/man/pl/man1/griffith.1.gz griffith.i386: E: no-binary griffith-debuginfo.i386: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426867] Review Request: scala - Hybrid functional/object-oriented language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=426867 --- Comment #78 from Harshad RJ [EMAIL PROTECTED] 2008-10-15 04:24:43 EDT --- Hoorray! I am very pleased to see this finally come through. I am still unable to actually see it my package list. Do you think a mirror would take this long to pick up the update? This was the command I used: yum --enablerepo=updates-testing-newkey list scala* PS. I tried posting on the admin.fedoraproject.org page, but it gives me an internal error of some kind, hence posting here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 --- Comment #3 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 04:05:40 EDT --- Forgot to say that there is a dot missing at the end of %description. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459631] Review Request: insight - GDB debugger GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459631 --- Comment #16 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 06:39:39 EDT --- insight-6.8-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/insight-6.8-4.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459631] Review Request: insight - GDB debugger GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459631 --- Comment #17 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 06:39:44 EDT --- insight-6.8-4.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/insight-6.8-4.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466743] Review Request: hunspell-br - Breton hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466743 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #27 from Stepan Kasal [EMAIL PROTECTED] 2008-10-15 09:26:09 EDT --- (In reply to comment #26) I said: I think that this upload failed because I had not the ssh key in my ssh keyring at the moment. This does not seem likely, the ssh key is used later, for cvs update. But in any case, it looks like a bug that make upload left things in an inconsistent state. Indeed, it looks like a bug in update.cgi; don't you, by any chance, know against what component should the bug be filed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #28 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 09:49:28 EDT --- I am missing something, isn't the file in the lookaside cache since a long time now? Subsequente make upload won't change the timestamp. In fact I guess that it was automatically imported, or something like that, during the marge from the old Red Haat internal buildsystem. Anyway it isn't important, just fix the Provides and we're done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459924] Review Request: Homestead - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459924 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #5 from Jon Ciesla [EMAIL PROTECTED] 2008-10-15 09:49:30 EDT --- Corrections. License tag should be GPLv2+. Minor correction to desktop file handling, alter the vendor tag: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop a la: --vendor=vendor_id Otherwise, no major issues with the review or package. Randall, once you're sponsored, you can take ownership, verify the fixes and approve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466795] Review Request: boswars-addons - addon maps for Bos Wars
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466795 Peter Lemenkov [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Flag||fedora-review? --- Comment #1 from Peter Lemenkov [EMAIL PROTECTED] 2008-10-15 09:58:54 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467051] New: Review Request: arp-scan - scan network using ARP protocol.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: arp-scan - scan network using ARP protocol. https://bugzilla.redhat.com/show_bug.cgi?id=467051 Summary: Review Request: arp-scan - scan network using ARP protocol. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://ispbrasil.com.br/arp-scan/arp-scan.spec SRPM URL: http://ispbrasil.com.br/arp-scan/arp-scan-1.7-1.fc10.src.rpm Description: arp-scan sends ARP (Address Resolution Protocol) queries to the specified targets, and displays any responses that are received. It allows any part of the outgoing ARP packets to be changed, allowing the behavior of targets to non-standard ARP packets to be examined. The IP address and hardware address of received packets are displayed, together with the vendor details. These details are obtained from the IEEE OUI and IAB listings, plus a few manual entries. It includes arp-fingerprint, which allows a system to be fingerprinted based on how it responds to non-standard ARP packets. arp-scan is very useful if you want to migrate a network to use DHCP -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458402] Review Request: griffith - Media collection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=458402
Jon Ciesla [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #4 from Jon Ciesla [EMAIL PROTECTED] 2008-10-15 10:02:54 EDT ---
Comments on practice review:
[x] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
Comment: missing %{name} macro in Source0: URL %{name} macro is used
consistently through out spec should be used here also.
This particular case is more of a convenience, not a necessity. In fact,
sometimes I see macros overused, like %{version} in patch name, which must then
be hard-coded or renamed if the patch is valid over multiple versions, but this
is not the case here.
One comment I forgot to mention. The Website URL appears to be a domain parker
with pop-ups included. Is this correct or is this a temporary place holder for
the website listed?
README gives http://www.griffith.cc, which is much better.
[*] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install
in the %install section. This is described in detail in the desktop files
section of the Packaging Guidelines . If you feel that your packaged GUI
application does not need a .desktop file, you must put a comment in the
spec file with your explanation.
Actually, this is not *quite* correctly handled:
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop
Otherwise, a good review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #30 from Stepan Kasal [EMAIL PROTECTED] 2008-10-15 10:06:07 EDT --- (In reply to comment #28) I am missing something, isn't the file in the lookaside cache since a long time now? No, it isn't; the file in cvs has yesterday's time stamp: -rw-rw-r-- 1 dumas dumas 27336 oct. 14 12:13 XML-Grove-0.46alpha.tar.gz-cvs and I imported that file yesterday. And I did the import yesterday, using the originial tar.gz, dowloaded from upstream, with the right 1999 time stamp. But the upload command (upload.cgi, called from make new-source) screwed the time stamp. I do not know why. I agree with you that there is no known way to fix the time stamp now. I think that the bug in upload.cgi which caused that, should be reported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #29 from Stepan Kasal [EMAIL PROTECTED] 2008-10-15 09:59:54 EDT --- (In reply to comment #24) There are spurious provides coming from examples: Provides: perl(MyHTML) perl(MyVisitor) indeed. So it seems the messages were almost right: perl-XML-Grove.noarch: W: doc-file-dependency /usr/share/doc/perl-XML-Grove-0.46alpha/examples/my-html.pl perl(XML::Parser::PerlSAX) perl-XML-Grove.noarch: W: doc-file-dependency /usr/share/doc/perl-XML-Grove-0.46alpha/examples/visitor.pl perl(XML::Parser::PerlSAX) Had it mentioned perl(MyHTML) and perl(MyVisitor), respectively, the messages would have named the problem. But the rpmlint -i hint says that it helps to clear the exec bit of the files. This is not true, the bit is cleared, yet the dependency generator brings in the wrong provides. Should I fight against the dependency generator somehow? gzipping the examples, rot13-encoding, renaming them, clearing the #! line or whatever... ??? Or is it enough to file a bug aginst the buggy dependency generator? To sum up, I still apply for the approval of the package in its current state in the cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #31 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 10:09:00 EDT --- (In reply to comment #30) (In reply to comment #28) I am missing something, isn't the file in the lookaside cache since a long time now? No, it isn't; the file in cvs has yesterday's time stamp: I forgot about the .tar.gz vs .tar.bz2. I think that the bug in upload.cgi which caused that, should be reported. I guess that the best location would be the trac of the infrastructure team. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464441] Review Request: HamFax - An application for sending and receiving facsimiles in amateur radio.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464441 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added Blocks|177841 | Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467051] Review Request: arp-scan - scan network using ARP protocol.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467051 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 Alias||arp-scan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #32 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 10:16:24 EDT --- (In reply to comment #29) (In reply to comment #24) There are spurious provides coming from examples: Provides: perl(MyHTML) perl(MyVisitor) indeed. So it seems the messages were almost right: perl-XML-Grove.noarch: W: doc-file-dependency /usr/share/doc/perl-XML-Grove-0.46alpha/examples/my-html.pl perl(XML::Parser::PerlSAX) perl-XML-Grove.noarch: W: doc-file-dependency /usr/share/doc/perl-XML-Grove-0.46alpha/examples/visitor.pl perl(XML::Parser::PerlSAX) No, unless I am wrong it is about Requires, not about Provides, and I thing that it is harmless since those Requires are Provided by the package or are also a Requires for the package. Had it mentioned perl(MyHTML) and perl(MyVisitor), respectively, the messages would have named the problem. But the rpmlint -i hint says that it helps to clear the exec bit of the files. This is not true, the bit is cleared, yet the dependency generator brings in the wrong provides. The perl dependencies generator doesn't take into account the exec bit since .pm are not executables in general. Should I fight against the dependency generator somehow? gzipping the examples, rot13-encoding, renaming them, clearing the #! line or whatever... ??? I don't think so. Or is it enough to file a bug aginst the buggy dependency generator? The bug I see is that rpmlint should say that perl(MyHTML) and perl(MyVisitor) are doc file Provides dependencies, I don't see a bug in the dependency generator. And the rpmlint explanation is untrue, but rpmlint cannot know about all dependency generators, especially those that are customized. To sum up, I still apply for the approval of the package in its current state in the cvs. The perl(MyHTML) and perl(MyVisitor) provides should be removed. They are bogus provides, even though rpmlint doesn't find them... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 --- Comment #5 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 10:24:05 EDT --- The timestamp of the source archive is not kept: -rw-rw-r-- 1 dumas dumas 20480 juil. 22 1999 sl.tar -rw-rw-r-- 1 dumas dumas 20480 févr. 13 2008 ../SOURCES/sl.tar Otherwise seems ok to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 --- Comment #6 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 10:29:15 EDT --- Forgot one thing. In general I think that it is pretty bad to use a two letter command, since the number of two letter command names is scarce and they should be used wisely. However in that case I think that the name is not really taken since sl could just go if something serious wants the command name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464441] Review Request: HamFax - An application for sending and receiving facsimiles in amateur radio.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464441 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Comment #9 from Jon Ciesla [EMAIL PROTECTED] 2008-10-15 10:13:18 EDT --- Given the reviews you've completed, and our email exchange, I'm comfortable that you've got a good and improving grasp of the Packaging Guidelines and review process. I've sponsored your FAS account, APPROVED your package, and you're ready to request cvs branching, import, and build. I'd recommend devel (required, and no need to request) and F-9 branches. You can also take ownership of the reviews you did, verify that the changes get made, and approve them when ready. Feel free to shoot questions my way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463017] Review Request: getdata - Library for reading and writing dirfile data.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463017 Michael Schwendt [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Michael Schwendt [EMAIL PROTECTED] 2008-10-15 10:38:50 EDT --- * -devel pkg description still mentions static libs - fix this * gfortran build does not use our global $FFLAGS, but -g -O2 * Hint: Include manual pages as '*' or 'foo*' but drop the 'gz' because the rpmbuild compressor for man pages may change. * Why not include the AUTHORS and TODO files as %doc? * a shorter tar.bz2 release is available * a detached signature is available for the source tarballs - consider uploading and including them in fedora pkg cvs sources files Minor things which can be fixed in pkg cvs. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464822] Review Request: clojure - A dynamic programming language that targets the Java Virtual Machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464822 --- Comment #2 from Colin Walters [EMAIL PROTECTED] 2008-10-15 10:44:53 EDT --- Thanks for the review. On the version numbering, I was wrong in our IRC discussion. The main upstream version is 20080916 - it's not an SVN snapshot. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #34 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 10:54:26 EDT --- I don't think that the perl(XML::Parser::PerlSAX) requires should be removed, it is really required (unless I am wrong), not only by a doc file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465381] Review Request: sugar-moon - Lunar Activity for the sugar desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465381 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 Paul Howarth [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #35 from Paul Howarth [EMAIL PROTECTED] 2008-10-15 11:04:56 EDT --- (In reply to comment #34) I don't think that the perl(XML::Parser::PerlSAX) requires should be removed, it is really required (unless I am wrong), not only by a doc file. Hmm, you're right, it's used by XML::Grove and XML::Grove::Subst. I wonder why rpmlint had it down as a doc file dependency then? So the requires filter isn't needed at all then, which simplifies things. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 --- Comment #7 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 11:15:26 EDT --- Some notes for -4: * License - Please write explicitly from which you borrowed the license text in the spec file (and also in sl.COPYRIGHT) as comments. Perhaps it is from: http://ftp.debian.org/debian/pool/main/s/sl/sl_3.03-15.diff.gz * defattr - We now recommend %defattr(-,root,root,-) * manfile - Files under %_mandir are automatically marked as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 --- Comment #55 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 11:20:28 EDT --- gromacs-4.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/gromacs-4.0-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 --- Comment #8 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 11:33:41 EDT --- One more thing: * %dist tag - Please remove %dist tag from %changelog entry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 --- Comment #56 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 11:32:07 EDT --- gromacs-4.0-3.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/gromacs-4.0-3.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463266] Review Request: globalplatform - Access OpenPlatform and GlobalPlatform smart cards library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463266 --- Comment #9 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 11:34:46 EDT --- Well, this package itself is now good, so now I will wait for your another review request or your pre-review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 --- Comment #57 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 11:34:46 EDT --- gromacs-4.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/gromacs-4.0-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452107] Review Request: cfdg - Context Free Design Grammar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452107 --- Comment #11 from Jon Ciesla [EMAIL PROTECTED] 2008-10-15 09:10:56 EDT --- Wow, thanks, your suggestions are more details than some people's instructions. :) SPEC: http://zanoni.jcomserv.net/fedora/cfdg/cfdg.spec SRPM: http://zanoni.jcomserv.net/fedora/cfdg/cfdg-2.1-4.fc9.src.rpm All addressed/applied. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 --- Comment #58 from Jussi Lehtola [EMAIL PROTECTED] 2008-10-15 11:54:28 EDT --- Sorry for the spams about updates. Had to fight a bit with Bodhi to get the package included; the additional builds thingy in web bodhi doesn't seem to work, it only picks one of them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #33 from Paul Howarth [EMAIL PROTECTED] 2008-10-15 10:45:22 EDT --- Created an attachment (id=320442) -- (https://bugzilla.redhat.com/attachment.cgi?id=320442) Patch to remove bogus deps and provides Here's a simple patch that removes the bogus provides for perl(MyHTML) and perl(Visitor), the unversioned perl(XML::Grove) provide (leaving the versioned one), and the doc file dependencies that rpmlint complains about. It also switches the position of the -depth option in a find command to the start of the command, a style thing that I just can't seem to help myself fixing wherever I come across it ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445537] Review Request: tightvnc - VNC software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=445537
--- Comment #10 from Adam Tkac [EMAIL PROTECTED] 2008-10-15 08:13:48 EDT ---
(In reply to comment #9)
formal review is here, see the notes below:
BAD package meets naming and versioning guidelines.
Fixed
BAD compiler flags are appropriate.
Fixed, -O0 was (and probably will be during early F11 cycle) temporary option
because it makes core dumps more usable.
BAD scriptlets present
Fixed
- rpmlint complains:
tightvnc-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/tightvnc-1.5.0-svn2975/unix/xserver/*/*.[ch] (about 12 files)
run chmod a-x unix/xserver/*/*.[ch] after copying the xorg-x11-server-Xorg
sources into the tightvnc tree
Fixed
- the EVR in Obsoletes/Provides must be greater than the EVR of the package we
are replacing (use EVR=4.1.2-36, no dist tag) - see
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages
Fixed
- server subpackage should have Requires: xorg-x11-server-Xorg for the
ownership of %{_libdir}/xorg/modules/extensions/
dependency on xorg-x11-server-Xorg doesn't seem so good for me so I moved
libvnc.so module to server-module subpackage which requires
xorg-x11-server-Xorg
- remove the X-Red-Hat-Extra from the desktop file
Removed
Updated sources:
http://people.redhat.com/atkac/tightvnc.spec
http://people.redhat.com/atkac/tightvnc-1.5.0-0.5.20081015svn3019.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462818] Review Request: perl-Net-SMTP-SSL - SSL support for Net::SMTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462818 --- Comment #13 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-15 06:09:31 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464441] Review Request: HamFax - An application for sending and receiving facsimiles in amateur radio.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464441 Robert 'Bob' Jensen [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #11 from Robert 'Bob' Jensen [EMAIL PROTECTED] 2008-10-15 12:00:06 EDT --- Way To Go Randy. Thanks a lot Jon for sponsoring Randy, he has been a valuable member of our Amateur Radio SIG already, packaging will make him even more so. Good work guys. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464822] Review Request: clojure - A dynamic programming language that targets the Java Virtual Machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464822 Conrad Meyer [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Conrad Meyer [EMAIL PROTECTED] 2008-10-15 11:54:54 EDT --- Then that's perfectly acceptable. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 Jussi Lehtola [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445537] Review Request: tightvnc - VNC software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=445537
--- Comment #11 from Dan Horák [EMAIL PROTECTED] 2008-10-15 09:18:17 EDT ---
Yet 2 little issues
- the License tag should be GPLv2+ (sorry I missed that in the first round)
- include instructions for getting the sources - see
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
(svn export https://vnc-tight.svn.sourceforge.net/svnroot/vnc-tight/trunk -r
%{revision} tightvnc; tar czvf ...)
And one suggestion - can you move this section
cp -r %{_datadir}/xorg-x11-server-source/* unix/xserver
pushd unix/xserver
for all in `find . -type f -perm -001`; do
chmod -x $all
done
patch -p0 ../xserver.patch
from %build to %prep, because this is in fact source preparation too.
And last thing (not related to the review) could be refreshing the
xserver.patch, because it applies quite unclean.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464441] Review Request: HamFax - An application for sending and receiving facsimiles in amateur radio.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464441 --- Comment #12 from Jon Ciesla [EMAIL PROTECTED] 2008-10-15 12:13:25 EDT --- NP, the more the merrier. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 --- Comment #4 from Marc Bradshaw [EMAIL PROTECTED] 2008-10-15 04:38:47 EDT --- Thanks Pat, I assume you mean mv -f rather than rm -f and have incorporated the suggestions into a new revision. http://marcbradshaw.co.uk/packages/review/sl/sl-3.03-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466997] Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466997 Patrice Dumas [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Patrice Dumas [EMAIL PROTECTED] 2008-10-15 04:03:58 EDT --- The mail transcript should be directly in the package as asource, so Source2: http://marcbradshaw.co.uk/packages/review/sl/sl-license-mail.txt would work, with cp and adding to %doc. I suggest removing the /bin/ and let the commands be searched on the path. You should use cp -p and install -p (for the manpage) to keep timestamps. Also I suggest doing something along: iconv -f iso-2022-jp README -t utf8 README.conv README.conv \ touch -c -r README \ mv README.conv README Also the -f of rm is not needed, it is always the default in rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #36 from Stepan Kasal [EMAIL PROTECTED] 2008-10-15 12:28:20 EDT --- OK, I incorporated Paul's changes. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465694] Review Request: drascula - Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465694 Lucian Langa [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Lucian Langa [EMAIL PROTECTED] 2008-10-15 12:24:10 EDT --- New Package CVS Request === Package Name: drascula Short Description: Drascula: The Vampire Strikes Back Owners: lucilanga Branches: F-8 F-9 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445537] Review Request: tightvnc - VNC software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445537 --- Comment #12 from Adam Tkac [EMAIL PROTECTED] 2008-10-15 12:17:20 EDT --- All problems should be fixed: http://people.redhat.com/atkac/tightvnc-1.5.0-0.6.20081015svn3021.fc10.src.rpm http://people.redhat.com/atkac/tightvnc.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 --- Comment #54 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-15 06:13:01 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465758] Review Request: perl-Net-Daemon - Perl extension for portable daemons
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465758 Petr Lautrbach [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Petr Lautrbach [EMAIL PROTECTED] 2008-10-15 08:24:16 EDT --- New Package CVS Request === Package Name: perl-Net-Daemon Short Description: Perl extension for portable daemons Owners: plautrba Branches: F-8 F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459631] Review Request: insight - GDB debugger GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459631 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #18 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 09:00:19 EDT --- Thanks, now closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466743] Review Request: hunspell-br - Breton hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466743 --- Comment #3 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-15 05:52:53 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465381] Review Request: sugar-moon - Lunar Activity for the sugar desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465381 --- Comment #6 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-15 06:02:59 EDT --- You dont seem to be sponsored yet. Setting the sponsor flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466743] Review Request: hunspell-br - Breton hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466743 Caolan McNamara [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453016] Review Request: un-core-fonts - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453016 --- Comment #44 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 13:02:55 EDT --- un-core-fonts-1.0.2-0.6.080608.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/un-core-fonts-1.0.2-0.6.080608.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445537] Review Request: tightvnc - VNC software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445537 Dan Horák [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #14 from Dan Horák [EMAIL PROTECTED] 2008-10-15 12:48:28 EDT --- All issues are resolved and this package is APPROVED. Great work, Adam. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445537] Review Request: tightvnc - VNC software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445537 --- Comment #13 from Adam Tkac [EMAIL PROTECTED] 2008-10-15 12:40:39 EDT --- (In reply to comment #12) All problems should be fixed: http://people.redhat.com/atkac/tightvnc-1.5.0-0.6.20081015svn3021.fc10.src.rpm http://people.redhat.com/atkac/tightvnc.spec Well, SRPM written above is broken, updated one is: http://people.redhat.com/atkac/tightvnc-1.5.0-0.7.20081015svn3022.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465694] Review Request: drascula - Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465694 Toshio Ernie Kuratomi [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Toshio Ernie Kuratomi [EMAIL PROTECTED] 2008-10-15 12:40:19 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457517 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #17 from Marcela Maslanova [EMAIL PROTECTED] 2008-10-15 07:01:44 EDT --- Should be in F-10 perl-Padre-0.10-4.fc10. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-extra-fonts - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453017 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463266] Review Request: globalplatform - Access OpenPlatform and GlobalPlatform smart cards library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463266 --- Comment #8 from François Kooman [EMAIL PROTECTED] 2008-10-15 05:51:09 EDT --- Done: Spec URL: http://users.tuxed.net/fkooman/rpmbuild/SPECS/globalplatform.spec SRPM URL: http://users.tuxed.net/fkooman/rpmbuild/SRPMS/globalplatform-5.0.0-4.fc10.src.rpm I'll submit a review request for GPshell (which depends on globalplatform) shortly. Thanks! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466762] Review Request: ipmitool - Utility for IPMI control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466762 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Jon Ciesla [EMAIL PROTECTED] 2008-10-15 09:35:22 EDT --- Awesome. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457517 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465694] Review Request: drascula - Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465694 Michael Schwendt [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Michael Schwendt [EMAIL PROTECTED] 2008-10-15 07:25:31 EDT --- * desktop-file-validate drascula.desktop drascula.desktop: warning: key Encoding in group Desktop Entry is deprecated * there are two optional addon pkgs for music and other languages * speech sound is a bit choppy (compression? scummvm problem?) * packaging-wise: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459874] Review Request: zeromq - Fast messaging system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459874 Peter Lemenkov [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED] | |ect.org)| --- Comment #5 from Peter Lemenkov [EMAIL PROTECTED] 2008-10-15 04:55:44 EDT --- Yes,(In reply to comment #4) Is the license entry correct? Yes. Although they mentioned about re-licensing ZeroMQ, this was made only for trunk (and therefore for future releases). This release, 0.3.2, is still under GPLv3+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462251] Review Request: PyMOL - python molecular graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462251 --- Comment #24 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 08:57:23 EDT --- Well, while I does not have nVidia (I use intel), when I switch to vesa there does not seem to have any problem on this package. So for now I assume that there is something wrong with either X driver or mesa. So, @Tim if you have something you want to modify on your srpm would you do so and post on this bug the newest of URLs of your spec/srpm _anyway_ ? Then I will recheck your srpm again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461699] Review Request: remoot - ReMoot is a remote control wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461699 manuel wolfshant [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from manuel wolfshant [EMAIL PROTECTED] 2008-10-15 07:40:15 EDT --- I see no further blocker, package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-extra-fonts - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Comment #38 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-15 05:56:58 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 --- Comment #26 from Stepan Kasal [EMAIL PROTECTED] 2008-10-15 09:13:04 EDT --- (In reply to comment #24) ls -l *gz* -rw-rw-r-- 1 dumas dumas 27336 sept. 10 1999 XML-Grove-0.46alpha.tar.gz -rw-rw-r-- 1 dumas dumas 27336 oct. 14 12:13 XML-Grove-0.46alpha.tar.gz-cvs tarball timestamp was not kept. It is too late now, but please do it for the next time. Weird. My own copy of the file had the right time stamp when I issued make new-source FILES=XML-Grove-0.46alpha.tar.gz But it seems the upload process has crippled the time stamp. 2008-10-14 12:13:51 is the access time of the file on my disk, but I do not know if it is the time of download from upstream or the time of upload to fedora cvs. I think that this upload failed because I had not the ssh key in my ssh keyring at the moment. But in any case, it looks like a bug that make upload left things in an inconsistent state. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426867] Review Request: scala - Hybrid functional/object-oriented language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=426867 --- Comment #79 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 04:33:19 EDT --- (In reply to comment #78) I am still unable to actually see it my package list. Do you think a mirror would take this long to pick up the update? This package has not been pushed to testing repository, now waiting for signing by rel-eng team. You can check the current status on: https://admin.fedoraproject.org/updates/scala-2.7.2-0.2.RC1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464441] Review Request: HamFax - An application for sending and receiving facsimiles in amateur radio.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464441 Randall Berry [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Randall Berry [EMAIL PROTECTED] 2008-10-15 11:42:57 EDT --- New Package CVS Request === Package Name: HamFax Short Description: An application for sending and receiving facsimiles in amateur radio. Owners: dp67 Branches: F-9, F-10 InitialCC: dp67 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457517 --- Comment #16 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-15 05:59:32 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462818] Review Request: perl-Net-SMTP-SSL - SSL support for Net::SMTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462818 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-extra-fonts - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Comment #39 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 13:40:46 EDT --- un-extra-fonts-1.0.2-0.7.080608.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/un-extra-fonts-1.0.2-0.7.080608.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464621] Review Request: etherboot - roms needed for pxe boot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464621 Tom spot Callaway [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ --- Comment #7 from Tom spot Callaway [EMAIL PROTECTED] 2008-10-15 14:25:35 EDT --- Apologies on the delay here, this one totally fell off my radar. This package is now approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459675] Review Request: python-sybase - new package request
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459675 --- Comment #8 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-15 14:16:49 EDT --- Well, for -4: * installed files - Well, currently * sybasect.so * Sybase.py are not installed, which is apparently wrong (is this rpm really working for you?) As far as I checked this code, replacing the line python setup.py install by python setup.py install --root $RPM_BUILD_ROOT correctly installs these files. Also with this change the following rm $PYTHONPATH/site.* line is not needed. * General rpmlint issue python-sybase.i386: W: spurious-executable-perm /usr/share/doc/python-sybase-0.39/doc/pstumble python-sybase.i386: E: version-control-internal-file /usr/share/doc/python-sybase-0.39/doc/.cvsignore - Usually all files installed as %doc must have 0644 permission (and should not have executable permission) - .cvsignore file is not needed. Also I am waiting for your another review request or your pre-review of other person's review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455953] Review Request: rakarrack - Audio effects processing rack for guitar
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455953
--- Comment #14 from David Timms [EMAIL PROTECTED] 2008-10-15 09:35:54 EDT
---
(In reply to comment #11)
* rakarrack.desktop - %{name}.desktop
I looked at it and thought, maybe I should assign a variable to store the
complete path to .desktop in. Do people normally do things like that ?
Meanwhile I changed to point the spelt out path using %{name}
? %{name} is a basic rack of effects for guitar... - Rakarrack is a basic
rack of effects for guitar...
Overzealous search and replace. Fixed.
* This line needs to be in the %prep section:
%configure --docdir=%{_docdir}/%{name}-%{version}
--htmldir=%{_docdir}/%{name}-%{version}
I'm learning more about make configure and so on, thanks for these pointers.
* These lines need to be in the %prep section too:
%{__sed} -i 's/Icon=icono_rakarrack_128x128/Icon=rakarrack/'
%{buildroot}%{_datadir}/applications/rakarrack.desktop
%{__sed} -i 's/Guitar Effects Processor/Real-time audio effects processing
rack for guitar/' %{buildroot}%{_datadir}/applications/rakarrack.desktop
echo GenericName=Digital audio effects processor
%{buildroot}%{_datadir}/applications/rakarrack.desktop
echo Version=1.0
%{buildroot}%{_datadir}/applications/rakarrack.desktop
Moved.
You may need to change the %{buildroot}%{_datadir}/applications/ to data/
Correct, and done.
Basically, the %build section is for building/compiling, %install section is
to install the software into %{buildroot}. Everything else that can be done
before coming to these sections must be done in %prep.
First I've heard of it, but makes complete sense, as long as the build doesn't
build the icons / desktop files during make etc on the fly.
* %doc AUTHORS README
%{_datadir}/doc/%{name}/COPYING
%{_datadir}/doc/%{name}/html
This has problems. Now there are two document directories created:
/usr/share/doc/rakarrack /usr/share/doc/rakarrack-0.2.0
You only need one document directory. COPYING and html needs to go into %doc
(which is /usr/share/doc/rakarrack-0.2.0).
What you have to do is to make the program point onto the correct document
directory when you click on the Help-contents button. You may need to hack
Thanks for the sed hack.
In the end I still had to manually move the files to the doc-versioned dir so
that rpm and the app finds these things as expected.
It seems that this is an issue with some part of the source, ie the passed
--docdir and --htmldir are not properly used during configure, make and
install.
I am not sure what causes the html+COPYING files to end up in a non-versioned
doc dir, otherwise I would send a patch upstream.
So you decided to not add a new category? I'd say that would be convenient for
people dealing with audio software. :)
I wanted to, and a response from Matthias on f-packaging suggests it is OK, as
long as they are in addition to the standard categories, and prepended with X-.
Done.
Updated spec: http://members.iinet.net.au/~timmsy/rakarrack/rakarrack.spec
New .src.rpm:
http://members.iinet.net.au/~timmsy/rakarrack/rakarrack-0.2.0-4.fc9.src.rpm
- move non-install commands to setup
- fix configure .ini so that standard help path will be used
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 David Lutterkort [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ --- Comment #5 from David Lutterkort [EMAIL PROTECTED] 2008-10-15 15:21:23 EDT --- Looks good now APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458254] Review Request: fedora-package-config-zypper - Repository configuration for zypper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458254 --- Comment #1 from Debarshi Ray [EMAIL PROTECTED] 2008-10-15 15:37:48 EDT --- The Spec URL is not working. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447740] Review Request: zypper - easy to use command line package manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447740 Debarshi Ray [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449595] Review Request: gnome-applet-grandr - GNOME panel applet for XrandR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=449595 --- Comment #4 from Debarshi Ray [EMAIL PROTECTED] 2008-10-15 15:45:27 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462251] Review Request: PyMOL - python molecular graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462251 --- Comment #26 from Jussi Lehtola [EMAIL PROTECTED] 2008-10-15 15:43:19 EDT --- (In reply to comment #25) pymol-1.1-20081015svn3468.CR2.tar.gz (version 1.1 candidate release 2, svn rev 3468) be OK for this package? Actually, shouldn't it be pymol-1.1-5.3419svn ? Or, if this is more a prerelease of 1.2 than a release of the 1.1 series, then pymol-1.2-0.1.3419svn . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463233] Review Request: Web App for Appliance Management
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463233
David Lutterkort [EMAIL PROTECTED] changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #2 from David Lutterkort [EMAIL PROTECTED] 2008-10-15 15:49:34
EDT ---
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - License files are installed as %doc
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - BuildRoot value (one of the recommended values)
OK - PreReq not used
OK - Source md5sum matches upstream
FIX - No hardcoded pathnames
mentions /etc/pam.d, use %_sysconfdir
OK - Package owns all the files it installs
OK - 'Requires' create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly
OK - Macro usage is consistent
FIX - rpmlint is silent
NIT - lots of tabs lead to goofy indentation; remove tabs
I get the following from rpmlint:
ace-console-wui.noarch: E: zero-length
/usr/share/ace/ace-console-wui/db/development.sqlite3
ace-console-wui.noarch: W: symlink-should-be-relative
/usr/share/ace/ace-console-wui/config/environments/production.rb
/etc/ace-console-wui/production.rb
ace-console-wui.noarch: W: symlink-should-be-relative
/usr/share/ace/ace-console-wui/config/environments/test.rb
/etc/ace-console-wui/test.rb
ace-console-wui.noarch: W: symlink-should-be-relative
/usr/share/ace/ace-console-wui/config/database.yml
/etc/ace-console-wui/database.yml
ace-console-wui.noarch: W: symlink-should-be-relative
/usr/share/ace/ace-console-wui/config/environments/development.rb
/etc/ace-console-wui/development.rb
ace-console-wui.noarch: W: dangling-symlink /usr/share/ace/ace-console-wui/tmp
/var/lib/%{inst_name}/tmp
ace-console-wui.noarch: W: symlink-should-be-relative
/usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp
ace-console-wui.noarch: E: incoherent-subsys /etc/rc.d/init.d/ace-console-wui
ace-console-wui}
Either fix them or explain why they are ok to keep.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454997] Review Request: ircii - Popular Unix Irc client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454997 Debarshi Ray [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #4 from Debarshi Ray [EMAIL PROTECTED] 2008-10-15 16:07:30 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438588] Review Request: zfstream - C++ iostream like access to compressed files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=438588 --- Comment #6 from Debarshi Ray [EMAIL PROTECTED] 2008-10-15 16:15:15 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431154] Review Request: IMDbPY - Retrieve and manage the data of the IMDb movie database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=431154 Debarshi Ray [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #6 from Debarshi Ray [EMAIL PROTECTED] 2008-10-15 16:14:10 EDT --- I think this review is dead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462818] Review Request: perl-Net-SMTP-SSL - SSL support for Net::SMTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462818 --- Comment #14 from Fedora Update System [EMAIL PROTECTED] 2008-10-15 16:18:09 EDT --- perl-Net-SMTP-SSL-1.01-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Net-SMTP-SSL-1.01-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462818] Review Request: perl-Net-SMTP-SSL - SSL support for Net::SMTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462818 --- Comment #15 from Dan Nicholson [EMAIL PROTECTED] 2008-10-15 16:20:31 EDT --- Ah, too bad about the F-10 branch. I thought the branching had already happened with the F-10 beta, but I should have looked more closely. Anyway, I've submitted builds for F-9, F-10 and F-11. https://koji.fedoraproject.org/koji/buildinfo?buildID=66466 https://koji.fedoraproject.org/koji/buildinfo?buildID=66463 https://koji.fedoraproject.org/koji/buildinfo?buildID=66462 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
