[Bug 450527] Review Request: libkni - C++ library for the Katana robot arm

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450527





--- Comment #7 from Kushal Das [EMAIL PROTECTED]  2008-10-18 03:55:38 EDT ---
Automated result from review-o-matic

http://koji.fedoraproject.org/koji/taskinfo?taskID=887113

0 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 450527] Review Request: libkni - C++ library for the Katana robot arm

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450527


Kushal Das [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #8 from Kushal Das [EMAIL PROTECTED]  2008-10-18 04:09:41 EDT ---
Above comment came due to a bug in review-o-matic, we are testing it in the
intial stage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 450527] Review Request: libkni - C++ library for the Katana robot arm

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450527





--- Comment #9 from Kushal Das [EMAIL PROTECTED]  2008-10-18 04:11:25 EDT ---
Automated result from review-o-matic

http://koji.fedoraproject.org/koji/taskinfo?taskID=887113

libkni-devel.i386: W: no-documentation
libkni-devel.ppc64: W: no-documentation
libkni-devel.ppc: W: no-documentation
libkni-devel.x86_64: W: no-documentation
libkni-doc.i386: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/Timer_8h__incl.map
libkni-doc.i386: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/MathHelperFunctions_8h__incl.map
libkni-doc.ppc64: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/Timer_8h__incl.map
libkni-doc.ppc64: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/MathHelperFunctions_8h__incl.map
libkni-doc.ppc: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/Timer_8h__incl.map
libkni-doc.ppc: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/MathHelperFunctions_8h__incl.map
libkni-doc.x86_64: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/Timer_8h__incl.map
libkni-doc.x86_64: E: zero-length
/usr/share/doc/libkni-docs-3.9.2/html/MathHelperFunctions_8h__incl.map
libkni-examples.i386: W: no-documentation
libkni-examples.ppc64: W: no-documentation
libkni-examples.ppc: W: no-documentation
libkni-examples.x86_64: W: no-documentation
libkni-static.i386: W: no-documentation
libkni-static.ppc64: W: no-documentation
libkni-static.ppc: W: no-documentation
libkni-static.x86_64: W: no-documentation
26 packages and 1 specfiles checked; 8 errors, 12 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463123] Review Request: gnomint - Graphical x509 Certification Authority management tool

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463123


Adam Huffman [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|needinfo?([EMAIL PROTECTED] |
   |m)  |




--- Comment #14 from Adam Huffman [EMAIL PROTECTED]  2008-10-18 06:12:45 EDT 
---
I've built this package for F-9 and F-10 and it seems to be running acceptably
on both.  What is the procedure now?

Does the package need to be imported into the most recent release before the
review is considered closed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=441378


Bug 441378 depends on bug 465710, which changed state.

Bug 465710 Summary: Review Request: perl-qooxdoo-compat - Perl backend for 
Qooxdoo
https://bugzilla.redhat.com/show_bug.cgi?id=465710

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465710


Terje Røsten [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #6 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 07:03:48 EDT 
---
Things is in shape again, imported and built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466024] Review Request: teamgit - Visual tool for Git

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466024


Terje Røsten [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #7 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 07:43:19 EDT 
---
Imported and built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 465851] Review Request: logstalgia - Web server access log visualizer

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465851





--- Comment #5 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 08:13:52 EDT 
---
- Upstream patch refs
- Fix license

spec: http://terjeros.fedorapeople.org/logstalgia/logstalgia.spec
srpm:
http://koji.fedoraproject.org/koji/getfile?taskID=887396name=logstalgia-0.9.1-2.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=887395

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=441378





--- Comment #27 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 07:15:24 EDT 
---
One more update to celebrate that ¤465710 is closed.

- fix README.fedora

spec: http://terjeros.fedorapeople.org/smokeping/smokeping.spec
srpm:
http://koji.fedoraproject.org/koji/getfile?taskID=887265name=smokeping-2.4.2-6.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=887263

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449869] Review Request: tasque - A simple task management app

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=449869





--- Comment #22 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 10:44:16 EDT 
---
I will close this bug as NOTABUG if no response is received from
the reporter within ONE WEEK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451189] Review Request: rancid - Really Awesome New Cisco confIg Differ

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451189


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||needinfo?([EMAIL PROTECTED]
   ||org)




--- Comment #18 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 10:51:58 EDT 
---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463123] Review Request: gnomint - Graphical x509 Certification Authority management tool

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463123





--- Comment #15 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 10:57:37 EDT 
---
For F-9 package please submit a request to push the rebuilt packages
to repositories on bodhi:
https://admin.fedoraproject.org/updates/

Then you can close this bug as NEXTRELEASE.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462251] Review Request: PyMOL - python molecular graphics

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #32 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 12:02:58 EDT 
---
For -7:

(In reply to comment #31)
 (In reply to comment #30)
  * Python module dependency
- Would you check python module dependency again?
  For example pmg_tk/startup/apbs_tools.py says
  so this script requires tkinter (note: tkinter
  requires tk and tcl)
 Right, but python-pmw pulls tkinter in already.

  - Ah, okay. Thanks.

  And another example is that pmg_wx/__init__.py,
  This scripts requires wxPython.
  However these dependencies may be optional and
  I am not sure what python modules pymol requires
  _at least_.
 wxPython can be used as an alternative to tcl/tk, but is optional.  I guess in
 which case the pmg_wx module should be removed?
  - No need to remove. However it is also a good idea to create a subpackage
(like -wxpython), then split wxPython related files to that subpackage.

  * optflags
- build.log still says that compiler options -ffast-math -funroll-loops 
  -O3
  are used:
 doh!  Fixed.
  - Well, about how to apply a patch in the spec file see
the explanation
http://docs.fedoraproject.org/drafts/rpm-guide-en/ch09s04.html
and the example:
http://cvs.fedoraproject.org/viewvc/rpms/pcmanfm/devel/pcmanfm.spec?view=co

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459979





--- Comment #17 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 12:25:56 EDT 
---
To Nicolas:
If you have some suggestion and have your own srpm for this package,
would you post it somewhere where we can download it anytime?
(don't use koji site for the place to put your srpm:
 it is deleted within one week or so).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454980] Review Request: axel - Download accelerator, wget replacement

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454980


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||needinfo?([EMAIL PROTECTED])




--- Comment #18 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 12:35:07 EDT 
---
2.0 seems released. Pavel, would you check if the issue
reported by Michael is resolved?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 450164] Review Request: ace-tao - The ADAPTIVE Communication Environment (ACE) and The ACE ORB (TAO)

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450164


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||needinfo?([EMAIL PROTECTED]
   ||m)




--- Comment #17 from Mamoru Tasaka [EMAIL PROTECTED]  2008-10-18 12:36:02 EDT 
---
Would someone update the status of this bug?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461912


Sergio Pascual [EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466829] Review Request: openalchemist - reflexion game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466829


Alexey Torkhov [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Alexey Torkhov [EMAIL PROTECTED]  2008-10-18 13:08:30 EDT 
---
REVIEW:

+ rpmlint output is ignorable:

openalchemist.i386: W: devel-file-in-non-devel-package
/usr/bin/openalchemist-config

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license
(GPLv2+ and CC-BY-SA).
+ File, containing the text of the licenses for the package is included in
%doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package must matches the upstream source, as
provided in the spec URL.

3107b699d63d5ae7cbf65ddc9872c49a  openalchemist-0.3-src.tar.gz
3107b699d63d5ae7cbf65ddc9872c49a  openalchemist-0.3-src.tar.gz.orig

+ The package successfully compiles and builds into binary rpms on at least
one supported architecture (x86).
+ All build dependencies are listed in BuildRequires.
+ No need to deal with locales.
+ Does not contain shared libraries.
+ The package does not designed to be relocatable.
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros, as described in the macros section of
Packaging Guidelines.
+ The package contains code, or permissable content.
+ Does not contain large documentation files.
+ Includes only doc files in $doc.
+ No headers.
+ No static libraries.
+ The package does not contain pkgconfig(.pc) files.
+ The package does not contain library files with a suffix (e.g.
libfoo.so.1.1).
+ No devel packages.
+ The package does not contain any .la libtool archives.
+ Includes .desktop file. Properly installed with desktop-file-install.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in the package are valid UTF-8.


This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462446] Review Request: ttf2pt1 - TrueType to Adobe Type 1 font converter

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462446





--- Comment #15 from Göran Uddeborg [EMAIL PROTECTED]  2008-10-18 13:20:26 
EDT ---
(In reply to comment #14)
 My guess is that the 2 calls of
 scripts/html2man . . FONTS.html
 trigger a logical race condition.

I haven't been hit by this myself.  But when I look at it, I see it obviously
could happen.  It would probably be possible to explain to make, using pattern
rules or so, that a single command creates both manual pages.  But given the
small size of this package it's not worth the trouble.  I'll remove
%{_smp_mflags}.

 This is APPROVED if you remove %{_smp_mflags},

Sounds good.  I'll continue with the next step, to get to know koji.  (After
the F10 translation deadline on Tuesday.)

 I will approve you as packager.

Are you saying you will (and have the right to) sponsor me in the terms of
https://fedoraproject.org/wiki/PackageMaintainers/Join  Or is that yet another
step?

 ... I would happily have given you this level of trust
 but being more on the safe side is good, so for now you'll be only
 packager

That's certainly perfectly fine with me!  I AM learning.  (Besides, I've been
sysadming enough in my days to know that it could at times be advantageous NOT
to have privileges. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466795] Review Request: boswars-addons - addon maps for Bos Wars

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466795


Alexey Torkhov [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #3 from Alexey Torkhov [EMAIL PROTECTED]  2008-10-18 13:28:01 EDT 
---
New Package CVS Request
===
Package Name: boswars-addons
Short Description: Addon maps for Bos Wars real-time strategy game
Owners: atorkhov
Branches: F-9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462446] Review Request: ttf2pt1 - TrueType to Adobe Type 1 font converter

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462446





--- Comment #16 from Patrice Dumas [EMAIL PROTECTED]  2008-10-18 13:34:31 EDT 
---
(In reply to comment #15)

  I will approve you as packager.
 
 Are you saying you will (and have the right to) sponsor me in the terms of
 https://fedoraproject.org/wiki/PackageMaintainers/Join  Or is that yet another
 step?

Indeed I am a sponsor and will sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461912] Review Request: puzzles - A collection of one-player puzzle games

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461912





--- Comment #4 from Sergio Pascual [EMAIL PROTECTED]  2008-10-18 13:42:24 EDT 
---
I have added the dependence in desktop-file-utils to build the package. 

   * In Source0 you can use the %{name} macro instead of puzzles if you want
   * BuildRequires: sed is in the exception list, so it can be safely removed.
Perl it isn't but is pulled anyway. You can remove it also or leave it to be in
the safe side. You have to add desktop-file-utils too.
   * Source doesn't match upstream source (there is a new version upstream)
   * In description there's a typo: this is a collection - This is a colection
   * In %setup, you can run sed in place with 
 sed -e s/CFLAGS = .*-g/CFLAGS = %{optflags}/ -i Makefile
   * The naming of the binaries seems problematic. For example, there is a
blackbox package that provides /usr/bin/blackbox already in Fedora. Other
puzzles have very generic names: cube, guess, map, mines... I suggest you to
rename all the puzzles, something like puzzle_name or puzzle-name
   * You are putting the desktop files in a directory inside
/usr/share/applications. I think is clearer to put them all in the main
directory and use a prefix if necessary (the different openoffice applications
follow this approach)
   * The license text must be included in %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454867] Review Request: brickshooter - A small puzzle game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454867





--- Comment #9 from Stefan Posdzich [EMAIL PROTECTED]  2008-10-18 13:55:17 
EDT ---
Fixed most of the problems and would like to become some feedback...

Spec: http://cheekyboinc.spielen-unter-linux.de/kcirbshooter.spec
SRPM:
http://cheekyboinc.spielen-unter-linux.de/kcirbshooter-0.04-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467507] Review Request: Rufscript-fonts - Rufscripts is a decorative handwriting based font

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467507





--- Comment #1 from Kushal Das [EMAIL PROTECTED]  2008-10-18 14:02:52 EDT ---
Automated result from review-o-matic

http://koji.fedoraproject.org/koji/taskinfo?taskID=887703

rufscript-fonts.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437192] Review Request: simdock - Fast and customizable dockbar

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192





--- Comment #6 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 14:30:38 EDT 
---
Jussi, do you want to continue the review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463217] Review Request: gnuplot-py - Python interface to Gnuplot

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463217





--- Comment #8 from Sergio Pascual [EMAIL PROTECTED]  2008-10-18 15:09:02 EDT 
---


(In reply to comment #7)
 Based on upstream's response, I think removing demo.py and test.py from
 %{buildroot} is the best thing to do.  E.g.:
 

That's what I hav done. Additionally I have included html documentation

Spec URL: http://sergiopr.fedorapeople.org/gnuplot-py.spec
SRPM URL: http://sergiopr.fedorapeople.org/gnuplot-py-1.8-4.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 254059] Review Request: e16-keyedit - GUI for editing keybindings for Enlightenment, DR16

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=254059





--- Comment #3 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 16:02:02 EDT 
---
All e16 packages are named e16-*, however no big issue to rename this one
to e16keyedit.

Updated package:
- Add desktop file

spec: http://terjeros.fedorapeople.org/e16/e16-keyedit.spec
srpm:
http://koji.fedoraproject.org/koji/getfile?taskID=887831name=e16-keyedit-0.5-3.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=887830

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437192] Review Request: simdock - Fast and customizable dockbar

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192


Jussi Lehtola [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #7 from Jussi Lehtola [EMAIL PROTECTED]  2008-10-18 16:20:10 EDT 
---
Sure, now that I got packager status.

SHOULD: Now the buildrequires section is IMHO not very clean. Please break the
BR one per line in alphabetized order. But you can do this when you import the
package.

The only thing missing in the preliminary review was the desktop file
installation and you've fixed that, the package is ACCEPTED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437192] Review Request: simdock - Fast and customizable dockbar

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192





--- Comment #8 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 16:28:15 EDT 
---

Please set correct Status and Assigned To, do this before you start the review.

I will put br's in alphabetized order, however on a single line.

Where is the one br per line policy coming from?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437192] Review Request: simdock - Fast and customizable dockbar

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192


Jussi Lehtola [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437192] Review Request: simdock - Fast and customizable dockbar

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192





--- Comment #9 from Jussi Lehtola [EMAIL PROTECTED]  2008-10-18 16:43:00 EDT 
---
(In reply to comment #8)
 Please set correct Status and Assigned To, do this before you start the 
 review.

Thanks for the tip :)

 I will put br's in alphabetized order, however on a single line.
 
 Where is the one br per line policy coming from?

I don't think it's a policy per se; my sponsor (Dominik) told me about it. And
he is right: even though you have to spend a minute or two typing the BRs in
this way, the end result is a lot cleaner to look at. You can see on one glance
what kind of software the package requires.

When you have many requires per line, you have to spend more time looking
around; when you have everything nicely in a column the list is much faster to
look through.

Since your other packages also have the same kind of BRs and they have passed
their reviews without problems, I won't make a fuss out of this. Decide for
yourself: which of these is nicest to read?

http://cvs.fedoraproject.org/viewvc/rpms/lynx/F-9/lynx.spec?revision=1.55view=markup
http://cvs.fedoraproject.org/viewvc/rpms/firefox/F-9/firefox.spec?revision=1.304view=markup
http://cvs.fedoraproject.org/viewvc/rpms/evolution/F-8/evolution.spec?revision=1.313view=markup

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457925] Review Request: biniax - An unique arcade logic game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457925


Robert Scheck [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   ||e




--- Comment #3 from Robert Scheck [EMAIL PROTECTED]  2008-10-18 16:40:58 EDT 
---
My english is maybe worse, but I would say A unique because the u is 
pronounced as j so just a not an, right? Sorry... ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457925] Review Request: biniax - An unique arcade logic game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457925





--- Comment #5 from Robert Scheck [EMAIL PROTECTED]  2008-10-18 16:50:06 EDT 
---
Created an attachment (id=320769)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=320769)
biniax-1.2-optflags.patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457925] Review Request: biniax - An unique arcade logic game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457925


Christopher Stone [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #4 from Christopher Stone [EMAIL PROTECTED]  2008-10-18 16:49:58 
EDT ---
http://www.englishonline.org.cn/en/learners/vocabulary-grammar/grammar-questions/a-or-an

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 450164] Review Request: ace-tao - The ADAPTIVE Communication Environment (ACE) and The ACE ORB (TAO)

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450164


Ken Sedgwick [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|needinfo?([EMAIL PROTECTED] |
   |m)  |




--- Comment #18 from Ken Sedgwick [EMAIL PROTECTED]  2008-10-18 16:52:34 EDT 
---
Here is the new version:

Spec URL: http://dist.bonsai.com/ken/ace_tao_rpm/SRC/5.6.6-1/ace-tao.spec
SRPM URL:
http://dist.bonsai.com/ken/ace_tao_rpm/SRC/5.6.6-1/ace-tao-5.6.6-1.fc9.src.rpm
Description: 
The ADAPTIVE Communication Environment (ACE) is a freely available,
open-source object-oriented (OO) framework that implements many core
patterns for concurrent communication software. ACE provides a rich
set of reusable C++ wrapper facades and framework components that
perform common communication software tasks across a range of OS
platforms. The communication software tasks provided by ACE include
event demultiplexing and event handler dispatching, signal handling,
service initialization, interprocess communication, shared memory
management, message routing, dynamic (re)configuration of distributed
services, concurrent execution and synchronization.

TAO is a real-time implementation of CORBA built using the framework
components and patterns provided by ACE. TAO contains the network
interface, OS, communication protocol, and CORBA middleware components
and features. TAO is based on the standard OMG CORBA reference model,
with the enhancements designed to overcome the shortcomings of
conventional ORBs for high-performance and real-time applications.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437192] Review Request: simdock - Fast and customizable dockbar

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192


Terje Røsten [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #10 from Terje Røsten [EMAIL PROTECTED]  2008-10-18 17:01:55 EDT 
---
I see the point, something to consider.

Thanks for the review!


New Package CVS Request
===
Package Name: simdock
Short Description: Fast and customizable dockbar
Owners: terjeros
Branches: F-9
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457925] Review Request: biniax - An unique arcade logic game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457925





--- Comment #6 from Stefan Posdzich [EMAIL PROTECTED]  2008-10-18 17:31:04 
EDT ---
Fixed Version

Spec: http://cheekyboinc.spielen-unter-linux.de/biniax.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/biniax-1.2-2.fc10.src.rpm

To your last point:

I cant reproduce that on Fedora 8 (x86), Fedora 9 (ppc) and Rawhide (x86).
Biniax exit without problems.

Thanks to Robert for the patch!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463123] Review Request: gnomint - Graphical x509 Certification Authority management tool

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463123





--- Comment #16 from Fedora Update System [EMAIL PROTECTED]  2008-10-18 
18:50:52 EDT ---
gnomint-0.5.4-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/gnomint-0.5.4-2.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462251] Review Request: PyMOL - python molecular graphics

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #33 from Tim Fenn [EMAIL PROTECTED]  2008-10-18 19:31:33 EDT ---
(In reply to comment #32)
 For -7:
 
 (In reply to comment #31)
  (In reply to comment #30)
   And another example is that pmg_wx/__init__.py,
   This scripts requires wxPython.
   However these dependencies may be optional and
   I am not sure what python modules pymol requires
   _at least_.
  wxPython can be used as an alternative to tcl/tk, but is optional.  I guess 
  in
  which case the pmg_wx module should be removed?
   - No need to remove. However it is also a good idea to create a subpackage
 (like -wxpython), then split wxPython related files to that subpackage.
 

Good idea - done in -8.

   * optflags
 - build.log still says that compiler options -ffast-math 
   -funroll-loops -O3
   are used:
  doh!  Fixed.
   - Well, about how to apply a patch in the spec file see
 the explanation
 http://docs.fedoraproject.org/drafts/rpm-guide-en/ch09s04.html
 and the example:
 
 http://cvs.fedoraproject.org/viewvc/rpms/pcmanfm/devel/pcmanfm.spec?view=co

Ah, thanks.  Fixed.

spec url: http://www.stanford.edu/~fenn/packs/pymol.spec
srpm url:
http://www.stanford.edu/~fenn/packs/pymol-1.1-8.20081015svn3468.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466829] Review Request: openalchemist - reflexion game

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466829


Xavier Bachelot [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Xavier Bachelot [EMAIL PROTECTED]  2008-10-18 20:03:25 
EDT ---
Thanks for the review Alexey.

New Package CVS Request
===
Package Name: openalchemist
Short Description: Puzzle game
Owners: xavierb
Branches: F-8 F-9 EL-4 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464430] Review Request: ltsp-server-livesetupdocs - Doc describing how to enable LTSP on Fedora Live LTSP.

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464430





--- Comment #10 from Peter Scheie [EMAIL PROTECTED]  2008-10-18 20:43:55 EDT 
---
This package is only used on the K12Linux Live image and only exists to make
LTSP easier to get working.  So, while it might generically be about binding
the virtual bridge to an interface, shifting the focus/name to that would only
confuse the very people for whom it is intended, which is new users of
K12Linux.

(BTW, is it okay to address multiple comments in one message, or should I
create a separate comment for each point raised?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457035] Review Request: libproxy - A library handling all the details of proxy configuration

2008-10-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457035


Nathaniel McCallum [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #7 from Nathaniel McCallum [EMAIL PROTECTED]  2008-10-18 23:35:09 
EDT ---
Hi, I'm one of the authors of libproxy.  I'd like to suggest that my preferred
method of packaging libproxy is *not* to create separate binary packages for
each plugin.  I know this flies in the face of conventional wisdom.  However,
libproxy is designed to always do the best with what is given.  If a certain
dependency is not met for a plugin, the plugin will simply fail to load.  It
will be far more confusing for the user to have all these plugin packages, then
for libproxy simply to work for them.

What outstanding issues remain for libproxy to be in Fedora?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review