[Bug 451582] Review Request: kvirc - themeable qt based irc client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451582 --- Comment #10 from Alexey Torkhov atork...@gmail.com 2009-03-22 03:40:32 EDT --- Steven, you perhaps should collaborate with nucleo if you wish to continue to work on this package. Otherwise, this ticket should be closed and new opened. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489728] Review Request: kcheckers - Checkers board game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489728 --- Comment #3 from Alexey Torkhov atork...@gmail.com 2009-03-22 03:59:21 EDT --- Spec URL: http://atorkhov.fedorapeople.org/kcheckers.spec SRPM URL: http://atorkhov.fedorapeople.org/kcheckers-0.8.1-3.fc10.src.rpm * Sat Mar 21 2009 Alexey Torkhov atork...@gmail.com - 0.8.1-3 - Install icon to hicolor theme - Use qt-devel build requires instead of qt4-devel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 Mattias Ellert mattias.ell...@fysast.uu.se changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mattias.ell...@fysast.uu.se Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225945] Merge Review: jfsutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225945 --- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2009-03-22 05:02:21 EDT --- (In reply to comment #5) I've done most of this locally now. Still need to look at the weird debuginfo stuff. The debuginfo stuff should be trivial to fix, just remove the executable bits from the source code files and headers in the setup phase. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490723
--- Comment #5 from Pierre-YvesChibon pin...@pingoured.fr 2009-03-22
06:05:24 EDT ---
! The package license corresponds to the license as mentioned in the
DESCRIPTION file and in the website, however several source files
contain the statement:
* This file is copyright 2002 Jim Kent, but license is hereby
* granted for all use - public, private or commercial. */
which is not the same as Artistic licence 2.0. Needs some
consultation with upstream.
I will ask upstream for clarification
! Specfile is written in legible English and uses macro consitently,
however:
The Source and URL fields uses the macro %{BioC} with is not defined
anywhere. The urls point to the right location if this macro is
assumed to be an empty string, so techncally they are correct, but
it is a source of confusion. Suggestion - remove the macros.
The macro is defined (line 2 of the file), however the %define should be
changed to %global according to the newly approved guidelines.
The comment that says #i368 arch should probaly read something
like #architecture dependent package, because that I think is what
you really mean.
That comment is generated by R2spec, it can be changed/ignored/removed
(I will change R2spec to this)
! Package compiles, but there are warnings that should be fixed:
IntervalTree.c:48: warning: missing braces around initializer
memalloc.c:293: warning: format '%d' expects type 'int', but argument 2 has
type 'size_t'
memalloc.c:293: warning: format '%d' expects type 'int', but argument 3 has
type 'size_t'
The ... may be used uninitialized warnings might be harmless (or
not, ...)
I have no idea if these warnings are harmful or not:
Creating a generic for cbind in package IRanges
(the supplied definition differs from and overrides the implicit generic
in package base: Signatures differ: (...), (deparse.level))
Creating a generic for rbind in package IRanges
(the supplied definition differs from and overrides the implicit generic
in package base: Signatures differ: (...), (deparse.level))
I will point these warning to upstream.
! %check is present and check pass, but
Comparing 'runalltests.Rout' to 'runalltests.Rout.save' ...11,12c11
rbind,
sapply
---
rbind
It test still says OK, but it looks strange.
This is just the output of the test run
! No package owns the package's main directory /usr/lib64/R/library/IRanges
Oups, I will change this
Ideally both main and devel should own the main directory in order
to avoid orphaned directories after package removal, but at least
main must own it.
I do not agree. Since -devel has the main package has a requirement, only the
main need to own the directory.
! Since the -devel package does not include a .pc file it should not
require pkgconfig (or is there some other reason for this?)
Will be fixed
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 --- Comment #4 from Mattias Ellert mattias.ell...@fysast.uu.se 2009-03-22 05:47:38 EDT --- Created an attachment (id=336194) -- (https://bugzilla.redhat.com/attachment.cgi?id=336194) Review result I attach my review. In summary it looks quite good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226557] Merge Review: xfig
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226557
Patrice Dumas pertu...@free.fr changed:
What|Removed |Added
AssignedTo|pertu...@free.fr|nob...@fedoraproject.org
--- Comment #10 from Patrice Dumas pertu...@free.fr 2009-03-22 06:19:44 EDT
---
I don't use fedora anymore so I cannot have the final say, nor do many of the
checks, but it looks good from reading the spec. Only 3 comments,
* some patches could have a comment, namely xfig-3.2.5-color-resources.patch
and xfig-3.2.5-debian.patch, others were rather straightforward, or explained
by corresponding entries in changelog
* I'd prefer xfig-3.2.4-redhat.patch not to be named like that, but rather
along xfig-3.2.4-commands.patch for downstream reuse of spepc and patches
* I's still prefer
Provides: %{name}(executable) = %{version}-%{release}
I am not sure that any of these constitutes a blocker.
I'll remove myself to the assignee, since I cannot really formally do the
review, but from my point of view it is fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226557] Merge Review: xfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226557 Patrice Dumas pertu...@free.fr changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 --- Comment #6 from Pierre-YvesChibon pin...@pingoured.fr 2009-03-22 06:28:27 EDT --- * Sun Mar 22 2009 pingou pingou -AT- pingoured.fr 1.0.14-3 - The main package owns the directory - Remove pkgconfig as R for the devel package - Define becomes global SPEC: http://pingou.fedorapeople.org/RPMs/R-IRanges.spec SRPM: http://pingou.fedorapeople.org/RPMs/R-IRanges-1.0.14-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added CC||st...@silug.org --- Comment #7 from Christoph Wickert fed...@christoph-wickert.de 2009-03-22 07:02:03 EDT --- *** Bug 246348 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246348] Review Request: parrot - Parrot Virtual Machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=246348 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Flag|fedora-review?, | |needinfo?(st...@silug.org) | --- Comment #15 from Christoph Wickert fed...@christoph-wickert.de 2009-03-22 07:02:03 EDT --- Closing due to lack of response. Steven, you are welcome to co-maintain the package together with Gerd once you have more time again. *** This bug has been marked as a duplicate of 486302 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added CC||fed...@christoph-wickert.de --- Comment #8 from Christoph Wickert fed...@christoph-wickert.de 2009-03-22 07:12:58 EDT --- Gerd, please build packages of 1.0.0 so we can review them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478570] Review Request: oflb-riordonfancy-fonts - A stylized font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478570 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added AssignedTo|nicolas.mail...@laposte.net |ivazquez...@gmail.com Flag|fedora-review? |fedora-review+ --- Comment #3 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-03-22 07:32:46 EDT --- Nice and clean package, I don't see enough of them. Thank you for packaging a new font in Fedora! ⚸⚸⚸ APPROVED ⚸⚸⚸ You can now continue from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a (Please take the time to replace your defines with globals someday btw) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490996] Review Request: backup-light - A small backup bash utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490996 --- Comment #6 from Fabian Affolter fab...@bernewireless.net 2009-03-22 07:39:52 EDT --- Changed in svn, the new name will affect with the next release. http://code.google.com/p/backup-light/issues/detail?id=3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 Fabien Georget fabien.geor...@gmail.com changed: What|Removed |Added CC||fabien.geor...@gmail.com --- Comment #9 from Fabien Georget fabien.geor...@gmail.com 2009-03-22 07:46:06 EDT --- I build parrot 1.0.0 from the spec provided in the official tarball before I discovered this topic I modified this spec to remove rpath and to add somes BuildRequires (ctags and openssl-devel) Spec URL : http://www.bde.espci.fr/~george27/parrot.spec Srpm URL : http://www.bde.espci.fr/~george27/parrot-1.0.0-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490996] Review Request: backup-light - A small backup bash utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490996 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-03-22 08:09:18 EDT --- backup-light-0.4-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/backup-light-0.4-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490996] Review Request: backup-light - A small backup bash utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490996 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-03-22 08:09:23 EDT --- backup-light-0.4-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/backup-light-0.4-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478771] Review Request: spring-maps-default - Default maps for Spring
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478771 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-03-22 08:59:57 EDT --- spring-0.78.2.1-9.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478770] Review Request: springlobby - A lobby client for the spring RTS game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478770 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2009-03-22 09:00:03 EDT --- spring-0.78.2.1-9.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478769] Review Request: spring-installer - Installer for the Spring game's maps and mods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478769 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2009-03-22 09:00:09 EDT --- spring-0.78.2.1-9.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478767] Review Request: spring - Realtime strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478767 --- Comment #41 from Fedora Update System upda...@fedoraproject.org 2009-03-22 09:00:15 EDT --- spring-0.78.2.1-9.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Attachment #335928|0 |1 is obsolete|| --- Comment #36 from Michael Schwendt bugs.mich...@gmx.net 2009-03-22 09:47:40 EDT --- Created an attachment (id=336200) -- (https://bugzilla.redhat.com/attachment.cgi?id=336200) spec patch for build fix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 --- Comment #35 from Michael Schwendt bugs.mich...@gmx.net 2009-03-22 09:46:53 EDT --- Created an attachment (id=336199) -- (https://bugzilla.redhat.com/attachment.cgi?id=336199) eclib-20080310.p7-build.patch I've found the problem after a close look. It's a packaging mistake. Parts of the code are miscompiled because the OPTFLAG environment variable is redefined and alters the source tarball's build flags. The NEW_OP_ORDER definition is lost. That miscompiles some source files. The cleaner way would be to patch the src/Makefile and make it accept our $RPM_OPT_FLAGS from the outside. It already accepts $PICFLAG for -fPIC. With this change it is not necessary to move fundamental build flags into the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486757] Review Request: divine-mc - Multi-core model checking system for proving specifications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486757 --- Comment #14 from David A. Wheeler dwhee...@dwheeler.com 2009-03-22 10:44:50 EDT --- Okay, I've tried to respond to all changes from Comment #13 ; the sole exception is that I didn't version Java (it makes Fedora 10 builds fail, and doesn't seem necessary). Comments? First, a discussion of how I handled each comment... First, thanks for coordinating with upstream!! I appreciate that. I've installed all the binaries as you suggested. I had earlier figured that if they weren't getting installed, they were less mature, but I agree that letting users make the decision of what to run is reasonable. I'll go package Promela next, so that it can be removed from divine-mc 2.0. But I don't think Java needs to be versioned; can you help me understand why it must be, before I do that? (I'll use this package as a starting point.) Regarding: please fix the cmake install target, make sure that the Perl dependencies are ok then, see: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides I don't see anything that needs doing. It doesn't use much of perl, and it's not a perl module. I switched to the upstreams tarball URL, and added the link to trac ticket on why it's not currently packaged separately. You said: regarding Java, the BR and R should be versioned, hence please use: BuildRequires: java-devel = 1:1.6.0 ... Requires: java = 1:1.6.0 Versioning Java makes the Fedora 10 build fail, and doesn't seem necessary; 1.5 seems to work just fine. I surrounded the take too long test as suggested. Very nice! I would appreciate if you would submit the review request for Promela before approving this package (the package and review shouldn't be problematic AFAIK). I understand. But can you explain why you think java and java-devel need to be versioned? I did rpmlint on the .src.rpm, .spec, and a binary RPM. The only message is: divine-mc.src:134: W: configure-without-libdir-spec and as discussed earlier, this is a bogus warning. I built this with koji on dist-f10 and dist-f11, builds on all architectures: http://koji.fedoraproject.org/koji/taskinfo?taskID=1252929 0 free 0 open 5 done 0 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1252947 0 free 0 open 5 done 0 failed Here's the latest SRPM: http://www.dwheeler.com/divine-mc-1.3-7.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478767] Review Request: spring - Realtime strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478767 --- Comment #42 from Fedora Update System upda...@fedoraproject.org 2009-03-22 10:49:18 EDT --- spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478769] Review Request: spring-installer - Installer for the Spring game's maps and mods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478769 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2009-03-22 10:49:13 EDT --- spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] New: Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD https://bugzilla.redhat.com/show_bug.cgi?id=491519 Summary: Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fe...@fetzig.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://heffer.fedorapeople.org/review/openttd-opengfx.spec SRPM URL: http://heffer.fedorapeople.org/review/openttd-opengfx-0-0.1.alpha4.2.fc11.src.rpm Description: The ultimate aim of this project is to have a full replacement set of graphics, so that OpenTTD can be distributed freely without the need of the copyrighted graphics from the original game. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added Depends on||491519 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added Blocks||491518 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478771] Review Request: spring-maps-default - Default maps for Spring
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478771 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-03-22 10:49:03 EDT --- spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478770] Review Request: springlobby - A lobby client for the spring RTS game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478770 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2009-03-22 10:49:08 EDT --- spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/spring-0.78.2.1-9.fc10,springlobby-0.0.1.10425-1.fc10,spring-installer-20090316-4.fc10,spring-maps-default-0.1-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] New: Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: openttd - Transport system simulation game https://bugzilla.redhat.com/show_bug.cgi?id=491518 Summary: Review Request: openttd - Transport system simulation game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fe...@fetzig.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://heffer.fedorapeople.org/review/openttd.spec SRPM URL: http://heffer.fedorapeople.org/review/openttd-0.7.0-0.2.rc1.fc11.src.rpm Description: OpenTTD is modeled after a popular transportation business simulation game by Chris Sawyer and enhances the game experience dramatically. Many features were inspired by TTDPatch while others are original. openttd.spec:45: W: rpm-buildroot-usage %build --install-dir=$RPM_BUILD_ROOT \ openttd.spec:34: W: configure-without-libdir-spec is due to the non-standard buildsystem OpenTTD uses -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] New: Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs https://bugzilla.redhat.com/show_bug.cgi?id=491521 Summary: Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bojanpopo...@beotel.rs QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.bojanpopovic.com/testing/hedgewars.spec SRPM URL: http://www.bojanpopovic.com/testing/hedgewars-0.9.9-1.fc10.src.rpm Description: The latest official release of Hegdewars. Based on already existing 0.9.7 spec file. This is my first package and I'm looking for a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491520] New: Review Request: shntool - shntool is a multi-purpose WAVE data processing and reporting utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: shntool - shntool is a multi-purpose WAVE data processing and reporting utility https://bugzilla.redhat.com/show_bug.cgi?id=491520 Summary: Review Request: shntool - shntool is a multi-purpose WAVE data processing and reporting utility Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fe...@fetzig.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://heffer.fedorapeople.org/review/shntool.spec SRPM URL: http://heffer.fedorapeople.org/review/shntool-3.0.8-1.fc11.src.rpm Description: shntool is a multi-purpose WAVE data processing and reporting utility. File formats are abstracted from its core, so it can process any file that contains WAVE data, compressed or not - provided there exists a format module to handle that particular file type. shntool.src: W: summary-not-capitalized shntool is a multi-purpose WAVE data processing and reporting utility shntool.x86_64: W: summary-not-capitalized shntool is a multi-purpose WAVE data processing and reporting utility can be ignored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491521 Bojan Popović bojanpopo...@beotel.rs changed: What|Removed |Added Version|rawhide |10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491521 Bojan Popović bojanpopo...@beotel.rs changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #1 from Felix Kaechele fe...@fetzig.org 2009-03-22 11:08:31 EDT --- Let this block FE-Legal as a precaution to check if this OK trademark-wise. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426753] Review Request: xmonad - A tiling window manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=426753 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name --- Comment #27 from Till Maas opensou...@till.name 2009-03-22 12:10:55 EDT --- The manpage and the example config file (xmonad.hs) from the directory man are not packaged. Also it seems to me that a xmonad.desktop file in /usr/share/xsessions is missing, which allows one to select xmonad as wm in gdm. I used this the following one with an older xmonad release, maybe it works with the current one, too: http://till.fedorapeople.org/files/xmonad.desktop -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486302
Ian Weller ianwel...@gmail.com changed:
What|Removed |Added
CC||ianwel...@gmail.com
--- Comment #10 from Ian Weller ianwel...@gmail.com 2009-03-22 12:46:24 EDT
---
I'm somewhat certain that filename-based Requires and BRs aren't allowed in
Fedora. (BuildRequires: /usr/bin/perldoc, Requires:
%{_libdir}/pkgconfig)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490723 --- Comment #7 from Pierre-YvesChibon pin...@pingoured.fr 2009-03-22 13:20:23 EDT --- I got a reply to the mail I sent: --- We also see some warnings while compiling it: IntervalTree.c:48: warning: missing braces around initializer memalloc.c:293: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' memalloc.c:293: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' These are probably harmless but easy to rectify. Creating a generic for cbind in package IRanges (the supplied definition differs from and overrides the implicit generic in package base: Signatures differ: (...), (deparse.level)) Creating a generic for rbind in package IRanges (the supplied definition differs from and overrides the implicit generic in package base: Signatures differ: (...), (deparse.level)) These are intentional and may be ignored. - Nothing regarding the license yet though -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487973] Review Request: lxmenu-data - Data files for the LXDE menu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487973 --- Comment #3 from Christoph Wickert fed...@christoph-wickert.de 2009-03-22 13:25:12 EDT --- Upstream confirmed that it should be LGPLv2+ like gnome-menus. Fixed license in spec and in RPM. Intltool does not matter as long as we don't build this package for F9. Patch will be in upstream in 0.2. I have patched the menu to use Fedora's default menu structure: http://cwickert.fedorapeople.org/review/lxmenu-data.spec http://cwickert.fedorapeople.org/review/lxmenu-data-0.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 --- Comment #11 from David Fetter da...@fetter.org 2009-03-22 13:33:57 EDT --- Created an attachment (id=336211) -- (https://bugzilla.redhat.com/attachment.cgi?id=336211) Update .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455226 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #18 from Remi Collet fed...@famillecollet.com 2009-03-22 13:35:12 EDT --- I prefer see errors if it is present. Redirection of standard output (what you've done) doesn't suppress output of error ;) but only unuseful information about (un)registration. All MUST (and should) are fixed, so APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484567] Review Request: php-ezc-File - eZ Components File
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484567 Bug 484567 depends on bug 484507, which changed state. Bug 484507 Summary: Review Request: php-channel-ezc - eZ Components https://bugzilla.redhat.com/show_bug.cgi?id=484507 What|Old Value |New Value Resolution||NEXTRELEASE Status|ON_QA |CLOSED Bug 484567 depends on bug 484509, which changed state. Bug 484509 Summary: Review Request: php-ezc-Base - eZ Components Base https://bugzilla.redhat.com/show_bug.cgi?id=484509 What|Old Value |New Value Status|ASSIGNED|ON_QA Resolution||NEXTRELEASE Status|ON_QA |CLOSED --- Comment #1 from Remi Collet fed...@famillecollet.com 2009-03-22 13:46:37 EDT --- According to package.xml, dependencies are : php-common = 5.1.1 Base = 1.4 The src.rpm doesn't seems updated (spec if from Mar 4, srpm from Feb 8) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455226 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.spb.su changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.spb.su 2009-03-22 13:49:45 EDT --- Remi Collet, thank you for review. New Package CVS Request === Package Name: php-pecl-runkit Short Description: PHP Opcode Analyser Owners: Hubbitus Branches: F9 F10 EL5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473037] Review Request: tinycc - Tiny C Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473037 --- Comment #22 from Lubomir Rintel lkund...@v3.sk 2009-03-22 14:12:28 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491530] New: Review Request: letterslaughing-fonts - Decorative/LED sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: letterslaughing-fonts - Decorative/LED sans-serif font https://bugzilla.redhat.com/show_bug.cgi?id=491530 Summary: Review Request: letterslaughing-fonts - Decorative/LED sans-serif font Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: sanjay.an...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://ankursinha.fedorapeople.org/letterslaughing_fonts/letterslaughing-fonts.spec SRPM URL: http://ankursinha.fedorapeople.org/letterslaughing_fonts/letterslaughing-fonts-1.0-1.fc10.src.rpm Description: Letters Laughing is a decorative/LED sans-serif font -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246348] Review Request: parrot - Parrot Virtual Machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=246348 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added Alias|parrot | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491530] Review Request: letterslaughing-fonts - Decorative/LED sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491530 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Platform|All |noarch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added CC||cw...@alumni.drew.edu Alias||parrot -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486302
--- Comment #12 from Christoph Wickert fed...@christoph-wickert.de
2009-03-22 14:42:30 EDT ---
Please don't use
Requires: %{_libdir}/pkgconfig
Instead require pkgconfig which owns this dir, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files
File based deps slow down the dependency resolution process and should only be
used when it makes sense (e. g. two different packages provide %{_bindir}/foo).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486302
--- Comment #13 from Christoph Wickert fed...@christoph-wickert.de
2009-03-22 14:45:43 EDT ---
Note that
%ifarch i386 x86_64
is obsolete, now that we build i586. Use
%ifarch %{ix86} x86_64
instead.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484567] Review Request: php-ezc-File - eZ Components File
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484567 --- Comment #2 from Guillaume Kulakowski llaum...@gmail.com 2009-03-22 14:43:50 EDT --- Correction made -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490849] Review Request: php-ezc-Archive- eZ Components Archive
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490849 --- Comment #1 from Guillaume Kulakowski llaum...@gmail.com 2009-03-22 14:50:16 EDT --- Version 1.3.2-2 with fix in requires SPEC: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-Archive.spec SRPM: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-Archive-1.3.2-2.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-Archive-1.3.2-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491530] Review Request: letterslaughing-fonts - Decorative/LED sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491530 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net Flag||fedora-review?, ||needinfo?(sanjay.an...@gmai ||l.com) --- Comment #1 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-03-22 14:50:12 EDT --- Initial review: 1. MUST: rename the package to chisholm-xxx to be consistent with to be continued font 2. MUST: register the font as fantasy, really, this is not a general-purpose font at all (also please use the same casing as the font files use, I don't know if fontconfig is case sensitive or not best avoid problems) 3. MUST: there is no clear version in the font files, so use the timestamp of the most recent file as version (19970902) 4. SHOULD: ask upstream to add a detached .txt licensing file to its zip (the font itself says all rights reserved, and if the web site ever disappears we won't have any licensing grant trace anywhere) 5. SHOULD: ask usptream to use different family names for the three fonts and not invent weird styles like at their Execution. They'll drive normal software like OpenOffice mad (yes I know this would make it a multifont package which is a bit harder to create but this is the right thing to do) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=456190
--- Comment #44 from Lubomir Rintel lkund...@v3.sk 2009-03-22 15:02:48 EDT
---
Guys, please don't discuss the functional issues here, until the package is in
Fedora. Once there will be a single official build of the package you'll agree
on, then it will start to make sense to solve issues, not before then. It makes
this review report a lot less legible for the reviewer, and it's increasingly
hard to keep track of the packaging issues here. Derek, thank you for the
participation though.
When it comes to the compiler flags, I see them being properly used, since
%configure macro sets them correctly. Probably past use of ./configure instead
of %configure resulted into build w/o proper flags, but it all seems OK to me
now. (Please be sure you understand it though).
Justin, are there any examples of your work that could prove that you
understand packaging well? Some informal reviews? I'll need to see it so that I
can sponsor you.
So here's first crack at the official review (sorry that it took so long):
1.) Source files
Please comment on how did you get these:
VCS checkout? Which revision?
Source: %{name}-%{version}.tgz
Full URL?
Source1:%{name}-freedos-bin.tgz
Original work?
Source2:%{name}.desktop
Isn't etc/dosemu.xpm from the source tarball sufficient?
Source3:%{name}.xpm
2.) FreeDOS image
I don't believe this is formally allowed (shipping binaries), though other
packages do this (say, qemu includes bochs bios image). I'll ask on packaging
list how to deal with this and let you know.
It is also probably illegal (if it's GPL) to distribute this without source
code, so at the very least, please add also the source code package and, as
always, please comment as heavily as you can :)
In case we won't be able to this -- do you know if it's very hard to build
FreeDOS kernel image and cross-build the basic utilities (at least COMMAND.COM)
with the tooling currently in Fedora?
Source1:%{name}-freedos-bin.tgz
3.) Please use make flags.
Please add %{_smp_mflags} after make, unless it breaks built. If it does,
please add a comment instead.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
4.) Legibility
Please try not to cross 75 or 80 column boundary:
chmod 755 $RPM_BUILD_ROOT%{_datadir}/dosemu
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z/doc/exe2bin
That is better written as:
chmod 755 $RPM_BUILD_ROOT%{_datadir}/dosemu \
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z \
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z/doc/exe2bin
5.) Group
RPMLint complains:
dosemu.i586: W: non-standard-group Game/Emulator
Indeed, this is not a standard group. Pick one from /usr/share/doc/rpm*/GROUPS.
I believe the right one is Applications/System. Hint: This is not used for
anything, so does not matter at all. It can even be omitted since Fedora 10.
6.) .desktop entry
Please set the back to Category=System;Emulator from Category=Game;Emulator,
which is the only right value in this case. I believe we've have communicated
this with Andrea via private mail back then.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 --- Comment #14 from David Fetter da...@fetter.org 2009-03-22 15:04:35 EDT --- Per Christoph's comments: Spec: http://fetter.org/~shackle/parrot.spec SRPM: http://fetter.org/~shackle/parrot-1.0.0-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465858] Package Review: afpfs-ng - Apple Filing Protocol client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465858 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Lubomir Rintel lkund...@v3.sk 2009-03-22 15:22:55 EDT --- Thanks for the review Stepan! New Package CVS Request === Package Name: afpfs-ng Short Description: Apple Filing Protocol client Owners: lkundrak jfch Branches: EL-5 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486390] Review Request: simspark - Spark physical simulation system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486390 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-03-22 15:31:30 EDT --- simspark-0.1-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/simspark-0.1-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486390] Review Request: simspark - Spark physical simulation system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486390 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-03-22 15:31:36 EDT --- simspark-0.1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/simspark-0.1-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #45 from Lubomir Rintel lkund...@v3.sk 2009-03-22 15:31:25 EDT --- 7.) Summary Summary:DOS Emulator for linux There's no such thing as linux (with lowercase l). DOSEmu is not specific to Linux either. This would probably be better DOS Emulator. Or something like Environment to run DOS programs in to be more friendly to a casual user. You decide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490562 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-03-22 15:37:08 EDT --- renameutils-0.10.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/renameutils-0.10.0-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490562 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-03-22 15:38:29 EDT --- renameutils-0.10.0-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/renameutils-0.10.0-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476346] Review Request: python-polybori - Framework for Boolean Rings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476346 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Depends on||491537 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486390] Review Request: simspark - Spark physical simulation system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486390 --- Comment #16 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-03-22 15:56:04 EDT --- Can't F-10/9 rcssserver3d be upgraded so as not to get conflict with simspark before simspark is pushed into F-10/9 repositories? Otherwise after simspark is pushed into repositories I am not sure if $ yum -y install rcssserver3d still works. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490580] Review Request: faust - Compiled language for real-time audio signal processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490580 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-03-22 16:30:59 EDT --- faust-0.9.9.4-2.b.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/faust-0.9.9.4-2.b.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486302] Review Request: parrot - Parrot is a virtual machine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486302 --- Comment #15 from Fabien Georget fabien.geor...@gmail.com 2009-03-22 16:49:12 EDT --- Package devel not full. I can't build pynie (http://code.google.com/p/pynie/). The tools repertory have to be installed. I try, but I have still this error : [man...@teatime]~/Téléchargement/pynie-read-only% ./configure Creating Makefile Can't locate Parrot/Configure.pm in @INC (@INC contains: /usr/lib64/parrot/1.0.0/tools/dev/../../lib /usr/lib64/parrot/1.0.0/tools/dev/../lib /usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/5.10.0 /usr/local/lib64/perl5/site_perl/5.10.0/x86_64-linux-thread-multi /usr/local/lib/perl5/site_perl/5.10.0 /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.10.0 /usr/lib/perl5/vendor_perl /usr/local/lib/perl5/site_perl /usr/local/lib64/perl5/site_perl /usr/lib/perl5/site_perl .) at /usr/lib64/parrot/1.0.0/tools/dev/gen_makefile.pl line 12. BEGIN failed--compilation aborted at /usr/lib64/parrot/1.0.0/tools/dev/gen_makefile.pl line 12. You can now use 'gmake' to build Pynie, and 'gmake test' to test it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491545] New: Review Request: pynac - A modified version of GiNaC using Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pynac - A modified version of GiNaC using Python https://bugzilla.redhat.com/show_bug.cgi?id=491545 Summary: Review Request: pynac - A modified version of GiNaC using Python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kon...@tylerc.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/pynac.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/pynac-0.1.3-1.fc10.src.rpm Description: A modified version of GiNaC that replaces the dependency on CLN by Python. Rpmlint output: pynac-devel.x86_64: W: no-documentation pynac-static.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 0 errors, 2 warnings. Which are ignorable. Builds in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1253354 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 --- Comment #12 from Lubomir Rintel lkund...@v3.sk 2009-03-22 17:04:02 EDT --- I've sent a mail upstream myself today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479799] Review Request: ghc-uniplate - Uniform type generic traversals
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479799 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #10 from Conrad Meyer kon...@tylerc.org 2009-03-22 17:53:59 EDT --- Built in rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=1253377 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479800] Review Request: hlint - Provides Haskell Source Code Suggestions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479800 Bug 479800 depends on bug 479799, which changed state. Bug 479799 Summary: Review Request: ghc-uniplate - Uniform type generic traversals https://bugzilla.redhat.com/show_bug.cgi?id=479799 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 --- Comment #37 from Conrad Meyer kon...@tylerc.org 2009-03-22 17:59:48 EDT --- Thank you for both patches; they have been incorporated in: http://konradm.fedorapeople.org/fedora/SPECS/eclib.spec http://konradm.fedorapeople.org/fedora/SRPMS/eclib-20080310-6.p7.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added CC||kon...@tylerc.org --- Comment #1 from Conrad Meyer kon...@tylerc.org 2009-03-22 17:58:39 EDT --- Should this really be a separate package? Seems like a core part of OpenTTD to me (if Fedora is going to distribute the game). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470702] Review Request: L-function - L-function calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470702 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #11 from Conrad Meyer kon...@tylerc.org 2009-03-22 18:00:58 EDT --- Build in rawhide, closing. http://koji.fedoraproject.org/koji/taskinfo?taskID=1253389 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #2 from Felix Kaechele fe...@fetzig.org 2009-03-22 18:08:27 EDT --- I actually never thought about this from that perspective. I started it as a separate package because the opengfx project is separate from openttd development. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #3 from Alexey Torkhov atork...@gmail.com 2009-03-22 18:15:28 EDT --- (In reply to comment #1) Should this really be a separate package? Seems like a core part of OpenTTD to me (if Fedora is going to distribute the game). It is separate project with separate releases and separate developers. Yes, it is essential for OpenTTD, but why they should be bundled together? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #4 from Conrad Meyer kon...@tylerc.org 2009-03-22 18:21:21 EDT --- It was just a thought. I would love to see this included in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491550] New: Review Request: libass - Portable library for SSA/ASS subtitles rendering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libass - Portable library for SSA/ASS subtitles rendering https://bugzilla.redhat.com/show_bug.cgi?id=491550 Summary: Review Request: libass - Portable library for SSA/ASS subtitles rendering Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: martin.sour...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://mso.fedorapeople.org/packages/SPECS/libass.spec SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/libass-0.9.6-1.fc10.src.rpm Description: Libass is a portable library for SSA/ASS subtitles rendering. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added CC||kon...@tylerc.org --- Comment #2 from Conrad Meyer kon...@tylerc.org 2009-03-22 18:42:35 EDT --- Is --with-ccache something relevant for the koji builders? (Should you require ccache then?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491550] Review Request: libass - Portable library for SSA/ASS subtitles rendering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491550 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? --- Comment #1 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2009-03-22 19:17:32 EDT --- Taking review. Quick comment: you don't need BR: glibc-devel. gcc requires it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=456190
--- Comment #46 from Justin Zygmont solarflo...@gmail.com 2009-03-22
19:29:45 EDT ---
(In reply to comment #44)
Guys, please don't discuss the functional issues here, until the package is in
Fedora. Once there will be a single official build of the package you'll agree
on, then it will start to make sense to solve issues, not before then. It
makes
this review report a lot less legible for the reviewer, and it's increasingly
hard to keep track of the packaging issues here. Derek, thank you for the
participation though.
ok, thanks for letting us know.
When it comes to the compiler flags, I see them being properly used, since
%configure macro sets them correctly. Probably past use of ./configure instead
of %configure resulted into build w/o proper flags, but it all seems OK to me
now. (Please be sure you understand it though).
Thats good to know because I didnt see any place where opt_flags was used.
Justin, are there any examples of your work that could prove that you
understand packaging well? Some informal reviews? I'll need to see it so that
I can sponsor you.
ok, I am about to do this, i'll let you know.
So here's first crack at the official review (sorry that it took so long):
1.) Source files
Please comment on how did you get these:
You mean comment where I got it in the spec file?
VCS checkout? Which revision?
Source: %{name}-%{version}.tgz
Full URL?
Source1:%{name}-freedos-bin.tgz
Original work?
Source2:%{name}.desktop
Isn't etc/dosemu.xpm from the source tarball sufficient?
Source3:%{name}.xpm
I think I got that idea from the dosbox spec file, I can change it if
necessary.
2.) FreeDOS image
I don't believe this is formally allowed (shipping binaries), though other
packages do this (say, qemu includes bochs bios image). I'll ask on packaging
list how to deal with this and let you know.
ok, I guess I overlooked it as shipping binaries because it was just a freedos
image. I hope it will be ok.
It is also probably illegal (if it's GPL) to distribute this without source
code, so at the very least, please add also the source code package and, as
always, please comment as heavily as you can :)
ok, I guess the source URL in the comments.
In case we won't be able to this -- do you know if it's very hard to build
FreeDOS kernel image and cross-build the basic utilities (at least
COMMAND.COM)
with the tooling currently in Fedora?
Source1:%{name}-freedos-bin.tgz
hmm, I guess that would be the ideal way, but the freedos kernel image is
trimmed and customized a bit, i'd hate to have to go down that route just for a
replaceable image. At this point I dont know what it takes to build that.
This .tgz file is not something thats available on the freedos site, for the
source code, all they have is a large ISO image.
3.) Please use make flags.
Please add %{_smp_mflags} after make, unless it breaks built. If it does,
please add a comment instead.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
ok thanks. Done.
4.) Legibility
Please try not to cross 75 or 80 column boundary:
chmod 755 $RPM_BUILD_ROOT%{_datadir}/dosemu
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z/doc/exe2bin
That is better written as:
chmod 755 $RPM_BUILD_ROOT%{_datadir}/dosemu \
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z \
$RPM_BUILD_ROOT%{_datadir}/dosemu/drive_z/doc/exe2bin
All done. I just have a URL that is long, should I break that up too?
5.) Group
RPMLint complains:
dosemu.i586: W: non-standard-group Game/Emulator
Indeed, this is not a standard group. Pick one from
/usr/share/doc/rpm*/GROUPS.
I believe the right one is Applications/System. Hint: This is not used for
anything, so does not matter at all. It can even be omitted since Fedora 10.
6.) .desktop entry
Please set the back to Category=System;Emulator from Category=Game;Emulator,
which is the only right value in this case. I believe we've have communicated
this with Andrea via private mail back then.
Yes, thats done. I have also changed linux to Linux :) The summary is
accurate though, dosemu doesn't build on other platforms, there used to be a
port to netbsd but that was a long time ago.
I have uploaded the latest RPM packages and spec file here:
http://jzygmont.fedorapeople.org/dosemu.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473679] Review Request: xfburn - Simple CD/DVD burning tool based on libburnia
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473679 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-03-22 19:29:41 EDT --- xfburn-0.4.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xfburn-0.4.1-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491521 Alex Orlandi nyr...@gmail.com changed: What|Removed |Added CC||nyr...@gmail.com --- Comment #1 from Alex Orlandi nyr...@gmail.com 2009-03-22 19:37:51 EDT --- Hi, this is just a very fast and informal review. - it seems that hedgewars is already and still maintained in Fedora (whilst, in the guildelines, is said you should make sure that it is a new package): update to 0.9.9 upstream is already on cvs for f11 - anyway, there's 1 rpmlint warning: hedgewars.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 81) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491519
--- Comment #5 from Conrad Meyer kon...@tylerc.org 2009-03-22 19:35:30 EDT
---
Requires: openttd
seems wrong (because openttd requires this for graphics). I think maybe a
solution is for this to go in %{_datadir}/%{name}/ and when openttd is
installed and requires this, it can symlink %{_datadir}/openttd/data to this
package (if it's too hard to change where openttd looks).
This is one argument for including opengfx in openttd (opengfx can be installed
into the correct place without a hack, and the two-way requires can be
avoided).
The use of __command macros is unnecessary (%{__rm}, %{__mv}, etc). Fedora is
not Mandriva.
This bit concerns me (slightly):
# These are already in %doc
%{__rm} $RPM_BUILD_ROOT%{_datadir}/openttd/data/COPYING
%{__rm} $RPM_BUILD_ROOT%{_datadir}/openttd/data/readme.txt
Are these really never used by OpenTTD? If so it's fine.
Otherwise this looks pretty clean (fairly uncomplicated data-only package).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478668] Review Request: lxmusic - Lightweight XMMS2 client with simple user interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478668 --- Comment #12 from Christoph Wickert fed...@christoph-wickert.de 2009-03-22 19:41:21 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487737] Review Request: slock - Simple X display locker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487737 --- Comment #10 from Pavel Shevchuk stl...@gmail.com 2009-03-22 19:54:31 EDT --- * Mon Mar 23 2009 Pavel Stalwart Shevchuk stl...@gmail.com - 0.9-4 - Replaced sed expressions with a patch Spec URL: http://rpm.scwlab.com/fedora/slock/slock.spec SRPM URL: http://rpm.scwlab.com/fedora/slock/slock-0.9-4.fc10.src.rpm Built RPMs for F10 i386 and x86_64: http://rpm.scwlab.com/fedora/slock/ Thank you for a patch, i didn't know $RPM_OPT_FLAGS is set in build environment -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491566] New: Review Request: powwow - A console MUD client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: powwow - A console MUD client https://bugzilla.redhat.com/show_bug.cgi?id=491566 Summary: Review Request: powwow - A console MUD client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ka...@smartlink.ee QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.smartlink.ee/~kalev/powwow.spec SRPM URL: http://www.smartlink.ee/~kalev/powwow-1.2.13-1.fc11.src.rpm Description: Powwow is a powerful console MUD client that supports triggers, aliases, multiple connections, and more. It is primarily designed for DikuMUDs, but nothing prevents its use for other types of MUDs. This client is also extensible through a plugin interface. This is my first package and I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491566] Review Request: powwow - A console MUD client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491566 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491566] Review Request: powwow - A console MUD client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491566 --- Comment #1 from Kalev Lember ka...@smartlink.ee 2009-03-22 20:01:48 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1253436 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491550] Review Request: libass - Portable library for SSA/ASS subtitles rendering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491550 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2009-03-22 20:06:55 EDT --- Full review: rpmlint clean: $ rpmlint /var/lib/mock//fedora-rawhide-x86_64/result libass-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 1 warnings. source matches upstream: $ md5sum libass-0.9.6.tar.bz2 libass-0.9.6.tar.bz2.orig 58d9fa08eedc27edae05b53288025370 libass-0.9.6.tar.bz2 58d9fa08eedc27edae05b53288025370 libass-0.9.6.tar.bz2.orig Builds fine in mock(devel/x86_64). Just one small issue: Redundant BuildRequires: glibc-devel (required by gcc, which is in exceptions) freetype-devel (required by fontconfig-devel) Other than that it's fine. This package is APPROVED. (But please fix the redundant BRs upon import.) I also encourage you to work with avidemux maintainer (in RPM Fusion) to unbundle its internal copy of libass. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491521 --- Comment #2 from Bojan Popović bojanpopo...@beotel.rs 2009-03-22 20:15:59 EDT --- Thanx you Alex. I'll check the warning and try to contact the current maintainer. Is tere any possibilty on getting this accepted as a backport then? 0.9.10 is due to be released soon (possibly month or two). Sorry if the question is a bit unfortunate, but I'm still new to Fedora package sumbiting system and I'm still not at ease with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452749] Review Request: ocp - Open Cubic Player for MOD/S3M/XM/IT/SID/MIDI music files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452749 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added Resolution|RAWHIDE |NEXTRELEASE --- Comment #17 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2009-03-22 20:16:15 EDT --- New package reviews should be closed as NEXTRELEASE after importing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214967] Review Request: arpack - Fortran77 subroutines for solving large scale eigenvalue problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=214967 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added Resolution|CURRENTRELEASE |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491521 --- Comment #3 from Bojan Popović bojanpopo...@beotel.rs 2009-03-22 20:21:39 EDT --- Btw, where can I check the cvs for F11? I looked here: http://cvs.fedoraproject.org/viewvc/rpms/hedgewars/ Doesn't seem to have any branch for F11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491550] Review Request: libass - Portable library for SSA/ASS subtitles rendering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491550 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|r...@greysector.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464781] Review Request: flexdock - Java docking UI element. First package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464781 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added Flag||needinfo?(my...@yahoo.com) --- Comment #42 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2009-03-22 20:22:06 EDT --- Could this package be moved to stable and the review bug closed as NEXTRELEASE? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462311] Review Request: raidutils - Utilities to manage Adaptec I2O compliant RAID controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462311 Dominik 'Rathann' Mierzejewski r...@greysector.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2009-03-22 20:25:05 EDT --- New Package CVS Request === Package Name: raidutils Short Description: Utilities to manage Adaptec I2O compliant RAID controllers Owners: rathann Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491521] Review Request: Hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491521 --- Comment #4 from Bojan Popović bojanpopo...@beotel.rs 2009-03-22 20:26:13 EDT --- I found it myself. :) http://cvs.fedoraproject.org/viewvc/devel/hedgewars/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462311] Review Request: raidutils - Utilities to manage Adaptec I2O compliant RAID controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462311 --- Comment #8 from Dominik 'Rathann' Mierzejewski r...@greysector.net 2009-03-22 20:26:42 EDT --- Thanks for the review. I've just reviewed libass (bug 491550). I'll fix the redundant builddep and look at the weak symbols issue too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489233] Review Request: rmol - C++ Revenue Management Optimisation Library (RMOL)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489233 --- Comment #5 from Denis Arnaud denis.arnaud_fed...@m4x.org 2009-03-22 21:01:50 EDT --- (In reply to comment #4) Thanks a lot! I eventually have integrated all those changes, and the updated packages are as follows: Spec URL: http://downloads.sourceforge.net/rmol/rmol.spec?use_mirror=ovh SRPM URL: http://downloads.sourceforge.net/rmol/rmol-0.19.0-1.fc10.src.rpm?use_mirror=ovh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
